#
3a797f36 |
|
03-Feb-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6656: Fix crash when WLAN is turned off Stop submitting urbs before calling usb_kill_urb() and usb_free_urb(). Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20220203192201.GA18509@matrix-ESPRIMO-P710 Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
e1e0ee8e |
|
27-Aug-2021 |
Aldas Taraškevičius <aldas60@gmail.com> |
staging: vt6656: Remove filenames in files checkpatch.pl warning: It's generally not useful to have the filename in the file Remove the filenames. Signed-off-by: Aldas Taraškevičius <aldas60@gmail.com> Link: https://lore.kernel.org/r/20210827163203.4100-1-aldas60@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
5f46e3cd |
|
27-May-2020 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: Move vnt_tx_usb_header to vnt_tx_context Move the USB element out of vnt_tx_packet and vnt_beacon_xmit to vnt_tx_context with sk_buff passed in parameters with the data now between skb->data and skb->len. The vnt_tx_usb header is moved from vnt_tx_buffer to usbpipe.h with the size added to extra_tx_headroom the largest possible size. The CONTEXT enums types are aligned with usb ones and CONTEXT_MGMT_PACKET is removed and is never be used. The skb_push in vnt_tx_packet is now only ever used with vnt_get_hdr_size with variables tx_bytes and tx_header_size removed. buf_len in vnt_usb_send_context is no longer used and replaced with urb->actual_length in vnt_tx_context_complete. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Link: https://lore.kernel.org/r/aa6257eb-1758-4e75-ab39-2a15ff6ffa7c@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
cf5ffd22 |
|
16-May-2020 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: use usb_anchor for tx queue. Use usb_anchor to track tx submitted urbs and initialize the urb as needed in vnt_tx_context. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Link: https://lore.kernel.org/r/077f42f8-4f7f-adc4-5a14-955165cef9f1@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
9786f8b2 |
|
16-May-2020 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: vnt_usb_send_context remove variable data. A limit is also placed in vnt_tx_context of MAX_TOTAL_SIZE_WITH_ALL_HEADERS limiting size. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Link: https://lore.kernel.org/r/9416e1a8-bd72-ffb1-5366-78361d053907@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
abfd2374 |
|
16-May-2020 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: Use sk_buff buffer for tx header mac80211 can provide space for the driver to put a tx header on the skb buffer instead coping the entire frame on to a local buffer with the header. To use this extra_tx_headroom must be set in mac80211 with the largest possible header which is struct vnt_tx_buffer. The driver has 8 possible combinations of tx header size which are found in vnt_get_hdr_size replacing vnt_mac_hdr_pos. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Link: https://lore.kernel.org/r/7b967bfc-1d4b-4b45-efab-d54f16cca226@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
2e11cc1a |
|
04-May-2020 |
Oscar Carter <oscar.carter@gmx.com> |
staging: vt6656: Use const for read only data Use const for the arrays that are used as "read only". Also, modify the prototype of vnt_control_out_blocks() function to use a pointer to a const type. The vnt_vt3184_al2230 array can't be converted to const as it's modified later. Then in the vnt_vt3184_init() function use two types of pointers (to const type and to no const type) to avoid the compiler warning: assignment discards 'const' qualifiers from pointer target type This way decrease the .data section and increase the .rodata section limiting the surface attack. Before this change: ------------------- drivers/staging/vt6656/baseband.o : section size addr .text 1278 0 .data 576 0 .bss 0 0 .rodata 319 0 .comment 45 0 .note.GNU-stack 0 0 .note.gnu.property 32 0 Total 2250 After this change: ------------------ drivers/staging/vt6656/baseband.o : section size addr .text 1278 0 .data 256 0 .bss 0 0 .rodata 640 0 .comment 45 0 .note.GNU-stack 0 0 .note.gnu.property 32 0 Total 2251 Signed-off-by: Oscar Carter <oscar.carter@gmx.com> Link: https://lore.kernel.org/r/20200504171414.11307-1-oscar.carter@gmx.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
d95c8695 |
|
01-May-2020 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: refactor power save operation At present the power save wake uses the listening interval and the slow path to wake up. The following using a beacon interval of 100 and listen interval of 5. The TBTT set at 100 wake-up sequence; 100 TBTT wake-up set to listen interval. 200 TBTT 300 TBTT 400 TBTT --> call vnt_next_tbtt_wakeup on slow path Beacon heard and passed through at the approx 500 interval. 500 TBTT 600 TBTT wake-up set to listen interval The TBTT set at 500 wake-up sequence and always listen flagged on; 100 No TBTT 200 No TBTT 300 No TBTT 400 No TBTT 500 TBTT - beacon heard and passed through 600 No TBTT A further enhancement because the TBTT is more precise the dtim_period can be used instead. When Power save is off the TBTT continues to run at the listen interval but all the other beacons are passed. The code in vnt_int_process_data is no longer required. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Link: https://lore.kernel.org/r/5a188bd8-7049-8063-f24d-96768ce9a6ed@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
986da7de |
|
01-May-2020 |
Malcolm Priestley <malcolmpriestley@gmail.com> |
staging: vt6656: Return on isr0 when zero. When isr0 is zero there is nothing more todo so return and pull following code in. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Link: https://lore.kernel.org/r/8dccc74d-d0bb-e8e7-df81-dfd81e3fd7d8@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
ea81c348 |
|
14-Apr-2020 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: Power save stop wake_up_count wrap around. conf.listen_interval can sometimes be zero causing wake_up_count to wrap around up to many beacons too late causing CTRL-EVENT-BEACON-LOSS as in. wpa_supplicant[795]: message repeated 45 times: [..CTRL-EVENT-BEACON-LOSS ] Fixes: 43c93d9bf5e2 ("staging: vt6656: implement power saving code.") Cc: stable <stable@vger.kernel.org> Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Link: https://lore.kernel.org/r/fce47bb5-7ca6-7671-5094-5c6107302f2b@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
696089de |
|
04-Mar-2020 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: struct vnt_rcb remove unused in_use. The variable merely toggles true to false and is unused. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Link: https://lore.kernel.org/r/130a4078-2502-a381-46c4-b473815e153b@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
d1ec1242 |
|
04-Mar-2020 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: Remove vnt_interrupt_buffer in_use flag. mac80211 is the only user of in_use to start it and should not be true when so. So internal toggling of this variable is not relevant. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Link: https://lore.kernel.org/r/69585034-4318-4bec-7d9b-f64a167df237@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
3c505f50 |
|
03-Mar-2020 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: Move vnt_rx_data to usbpipe.c vnt_rx_data is a USB function and vnt_submit_rx_urb_complete is the only caller therefore removing dpc.c/h files and becoming static. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Link: https://lore.kernel.org/r/d3937276-5a47-7184-e263-84d9c9cb5c7a@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
10e9a359 |
|
02-Mar-2020 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: Delete int.c/h file and move functions to usbpipe Move functions vnt_int_process_data and vnt_int_report_rate to usbpipe.c and vnt_interrupt_data to usbpipe.h These form part of the USB structure. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Link: https://lore.kernel.org/r/bc21d3d7-81be-4ec1-030e-4e7a45f98238@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
05f665dd |
|
02-Mar-2020 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: Remove function vnt_int_process_data. call vnt_start_interrupt_urb directly from vnt_start. Move debug message to vnt_start_interrupt_urb. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Link: https://lore.kernel.org/r/dff3a1d0-4d24-d9ea-2a15-c81fd544bc79@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
2812ab89 |
|
29-Feb-2020 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: Remove STATUS enums from TX path Returning standard error code or status variable. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Link: https://lore.kernel.org/r/21bf299b-63e0-9f65-c7db-6e0b72e0f1d8@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
747a64bd |
|
18-Jan-2020 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: Remove memory buffer from vnt_download_firmware. The memory buffer is being done twice here as vnt_control_out passes it straight to kmemdup. Remove buffer and add const to the variable in vnt_control_out to pass the pointer to it. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Link: https://lore.kernel.org/r/be025ed0-204d-e957-4bc9-963e841fcb2c@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
69cc1f92 |
|
20-Dec-2019 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: limit reg output to block size vnt_control_out appears to fail when BBREG is greater than 64 writes. Create new function that will relay an array in no larger than the indicated block size. It appears that this command has always failed but was ignored by driver until the introduction of error checking. Cc: stable <stable@vger.kernel.org> # v5.3+ Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Link: https://lore.kernel.org/r/a41f0601-df46-ce6e-ab7c-35e697946e2a@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
58c3e681 |
|
20-Dec-2019 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: Fix non zero logical return of, usb_control_msg Starting with commit 59608cb1de1856 ("staging: vt6656: clean function's error path in usbpipe.c") the usb control functions have returned errors throughout driver with only logical variable checking. However, usb_control_msg return the amount of bytes transferred this means that normal operation causes errors. Correct the return function so only return zero when transfer is successful. Cc: stable <stable@vger.kernel.org> # v5.3+ Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Link: https://lore.kernel.org/r/08e88842-6f78-a2e3-a7a0-139fec960b2b@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
44a22dc3 |
|
15-Jul-2019 |
Benjamin Sherman <benjamin@bensherman.io> |
staging: vt6656: change alignment to match parenthesis Change indentation to match parentheses. This complies with the Linux kernel coding style and improves readability. Signed-off-by: Benjamin Sherman <benjamin@bensherman.io> Link: https://lore.kernel.org/r/20190716045754.fivh5n44bybe2uce@valkyrie-mobile.localdomain Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
59608cb1 |
|
20-May-2019 |
Quentin Deslandes <quentin.deslandes@itdev.co.uk> |
staging: vt6656: clean function's error path in usbpipe.c Avoid discarding called function's returned value. Store it instead in order to act accordingly. Update error path to return 0 on success and a negative errno value on error. Signed-off-by: Quentin Deslandes <quentin.deslandes@itdev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
b79f3f68 |
|
12-Feb-2018 |
Dileep Sankhla <sankhla.dileep96@gmail.com> |
staging: vt6656: Remove unnecessary 'out of memory' message This patch removes the unnecessary out of memory message fixing the following checkpatch.pl warning in usbpipe.c: WARNING: Possible unnecessary 'out of memory' message Signed-off-by: Dileep Sankhla <sankhla.dileep96@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
dd41dab5 |
|
07-Nov-2017 |
Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
staging: vt6656: Remove redundant license text Now that the SPDX tag is in all vt6656 files, that identifies the license in a specific and legally-defined manner. So the extra GPL text wording can be removed as it is no longer needed at all. This is done on a quest to remove the 700+ different ways that files in the kernel describe the GPL license text. And there's unneeded stuff like the address (sometimes incorrect) for the FSF which is never needed. No copyright headers or other non-license-description text was removed. Cc: Forest Bond <forest@alittletooquiet.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
6b4c6ce8 |
|
07-Nov-2017 |
Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
staging: vt6656: add SPDX identifiers to all vt6656 driver files It's good to have SPDX identifiers in all files to make it easier to audit the kernel tree for correct licenses. Update the vt6656 driver files with the correct SPDX license identifier based on the license text in the file itself. The SPDX identifier is a legally binding shorthand, which can be used instead of the full boiler plate text. This work is based on a script and data from Thomas Gleixner, Philippe Ombredanne, and Kate Stewart. Cc: Forest Bond <forest@alittletooquiet.net> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Kate Stewart <kstewart@linuxfoundation.org> Cc: Philippe Ombredanne <pombredanne@nexb.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
3781f887 |
|
30-Jun-2017 |
Simon Sandström <simon@nikanor.nu> |
staging: vt6656: Align function parameters Fixes checkpatch.pl warnings "Alignment should match open parenthesis". Signed-off-by: Simon Sandström <simon@nikanor.nu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
05c0cf88 |
|
22-Apr-2017 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: use off stack for in buffer USB transfers. Since 4.9 mandated USB buffers to be heap allocated. This causes the driver to fail. Create buffer for USB transfers. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Cc: <stable@vger.kernel.org> # v4.9+ Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
12ecd24e |
|
22-Apr-2017 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: use off stack for out buffer USB transfers. Since 4.9 mandated USB buffers be heap allocated this causes the driver to fail. Since there is a wide range of buffer sizes use kmemdup to create allocated buffer. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Cc: <stable@vger.kernel.org> # v4.9+ Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
1ce08c27 |
|
25-Feb-2017 |
Jitendra Kumar Khasdev <jkhasdev@gmail.com> |
Staging: vt6656: Fix spaces and char limit This is a patch to usbpipe.c to fix space and char limit warning found by checkpatch tool. Signed-off-by: Jitendra Khasdev <jkhasdev@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
81293066 |
|
14-Feb-2017 |
Arushi Singhal <arushisinghal19971997@gmail.com> |
staging: vt6656: Alignment should match open parenthesis Fix checkpatch issues: "CHECK: Alignment should match open parenthesis" Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
3b1d7533 |
|
22-Aug-2016 |
Anson Jacob <ansonjacob.aj@gmail.com> |
staging: vt6656: usbpipe.c: Fix checkpatch warning Fix checkpatch.pl warning for line over 80 characters Signed-off-by: Anson Jacob <ansonjacob.aj@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
7aa47db9 |
|
17-Feb-2016 |
Alison Schofield <amsfield22@gmail.com> |
staging: vt6656: simplify tests of successful urb status Use if (status) in tests for successful urb status. This replaces (status != 0) and (status == STATUS_SUCCESS). (STATUS_SUCCESS is defined for NDIS status in this driver, but was being misused) Signed-off-by: Alison Schofield <amsfield22@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
b9183fdd |
|
12-Feb-2016 |
Alison Schofield <amsfield22@gmail.com> |
staging: vt6656: move local var init into declaration Improve readability by initializing local variables at declaration. In one instance, vnt_start_interrupt_urb_complete(), also use that local variable in subsequent switch. Signed-off-by: Alison Schofield <amsfield22@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
27f31cf9 |
|
11-Feb-2016 |
Alison Schofield <amsfield22@gmail.com> |
staging: vt6656: replace explicit NULL comparison with ! operator Replace explicit NULL comparison with ! operator to simplify code. Found with Coccinelle: @@ expression e; statement s0, s1; @@ if ( ( + ! e - == NULL || ... ) ) s0 else s1 Signed-off-by: Alison Schofield <amsfield22@gmail.com> Acked-by: Julia Lawall <julia.lawall@lip6.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
a85994d5 |
|
16-Nov-2015 |
Othmar Pasteka <pasteka@kabsi.at> |
staging: vt6656: remove address from GPL text Cleanup errors from checkpatch.pl. Signed-off-by: Othmar Pasteka <pasteka@kabsi.at> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
56b4c049 |
|
27-Sep-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: remove RX complete locking. The lock in vnt_submit_rx_urb_complete is blocked by TX activity. The lock comes from a time when RX needed to be synchronized with other parts of the driver because the WLAN API was in driver. Since this is now dealt with in mac80211 the lock is unnecessary. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
5699c0f4 |
|
15-Jun-2015 |
Abdul Hussain <habdul@visteon.com> |
staging: vt6656: Boolean tests don't need comparisons. This patch remove true and false from boolean tests. Signed-off-by: Abdul Hussain <habdul@visteon.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
86140346 |
|
10-Aug-2014 |
Ragnar B. Johannsson <ragnar@igo.is> |
staging: vt6656: remove unnecessary braces Removes unnecessary braces to comply with coding style. Signed-off-by: Ragnar B. Johannsson <ragnar@igo.is> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
a8492a0b |
|
25-Jul-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: remove comments of old functions nolonger present. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
d78551b9 |
|
25-Jul-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: remove return from all void functions Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
cbcc9a36 |
|
24-Jul-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: use test_bit to check flags status Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
2746321e |
|
24-Jul-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: struct vnt_private merge flag and macros merge u32 flag into unsigned long Flags Replacing fMP_DISCONNECTED with DEVICE_FLAGS_DISCONNECTED Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
f370872f |
|
24-Jul-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: remove macro MP_IS_READY Just test FLag and remove not. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
b679ad2f |
|
24-Jul-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: Remove flags fMP_POST_READS and fMP_POST_WRITES MP_IS_READY(fMP_DISCONNECTED) is used to block thread in vnt_tx_context Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
b2435179 |
|
21-Jul-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: usbpipe.c clean up USB_CTL_WAIT Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
0acece05 |
|
21-Jul-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: usbpipe remove unneeded comments We know what the endpoints are Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
4060f53c |
|
21-Jul-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: Remove ununsed macro URB_ASYNC_UNLINK Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
664b044b |
|
21-Jul-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: remove static declaration vnt_tx_context_complete Moving vnt_tx_context in visibility of vnt_tx_context_complete Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
93eac3b1 |
|
21-Jul-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: Remove static declaration vnt_submit_rx_urb_complete Moving vnt_submit_rx_urb in visibility of vnt_submit_rx_urb_complete Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
eaa56792 |
|
21-Jul-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: Remove static declaration vnt_start_interrupt_urb_complete Moving vnt_start_interrupt_urb in visibility of vnt_start_interrupt_urb_complete Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
3d582487 |
|
17-Jul-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: struct vnt_private pInterruptURB rename to interrupt_urb Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
325de984 |
|
17-Jul-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: struct vnt_rcb remove camel case Camel case changes pDevice -> priv pUrb -> urb bBoolInUse -> in_use Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
23dbf877 |
|
17-Jul-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: struct vnt_rcb remove unused members Remove Next and Ref Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
f24937db |
|
15-Jul-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: usbpipe irrelevant function descriptions All these have no or vague meaning. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
08823af4 |
|
15-Jul-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: rename s_nsBulkInUsbIoCompleteRead to vnt_submit_rx_urb_complete Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
2dc37af0 |
|
15-Jul-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: rename PIPEnsBulkInUsbRead to vnt_submit_rx_urb The function just submits to rx urbs. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
ceebd903 |
|
15-Jul-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: rename s_nsBulkOutIoCompleteWrite to vnt_tx_context_complete Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
476e7d97 |
|
15-Jul-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: rename PIPEnsSendBulkOut to vnt_tx_context. We are just tx the context Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
34f98e3f |
|
15-Jul-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: rename s_nsInterruptUsbIoCompleteRead to vnt_start_interrupt_urb_complete Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
b0bc5724 |
|
15-Jul-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: usbpipe rename PIPEnsInterruptRead to vnt_start_interrupt_urb Drop Read and PIPE. The function starts the interrupt urb. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
e360d2b8 |
|
15-Jul-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: int rename INTnsProcessData to vnt_int_process_data Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
618ff9ce |
|
06-Jul-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: s_nsBulkInUsbIoCompleteRead check that used sk_buff is clean and ready to reuse. skb_push the headroom and trimmed back to 0 Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
71d764ae |
|
05-Jul-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
stagingL vt6656: implement fall back rates reporting. The driver reports the rate tried in struct vnt_interrupt_data tsr* variables which is available in INTnsProcessData via interrupt urb context. Instead of closing apTD tx context in s_nsBulkOutIoCompleteWrite by setting in_use to false. Keep the context open and allow vnt_int_report_rate to close it. If the tx_retry value is correct it will report back the sucessful RATE tried. struct vnt_usb_send_context add pkt_no which is index of apTD Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
f5283274 |
|
05-Jul-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: Include re_alloc_skb within lock. Remove variable re_alloc_skb and merge code within urb->actual_length. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
a5615b97 |
|
29-Jun-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: s_nsBulkOutIoCompleteWrite fix bug of 5GHZ a rates idx On 2GHz band the values of wCurrentRate match the idx rates. However, on 5GHz they do not because in channel.c vnt_rates_a do not match idx. Instead use the info->control.rates[0].idx the value that was tried. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
8cffb3cf |
|
28-Jun-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: Remove rx handing from RXvWorkItem In s_nsBulkInUsbIoCompleteRead reuse or reallocate sb_buff and resubmit urb. In device_alloc_bufs allocate memory to rcb individually and call PIPEnsBulkInUsbRead to submit the urbs Change handling to free rcb in device_free_rx_bufs Remove calls to workqueue. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
09840eb6 |
|
25-Jun-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: device.h remove dead strutures and variables Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
d38b13aa |
|
25-Jun-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: mac80211 conversion: Create tx functions Create vnt_fill_txkey as mac80211 replacement for s_vFillTxKey. Create vnt_tx_packet which a merger of s_bPacketToWirelessUsb, nsDMA_tx_packet and csMgmt_xmit using mac80211 signalling. Create vnt_beacon_xmit as mac80211 replacement for csBeacon_xmit. Changing header in vnt_beacon_buffer to struct ieee80211_mgmt deleting some of old code. vnt_beacon_make is needed to make beacon for vnt_beacon_xmit. Create vnt_beacon_enable as mac80211 call to enable beacon. vnt_fill_ieee80211_rts is modified to use struct ieee80211_hdr instead of struct ethhdr and access to tx_context. In s_nsBulkOutIoCompleteWrite modify context handling Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
63b9907f |
|
25-Jun-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: mac80211 conversion: create rx function. Add mac80211 header and depends. Create new function vnt_rx_data to receive 80211 packets which is based on RXbBulkInProcessData and rx them into mac80211 The function also relays dbm, tsf_time(as mactime) and sets byBBPreEDRSSI and uCurrRSSI. skb is modified slightly to skb_put the maxium tail room in PIPEnsBulkInUsbRead and trim back in vnt_rx_data. dev_alloc_skb is used to reallocate the sk_buff. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
62c8526d |
|
26-May-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: dead code remove control.c/h Replace control.h headers with usbpipe.h Also add to usbpipe.c its header Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
53742906 |
|
26-May-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: create vnt_control_in_u8 to replace ControlvReadByte ControlvReadByte will be removed in next patch Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
285d58c4 |
|
26-May-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: replace ControlvWriteByte with vnt_control_out_u8 add new function in usbpipe.c to replace ControlvWriteByte Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
441c21c3 |
|
26-May-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: rename PIPEnsControlIn/CONTROLnsRequestIn with vnt_control_in Replace all to CONTROLnsRequestIn with vnt_control_in and remove macro. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
1390b02a |
|
26-May-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: rename PIPEnsControlOut/CONTROLnsRequestOut to vnt_control_out Rename all CONTROLnsRequestOut and remove macro from control.h Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
9af49fdb |
|
17-May-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: PIPEnsControlIn remove camel case. Camel case changes pDevice, byRequest, wValue, wIndex, wLength, pbyBuffer, ntStatus -> priv, request, value, index, length, buffer, status Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
0f06a739 |
|
17-May-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: PIPEnsControlOut remove camel case. Camel case changes pDevice, byRequest, wValue, wIndex, wLength, pbyBuffer, ntStatus -> priv, request, value, index, length, buffer, status Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
8a660261 |
|
17-May-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: usbpipe: replace debug messsages. Replace all DBG_PRT wiht dev_dbg Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
f347d8cb |
|
17-May-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: usbpipe: get rid of in/out debug messages. Remove all in/out debug messages. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
3136b5fe |
|
15-May-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: Remove PIPEnsControlOutAsyn/CONTROLnsRequestOutAsyn This now the same as PIPEnsControlOut. Replace with PIPEnsControlOut/CONTROLnsRequestOut. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
0fb2af35 |
|
15-May-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: PIPEnsControlIn use usb_control_msg Now that this function is nolonger atomic useusb_control_msg. Return STATUS_FAILURE if ntStatus less than wLength Remove the old struct urb and struct usb_ctrlrequest structures. Remove fMP_CONTROL_READS flag. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
7021b684 |
|
15-May-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: usbpipe.c PIPEnsControlOut use usb_control_msg Now that this fucntion is nolonger atomic change to usb_control_msg Return STATUS_FAILURE if ntStatus less than wLength. Remove fMP_CONTROL_WRITES flag Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
29b02373 |
|
15-May-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: lock changes: s_nsBulkInUsbIoCompleteRead. Use spin_lock_irqsave/spin_unlock_irqrestore Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
c91b1869 |
|
15-May-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: lock changes: usbpipe.c add mutex lock. PIPEnsControlOut and PIPEnsControlIn are nolonger atomic but they do need a usb lock. Add new mutex lock for these functions and PIPEnsControlOutAsyn. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
7af94000 |
|
15-May-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: lock changes: Remove spin locks. Remove atomic paths to usbpipe.c PIPEnsControlOut and PIPEnsControlIn Remove from PIPEnsControlOut PIPEnsControlIn BSSvSecondCallBack vt6656_hostap_ioctl iwctl_siwmode iwctl_siwencode iwctl_siwpower iwctl_siwencodeext KeyvInitTable device_init_registers device_open device_close Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
30a05b39 |
|
15-May-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: struct vnt_usb_send_context remove camel case. Camel case changes pDevice -> priv pPacket -> skb pUrb -> urb uBufLen -> buf_len; bBoolInUse -> in_use Data -> data Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
b9d93d1c |
|
15-Mar-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: [BUG] Fix Warning BOGUS urb xfer, pipe 3 != type 1 Stable kernels will need patches staging: vt6656: s_nsInterruptUsbIoCompleteRead remove usb_fill_bulk_urb staging: vt6656: PIPEnsInterruptRead use usb_fill_int_urb and a backported version of this patch. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
9009dd16 |
|
12-Mar-2014 |
Iulia Manda <iulia.manda21@gmail.com> |
staging: vt6656: Use __releases/__acquires annotations This patch fixes the following sparse warnings: drivers/staging/vt6656/usbpipe.c:147:24: warning: context imbalance in 'PIPEnsControlOut' - unexpected unlock drivers/staging/vt6656/usbpipe.c:209:24: warning: context imbalance in 'PIPEnsControlIn' - unexpected unlock Signed-off-by: Iulia Manda <iulia.manda21@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
|
#
d1b2a11d |
|
27-Feb-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: s_nsBulkOutIoCompleteWrite Remove variable status. Remove status and move debug messages to switch statement. Remove duplicate second debug message. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
d597aaef |
|
27-Feb-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: s_nsBulkOutIoCompleteWrite remove buf_len. Use context->uBufLen directly which is unsigned int. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
07bc8398 |
|
27-Feb-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: Remove unused variables packets* These variables are unused and don't reach user. Remove them all. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
cbe4da53 |
|
27-Feb-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: Remove unused variable bEventAvailable. Flips from true to false but does nothing. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
7e5a9193 |
|
27-Feb-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: Remove all variables ulInt* None of these variables reach user or used by debug messages. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
88c4d12c |
|
27-Feb-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: Remove all variables ulBulk* None of these variables reach user or in any debug messages. Remove them all. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
599e4b5c |
|
25-Feb-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: Remove pointer cast to urb->context. Remove unnecessary cast to void * urb->context Reported-by: Joe Perches <joe@perches.com> Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
0b787d71 |
|
25-Feb-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: Cleanup PIPEnsBulkInUsbRead Remove camel case and white space. Camel case changes pDevice -> priv pRCB -> rcb ntStatus -> status pUrb -> urb Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
d4fa2ab0 |
|
25-Feb-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: clean up s_nsBulkInUsbIoCompleteRead Clean up white space and camel case. Camel case changes pDevice -> priv pRCB -> rcb bReAllocSkb -> re_alloc_skb Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
67638980 |
|
25-Feb-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: s_nsBulkInUsbIoCompleteRead Replace error handling. Use switch on urb->status Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
1882c19c |
|
25-Feb-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: s_nsBulkInUsbIoCompleteRead Remove bytesRead/bIndicateReceive. Replace with urb->actual_length. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
e3a8fa17 |
|
25-Feb-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: s_nsBulkInUsbIoCompleteRead get rid of status. Just use urb->status directly. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
3f38290e |
|
25-Feb-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: clean up PIPEnsSendBulkOut. Remove commented out code, white space and camel case. camel case changes pDevice -> priv pContext -> context pUrb -> urb Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
da5c99fd |
|
25-Feb-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: usb_fill_bulk_urb get rid of void* cast. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
13338303 |
|
25-Feb-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: PIPEnsSendBulkOut reverse if statement Get rid of unnessary else statement by !(MP_IS_READY(pDevice) && pDevice->Flags & fMP_POST_WRITES) Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
1450ba62 |
|
19-Feb-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: Remove typedef enum _CONTEXT_TYPE Replace with enum assign as u8 type. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
21aa212c |
|
19-Feb-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: clean up s_nsBulkOutIoCompleteWrite. Remove commented out, white space and camel case. Camel case changes pContext -> context pDevice -> priv ContextType -> context_type ulBufLen -> buf_len Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
e8152bfb |
|
19-Feb-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: s_nsBulkOutIoCompleteWrite add error handling, change pContext->bBoolInUse to false on connection errors. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
1c398a38 |
|
19-Feb-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: s_nsBulkOutIoCompleteWrite reorganise variable order. Declare in order of pointer use. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
f764e00d |
|
19-Feb-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: Replace typedef struct INT_BUFFER, *PINT_BUFFER Replace with struct vnt_interrupt_buffer. Using only the live member of old structure pDataBuf -> data_buf bInUse -> in_use uDataLen is unused and dropped. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
5f38b783 |
|
19-Feb-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: clean up PIPEnsInterruptRead. Remove comments, white space and camel case. Camel case changes pDevice -> priv ntStatus -> status Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
59858f5e |
|
19-Feb-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: PIPEnsInterruptRead set intBuf.bInUse to false. set intBuf.bInUse to false on return error. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
f39b8534 |
|
19-Feb-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: PIPEnsInterruptRead use usb_fill_int_urb Change to usb_fill_int_urb which has int_interval. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
d9ad7a98 |
|
17-Feb-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: clean up s_nsInterruptUsbIoCompleteRead Remove comments, white space and camel case Camel Case changes pDevice -> priv ntStatus -> status Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
749627f2 |
|
17-Feb-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: Remove variable fKillEventPollingThread We already kill the urb and since patch s_nsInterruptUsbIoCompleteRead add urb status returns. have error handling There is no need for this variable. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
def84bd9 |
|
17-Feb-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: s_nsInterruptUsbIoCompleteRead remove usb_fill_bulk_urb No need to fill urb in again, just resubmit it. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
c98fbf90 |
|
17-Feb-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: s_nsInterruptUsbIoCompleteRead add urb status returns Drop out of urb return on usb errors and set intBuf.bInUse to false. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
247b4b68 |
|
17-Feb-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: s_nsInterruptUsbIoCompleteRead set intBuf.bInUse to true intBuf.bInUse is set to false set back to true on successful usb_submit_urb Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
1fd4f55b |
|
11-Dec-2013 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: Remove unused scStatistic data/functions from driver. None of these stats reach user. So delete them from driver mib.c and mib.h becomes dead code as result of this patch. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
e1feda13 |
|
14-Oct-2013 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: return if pControlURB->hcpriv not NULL Fixes occasional urb submitted while active. Even thought the fMP_CONTROL_WRITES/fMP_CONTROL_READS flags are cleared in the return context urb->hcpriv is not NULL. check for hcpriv and return STATUS_FAILURE if not NULL. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
60cc2747 |
|
14-Oct-2013 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: Remove 10 second timer and move to BSSvSecondCallBack Remove sTimerTxData 10 second timer which triggers PSbSendNullPacket every 40 seconds when bLinkPass == true. Move the 40 second timer to the existing BSSvSecondCallBack one second delayed workqueue and trigger every 40 seconds when bLinkPass == true. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
115cac2e |
|
28-Aug-2013 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: device.h Replace typedef struct _RCB Replace with struct vnt_rcb Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
dcdf1d03 |
|
26-Aug-2013 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: device.h replace typedef struct _USB_SEND_CONTEXT. Replace with struct vnt_usb_send_context. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
8dbc6aa0 |
|
23-Jul-2013 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: Remove dead code macro ASSERT ASSERT is always defined as empty macro because VIAWET_DEBUG is never defined. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
9fbafdd9 |
|
26-Mar-2013 |
Andres More <more.andres@gmail.com> |
staging: vt6656: remove consecutive newlines Several sed -i '/^$/{ N /^\n$/ D }' drivers/staging/vt6656/*.[ch] Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
00d0603c |
|
18-Mar-2013 |
Andres More <more.andres@gmail.com> |
staging: vt6656: remove code placeholders Removed comments from coding template. sed -i '/^\/\*---/d' drivers/staging/vt6656/*.[ch] Signed-off-by: Andres More <more.andres@gmail.com> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
4e9b5e2b |
|
12-Feb-2013 |
Andres More <more.andres@gmail.com> |
staging: vt6656: replaced custom TRUE definition with true Checkpatch findings were not resolved, just direct replacement. sed -i 's/\bTRUE\b/true/g' drivers/staging/vt6656/*.[ch] Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
e269fc2d |
|
12-Feb-2013 |
Andres More <more.andres@gmail.com> |
staging: vt6656: replaced custom FALSE definition with false Checkpatch findings were not resolved, just direct replacement. sed -i 's/\bFALSE\b/false/g' drivers/staging/vt6656/*.[ch] Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
ae5943de |
|
30-Jan-2013 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: Fix URB submitted while active warning. This error happens because PIPEnsControlOut and PIPEnsControlIn unlock the spin lock for delay, letting in another thread. The patch moves the current MP_SET_FLAG to before filling of sUsbCtlRequest for pControlURB and clears it in event of failing. Any thread calling either function while fMP_CONTROL_READS or fMP_CONTROL_WRITES flags set will return STATUS_FAILURE. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Cc: stable@vger.kernel.org # 3.8 Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
fe5d00eb |
|
10-Dec-2012 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: channel/control/firmware/int/usbpipe to new structures This patch cleans up function declarations, definitions and local variables where appropriate replacing types defined in "ttype.h" with linux/types.h. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
87c62985 |
|
04-Nov-2012 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: no need to bIndicateReceive when no bytes to read. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
02560efe |
|
12-Oct-2012 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6656: [BUG] PIPEnsSendBulkOut free bBoolInUse Eventually, when there is enough errors we run out of free TX urbs and connection stalls. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
1acc0d62 |
|
08-Jul-2012 |
Marcos Paulo de Souza <marcos.souza.org@gmail.com> |
staging: vt6656: Remove all commented macros These macros were reported by forgotten-macros tool (https://github.com/marcosps/forgotten_macros). Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
731047f9 |
|
05-Aug-2010 |
Andres More <more.andres@gmail.com> |
staging: vt6656: removed macro to test bits Removed custom macro used to test bits. Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
27264fb8 |
|
05-Aug-2010 |
Andres More <more.andres@gmail.com> |
staging: vt6656: removed NDIS_STATUS int redefinition Removed int redefinition for function results. Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
6487c49e |
|
02-Aug-2010 |
Andres More <more.andres@gmail.com> |
staging: vt6656: removed NTSTATUS definition Replaced NTSTATUS with int, as defined in a couple of places. Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
8efe1ab3 |
|
12-Jul-2010 |
Andres More <more.andres@gmail.com> |
staging: vt6656: removed Calcu_LinkQual definition Removed an always defined macro, perhaps used to patch the driver Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
68746744 |
|
12-Jul-2010 |
Andres More <more.andres@gmail.com> |
staging: vt6656: removed Safe_Close definition Removed an always defined macro, perhaps used to patch the driver Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
feaf03d3 |
|
25-Jun-2010 |
Andres More <more.andres@gmail.com> |
staging: vt6656: removed TxInSleep definition Removed an always defined macro, perhaps used to patch the driver Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
2a1a1749 |
|
21-Jun-2010 |
Andres More <more.andres@gmail.com> |
Staging: vt6656: removed '#if 0' definitions Removed code in .c files that was being skipped by the preprocessor Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
cc856e61 |
|
17-May-2010 |
Andres More <more.andres@gmail.com> |
Staging: vt6656: removed custom UCHAR/USHORT/UINT/ULONG/ULONGLONG typedefs Cleared all checkpatch warnings but 'do not add new typedefs' ones. Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
6f8c13c7 |
|
04-May-2010 |
Andres More <more.andres@gmail.com> |
Staging: vt6656: code cleanup, removed OUT definition Remoted empty OUT define in ttype.h and its usage across the code. Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
8611a29a |
|
01-May-2010 |
Andres More <more.andres@gmail.com> |
Staging: vt6656: removed VOID/PVOID definitions Warnings about the usage of externs in .c files were not resolved here. Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
592ccfeb |
|
16-Apr-2010 |
Andres More <more.andres@gmail.com> |
Staging: vt6656: Removed IN definition Code cleanup, removed empty IN definition used to denote input parameters. Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
bfbfeecc |
|
24-Mar-2010 |
Joe Perches <joe@perches.com> |
Staging: vt6656: Hoist assign from if Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
dad72fed |
|
12-Aug-2009 |
Jim Lieb <lieb@canonical.com> |
Staging: vt665x: cleanup USB definitions Remove gratuitous macros re-defining usb functions. One result is to make kcompat.h now identical in both driver dirs Signed-off-by: Jim Lieb <lieb@canonical.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
3e362598 |
|
12-Aug-2009 |
Jim Lieb <lieb@canonical.com> |
Staging: vt665x: Remove umem.h Part 2 Remove references to umem.h macros and refer directly to memcpy functions. Delete the include file. Signed-off-by: Jim Lieb <lieb@canonical.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
9d26d60f |
|
12-Aug-2009 |
Jim Lieb <lieb@canonical.com> |
Staging: vt665x: Clean up include files, Part 1 Remove cplusplus lines from include files Remove needless ifdefs on includes to conform with C conventions. Remove misc commented code/includes Update TODO Signed-off-by: Jim Lieb <lieb@canonical.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
193a823c |
|
12-Aug-2009 |
Jim Lieb <lieb@canonical.com> |
Staging: vt665x: Typedef and macro cleanup Part 1 Clean up unused typedefs and macros to remove Win32'isms and misc non-linux constructs. Text edits to referencing source for less frequently used macros. Signed-off-by: Jim Lieb <lieb@canonical.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
edb3a950 |
|
02-Jul-2009 |
Alexander Beregalov <a.beregalov@gmail.com> |
Staging: vt6656: remove dependency on kernel version Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com> Acked-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
92b96797 |
|
13-Jun-2009 |
Forest Bond <forest@alittletooquiet.net> |
Staging: Add pristine upstream vt6656 driver sources to drivers/staging/vt6656. Add pristine upstream vt6656 driver sources to drivers/staging/vt6656. These files were copied from the driver directory in the upstream source archive, available here: http://www.viaarena.com/Driver/VT6656_Linux_src_v1.19_12_x86.zip After copying, trailing whitespace was stripped. This is GPL-licensed code. Signed-off-by: Forest Bond <forest@alittletooquiet.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|