#
6092077a |
|
29-Jan-2024 |
Johannes Berg <johannes.berg@intel.com> |
wifi: mac80211: introduce 'channel request' For channel contexts, mac80211 currently uses the cfg80211 chandef struct (control channel, center freq(s), width) to define towards drivers and internally how these behave. In fact, there are _two_ such structs used, where the min_def can reduce bandwidth according to the stations connected. Unfortunately, with EHT this is longer be sufficient, at least not for all hardware. EHT requires that non-AP STAs that are connected to an AP with a lower bandwidth than it (the AP) advertises (e.g. 160 MHz STA connected to 320 MHz AP) still be able to receive downlink OFDMA and respond to trigger frames for uplink OFDMA that specify the position and bandwidth for the non-AP STA relative to the channel the AP is using. Therefore, they need to be aware of this, and at least for some hardware (e.g. Intel) this awareness is in the hardware. As a result, use of the "same" channel may need to be split over two channel contexts where they differ by the AP being used. As a first step, introduce a concept of a channel request ('chanreq') for each interface, to control the context it requests. This step does nothing but reorganise the code, so that later the AP's chandef can be added to the request in order to handle the EHT case described above. Link: https://msgid.link/20240129194108.2e88e48bd2e9.I4256183debe975c5ed71621611206fdbb69ba330@changeid Signed-off-by: Johannes Berg <johannes.berg@intel.com>
|
#
0a44dfc0 |
|
29-Jan-2024 |
Johannes Berg <johannes.berg@intel.com> |
wifi: mac80211: simplify non-chanctx drivers There are still surprisingly many non-chanctx drivers, but in mac80211 that code is a bit awkward. Simplify this by having those drivers assign 'emulated' ops, so that the mac80211 code can be more unified between non-chanctx/chanctx drivers. This cuts the number of places caring about it by about 15, which are scattered across - now they're fewer and no longer in the channel context handling. Link: https://msgid.link/20240129194108.6d0ead50f5cf.I60d093b2fc81ca1853925a4d0ac3a2337d5baa5b@changeid Signed-off-by: Johannes Berg <johannes.berg@intel.com>
|
#
84353aee |
|
30-Oct-2023 |
Pavan Bobba <opensource206@gmail.com> |
staging: vt6655: Type encoding info dropped from variable name "apTailTD" variable name "apTailTD" updated like below: a.type encoding info dropped from name b.camelcase name replaced by snakecase Issue found by checkpatch Signed-off-by: Pavan Bobba <opensource206@gmail.com> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/482553f089fe86dc7ebecd96c9397cfaa9c7bdf9.1698730318.git.opensource206@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
157327d0 |
|
30-Oct-2023 |
Pavan Bobba <opensource206@gmail.com> |
staging: vt6655: Type encoding info dropped from function name "CARDvSafeResetTx" function name "CARDvSafeResetTx" updated like below: a.type encoding info dropped from name b.camelcase name replaced by snakecase Issue found by checkpatch Signed-off-by: Pavan Bobba <opensource206@gmail.com> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/785a163ab01555bd0a7ed87484d727560d22cd95.1698730318.git.opensource206@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
ac491ce1 |
|
30-Oct-2023 |
Pavan Bobba <opensource206@gmail.com> |
staging: vt6655: Type encoding info dropped from function name "CARDbRadioPowerOff" function name "CARDbRadioPowerOff" updated like below: a.type encoding info dropped from name b.camelcase name replaced by snakecase Issue found by checkpatch Signed-off-by: Pavan Bobba <opensource206@gmail.com> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/5b264db5a6d5ac936e02f0a7f465e648504a049e.1698730318.git.opensource206@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
b6f0032e |
|
30-Oct-2023 |
Pavan Bobba <opensource206@gmail.com> |
staging: vt6655: Type encoding info dropped from function name "CARDbSetBeaconPeriod" function name "CARDbSetBeaconPeriod" updated like below: a.type encoding info dropped from name b.camelcase name replaced by snakecase Issue found by checkpatch Signed-off-by: Pavan Bobba <opensource206@gmail.com> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/8d4c10ac86f80bb46d5cb1f18079276c3326e5dd.1698730318.git.opensource206@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
3b9325d8 |
|
27-Oct-2023 |
Pavan Bobba <opensource206@gmail.com> |
staging: vt6655: Type encoding info dropped from function name "CARDbUpdateTSF" function name "CARDbUpdateTSF" updated like below: a.type encoding info dropped from name b.camelcase name replaced by snakecase Issue found by checkpatch Signed-off-by: Pavan Bobba <opensource206@gmail.com> Link: https://lore.kernel.org/r/926ec04bbfc69926cd1af92684fef392f2d6e04a.1698396278.git.opensource206@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
956ab42b |
|
27-Oct-2023 |
Pavan Bobba <opensource206@gmail.com> |
staging: vt6655: Type encoding info dropped from variable name "byPacketType" variable name "byPacketType" updated like below: a.type encoding info dropped from name b.camelcase name replaced by snakecase Issue found by checkpatch Signed-off-by: Pavan Bobba <opensource206@gmail.com> Link: https://lore.kernel.org/r/308813545f9364da18dfc3cdb051ed59eca18f7f.1698396278.git.opensource206@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
4922f5d1 |
|
27-Oct-2023 |
Pavan Bobba <opensource206@gmail.com> |
staging: vt6655: Type encoding info dropped from function name "CARDbSetPhyParameter" function name "CARDbSetPhyParameter" updated like below: a.type encoding info dropped from name b.camelcase name replaced by snakecase Issue found by checkpatch Signed-off-by: Pavan Bobba <opensource206@gmail.com> Link: https://lore.kernel.org/r/66beb307ac7983b2aa82fa81f6f2362353209859.1698396278.git.opensource206@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
30953504 |
|
16-Oct-2023 |
Gilbert Adikankwu <gilbertadikankwu@gmail.com> |
staging: vt6655: Rename variable byCurPwr Remove byte Type encoding "by" from variable name and replace camelcase with snakecase Mute checkpatch.pl error: CHECK: Avoid CamelCase: <byCurPwr> Signed-off-by: Gilbert Adikankwu <gilbertadikankwu@gmail.com> Link: https://lore.kernel.org/r/4c24962988ac990ae21c95e4a1754cfabfd2db8d.1697495598.git.gilbertadikankwu@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
e9a2aba0 |
|
16-Oct-2023 |
Gilbert Adikankwu <gilbertadikankwu@gmail.com> |
staging: vt6655: Rename variable bUpdateBBVGA Remove bool Type encoding "b" from variable name and replace camelcase with snakecase. Mute checkpatch.pl error: CHECK: Avoid CamelCase: <bUpdateBBVGA> Signed-off-by: Gilbert Adikankwu <gilbertadikankwu@gmail.com> Link: https://lore.kernel.org/r/9bd935c464671db2654c654964812cc48f4603d3.1697495598.git.gilbertadikankwu@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
e385ed2a |
|
08-Oct-2023 |
Pavan Bobba <opensource206@gmail.com> |
staging: vt6655: Type encoding info dropped from variable name "byBBVGANew" variable name "byBBVGANew" updated like below: a.type encoding info dropped from name b.camelcase name replaced by snakecase Issue found by checkpatch Signed-off-by: Pavan Bobba <opensource206@gmail.com> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/abb105b822090a82ef081b2e28705bf14b8ce058.1696791459.git.opensource206@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
f5640b0c |
|
08-Oct-2023 |
Pavan Bobba <opensource206@gmail.com> |
staging: vt6655: Type encoding info dropped from variable name "byBBVGACurrent" variable name "byBBVGACurrent" updated like below: a.type encoding info dropped from name b.camelcase name replaced by snakecase Issue found by checkpatch Signed-off-by: Pavan Bobba <opensource206@gmail.com> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/f0dfd4d2460f858540d465dd8bcfc920c219e94d.1696791459.git.opensource206@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
11b896e6 |
|
08-Oct-2023 |
Pavan Bobba <opensource206@gmail.com> |
staging: vt6655: Type encoding info dropped from array name "abyBBVGA" array name "abyBBVGA" updated like below: a.type encoding info dropped from name b.camelcase name replaced by snakecase Issue found by checkpatch Signed-off-by: Pavan Bobba <opensource206@gmail.com> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/13a233dff4d6daf728f75ab18b38ec9d0703764b.1696791459.git.opensource206@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
eb507641 |
|
21-Sep-2023 |
Pavan Bobba <opensource206@gmail.com> |
staging: vt6655: Type encoding info dropped from variable "byRFType" variable name "byRFType" updated like below: a.type encoding info dropped from name b.camelcase name replaced by snakecase Issue found by checkpatch Signed-off-by: Pavan Bobba <opensource206@gmail.com> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/ZQwyRXFHA9hTLcyv@ubuntu.myguest.virtualbox.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
a790cc3a |
|
09-Oct-2022 |
Alexander Wetzel <alexander@wetzel-home.de> |
wifi: mac80211: add wake_tx_queue callback to drivers mac80211 is fully switching over to the internal TX queue (iTXQ) implementation. Update all drivers not yet providing the now mandatory wake_tx_queue() callback. As an side effect the netdev interfaces of all updated drivers will switch to the noqueue qdisc. Signed-off-by: Alexander Wetzel <alexander@wetzel-home.de> [add staging drivers] Signed-off-by: Johannes Berg <johannes.berg@intel.com>
|
#
2a2db520 |
|
12-Sep-2022 |
Nam Cao <namcaov@gmail.com> |
staging: vt6655: fix some erroneous memory clean-up loops In some initialization functions of this driver, memory is allocated with 'i' acting as an index variable and increasing from 0. The commit in "Fixes" introduces some clean-up codes in case of allocation failure, which free memory in reverse order with 'i' decreasing to 0. However, there are some problems: - The case i=0 is left out. Thus memory is leaked. - In case memory allocation fails right from the start, the memory freeing loops will start with i=-1 and invalid memory locations will be accessed. One of these loops has been fixed in commit c8ff91535880 ("staging: vt6655: fix potential memory leak"). Fix the remaining erroneous loops. Link: https://lore.kernel.org/linux-staging/Yx9H1zSpxmNqx6Xc@kadam/ Fixes: 5341ee0adb17 ("staging: vt6655: check for memory allocation failures") Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Signed-off-by: Nam Cao <namcaov@gmail.com> Link: https://lore.kernel.org/r/20220912170429.29852-1-namcaov@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
c8ff9153 |
|
09-Sep-2022 |
Nam Cao <namcaov@gmail.com> |
staging: vt6655: fix potential memory leak In function device_init_td0_ring, memory is allocated for member td_info of priv->apTD0Rings[i], with i increasing from 0. In case of allocation failure, the memory is freed in reversed order, with i decreasing to 0. However, the case i=0 is left out and thus memory is leaked. Modify the memory freeing loop to include the case i=0. Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Signed-off-by: Nam Cao <namcaov@gmail.com> Link: https://lore.kernel.org/r/20220909141338.19343-1-namcaov@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
9ca57c63 |
|
08-Sep-2022 |
Nam Cao <namcaov@gmail.com> |
staging: vt6655: remove unnecessary null check Remove null check for priv->tx0_bufs, because it can never be null at this point. Signed-off-by: Nam Cao <namcaov@gmail.com> Link: https://lore.kernel.org/r/20220909100650.44609-1-namcaov@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
6d29e080 |
|
28-Aug-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6655: Rename function MACvSetShortRetryLimit Rename function MACvSetShortRetryLimit to vt6655_mac_set_short_retry_limit and byRetryLimit to retry_limit to avoid CamelCase which is not accepted by checkpatch.pl. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/d04b82510853607f439b4d969d4ce4b1883e9de8.1661666677.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
8809cc88 |
|
28-Aug-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6655: Rename macro MACvSelectPage1 Rename MACvSelectPage1 macro to VT6655_MAC_SELECT_PAGE1 to avoid CamelCase which is not accepted by checkpatch.pl and to clean up namespace. Remove unnecessary line break. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/8aa03e089613d49be7acedcb60a19a0133e96baa.1661666677.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
54765727 |
|
28-Aug-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6655: Rename macro MACvSelectPage0 Rename MACvSelectPage0 macro to VT6655_MAC_SELECT_PAGE0 to avoid CamelCase which is not accepted by checkpatch.pl and to clean up namespace. Remove unnecessary line break. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/a656aa0e04c43654ba22b764cb00e27898efbe5f.1661666677.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
692f9007 |
|
07-Aug-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6655: Convert macro MACvDisableBarkerPreambleMd Convert macro MACvDisableBarkerPreambleMd to static function which calls the common static function vt6655_mac_clear_bits. This saves codelines and multiline macros are not liked by kernel community. Function name is also changed to avoid CamelCase which is not accepted by checkpatch.pl and to clean up namespace. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/2a1d67762d9ecf3f30f3e293ad6ab997ad278b84.1659892671.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
0e17361b |
|
07-Aug-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6655: Convert macro MACvEnableBarkerPreambleMd Convert macro MACvEnableBarkerPreambleMd to static function which calls the common static function vt6655_mac_set_bits. This saves codelines and multiline macros are not liked by kernel community. Function name is also changed to avoid CamelCase which is not accepted by checkpatch.pl and to clean up namespace. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/542b9f8c0b10aa3db143b22f7425ab5bddc5bffe.1659892671.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
cc002691 |
|
07-Aug-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6655: Convert macro MACvDisableProtectMD Convert macro MACvDisableProtectMD to static function which calls the new common static function vt6655_mac_clear_bits. This saves codelines and multiline macros are not liked by kernel community. Function name is also changed to avoid CamelCase which is not accepted by checkpatch.pl and to clean up namespace. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/4cb2b8025adde2a3addfd8e954faf18a0a8032aa.1659892670.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
17ca6537 |
|
07-Aug-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6655: Rename function MACvEnableProtectMD Rename MACvEnableProtectMD function to vt6655_mac_en_protect_md to avoid CamelCase which is not accepted by checkpatch.pl and to clean up namespace. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/927d7c6e7c9d5214e4faeca886efd2696b2abc31.1659892670.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
0e68ed8f |
|
07-Aug-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6655: Create one function for two macros Create function vt6655_mac_set_bits with two parameters to cover functionality of two macros. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/78883f42b2df258dbf821d7f7515a82932a157f1.1659892670.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
6d9f3d12 |
|
07-Aug-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6655: Convert macro MACvEnableProtectMD to function Convert macro to static function. Multiline macros are not liked by kernel community. Rename variable dwOrgValue to reg_value to avoid CamelCase which is not accepted by checkpatch.pl. Change variable declaration to u32 as this improves readability. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/f3a5ec5352346f1dc4bf3afbee25973fdb47d7e4.1659892670.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
05e778f0 |
|
29-Jul-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6655: Replace MACvTransmitAC0 with function vt6655_mac_dma_ctl Convert macro MACvTransmitAC0 to existing static function. This saves codelines and multiline macros are not liked by kernel community. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/013abd177d9ac129c034776f10cdf823fd87d781.1659080988.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
59cce3f4 |
|
29-Jul-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6655: Replace MACvTransmit0 with function vt6655_mac_dma_ctl Convert macro MACvTransmit0 to existing static function. This saves codelines and multiline macros are not liked by kernel community. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/fc412f0fda11045a55b6b5867d51e250ca841ee8.1659080988.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
f4726f7f |
|
29-Jul-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6655: Replace MACvReceive1 with function vt6655_mac_dma_ctl Convert macro MACvReceive1 to existing static function. This saves codelines and multiline macros are not liked by kernel community. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/ec8dbbfeccb32e0b5c753702cb70d2749426c054.1659080988.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
1795826c |
|
29-Jul-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6655: Rename function MACvReceive0 and add parameter Rename MACvReceive0 function to vt6655_mac_dma_ctl to avoid CamelCase which is not accepted by checkpatch.pl and to clean up namespace. Add one parameter to avoid multiple repetitions of the same function. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/e5ca6208263d5aa3f1d6f0359fa602187d799f19.1659080988.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
9665eaf5 |
|
29-Jul-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6655: Convert macro MACvReceive0 to function Convert macro to static function. Multiline macros are not liked by kernel community. Rename variable dwData to reg_value to avoid CamelCase which is not accepted by checkpatch.pl. Change variable declaration to u32 as this improves readability. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/059aca149bd0c1d75df4fb3cd8a177aa4948fb02.1659080988.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
5327d71d |
|
12-Jul-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6655: Rename MACvRegBitsOff Fix name of a macro that uses CamelCase which is not accepted by checkpatch.pl Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/e6bea6707f20a53d0631dd1f477ce72d36cd6f3e.1657657918.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
ee67fe63 |
|
12-Jul-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6655: Rename MACvWordRegBitsOn Fix name of a macro that uses CamelCase which is not accepted by checkpatch.pl Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/b3873e1103d642a804d42c945dc0c73d94b0c1cf.1657657918.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
67ec5576 |
|
12-Jul-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6655: Rename MACvRegBitsOn Fix name of a macro that uses CamelCase which is not accepted by checkpatch.pl Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/7fb9627441ff97897d132c62d59676355b6d14ea.1657657918.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
2a1f94e4 |
|
06-Jul-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6655: Use loop in vt6655_mac_read_ether_addr Use loop in vt6655_mac_read_ether_addr to avoid multiple similar statements. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/f233c8a007d75a8adcc99a07c582b75bdc1985db.1657134099.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
385b35ab |
|
06-Jul-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6655: Use loop in vt6655_mac_write_bssid_addr Use loop in vt6655_mac_write_bssid_addr to avoid multiple similar statements. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/b3b93ae7ce41562565e9007eb4580b9c47a2881f.1657134099.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
7b5ec68a |
|
04-Jul-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6655: Convert macro vt6655_mac_read_ether_addr to function Convert macro vt6655_mac_read_ether_addr to static function. checkpatch.pl does not accept multiline macros. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/2e2524187d9d3a6140fe4a5a35926db14dddfe98.1656835310.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
5df564ca |
|
04-Jul-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6655: Convert macro vt6655_mac_write_bssid_addr to function Convert macro vt6655_mac_write_bssid_addr to static function. checkpatch.pl does not accept multiline macros. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/caecf7287d92c5d25ba0dfc16a24a6ce4aa67d55.1656835310.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
52fbed10 |
|
04-Jul-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6655: Move two macros to file where those are used Move two multiline macros to file of only useage to convert them later to static functions. checkpatch.pl does not accept multiline macros. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/b4a04608b3900186d4941b3bfe9463bb79e261e8.1656835310.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
41c8e56b |
|
04-Jul-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6655: Rename MACvReadEtherAddress Fix name of a macro that uses CamelCase which is not accepted by checkpatch.pl Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/3714f7cd3425e0ef0a3df0cc291131cdb85a3796.1656835310.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
06f737ef |
|
04-Jul-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6655: Rename MACvWriteBSSIDAddress Fix name of a macro that uses CamelCase which is not accepted by checkpatch.pl Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/1190d93181409679f9ae348a95ea269b48b1115c.1656835310.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
6f58936e |
|
22-May-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6655: Add missing BE support on 2x iowrite32 Add missing big-endian support when using two times iowrite32 to write 64 Bit. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/974ef7a9244e7caeafd8c176c7b53a6de3c20219.1653203927.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
a18263eb |
|
22-May-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6655: Replace VNSvOutPortD with iowrite32 Replace macro VNSvOutPortD with iowrite32 because it replaces just one line. The name of macro and the arguments use CamelCase which is not accepted by checkpatch.pl Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/03b6ff0250aa797f45a855ff2fc76f8013f73dc0.1653203927.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
a7992290 |
|
22-May-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6655: Replace MACvIntDisable with VNSvOutPortD Replace macro MACvIntDisable with VNSvOutPortD and as it was only used twice, it can now be removed. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/937422bb879d8f1f58978bedc8d15559d28581c7.1653203927.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
159ed047 |
|
22-May-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6655: Replace MACvIntEnable with VNSvOutPortD Replace macro MACvIntEnable with VNSvOutPortD and as it was only used twice, it can now be removed. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/182b9f8edd1ce3f6ff12a2942e990dae0f80099a.1653203927.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
0fd13e6b |
|
22-May-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6655: Replace MACvWriteISR with VNSvOutPortD Replace macro MACvWriteISR with VNSvOutPortD and as it was the only user, it can now be removed. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/80cd68a83807209230a898ab0260188adfad4158.1653203927.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
33028eea |
|
22-May-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6655: Replace VNSvOutPortW with iowrite16 Replace macro VNSvOutPortW with iowrite16 because it replaces just one line. The name of macro and the arguments use CamelCase which is not accepted by checkpatch.pl Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/ded437e27cffb040865d4afe47e447c2d0d6f0b8.1653203927.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
7b7090b4 |
|
24-May-2022 |
Johannes Berg <johannes.berg@intel.com> |
wifi: mac80211: split bss_info_changed method Split the bss_info_changed method to vif_cfg_changed and link_info_changed, with the latter getting a link ID. Also change the 'changed' parameter to u64 already, we know we need that. Signed-off-by: Johannes Berg <johannes.berg@intel.com>
|
#
f276e20b |
|
10-May-2022 |
Johannes Berg <johannes.berg@intel.com> |
wifi: mac80211: move interface config to new struct We'll use bss_conf for per-link configuration later, so move out all the non-link-specific data out into a new struct ieee80211_vif_cfg used in the vif. Some adjustments were done with the following spatch: @@ expression sdata; struct ieee80211_vif *vifp; identifier var = { assoc, ibss_joined, aid, arp_addr_list, arp_addr_cnt, ssid, ssid_len, s1g, ibss_creator }; @@ ( -sdata->vif.bss_conf.var +sdata->vif.cfg.var | -vifp->bss_conf.var +vifp->cfg.var ) @bss_conf@ struct ieee80211_bss_conf *bss_conf; identifier var = { assoc, ibss_joined, aid, arp_addr_list, arp_addr_cnt, ssid, ssid_len, s1g, ibss_creator }; @@ -bss_conf->var +vif_cfg->var (though more manual fixups were needed, e.g. replacing "vif_cfg->" by "vif->cfg." in many files.) Signed-off-by: Johannes Berg <johannes.berg@intel.com>
|
#
404079e7 |
|
08-May-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6655: Replace VNSvOutPortB with iowrite8 Replace macro VNSvOutPortB with iowrite8 because it replaces just one line. The name of macro and the arguments use CamelCase which is not accepted by checkpatch.pl Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/38611512677a18f63d9266cde1d20758c0feeb6e.1651957741.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
7436b3ea |
|
08-May-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6655: Replace MACvStart with VNSvOutPortB Replace macro MACvStart with VNSvOutPortB and as it was the only user, it can now be removed. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/d998305b4dec2827b0e13e49938e68a32517c487.1651957741.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
60a16985 |
|
01-May-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6655: Replace unused return value of vt6655_get_current_tsf Replace unused return value with u64 to increase readability, reduce address and dereference operators and omit pqwCurrTSF that uses CamelCase which is not accepted by checkpatch.pl Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/62c83d78627196ec0ce2f5a562cb080a1c87a05a.1651435890.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
fed5b533 |
|
01-May-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6655: Rename function CARDbGetCurrentTSF The name of the function uses CamelCase which is not accepted by checkpatch.pl Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/2b92db8d67e8dd1fc85b45efe3b32d2199371190.1651435890.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
79ffde57 |
|
01-May-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6655: Replace VNSvInPortD with ioread32 Replace macro VNSvInPortD with ioread32 and as it was the only user, it can now be removed. The name of macro and the arguments use CamelCase which is not accepted by checkpatch.pl Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/3945d32053898e5f9771d6f742ae118ca56943ce.1651431640.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
5fe7856a |
|
26-Apr-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6655: Replace MACvReadISR with VNSvInPortD Replace macro MACvReadISR with VNSvInPortD and as it was the only user, it can now be removed. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/ddd403a3f590cb81403197442b12c3986c98ba25.1651036713.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
aa20e234 |
|
26-Apr-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6655: Replace MACvReadMIBCounter with VNSvInPortD Replace macro MACvReadMIBCounter with VNSvInPortD and as it was the only user, it can now be removed. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/e1b7156e2c689cf53c738642fd9b33816ec89f92.1651036713.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
08bea7da |
|
16-Apr-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6655: Replace VNSvInPortB with ioread8 Replace macro VNSvInPortB with ioread8. Avoid cast of the return value is possible with one exception. The name of macro and the arguments use CamelCase which is not accepted by checkpatch.pl Since there are more than one checkpatch issue per line, more steps are rquired to fix. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/fd71797d9d55d53f95c5c4e2df826bf85dd4626a.1650094595.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
bcac7e6e |
|
16-Apr-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6655: Replace MACvGPIOIn with VNSvInPortB Replace macro MACvGPIOIn with VNSvInPortB. Next patch will replace all macros VNSvInPortB with ioread8. The names of macros and the arguments use CamelCase which is not accepted by checkpatch.pl Since there are more than one checkpatch issue per line, more steps are rquired to fix. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/0a3c3eb0d4dad544fa281b34c5a70d4a3ab2d9f1.1650094595.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
7988cf07 |
|
27-Nov-2021 |
Alberto Merciai <alb3rt0.m3rciai@gmail.com> |
staging: vt6655: refactor camelcase uCurrRSSI to current_rssi Replace camelcase variable "uCurrRSSI" (current Received Signal Strength Indicator) into linux kernel coding style equivalent variable "current_rssi". Signed-off-by: Alberto Merciai <alb3rt0.m3rciai@gmail.com> Link: https://lore.kernel.org/r/20211127100807.3113388-1-alb3rt0.m3rciai@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
9e861d3f |
|
20-Nov-2021 |
Alberto Merciai <alb3rt0.m3rciai@gmail.com> |
staging: vt6655: rename variable bHWRadioOff Replace camelcase hungarian notated variable "bHWRadioOff" into linux kernel coding style equivalent variable "hw_radio_off". Tested-by: Tommaso Merciai <tomm.merciai@gmail.com> Acked-by: Tommaso Merciai <tommaso.merciai@gmail.com> Acked-by: Tommaso Merciai <tomm.merciai@gmail.com> Signed-off-by: Alberto Merciai <alb3rt0.m3rciai@gmail.com> Link: https://lore.kernel.org/r/20211121112000.632456-1-alb3rt0.m3rciai@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
fca00dc4 |
|
13-Nov-2021 |
Tommaso Merciai <tomm.merciai@gmail.com> |
staging: vt6655: fix camelcase in bRadioOff Replace camel case variable bRadioOff with snake case variable radio_off. Drop Hungarian notation prefix in `bRadioOff` variable. Change it to use snake case. Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com> Link: https://lore.kernel.org/r/20211113102126.82904-1-tomm.merciai@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
548b6d7e |
|
18-Oct-2021 |
Karolina Drobnik <karolinadrobnik@gmail.com> |
staging: vt6655: Rename byPreambleType field Drop Hungarian notation prefix in `byPreambleType` member of struct vnt_private. Change it to use snake case. Fix issue detected by checkpatch.pl: CHECK: Avoid CamelCase: <byPreambleType> Signed-off-by: Karolina Drobnik <karolinadrobnik@gmail.com> Link: https://lore.kernel.org/r/20211018150317.9590-1-karolinadrobnik@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
e9c1caea |
|
10-Oct-2021 |
Tommaso Merciai <tomm.merciai@gmail.com> |
staging: vt6655: fix camelcase in byLocalID Replace camel case variable name for variable byLocalID with snake case equivalent. Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com> Link: https://lore.kernel.org/r/20211010220014.148785-1-tomm.merciai@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
1977dcf0 |
|
05-Oct-2021 |
Tommaso Merciai <tomm.merciai@gmail.com> |
staging: vt6655: fix camelcase in PortOffset Replace camel case variable PortOffset with snake case variable port_offset. Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com> Link: https://lore.kernel.org/r/20211005205702.14029-4-tomm.merciai@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
aeec304c |
|
05-Oct-2021 |
Tommaso Merciai <tomm.merciai@gmail.com> |
staging: vt6655: fix camelcase in ldBmThreshold Replace camel case variable ldBmThreshold with snake case variable dbm_threshold. ldBmThreshold is in hungarian notation, where "l" is for long and "dbm" is for decibel-milliwatt (signal strenght). This variable contain's signal strenght threshold in dbm. References: - https://en.wikipedia.org/wiki/Hungarian_notation - https://www.rapidtables.com/electric/dBm.html Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com> Link: https://lore.kernel.org/r/20211005205702.14029-3-tomm.merciai@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
e4a9e1d8 |
|
05-Oct-2021 |
Tommaso Merciai <tomm.merciai@gmail.com> |
staging: vt6655: fix camelcase in bShortSlotTime Replace camel case variable bShortSlotTime with snake case variable short_slot_time. bShortSlotTime is a boolean variable, if true short slot time is enabled, false not. Short Slot Time reduces the slot time from 20 microseconds to 9 microseconds, where the slot time is the maximum theoretical time for a frame to travel a network. References: - http://cciew.blogspot.com/2011/02/short-slot-time.html - https://www.cse.wustl.edu/~jain/cse574-16/ftp/j_05lan4.pdf - https://www.networkdatapedia.com/post/2013/09/16/ \ configuring-short-slot-time-to-improve-wifi-performance - https://en.wikipedia.org/wiki/Slot_time Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com> Link: https://lore.kernel.org/r/20211005205702.14029-2-tomm.merciai@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
0e9e3f61 |
|
23-Jul-2021 |
Lucas Henneman <lucas.henneman@linaro.org> |
staging: vt6655: remove filename from device_main.c This patch resolves checkpatch's warning, "It's generally not useful to have the filename in the file" for device_main.c. Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org> Link: https://lore.kernel.org/r/20210723144340.15787-8-lucas.henneman@linaro.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
6a8ce971 |
|
19-Nov-2020 |
Gustavo A. R. Silva <gustavoars@kernel.org> |
staging: vt6655: Fix fall-through warnings for Clang In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple warnings by explicitly adding multiple break statements instead of just letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> Link: https://lore.kernel.org/r/863fda60074850bc976974af48fa769c64725e64.1605896059.git.gustavoars@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
2ed1fa08 |
|
16-Oct-2020 |
Deepak R Varma <mh12gx2825@gmail.com> |
staging: vt6655: rearrange lines exceeding 100 columns Rearrange lines that are longer than 100 columns in width. Issue reported by chckpatch script. Also remove unnecessary pair of braces for single line instruction post if condition. Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com> Link: https://lore.kernel.org/r/20201016154423.GA17210@ubuntu204 Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
9a9c1827 |
|
11-Sep-2020 |
Sebastian Fuentes <sefu1789@gmail.com> |
staging: vt6655: Add spaces around arithmetic operators This addresses the checkpatch.pl warning "spaces preferred around that '+/-/*'" Signed-off-by: Sebastian Fuentes <sefu1789@gmail.com> Link: https://lore.kernel.org/r/20200912052357.GA4707@ubuntu Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
7a46931b |
|
29-Jun-2020 |
Vaibhav Gupta <vaibhavgupta40@gmail.com> |
staging: vt6655/device_main.c: use generic power management Drivers should not use legacy power management as they have to manage power states and related operations, for the device, themselves. This driver was handling them with the help of PCI helper functions like pci_save/restore_state(), pci_enable/disable_device(), etc. With generic PM, all essentials will be handled by the PCI core. Driver needs to do only device-specific operations. The driver was also using pci_enable_wake(...,..., 0) to disable wake. Use device_wakeup_disable() instead. Compile-tested only. Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com> Link: https://lore.kernel.org/r/20200629082819.216405-5-vaibhavgupta40@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
3abbab51 |
|
13-May-2020 |
Matej Dujava <mdujava@kocurkovo.cz> |
staging: vt6656: vt6655: removing unused macros definition Makefiles This patch is removing definition of CFLAGS in Makefile of vt6656 and vt6655, as those are defining macros that are not used. This will remove undef of one macro from vt6655/device_main.c, as it is only undef and it is not used anywhere else, so it is safe to remove it. Macros are removed from vt665x/Makefile and vt6655/device_main.c. Signed-off-by: Matej Dujava <mdujava@kocurkovo.cz> Link: https://lore.kernel.org/r/1589397351-24655-2-git-send-email-mdujava@kocurkovo.cz Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
af93096e |
|
03-Apr-2020 |
Briana Oursler <briana.oursler@gmail.com> |
Staging: vt6655: Replace camel case variable names. Replace camel case variable names with snake case in baseband.h and its dependencies. Signed-off-by: Briana Oursler <briana.oursler@gmail.com> Reviewed-by: Stefano Brivio <sbrivio@redhat.com> Link: https://lore.kernel.org/r/20200403171805.466600-1-briana.oursler@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
73d85422 |
|
24-Mar-2020 |
Briana Oursler <briana.oursler@gmail.com> |
staging: vt6655: Break up function call with long line. Update matches style found elsewhere in file. Issue found by checkpatch: line over 80 characters. Signed-off-by: Briana Oursler <briana.oursler@gmail.com> Link: https://lore.kernel.org/r/20200324183812.79411-1-briana.oursler@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
a1182cda |
|
28-Jan-2020 |
Simon Fong <simon.fongnt@yahoo.com> |
Staging: vt6655: device_main: cleanup long line cleanup a long line coding style warning. Signed-off-by: Simon Fong <simon.fongnt@yahoo.com> Link: https://lore.kernel.org/r/20200128141426.12230-1-simon.fongnt@yahoo.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
3bce4750 |
|
01-Nov-2019 |
Frank A. Cancio Bello <frank@generalsoftwareinc.com> |
staging: vt6655: Fix long lines Lines longer than 80 characters should be avoided because they are ugly and harder to read. Fix a few of long lines to comply with the preferred coding style for the linux kernel. Issues found by checkpatch. Suggested-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Frank A. Cancio Bello <frank@generalsoftwareinc.com> Link: https://lore.kernel.org/r/588c73f275b22f55323797706e5ceae44d7aa160.1572649242.git.frank@generalsoftwareinc.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
ebacc1a7 |
|
01-Nov-2019 |
Frank A. Cancio Bello <frank@generalsoftwareinc.com> |
staging: vt6655: Fix the spacing around operators Add space around operators to comply in that way with the preferred coding style for the linux kernel. Issue found by checkpatch. Suggested-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Frank A. Cancio Bello <frank@generalsoftwareinc.com> Link: https://lore.kernel.org/r/0f77b97e88c28c503caf25fafb84729509969ec3.1572649242.git.frank@generalsoftwareinc.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
8b3f9afc |
|
01-Nov-2019 |
Frank A. Cancio Bello <frank@generalsoftwareinc.com> |
staging: vt6655: Fix parameter alignment issues Fix alignment to match open parenthesis and comply in that way with the preferred coding style for the linux kernel. Issue found by checkpatch. Suggested-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Frank A. Cancio Bello <frank@generalsoftwareinc.com> Link: https://lore.kernel.org/r/df2a5f511870bd96abb9b111de83f3a1f1d82d70.1572649242.git.frank@generalsoftwareinc.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
80b15db5 |
|
04-Oct-2019 |
Navid Emamdoost <navid.emamdoost@gmail.com> |
staging: vt6655: Fix memory leak in vt6655_probe In vt6655_probe, if vnt_init() fails the cleanup code needs to be called like other error handling cases. The call to device_free_info() is added. Fixes: 67013f2c0e58 ("staging: vt6655: mac80211 conversion add main mac80211 functions") Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com> Cc: stable <stable@vger.kernel.org> Link: https://lore.kernel.org/r/20191004200319.22394-1-navid.emamdoost@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
cc26358f |
|
27-Mar-2019 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: Remove vif check from vnt_interrupt A check for vif is made in vnt_interrupt_work. There is a small chance of leaving interrupt disabled while vif is NULL and the work hasn't been scheduled. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> CC: stable@vger.kernel.org # v4.2+ Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
3b9c2f2e |
|
24-Mar-2019 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: Fix interrupt race condition on device start up. It appears on some slower systems that the driver can find its way out of the workqueue while the interrupt is disabled by continuous polling by it. Move MACvIntEnable to vnt_interrupt_work so that it is always enabled on all routes out of vnt_interrupt_process. Move MACvIntDisable so that the device doesn't keep polling the system while the workqueue is being processed. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> CC: stable@vger.kernel.org # v4.2+ Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
73ad3e24 |
|
26-Feb-2019 |
Madhumitha Prabakaran <madhumithabiw@gmail.com> |
Staging: vt6655: Alignment should match open parenthesis Fix the check to improve readibility CHECK: Alignment should match open parenthesis Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
00bdd001 |
|
25-Feb-2019 |
Madhumitha Prabakaran <madhumithabiw@gmail.com> |
Staging: vt6655: Alignment should match open parenthesis Fix the check to improve readibility. CHECK: Alignment should match open parenthesis Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
750afb08 |
|
04-Jan-2019 |
Luis Chamberlain <mcgrof@kernel.org> |
cross-tree: phase out dma_zalloc_coherent() We already need to zero out memory for dma_alloc_coherent(), as such using dma_zalloc_coherent() is superflous. Phase it out. This change was generated with the following Coccinelle SmPL patch: @ replace_dma_zalloc_coherent @ expression dev, size, data, handle, flags; @@ -dma_zalloc_coherent(dev, size, handle, flags) +dma_alloc_coherent(dev, size, handle, flags) Suggested-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org> [hch: re-ran the script on the latest tree] Signed-off-by: Christoph Hellwig <hch@lst.de>
|
#
1dc751a5 |
|
05-Apr-2018 |
Ji-Hun Kim <ji_hun.kim@samsung.com> |
staging: vt6655: add handling memory leak on vnt_start() There was no code for handling memory leaks of device_init_rings() and request_irq(). It needs to free allocated memory in the device_init_rings() , when request_irq() would be failed. Add freeing sequences of irq and device init rings. Signed-off-by: Ji-Hun Kim <ji_hun.kim@samsung.com> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
5341ee0a |
|
05-Apr-2018 |
Ji-Hun Kim <ji_hun.kim@samsung.com> |
staging: vt6655: check for memory allocation failures There are no null pointer checking on rd_info and td_info values which are allocated by kzalloc. It has potential null pointer dereferencing issues. Implement error handling code on device_init_rd*, device_init_td* and vnt_start for the allocation failures. Signed-off-by: Ji-Hun Kim <ji_hun.kim@samsung.com> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
6089735a |
|
02-Mar-2018 |
Santha Meena Ramamoorthy <santhameena13@gmail.com> |
staging: vt6655: remove unnecessary parentheses Remove unnecessary parentheses around variables to conform to the Linux kernel coding style. Issue found using checkpatch. Signed-off-by: Santha Meena Ramamoorthy <santhameena13@gmail.com> Acked-by: Julia Lawall <julia.lawall@lip6.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
88a527c4 |
|
18-Dec-2017 |
Jia-Ju Bai <baijiaju1990@gmail.com> |
staging: vt6655: Use GFP_KERNEL in kzalloc Four kzalloc functions are called with GFP_ATOMIC. But according to driver call graph, they are not in atomic context, namely no spinlock is held nor in an interrupt handler. All these "GFP_ATOMIC"s are unnecessary, and replace with with "GFP_KERNEL"s. Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
dbc9f36c |
|
07-Nov-2017 |
Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
staging: vt6655: Remove redundant license text Now that the SPDX tag is in all vt6655 files, that identifies the license in a specific and legally-defined manner. So the extra GPL text wording can be removed as it is no longer needed at all. This is done on a quest to remove the 700+ different ways that files in the kernel describe the GPL license text. And there's unneeded stuff like the address (sometimes incorrect) for the FSF which is never needed. No copyright headers or other non-license-description text was removed. Cc: Forest Bond <forest@alittletooquiet.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
d7c43082 |
|
07-Nov-2017 |
Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
staging: vt6655: add SPDX identifiers to all vt6655 driver files It's good to have SPDX identifiers in all files to make it easier to audit the kernel tree for correct licenses. Update the vt6655 driver files with the correct SPDX license identifier based on the license text in the file itself. The SPDX identifier is a legally binding shorthand, which can be used instead of the full boiler plate text. This work is based on a script and data from Thomas Gleixner, Philippe Ombredanne, and Kate Stewart. Cc: Forest Bond <forest@alittletooquiet.net> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Kate Stewart <kstewart@linuxfoundation.org> Cc: Philippe Ombredanne <pombredanne@nexb.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
42c8eb3f |
|
09-Oct-2017 |
Jia-Ju Bai <baijiaju1990@163.com> |
vt6655: Fix a possible sleep-in-atomic bug in vt6655_suspend The driver may sleep under a spinlock, and the function call path is: vt6655_suspend (acquire the spinlock) pci_set_power_state __pci_start_power_transition (drivers/pci/pci.c) msleep --> may sleep To fix it, pci_set_power_state is called without having a spinlock. This bug is found by my static analysis tool and my code review. Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
7959c331 |
|
23-May-2017 |
Marko Stankovic <dartnorris@gmail.com> |
staging: vt6655: align function parameters to open parenthesis Alignment styles are used interchangeably, align parameters to open parenthesis and fix issues reported by checkpatch.pl Signed-off-by: Marko Stankovic <dartnorris@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
5c60befe |
|
22-May-2017 |
Marko Stankovic <dartnorris@gmail.com> |
staging: vt6655: remove unnecessary blank lines Fix unnecessary blank lines issues reported by checkpatch.pl Signed-off-by: Marko Stankovic <dartnorris@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
3621014a |
|
22-May-2017 |
Marko Stankovic <dartnorris@gmail.com> |
staging: vt6655: replace NULL comparison with '!' operator Fix comparison to NULL issues reported by checkpatch.pl Signed-off-by: Marko Stankovic <dartnorris@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
e5851dc0 |
|
02-Dec-2016 |
PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com> |
staging: vt6655: Add spaces around + Add spaces around + for better readability of the code. Signed-off-by: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
21971f3e |
|
11-Oct-2016 |
Varsha Rao <rvarsha016@gmail.com> |
staging: vt6655: Removes the FSF mailing address. This patch fixes the checkpatch issue by removing the Free Software Foundation's mailing address from the sample GPL notice. Because the FSF has changed address in the past, and may change again. Linux already includes a copy of the GPL. Signed-off-by: Varsha Rao <rvarsha016@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
3d30311c |
|
09-Oct-2016 |
Varsha Rao <rvarsha016@gmail.com> |
staging: vt6655: Removes unnecessary blank lines. This patch fixes the checkpatch issue of multiple blank lines, by removing them. Signed-off-by: Varsha Rao <rvarsha016@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
7cfae249 |
|
18-Sep-2016 |
Namrata A Shettar <namrataashettar@gmail.com> |
staging: vt6655: device_main: Replace NULL comparison with !x Replace NULL comparison to resolve checkpatch issue. - x == NULL => !x Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
8f4166d8 |
|
18-Sep-2016 |
Namrata A Shettar <namrataashettar@gmail.com> |
staging: vt6655: device_main: Replace explicit NULL comparison Replace NULL comparison to resolve checkpatch issue. - x == NULL => !x Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
9877f9de |
|
08-Jul-2016 |
Anson Jacob <ansonjacob.aj@gmail.com> |
staging: vt6655: Fix checkpatch warning Fix warning by checkpatch.pl Add * for block comments on subsequent lines Signed-off-by: Anson Jacob <ansonjacob.aj@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
57fbcce3 |
|
12-Apr-2016 |
Johannes Berg <johannes.berg@intel.com> |
cfg80211: remove enum ieee80211_band This enum is already perfectly aliased to enum nl80211_band, and the only reason for it is that we get IEEE80211_NUM_BANDS out of it. There's no really good reason to not declare the number of bands in nl80211 though, so do that and remove the cfg80211 one. Signed-off-by: Johannes Berg <johannes.berg@intel.com>
|
#
50aefc19 |
|
05-Mar-2016 |
Sandhya Bankar <bankarsandhya512@gmail.com> |
Staging: vt6655: Remove & from function name. Remove & from function name,when function name passed as an argument to another function. Function name is used as pointer without &. Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
2fbf6d61 |
|
11-Feb-2016 |
Haneen Mohammed <hamohammed.sa@gmail.com> |
Staging: vt6655: Add check dma_mapping_error This patch checks for dma_mapping_error() after using dma_map_single. If the dma map fails we release skb buff allocated by dev_alloc_skb() to avoid possible causes of resource leak. Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
f9f853af |
|
22-Nov-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: mac.c replace void __iomem * with struct vnt_private Moving void __iomem down one level in the following functions MACbIsRegBitsOn MACbIsRegBitsOff MACbIsIntDisable MACvSetShortRetryLimit MACvSetLongRetryLimit MACvGetLongRetryLimit MACvSetLoopbackMode MACvSaveContext MACvRestoreContext MACbSoftwareReset MACbSafeSoftwareReset MACbSafeRxOff MACbSafeTxOff MACbSafeStop MACbShutdown MACvInitialize MACvSetCurrRx0DescAddr MACvSetCurrRx1DescAddr MACvSetCurrTXDescAddr MACvSetCurrTx0DescAddrEx MACvSetCurrAC0DescAddrEx MACvSetCurrSyncDescAddrEx MACvSetCurrATIMDescAddrEx MACvTimer0MicroSDelay MACvOneShotTimer1MicroSec MACvSetMISCFifo MACbPSWakeup MACvSetKeyEntry MACvDisableKeyEntry Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
bc667b99 |
|
17-Oct-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: rename pOpts and sOpts to opts. bring pointers and members into line. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
068b9988 |
|
17-Oct-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: remove static inline alloc_td_info. Since this only contains one function and used only twice remove inline altogether. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
e06cf9ab |
|
17-Oct-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: remove static inline alloc_rd_info. Since this only contains one function and only used twice remove inline altogether. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
bed02d93 |
|
17-Oct-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: replace typedef struct __device_opt with struct vnt_options and members rx_descs0 for nRxDescs0 rx_descs1 for nRxDescs1 tx_descs for nTxDescs int_works short_retry long_retry bbp_type flags Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
0924a89b |
|
17-Oct-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: device_main Replace uIdx with idx. Removing camel case. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
9f31b695 |
|
03-Oct-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: device_tx_srv rename pTD Following the convention elsewhere for vnt_tx_desc rename desc. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
12f2ee35 |
|
03-Oct-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: device_main replace pTDInfo with td_info. Removing camel case. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
480fc5b8 |
|
03-Oct-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: device_main replace pRD with rd. Removing camel case. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
5e011b43 |
|
03-Oct-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: device_alloc_rx_buf replace pRDInfo with rd_info. Removing camel case. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
5e76c8f4 |
|
03-Oct-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: device_main.c replace pDesc with desc. Removing camel case. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
78e0e853 |
|
03-Oct-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: device_main replace pDevice with priv. Removing camel case. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
113d6dc1 |
|
27-Sep-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: don't stop TX queue unless buffer full. Presently the TX buffer stops while filling the buffer. However, this does not make use of the available buffer space, it also lags the speed of the TX troughtput. Only stop the queue when the buffer becomes full. The Interupt handler will start the queue again when a buffer is available. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
a03b8b3e |
|
12-Sep-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: Move code in device_get_pci_info Function always returns true and now only a few lines move to vt6655_probe. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
70d66a6a |
|
12-Sep-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: device_get_pci_info pcid already assigned. pcid has already been assigned earlier in vt6655_probe. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
41652a21 |
|
12-Sep-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: device_get_pci_info remove call to set master. a call to PCI_COMMAND is used to set master. However, a call to pci_set_master earlier in function which does the same thing. So remove the calls and variable b. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
2ef1571b |
|
12-Sep-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: device_get_pci_info remove variable cis_addr. cis_addr is never used remove its call to pci_resource_start. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
7a95f961 |
|
12-Sep-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: device_get_pci_info remove unused pci_read_config_* These values are read from pci but never used. Removing variables byRevId, SubSystemID, SubVendorID and pci_cmd. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
f3179826 |
|
12-Sep-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: remove and move vt6655_init_info move code to vt6655_probe. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
e577474f |
|
12-Sep-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: vt6655_init_info remove memset. vnt_private is allocated with kzalloc so is already zero. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
73eb8a11 |
|
12-Sep-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: remove unused multicast_limit. multicast_limit is assigned a vale that is never used. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
319755a7 |
|
12-Sep-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: Remove typedef struct __chip_info_tbl Only two values that are assigned from this table. DEVICE_FLAGS_TX_ALIGN and the value of io_size which is used as the size of ioremap which is 256. Remove all variables, DEVICE_FLAGS_TX_ALIGN check, apply io_size value and chip_info_table. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
e77610a9 |
|
12-Sep-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: remove get_chip_name and info message. This prints "VIA Networking Solomon-A/B/G Wireless LAN Adapter" which has already printed once in vt6655_probe. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
c2c77eea |
|
12-Sep-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: vt6655_probe remove PCI debug info Remove unnecessary debug PCI info that can be obtained by lspci. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
9cb693f6 |
|
15-Aug-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: replace typedef struct tagSRxDesc with struct vnt_rx_desc and all members the same. volatile is removed from pointers as this generates warning message. Only the first four members of vnt_rx_desc need to be volatile. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
88defe2b |
|
15-Aug-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: replace typedef struct tagDEVICE_RD_INFO with struct vnt_rd_info volatile is removed because it will generate a warning (in any case this member is not) and renaming rd_info. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
9fc7091c |
|
15-Aug-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: replace typedef struct tagRDES1 with struct vnt_rdes1 and members wReqCount -> req_count wReserved -> reserved Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
de1c1862 |
|
15-Aug-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: replace typedef struct tagRDES0 with struct vnt_rdes0 replacing members as follows wResCount -> res_count f15Reserved -> f15_reserved f1Owner -> owner big endian f8Reserved1 -> f8_reserved1 f7Reserved -> f7_reserved Narrowing endian differences to inside structure. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
e2357271 |
|
14-Aug-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: Replace typedef struct tagSTxDesc Replace with struct vnt_tx_desc with all members the same. volatile is removed from pointers as this generates warning message. Only the first four members of vnt_tx_desc need to be volatile. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
54382859 |
|
14-Aug-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: replace typedef struct tagDEVICE_TD_INFO and structure Create struct vnt_td_info with members mic_hdr skb buf buf_dma dwReqCount -> req_count byFlags -> flags In struct tagSTxDesc volatile is removed because it will generate a warning (in any case this member is not) and renaming td_info. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
531a9c52 |
|
14-Aug-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: struct tagDEVICE_TD_INFO resize dwReqCount. dwReqCount is no bigger than u16 Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
9cc8eac9 |
|
14-Aug-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: replaced typedef struct tagTDES1 Create struct vnt_tdes1 that replaces members wReqCount -> req_count byTCR -> tcr byReserved -> reserved Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
5235ff6a |
|
14-Aug-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: desc.h replace typedef struct tagTDES0 create struct vnt_tdes0 replacing used members byTSR0 -> tsr0 byTSR1 -> tsr1 f1Owner -> owner Narrowing endian differences to inside structure. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
1f171240 |
|
01-Aug-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: vnt_bss_info_changed check conf->beacon_rate is not NULL conf->beacon_rate can be NULL on association. So check conf->beacon_rate BSS_CHANGED_BEACON_INFO needs to flagged in changed as the beacon_rate will appear later. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Cc: <stable@vger.kernel.org> # v3.19+ Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
d5806c53 |
|
22-Jul-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: always set 32 bit dma mask The device is limited to 32 bit address space. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
db1ade7c |
|
22-Jul-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: remove unused tagDEVICE_RD_INFO -> curr_desc variable is assigned a value that is never used. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
eae6377e |
|
22-Jul-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: Remove unused tagDEVICE_TD_INFO curr_desc The variable is assigned a value that is never used. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
06f716a5 |
|
22-Jul-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: remove unnecessary variable skb_dma skb_dma flips from 0 to the contents buf_dma. This is nolonger necessary so use buf_dma directly and remove skb_dma altogether. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
3a00033e |
|
22-Jul-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: dead code tx path remove dma_unmap_single When pTDInfo->skb_dma not equal to pTDInfo->buf_dma, pTDInfo->skb_dma equals zero. as mentioned in comment pre-allocated buf_dma can't be unmapped so remove dead code. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
217ed3ab |
|
22-Jul-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: Remove ununsed macro ASSERT VIAWET_DEBUG is not defined so macro is empty. Remove the macro. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
42e0bb4d |
|
09-Jul-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: check ieee80211_bss_conf bssid not NULL Sometimes bssid can go null on failed association. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Cc: <stable@vger.kernel.org> # v3.19+ Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
4d4d138a |
|
14-Jul-2015 |
Maninder Singh <maninder1.s@samsung.com> |
staging:vt6655: remove checks around dev_kfree_skb dev_kfree_skb checks for NULL pointer itself, Thus no need of explicit NULL check. Signed-off-by: Maninder Singh <maninder1.s@samsung.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
8e8e9198 |
|
09-Jul-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: check ieee80211_bss_conf bssid not NULL Sometimes bssid can go null on failed association. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Cc: <stable@vger.kernel.org> # v3.19+ Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
eda01f61 |
|
09-Jul-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: Fix missing power saving support Add IEEE80211_HW_SUPPORTS_PS to ieee80211_hw flags enabling this feature. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
4fdae0d9 |
|
21-Jun-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: vnt_tx_packet don't wakeup from power saving. mac80211 changes the wake state before attempting to tx data Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
e75e8cac |
|
16-Jun-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: use module_pci_driver helper Remove vt6655_init_module and vt6655_cleanup_module and replace module_pci_driver Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
b51c88171 |
|
16-Jun-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: remove suspend struct notifier_block. The only thing this does is vt6655_suspend which is already been called upon suspend. Remove function device_notify_reboot and structure device_notifier. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
30686bf7 |
|
02-Jun-2015 |
Johannes Berg <johannes.berg@intel.com> |
mac80211: convert HW flags to unsigned long bitmap As we're running out of hardware capability flags pretty quickly, convert them to use the regular test_bit() style unsigned long bitmaps. This introduces a number of helper functions/macros to set and to test the bits, along with new debugfs code. The occurrences of an explicit __clear_bit() are intentional, the drivers were never supposed to change their supported bits on the fly. We should investigate changing this to be a per-frame flag. Signed-off-by: Johannes Berg <johannes.berg@intel.com>
|
#
b5eeed8c |
|
31-May-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: device_rx_srv check sk_buff is NULL There is a small chance that pRD->pRDInfo->skb could go NULL while the interrupt is processing. Put NULL check on loop to break out. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Cc: <stable@vger.kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
41b9e5e5 |
|
31-May-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: replace and resize dwIsr dwIsr is not used outside vnt_interrupt_process and should be u32. Move to function and resize to u32. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
2995dfe6 |
|
31-May-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: vnt_interrupt_process remove camel case. pDevice -> priv Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
f33d8d63 |
|
31-May-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: vnt_interrupt_process remove page 0 select Page 1 is fully proctected by lock there is no need to check for it. Page 0 is selected at other times. Remove byOrgPageSel and its calls from function. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
ff1ce1a8 |
|
31-May-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: use workqueue for interrupt handling Introduce vnt_interrupt to handle interrupt and use workqueue to queue and queue on vif. Convert device_intr to void call vnt_interrupt_process from vnt_interrupt_work providing vif is valid. This removes troublesome heavy code from the interupt handler and allows to remove atomic from other areas of driver. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
7e4786d1 |
|
31-May-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: Remove call to STAvUpdateIsrStatCounter. This function does not provide any data to users. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
700f6c02 |
|
31-May-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: implement ieee80211_low_level_stats Collect low level stats from mib counter for mac80211 call. Replacing the unused function STAvUpdate802_11Counter. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
664a5c1d |
|
21-Apr-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: lock MACvWriteBSSIDAddress. This function selects page 1 and cause intermittent problems on interrupt handler. lock call with spin_lock_irqsave. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Cc: <stable@vger.kernel.org> # v3.19+ Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
032ed34a |
|
21-Apr-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: CARDbUpdateTSF bss timestamp correct tsf counter value. The TSF counter is not set correctly. Use sync_tsf for last beacon value and get tsf local value. Remove qwLocalTSF variable and call CARDbGetCurrentTSF. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
d65d2b25 |
|
21-Apr-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: vnt_tx_packet Correct TX order of OWNED_BY_NIC The state of m_td0TD0.f1Owner should change after the buff_addr has been filled otherwise the device grabs the buffer too early. m_td0TD0.f1Owner is protected by memory barriers on both sides of change. iTDUsed is best incremented after MACvTransmit. It appears that f1Owner actually polls to do the memory transfer. A back port patch will be needed for v3.19 Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Cc: <stable@vger.kernel.org> # v4.0+ Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
ad3fee9b |
|
11-Apr-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: Fix 80211 control and management status reporting. Currently only TD_FLAGS_NETIF_SKB are reported back to mac80211. Move vnt_int_report_rate to report all frame types. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Cc: <stable@vger.kernel.org> # v3.19+ Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
6e44dc4b |
|
09-Apr-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: implement IEEE80211_TX_STAT_NOACK_TRANSMITTED Make use of this macro for non ack frames. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Cc: <stable@vger.kernel.org> # v4.0 Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
3fa0917b |
|
09-Apr-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: device_free_tx_buf use only ieee80211_tx_status_irqsafe TD_FLAGS_NETIF_SKB is only for data. Fixes issue of ack frames not being reported. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Cc: <stable@vger.kernel.org> # v3.19+ Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
32b249b0 |
|
06-Apr-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: device_intr check for vif on while loop vif should never be or go null while in loop. Fixes race condition where interrupts are late and when interface is not present. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
df140465 |
|
22-Apr-2015 |
Johannes Berg <johannes.berg@intel.com> |
mac80211: remove support for IFF_PROMISC This support is essentially useless as typically networks are encrypted, frames will be filtered by hardware, and rate scaling will be done with the intended recipient in mind. For real monitoring of the network, the monitor mode support should be used instead. Removing it removes a lot of corner cases. Signed-off-by: Johannes Berg <johannes.berg@intel.com>
|
#
a1c6dcda |
|
19-Mar-2015 |
Quentin Lambert <lambert.quentin@gmail.com> |
staging: vt6655: remove deprecated use of pci api Replace occurences of the pci api by appropriate call to the dma api. A simplified version of the semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr) @deprecated@ idexpression id; position p; @@ ( pci_dma_supported@p ( id, ...) | pci_alloc_consistent@p ( id, ...) ) @bad1@ idexpression id; position deprecated.p; @@ ...when != &id->dev when != pci_get_drvdata ( id ) when != pci_enable_device ( id ) ( pci_dma_supported@p ( id, ...) | pci_alloc_consistent@p ( id, ...) ) @depends on !bad1@ idexpression id; expression direction; position deprecated.p; @@ ( - pci_dma_supported@p ( id, + dma_supported ( &id->dev, ... + , GFP_ATOMIC ) | - pci_alloc_consistent@p ( id, + dma_alloc_coherent ( &id->dev, ... + , GFP_ATOMIC ) ) Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
1f51d580 |
|
07-Mar-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
vt6655: Fix late setting of byRFType. byRFType is not set prior to registration of mac80211 causing unpredictable operation after channel scans. With byRFType unset all channels are enabled this causes tx power to be set to values not present its eeprom. Move setting of this variable to vt6655_probe. byRFType must have a mask set. byRevId not used by driver and is removed. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Cc: <stable@vger.kernel.org> # v3.19+ Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
c3125305 |
|
09-Feb-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: vnt_tx_packet fix dma_idx selection. There is still a problem that dma_idx is causing packets to go onto the wrong tx path. Protect dma_idx fully with the present first lock and use pTDInfo->byFlags TD_FLAGS_NETIF_SKB to set MACvTransmit. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
bb72dd53 |
|
26-Feb-2015 |
Alex W Slater <alex.slater.dev@gmail.com> |
staging: vt6655: Cleanup C99 comments Fix checkpatch.pl errors: "ERROR: do not use C99 // comments" Signed-off-by: Alex W Slater <alex.slater.dev@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
d17f4c8a |
|
01-Feb-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: Fix TD_FLAGS_NETIF_SKB only on TYPE_AC0DMA Allow only TD_FLAGS_NETIF_SKB on ring buffer TYPE_AC0DMA for data only transfers for correct reporting of tx rates. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
64e4fd51 |
|
01-Feb-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: parse bb vga code out of device_intr. Reordering the code and reversing the priv->byBBVGANew verses priv->byBBVGACurrent check and using dev_dbg for pr_debug. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
187e2a81 |
|
01-Feb-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: move setting of PSTxDesc->buff_addr to vnt_tx_packet Keep setting of this part of the structure with the others. Only pTDInfo needs carried in the buffer structure. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
918185f6 |
|
19-Jan-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: device_init_registers alway set initial antenna mode BBvSetTxAntennaMode and BBvSetRxAntennaMode need to be set correcty on start up Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
e6f534bc |
|
19-Jan-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: remove antenna diversity functions The vendor had disabled these functions in their last version. On test this can be troublesome, so remove this from the driver along with its macros and timers. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
d7a4cfa8 |
|
19-Jan-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: set_channel replace parameter with ieee80211_channel replacing uConnectionChannel for hw_value as set in vnt_init_bands. This allows other signaling of ieee80211_channel to move deeper into driver. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
2a0a7b3d |
|
19-Jan-2015 |
Ahmad Hassan <ahmad.hassan612@gmail.com> |
staging: vt6655: fix space prohibted before that ',' This patch fixes the following checkpatch.pl error: fix space prohibited before that ',' Signed-off-by: Ahmad Hassan <ahmad.hassan612@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
b5745290 |
|
20-Dec-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: vnt_tx_packet Fix corrupted tx packets. Move PSTxDesc->m_td1TD1 to inside spin locks. if m_td1TD1.byTCR has TCR_EDP and TCR_STP are set, the interrupt handler will try and complete the buffer before it is completed. Usually on the tail of a burst of tx packets. This results in a partially completed packet being transmitted or worse sitll dead lock when skb is freed by the interrupt handler. Set head_td->m_td1TD1.byTCR to 0 in first lock of vnt_tx_packet to stop interrupt handler completing the buffer. Move Set TSR1 & ReqCount in s_cbFillTxBufHead to the second lock. cbReqCount is carried to the second lock in pTDInfo->dwReqCount without the padding removed. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
84c00afe |
|
21-Dec-2014 |
Mike Krinkin <krinkin.m.u@gmail.com> |
staging: vt6655: fix sparse warnings: incorrect argument type this patch fixes following sparse warnings: drivers/staging/vt6655/device_main.c:1503:25: warning: incorrect type in argument 1 (different address spaces) drivers/staging/vt6655/device_main.c:1503:25: expected void [noderef] <asn:2>*<noident> drivers/staging/vt6655/device_main.c:1503:25: got struct vnt_private * drivers/staging/vt6655/device_main.c:1503:25: warning: incorrect type in argument 2 (different address spaces) drivers/staging/vt6655/device_main.c:1503:25: expected void [noderef] <asn:2>*<noident> drivers/staging/vt6655/device_main.c:1503:25: got struct vnt_private * drivers/staging/vt6655/device_main.c:1505:25: warning: incorrect type in argument 1 (different address spaces) drivers/staging/vt6655/device_main.c:1505:25: expected void [noderef] <asn:2>*<noident> drivers/staging/vt6655/device_main.c:1505:25: got struct vnt_private * drivers/staging/vt6655/device_main.c:1505:25: warning: incorrect type in argument 2 (different address spaces) drivers/staging/vt6655/device_main.c:1505:25: expected void [noderef] <asn:2>*<noident> drivers/staging/vt6655/device_main.c:1505:25: got struct vnt_private * Signed-off-by: Mike Krinkin <krinkin.m.u@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
95775d12 |
|
11-Jan-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: [BUG] Protect MACvSelectPage1 with lock. The device must not flip to page 1 while in interrupt lock causing loss of connection or dead lock. Protect from changes to page by adding lock where user can change the page in CARDvSetRSPINF, vnt_configure and set_channel Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
b7c9cd45 |
|
04-Dec-2014 |
Sören Brinkmann <soeren.brinkmann@gmail.com> |
staging: vt6655: Declare vnt_init() static Fix sparse warning: drivers/staging/vt6655/device_main.c:1672:5: warning: symbol 'vnt_init' was not declared. Should it be static? Signed-off-by: Sören Brinkmann <soeren.brinkmann@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
738487ff |
|
12-Nov-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: card.c move __iomem into functions. Removing dereferencing from callers Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
6d35b1fc |
|
12-Nov-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: card Remove function vUpdateIFS vUpdateIFS does the same operations of CARDbSetPhyParameter there is not need to call this function. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
bf8918de |
|
07-Nov-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: change typedef enum _VIA_PKT_TYPE to macro Replacing for u8 type and removing cast for byBBType. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
bfb6c863 |
|
07-Nov-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: CARDbSetPhyParameter remove unused parameters wCapInfo byERPField, *pvSupportRateIEs *pvExtSupportRateIEs Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
a5f0eef3 |
|
06-Nov-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: baseband replace __iomem where caller is priv dereferenced. Replace with stucture vnt_private *priv in functions BBvSoftwareReset BBvSetTxAntennaMode BBvSetRxAntennaMode BBvSetDeepSleep BBvExitDeepSleep __iomem *dwIoBase will be moved into BBbWriteEmbedded and BBbReadEmbedded later. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
54fbb2da |
|
04-Nov-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: change tx wake queue Wake queue in the dwIsr loop of device_intr instead of device_tx_srv. This fixes an issue when ISR_TXDMA0 or ISR_AC0DMA does not occur device_tx_srv is not called and the queue gets stuck in stopped condition. On test if the queue is stuck another MACvTransmitAC0 or MACvTransmit0 in vnt_tx_packet will clear it. Check on vif that both buffers are available and the queue is stopped. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
2ee1ad7b |
|
05-Nov-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: device_set_options remove dead variables uConnectionRate wRTSThreshold byOpMode b11hEnable uChannel Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
bfa4b0fe |
|
05-Nov-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: device_init_registers remove uConnectionRate The device starts up with a default rate of 54M Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
ac875c17 |
|
05-Nov-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: device_set_options remove unused ethernet addresses Removing these variables abyBroadcastAddr abySNAP_RFC1042 abySNAP_Bridgetunnel Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
1b8e512b |
|
05-Nov-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: device_get_options remove unused device parameters IP_byte_align Channel PreambleType RTSThreshold ConnectionRate OPMode b80211hEnable Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
b1c41336 |
|
05-Nov-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: remove fragmentation from driver fragmentation is now handled by mac80211. Remove functions device_alloc_frag_buf device_init_defrag_cb device_free_frag_buf Removing typedef struct tagSDeFragControlBlock frag_thresh sRxDFCB cbDFCB; cbFreeDFCB; uCurrentDFCBIdx; macros FRAG_THRESH_MIN FRAG_THRESH_MAX Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
33785983 |
|
29-Oct-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: dead code remove wmgr.h on removal needs to be replaced by card.h in device.h Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
e11cdc39 |
|
29-Oct-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: remove typedef void *TimerFunction Covert functions TimerSQ3CallBack and TimerState1CallBack to the correct type for struct timer_list.function to remove the cast altogether. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
651a39ca |
|
29-Oct-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: dead code remove iocmd.h Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
47a2a3cb |
|
29-Oct-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: dead code remove iowpa.h Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
d54435d3 |
|
29-Oct-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: dead code remove tether.h Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
d853ce22 |
|
29-Oct-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: dead code remove bssdb.h header Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
37cc22b1 |
|
29-Oct-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: dead remove wcmd.h and typedefs CMD_STATE CMD_CODE CMD_ITEM Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
8ec94797 |
|
29-Oct-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: dead code remove vntwifi.h Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
b4ba0cb1 |
|
29-Oct-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: dead code remove wctl.c/h Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
5e6fc9d7 |
|
29-Oct-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: dead code remove tcrc.c/h Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
c49802bf |
|
29-Oct-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: deadcode remove wroute.c/h Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
f3de0df9 |
|
29-Oct-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: dead code datarate.c/h Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
2759e217 |
|
29-Oct-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: dead code remove wpactl.c/h All these functions are now dead. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
ee146490 |
|
29-Oct-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: dead code remove legacy hostap.c/h hoatap is now supported by mac80211 in nl80211 mode Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
ae1927eb |
|
29-Oct-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: dead code remove ioctl.c/h The driver nolonger supports these io functions Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
0d24c970 |
|
29-Oct-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: dead code remove iwctl.c/h The iw handler and functions are nolonger required. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
7af1ead4 |
|
29-Oct-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: dead code remove net device code All functions are dead and nolonger of use. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
f4cf678f |
|
29-Oct-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: deadcode remove zone file operations and vntconfiguration.dat These are now all handled by mac80211. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
c7b14ea0 |
|
29-Oct-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: reset tsf on dissociation Ensuring that tsf counter does not run while idle. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
d855802b |
|
29-Oct-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: don't update bUpdateBBVGA when off channel Check flag conf IEEE80211_CONF_OFFCHANNEL so that RSSI doesn't swing wildly on scanning. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
10d6f1b7 |
|
29-Oct-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: device_init_registers replace spin lock Use spin_lock_irqsave and spin_unlock_irqrestore. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
b4bdf94d |
|
29-Oct-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: vt6655_probe remove management pointers All these pointers are now dead. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
7e5d88d8 |
|
29-Oct-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: mac80211 conversion: device_error remove legacy functions Remove netif_stop_queue, bCmdRunning and timer functions Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
14e53006 |
|
29-Oct-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: mac80211 conversion: device_free_info Remove net device code and add mac80211 unregister code. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
1d6d3c1a |
|
29-Oct-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: mac80211 conversion: device_init_registers remove legacy code Remove pMgmt, byCurrentCh, VNTWIFIbConfigPhyMode, eEncryptionStatus and netif_stop_queue. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
59918bea |
|
29-Oct-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: mac80211 conversion: device_tx_srv tx and add report rates vnt_int_report_rate reports backs tx rate and is replacment for STAvUpdateTDStatCounter and BSSvUpdateNodeTxCounter. Replacing existing code. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
e70abceb |
|
29-Oct-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: mac80211 conversion: changes to device_intr Remove net device code. Remove current measure code and function s_vCompleteCurrentMeasure and switch code which are now handled by mac80211 Change beaconing to mac80211. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
bc5d431c |
|
29-Oct-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: mac80211 conversion: device_print_info remove netdevice. use dev_info for device name and pcid->irq for irq number. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
000fe0f5 |
|
29-Oct-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: mac80211 conversion replace suspend resume functions add vt6655_suspend and vt6655_resume remove viawget_suspend and viawget_resume. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
3d75b9e2 |
|
29-Oct-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: mac80211 conversion add channel bands Add rates and channels according to rf type for vnt_init_bands which is a mac80211 replacement for init_channel_table. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
67013f2c |
|
29-Oct-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: mac80211 conversion add main mac80211 functions Replace existing vt6655_probe with one converted to mac80211 with the following operations vnt_tx_80211 vnt_start vnt_stop vnt_add_interface vnt_remove_interface vnt_config vnt_bss_info_changed vnt_prepare_multicast vnt_configure vnt_set_key vnt_get_tsf vnt_set_tsf vnt_reset_tsf The following variables are also added. basic_rates mc_list_count mac_hw Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
33b1c8c1 |
|
29-Oct-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: mac80211 conversion: add new rx functions vnt_receive_frame which replaces device_receive_frame and vnt_rx_data which handles mac80211 rx data structures ieee80211_hw, ieee80211_vif and variable rx_rate are added in structure vnt_private Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
c42645a2 |
|
21-Oct-2014 |
Rasmus Villemoes <linux@rasmusvillemoes.dk> |
staging: vt6655: Remove redundant cast Both sides have type const struct iw_handler_def*, so the cast is unnecessary and confusing. Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
4a2bc3bd |
|
09-Oct-2014 |
Vladimir A. Nazarenko <naszar@ya.ru> |
staging: vt6655: delete SndEvt_ToAPI code It's never enabled, so we can safely remove it. Signed-off-by: Vladimir A. Nazarenko <naszar@ya.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
402eede3 |
|
08-Oct-2014 |
Vladimir A. Nazarenko <naszar@ya.ru> |
staging: vt6655: remove useless #if 1 There is code encapsulated in #if 1, let's remove it. Signed-off-by: Vladimir A. Nazarenko <naszar@ya.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
5ba1b07a |
|
08-Oct-2014 |
Vladimir A. Nazarenko <naszar@ya.ru> |
staging: vt6655: remove global variable wpa_Result This variable unused, so remove it. Signed-off-by: Vladimir A. Nazarenko <naszar@ya.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
25ef419d |
|
09-Oct-2014 |
Dilek Uzulmez <dilekuzulmez@gmail.com> |
staging: vt6655: Use ether_addr_copy function This patch fixes the following checkpatch.pl warnings: WARNING: "Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2)" in file device_main.c Pahole shows that the addresses are aligned Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
c5e11501 |
|
08-Oct-2014 |
Dilek Uzulmez <dilekuzulmez@gmail.com> |
staging: vt6655: Use ether_addr_copy function This patch fixes the following checkpatch.pl warnings: WARNING: "Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2)" in file device_main.c Pahole shows that the addresses are aligned Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
61d566a5 |
|
08-Oct-2014 |
Tapasweni Pathak <tapaswenipathak@gmail.com> |
staging: vt6655: Remove unnecessary cast for argument of kfree This patch removes all occurrences of unnecessary cast on the argument to kfree, all over in rtl8712. There is no need of the cast on the argument to kfree. Greped to find occurrences. Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
b7f0790d |
|
06-Oct-2014 |
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com> |
staging: vt6655: Fixed else after return or break warning. This patch fixes multiple instances of checkpatch.pl WARNING : else is not generally useful after a break or return in device_main.c Signed-off-by: Melike Yurtoglu <aysemelikeyurtoglu@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
a793b2d8 |
|
28-Sep-2014 |
Gulsah Kose <gulsah.1004@gmail.com> |
staging: vt6655: Type conversion was made. This patch fixes this sparse warning: drivers/staging/vt6655/device_main.c:385:40: warning: mixing different enum types drivers/staging/vt6655/device_main.c:385:40: int enum _VIA_BB_TYPE versus drivers/staging/vt6655/device_main.c:385:40: int enum _VIA_PKT_TYPE Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Acked-by: Julia Lawall <julia.lawall@lip6.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
9e23c1b8 |
|
24-Sep-2014 |
Aybuke Ozdemir <aybuke.147@gmail.com> |
Staging: vt6655: Add require space before that '(' This patch fixes checkpatch.pl error in file device_main.c ERROR: space required before the open parenthesis '(' Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
6e61b441 |
|
24-Sep-2014 |
Aybuke Ozdemir <aybuke.147@gmail.com> |
Staging: vt6655: Add require space after that ',' This patch fixes checkpatch.pl error in file device_main.c ERROR: space required after that ';' (ctx:VxV) Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
46fa0ec0 |
|
22-Sep-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: device_get_options remove unused variable devname Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
42f709ef |
|
22-Sep-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: pr_err remove string to net device name Just print driver name with dev_err removing the string formatting. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
22981e0e |
|
10-Sep-2014 |
Tobias Klauser <tklauser@distanz.ch> |
staging: vt6655: Use net_device_stats from struct net_device Instead of using an own copy of struct net_device_stats in struct vnt_private, use stats from struct net_device. Also remove the thus unnecessary device_get_stats(), as it would now just return netdev->stats, which is the default in dev_get_stats(). Signed-off-by: Tobias Klauser <tklauser@distanz.ch> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
c72f65cc |
|
04-Sep-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: device_free_info() warn: variable dereferenced before check pDevice is never NULL when this function is called remove the check. This fixes smatch warning drivers/staging/vt6655/device_main.c:1023 device_free_info() warn: variable dereferenced before check 'pDevice' (see line 1021) Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Cc: kbuild@01.org Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
a9873673 |
|
30-Aug-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: Replace typedef enum _CARD_OP_MODE eOPMode with enum nl80211_iftype op_mode. Using the nl80211 header. Using enum changes OP_MODE_ADHOC -> NL80211_IFTYPE_ADHOC OP_MODE_AP -> NL80211_IFTYPE_AP OP_MODE_INFRASTRUCTURE -> NL80211_IFTYPE_STATION OP_MODE_UNKNOWN -> NL80211_IFTYPE_UNSPECIFIED Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
93320258 |
|
30-Aug-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
stgaing: vt6655: remove unused variable wCTSDuration wCTSDuration is always set to 0. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
43e79c0f |
|
21-Aug-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: dead code remove device_nics variable The module can not load more than once. Remove device_nics, MAX_UINTS and OPTION_DEFAULT Remove dead index variable from device_get_options Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
33cfce64 |
|
21-Aug-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: remove multiple instances of netdevice. netdevice can only be created once. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
70afb8e5 |
|
21-Aug-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: remove multiple instances of driver loading. The driver can only load once from the instance provided by pci_dev. struct vnt_private next, prev and pDevice_Infos are removed. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
5154b0d0 |
|
20-Aug-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: device.h dead code remove bCCK bCCK is always set to true, the only place it is used is in BBvCalculateParameter which nots the value to false. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
97fe1ad0 |
|
17-Aug-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: main_usb.c remove undefined PLICE_DEBUG code. PLICE_DEBUG is not defined in any header for this file. Remove code, references and directives. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
b39d60c1 |
|
17-Aug-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: Use ether_crc in kernel. ether_crc is already in kernel remove local code and include linux/crc32.h Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
48caf5a0 |
|
17-Aug-2014 |
Joe Perches <joe@perches.com> |
staging: vt6655: Convert DBG_PRT to pr_<level> DBG_PRT uses are unnecessarily complex. Convert DBG_PRT msglevel to pr_<level>. This changes the KERN_<level> type of several uses. It also enables dynamic_debug for the pr_debug conversions. This patch can be a prelude to converting these pr_<level> uses to dev_<level> as appropriate. Other changes: Realign arguments of these conversions. Remove now unused static int msglevel declarations. Remove now unused DBG_PRT #define. Compile tested only. Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
1bd63757 |
|
10-Aug-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: device_main Replace DEVICE_INFO with size of pointer Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
3f8597f4 |
|
10-Aug-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: device.h use change __device_info to vnt_private Coverting all functions to struct vnt_private in device.h and device_main.c Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
f2af99ee |
|
09-Aug-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: Remove TxInSleep macro TxInSleep is always enabled remove the macro and any else code. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
8b983be5 |
|
08-Aug-2014 |
Joe Perches <joe@perches.com> |
staging: use pci_zalloc_consistent Remove the now unnecessary memset too. Signed-off-by: Joe Perches <joe@perches.com> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Lior Dotan <liodot@gmail.com> Cc: Christopher Harrer <charrer@alacritech.com> Cc: Forest Bond <forest@alittletooquiet.net> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
|
#
3500a1da |
|
28-Jul-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: clean up the tail of function device_init_registers Aligning the code. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
9f34de35 |
|
28-Jul-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: remove typedef enum __device_init_type The value is either DEVICE_INIT_COLD or DEVICE_INIT_DXPL making no difference to code. Remove typedef and remove if statement in device_init_registers pulling the code in. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
fbf515b8 |
|
28-Jul-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: dead code remove undefined macro IO_MAP This device is always memory mapped Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
33c1576e |
|
28-Jul-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: dead code remove undefined macro FOR_LED_ON_NOTEBOOK code. Removing all variables associated with the code. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
9a802f2e |
|
28-Jul-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: deadcode remove undefined macro THREAD code. Removing _RxManagementQueue, InitRxManagementQueue, MlmeThread, mlme_kill, EnQueue and DeQueue. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
795d644c |
|
28-Jul-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: remove undefined TASK_LET code Removing all code within and function MngWorkItem. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
70ae543b |
|
24-Jul-2014 |
Guillaume Clement <gclement@baobob.org> |
staging: vt6655: Remove NULL pointer sparse warning We were using 0 instead of NULL to initialize a pointer, which caused a sparse warning. Signed-off-by: Guillaume Clement <gclement@baobob.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
fa13849f |
|
24-Jul-2014 |
Guillaume Clement <gclement@baobob.org> |
staging: vt6655: add missing whitespace Some whitespace were missing, causing checkpatch warnings and altering readability. Signed-off-by: Guillaume Clement <gclement@baobob.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
a1613423 |
|
24-Jul-2014 |
Guillaume Clement <gclement@baobob.org> |
staging: vt6655: break single line if statements This fixes the "trailing statements should be on next line" checkpatch warning. Signed-off-by: Guillaume Clement <gclement@baobob.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
941ead9a |
|
24-Jul-2014 |
Guillaume Clement <gclement@baobob.org> |
staging: vt6655: Use pr_* functions instead of printk Lots of printk are used in vt6655, replace them with the pr_* equivalent. Signed-off-by: Guillaume Clement <gclement@baobob.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
84b50762 |
|
24-Jul-2014 |
Guillaume Clement <gclement@baobob.org> |
staging: vt6655: fix function braces not on the proper line Function braces should be on a separate line. Reported by checkpatch. Signed-off-by: Guillaume Clement <gclement@baobob.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
bfd7a281 |
|
24-Jul-2014 |
Guillaume Clement <gclement@baobob.org> |
staging: vt6655: Remove spaces before quoted newlines This fixes several spaces added just before a newline in debug strings, reported by checkpatch. Signed-off-by: Guillaume Clement <gclement@baobob.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
6b711271 |
|
24-Jul-2014 |
Guillaume Clement <gclement@baobob.org> |
staging: vt6655: Add missing blank lines after declarations This patch fixes the missing blank lines after declarations in vt6655 reported by checkpatch. Signed-off-by: Guillaume Clement <gclement@baobob.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
fe802546 |
|
24-Jul-2014 |
Guillaume Clement <gclement@baobob.org> |
staging: vt6655: remove useless return statements Many return statements in void function were present at the end of functions, with no effect. They now are removed. This fixes a bunch of checkpatch warnings. Signed-off-by: Guillaume Clement <gclement@baobob.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
6cff1f6a |
|
23-Jul-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: Fix Warning on boot handle_irq_event_percpu. WARNING: CPU: 0 PID: 929 at /home/apw/COD/linux/kernel/irq/handle.c:147 handle_irq_event_percpu+0x1d1/0x1e0() irq 17 handler device_intr+0x0/0xa80 [vt6655_stage] enabled interrupts Using spin_lock_irqsave appears to fix this. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Cc: <stable@vger.kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
8e3bec32 |
|
22-Jul-2014 |
Guillaume Clement <gclement@baobob.org> |
staging: vt6655: Fix unused function warning Sparse reports that MimeThread is not used. Actually, it can be used if THREAD is defined. By enclosing the MimeThread function into the same #ifdef as the caller of MimeThread, this fixes the sparse warnings. Signed-off-by: Guillaume Clement <gclement@baobob.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
9e4c5c28 |
|
22-Jul-2014 |
Guillaume Clement <gclement@baobob.org> |
staging: vt6655: statify some variables Some variables are used only in the context of their .c file, which gives warnings with sparse. Signed-off-by: Guillaume Clement <gclement@baobob.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
16834405 |
|
22-Jul-2014 |
Guillaume Clement <gclement@baobob.org> |
staging: vt6655: change type of PortOffset to void __iomem * PortOffset was an unsigned long, but used as an pointer to io memory. Sometimes it was not properly cast before use, which caused many warning by sparse. By updating its type to void __iomem *, and reflecting the changes where it is needed, this removes most of those warnings. Signed-off-by: Guillaume Clement <gclement@baobob.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
ebc43d09 |
|
31-May-2014 |
James A Shackleford <shack@linux.com> |
staging: vt6655: fix sparse warning "cast removes address space of expression" Add missing __user macro to second parameter of ethtool_ioctl(). This removes the need for the offending (void *) cast of the user space pointer rq->ifr_data. Signed-off-by: James A Shackleford <shack@linux.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
bc5cf656 |
|
19-Apr-2014 |
Guido Martínez <guido@vanguardiasur.com.ar> |
staging: vt6655: fix checkpatch bracing issues This patchs fixes tons of warnings such as: WARNING: braces {} are not necessary for single statement blocks #354: FILE: drivers/staging/vt6655/wmgr.c:354: + for (ii = 0; ii < WLAN_BSSID_LEN; ii++) { + pMgmt->abyDesireBSSID[ii] = 0xFF; + } Please note: this patch only fixes bracing issues (and there is still a lot to do); so if you run checkpatch it _will_ throw a lot of errors. Use --test-only=braces Signed-off-by: Guido Martínez <guido@vanguardiasur.com.ar> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
4e8a7e5f |
|
19-Apr-2014 |
Guido Martínez <guido@vanguardiasur.com.ar> |
staging: vt6655: remove dead code Remove dead code in many places on this driver. Signed-off-by: Guido Martínez <guido@vanguardiasur.com.ar> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
41e043fc |
|
02-Dec-2013 |
Jingoo Han <jg1.han@samsung.com> |
staging: remove DEFINE_PCI_DEVICE_TABLE macro Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred. Signed-off-by: Jingoo Han <jg1.han@samsung.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
1208f14a |
|
10-Nov-2013 |
Teodora Baluta <teobaluta@gmail.com> |
staging: vt6655: delete explicit comparison to bool This patch fixes the following type of coccinelle detected warnings for driver vt6655: WARNING: Comparison to bool Signed-off-by: Teodora Baluta <teobaluta@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
27e81107 |
|
20-Sep-2013 |
Sachin Kamat <sachin.kamat@linaro.org> |
staging: vt6655: Remove redundant pci_set_drvdata Driver core sets driver data to NULL upon failure or remove. Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
6496c045 |
|
27-Jun-2013 |
Yijing Wang <wangyijing@huawei.com> |
vt6655/trivial: replace numeric with standard PM state macros Use standard PM state macros PCI_Dx instead of numeric 0/1/2.. Signed-off-by: Yijing Wang <wangyijing@huawei.com> Cc: Forest Bond <forest@alittletooquiet.net> Cc: Jiri Kosina <trivial@kernel.org> Cc: Devendra Naga <devendra.aaru@gmail.com> Cc: Joe Perches <joe@perches.com> Cc: Marcos Paulo de Souza <marcos.souza.org@gmail.com> Cc: Bill Pemberton <wfp5p@virginia.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
f805442e |
|
06-Apr-2013 |
Al Viro <viro@zeniv.linux.org.uk> |
vt6655: slightly clean reading config file Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
|
#
96d69e20 |
|
18-Mar-2013 |
Joe Perches <joe@perches.com> |
staging: vt6655: Remove unnecessary blank lines Remove a bunch of useless vertical whitespace. Convert 3 or more consecutive newlines to 2. Remove blank lines after open brace and before close brace. Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
a7307538 |
|
18-Mar-2013 |
Joe Perches <joe@perches.com> |
staging: vt6655: Remove commented out if()s Commented out code is just noise. Remove them. Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
5e0cc8a2 |
|
18-Mar-2013 |
Joe Perches <joe@perches.com> |
staging: vt6655: Convert to kernel brace style Move braces around to be more kernel like. Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
f2046f93 |
|
18-Mar-2013 |
Joe Perches <joe@perches.com> |
staging: vt6655: Remove commented out printks These are just noise in the code so remove them. Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
915006cd |
|
18-Mar-2013 |
Joe Perches <joe@perches.com> |
staging:vt6655:device_main: Whitespace cleanups Neatening only. git diff -w shows no differences. Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
f4e1b7c8 |
|
19-Nov-2012 |
Bill Pemberton <wfp5p@virginia.edu> |
staging: vt6655: remove use of __devexit CONFIG_HOTPLUG is going away as an option so __devexit is no longer needed. Signed-off-by: Bill Pemberton <wfp5p@virginia.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
a1179b20 |
|
19-Nov-2012 |
Bill Pemberton <wfp5p@virginia.edu> |
staging: vt6655: remove use of __devinit CONFIG_HOTPLUG is going away as an option so __devinit is no longer needed. Signed-off-by: Bill Pemberton <wfp5p@virginia.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
960cf811 |
|
06-Sep-2012 |
Devendra Naga <devendra.aaru@gmail.com> |
staging: vt6655: vt6655_init_info function must be void type this is because it doesn't fail anywhere and returning a value from it will be completely unnecesary. Signed-off-by: Devendra Naga <devendra.aaru@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
cfd1fc1f |
|
06-Sep-2012 |
Devendra Naga <devendra.aaru@gmail.com> |
staging: vt6655: return ENOMEM rather than ENODEV when alloc_etherdev fail when alloc_etherdev fails we should be returning ENOMEM, not ENODEV Signed-off-by: Devendra Naga <devendra.aaru@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
502eb536 |
|
06-Sep-2012 |
Devendra Naga <devendra.aaru@gmail.com> |
staging: vt6655: fix coding style problem at assigning netdev_ops we are using spaces at the beginning of the line, we should use tabs instead Signed-off-by: Devendra Naga <devendra.aaru@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
bf76ebd9 |
|
06-Sep-2012 |
Devendra Naga <devendra.aaru@gmail.com> |
staging: vt6655: fix coding style issues in device_get_options a) put the device_get_options functions' opening brace below b) replace spaces with tabs Signed-off-by: Devendra Naga <devendra.aaru@gmail.com> Acked-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
3ac9e0fd |
|
06-Sep-2012 |
Devendra Naga <devendra.aaru@gmail.com> |
staging: vt6655: fix coding style warnings a) replace spaces with tabs b) put the opening brace of get_chip_name below it Signed-off-by: Devendra Naga <devendra.aaru@gmail.com> Acked-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
623b2b39 |
|
20-Aug-2012 |
Justin P. Mattock <justinmattock@gmail.com> |
staging: "vt6655" Typo change *Embeded to *Embedded. Signed-off-by: Justin P. Mattock <justinmattock@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
789d1aef |
|
20-Aug-2012 |
Justin P. Mattock <justinmattock@gmail.com> |
staging: "vt6655" Fix typos in comments. Signed-off-by: Justin P. Mattock <justinmattock@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
27e3b901 |
|
08-Jul-2012 |
Marcos Paulo de Souza <marcos.souza.org@gmail.com> |
staging: vt6655: Remove all commented macros These macros were reported by forgotten-macros tool (https://github.com/marcosps/forgotten_macros). Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
2478ef57 |
|
08-Jul-2012 |
Marcos Paulo de Souza <marcos.souza.org@gmail.com> |
staging: vt6655: Remove all "if 0" blocks from driver This commit removes code that will never be executed by vt6655 driver. Was the forgotten-macros tool(https://github.com/marcosps/forgotten_macros) who reported these blocks for us. Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
428c1fb5 |
|
28-Nov-2011 |
Marcos Paulo de Souza <marcos.mage@gmail.com> |
staging:vt6656: iwctl.c: Removed unneeded function Removed the function iwctl_giwnwid, that just return a error code. Changes v1 to v2: Removed same functions of vt6655 and vt6656. Signed-off-by: Marcos Paulo de Souza <marcos.mage@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
30d6a2b8 |
|
26-Jul-2011 |
Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
staging: vt6655: simplify MAC printing by using %pM Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
afc4b13d |
|
16-Aug-2011 |
Jiri Pirko <jpirko@redhat.com> |
net: remove use of ndo_set_multicast_list in drivers replace it by ndo_set_rx_mode Signed-off-by: Jiri Pirko <jpirko@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
|
#
9fc86028 |
|
10-Apr-2011 |
Joe Perches <joe@perches.com> |
staging: Remove unnecessary semicolons when if (foo) {...}; Done via perl script: $ cat remove_semi_if.pl my $match_balanced_parentheses = qr/(\((?:[^\(\)]++|(?-1))*\))/; my $match_balanced_braces = qr/(\{(?:[^\{\}]++|(?-1))*\})/; foreach my $file (@ARGV) { my $f; my $text; my $oldtext; next if ((-d $file)); open($f, '<', $file) or die "$P: Can't open $file for read\n"; $oldtext = do { local($/) ; <$f> }; close($f); next if ($oldtext eq ""); $text = $oldtext; my $count = 0; do { $count = 0; $count += $text =~ s@\b(if\s*${match_balanced_parentheses}\s*)${match_balanced_braces}\s*;@"$1$3"@egx; } while ($count > 0); if ($text ne $oldtext) { my $newfile = $file; open($f, '>', $newfile) or die "$P: Can't open $newfile for write\n"; print $f $text; close($f); } } $ Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
25985edc |
|
30-Mar-2011 |
Lucas De Marchi <lucas.demarchi@profusion.mobi> |
Fix common misspellings Fixes generated by 'codespell' and manually reviewed. Signed-off-by: Lucas De Marchi <lucas.demarchi@profusion.mobi>
|
#
6403bb7d |
|
12-Mar-2011 |
Ilia Mirkin <imirkin@alum.mit.edu> |
staging: vt6655: Remove NULL check before kfree This patch was generated by the following semantic patch: // <smpl> @@ expression E; @@ - if (E != NULL) { kfree(E); } + kfree(E); @@ expression E; @@ - if (E != NULL) { kfree(E); E = NULL; } + kfree(E); + E = NULL; // </smpl> Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
0ffa3db9 |
|
24-Feb-2011 |
Justin P. Mattock <justinmattock@gmail.com> |
staging: vt6655: device_main.c remove one to many l's in the word. The patch below removes an extra "l" in the word. Signed-off-by: Justin P. Mattock <justinmattock@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
34381c22 |
|
10-Jan-2011 |
Peter Huewe <peterhuewe@gmx.de> |
staging/vt6655: fix sparse warning "obsolete struct initializer" This patch fixes the sparse warnings "obsolete struct initializer, use C99 syntax" in vt6655/device_main.c by converting the struct to C99 syntax KernelVersion: linux-next-20110110 Signed-off-by: Peter Huewe <peterhuewe@gmx.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
13b631a5 |
|
03-Aug-2010 |
Kulikov Vasiliy <segooon@gmail.com> |
staging: vt6655: do not use PCI resources before pci_enable_device() IRQ and resource[] may not have correct values until after PCI hotplug setup occurs at pci_enable_device() time. The semantic match that finds this problem is as follows: // <smpl> @@ identifier x; identifier request ~= "pci_request.*|pci_resource.*"; @@ ( * x->irq | * x->resource | * request(x, ...) ) ... *pci_enable_device(x) // </smpl> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
7b6a0013 |
|
01-Aug-2010 |
Charles Clément <caratorn@gmail.com> |
Staging: vt6655: replace BOOL with in kernel bool Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
5a5a2a6a |
|
01-Aug-2010 |
Charles Clément <caratorn@gmail.com> |
Staging: vt6655: replace FALSE with in kernel false Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
1b12068a |
|
01-Aug-2010 |
Charles Clément <caratorn@gmail.com> |
Staging: vt6655: replace TRUE with in kernel true Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
5bddefad |
|
03-Jul-2010 |
Kulikov Vasiliy <segooon@gmail.com> |
Staging: vt6655: use for_each_pci_dev() Use for_each_pci_dev() to simplify the code. Signed-off-by: Kulikov Vasiliy <segooon@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
3fc9b584 |
|
24-Jun-2010 |
Charles Clément <caratorn@gmail.com> |
Staging: vt6655: remove BYTE typedef Replace all occurrences with unsigned char type. Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
2986db5f |
|
24-Jun-2010 |
Charles Clément <caratorn@gmail.com> |
Staging: vt6655: remove WORD typedef Replace all occurrences with unsigned short type. Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
0f4c60d6 |
|
24-Jun-2010 |
Charles Clément <caratorn@gmail.com> |
Staging: vt6655: remove DWORD typedef Replace all occurrences with unsigned long type, except for pointer fields that should be u32 in packed structures and 8-byte-aligned 8 byte long structure QWORD. Thanks to Jiri Slaby for pointing out that simply replacing by unsigned long is wrong on x86-64 arch. Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
79566eb2 |
|
21-Jun-2010 |
Charles Clément <caratorn@gmail.com> |
Staging: vt6655: move channel mapping code from card.c to channel.c Move functions managing the channel mapping to a new channel.c file, as done in the staging VT6656 driver. The function names contained in card.c were prefixed with CARD followed by the first letter of the return code, remove this and use more coherent function names. The following functions moved and were renamed: ChannelValid -> is_channel_valid CARDbSetChannel -> set_channel CARDvInitChannelTable -> init_channel_table CARDbyGetChannelMapping -> get_channel_mapping CARDvSetCountryInfo -> set_country_info CARDbySetSupportChannels -> set_support_channels CARDbChannelGetList -> channel_get_list CARDvSetCountryIE -> set_country_IE CARDbGetChannelMapInfo -> get_channel_map_info CARDvSetChannelMapInfo -> set_channel_map_info CARDvClearChannelMapInfo -> clear_channel_map_info CARDbyAutoChannelSelect -> auto_channel_select CARDbyGetChannelNumber -> get_channel_number Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
013a468c |
|
15-Jun-2010 |
Charles Clément <caratorn@gmail.com> |
Staging: vt6655: struct pci_driver cleanup Rename driver struct and callbacks to vt6655_* instead of device_* and add __devinit/__devexit directives. Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
15df6c2b |
|
05-Jun-2010 |
Charles Clément <caratorn@gmail.com> |
Staging: vt6655: remove PWORD typedef Use unsigned short * instead. Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
2989e96f |
|
05-Jun-2010 |
Charles Clément <caratorn@gmail.com> |
Staging: vt6655: remove PBYTE typedef Use unsigned char * instead. Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
e3fd16d0 |
|
02-Jun-2010 |
Charles Clément <caratorn@gmail.com> |
Staging: vt6655: remove custom ULONG typedef Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
b6e95cd5 |
|
02-Jun-2010 |
Charles Clément <caratorn@gmail.com> |
Staging: vt6655: remove custom UINT typedef Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
5c9824e1 |
|
02-Jun-2010 |
Charles Clément <caratorn@gmail.com> |
Staging: vt6655: remove custom UCHAR typedef Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
b83cc2ed |
|
01-Jun-2010 |
Charles Clément <caratorn@gmail.com> |
Staging: vt6655: remove custom LONG typedef Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
7ca30195 |
|
01-Jun-2010 |
Charles Clément <caratorn@gmail.com> |
Staging: vt6655: remove custom INT typedef Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
902d2411 |
|
28-May-2010 |
Charles Clément <caratorn@gmail.com> |
Staging: vt6655: remove U32 custom macro Remove custom macro for unsigned 32-bit integers, replace by u32. Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
c17ce8c2 |
|
28-May-2010 |
Charles Clément <caratorn@gmail.com> |
Staging: vt6655: remove U16 custom macro Remove custom macro for unsigned 16-bit integers. Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
737c3d70 |
|
28-May-2010 |
Charles Clément <caratorn@gmail.com> |
Staging: vt6655: remove U8 custom macro Remove custom macro for unsigned 8-bit integers. Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
670ea81e |
|
19-May-2010 |
Charles Clément <caratorn@gmail.com> |
Staging: vt6655: use is_multicast_ether_addr instead of custom macro Replace custom macro IS_MULTICAST_ADDRESS by is_multicast_ether_addr from <linux/etherdevice.h>. Remove linux/if_ether.h include as it is included in linux/etherdevice.h already. Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
31c21b77 |
|
18-May-2010 |
Charles Clément <caratorn@gmail.com> |
Staging: vt6655: use ETH_DATA_LEN macro instead of custom one Replace custom maximum data lenght definition MAX_DATA_LEN by ETH_DATA_LEN from <linux/if_ether.h>. Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
96fe9ee2 |
|
14-May-2010 |
Charles Clément <caratorn@gmail.com> |
Staging: vt6655: use ETH_HLEN macro instead of custom one Replaced custom header length definition U_HEADER_LEN by ETH_HLEN from <linux/if_ether.h>. Also remove unused U_TYPE_LEN. Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
078b078f |
|
14-May-2010 |
Charles Clément <caratorn@gmail.com> |
Staging: vt6655: use ETH_ALEN macro instead of custom one Replaced custom ethernet address length definition U_ETHER_ADDR_LEN by ETH_ALEN from <linux/if_ether.h>. Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
3a215e0f |
|
12-May-2010 |
Charles Clément <caratorn@gmail.com> |
Staging: vt6655: remove IN definition Remove empty IN definition used to specify input parameters. Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
e64354c0 |
|
12-May-2010 |
Charles Clément <caratorn@gmail.com> |
Staging: vt6655: remove HANDLE definition and use Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
32414878 |
|
11-May-2010 |
Julia Lawall <julia@diku.dk> |
Staging: Drop memory allocation cast Drop cast on the result of kmalloc and similar functions. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ type T; @@ - (T *) (\(kmalloc\|kzalloc\|kcalloc\|kmem_cache_alloc\|kmem_cache_zalloc\| kmem_cache_alloc_node\|kmalloc_node\|kzalloc_node\)(...)) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
f6551527 |
|
09-May-2010 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: vt6655: Fix kernel BUG on driver wpa initialization In http://bugzilla.novell.com/show_bug.cgi?id=597299, the vt6655 driver generates a kernel BUG on a NULL pointer dereference at NULL. This problem has been traced to a failure in the wpa_set_wpadev() routine. As the vt6656 driver does not call this routine, the vt6655 code is similarly set to skip the call. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Tested-by: Richard Meek <osl2008@googlemail.com> Cc: Stable <stable@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
830a619c |
|
07-May-2010 |
Charles Clément <caratorn@gmail.com> |
Staging: vt6655: remove PVOID definition and use Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
6b35b7b3 |
|
07-May-2010 |
Charles Clément <caratorn@gmail.com> |
Staging: vt6655: remove VOID definition and use Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
ecf739e6 |
|
17-Apr-2010 |
Forest Bond <forest@alittletooquiet.net> |
Staging: vt6655: Rename hostap_set_hostapd, hostap_iotctl. The functions hostap_set_hostapd, hostap_iotctl clashed with functions of the same name with CONFIG_HOSTAP=y and/or CONFIG_VT6656=y. Signed-off-by: Forest Bond <forest@alittletooquiet.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
d2c6170b |
|
24-Mar-2010 |
Joe Perches <joe@perches.com> |
Staging: vt6655: Hoist assign from if Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
646755ad |
|
22-Mar-2010 |
Roel Kluin <roel.kluin@gmail.com> |
Staging: vt6655: CGI/CSI confusion in device_ioctl() The wrong messages were printed Signed-off-by: Roel Kluin <roel.kluin@gmail.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
22bedad3 |
|
01-Apr-2010 |
Jiri Pirko <jpirko@redhat.com> |
net: convert multicast list to list_head Converts the list and the core manipulating with it to be the same as uc_list. +uses two functions for adding/removing mc address (normal and "global" variant) instead of a function parameter. +removes dev_mcast.c completely. +exposes netdev_hw_addr_list_* macros along with __hw_addr_* functions for manipulation with lists on a sandbox (used in bonding and 80211 drivers) Signed-off-by: Jiri Pirko <jpirko@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
|
#
5a0e3ad6 |
|
24-Mar-2010 |
Tejun Heo <tj@kernel.org> |
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h percpu.h is included by sched.h and module.h and thus ends up being included when building most .c files. percpu.h includes slab.h which in turn includes gfp.h making everything defined by the two files universally available and complicating inclusion dependencies. percpu.h -> slab.h dependency is about to be removed. Prepare for this change by updating users of gfp and slab facilities include those headers directly instead of assuming availability. As this conversion needs to touch large number of source files, the following script is used as the basis of conversion. http://userweb.kernel.org/~tj/misc/slabh-sweep.py The script does the followings. * Scan files for gfp and slab usages and update includes such that only the necessary includes are there. ie. if only gfp is used, gfp.h, if slab is used, slab.h. * When the script inserts a new include, it looks at the include blocks and try to put the new include such that its order conforms to its surrounding. It's put in the include block which contains core kernel includes, in the same order that the rest are ordered - alphabetical, Christmas tree, rev-Xmas-tree or at the end if there doesn't seem to be any matching order. * If the script can't find a place to put a new include (mostly because the file doesn't have fitting include block), it prints out an error message indicating which .h file needs to be added to the file. The conversion was done in the following steps. 1. The initial automatic conversion of all .c files updated slightly over 4000 files, deleting around 700 includes and adding ~480 gfp.h and ~3000 slab.h inclusions. The script emitted errors for ~400 files. 2. Each error was manually checked. Some didn't need the inclusion, some needed manual addition while adding it to implementation .h or embedding .c file was more appropriate for others. This step added inclusions to around 150 files. 3. The script was run again and the output was compared to the edits from #2 to make sure no file was left behind. 4. Several build tests were done and a couple of problems were fixed. e.g. lib/decompress_*.c used malloc/free() wrappers around slab APIs requiring slab.h to be added manually. 5. The script was run on all .h files but without automatically editing them as sprinkling gfp.h and slab.h inclusions around .h files could easily lead to inclusion dependency hell. Most gfp.h inclusion directives were ignored as stuff from gfp.h was usually wildly available and often used in preprocessor macros. Each slab.h inclusion directive was examined and added manually as necessary. 6. percpu.h was updated not to include slab.h. 7. Build test were done on the following configurations and failures were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my distributed build env didn't work with gcov compiles) and a few more options had to be turned off depending on archs to make things build (like ipr on powerpc/64 which failed due to missing writeq). * x86 and x86_64 UP and SMP allmodconfig and a custom test config. * powerpc and powerpc64 SMP allmodconfig * sparc and sparc64 SMP allmodconfig * ia64 SMP allmodconfig * s390 SMP allmodconfig * alpha SMP allmodconfig * um on x86_64 SMP allmodconfig 8. percpu.h modifications were reverted so that it could be applied as a separate patch and serve as bisection point. Given the fact that I had only a couple of failures from tests on step 6, I'm fairly confident about the coverage of this conversion patch. If there is a breakage, it's likely to be something in one of the arch headers which should be easily discoverable easily on most builds of the specific arch. Signed-off-by: Tejun Heo <tj@kernel.org> Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org> Cc: Ingo Molnar <mingo@redhat.com> Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
|
#
00367a6d |
|
28-Dec-2009 |
H Hartley Sweeten <hartleys@visionengravers.com> |
Staging: vt6655/device_main.c: use %pM to shown MAC address Trivial, use the %pM kernel extension to display the MAC address. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Forest Bond <forest@alittletooquiet.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
d5907942 |
|
17-Feb-2010 |
Jiri Pirko <jpirko@redhat.com> |
staging: convert to use netdev_for_each_mc_addr removed needless checks in arlan-main.c and slicoss.c fixed bug in et131x_netdev.c to actually fill addresses in. Signed-off-by: Jiri Pirko <jpirko@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
|
#
4cd24eaf |
|
07-Feb-2010 |
Jiri Pirko <jpirko@redhat.com> |
net: use netdev_mc_count and netdev_mc_empty when appropriate This patch replaces dev->mc_count in all drivers (hopefully I didn't miss anything). Used spatch and did small tweaks and conding style changes when it was suitable. Jirka Signed-off-by: Jiri Pirko <jpirko@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
|
#
bbc9a991 |
|
14-Nov-2009 |
André Goddard Rosa <andre.goddard@gmail.com> |
Staging: fix assorted typos all over the place Signed-off-by: André Goddard Rosa <andre.goddard@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
03cd7136 |
|
07-Aug-2009 |
Roel Kluin <roel.kluin@gmail.com> |
Staging: vt6655: fix possible Read buffer overflow If pDevice->sOpts.nRxDescs{0,1} or nTxDescs[{0,1}] is zero, the loop ends with i == 0, and we write aRD{0,1}Ring[-1]. apTD{0,1}Rings[-1] respectively. Signed-off-by: Roel Kluin <roel.kluin@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
256a816b |
|
12-Aug-2009 |
Jim Lieb <lieb@canonical.com> |
Staging: vt665x: remove tbit.h part 2 Remove use of tbit macros adn remove header file. Signed-off-by: Jim Lieb <lieb@canonical.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
1e5743ca |
|
12-Aug-2009 |
Jim Lieb <lieb@canonical.com> |
Staging: vt665x: remove tpci.h file Convert pci register/command defs to use kernel definitions. Remove tpci.h. Signed-off-by: Jim Lieb <lieb@canonical.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
a7ad322a |
|
12-Aug-2009 |
Jim Lieb <lieb@canonical.com> |
Staging: vt665x: Clean up include files, Part 2 Remove cplusplus lines from include files Remove needless ifdefs on includes to conform with C conventions. Remove misc commented code/includes Update TODO Signed-off-by: Jim Lieb <lieb@canonical.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
a884847a |
|
12-Aug-2009 |
Jim Lieb <lieb@canonical.com> |
Staging: vt665x: Typedef and macro cleanup Part 2 Clean up unused typedefs and macros to remove Win32'isms and misc non-linux constructs. Text edits to referencing source for less frequently used macros. Signed-off-by: Jim Lieb <lieb@canonical.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
7e809a9b |
|
30-Jul-2009 |
Jim Lieb <lieb@canonical.com> |
Staging: vt6655 textual cleanup in prep for driver merge The vt6655 and vt6656 drivers are from a common origin but have drifted apart with minor textual differences. There are two changes: s/DEVICE_PRT/DBG_PRT/g and s/byPktTyp/byPktType/g This significantly reduces the differences between the two file sets in preparation to merging the common code. A few whitespace and text bits were also adjusted. Signed-off-by: Jim Lieb <lieb@canonical.com> Cc: Forest Bond <forest@alittletooquiet.net> Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
db6cb903 |
|
23-Jul-2009 |
Jim Lieb <lieb@canonical.com> |
Staging: vt665x: 64bit compile fixes Part 1 Fix compile problems with 64bit. These issues could cause corrupted address crashes. In the process, replaced some definitions to use more portable kernel types. Signed-off-by: Jim Lieb <lieb@canonical.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
83a27326 |
|
10-Jul-2009 |
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> |
Staging: vt6655: remove PRIVATE_OBJ ifdefs Cc: Forest Bond <forest@alittletooquiet.net> Cc: Alexander Beregalov <a.beregalov@gmail.com> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
e882335b |
|
04-Jul-2009 |
Alexander Beregalov <a.beregalov@gmail.com> |
Staging: vt665x: depend on WIRELESS_EXT Make vt665x depended on WIRELESS_EXT and remove remain ifdef's Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com> Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
4c47b34c |
|
20-Jun-2009 |
Alexander Beregalov <a.beregalov@gmail.com> |
Staging: vt6655: remove dependency on WIRELESS_EXT version As the driver is in mainline now we can remove such dependencies. WIRELESS_EXT is 22 now. Cc: Forest Bond <forest@alittletooquiet.net> Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
761e9549 |
|
20-Jun-2009 |
Alexander Beregalov <a.beregalov@gmail.com> |
Staging: vt6655: fix build when !CONFIG_WIRELESS_EXT Fix this build error when CONFIG_WIRELESS_EXT is not set: drivers/staging/vt6655/device_main.c:1153: error: 'struct net_device' has no member named 'wireless_handlers' Cc: Forest Bond <forest@alittletooquiet.net> Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
f408adeb |
|
10-Jun-2009 |
Alan Cox <alan@linux.intel.com> |
Staging: vt6655: compile fix At least make it compile Signed-off-by: Alan Cox <alan@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
57211354 |
|
02-Jun-2009 |
Forest Bond <forest@alittletooquiet.net> |
Staging: vt6655: use net_device_ops for management functions vt6655: use net_device_ops for management functions Signed-off-by: Forest Bond <forest@alittletooquiet.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
7bb8dc2d |
|
01-Jun-2009 |
Forest Bond <forest@alittletooquiet.net> |
Staging: vt6655: Remove LINUX_VERSION_CODE preprocessor conditionals. vt6655: Remove LINUX_VERSION_CODE preprocessor conditionals. Signed-off-by: Forest Bond <forest@alittletooquiet.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
c9d03529 |
|
01-Jun-2009 |
Forest Bond <forest@alittletooquiet.net> |
Staging: vt6655: Replace net_device->priv accesses with netdev_priv calls. vt6655: Replace net_device->priv accesses with netdev_priv calls. Signed-off-by: Forest Bond <forest@alittletooquiet.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
756f94e6 |
|
25-Apr-2009 |
Forest Bond <forest@alittletooquiet.net> |
Staging: vt6655: Drop obsolete fsuid/fsgid accesses. drivers/staging/vt6655/device_main.c: Drop obsolete fsuid/fsgid accesses. Signed-off-by: Forest Bond <forest@alittletooquiet.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
5449c685 |
|
25-Apr-2009 |
Forest Bond <forest@alittletooquiet.net> |
Staging: Add pristine upstream vt6655 driver sources Add pristine upstream vt6655 driver sources to drivers/staging/vt6655. These files were literally copied from the driver directory in the upstream source archive, available here: http://www.viaarena.com/Driver/vt6655_linux_src_v1.19.12_x86.zip Signed-off-by: Forest Bond <forest@alittletooquiet.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|