#
e9a2aba0 |
|
16-Oct-2023 |
Gilbert Adikankwu <gilbertadikankwu@gmail.com> |
staging: vt6655: Rename variable bUpdateBBVGA Remove bool Type encoding "b" from variable name and replace camelcase with snakecase. Mute checkpatch.pl error: CHECK: Avoid CamelCase: <bUpdateBBVGA> Signed-off-by: Gilbert Adikankwu <gilbertadikankwu@gmail.com> Link: https://lore.kernel.org/r/9bd935c464671db2654c654964812cc48f4603d3.1697495598.git.gilbertadikankwu@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
f5640b0c |
|
08-Oct-2023 |
Pavan Bobba <opensource206@gmail.com> |
staging: vt6655: Type encoding info dropped from variable name "byBBVGACurrent" variable name "byBBVGACurrent" updated like below: a.type encoding info dropped from name b.camelcase name replaced by snakecase Issue found by checkpatch Signed-off-by: Pavan Bobba <opensource206@gmail.com> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/f0dfd4d2460f858540d465dd8bcfc920c219e94d.1696791459.git.opensource206@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
11b896e6 |
|
08-Oct-2023 |
Pavan Bobba <opensource206@gmail.com> |
staging: vt6655: Type encoding info dropped from array name "abyBBVGA" array name "abyBBVGA" updated like below: a.type encoding info dropped from name b.camelcase name replaced by snakecase Issue found by checkpatch Signed-off-by: Pavan Bobba <opensource206@gmail.com> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/13a233dff4d6daf728f75ab18b38ec9d0703764b.1696791459.git.opensource206@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
eb507641 |
|
21-Sep-2023 |
Pavan Bobba <opensource206@gmail.com> |
staging: vt6655: Type encoding info dropped from variable "byRFType" variable name "byRFType" updated like below: a.type encoding info dropped from name b.camelcase name replaced by snakecase Issue found by checkpatch Signed-off-by: Pavan Bobba <opensource206@gmail.com> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/ZQwyRXFHA9hTLcyv@ubuntu.myguest.virtualbox.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
14410001 |
|
13-Sep-2023 |
Pavan Bobba <opensource206@gmail.com> |
staging: vt6655: Type encoding info dropped from array name "byVT3253B0_" Array names starting with "byVT3253B0_" updated like below: a.type encoding info dropped from names b.camelcase names replaced by snakecase Issue found by checkpatch Signed-off-by: Pavan Bobba <opensource206@gmail.com> Link: https://lore.kernel.org/r/ZQGiqA2GoDp/WiPK@ubuntu.myguest.virtualbox.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
722de0e6 |
|
14-Aug-2023 |
Pavan Bobba <opensource206@gmail.com> |
staging: vt6655: replace camel case by snake case Replace array name of camel case by snake case. Issue found by checkpatch Signed-off-by: Pavan Bobba <opensource206@gmail.com> Link: https://lore.kernel.org/r/ZNotXWJbJU1Gi2Gx@ubuntu.myguest.virtualbox.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
5001d664 |
|
17-Mar-2023 |
Michael Straube <straube.linux@gmail.com> |
staging: vt6655: remove unused bb_power_save_mode_off() function The function bb_power_save_mode_off() is not used anywhere, remove it. Signed-off-by: Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20230317065041.16635-3-straube.linux@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
d32a62ac |
|
17-Mar-2023 |
Michael Straube <straube.linux@gmail.com> |
staging: vt6655: remove unused bb_power_save_mode_on() function The function bb_power_save_mode_on() is not used anywhere, remove it. Signed-off-by: Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20230317065041.16635-2-straube.linux@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
4f7730e0 |
|
28-Aug-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6655: Replace macro MACvSetRFLE_LatchBase Replace macro MACvSetRFLE_LatchBase with the called function as it is just used once and to avoid CamelCase which is not accepted by checkpatch.pl. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/624068fef03d5226e3fb2d31d47e9dabc5562b3c.1661666677.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
67ec5576 |
|
12-Jul-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6655: Rename MACvRegBitsOn Fix name of a macro that uses CamelCase which is not accepted by checkpatch.pl Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/7fb9627441ff97897d132c62d59676355b6d14ea.1657657918.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
a18263eb |
|
22-May-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6655: Replace VNSvOutPortD with iowrite32 Replace macro VNSvOutPortD with iowrite32 because it replaces just one line. The name of macro and the arguments use CamelCase which is not accepted by checkpatch.pl Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/03b6ff0250aa797f45a855ff2fc76f8013f73dc0.1653203927.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
404079e7 |
|
08-May-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6655: Replace VNSvOutPortB with iowrite8 Replace macro VNSvOutPortB with iowrite8 because it replaces just one line. The name of macro and the arguments use CamelCase which is not accepted by checkpatch.pl Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/38611512677a18f63d9266cde1d20758c0feeb6e.1651957741.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
08bea7da |
|
16-Apr-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6655: Replace VNSvInPortB with ioread8 Replace macro VNSvInPortB with ioread8. Avoid cast of the return value is possible with one exception. The name of macro and the arguments use CamelCase which is not accepted by checkpatch.pl Since there are more than one checkpatch issue per line, more steps are rquired to fix. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/fd71797d9d55d53f95c5c4e2df826bf85dd4626a.1650094595.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
b8ce0acf |
|
16-Apr-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6655: Delete tmacro.h Relocate the only macro MAKEWORD that is in use and remove file tmacro.h. File needs to be changed anyhow because of use of CamelCase which is not accepted by checkpatch.pl. Reduced code provides a better overview. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20220416191622.GA11596@matrix-ESPRIMO-P710 Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
b7711a87 |
|
05-Mar-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: vt6655: Remove unused byRFType in baseband.c Remove byRFType that support 5GHz band. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/198341a249ea67acbf1be00b6465aa6a4eaef6e1.1646512837.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
9da4b50c |
|
21-Oct-2021 |
Karolina Drobnik <karolinadrobnik@gmail.com> |
staging: vt6655: Use named constants when checking preamble type Compare `preamble_type` to a predefined constant, `PREAMBLE_SHORT`, instead of a literal in `bb_get_frame_time` and `vnt_get_phy_field` functions. Thanks to this change, it is clear that we check the type of a preamble, not just compare it against an arbitrary value. Remove a redundant comment. Signed-off-by: Karolina Drobnik <karolinadrobnik@gmail.com> Link: https://lore.kernel.org/r/20211021092753.511863-1-karolinadrobnik@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
1263c10c |
|
20-Oct-2021 |
Karolina Drobnik <karolinadrobnik@gmail.com> |
staging: vt6655: Rename `by_preamble_type` parameter Drop Hungarian notation prefix in the first parameter of `bb_get_frame_time` function. Update the comment to reflect that change. Signed-off-by: Karolina Drobnik <karolinadrobnik@gmail.com> Link: https://lore.kernel.org/r/20211020132326.417059-1-karolinadrobnik@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
548b6d7e |
|
18-Oct-2021 |
Karolina Drobnik <karolinadrobnik@gmail.com> |
staging: vt6655: Rename byPreambleType field Drop Hungarian notation prefix in `byPreambleType` member of struct vnt_private. Change it to use snake case. Fix issue detected by checkpatch.pl: CHECK: Avoid CamelCase: <byPreambleType> Signed-off-by: Karolina Drobnik <karolinadrobnik@gmail.com> Link: https://lore.kernel.org/r/20211018150317.9590-1-karolinadrobnik@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
e9c1caea |
|
10-Oct-2021 |
Tommaso Merciai <tomm.merciai@gmail.com> |
staging: vt6655: fix camelcase in byLocalID Replace camel case variable name for variable byLocalID with snake case equivalent. Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com> Link: https://lore.kernel.org/r/20211010220014.148785-1-tomm.merciai@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
1977dcf0 |
|
05-Oct-2021 |
Tommaso Merciai <tomm.merciai@gmail.com> |
staging: vt6655: fix camelcase in PortOffset Replace camel case variable PortOffset with snake case variable port_offset. Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com> Link: https://lore.kernel.org/r/20211005205702.14029-4-tomm.merciai@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
aeec304c |
|
05-Oct-2021 |
Tommaso Merciai <tomm.merciai@gmail.com> |
staging: vt6655: fix camelcase in ldBmThreshold Replace camel case variable ldBmThreshold with snake case variable dbm_threshold. ldBmThreshold is in hungarian notation, where "l" is for long and "dbm" is for decibel-milliwatt (signal strenght). This variable contain's signal strenght threshold in dbm. References: - https://en.wikipedia.org/wiki/Hungarian_notation - https://www.rapidtables.com/electric/dBm.html Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com> Link: https://lore.kernel.org/r/20211005205702.14029-3-tomm.merciai@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
e4a9e1d8 |
|
05-Oct-2021 |
Tommaso Merciai <tomm.merciai@gmail.com> |
staging: vt6655: fix camelcase in bShortSlotTime Replace camel case variable bShortSlotTime with snake case variable short_slot_time. bShortSlotTime is a boolean variable, if true short slot time is enabled, false not. Short Slot Time reduces the slot time from 20 microseconds to 9 microseconds, where the slot time is the maximum theoretical time for a frame to travel a network. References: - http://cciew.blogspot.com/2011/02/short-slot-time.html - https://www.cse.wustl.edu/~jain/cse574-16/ftp/j_05lan4.pdf - https://www.networkdatapedia.com/post/2013/09/16/ \ configuring-short-slot-time-to-improve-wifi-performance - https://en.wikipedia.org/wiki/Slot_time Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com> Link: https://lore.kernel.org/r/20211005205702.14029-2-tomm.merciai@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
cae9546a |
|
23-Jul-2021 |
Lucas Henneman <lucas.henneman@linaro.org> |
staging: vt6655: remove filename from baseband.c This patch resolves checkpatch's warning, "It's generally not useful to have the filename in the file" for baseband.c. Signed-off-by: Lucas Henneman <lucas.henneman@linaro.org> Link: https://lore.kernel.org/r/20210723144340.15787-2-lucas.henneman@linaro.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
754db907 |
|
14-Mar-2021 |
Madhumitha Prabakaran <madhumithabiw@gmail.com> |
staging: vt6655: Rename two dimensional array declaration Rename two dimensional array declaration to fix checkpatch warning: Avoid Camelcase and make the declaration more readable and understandable Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com> Link: https://lore.kernel.org/r/20210315004641.378933-1-madhumithabiw@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
3b27f646 |
|
10-Feb-2021 |
Yujia Qiao <rapiz@foxmail.com> |
Staging: vt6655: Replace a camel case variable name Replace camel case variable names with snake case in baseband.c. Signed-off-by: Yujia Qiao <rapiz@foxmail.com> Link: https://lore.kernel.org/r/tencent_21CFC58E6013D47A55691E4F4C6C4CF20706@qq.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
af93096e |
|
03-Apr-2020 |
Briana Oursler <briana.oursler@gmail.com> |
Staging: vt6655: Replace camel case variable names. Replace camel case variable names with snake case in baseband.h and its dependencies. Signed-off-by: Briana Oursler <briana.oursler@gmail.com> Reviewed-by: Stefano Brivio <sbrivio@redhat.com> Link: https://lore.kernel.org/r/20200403171805.466600-1-briana.oursler@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
3d7b79f2 |
|
01-Apr-2020 |
Briana Oursler <briana.oursler@gmail.com> |
Staging: vt6655: Remove BBvExitDeepSleep definition. Remove function BBvExitDeepSleep that is never called. Signed-off-by: Briana Oursler <briana.oursler@gmail.com> Reviewed-by: Stefano Brivio <sbrivio@redhat.com> Link: https://lore.kernel.org/r/027b00a27e2bef13c1daab3514dc7dc19fa1aa00.1585802818.git.briana.oursler@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
6f5ec722 |
|
28-Mar-2020 |
Briana Oursler <briana.oursler@gmail.com> |
Staging: vt6655: Remove BBvCalculateParameter comment. Remove comment that refers to function that no longer exists. Signed-off-by: Briana Oursler <briana.oursler@gmail.com> Reviewed-by: Stefano Brivio <sbrivio@redhat.com> Link: https://lore.kernel.org/r/20200328200331.136265-1-briana.oursler@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
ffc33e99 |
|
27-Feb-2019 |
Madhumitha Prabakaran <madhumithabiw@gmail.com> |
Staging: vt6655: Align a function declaration Align function return type and function arguments to improve readability. Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
3ef1ba06 |
|
05-Nov-2018 |
Yangtao Li <tiny.windzz@gmail.com> |
staging: vt6655: fix small typo Correct spelling mistakes of "Calculate" Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
dbc9f36c |
|
07-Nov-2017 |
Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
staging: vt6655: Remove redundant license text Now that the SPDX tag is in all vt6655 files, that identifies the license in a specific and legally-defined manner. So the extra GPL text wording can be removed as it is no longer needed at all. This is done on a quest to remove the 700+ different ways that files in the kernel describe the GPL license text. And there's unneeded stuff like the address (sometimes incorrect) for the FSF which is never needed. No copyright headers or other non-license-description text was removed. Cc: Forest Bond <forest@alittletooquiet.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
d7c43082 |
|
07-Nov-2017 |
Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
staging: vt6655: add SPDX identifiers to all vt6655 driver files It's good to have SPDX identifiers in all files to make it easier to audit the kernel tree for correct licenses. Update the vt6655 driver files with the correct SPDX license identifier based on the license text in the file itself. The SPDX identifier is a legally binding shorthand, which can be used instead of the full boiler plate text. This work is based on a script and data from Thomas Gleixner, Philippe Ombredanne, and Kate Stewart. Cc: Forest Bond <forest@alittletooquiet.net> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Kate Stewart <kstewart@linuxfoundation.org> Cc: Philippe Ombredanne <pombredanne@nexb.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
26f64a6b |
|
15-Oct-2016 |
Varsha Rao <rvarsha016@gmail.com> |
Staging: vt6655: Replace dwIoBase by iobase In this patch dwIoBase is renamed as iobase. This is done to fix the checkpatch issue of CamelCase. Signed-off-by: Varsha Rao <rvarsha016@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
21971f3e |
|
11-Oct-2016 |
Varsha Rao <rvarsha016@gmail.com> |
staging: vt6655: Removes the FSF mailing address. This patch fixes the checkpatch issue by removing the Free Software Foundation's mailing address from the sample GPL notice. Because the FSF has changed address in the past, and may change again. Linux already includes a copy of the GPL. Signed-off-by: Varsha Rao <rvarsha016@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
3d30311c |
|
09-Oct-2016 |
Varsha Rao <rvarsha016@gmail.com> |
staging: vt6655: Removes unnecessary blank lines. This patch fixes the checkpatch issue of multiple blank lines, by removing them. Signed-off-by: Varsha Rao <rvarsha016@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
33d877bb |
|
19-Sep-2016 |
Sandhya Bankar <bankarsandhya512@gmail.com> |
Staging: vt6655: baseband: Remove unnecessary space after a cast No space is necessary after a cast. This issue was found by checkpatch. Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
5150d01e |
|
15-Mar-2016 |
Kathryn Hampton <kh353dev@gmail.com> |
staging: vt6655: fix style violations for lines over 80 characters This patch addresses line length errors reported by checkpatch.pl that could be fixed with simple line breaks. Signed-off-by: Kathryn Hampton <kh353dev@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
6c5f37df |
|
14-Mar-2016 |
Claudiu Beznea <claudiu.beznea@gmail.com> |
Staging: vt6655: defined byVT3253InitTab_RFMD[] and byVT3253B0_RFMD[] as const arrays. This patch changes byVT3253InitTab_RFMD[] and byVT3253B0_RFMD[] arrays in const arrays since these are not changed anywhere in the code. Signed-off-by: Claudiu Beznea <claudiu.beznea@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
5f7a9424 |
|
30-Sep-2015 |
Arjun Krishna Babu <arjunkrishnababu96@gmail.com> |
staging: vt6655: Fixed two lines over 80 characters long Two lines of code that were over 80 characters long is fixed by splitting them across multiple lines. The lines of code are now easier to comprehend. Issue found by checkpatch. Signed-off-by: Arjun Krishna Babu <arjunkrishnababu96@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
fd43585b |
|
22-Jul-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: remove unused DBG_PORT80 and VIAWET_DEBUG VIAWET_DEBUG is never defined so DBG_PORT80 is empty and never used. Remove both macros. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
217ed3ab |
|
22-Jul-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: Remove ununsed macro ASSERT VIAWET_DEBUG is not defined so macro is empty. Remove the macro. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
5b4ac54f |
|
09-Mar-2015 |
Himani Agrawal <himani93@gmail.com> |
staging: vt6655: Fixes the checkpatch.pl warning warning fixed: WARNING: line over 80 characters The function call containing several variables is broken to make it fit in 80 characters. Signed-off-by: Himani Agrawal <himani93@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
e6f534bc |
|
19-Jan-2015 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: remove antenna diversity functions The vendor had disabled these functions in their last version. On test this can be troublesome, so remove this from the driver along with its macros and timers. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
a307d1d6 |
|
20-Dec-2014 |
Eddie Kovsky <ewk@edkovsky.org> |
staging: vt6655: fix sparse warning: argument type Fixes following warning generated by sparse: drivers/staging/vt6655/baseband.c:2180:45: warning: incorrect type in argument 1 (different address spaces) drivers/staging/vt6655/baseband.c:2180:45: expected struct vnt_private *priv drivers/staging/vt6655/baseband.c:2180:45: got void [noderef] <asn:2>*dwIoBase Compile tested on next-20141219. Signed-off-by: Eddie Kovsky <ewk@edkovsky.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
527ef70d |
|
08-Jan-2015 |
Sakshi Bansal <sakshi.april5@gmail.com> |
Staging: vt6655: baseband.c: fixed line over 80 characters Signed-off-by: Sakshi Bansal <sakshi.april5@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
8e8a9f51 |
|
06-Nov-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: BBbReadEmbedded replace __iomem with vnt_private Changing callers to point to private Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
377f5bc0 |
|
06-Nov-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: BBbWriteEmbedded replace __iomem with vnt_private for callers Referencing dwIoBase inside function. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
78b3c1fd |
|
06-Nov-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: baseband/rf s_bAL7230Init change __iomem for baseband functions Replace __iomem with vnt_private providing pointer for dwIoBase Change BBvPowerSaveModeON and BBvPowerSaveModeOFF to vnt_private and reference __iomem there, to be removed later. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
a5f0eef3 |
|
06-Nov-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: baseband replace __iomem where caller is priv dereferenced. Replace with stucture vnt_private *priv in functions BBvSoftwareReset BBvSetTxAntennaMode BBvSetRxAntennaMode BBvSetDeepSleep BBvExitDeepSleep __iomem *dwIoBase will be moved into BBbWriteEmbedded and BBbReadEmbedded later. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
8514408b |
|
05-Nov-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655 baseband.c camel case replace pDevice -> priv for struct vnt_private Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
3d42d26c |
|
05-Nov-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: baseband.c/h remove dead functions These functions are not used so remove them BBbIsRegBitsOn BBbIsRegBitsOff BBvReadAllRegs BBvLoopbackOn BBvLoopbackOff Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
e11cdc39 |
|
29-Oct-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: remove typedef void *TimerFunction Covert functions TimerSQ3CallBack and TimerState1CallBack to the correct type for struct timer_list.function to remove the cast altogether. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
d54435d3 |
|
29-Oct-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: dead code remove tether.h Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
a9c049b8 |
|
29-Oct-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: baseband.c timers replace spin lock Use spin_lock_irqsave and spin_unlock_irqrestore in functions TimerSQ3CallBack and TimerState1CallBack Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
837a38f7 |
|
29-Oct-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: baseband.c replace BIT0 with BIT(0) Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
14cd1df4 |
|
08-Oct-2014 |
Dilek Uzulmez <dilekuzulmez@gmail.com> |
staging: vt6655: Remove unnecessary else after return This patch fixes checkpatch.pl warning in files of vt6655 WARNING: else is not generally useful after a break or return Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
78fc8484 |
|
22-Sep-2014 |
Tapasweni Pathak <tapaswenipathak@gmail.com> |
staging: vt6655: shift open brace '{' to previous line This patch fixes checkpatch.pl error in baseband.c file ERROR : that open brace { should be on the previous line Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
c28f3253 |
|
20-Aug-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: Remove BBvCalculateParameter and its data members Remove data members bySignalField*, byServiceField*, wTransmitLength* from structures in desc.h Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
10c17445 |
|
20-Aug-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: baseband add new function vnt_get_phy_field This is a replacement for BBvCalculateParameter for getting the phy fields via struct vnt_phy_field This is a direct copy from the vt6656 driver. BBvCalculateParameter will removed later. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
5154b0d0 |
|
20-Aug-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: device.h dead code remove bCCK bCCK is always set to true, the only place it is used is in BBvCalculateParameter which nots the value to false. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
48caf5a0 |
|
17-Aug-2014 |
Joe Perches <joe@perches.com> |
staging: vt6655: Convert DBG_PRT to pr_<level> DBG_PRT uses are unnecessarily complex. Convert DBG_PRT msglevel to pr_<level>. This changes the KERN_<level> type of several uses. It also enables dynamic_debug for the pr_debug conversions. This patch can be a prelude to converting these pr_<level> uses to dev_<level> as appropriate. Other changes: Realign arguments of these conversions. Remove now unused static int msglevel declarations. Remove now unused DBG_PRT #define. Compile tested only. Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
582d6c22 |
|
10-Aug-2014 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: vt6655: baseband replace PSDevice Coverting all functions to struct vnt_private. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
6b711271 |
|
24-Jul-2014 |
Guillaume Clement <gclement@baobob.org> |
staging: vt6655: Add missing blank lines after declarations This patch fixes the missing blank lines after declarations in vt6655 reported by checkpatch. Signed-off-by: Guillaume Clement <gclement@baobob.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
fe802546 |
|
24-Jul-2014 |
Guillaume Clement <gclement@baobob.org> |
staging: vt6655: remove useless return statements Many return statements in void function were present at the end of functions, with no effect. They now are removed. This fixes a bunch of checkpatch warnings. Signed-off-by: Guillaume Clement <gclement@baobob.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
9e4c5c28 |
|
22-Jul-2014 |
Guillaume Clement <gclement@baobob.org> |
staging: vt6655: statify some variables Some variables are used only in the context of their .c file, which gives warnings with sparse. Signed-off-by: Guillaume Clement <gclement@baobob.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
16834405 |
|
22-Jul-2014 |
Guillaume Clement <gclement@baobob.org> |
staging: vt6655: change type of PortOffset to void __iomem * PortOffset was an unsigned long, but used as an pointer to io memory. Sometimes it was not properly cast before use, which caused many warning by sparse. By updating its type to void __iomem *, and reflecting the changes where it is needed, this removes most of those warnings. Signed-off-by: Guillaume Clement <gclement@baobob.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
15974dce |
|
01-Jun-2014 |
James A Shackleford <shack@linux.com> |
staging: vt6655: replace C99 style comments Signed-off-by: James A Shackleford <shack@linux.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
bc5cf656 |
|
19-Apr-2014 |
Guido Martínez <guido@vanguardiasur.com.ar> |
staging: vt6655: fix checkpatch bracing issues This patchs fixes tons of warnings such as: WARNING: braces {} are not necessary for single statement blocks #354: FILE: drivers/staging/vt6655/wmgr.c:354: + for (ii = 0; ii < WLAN_BSSID_LEN; ii++) { + pMgmt->abyDesireBSSID[ii] = 0xFF; + } Please note: this patch only fixes bracing issues (and there is still a lot to do); so if you run checkpatch it _will_ throw a lot of errors. Use --test-only=braces Signed-off-by: Guido Martínez <guido@vanguardiasur.com.ar> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
4e8a7e5f |
|
19-Apr-2014 |
Guido Martínez <guido@vanguardiasur.com.ar> |
staging: vt6655: remove dead code Remove dead code in many places on this driver. Signed-off-by: Guido Martínez <guido@vanguardiasur.com.ar> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
1208f14a |
|
10-Nov-2013 |
Teodora Baluta <teobaluta@gmail.com> |
staging: vt6655: delete explicit comparison to bool This patch fixes the following type of coccinelle detected warnings for driver vt6655: WARNING: Comparison to bool Signed-off-by: Teodora Baluta <teobaluta@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
5c36d5ae |
|
24-Oct-2013 |
Archana kumari <archanakumari959@gmail.com> |
staging: vt6655: fixed use of unnecessary braces in baseband.c This patch fixes use of unnecessary braces in baseband.c Signed-off-by: Archana kumari <archanakumari959@gmail.com> Reviewed-by: Rusty Russell <rusty@rustcorp.com.au> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
96d69e20 |
|
18-Mar-2013 |
Joe Perches <joe@perches.com> |
staging: vt6655: Remove unnecessary blank lines Remove a bunch of useless vertical whitespace. Convert 3 or more consecutive newlines to 2. Remove blank lines after open brace and before close brace. Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
a4ef27ad |
|
18-Mar-2013 |
Joe Perches <joe@perches.com> |
staging: vt6655: Remove unnecessary parentheses from returns Returns aren't functions, remove the parentheses to be more kernel style like. Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
5e0cc8a2 |
|
18-Mar-2013 |
Joe Perches <joe@perches.com> |
staging: vt6655: Convert to kernel brace style Move braces around to be more kernel like. Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
f2046f93 |
|
18-Mar-2013 |
Joe Perches <joe@perches.com> |
staging: vt6655: Remove commented out printks These are just noise in the code so remove them. Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
37529367 |
|
18-Mar-2013 |
Joe Perches <joe@perches.com> |
staging:vt6655:baseband: Whitespace cleanups Neatening only. git diff -w shows no differences. Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
7664ec86 |
|
20-Aug-2012 |
Justin P. Mattock <justinmattock@gmail.com> |
staging: "vt6655" Typo change *Caculate to *Calculate. Signed-off-by: Justin P. Mattock <justinmattock@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
623b2b39 |
|
20-Aug-2012 |
Justin P. Mattock <justinmattock@gmail.com> |
staging: "vt6655" Typo change *Embeded to *Embedded. Signed-off-by: Justin P. Mattock <justinmattock@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
789d1aef |
|
20-Aug-2012 |
Justin P. Mattock <justinmattock@gmail.com> |
staging: "vt6655" Fix typos in comments. Signed-off-by: Justin P. Mattock <justinmattock@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
27e3b901 |
|
08-Jul-2012 |
Marcos Paulo de Souza <marcos.souza.org@gmail.com> |
staging: vt6655: Remove all commented macros These macros were reported by forgotten-macros tool (https://github.com/marcosps/forgotten_macros). Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
7b6a0013 |
|
01-Aug-2010 |
Charles Clément <caratorn@gmail.com> |
Staging: vt6655: replace BOOL with in kernel bool Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
5a5a2a6a |
|
01-Aug-2010 |
Charles Clément <caratorn@gmail.com> |
Staging: vt6655: replace FALSE with in kernel false Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
1b12068a |
|
01-Aug-2010 |
Charles Clément <caratorn@gmail.com> |
Staging: vt6655: replace TRUE with in kernel true Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
3fc9b584 |
|
24-Jun-2010 |
Charles Clément <caratorn@gmail.com> |
Staging: vt6655: remove BYTE typedef Replace all occurrences with unsigned char type. Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
2986db5f |
|
24-Jun-2010 |
Charles Clément <caratorn@gmail.com> |
Staging: vt6655: remove WORD typedef Replace all occurrences with unsigned short type. Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
412b2d08 |
|
22-Jun-2010 |
Charles Clément <caratorn@gmail.com> |
Staging: vt6655: remove DWORD_PTR pointer typedef Use unsigned long instead. Signed-off-by: Charles Clément <caratorn@gmail.com>
|
#
15df6c2b |
|
05-Jun-2010 |
Charles Clément <caratorn@gmail.com> |
Staging: vt6655: remove PWORD typedef Use unsigned short * instead. Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
2989e96f |
|
05-Jun-2010 |
Charles Clément <caratorn@gmail.com> |
Staging: vt6655: remove PBYTE typedef Use unsigned char * instead. Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
e3fd16d0 |
|
02-Jun-2010 |
Charles Clément <caratorn@gmail.com> |
Staging: vt6655: remove custom ULONG typedef Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
b6e95cd5 |
|
02-Jun-2010 |
Charles Clément <caratorn@gmail.com> |
Staging: vt6655: remove custom UINT typedef Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
3cdec554 |
|
12-May-2010 |
Charles Clément <caratorn@gmail.com> |
Staging: vt6655: remove OUT definition Remove empty OUT definition used to specify output parameters. Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
3a215e0f |
|
12-May-2010 |
Charles Clément <caratorn@gmail.com> |
Staging: vt6655: remove IN definition Remove empty IN definition used to specify input parameters. Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
e64354c0 |
|
12-May-2010 |
Charles Clément <caratorn@gmail.com> |
Staging: vt6655: remove HANDLE definition and use Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
6b35b7b3 |
|
07-May-2010 |
Charles Clément <caratorn@gmail.com> |
Staging: vt6655: remove VOID definition and use Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
256a816b |
|
12-Aug-2009 |
Jim Lieb <lieb@canonical.com> |
Staging: vt665x: remove tbit.h part 2 Remove use of tbit macros adn remove header file. Signed-off-by: Jim Lieb <lieb@canonical.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
51b6d9c2 |
|
12-Aug-2009 |
Jim Lieb <lieb@canonical.com> |
Staging: vt665x: Remove umem.h Part 1 Remove references to umem.h macros and refer directly to memcpy functions. Delete the include file. Signed-off-by: Jim Lieb <lieb@canonical.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
a7ad322a |
|
12-Aug-2009 |
Jim Lieb <lieb@canonical.com> |
Staging: vt665x: Clean up include files, Part 2 Remove cplusplus lines from include files Remove needless ifdefs on includes to conform with C conventions. Remove misc commented code/includes Update TODO Signed-off-by: Jim Lieb <lieb@canonical.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
612822f5 |
|
12-Aug-2009 |
Jim Lieb <lieb@canonical.com> |
Staging: vt665x: Text janitor in prep for driver merge, part 2 Text only changes to remove textual differences between the vt6655 and vt6656 trees in prep for driver merge. Signed-off-by: Jim Lieb <lieb@canonical.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
7e809a9b |
|
30-Jul-2009 |
Jim Lieb <lieb@canonical.com> |
Staging: vt6655 textual cleanup in prep for driver merge The vt6655 and vt6656 drivers are from a common origin but have drifted apart with minor textual differences. There are two changes: s/DEVICE_PRT/DBG_PRT/g and s/byPktTyp/byPktType/g This significantly reduces the differences between the two file sets in preparation to merging the common code. A few whitespace and text bits were also adjusted. Signed-off-by: Jim Lieb <lieb@canonical.com> Cc: Forest Bond <forest@alittletooquiet.net> Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
5449c685 |
|
25-Apr-2009 |
Forest Bond <forest@alittletooquiet.net> |
Staging: Add pristine upstream vt6655 driver sources Add pristine upstream vt6655 driver sources to drivers/staging/vt6655. These files were literally copied from the driver directory in the upstream source archive, available here: http://www.viaarena.com/Driver/vt6655_linux_src_v1.19.12_x86.zip Signed-off-by: Forest Bond <forest@alittletooquiet.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|