#
ad0498f3 |
|
26-Feb-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename function MgntQuery_MgntFrameTxRate Rename function MgntQuery_MgntFrameTxRate to mgnt_query_mgnt_frame_tx_rate to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240227044157.407379-21-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
a4d4bbd2 |
|
26-Feb-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename boolean variable bHalfWirelessN24GMode Rename boolean variable bHalfWirelessN24GMode to half_wireless_n24g_mode to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240227044157.407379-20-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
a033871a |
|
26-Feb-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename reference AllowAllDestAddrHandler Rename variable AllowAllDestAddrHandler to allow_all_dest_addr_handler to fix checkpatch warning Avoid CamelCase, Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240227044157.407379-19-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
99c7328a |
|
26-Feb-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename varoable asSta Rename variable asSta to addr as it references bssid addr, and fixes checkpatch warning Avoid CamelCase, Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240227044157.407379-18-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
41df5318 |
|
26-Feb-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename varoable osCcxVerNum Rename variable osCcxVerNum to os_vcx_ver_num to fix checkpatch warning Avoid CamelCase, Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240227044157.407379-17-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
39db18dd |
|
26-Feb-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable CcxAironetBuf Rename variable CcxAironetBuf to ccx_aironet_buf to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240227044157.407379-16-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
cfbcf6df |
|
26-Feb-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable osCcxAironetIE Rename variable osCcxAironetIE to os_ccx_aironet_ie to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240227044157.407379-15-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
b526e496 |
|
26-Feb-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable AironetIeOui Rename variable AironetIeOui to aironet_ie_oui to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240227044157.407379-14-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
0c5d6ec4 |
|
26-Feb-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable asRsn Rename variable asRsn to rsn to fix checkpatch warning Avoid CamelCase, and adjust spacing to avoid alignment check. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240227044157.407379-13-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
2c6dc848 |
|
26-Feb-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable CcxVerNumBuf Rename variable CcxVerNumBuf to ccx_ver_num_buf to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240227044157.407379-12-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
ba15ff48 |
|
26-Feb-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable BssCcxVerNumber Rename variable BssCcxVerNumber to bss_ccx_ver_number to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240227044157.407379-11-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
fbf63623 |
|
26-Feb-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable CcxRmCapBuf Rename variable CcxRmCapBuf to ccx_rm_cap_buf to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240227044157.407379-10-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
98d602e8 |
|
26-Feb-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable bCcxRmEnable Rename variable bCcxRmEnable to ccx_rm_enable to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240227044157.407379-9-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
ce0ba550 |
|
26-Feb-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable bCkipSupported Rename variable bCkipSupported to ckip_supported to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240227044157.407379-8-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
99a21d5a |
|
26-Feb-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable osCcxRmCap Rename variable osCcxRmCap to os_ccx_rm_cap to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240227044157.407379-7-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
9880998b |
|
26-Feb-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable Turbo_Enable Rename variable Turbo_Enable to turbo_enable to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240227044157.407379-6-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
d674c623 |
|
26-Feb-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable PMKIDList Rename variable PMKIDList to pmkid_list to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240227044157.407379-5-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
020d29db |
|
26-Feb-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename function SecIsInPMKIDList() Rename function SecIsInPMKIDList to sec_is_in_pmkid_list to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240227044157.407379-4-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
9f965f1e |
|
26-Feb-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable NumRecvDataInPeriod Rename variable NumRecvDataInPeriod to num_recv_data_in_period to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240227044157.407379-3-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
d1c4f17f |
|
26-Feb-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename function rtllib_rx_ADDBAReq() Rename function rtllib_rx_ADDBAReq to rtllib_rx_add_ba_req to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240227044157.407379-2-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
b4a89adc |
|
26-Jan-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable bForcedBgMode Rename variable bForcedBgMode to forced_bg_mode to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20240126223106.986093-19-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
34eb6bea |
|
26-Jan-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable NumRecvBcnInPeriod Rename variable NumRecvBcnInPeriod to num_recv_bcn_in_period to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20240126223106.986093-18-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
0dd08a4b |
|
26-Jan-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable LpsIdleCount Rename variable LpsIdleCount to lps_idle_count to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20240126223106.986093-17-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
1650401e |
|
26-Jan-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable Octet Rename variable Octet to octet to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20240126223106.986093-16-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
3f3dd0a0 |
|
26-Jan-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Fix if statement alignment with open parenthesis Add a space in front of statement to fix checkpatch warning: Alignment should match open parenthesis Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20240126223106.986093-15-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
c64b64c9 |
|
26-Jan-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Remove unnecessary blank line Remove blank line to fix checkpatch warning: Blank lines aren't necessary before a close brace '}' Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20240126223106.986093-14-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
9842cb03 |
|
26-Jan-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Fixup if statement broken across multiple lines. Join broken lines across if statement to fix checkpatch warning: Lines should not end with a '(' Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20240126223106.986093-13-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
459a6c2b |
|
26-Jan-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Fix paren alignment for rtllib_disable_net_monitor_mode() Join 2 lines to fix Warning: Alignment should match open parenthesis Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20240126223106.986093-12-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
0efe628a |
|
26-Jan-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable SelfHTCap Rename variable SelfHTCap to self_ht_cap to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20240126223106.986093-11-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
a9055dc8 |
|
26-Jan-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable LPSAwakeIntvl Rename variable LPSAwakeIntvl to lps_awake_intvl to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20240126223106.986093-10-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
332fe0ec |
|
26-Jan-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable PeerHTInfoBuf Rename variable PeerHTInfoBuf to peer_ht_info_buf to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20240126223106.986093-9-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
05ee6e2f |
|
26-Jan-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable PeerHTCapBuf Rename variable PeerHTCapBuf to peer_ht_cap_buf to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20240126223106.986093-8-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
e51e9469 |
|
26-Jan-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename function MgntQuery_TxRateExcludeCCKRates() Rename function MgntQuery_TxRateExcludeCCKRates to mgnt_query_tx_rate_exclude_cck_rates to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20240126223106.986093-7-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
583b7e3b |
|
26-Jan-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename function pointer SetHwRegHandler() Rename function pointer SetHwRegHandler to set_hw_reg_handler to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20240126223106.986093-6-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
6b7a8b46 |
|
26-Jan-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable LPSDelayCnt Rename variable LPSDelayCnt to lps_delay_cnt to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20240126223106.986093-5-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
808f35c4 |
|
26-Jan-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable LPSAwakeIntvl_tmp Rename variable LPSAwakeIntvl_tmp to lps_awake_intvl_tmp to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20240126223106.986093-4-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
a372b802 |
|
26-Jan-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename function rtllib_rx_ADDBARsp() Rename function rtllib_rx_ADDBARsp to rtllib_rx_add_ba_rsp to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20240126223106.986093-3-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
dfc5660b |
|
26-Jan-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable FirstIe_InScan Rename variable FirstIe_InScan to first_ie_in_scan to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20240126223106.986093-2-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
1cc357dd |
|
05-Jan-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable AsocRetryCount Rename variable AsocRetryCount to asoc_retry_count to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20240106055556.430948-22-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
c9f43ad4 |
|
05-Jan-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename function GetNmodeSupportBySecCfg() Rename function GetNmodeSupportBySecCfg to get_nmode_support_by_sec_cfg fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20240106055556.430948-21-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
7ee99ed3 |
|
05-Jan-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable PMKCacheIdx Rename variable PMKCacheIdx to pmk_cache_idx to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20240106055556.430948-20-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
64df2dcc |
|
05-Jan-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable bHalfSupportNmode Rename variable bHalfSupportNmode to half_support_nmode to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20240106055556.430948-19-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
c41616e9 |
|
05-Jan-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename function SendDisassociation() Rename function SendDisassociation to send_disassociation to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20240106055556.430948-18-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
053e3b7c |
|
05-Jan-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename function rtllib_MlmeDisassociateRequest() Rename function rtllib_MlmeDisassociateRequest to rtllib_mlme_disassociate_request to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20240106055556.430948-17-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
b7e6e1ef |
|
05-Jan-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename function RemovePeerTS() Rename function RemovePeerTS to remove_peer_ts to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20240106055556.430948-16-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
f70205ad |
|
05-Jan-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable RemoveAllTS Rename variable RemoveAllTS to remove_all_ts to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20240106055556.430948-15-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
254c59bf |
|
05-Jan-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable SlotNum Rename variable SlotNum to slot_num to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20240106055556.430948-14-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
124f2e44 |
|
05-Jan-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable NumRxUnicastOkInPeriod Rename variable NumRxUnicastOkInPeriod to num_rx_unicast_ok_in_period to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20240106055556.430948-13-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
a89dd127 |
|
05-Jan-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable array Bssid Rename variable array Bssid -> bssid to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20240106055556.430948-12-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
e2bf5a27 |
|
05-Jan-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable bFilterOutNonAssociatedBSSID Rename variable bFilterOutNonAssociatedBSSID -> filter_out_nonassociated_bssid to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20240106055556.430948-11-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
5d8fef84 |
|
05-Jan-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename function rtllib_MgntDisconnect() Rename function rtllib_MgntDisconnect to rtllib_mgnt_disconnect fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20240106055556.430948-10-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
6593d5bc |
|
05-Jan-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable bBusyTraffic Rename variable bBusyTraffic to busy_traffic to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20240106055556.430948-9-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
c7c4440d |
|
05-Jan-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable bSupportNmode Rename variable bSupportNmode to support_nmode to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20240106055556.430948-8-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
eba9c984 |
|
05-Jan-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable bAwakePktSent Rename variable bAwakePktSent to awake_pkt_sent to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20240106055556.430948-7-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
698888bd |
|
05-Jan-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable MaxPeriod Rename variable MaxPeriod to max_period to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20240106055556.430948-6-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
9ad8d831 |
|
05-Jan-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable bMulticast Rename variable bMulticast to multicast to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20240106055556.430948-5-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
7fe65bc5 |
|
05-Jan-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename function rtllib_MgntDisconnectAP() Rename function rtllib_MgntDisconnectAP to rtllib_mgnt_disconnect_ap to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20240106055556.430948-4-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
0f598601 |
|
05-Jan-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable SlotIndex Rename variable SlotIndex to slot_index to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20240106055556.430948-3-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
d5cae945 |
|
05-Jan-2024 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Remove unnecessary parenthesis in rtllib_softmac_new_net() Remove parentheses to fix checkpatch Warning: Unnecessary parentheses around ieee->current_network Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20240106055556.430948-2-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
0a46c21c |
|
25-Dec-2023 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable OpMode Rename variable OpMode to op_mode to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20231225202314.31869-7-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
9cbaf63c |
|
25-Dec-2023 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable bIsAggregateFrame Rename variable bIsAggregateFrame to is_aggregate_frame to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20231225202314.31869-6-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
2d1f3832 |
|
25-Dec-2023 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename function rtllib_EnableNetMonitorMode() Rename function rtllib_EnableNetMonitorModeto to rtllib_enable_net_monitor_mode to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20231225202314.31869-5-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
5fa882a8 |
|
25-Dec-2023 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable NumRxOkInPeriod Rename variable NumRxOkInPeriod to num_rx_ok_in_period to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20231225202314.31869-4-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
a24e0197 |
|
25-Dec-2023 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable NumTxOkInPeriod Rename variable NumTxOkInPeriod to num_tx_ok_in_period to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20231225202314.31869-3-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
d65a2fc0 |
|
25-Dec-2023 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable bUsed Rename variable bUsed to used to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20231225202314.31869-2-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
9ebffbe2 |
|
22-Dec-2023 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename function rtllib_DisableNetMonitorMode() Rename function rtllib_DisableNetMonitorMode to rtllib_disable_net_monitor_mode to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20231223015942.418263-21-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
53156632 |
|
22-Dec-2023 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable bInitState Rename variable bInitState to init_state to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20231223015942.418263-20-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
6a200076 |
|
22-Dec-2023 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable skb_waitQ Rename variable skb_waitQ to skb_waitq to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20231223015942.418263-19-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
0edd0fb7 |
|
22-Dec-2023 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable BasicRate Rename variable BasicRate to basic_rate to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20231223015942.418263-18-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
66dda5e3 |
|
22-Dec-2023 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable QueryRate Rename variable QueryRate to query_rate to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20231223015942.418263-17-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
8867af67 |
|
22-Dec-2023 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename function rtllib_TURBO_Info() Rename function rtllib_TURBO_Info to rtllib_turbo_info to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20231223015942.418263-16-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
1ed0f611 |
|
22-Dec-2023 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename function rtllib_WMM_Info() Rename function rtllib_WMM_Info to rtllib_wmm_info to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20231223015942.418263-15-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
d70c91a3 |
|
22-Dec-2023 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename function rtllib_MFIE_Grate() Rename function rtllib_MFIE_Grate to rtllib_mfie_grate to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20231223015942.418263-14-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
4f6054fb |
|
22-Dec-2023 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename function rtllib_MFIE_Brate() Rename function rtllib_MFIE_Brate to rtllib_mfie_brate to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20231223015942.418263-13-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
75a946f9 |
|
22-Dec-2023 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Fixup statement broken across 2 lines in rtllib_softmac_new_net() Join 2 lines to fix Warning: Lines should not end with a '(' Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20231223015942.418263-12-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
7fa14461 |
|
22-Dec-2023 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Fixup statement broken across 2 lines in rtllib_softmac_xmit() Join 2 lines to fix Warning: Lines should not end with a '(' Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20231223015942.418263-11-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
afae5cd7 |
|
22-Dec-2023 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Fix function definition broken across multiple lines Join 4 lines, so that function definition resides on a single line, to fix Warning: Lines should not end with a '(' Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20231223015942.418263-10-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
e946ef93 |
|
22-Dec-2023 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Fix statement broken across 2 lines in rtllib_rx_assoc_resp() Join 2 lines, so that statment resides on one line, to fix Warning: Lines should not end with a '(' Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20231223015942.418263-9-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
7d225068 |
|
22-Dec-2023 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Fixup multiple assinment in init_mgmt_queue() Break multiple assignment into 2 assignment statements to fix checkpatch Warning: multiple assignments should be avoided. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20231223015942.418263-8-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
eb2ebe15 |
|
22-Dec-2023 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Remove unnecessary parenthesis in rtllib_association_req() Remove parnthesis to fix checkpatch Warning: Unnecessary parentheses around ieee->ht_info->SelfHTCap Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20231223015942.418263-7-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
a87f009c |
|
22-Dec-2023 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Remove unnecessary parenthesis in rtllib_ap_sec_type() Remove parnthesis to fix checkpatch Warning: Unnecessary parentheses around ieee->wpa_ie[14] Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20231223015942.418263-6-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
be0d49be |
|
22-Dec-2023 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Remove unnecessary parenthesis in rtllib_rx_assoc_resp() Remove parentheses to fix checkpatch Warning: Unnecessary parentheses around resp->info_element[0].id Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20231223015942.418263-5-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
6bb7a078 |
|
22-Dec-2023 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Remove unnecessary parenthesis in rtllib_association_req() Remove parentheses to fix checkpatch Warning: Unnecessary parentheses around hdr->info_element[0].id Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20231223015942.418263-4-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
1aa721a4 |
|
22-Dec-2023 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Remove unnecessary braces from MgntQuery_MgntFrameTxRate() Remove braces from if statement to fix checkpatch WARNING: 'braces {} are not necessary for single statement blocks' Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20231223015942.418263-2-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
93235f62 |
|
21-Dec-2023 |
Gary Rookard <garyrookard@fastmail.org> |
staging: rtl8192e: rename variable ePeerHTSpecVer Coding style issue, checkpatch Avoid CamelCase, rename it. ePeerHTSpecVer -> peer_ht_spec_ver Signed-off-by: Gary Rookard <garyrookard@fastmail.org> Link: https://lore.kernel.org/r/20231221183413.8349-6-garyrookard@fastmail.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
0901e696 |
|
21-Dec-2023 |
Gary Rookard <garyrookard@fastmail.org> |
staging: rtl8192e: rename variable HTResetSelfAndSavePeerSetting Coding style issue, checkpatch Avoid CamelCase, rename it. HTResetSelfAndSavePeerSetting -> ht_reset_self_and_save_peer_setting Signed-off-by: Gary Rookard <garyrookard@fastmail.org> Link: https://lore.kernel.org/r/20231221183413.8349-3-garyrookard@fastmail.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
8caf3a8e |
|
12-Dec-2023 |
Gary Rookard <garyrookard@fastmail.org> |
staging: rtl8192e: rename variable HTOnAssocRsp Coding style issue, checkpatch Avoid CamelCase, rename it. HTOnAssocRsp -> ht_on_assoc_rsp Signed-off-by: Gary Rookard <garyrookard@fastmail.org> Link: https://lore.kernel.org/r/20231213175459.5425-5-garyrookard@fastmail.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
36802495 |
|
12-Dec-2023 |
Gary Rookard <garyrookard@fastmail.org> |
staging: rtl8192e: rename variable HTSetConnectBwMode Coding style issue, checkpatch Avoid CamelCase, rename it. HTSetConnectBwMode -> ht_set_connect_bw_mode Signed-off-by: Gary Rookard <garyrookard@fastmail.org> Link: https://lore.kernel.org/r/20231213175459.5425-4-garyrookard@fastmail.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
83280534 |
|
10-Dec-2023 |
Gary Rookard <garyrookard@fastmail.org> |
staging: rtl8192e: rename variable HTConstructRT2RTAggElement Coding style issue, checkpatch Avoid CamelCase, rename it. HTConstructRT2RTAggElement -> ht_construct_rt2rt_agg_element Signed-off-by: Gary Rookard <garyrookard@fastmail.org> Link: https://lore.kernel.org/r/20231211001335.26169-5-garyrookard@fastmail.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
9ee07ff4 |
|
10-Dec-2023 |
Gary Rookard <garyrookard@fastmail.org> |
staging: rtl8192e: rename variable HTConstructCapabilityElement Coding style issue, checkpatch Avoid CamelCase, rename it. HTConstructCapabilityElement -> ht_construct_capability_element Signed-off-by: Gary Rookard <garyrookard@fastmail.org> Link: https://lore.kernel.org/r/20231211001335.26169-4-garyrookard@fastmail.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
9ba1a160 |
|
10-Dec-2023 |
Gary Rookard <garyrookard@fastmail.org> |
staging: rtl8192e: rename variable HTResetIOTSetting Coding style issue, checkpatch Avoid CamelCase, rename it. HTResetIOTSetting -> ht_reset_iot_setting Signed-off-by: Gary Rookard <garyrookard@fastmail.org> Link: https://lore.kernel.org/r/20231211001335.26169-3-garyrookard@fastmail.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
a496db48 |
|
10-Dec-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Remove variable ht_info->bCurSuppCCK ht_info->bCurSuppCCK is set to 1 and unchanged. Therefore all equations result accordingly and ht_info->bCurSuppCCK can be removed. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/159a1a84c7bc90042bf1618a067f02ac123dd15d.1702212003.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
13afc9bd |
|
08-Dec-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Remove files dot11d.c and dot11d.h Remove files dot11d.c and dot11d.h as they are empty. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/ed7de82ade0fde1835bbd88aafba74aeb128beed.1701989555.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
0c2d3ca5 |
|
08-Dec-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Remove variable dot11d_info Remove variable dot11d_info as it is unused. Remove unused struct channel_list and empty struct rt_dot11d_info. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/2438971feb0c02c5c72776f57201a4011f249190.1701989555.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
97cb8afd |
|
08-Dec-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Remove function rtllib_update_active_chan_map() Remove function rtllib_update_active_chan_map() as "active_channel_map" and "channel_map" have the same content. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/bae3ddeffe96e4ac7d929127ce3a72cd23fae8dd.1701989555.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
7e0ea2ea |
|
24-Nov-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Remove unused function rtllib_probe_resp() Remove unused function rtllib_probe_resp(). Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/be709ffea087df6f960075a51c0eab89f86ef8b2.1700860759.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
55003c4d |
|
24-Nov-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Remove unused function rtllib_get_beacon_() Remove unused function rtllib_get_beacon_(). Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/ed825d5fb1946530c310afca1d3f27e46da35f06.1700860759.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
270f40cf |
|
24-Nov-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Remove unused function rtllib_send_beacon() Remove unused function rtllib_send_beacon(). Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/fca983a276ae67dc9cd124e236fe9d210fd997d3.1700860759.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
d7f0b9c2 |
|
24-Nov-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Remove unused timer beacon_timer Driver does not support AP Mode therefore no beacons need to be send. Remove unused timer beacon_timer. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/b16b6b4525ede8e2a218cb39d23f9ef2a3a745a9.1700860759.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
786b6f57 |
|
24-Nov-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Remove unused function rtllib_get_beacon() Remove unused function rtllib_get_beacon(). Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/d76eeb7e273f4fcfec4ae8879e56d237363ebde2.1700860758.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
ea6df150 |
|
23-Nov-2023 |
Gary Rookard <garyrookard@fastmail.org> |
staging: rtl8192e: renamed variable IsHTHalfNmodeAPs Renamed from Pascal/CamelCase to Snake case the variable IsHTHalfNmodeAPs. ISHTHalfNmodeAPs -> is_ht_half_nmode_aps Linux kernel coding style (cleanup), checkpatch Avoid CamelCase. Driver/module rtl8192e compiles. Signed-off-by: Gary Rookard <garyrookard@fastmail.org> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20231123144337.13112-4-garyrookard@fastmail.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
b7bba314 |
|
19-Nov-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Remove IS_DOT11D_ENABLE(ieee) Variable "enabled" is initialized to false and never changed. Therefore IS_DOT11D_ENABLE(ieee) returns always false. Remove dead code. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org> Link: https://lore.kernel.org/r/9e737b2246e0b73c3ad84a4ee09f5e94bf778b3c.1700431464.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
e6377178 |
|
21-Oct-2023 |
Michael Straube <straube.linux@gmail.com> |
staging: rtl8192e: clean up comparisons to NULL Clean up comparisons to NULL to improve readability. Reported by checkpatch. if (x == NULL) -> if (!x) if (x != NULL) -> if (x) Signed-off-by: Michael Straube <straube.linux@gmail.com> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20231021121947.14516-1-straube.linux@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
f4840e34 |
|
06-Oct-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Remove unchanged variable active_scan Remove variable active_scan as its value is set to 1 at initialization. No further writes to active_scan are done. The equation results accordingly. Remove dead code. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/eea9f6cb1feeb8aa5beb546034562f55a03da449.1696548527.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
02584b2a |
|
06-Oct-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Remove constant variable reg_max_lps_awake_intvl Remove constant variable reg_max_lps_awake_intvl as this value is just written to MaxPeriod. Function _rtl92e_init_priv_constant() is then empty and can be removed as well. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/d5b2ccc0f10c28f960552dd2b2c5ec83aa62041f.1696548527.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
0fe73dca |
|
03-Oct-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Remove function _rtl92e_wx_set_promisc_mode() Remove function _rtl92e_wx_set_promisc_mode() as this functionality is not commonly used and the tool to access it is deprecated. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/d318afeae38f14db36da9f2b229ff61535b815c8.1696360404.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
ea4ba961 |
|
03-Oct-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Remove unused parameter mesh_flag Remove unused parameter mesh_flag of function rtllib_softmac_start_protocol(). Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/3daa591db70978b305e4a1db7353fd96574d5591.1696360403.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
841ee18e |
|
03-Oct-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Remove function rtllib_start_monitor_mode() Remove equation with raw_tx in function rtllib_start_monitor_mode() as it is always false. rtllib_start_monitor_mode() is then empty and can be removed as well. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/0031b5f9150851e5ec86a56c1ffad5488fa065f4.1696360403.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
782bfb06 |
|
02-Oct-2023 |
Tree Davies <tdavies@darkphysics.net> |
Staging: rtl8192e: Rename variable bCurrentHTSupport Rename variable bCurrentHTSupport to current_ht_support to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20231003031849.176743-3-tdavies@darkphysics.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
c61d7510 |
|
02-Oct-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Remove constant parameter from rtllib_stop_protocol() Remove constant parameter shutdown of function rtllib_stop_protocol(). shutdown is always true. Remove dead code. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/7eebcd3a8637b686331e34532136df3e7760f869.1696266965.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
fe8ab331 |
|
02-Oct-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Remove unused/constant parameter mesh_flag and shutdown Remove parameters mesh_flag and shutdown of function rtllib_softmac_stop_protocol(). mesh_flag is unused. shutdown is always true. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/5a8f87165b10fd93e3e2fad83ff3380c9f4f22b2.1696266965.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
92834696 |
|
01-Oct-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Remove unused variable is_silent_reset ieee->is_silent_reset is set to false and never changed. All equations result accordingly. Remove dead code. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/124d8f91db347e0e35184b356ba4ec39f52871cb.1696165351.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
f4050ec5 |
|
24-Sep-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Unlock mutex for one line in rtllib_stop_protocol() The following command uses the mutex ieee->wx_mutex: cancel_delayed_work_sync(&ieee->associate_retry_wq) Therefore it cannot be canceled with ieee->wx_mutex locked. rtllib_stop_protocol() is always called with ieee->wx_mutex locked so according line can be unlocked. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/ffe60e8f6e29197f331e239ab38154da97c743be.1695582999.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
d17631c4 |
|
24-Sep-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Remove mutex from rtllib_softmac_free() The following commands use the mutex ieee->wx_mutex: cancel_delayed_work_sync(&ieee->associate_retry_wq) cancel_delayed_work_sync(&ieee->associate_procedure_wq) cancel_work_sync(&ieee->wx_sync_scan_wq) Therefore they cannot be canceled with ieee->wx_mutex locked. As the work functions are executed time shifted during normal operation of the driver, proper locking can only be done inside the functions. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/a5308876bd8fabcb5f8b25d14dbad2c1f68ce59f.1695582999.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
1579c706 |
|
24-Sep-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Put kfree() to end of rtllib_softmac_free() To reverse order of initialization put kfree() to the end of rtllib_softmac_free(). Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/85b63c62780356af91c30cc63280c5f59cd29210.1695582999.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
b174d2c5 |
|
22-Sep-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Remove rtllib_stop_send_beacons rtllib_start_send_beacons() is removed so no need for rtllib_stop_send_beacons() anymore. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/17c5545102ad8f50ca320af17aafa555f8caec2d.1695387832.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
91f70cf2 |
|
22-Sep-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Remove delayed_work start_ibss_wq Remove delayed_work start_ibss_wq and the related functions which are not needed anymore. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/805447a41feffb9da7d82830868dc1d47f9aa737.1695387832.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
27cde974 |
|
22-Sep-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Remove mode IW_MODE_ADHOC from rtllib_softmac.c Remove unsupported mode IW_MODE_ADHOC from rtllib_softmac.c. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/4259c06deaf2e3f3cc615e8c55bcf6f70ce4e277.1695387832.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
decfb8dd |
|
22-Sep-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Remove mode IW_MODE_ADHOC from rtllib_rx.c Remove unsupported mode IW_MODE_ADHOC from rtllib_rx.c and all related functions and structs. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/5400c68e17b86b1170ac997fae3fe1fb09220af8.1695387832.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
8e050848 |
|
15-Sep-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Replace frame control constants with IEEE80211_FCTL_* Replace frame control fields with IEEE80211_FCTL_* to avoid proprietary constant names. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/24d195f60ab9aa1d419c81b749c3d64dc8f643e3.1694792595.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
87f8e11d |
|
15-Sep-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Replace control subframe types with IEEE80211_STYPE_* Replace control and data subframe types RTLLIB_STYPE_* with IEEE80211_STYPE_* to avoid proprietary constant names. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/970555ba76dcf3b9896c51aab8ff333a95f12225.1694792595.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
c2f7ab52 |
|
15-Sep-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Replace management subframe types with IEEE80211_STYPE_* Replace management subframe types RTLLIB_STYPE_* with IEEE80211_STYPE_* to avoid proprietary constant names. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/35ff2758b79f8dadb1d864f3f6d948a76179ad36.1694792595.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
03622cc9 |
|
15-Sep-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Remove struct rtllib_pspoll_hdr Replace struct rtllib_pspoll_hdr with struct ieee80211_pspoll to avoid proprietary code. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/a4bd004fcbba81f96fd09f5adec5f029e2de3d6d.1694792595.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
71ddc43e |
|
15-Sep-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Replace struct rtllib_hdr_3addr in structs of rtllib.h Replace struct rtllib_hdr_3addr with struct ieee80211_hdr_3addr to avoid proprietary struct in structs of rtllib.h. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/e327712027b022561759d7cadcf51bf8274ab05a.1694792595.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
ab426599 |
|
15-Sep-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Replace struct rtllib_hdr_3addr in rtllib_softmac.c Replace struct rtllib_hdr_3addr with struct ieee80211_hdr_3addr to avoid proprietary struct. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/8e385d0810132086ce44d295c47d3798960a391b.1694792595.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
58806573 |
|
12-Sep-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Remove rtllib_get_payload() rtllib_process_action() is only called in one place with management frames. Frame is passed over to rtllib_get_payload() which passes it to rtllib_get_hdrlen(). In rtllib_get_hdrlen() all management frames return with hdrlen = RTLLIB_3ADDR_LEN. Therefore the switch in rtllib_get_payload() is useless and dead code. The condition act == NULL cannot occur and can also be removed. Then rtllib_hdr_2addr is not used anymore and can be removed as well. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/3ef288fb819f50da3eb9291522067babaa57f532.1694546301.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
f59edab8 |
|
12-Sep-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Use standard function in softmac_mgmt_xmit() Use standard function ieee80211_is_beacon() to avoid proprietary code to identify beacon and to increase readability in softmac_mgmt_xmit() and _rtl92e_translate_rx_signal_stats() Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/bd648e8e3c9c93c7944b72778ef7288973d8386e.1694546300.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
da1e3968 |
|
13-Aug-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Remove unused function rtllib_start_master_bss() Remove unused functions rtllib_start_master_bss(), rtllib_rx_assoc_rq() and rtllib_rx_auth_rq() and resulting unused functions. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/ac2012d94fe4ff705cc900bb1cf2d58bc81c77f0.1691908402.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
2b632f7f |
|
13-Aug-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Remove unsupported mode IW_MODE_MASTER Tasklet irq_rx_tasklet is scheduled when hw is receiving frames. Function _rtl92e_irq_rx_tasklet() is then called which calls then _rtl92e_rx_normal(). In _rtl92e_rx_normal() all frames are processed by rtllib_rx(). When ieee->iw_mode is IW_MODE_MASTER the function returns 0. The calling function then calls: dev_kfree_skb_any() which clears the skb. So the driver clears all packets received in this mode. Remove dead code in mode IW_MODE_MASTER. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/9cd4574e4cfe0a2d7afce03c9b868757e215a23c.1691908402.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
30afa99d |
|
29-Jul-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Remove is_mesh from rtllib_softmac_scan_syncro Function rtllib_softmac_scan_syncro() has unused parameter is_mesh. Remove dead code. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/9fcd1193c155ef992493af3526442fb84032166f.1690615475.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
349db421 |
|
29-Jul-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Remove is_mesh from rtllib_start_scan_syncro Function rtllib_start_scan_syncro() has parameter is_mesh which is in all calls 0. Remove dead code. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/6050a1d7764364190dda252f79d75c7cc47143de.1690615475.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
fc6ea9d3 |
|
29-Jul-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Remove is_mesh from rtllib_send_probe_requests Function rtllib_send_probe_requests() has unused parameter is_mesh. Remove dead code. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/06a4c66112e22d6131711969dd4f5ac9fab91426.1690615475.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
bbf2b164 |
|
29-Jul-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Remove unused variable is_mesh from rtllib_send_probe Function rtllib_send_probe() has unused parameter is_mesh. Remove dead code. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/5b1f4b9d8f81790c151adc7f9b6611f0b5cd94a5.1690615475.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
a90928f7 |
|
24-Jun-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Remove variable ieee->short_slot ieee->short_slot also named priv->rtllib->short_slot is initialized to 1 and then unchanged. All evaluations will result accordingly. Remove resulting dead code. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/74fe53ccfafe2e0e18319b5502ed83544cc3ffd8.1687583718.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
1047daac |
|
24-Jun-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Remove variable host_encrypt as it is constant ieee->host_encrypt also named priv->rtllib->host_encrypt is initialized to 1 and then unchanged. All evaluations will result accordingly. Remove resulting dead code. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/bc4ea0492306f708f0e5cac6bf0239deb3cd9a80.1687583718.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
d6128d77 |
|
24-Jun-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Remove variable modulation as it is constant ieee->modulation is initialized to 3 and then unchanged. All evaluations will result accordingly. Remove resulting dead code. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/ebd543d097a65f105078c71faceaed2a4d5e7b55.1687583718.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
18b89d19 |
|
19-Jun-2023 |
Michael Straube <straube.linux@gmail.com> |
staging: rtl8192e: convert else if sequence to switch Convert a sequence of else if statements that all check the same variable to a single switch statement. With a switch statement it is easier to see what is going on. Additionally this clears a checkpatch warning. WARNING: braces {} are not necessary for any arm of this statement Signed-off-by: Michael Straube <straube.linux@gmail.com> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20230619150953.22484-3-straube.linux@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
56424246 |
|
19-Jun-2023 |
Michael Straube <straube.linux@gmail.com> |
staging: rtl8192e: clean up brace coding style issues Clean up brace coding style in if/else statements to improve readability and clear checkpatch issues. CHECK: braces {} should be used on all arms of this statement CHECK: Unbalanced braces around else statement Signed-off-by: Michael Straube <straube.linux@gmail.com> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20230619150953.22484-2-straube.linux@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
413cc33f |
|
19-Jun-2023 |
Yogesh Hegde <yogi.kernel@gmail.com> |
staging: rtl8192e: Rename variable SetWirelessMode Rename variable SetWirelessMode to set_wireless_mode to avoid CamelCase which is not accepted by checkpatch. Signed-off-by: Yogesh Hegde <yogi.kernel@gmail.com> Link: https://lore.kernel.org/r/c0a65d217d272bf457917c89462c49e67bbfedb2.1687183827.git.yogi.kernel@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
57e2936e |
|
17-Jun-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Rename RTLLIB_LINKED_SCANNING Rename RTLLIB_LINKED_SCANNING to MAC80211_LINKED_SCANNING to align with rtlwifi driver. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/25b97cd436c636e750c50f0c03386fcc46e56610.1687007788.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
2445e3a5 |
|
17-Jun-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Rename RTLLIB_LINKED to MAC80211_LINKED Rename RTLLIB_LINKED to MAC80211_LINKED to align with rtlwifi driver. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/532bd98301657b2a8329e95eccb993540ae9ba3f.1687007788.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
fff6e869 |
|
17-Jun-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Rename RTLLIB_NOLINK to MAC80211_NOLINK Rename RTLLIB_NOLINK to MAC80211_NOLINK to align with rtlwifi driver. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/74feefdf800304deaf918efbc04344865f7aa01d.1687007788.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
52ac3ff9 |
|
17-Jun-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Rename state to link_state Rename state to link_state to align with rtlwifi driver and to increase readability as state is to general. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/9cf4d0b01c6a84a11939099b628754d4c6d54839.1687007788.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
5cac011c |
|
17-Jun-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Rename constant IEEE_x to WIRELESS_MODE_x Rename constant IEEE_B to WIRELESS_MODE_B, IEEE_G -> WIRELESS_MODE_G and IEEE_N_24G -> WIRELESS_MODE_N_24G to align with rtlwifi driver as requested in TODO. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/37d81ab3cbb0231868d75b11eaa2f65a0e6a9379.1687007788.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
26cdc2b7 |
|
17-Jun-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Remove unsupported modes IEEE_N_5G and IEEE_A Remove unsupported modes IEEE_N_5G and IEEE_A as those are not supported by hardware and are not offered by user software. Remove resulting dead code and unused defines. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/40c5b21654376348144280dbe45203140c6e6807.1687007788.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
c88af76f |
|
30-May-2023 |
Michael Straube <straube.linux@gmail.com> |
staging: rtl8192e: remove blank lines Remove unnecessary blank lines reported by checkpatch. Signed-off-by: Michael Straube <straube.linux@gmail.com> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Message-ID: <20230531053118.17053-1-straube.linux@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
8942c3f1 |
|
18-May-2023 |
Michael Straube <straube.linux@gmail.com> |
staging: rtl8192e: add missing spaces around operators Add missing spaces around operators to improve readability and clear checkpatch issues. Signed-off-by: Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20230518163201.14463-1-straube.linux@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
35a70c03 |
|
14-May-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Exclude scan_mutex in rtllib_softmac_stop_scan Exclude scan_mutex from cancel_delayed_work_sync(&ieee->softmac_scan_wq) as ieee->softmac_scan_wq takes scan_mutex as well. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20230514204033.GA20187@matrix-ESPRIMO-P710 Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
09201af5 |
|
13-May-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Remove undefined function LedControlHandler Remove function LedControlHandler as it is not defined. Remove resulting unused local variables bLedBlinking, type, fc and LedAction. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/e3c29c3db33d314dffb673f8e563da0fb1f2b22f.1683960685.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
b17bbcfb |
|
13-May-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Remove undefined function UpdateBeaconInterruptHandler Remove function UpdateBeaconInterruptHandler as it is not defined. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/7cc71096fb1e6fee755dd96de0095ef1fb6d51e1.1683960685.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
03477a46 |
|
13-May-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Remove functions rtllib_start_hw_scan and stop Remove functions rtllib_start_hw_scan and rtllib_stop_hw_scan as they are not defined. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/868524470321b8936f63d3ea06ba86c34fc89bb7.1683960684.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
27b644c5 |
|
13-May-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Remove undefined function data_hard_resume Remove function data_hard_resume as it is not defined. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/07048d775759fffe1d1c63d0416214da8311129a.1683960684.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
a634e894 |
|
13-May-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Remove undefined function data_hard_stop Remove function data_hard_stop as it is not defined. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/4cc180b9538d6c9c32ff0f56646a642fa217a4a4.1683960684.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
718ac8c8 |
|
24-Apr-2023 |
John Grace <johnmgrace1@gmail.com> |
staging: rtl8192e: avoid CamelCase <RATRIndex> Linux kernel coding-style suggests to not use mixed-case names. Fix checkpatch issue by changing the variable name from camel case to snake case. Signed-off-by: John Grace <johnmgrace1@gmail.com> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/ZEcjdUR/bnln7Z1J@iris Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
861a6a82 |
|
22-Mar-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Replace macro container_of_work_rsl with standard macro Replace macro container_of_work_rsl with standard macro container_of to increase readability. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/d75688b6f884c526f6046fac522b8ed87db1ca2f.1679504314.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
8c385e3f |
|
22-Mar-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Replace macro INIT_WORK_RSL with standard macro Replace macro INIT_WORK_RSL with standard macro INIT_WORK to increase readability. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/71879ccda54d57078f47c70cdba90ae2234adc91.1679504314.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
9c9c9f8e |
|
22-Mar-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Replace macro INIT_DELAYED_WORK_RSL with standard macro Replace macro INIT_DELAYED_WORK_RSL with standard macro INIT_DELAYED_WORK to increase readability. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/61b589012a5efb4b68a76e52eb84ad19093013b3.1679504314.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
4bd92a77 |
|
25-Feb-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Remove checks of pointer to rtllib.. and ScanOpera.. Function pointers of rtllib_ips_leave and ScanOperationBackupHandler is set while executing the probe function. Therefore a NULL pointer check is not required. Remove checks as it is dead code. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/8b01cbfaad2db4666b98bfeae29dd429d8c6cd07.1677345331.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
997f7f0c |
|
25-Feb-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Remove checks of pointer to stop_send.. and rtllib_.. Function pointers of stop_send_beacons and rtllib_ips_leave_wq is set while executing the probe function. Therefore a NULL pointer check is not required. Remove checks as it is dead code. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/f12e9167499344059f77991d2058c050bbe744d2.1677345331.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
f7cc8739 |
|
25-Feb-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Remove checks of pointer to LeisureP.. and start_se.. Function pointers of LeisurePSLeave and start_send_beacons is set while executing the probe function. Therefore a NULL pointer check is not required. Remove checks as it is dead code. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/cd828bb1c8dfbb6d2a85d770c82afbb9889e0ea2.1677345331.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
237fea2f |
|
25-Feb-2023 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Remove checks of pointer to handle_a.. and handle_b.. Function pointers of handle_assoc_response and handle_beacon is set while executing the probe function. Therefore a NULL pointer check is not required. Remove checks as it is dead code. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/5c0fd114c24616bc03271ccb0a72a6bc68e45d61.1677345331.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
ccdbe14b |
|
12-Nov-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Rename pHTInfo Rename variable pHTInfo to ht_info to avoid CamelCase which is not accepted by checkpatch. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/88cdc0ef393c92cb2102a66893c5320e8c8606df.1668313325.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
8e5d08ce |
|
12-Nov-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Rename bNetPromisc.., IntelPromiscu.. and bPromiscu.. Rename variable bNetPromiscuousMode to net_promiscuous_md, IntelPromiscuousModeInfo to intel_promiscuous_md_info and bPromiscuousOn to promiscuous_on to avoid CamelCase which is not accepted by checkpatch. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/69d9998a30ce2286c3ae6cb4510174e1255b3f9e.1668313325.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
7e5cfa3c |
|
12-Nov-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Rename LinkDetectInfo Rename variable LinkDetectInfo to link_detect_info to avoid CamelCase which is not accepted by checkpatch. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/48d043893fa755490e810af204e5b7ad2ba606de.1668313325.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
ab4bcf79 |
|
12-Nov-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Rename RFInProgres.., bEnableHT and RegChannelPlan Rename variable RFInProgressTimeOut to rf_in_progress_timeout, bEnableHT to enable_ht and RegChannelPlan to reg_chnl_plan to avoid CamelCase which is not accepted by checkpatch. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/aa3b8fd4a51fc9b1c32566cd079590bf11a9190d.1668313325.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
ca0298c0 |
|
12-Nov-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Rename pPSC Rename variable pPSC to psc to avoid CamelCase which is not accepted by checkpatch. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/47ded8a906e55d6f09b51cd8f2dfb78b7b92c1cc.1668313325.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
ca25401e |
|
12-Nov-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Rename Regdot11TxHT.., dot11HTOpera.. and RegHTSuppRa.. Rename variable Regdot11TxHTOperationalRateSet to reg_dot11tx_ht_oper_rate_set, dot11HTOperationalRateSet to dot11ht_oper_rate_set and RegHTSuppRateSet to reg_ht_supp_rate_set to avoid CamelCase which is not accepted by checkpatch. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/0c87e7ffc94be1c26f6400f5e12419f2df0418a3.1668313325.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
c7bf6d33 |
|
12-Nov-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Rename Regdot11HTOper.., bSupportM.. and PowerSaveCo.. Rename variable Regdot11HTOperationalRateSet to reg_dot11ht_oper_rate_set, bSupportMode to support_mode and PowerSaveControl to pwr_save_ctrl to avoid CamelCase which is not accepted by checkpatch. Fix unnecessary parentheses warning from checkpatch when used with this variables. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/1ef7fd22b4a037c4d1f8685065ce7916b6f0930b.1668313325.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
b397fc48 |
|
12-Nov-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Rename bTxDisableRate.., RegMaxLPSAwa.. and bTxUseD.. Rename variable bTxDisableRateFallBack to tx_dis_rate_fallback, RegMaxLPSAwakeIntvl to reg_max_lps_awake_intvl and bTxUseDriverAssingedRate to tx_use_drv_assinged_rate to avoid CamelCase which is not accepted by checkpatch. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/092eb2dc73d37daf851ea9ef9cb7e4df6f766845.1668313325.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
dba2628c |
|
01-Nov-2022 |
Gabhyun Kim <kimgaby415@gmail.com> |
staging: rtl8192e: Remove line breaks to match coding style Remove redundant line break in function definition to correct coding style. Signed-off-by: Gabhyun Kim <kimgaby415@gmail.com> Link: https://lore.kernel.org/r/20221101062636.GA3257@ubuntu Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
9c63f133 |
|
24-Sep-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Rename PeerMimoPs, IOTAction and IOTRaFunc Rename variable PeerMimoPs to peer_mimo_ps, IOTAction to iot_action and IOTRaFunc to iot_ra_func to avoid CamelCase which is not accepted by checkpatch. Added spaces around '&' as proposed by checkpatch. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/2a8ce7bff9a00fe44c057242cedb27ca91219137.1664055213.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
55bce0ae |
|
24-Sep-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Rename szRT2RTAggBuffer, bRegRxRe... and bCurRxReo... Rename variable szRT2RTAggBuffer to sz_rt2rt_agg_buf, bRegRxReorderEnable to reg_rx_reorder_enable and bCurRxReorderEnable to cur_rx_reorder_enable to avoid CamelCase which is not accepted by checkpatch. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/af445e0a80dc8e153a1ba81df99309f19a69d6cb.1664055213.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
27dd3f00 |
|
24-Sep-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Rename bSwBwInPro..., bRegRT2RTAg... and bCurrentRT... Rename variable bSwBwInProgress to sw_bw_in_progress, bRegRT2RTAggregation to reg_rt2rt_aggregation and bCurrentRT2RTAggregation to current_rt2rt_aggregation to avoid CamelCase which is not accepted by checkpatch. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/868f9db0e29bd170129f90bdbcc14238a750c440.1664055213.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
ec079860 |
|
24-Sep-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Rename eRFPowerState, eRfOff and eRfOn Rename variable eRFPowerState to rf_power_state, eRfOff to rf_off and eRfOn to rf_on to avoid CamelCase which is not accepted by checkpatch. Omit the upfront "e" as no RFPowerState, RfOff and RfOn exist and it makes the variables unnecessary long. Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/52c676bbaf1f894e30971c5c409b4bcb71c8ef7e.1664055213.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
9bbf2f32 |
|
16-Sep-2022 |
Philipp Hortmann <philipp.g.hortmann@gmail.com> |
staging: rtl8192e: Remove ftrace-like logging in rtl819x_BAProc.c, ... Remove "Unnecessary ftrace-like logging" as requested by checkpatch. Remove multiline macro as it is not needed anymore and not liked by kernel community. Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/2c41e6856cd37b4f3e5cb1108272bcc24032bf64.1663387785.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
700f7e29 |
|
25-Aug-2022 |
Jilin Yuan <yuanjilin@cdjrlc.com> |
staging/rtl8192e: fix repeated words in comments Delete the redundant word 'new'. Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com> Link: https://lore.kernel.org/r/20220825122645.27588-1-yuanjilin@cdjrlc.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
37a3929f |
|
16-May-2022 |
Haowen Bai <baihaowen@meizu.com> |
staging: rtl8192e: remove null check after call container_of() container_of() will never return NULL, so remove useless code. Signed-off-by: Haowen Bai <baihaowen@meizu.com> Link: https://lore.kernel.org/r/1652696403-17852-1-git-send-email-baihaowen@meizu.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
97042d0a |
|
21-Apr-2022 |
Haowen Bai <baihaowen@meizu.com> |
staging: rtl8192e: Fix signedness bug in rtllib_rx_assoc_resp() The rtllib_rx_assoc_resp() function has a signedness bug because it's a declared as a u16 but it return -ENOMEM. When you look at it more closely it returns a mix of error codes including 0xcafe, -ENOMEM, and a->status which is WLAN_STATUS_NOT_SUPPORTED_AUTH_ALG. This is a mess. Clean it up to just return standard kernel error codes. We can print out the a->status before returning a regular error code. The printks in the caller need to be adjusted as well. Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Haowen Bai <baihaowen@meizu.com> Link: https://lore.kernel.org/r/1650529277-7893-1-git-send-email-baihaowen@meizu.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
55de6cb7 |
|
19-Apr-2022 |
Solomon Tan <wjsota@gmail.com> |
staging: rtl8192e: Remove space after cast This patch addresses the checkpatch.pl flag that there should not be a space after a cast. Signed-off-by: Solomon Tan <wjsota@gmail.com> Link: https://lore.kernel.org/r/20220419124318.8028-1-wjsota@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
9b6bdbd9 |
|
17-Apr-2022 |
Duoming Zhou <duoming@zju.edu.cn> |
drivers: staging: rtl8192e: Fix deadlock in rtllib_beacons_stop() There is a deadlock in rtllib_beacons_stop(), which is shown below: (Thread 1) | (Thread 2) | rtllib_send_beacon() rtllib_beacons_stop() | mod_timer() spin_lock_irqsave() //(1) | (wait a time) ... | rtllib_send_beacon_cb() del_timer_sync() | spin_lock_irqsave() //(2) (wait timer to stop) | ... We hold ieee->beacon_lock in position (1) of thread 1 and use del_timer_sync() to wait timer to stop, but timer handler also need ieee->beacon_lock in position (2) of thread 2. As a result, rtllib_beacons_stop() will block forever. This patch extracts del_timer_sync() from the protection of spin_lock_irqsave(), which could let timer handler to obtain the needed lock. Signed-off-by: Duoming Zhou <duoming@zju.edu.cn> Link: https://lore.kernel.org/r/20220417141641.124388-1-duoming@zju.edu.cn Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
f96f8ae0 |
|
11-Apr-2022 |
Davidlohr Bueso <dave@stgolabs.net> |
staging/rtl8192e,ieee80211: replace ps tasklet with work Tasklets have long been deprecated as being too heavy on the system by running in irq context - and this is not a performance critical path. If a higher priority process wants to run, it must wait for the tasklet to finish before doing so. rtllib_sta_ps() and ieee80211_sta_ps() will now run in process context and have further concurrency (tasklets being serialized among themselves), but this is done holding the ieee->lock, so it should be fine. Signed-off-by: Davidlohr Bueso <dave@stgolabs.net> Link: https://lore.kernel.org/r/20220411151620.129178-7-dave@stgolabs.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
68bf78ff |
|
01-Dec-2021 |
Yang Yingliang <yangyingliang@huawei.com> |
staging: rtl8192e: return error code from rtllib_softmac_init() If it fails to allocate 'dot11d_info', rtllib_softmac_init() should return error code. And remove unneccessary error message. Fixes: 94a799425eee ("From: wlanfae <wlanfae@realtek.com>") Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: Pavel Skripkin <paskripkin@gmail.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Link: https://lore.kernel.org/r/20211202030704.2425621-2-yangyingliang@huawei.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
5337824f |
|
16-Nov-2021 |
Eric Dumazet <edumazet@google.com> |
net: annotate accesses to queue->trans_start In following patches, dev_watchdog() will no longer stop all queues. It will read queue->trans_start locklessly. Signed-off-by: Eric Dumazet <edumazet@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>
|
#
cf79ee6e |
|
23-Jul-2021 |
Len Baker <len.baker@gmx.com> |
staging/rtl8192e: Remove all strcpy() uses strcpy() performs no bounds checking on the destination buffer. This could result in linear overflows beyond the end of the buffer, leading to all kinds of misbehaviors. The safe replacement is strscpy(). It is also dangerous a strcpy() followed by a strcat(). In this case, refactor the code using scnprintf() and avoid this combination. Signed-off-by: Len Baker <len.baker@gmx.com> Link: https://lore.kernel.org/r/20210723173216.12157-1-len.baker@gmx.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
66d708e6 |
|
30-Apr-2021 |
zhaoxiao <zhaoxiao@uniontech.com> |
staging: rtl8192e: remove unnecesasry ftrace-like logging Fixed Check: Remove unnecessary ftrace-like logging by simply deleting that statement as we have other modes of logging like ftrace. Reported by checkpatch. Signed-off-by: zhaoxiao <zhaoxiao@uniontech.com> Link: https://lore.kernel.org/r/20210430122826.9899-1-zhaoxiao@uniontech.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
060d3f6c |
|
20-Feb-2021 |
William Durand <will+git@drnd.me> |
staging: rtl8192e: rename bdHTInfoLen to bd_ht_info_len in bss_ht struct Rename bdHTInfoLen to bd_ht_info_len to silence a checkpatch warning about CamelCase. Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: William Durand <will+git@drnd.me> Link: https://lore.kernel.org/r/20210220172909.15812-7-will+git@drnd.me Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
2408ee9e |
|
20-Feb-2021 |
William Durand <will+git@drnd.me> |
staging: rtl8192e: rename bdHTInfoBuf to bd_ht_info_buf in bss_ht struct Rename bdHTInfoBuf to bd_ht_info_buf to silence a checkpatch warning about CamelCase. Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: William Durand <will+git@drnd.me> Link: https://lore.kernel.org/r/20210220172909.15812-6-will+git@drnd.me Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
20e90635 |
|
20-Feb-2021 |
William Durand <will+git@drnd.me> |
staging: rtl8192e: rename bdHTCapLen to bd_ht_cap_len in bss_ht struct Rename bdHTCapLen to bd_ht_cap_len to silence a checkpatch warning about CamelCase. Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: William Durand <will+git@drnd.me> Link: https://lore.kernel.org/r/20210220172909.15812-5-will+git@drnd.me Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
b87b2108 |
|
20-Feb-2021 |
William Durand <will+git@drnd.me> |
staging: rtl8192e: rename bdHTCapBuf to bd_ht_cap_buf in bss_ht struct Rename bdHTCapBuf to bd_ht_cap_buf to silence a checkpatch warning about CamelCase. Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: William Durand <will+git@drnd.me> Link: https://lore.kernel.org/r/20210220172909.15812-4-will+git@drnd.me Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
b3b55bd7 |
|
20-Feb-2021 |
William Durand <will+git@drnd.me> |
staging: rtl8192e: rename bdSupportHT to bd_support_ht in bss_ht struct Rename bdSupportHT to bd_support_ht to silence a checkpatch warning about CamelCase. Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: William Durand <will+git@drnd.me> Link: https://lore.kernel.org/r/20210220172909.15812-3-will+git@drnd.me Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
46e65673 |
|
13-Feb-2021 |
William Durand <will+git@drnd.me> |
staging: rtl8192e: fix typo in a comment This patch fixes a checkpatch warning by deleting a repeated word. Signed-off-by: William Durand <will+git@drnd.me> Link: https://lore.kernel.org/r/20210213090112.24616-1-will+git@drnd.me Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
9d370869 |
|
07-Feb-2021 |
Phillip Potter <phil@philpotter.co.uk> |
staging: rtl8192e: remove braces from single-line block This removes the braces from the if statement that checks the wps_ie_len and ieee->wps_ie values in rtllib_association_req of rtllib_softmac.c as this block contains only one statement. Fixes a checkpatch warning. Signed-off-by: Phillip Potter <phil@philpotter.co.uk> Link: https://lore.kernel.org/r/20210207225703.114229-1-phil@philpotter.co.uk Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
49391bf2 |
|
16-Sep-2020 |
Allen Pais <apais@linux.microsoft.com> |
staging: rtl8192e: convert tasklets to use new tasklet_setup() API In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier <romain.perier@gmail.com> Signed-off-by: Allen Pais <apais@linux.microsoft.com> Link: https://lore.kernel.org/r/20200916062054.58084-1-allen.lkml@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
6cfed598 |
|
15-Nov-2019 |
Kees Cook <keescook@chromium.org> |
staging: rtl*: Remove tasklet callback casts In order to make the entire kernel usable under Clang's Control Flow Integrity protections, function prototype casts need to be avoided because this will trip CFI checks at runtime (i.e. a mismatch between the caller's expected function prototype and the destination function's prototype). Many of these cases can be found with -Wcast-function-type, which found that the rtl wifi drivers had a bunch of needless function casts. Remove function casts for tasklet callbacks in the various drivers. Signed-off-by: Kees Cook <keescook@chromium.org> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> Link: https://lore.kernel.org/r/201911150926.2894A4F973@keescook Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
36d042bd |
|
03-Aug-2019 |
Hariprasad Kelam <hariprasad.kelam@gmail.com> |
staging: rtl8192e: Make use kmemdup As kmemdup API does kmalloc + memcpy . We can make use of it instead of calling kmalloc and memcpy independetly. Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com> Link: https://lore.kernel.org/r/20190804024832.GA14352@hari-Inspiron-1545 Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
18056f34 |
|
01-Apr-2019 |
Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
staging: rtl8192e: add proper SPDX identifiers on files that did not have them. There were a few files for the rtl8192e driver that did not have SPDX identifiers on them, so fix that up. At the same time, remove the "free form" text that specified the license of the file, as that is impossible for any tool to properly parse. Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
c40cac3b |
|
10-Feb-2019 |
Himadri Pandya <himadri18.07@gmail.com> |
staging: rtl8192e: rename function DOT11D_ScanComplete to dot11d_scan_complete - style Rename function DOT11D_ScanComplete to dot11d_scan_complete to fix checkpatch warning: Avoid CamelCase. Signed-off-by: Himadri Pandya <himadri18.07@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
8e9f5da2 |
|
10-Feb-2019 |
Himadri Pandya <himadri18.07@gmail.com> |
staging: rtl8192e: rename function Dot11d_Reset to dot11d_reset - style Rename function Dot11d_Reset to dot11d_reset to fix checkpatch warning: Avoid CamelCase. Signed-off-by: Himadri Pandya <himadri18.07@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
a180ef30 |
|
06-Feb-2019 |
Himadri Pandya <himadri18.07@gmail.com> |
staging: rtl8192e: rename members of struct rtllib_device - style Rename following members of struct rtllib_device to fix checkpatch warning: Avoid CamelCase pDot11dInfo -> dot11d_info bGlobalDomain -> global_domain IbssStartChnl -> bss_start_channel Signed-off-by: Himadri Pandya <himadri18.07@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
0fa82deb |
|
26-Jan-2019 |
Michiel Schuurmans <michielschuurmans@gmail.com> |
Staging: rtl8192e: Replaced spaces with tab. Replaced the spaces with tabs as suggested by checkpatch. Signed-off-by: Michiel Schuurmans <michielschuurmans@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
86eac24d |
|
27-Aug-2018 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Fix compiler warning from strncpy() When strncpy() is called with source and destination strings the same length, gcc 8 warns that there may be an unterminated string. This section is completely reworked to use the known lengths of the strings. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
783778e3 |
|
20-Jan-2018 |
Colin Ian King <colin.king@canonical.com> |
staging: rtl8192e: remove two redundant assignments Clang detected two redundant assignments that can be safely removed. The first is the removal of the duplicated assignment to pointer 'hdr', this has already been initialized with the same value. The second is the removal of the redundant initialization of variable 'timeout', this assigned value is never read and the variable is reassigned a new value a little later. Remove both redundant assignments, cleans up clang warnings: drivers/staging/rtl8192e/rtllib_rx.c:1305:27: warning: Value stored to 'hdr' during its initialization is never read drivers/staging/rtl8192e/rtllib_softmac.c:1971:6: warning: Value stored to 'timeout' during its initialization is never read Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
96bc1f2a |
|
16-Oct-2017 |
Kees Cook <keescook@chromium.org> |
staging: rtl8192e: Convert timers to use timer_setup() In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Derek Robson <robsonde@gmail.com> Cc: Suniel Mahesh <suniel.spartan@gmail.com> Cc: Malcolm Priestley <tvboxspy@gmail.com> Cc: Gargi Sharma <gs051095@gmail.com> Cc: Julia Lawall <Julia.Lawall@lip6.fr> Cc: "David S. Miller" <davem@davemloft.net> Cc: Johannes Berg <johannes.berg@intel.com> Cc: Yamanappagouda Patil <goudapatilk@gmail.com> Cc: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com> Cc: Colin Ian King <colin.king@canonical.com> Cc: Baoyou Xie <baoyou.xie@linaro.org> Cc: devel@driverdev.osuosl.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Derek Robson <robsonde@gmail.com> Cc: Suniel Mahesh <suniel.spartan@gmail.com> Cc: Malcolm Priestley <tvboxspy@gmail.com> Cc: Gargi Sharma <gs051095@gmail.com> Cc: Julia Lawall <Julia.Lawall@lip6.fr> Cc: Yamanappagouda Patil <goudapatilk@gmail.com> Cc: "David S. Miller" <davem@davemloft.net> Cc: Johannes Berg <johannes.berg@intel.com> Cc: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com> Cc: Colin Ian King <colin.king@canonical.com> Cc: Baoyou Xie <baoyou.xie@linaro.org> Cc: devel@driverdev.osuosl.org Signed-off-by: Kees Cook <keescook@chromium.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
1ce72e8a |
|
22-Sep-2017 |
Colin Ian King <colin.king@canonical.com> |
staging: rtl8192e: make const array broadcast_addr static, reduces object code size Don't populate const array broadcast_addr on the stack, instead make it static. Makes the object code smaller by over 40 bytes: Before: text data bss dec hex filename 63906 8248 1216 73370 11e9a rtllib_softmac.o After: text data bss dec hex filename 63806 8304 1216 73326 11e6e rtllib_softmac.o (gcc 6.3.0, x86-64) Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
8ad33de5 |
|
27-Jun-2017 |
Colin Ian King <colin.king@canonical.com> |
staging: rtl8192e: fix spelling mistake: "respose" -> "response" Trivial fix to spelling mistake in netdev_info message and split line to clean up an checkpatch line too wide warning. Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
f0836fd2 |
|
14-Jun-2017 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: rtl8192e: remove dead code rtllib_wpa_supplicant_ioctl Following removal of _rtl92e_ioctl this function along with associated macros, structure ieee_param and functions become dead code. Remove functions rtllib_wpa_enable, rtllib_wpa_assoc_frame, rtllib_wpa_mlme, rtllib_wpa_set_wpa_ie, rtllib_wpa_set_auth_algs, rtllib_wpa_set_param, rtllib_wpa_set_encryption and rtllib_wpa_supplicant_ioctl. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
b952f4df |
|
18-Jun-2017 |
yuan linyu <Linyu.Yuan@alcatel-sbell.com.cn> |
net: manual clean code which call skb_put_[data:zero] Signed-off-by: yuan linyu <Linyu.Yuan@alcatel-sbell.com.cn> Signed-off-by: David S. Miller <davem@davemloft.net>
|
#
4df864c1 |
|
16-Jun-2017 |
Johannes Berg <johannes.berg@intel.com> |
networking: make skb_put & friends return void pointers It seems like a historic accident that these return unsigned char *, and in many places that means casts are required, more often than not. Make these functions (skb_put, __skb_put and pskb_put) return void * and remove all the casts across the tree, adding a (u8 *) cast only where the unsigned char pointer was used directly, all done with the following spatch: @@ expression SKB, LEN; typedef u8; identifier fn = { skb_put, __skb_put }; @@ - *(fn(SKB, LEN)) + *(u8 *)fn(SKB, LEN) @@ expression E, SKB, LEN; identifier fn = { skb_put, __skb_put }; type T; @@ - E = ((T *)(fn(SKB, LEN))) + E = fn(SKB, LEN) which actually doesn't cover pskb_put since there are only three users overall. A handful of stragglers were converted manually, notably a macro in drivers/isdn/i4l/isdn_bsdcomp.c and, oddly enough, one of the many instances in net/bluetooth/hci_sock.c. In the former file, I also had to fix one whitespace problem spatch introduced. Signed-off-by: Johannes Berg <johannes.berg@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net>
|
#
59ae1d12 |
|
16-Jun-2017 |
Johannes Berg <johannes.berg@intel.com> |
networking: introduce and use skb_put_data() A common pattern with skb_put() is to just want to memcpy() some data into the new space, introduce skb_put_data() for this. An spatch similar to the one for skb_put_zero() converts many of the places using it: @@ identifier p, p2; expression len, skb, data; type t, t2; @@ ( -p = skb_put(skb, len); +p = skb_put_data(skb, data, len); | -p = (t)skb_put(skb, len); +p = skb_put_data(skb, data, len); ) ( p2 = (t2)p; -memcpy(p2, data, len); | -memcpy(p, data, len); ) @@ type t, t2; identifier p, p2; expression skb, data; @@ t *p; ... ( -p = skb_put(skb, sizeof(t)); +p = skb_put_data(skb, data, sizeof(t)); | -p = (t *)skb_put(skb, sizeof(t)); +p = skb_put_data(skb, data, sizeof(t)); ) ( p2 = (t2)p; -memcpy(p2, data, sizeof(*p)); | -memcpy(p, data, sizeof(*p)); ) @@ expression skb, len, data; @@ -memcpy(skb_put(skb, len), data, len); +skb_put_data(skb, data, len); (again, manually post-processed to retain some comments) Reviewed-by: Stephen Hemminger <stephen@networkplumber.org> Signed-off-by: Johannes Berg <johannes.berg@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net>
|
#
95b80b30 |
|
13-May-2017 |
Malcolm Priestley <tvboxspy@gmail.com> |
staging: rtl8192e: Let user know mac address associated with. User cannot tell which mac address(BSIDD) associated with so add this to info message. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
1393f1bc |
|
09-Feb-2017 |
Colin Ian King <colin.king@canonical.com> |
Staging: rtl8192e: remove redundant null check on array alg u.crypt.alg is an array of u8 integers and hence the null check on this array is redundant and can be removed. Detected with CoverityScan, CID#146583 ("Array compared against 0") Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
29f22246 |
|
15-Nov-2016 |
Yamanappagouda Patil <goudapatilk@gmail.com> |
staging: rtl8192e: Added new line after declaration Fixed checkpatch.pl "Missing a blank line after declarations" warnings. Signed-off-by: Yamanappagouda Patil <goudapatilk@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
ec65ef8e |
|
04-Sep-2016 |
Baoyou Xie <baoyou.xie@linaro.org> |
Staging: rtl8192e: mark symbols static where possible We get a few warnings when building kernel with W=1: drivers/staging/rtl8192e/rtllib_softmac.c:279:13: warning: no previous declaration for 'softmac_ps_mgmt_xmit' [-Wmissing-declarations] drivers/staging/rtl8192e/rtllib_softmac.c:773:24: warning: no previous declaration for 'rtllib_authentication_req' [-Wmissing-declarations] .... In fact, these functions are only used in the file in which they are declared and don't need a declaration, but can be made static. In addition, some of these functions are declared in different files, it looks like that we need to clean the codes of this driver up, but we can repress these warnings first, then clean it up. so this patch marks these functions with 'static' now. Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
38bee763 |
|
01-Jun-2016 |
Binoy Jayan <binoy.jayan@linaro.org> |
rtl8192e: Replace semaphore ips_sem with mutex The semaphore 'ips_sem' in the rtl8192e is a simple mutex, so it should be written as one. Semaphores are going away in the future. Signed-off-by: Binoy Jayan <binoy.jayan@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
be10ceea |
|
01-Jun-2016 |
Binoy Jayan <binoy.jayan@linaro.org> |
rtl8192e: Replace semaphore scan_sem with mutex The semaphore 'scan_sem' in the rtl8192e is a simple mutex, so it should be written as one. Semaphores are going away in the future. Signed-off-by: Binoy Jayan <binoy.jayan@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
9afa9370 |
|
01-Jun-2016 |
Binoy Jayan <binoy.jayan@linaro.org> |
rtl8192e: rtllib_device: Replace semaphore wx_sem with mutex The semaphore 'wx_sem' in the rtllib_device is a simple mutex, so it should be written as one. Semaphores are going away in the future. Signed-off-by: Binoy Jayan <binoy.jayan@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
4d0e9657 |
|
03-May-2016 |
Florian Westphal <fw@strlen.de> |
drivers: replace dev->trans_start accesses with dev_trans_start a trans_start struct member exists twice: - in struct net_device (legacy) - in struct netdev_queue Instead of open-coding dev->trans_start usage to obtain the current trans_start value, use dev_trans_start() instead. This is not exactly the same, as dev_trans_start also considers the trans_start values of the netdev queues owned by the device and provides the most recent one. For legacy devices this doesn't matter as dev_trans_start can cope with netdev trans_start values of 0 (they are ignored). This is a prerequisite to eventual removal of dev->trans_start. Cc: linux-rdma@vger.kernel.org Signed-off-by: Florian Westphal <fw@strlen.de> Signed-off-by: David S. Miller <davem@davemloft.net>
|
#
37241977 |
|
01-Mar-2016 |
Bhumika Goyal <bhumirks@gmail.com> |
Staging: rtl8192e: Replace random_ether_addr with eth_random_addr The macro random_ether_addr is calling the function eth_random_addr. Therefore, the call to random_ether_addr can be replaced with eth_random_addr. Remove the wrapper function rtllib_randomize_cell and replace its call with eth_random_addr as it is wrapping random_ether_addr. Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
354605f4 |
|
20-Feb-2016 |
Amitoj Kaur Chawla <amitoj1606@gmail.com> |
staging: rtl8192e: Remove create_workqueue() With conccurency managed workqueues, use of dedicated workqueues can be replaced by system_wq. Drop wq by using system_wq. Since there are multiple work items per rtllib but they do not need to be ordered, increase of concurrency by switching to system_wq should not break anything. All work items are sync canceled on rtllib_stop_protocol() so it is guaranteed that no work is running when rtl92e_disable/reset/restart functions are called. Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com> Acked-by: Tejun Heo <tj@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
7949be66 |
|
18-Feb-2016 |
Bhaktipriya Shridhar <bhaktipriya96@gmail.com> |
staging: rtl8192e: Drop useless initialisation Removed initialisation of a varible if it is immediately reassigned. Changes were made using Coccinelle. @@ type T; constant C; expression e; identifier i; @@ T i - = C ; i = e; Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
686f0c23 |
|
07-Feb-2016 |
Hari Prasath Gujulan Elango <hgujulan@visteon.com> |
staging: rtl8192e: prefer using eth_broadcast_addr() Prefer using the eth_broadcast_addr() instead of memset to broadcast address 0xFF to the array. Signed-off-by: Hari Prasath Gujulan Elango <hgujulan@visteon.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
0bd35534 |
|
15-Nov-2015 |
Sean MacLennan <seanm@seanm.ca> |
staging:rtl8192e: Usage count off by one The rtllib driver is not calling try_module_get() when loading the encryption modules. Because of this, you can never remove the module once you have used it one (i.e. bring up the wireless interface). Signed-off-by: Sean MacLennan <seanm@seanm.ca> Tested-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
bd60ac14 |
|
14-Oct-2015 |
Shivani Bhardwaj <shivanib134@gmail.com> |
Staging: rtl8192e: rtllib_softmac: Remove useless cast Explicit type conversion is not required to remove it. Semantic patch used: @@ type T; T e; identifier x; @@ * T x = (T)e; Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
4c29207a |
|
20-Sep-2015 |
Mateusz Kulikowski <mateusz.kulikowski@gmail.com> |
staging: rtl8192e: Fix CONSTANT_COMPARISON warnings Remove yoda conditions where pointed by checkpatch. Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
fc00af0c |
|
20-Sep-2015 |
Mateusz Kulikowski <mateusz.kulikowski@gmail.com> |
staging: rtl8192e: Fix SUSPECT_CODE_INDENT warnings Fix SUSPECT_CODE_INDENT warnings (indentation). Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
3e3148c5 |
|
25-Jun-2015 |
Vaishali Thakkar <vthakkar1994@gmail.com> |
Staging: rtl8192e: Replace memset with eth_zero_addr Use eth_zero_addr to assign the zero address to the given address array instead of memset when second argument is address of zero. Note that the 6 in the third argument of memset appears to represent an ethernet address size (ETH_ALEN). The Coccinelle semantic patch that makes this change is as follows: // <smpl> @eth_zero_addr@ expression e; @@ -memset(e,0x00,6); +eth_zero_addr(e); // </smpl> Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
6957248f |
|
14-Jul-2015 |
Mateusz Kulikowski <mateusz.kulikowski@gmail.com> |
staging: rtl8192e: rtllib_softmac: Make functions static Make as many functions as possible static in rtllib_softmac.c. The following functions were affected: - rtllib_sta_wakeup - rtllib_TURBO_Info - rtllib_get_beacon_ - rtllib_send_probe_requests - rtllib_update_active_chan_map - rtllib_softmac_scan_syncro Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
9efe891d |
|
14-Jul-2015 |
Mateusz Kulikowski <mateusz.kulikowski@gmail.com> |
staging: rtl8192e: Remove unused defines Remove most of unused defines (excluding phyreg/hw registers). Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
2e59e40d |
|
16-Jun-2015 |
Gnanachandran Dhanapal <gdhanapa@visteon.com> |
Staging: rtl8192e: Timer setup using macro rather assignment This patch shall replaces user defined timer setup function with standard timer setup macro. Also removes init_timer, because timer can be initialized in setup_timer macro as well. Signed-off-by: Gnanachandran Dhanapal <gdhanapa@visteon.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
47eae6dd |
|
15-Jun-2015 |
Mateusz Kulikowski <mateusz.kulikowski@gmail.com> |
staging: rtl8192e: Remove rtllib_device::agregation Variable is always true; Resolve condition where it is used (and change indentation of conditional expression). Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
0941f87f |
|
15-Jun-2015 |
Mateusz Kulikowski <mateusz.kulikowski@gmail.com> |
staging: rtl8192e: Remove softmac_hint11d_wq queue This queue is never used, and function handler is empty Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
48eb2b7e |
|
15-Jun-2015 |
Mateusz Kulikowski <mateusz.kulikowski@gmail.com> |
staging: rtl8192e: Remove unused rtllib_device members Delete several members of rtllib_device including their initializers if needed. Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
79b7d693 |
|
15-Jun-2015 |
Mateusz Kulikowski <mateusz.kulikowski@gmail.com> |
staging: rtl8192e: Remove rtllib_is_shortslot() This function was declared but never unused. Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
4b2f2184 |
|
15-Jun-2015 |
Mateusz Kulikowski <mateusz.kulikowski@gmail.com> |
staging: rtl8192e: Remove rtllib_wake_queue() This function was declared but never unused. Also remove dequeue_mgmt() and rtllib_resume_tx() that are no longer used. Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
f5259846 |
|
15-Jun-2015 |
Mateusz Kulikowski <mateusz.kulikowski@gmail.com> |
staging: rtl8192e: Remove rtllib_stop_queue() This function was declared but never unused. Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
fa70ae09 |
|
09-Jun-2015 |
Gnanachandran Dhanapal <gdhanapa@visteon.com> |
Staging: rtl8192e: Casting correct Endianness Casting correct Endianness for __le16 variable used in assignment and condition check Signed-off-by: Gnanachandran Dhanapal <gdhanapa@visteon.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
35e33b04 |
|
31-May-2015 |
Mateusz Kulikowski <mateusz.kulikowski@gmail.com> |
staging: rtl8192e: Fix LONG_LINE warnings Fix most of simple LONG_LINE warnings. None of the changes should affect behaviour of code, so several modifications are included in this patch: - Code is reindented where needed - Local variable names are compacted (priv -> p) - Unnecessary casts are removed - Nested ifs are replaced with logical and - a = b = c = d expressions are split - Replace if/then series with clamp_t() - Removed unneeded scopes Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
e9fea2ec |
|
31-May-2015 |
Mateusz Kulikowski <mateusz.kulikowski@gmail.com> |
staging: rtl8192e: Remove RTLLIB_DEBUG_MGMT() - Use netdev_dbg() instead of RTLLIB_DEBUG_MGMT() - Remove RTLLIB_DEBUG_MGMT() - Pass net_device to auth_parse(), auth_rq_parse() and assoc_rq_parse() - Remove duplicated messages Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
11e672c3 |
|
31-May-2015 |
Mateusz Kulikowski <mateusz.kulikowski@gmail.com> |
staging: rtl8192e: Replace RTLLIB_DEBUG(DL_ERR) with netdev_*() Replace all RTLLIB_DEBUG(RTLLIB_DL_ERR, *) calls with netdev_err() for errors that really should be reported to user. Use netdev_warn() for the rest. Rephrase some of the messages to make them more readable/compact. Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
c2f8b4ab |
|
31-May-2015 |
Mateusz Kulikowski <mateusz.kulikowski@gmail.com> |
staging: rtl8192e: Replace memcmp() with ether_addr_equal() Use dedicated macro to compare ethernet addresses in probe_rq_parse(). Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
b57ceb19 |
|
31-May-2015 |
Mateusz Kulikowski <mateusz.kulikowski@gmail.com> |
staging: rtl8192e: Fix PREFER_ETHER_ADDR_COPY warnings Replace memcpy() with ether_addr_copy() where possible to make checkpatch.pl happy. Change was target tested (download 1Mb file over WPA2 network) with BUG trap for unaligned addresses in ether_addr_copy() Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
06c11107 |
|
31-May-2015 |
Mateusz Kulikowski <mateusz.kulikowski@gmail.com> |
staging: rtl8192e: Make ethernet addresses properly aligned Reorder ethernet addresses allocated on stack or in non-packed structures to keep them aligned(2). Use ETH_ALEN as array length in places where it was hardcoded to 6. Alignment verified using pahole where possible and target-tested with BUG_ON() trap in ether_addr_copy. Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
c7ddc288 |
|
31-May-2015 |
Mateusz Kulikowski <mateusz.kulikowski@gmail.com> |
staging: rtl8192e: accept const MAC address Make set_swcam, setKey and rtllib_probe_resp parameter (MAC address) const. Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
640f7d69 |
|
09-May-2015 |
Arno Tiemersma <arno.tiemersma@gmail.com> |
staging: rtl8192e: Change cpu_to_le16 to le16_to_cpu Since the function auth_parse returns a u16, and struct rtllib_authentication.status is defined as an __le16, it seems that return cpu_to_le16(a->status); should be return le16_to_cpu(a->status); This change silences the following sparse warnings: drivers/staging/rtl8192e/rtllib_softmac.c:1817:16: warning: cast from restricted __le16 drivers/staging/rtl8192e/rtllib_softmac.c:1817:16: warning: incorrect type in return expression (different base types) drivers/staging/rtl8192e/rtllib_softmac.c:1817:16: expected unsigned short drivers/staging/rtl8192e/rtllib_softmac.c:1817:16: got restricted __le16 [usertype] <noident> Signed-off-by: Arno Tiemersma <arno.tiemersma@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
acd442db |
|
26-Apr-2015 |
Paul Gortmaker <paul.gortmaker@windriver.com> |
rtl8192e: delete local copy of iee80211 reason codes. This driver has a copy of the standard reason codes from the file <linux/ieee80211.h> but with slightly different name fields. Delete the local copy and remap the only two use cases onto the names used by the global implementation with the same values. Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
14b40d92 |
|
31-Mar-2015 |
Mateusz Kulikowski <mateusz.kulikowski@gmail.com> |
staging: rtl8192e: Comment cleanup (style/format) - Multiline comments use "network subsystem comment style" - Merge short multiline comments - Remove empty comments - Remove function name comment at the end of small (<1 screen) functions - Reformat 802.11 data frame format to use spaces and network format Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
e725fb6f |
|
31-Mar-2015 |
Mateusz Kulikowski <mateusz.kulikowski@gmail.com> |
staging: rtl8192e: Fix indentation in rtllib_rx_auth_resp() Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
f7567e20 |
|
31-Mar-2015 |
Mateusz Kulikowski <mateusz.kulikowski@gmail.com> |
staging: rtl8192e: Decrease nesting of rtllib_rx_auth_resp() Return from rtllib_rx_auth_resp() if auth_parse() fails. Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
e8f05b0b |
|
31-Mar-2015 |
Mateusz Kulikowski <mateusz.kulikowski@gmail.com> |
staging: rtl8192e: Divide rtllib_rx_auth() Move authentication response processing to rtllib_rx_auth_resp() function. No logic is affected. Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
e2ac0431 |
|
31-Mar-2015 |
Mateusz Kulikowski <mateusz.kulikowski@gmail.com> |
staging: rtl8192e: Fix LINE_CONTINUATIONS warning Fix 'Avoid unnecessary line continuations' checkpatch.pl warning Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
0f0688b3 |
|
31-Mar-2015 |
Mateusz Kulikowski <mateusz.kulikowski@gmail.com> |
staging: rtl8192e: Fix RETURN_VOID warnings Fix 'void function return statements are not generally useful' checkpatch.pl warnings Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
285b7c00 |
|
31-Mar-2015 |
Mateusz Kulikowski <mateusz.kulikowski@gmail.com> |
staging: rtl8192e: Fix UNNECESSARY_ELSE warning Fix checkpatch warnings 'else is not generally useful after a break or return' Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
d69d2054 |
|
16-Mar-2015 |
Mateusz Kulikowski <mateusz.kulikowski@gmail.com> |
staging: rtl8192e: fix coding style warnings (printk -> netdev_*) Use netdev_*, dev_* or pr_* instead of printk where possible. KERN_DEBUG messages are left intact as pr_dbg has different behaviour. Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
dc986e3e |
|
16-Mar-2015 |
Mateusz Kulikowski <mateusz.kulikowski@gmail.com> |
staging: rtl8192e: fix coding style issues (spaces before semicolon) Fix checkpatch.pl warning 'space prohibited before semicolon'. Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
0822339b |
|
16-Mar-2015 |
Mateusz Kulikowski <mateusz.kulikowski@gmail.com> |
staging: rtl8192e: fix coding style issues (merge broken strings) Fix checkpatch.pl warnings: - 'WARNING: quoted string split across lines' - 'WARNING: break quoted strings at a space character' Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
26049b11 |
|
13-Mar-2015 |
Supriya Karanth <iskaranth@gmail.com> |
staging: rtl8192e: remove break after return Remove "break" statement after a "return" statement as it does not get executed. Found by checkpatch.pl - break is not useful after a goto or return Signed-off-by: Supriya Karanth <iskaranth@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
8b9733c1 |
|
11-Mar-2015 |
Vaishali Thakkar <vthakkar1994@gmail.com> |
Staging: rtl8192e: Eliminate use of MSECS macro Use msecs_to_jiffies instead of driver specific macro MSECS. This is done using Coccinelle and semantic patch used for this is as follows: @@expression t;@@ - MSECS(t) + msecs_to_jiffies(t) Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
d272f9dd |
|
10-Mar-2015 |
Navya Sri Nizamkari <navyasri.tech@gmail.com> |
staging: rtl8192e: Use kzalloc instead of kmalloc. This patch uses kzalloc instead of kmalloc function. A coccinelle script was used to make this change. Signed-off-by: Navya Sri Nizamkari <navyasri.tech@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
cdbaf3f6 |
|
03-Mar-2015 |
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> |
staging: rtl8192e: replace memset(x,0,ETH_ALEN) by eth_zero_addr(x) eth_zero_addr() is a wrapper function for memset if 0 is going to be assigned to a mac address. The replacement was done by the following coccinelle script: @header@ @@ #include <linux/etherdevice.h> @eth_zero_addr@ expression e; @@ -memset(e,0,ETH_ALEN); +eth_zero_addr(e); @eth_broadcast_addr@ identifier e; @@ -memset(e,\(0xff\|0xFF\|255\),ETH_ALEN); +eth_broadcast_addr(e); @linux_header depends on !header && (eth_zero_addr || eth_broadcast_addr) @ @@ + #include <linux/etherdevice.h> + @special_header depends on !header && !linux_header && (eth_zero_addr || eth_broadcast_addr) @ @@ + + #include <linux/etherdevice.h> + @custom_header depends on !header && !linux_header && !special_header && (eth_zero_addr || eth_broadcast_addr) @ @@ + + #include <linux/etherdevice.h> Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
876e20d3 |
|
23-Nov-2014 |
Devendra Naga <devendra.aaru@gmail.com> |
staging: rtl8192e: add missing tasklet_kill on remove path The powersave tasklet is created in rtllib_softmac_init and it is not removed while unloading the module. Cc: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Devendra Naga <devendra.aaru@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
16fc54ee |
|
29-Oct-2014 |
Behan Webster <behanw@converseincode.com> |
staging, rtl8192e, LLVMLinux: Make static local in inline function const rtllib_association_req is a (large) inline function which defines 2 constant static arrays which aren't labelled as const. As a result clang complains with: non-constant static local variable in inline function may be different in different files [-Wstatic-local-in-inline] static u8 AironetIeOui[] = {0x00, 0x01, 0x66}; ^ The solution is making them "static const". However doing so requires dropping const when being used with struct octet_string. However the value is used in a const fashion thereafter, so no harm done. Signed-off-by: Behan Webster <behanw@converseincode.com> Suggested-by: Arnd Bergmann <arnd@arndb.de> Cc: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
d82f0029 |
|
29-Oct-2014 |
Behan Webster <behanw@converseincode.com> |
staging, rtl8192e, LLVMLinux: Remove unused prototype MgntQuery_MgntFrameTxRate is only used within rtllib_softmac.c, so it really should be static instead of extern. Since it is currently extern a warning is generated because a different function of the same name is defined staticlly in ieee80211_softmac.c Removing the incorrect extern declaration and defining the rtllib_softmac version of this routine static fixes the warning. Signed-off-by: Behan Webster <behanw@converseincode.com> Suggested-by: Arnd Bergmann <arnd@arndb.de> Cc: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
6d91857d |
|
29-Oct-2014 |
Behan Webster <behanw@converseincode.com> |
staging, rtl8192e, LLVMLinux: Change extern inline to static inline With compilers which follow the C99 standard (like modern versions of gcc and clang), "extern inline" does the opposite thing from older versions of gcc (emits code for an externally linkable version of the inline function). "static inline" does the intended behavior in all cases instead. Signed-off-by: Behan Webster <behanw@converseincode.com> Suggested-by: Arnd Bergmann <arnd@arndb.de> Cc: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
92db2a27 |
|
21-Sep-2014 |
Mahati Chamarthy <mahati.chamarthy@gmail.com> |
Staging: rtl8192e: Fix else is not useful warning style This fixes the following checkpatch.pl warnings: WARNING: else is not generally useful after a break or return Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
3a6b70c3 |
|
22-Aug-2014 |
Matthew Casey <mdcasey@chabloom.com> |
staging: rtl8192e: fixed coding style issues Fixed missing blank line after declarations issues Signed-off-by: Matthew Casey <mdcasey@chabloom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
4764ca98 |
|
26-May-2014 |
Peter Senna Tschudin <peter.senna@gmail.com> |
drivers/staging: Remove useless return variables This patch remove variables that are initialized with a constant, are never updated, and are only used as parameter of return. Return the constant instead of using a variable. Verified by compilation only. The coccinelle script that find and fixes this issue is: // <smpl> @@ type T; constant C; identifier ret; @@ - T ret = C; ... when != ret when strict return - ret + C ; // </smpl> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
430fb250 |
|
24-Apr-2014 |
Masanari Iida <standby24x7@gmail.com> |
staging: rtl8192e: Fix typo in rtl8192e Fix spelling typo in comments within rtl8192e. Signed-off-by: Masanari Iida <standby24x7@gmail.com> Reviewed-by: James Cameron <quozl@laptop.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
a0711c4d |
|
26-Dec-2013 |
Matthias Schoepe <matthias.schoepe@studium.uni-erlangen.de> |
Staging rtl8192e: Fixing checkpatch errors We fixed checkpatch errors of the following type: ERROR: "foo * bar" should be "foo *bar" The error was fixed in the following files of the rtl8192e staging driver: rtllib_softmac.c rtllib_rx.c rtllib_crypt.c rtllib.h There are no functional changes in this patch. Signed-off-by: Matthias Schoepe <matthias.schoepe@studium.uni-erlangen.de> Signed-off-by: Andreas Frembs <andreas.frembs@studium.uni-erlangen.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
c5654c0b |
|
07-Nov-2013 |
Rashika Kheria <rashika.kheria@gmail.com> |
Staging: rtl8192e: Fix Sparse Warning for Static Declarations in rtllib_softmac.c This patch fixes the following Sparse warnings in rtllib_softmac.c- drivers/staging/rtl8192e/rtllib_softmac.c:3636:12: warning: symbol 'rtllib_MgntDisconnectIBSS' was not declared. Should it be static? drivers/staging/rtl8192e/rtllib_softmac.c:3661:13: warning: symbol 'rtllib_MlmeDisassociateRequest' was not declared. Should it be static? drivers/staging/rtl8192e/rtllib_softmac.c:3687:13: warning: symbol 'rtllib_MgntDisconnectAP' was not declared. Should it be static? Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com> Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
1830a6d8 |
|
07-Nov-2013 |
Rashika Kheria <rashika.kheria@gmail.com> |
Staging: rtl8192e: Fix incorrect type in assignment in rtllib_softmac.c This patch fixes the following Sparse warning in rtllib_softmac.c- drivers/staging/rtl8192e/rtllib_softmac.c:298:12: warning: incorrect type in assignment (different base types) drivers/staging/rtl8192e/rtllib_softmac.c:298:12: expected unsigned short [unsigned] [usertype] fc drivers/staging/rtl8192e/rtllib_softmac.c:298:12: got restricted __le16 [usertype] frame_ctl drivers/staging/rtl8192e/rtllib_softmac.c:810:32: warning: incorrect type in assignment (different base types) drivers/staging/rtl8192e/rtllib_softmac.c:810:32: expected restricted __le16 [usertype] frame_ctl drivers/staging/rtl8192e/rtllib_softmac.c:810:32: got int drivers/staging/rtl8192e/rtllib_softmac.c:814:34: warning: incorrect type in assignment (different base types) drivers/staging/rtl8192e/rtllib_softmac.c:814:34: expected restricted __le16 [usertype] duration_id drivers/staging/rtl8192e/rtllib_softmac.c:814:34: got int drivers/staging/rtl8192e/rtllib_softmac.c:821:33: warning: incorrect type in assignment (different base types) drivers/staging/rtl8192e/rtllib_softmac.c:821:33: expected restricted __le16 [usertype] algorithm drivers/staging/rtl8192e/rtllib_softmac.c:821:33: got int drivers/staging/rtl8192e/rtllib_softmac.c:955:24: warning: incorrect type in assignment (different base types) drivers/staging/rtl8192e/rtllib_softmac.c:955:24: expected unsigned short [unsigned] [usertype] val16 drivers/staging/rtl8192e/rtllib_softmac.c:955:24: got restricted __le16 [usertype] <noident> drivers/staging/rtl8192e/rtllib_softmac.c:1263:33: warning: incorrect type in assignment (different base types) drivers/staging/rtl8192e/rtllib_softmac.c:1263:33: expected restricted __le16 [usertype] duration_id drivers/staging/rtl8192e/rtllib_softmac.c:1263:33: got int drivers/staging/rtl8192e/rtllib_softmac.c:1282:30: warning: incorrect type in assignment (different base types) drivers/staging/rtl8192e/rtllib_softmac.c:1282:30: expected restricted __le16 [usertype] listen_interval drivers/staging/rtl8192e/rtllib_softmac.c:1282:30: got unsigned short [unsigned] [usertype] listen_interval Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com> Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
7fe30a7d |
|
07-Nov-2013 |
Rashika Kheria <rashika.kheria@gmail.com> |
Staging: rtl8192e: Fix Sparse Warning of invalid assignment '|=' in rtllib_softmac.c This patch fixes the following Sparse warning in rtllib_softmac.c- drivers/staging/rtl8192e/rtllib_softmac.c:812:40: warning: invalid assignment: |= drivers/staging/rtl8192e/rtllib_softmac.c:812:40: left side has type restricted __le16 drivers/staging/rtl8192e/rtllib_softmac.c:812:40: right side has type int drivers/staging/rtl8192e/rtllib_softmac.c:924:17: warning: invalid assignment: |= drivers/staging/rtl8192e/rtllib_softmac.c:924:17: left side has type restricted __le16 drivers/staging/rtl8192e/rtllib_softmac.c:924:17: right side has type int drivers/staging/rtl8192e/rtllib_softmac.c:924:17: error: cast from unknown type Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com> Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
f7df1918 |
|
07-Nov-2013 |
Rashika Kheria <rashika.kheria@gmail.com> |
Staging: rtl8192e: Fix Sparse warning of restricted __le16 degrades to integer in rtllib_softmac.c This patch fixes the following Sparse warning in rtllib_softmac.c- drivers/staging/rtl8192e/rtllib_softmac.c:230:19: warning: restricted __le16 degrades to integer Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com> Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
014e4c27 |
|
29-Oct-2013 |
Valentina Manea <valentina.manea.m@gmail.com> |
staging: rtl8192e: use true and false for bool variables This patch fixes coccinelle errors for bool variables initialized with 1 or 0 instead of true and false. Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
21624981 |
|
26-Oct-2013 |
Teodora Baluta <teobaluta@gmail.com> |
staging: rtl8192e: use memdup_user to simplify code Use memdup_user rather than duplicating its implementation. This patch fixes the following coccinelle warnings: drivers/staging/rtl8192e/rtl8192e/rtl_core.c:2598:8-15: WARNING opportunity for memdup_user drivers/staging/rtl8192e/rtllib_softmac.c:3594:9-16: WARNING opportunity for memdup_user Signed-off-by: Teodora Baluta <teobaluta@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
4bb01423 |
|
25-Oct-2013 |
Valentina Manea <valentina.manea.m@gmail.com> |
staging: rtl8192e: do not use comparisons on bool tests This patch fixes coccinelle errors regarding comparisons used in bool tests. Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com> Reviewed-by: Lisa Nguyen <lisa@xenapiadmin.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
559a4c31 |
|
26-Aug-2013 |
Andrea Merello <andrea.merello@gmail.com> |
staging: Update e-mail address for Andrea Merello A lot of files contain reference to my old e-mail address. Now I'm going not to read mail from it anymore, so update it with my current address everywhere. Signed-off-by: Andrea Merello <andrea.merello@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
93ba2a85 |
|
26-Aug-2013 |
Andrea Merello <andrea.merello@gmail.com> |
Update e-mail address for Andrea Merello (resubmit) A lot of files contain reference to my old e-mail address. Now I'm going not to read mail from it anymore, so update it with my current address everywhere. Signed-off-by: Andrea Merello <andrea.merello@gmail.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
|
#
6dea0da1 |
|
14-May-2013 |
Hema Prathaban <hemaklnce@gmail.com> |
staging: rtl8192e: Use kmemdup for duplicating memory Instead of allocating memory (kmalloc) and copying (memcpy) from source, memory can be duplicated using kmemdup Signed-off-by: Hema Prathaban <hemaklnce@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
ae053253 |
|
14-May-2013 |
Hema Prathaban <hemaklnce@gmail.com> |
staging: rtl8192e: Fix potential null dereference check memory is allocated in '*challenge' before using it. Signed-off-by: Hema Prathaban <hemaklnce@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
f2635894 |
|
19-Sep-2012 |
Adam Buchbinder <adam.buchbinder@gmail.com> |
staging: Fix misspellings of "whether". "Whether" is spelled "wether" in several places. This fixes those that are in the staging tree. Signed-off-by: Adam Buchbinder <adam.buchbinder@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
71cd7913 |
|
21-Aug-2012 |
Wei Yongjun <yongjun_wei@trendmicro.com.cn> |
staging: rtl8192e: using random_ether_addr() to generate random MAC Using random_ether_addr() to generate a random Ethernet address (MAC) that is not multicast and has the local assigned bit set. Not need to duplicating its implementation. spatch with a semantic match is used to found this problem. (http://coccinelle.lip6.fr/) Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
b4797fef |
|
04-Sep-2012 |
Devendra Naga <devendra.aaru@gmail.com> |
staging: rtl8192e: remove casting of returned pointer from kmalloc as per Documentation/CodingStyle we dont need to cast the return of kmalloc Signed-off-by: Devendra Naga <devendra.aaru@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
0c43e56c |
|
25-Aug-2012 |
Wei Yongjun <yongjun_wei@trendmicro.com.cn> |
staging: rtl8192e: use is_broadcast_ether_addr() instead of memcmp() Using is_broadcast_ether_addr() instead of directly use memcmp() to determine if the ethernet address is broadcast address. spatch with a semantic match is used to found this problem. (http://coccinelle.lip6.fr/) Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
db2c8da0 |
|
09-Aug-2012 |
Masanari Iida <standby24x7@gmail.com> |
staging: rtl8192e: Fix typo in staging/rtl8192e Correct spelling typo in staging/rtl8192e. Signed-off-by: Masanari Iida <standby24x7@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
cd017123 |
|
23-Apr-2012 |
Justin P. Mattock <justinmattock@gmail.com> |
staging: rtl8192e: Fix typos. Signed-off-by: Justin P. Mattock <justinmattock@gmail.com> ACKed-by: Larry Finger <Larry.finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
ea9f10f2 |
|
20-Apr-2012 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: r8192e_pci: Change memcpy to memcmp Routine rtllib_MlmeDisassociateRequest() has a comparison of memcpy() with NULL, which makes no sense. Analysis of the code suggests that memcmp() was intended. Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
33750343 |
|
12-Feb-2012 |
Jesper Juhl <jj@chaosbits.net> |
Staging, rtl8192e, softmac: remove redundant memset and fix mem leak In drivers/staging/rtl8192e/rtllib_softmac.c::rtllib_rx_assoc_resp() we allocate memory for 'network' with kzalloc() and then proceed to zero the already zeroed mem we got from kzalloc() with memset(). That's redundant, so remove the memset() We also fail to kfree() the memory we allocated for 'network' if we do not enter if (ieee->current_network.qos_data.supported == 1) { and the variable then goes out of scope. To fix that I simply moved the kfree() that was inside that 'if' statement to instead be just after it. It then covers both the case where we take the branch and when we don't. Signed-off-by: Jesper Juhl <jj@chaosbits.net> Acked-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
3b148be0 |
|
19-Dec-2011 |
Sean MacLennan <seanm@seanm.ca> |
staging/rtl8192e: Register against lib80211 Convert rtllib from registering the crypt drivers against rtllib_crypt and instead register the against lib80211. The crypto functions have R- prepended (R-CCMP, R-TKIP, R-WEP) so they will not clash with the lib80211 versions. We cannot use the lib80211 crypt drivers since the rtl8192e has some hardware support that is not handled by the lib80211 crypt drivers. Signed-off-by: Sean MacLennan <seanm@seanm.ca> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
0ddcf5fd |
|
19-Dec-2011 |
Sean MacLennan <seanm@seanm.ca> |
staging/rtl8192e: Convert to lib80211_crypt_info Convert rtllib to use lib80211_crypt_info. Signed-off-by: Sean MacLennan <seanm@seanm.ca> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
32c44cb5 |
|
19-Dec-2011 |
Sean MacLennan <seanm@seanm.ca> |
staging/rtl8192e: Convert to lib80211_crypt_data and lib80211_crypt_ops Convert rtllib_crypt_data to lib80211_crypt_data and rtllib_crypt_ops to lib80211_crypt_ops. This is almost a 1:1 replacement, only extra_prefix_len and extra_postfix_len changed. Signed-off-by: Sean MacLennan <seanm@seanm.ca> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
184f1938 |
|
19-Dec-2011 |
Sean MacLennan <seanm@seanm.ca> |
staging/rtl8192e: Add lib80211.h to rtllib.h Add lib80211.h header file to rtllib.h and get it compiling. Signed-off-by: Sean MacLennan <seanm@seanm.ca> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
e0ec8a67 |
|
12-Dec-2011 |
Devendra Naga <devendra.aaru@gmail.com> |
staging: remove version.h includes in rtl8192e Signed-off-by: Devendra Naga <devendra.aaru@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
3b28499c |
|
28-Nov-2011 |
Sean MacLennan <seanm@seanm.ca> |
rtl8192e: Export symbols The rtl8192e driver had a natural split between the more generic rtllib code and the more specific rtl8192e code. This patch exports all the symbols needed by the r8192 specific code from the rtllib generic code. Signed-off-by: Sean MacLennan <seanm@seanm.ca> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
ea74fedc |
|
28-Nov-2011 |
Sean MacLennan <seanm@seanm.ca> |
rtl8192e: create generic rtllib_debug.h Rename rtl_debug.h to rtllib_debug.h. Source files should include rtllib.h if they are generic and rtl_core.h if they are r8192e specific. Files should never include both. Signed-off-by: Sean MacLennan <seanm@seanm.ca> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
d9317533 |
|
08-Nov-2011 |
Thomas Meyer <thomas@m3y3r.de> |
staging: rtl8192e: Use kmemdup rather than duplicating its implementation Use kmemdup rather than duplicating its implementation The semantic patch that makes this change is available in scripts/coccinelle/api/memdup.cocci. More information about semantic patching is available at http://coccinelle.lip6.fr/ Signed-off-by: Thomas Meyer <thomas@m3y3r.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
929fa2a4 |
|
10-Nov-2011 |
Thomas Meyer <thomas@m3y3r.de> |
staging: rtl8192e: Use kzalloc rather than kmalloc v2 Use kzalloc rather than kmalloc followed by memset with 0 This considers some simple cases that are common and easy to validate Note in particular that there are no ...s in the rule, so all of the matched code has to be contiguous The semantic patch that makes this change is available in scripts/coccinelle/api/alloc/kzalloc-simple.cocci. Signed-off-by: Thomas Meyer <thomas@m3y3r.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
6f03053b |
|
06-Nov-2011 |
Jesper Juhl <jj@chaosbits.net> |
rtl8192e: Don't copy huge struct by value (and make it const). rtllib_is_shortslot() takes one argument - a struct that's more than a kilobyte large. It should take a pointer instead of copying such a huge struct - and the argument might as well be declared 'const' now that we are at it, since it is not modified. This patch makes these changes. Signed-off-by: Jesper Juhl <jj@chaosbits.net> Acked-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
d7613e53 |
|
31-Aug-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Fix various problems noted by smatch Smatch reports the following problems: CHECK drivers/staging/rtl8192e/rtllib_softmac.c drivers/staging/rtl8192e/rtllib_softmac.c +3143 rtllib_softmac_free(4) info: redundant null check on ieee->pDot11dInfo calling kfree() CHECK drivers/staging/rtl8192e/rtllib_module.c drivers/staging/rtl8192e/rtllib_module.c +198 free_rtllib(6) info: redundant null check on ieee->pHTInfo calling kfree() CHECK drivers/staging/rtl8192e/rtl819x_TSProc.c drivers/staging/rtl8192e/rtl819x_TSProc.c +280 SearchAdmitTRStream(52) error: potential null derefence 'pRet'. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
ec0dc6be |
|
25-Aug-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Fix sparse (non-endian) messages - Part I Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
ac50ddaa |
|
25-Aug-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Remove MAC_FMT and MAC_ARG for %pM Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
966aeb32 |
|
12-Aug-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Fix sparse (non-endian) messages - Part I Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
|
#
438812c3 |
|
11-Aug-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Remove MAC_FMT and MAC_ARG for %pM Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
|
#
9d92ece80 |
|
25-Aug-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Cleanup checkpatch -f errors - Part XIV With this patch, all of the checkpatch errors are fixed; however, only some of the lines that are too long were fixed. To complete the fixing of these warnings, the file rtllib_softmac.c will need refactoring. In addition, some of the variables may need renaming. Those changes can be deferred. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
0dd56506 |
|
25-Aug-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Modify time handling In several places, the driver keeps times (in jiffies) in two 32-bit quantities. In the rtl8192_hw_to_sleep(), there is an error in the calculation of the difference between two 64-bit quantities. Rather than fix that error, I have converted to a single 64-bit number. That makes the code be much cleaner and clearer. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
3927ee36 |
|
09-Aug-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Cleanup checkpatch -f errors - Part XIV With this patch, all of the checkpatch errors are fixed; however, only some of the lines that are too long were fixed. To complete the fixing of these warnings, the file rtllib_softmac.c will need refactoring. In addition, some of the variables may need renaming. Those changes can be deferred. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
|
#
e829d65e |
|
01-Aug-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Modify time handling In several places, the driver keeps times (in jiffies) in two 32-bit quantities. In the rtl8192_hw_to_sleep(), there is an error in the calculation of the difference between two 64-bit quantities. Rather than fix that error, I have converted to a single 64-bit number. That makes the code be much cleaner and clearer. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
|
#
3b83db43 |
|
18-Jul-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Convert typedef cb_desc to struct cb_desc Remove typedef from struct. Rename struct. Rename uses. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
|
#
ca990011 |
|
18-Jul-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Convert typedef RT_POWER_SAVE_CONTROL to struct rt_pwr_save_ctrl Remove typedef from struct. Rename struct. Rename uses. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
|
#
8310b6c0 |
|
18-Jul-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Convert typedef OCTET_STRING to struct octet_string Remove typedef from struct. Rename struct. Rename uses. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
|
#
7796d93e |
|
18-Jul-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Convert typedef RT_HIGH_THROUGHPUT to struct rt_hi_throughput Remove typedef from struct. Rename struct. Rename uses. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
|
#
ce403a6a |
|
14-Jul-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Remove dead code associated with CUSTOMER_ID_INTEL_CMPC and CONFIG_CRDA Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
|
#
d32ddcba |
|
14-Jul-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Remove dead code associated with FOR_ANDROID_X86 and FOR_MOBLIN Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
|
#
07f43233 |
|
13-Jul-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Remove dead code associated with ADHOC_11N Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
|
#
f1c22567 |
|
13-Jul-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Remove dead code associated with WIFI_TEST Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
|
#
6e2c538f |
|
13-Jul-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Remove dead code associated with RTK_DMP_PLATFORM Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
|
#
02525969 |
|
13-Jul-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Remove dead code associated with SUPPORT_USPD Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
|
#
bf474281 |
|
13-Jul-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Remove dead code associated with USB_TX_DRIVER_AGGREGATION_ENABLE Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
|
#
2b259bd3 |
|
13-Jul-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Remove ifdefs that depend on ENABLE_DOT11D This configuration parameter is selected in the Makefile, thus the conditional code can be removed. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
|
#
e755463c |
|
12-Jul-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Remove dead code from removal of ENABLE_TKIP11N Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
|
#
0e3b1830 |
|
12-Jul-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Remove dead code associated with PF_SYNCTHREAD Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
|
#
4ebba6d6 |
|
12-Jul-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Remove dead code associated with COMPATIBLE_WITH_RALINK_MESH Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
|
#
a97dc3af |
|
12-Jul-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Remove dead code associated with USB_USE_ALIGNMENT Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
|
#
d064307a |
|
12-Jul-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Remove dead code involved with TO_DO Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
|
#
15e7650e |
|
12-Jul-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Remove dead code involved with TO_DO_LIST Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
|
#
1e71e6d0 |
|
11-Jul-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Remove dead code associated with RTL8192SE The vendor code will generate several different drivers. As the RTL8192SE is covered by a mac80211 driver in mainline, eliminate that code heere. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
|
#
175159c5 |
|
11-Jul-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
staging: rtl8192e: Remove code dependent on RTL8190P The vendor code can conditionally generate drivers for a number of devices. Remove any code that depends on RTL8190P being set. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
|
#
4f6807e8 |
|
10-Jul-2011 |
Mike McCormack <mikem@ring3k.org> |
rtl8192e: Remove occurences of #if 1 Signed-off-by: Mike McCormack <mikem@ring3k.org>
|
#
cb762154 |
|
10-Jul-2011 |
Mike McCormack <mikem@ring3k.org> |
rtl8192e: Remove extra ifdefs Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Mike McCormack <mikem@ring3k.org>
|
#
94a79942 |
|
23-Aug-2011 |
Larry Finger <Larry.Finger@lwfinger.net> |
From: wlanfae <wlanfae@realtek.com> [PATCH 1/8] rtl8192e: Import new version of driver from realtek Signed-off-by: wlanfae <wlanfae@realtek.com> Signed-off-by: Mike McCormack <mikem@ring3k.org> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> ---
|