system/boot: Begin factoring gFDT out of non-u-boot code

Change-Id: Ibe010c6c7ed71a20fc852ce6c72c6f32b98dfad2
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2292
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>

system/u-boot: Some 64-bit cleanups to our u-boot code

Change-Id: I70c50b36cd56263dcb37faeffc4037dea4af88c0
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2171
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>

bcm2835: Move mailbox init into bcm2835 framebuffer

We won't need the mailbox for most chipsets except bcm2835
to determine the framebuffer base address.
(especially at this early boot stage)

This simplifies things by making the mailbox usage limited
to boot_arch_arm and not spreading it all thoughout the
platform u-boot code... however we keep the mailbox driver
as-is since it would make a good kernel driver someday.

mmu_man mentioned us "finding" the fb base from the mailbox
and modifying the FDT to let it know the base reg of the
framebuffer... that's beyond 'just getting things building'
though :-)

Change-Id: Ic2772b85dff004f9d21447ea5958b5ae9776d526

u-boot: Drop openfirmware in u-boot platform hack

* If we need this, we can do builds with openfirmware
platform on u-boot loader now.

Change-Id: I67b5bda165a78b772e246c008c5018b2d6f459e9

arch: Cleanup of __ARM__ checks

* gcc 7.x defines __arm__ and __ARM__ (and others)
* clang defines __arm__ and __arm
* cleanup a few related ifdef vs if macros

Change-Id: I5da4bafac590f6fa3e10e543688001c2449f840d

u-boot/arm: Initial steps to drop target board requirements

U-Boot: PPC: dump the start of the board_data struct

Not so useful but just in case...

Sadly, this struct is both compile-time and arch dependent :-(

arm/mailbox: Load mailbox base from FDT in loader

loader/u-boot: Use FDT serial info to create uart

* drop my fdt tests
* we have to call fdt parsing code *after* cpu_init (why?)
* pass fdt pointer to all FDT support calls to avoid confusion
once we get into the kernel land
* look for PL011 compatible uart and use it
* Add some saftey checks to serial putc code to avoid null*
* fdt_node_check_compatible returns 0 on success not 1
* fdt_get_device_reg needs to add the SOC base to the result
* fdt_get_device_reg might need to add the second range cell
instead of reg?

arm/fdt: Initial reorg of fdt support code

* Makes FDT support code useable by everyone
without all of the externs
* Further movement to be non-u-boot centic
may still happen.

platform/u-boot: Work towards using arm mailbox driver

* Reference bcm2708 framebuffer when it makes sense
* Add bcm2708 define to Raspberry Pi board_config.h

U-Boot: always initialize args.arguments_count

U-Boot: delay checking /chosen:bootargs after remapping FDT

This avoids having to copy the strings.
For now we disregard argv[] as it is not remapped before
being used in add_stage2_driver_settings() and is not used
by the linux entry point.

This makes the overo loader panic at the same place as
the beagle xm one now, even though it fails to display
anything with the default RAM size since we allocate
the framebuffer beyond 128MB...

ARM: Check for RAM size in FDT

We skip the check when we already have ranges inserted,
like from the raspberry Pi start code, and we fall back to
32MB at SDRAM_BASE is not found.

U-Boot: move gUImage and gFDT back to BSS section

No need for this trick anymore.

U-Boot: introduce a start_gen() catch-all entry

So we can pass it all the optional stuff instead of playing tricks
to initialize them outside of BSS.

ARM: u-boot: fixup FDT handling

If we find an FDT (either from uImage or otherwise) we make sure
we map it after mmu_init() and use kernel_args to pass it to the
kernel (so it is available at all times there).

ARM: cleanup of bootloader memory mapping

* Removes default mapping of a portion of the RAM (will be done
as needed)
* Passes on the page directory area to kernel, so on early vm init
the kernel can use the area for pagetable allocation.
* Leaves it to the platform to pass in physical memory range(s). This
will ultimately come from FDT.
* Fix long standing issue with allocation of the heap, potentially
causing other part of the bootloader to overwrite the heap.
* Implements pagetable allocator in kernel for early vm mapping.

This fixes the first PANIC seen, we now just get the same one later
on when the VM is up... more to come...

ARM: remove initrd handling from mmu code

Let the platform mmu_map_physical_memory the initrd region, and
reserve it before calling mmu_init. This removes another hardcoded
address, since e.g. U-Boot gets the address from the uImage file.

ARM: define bootloader stack in linker script

This removes the need for the whole HAIKU_BOARD_LOADER_STACK_BASE
sing and dance, since it is always included in the bootloader binary
itself.

ARM: abort() is already pulled in using kernel_util.o

It was just here to make libgcc happy.

Corrected check to ensure that command line options are indeed passed.

* Currently, no command line options are being passed via u-boot
to haiku. However, the comparison doesn't ensure that cmdline
is not an empty string - it merely ensures cmdline is not null.

Signed-off-by: Ithamar R. Adema <ithamar@upgrade-android.com>

Style fixes

U-Boot: pass around argv and /chosen/bootargs

Not really handled correctly yet, but at least they are passed.

U-Boot: pass a copy of the FDT to the kernel

U-Boot: move of_init() call before cpu_init()

So we can use the OF wrapper there as well and copy code verbatim from
the OF platform.

U-Boot: fix warnings

ARM/u-boot: Add support for FDTs passed in the uImage

Since we're using multi-part uImage format, we can add the FDT as
a seperate "blob" in the uImage, if the used U-Boot version is not
"FDT enabled".

This is used for example for our Verdex target. Currently I've got
a local hack in the platform/u-boot/Jamfile, looking into pulling
in the FDT files and a proper Jam setup to do that properly...

U-Boot: implement part of the OpenFirmware wrapper

We'll see later on if it's really useful to keep it around.

U-Boot: check for /chosen in the FDT for an initrd holding our tgz

* since the FDT linux boot method doesn't pass the uimage, we can't
use it to pass the kernel+driver tgz in a multi-file uimage.
* instead we check for the linux initrd properties in the /chosen node.

(cherry picked from my sam460ex branch)

U-Boot: initialize the debug UART using FDT hints when possible

* we first try to find 'serial', 'serial0' or 'serial1' in /aliases
* extract the required properties from the found node and use them
* fallback to the hardcoded UART from the board definition header

(cherry picked from my sam460ex branch)

U-Boot: dump the passed FDT

* add some helpers for Flattened Device Trees, for now a dump call
* dump the passed FDT on startup for now

Conflicts:
src/system/boot/platform/u-boot/Jamfile

(cherry picked from my sam460ex branch)

U-Boot: check for /chosen in the FDT for an initrd holding our tgz

* since the FDT linux boot method doesn't pass the uimage, we can't
use it to pass the kernel+driver tgz in a multi-file uimage.
* instead we check for the linux initrd properties in the /chosen node.

U-Boot: initialize the debug UART using FDT hints when possible

* we first try to find 'serial', 'serial0' or 'serial1' in /aliases
* extract the required properties from the found node and use them
* fallback to the hardcoded UART from the board definition header

U-Boot: dump the passed FDT

* add some helpers for Flattened Device Trees, for now a dump call
* dump the passed FDT on startup for now

Fixes for other platforms.

Support static_cast on FixedWidthPointer.

Added an ELF64 version of preloaded_image.

* There is now 2 structures, preloaded_elf32_image and preloaded_elf64_image,
which both inherit from preloaded_image.
* For now I've just hardcoded in use of preloaded_elf32_image, but the
bootloader ELF code will shortly be converted to use templates which use
the appropriate structure. The kernel will be changed later when I add
ELF64 support to it.
* All kernel_args data is now compatible between 32-bit and 64-bit kernels.

U-Boot: move gFDT declaration to shell.S

* this avoids it falling into the BSS section which we clear quite late,
and allows setting it from asm code if needed.

U-Boot: save passed FDT and call common code

* should work better this way :D

Cleanup U-Boot global data struct

* there are only a few members we can really rely on, the rest is compile-time dependant.
* don't use ARM-specific stuff.

Drop ARM-specific register pointer

* the global data is already stored in a variable from shell.S anyway when available

Add empty C linux-style entry points

* On PPC, there are two different kernel entry signatures for Linux

Rename u-boot start2.cpp to start.cpp

* rename the file for consistency with other platforms.
* there used to be a start.S, long since renamed to shell.S anyway.

arm/mailbox: Load mailbox base from FDT in loader

loader/u-boot: Use FDT serial info to create uart

* drop my fdt tests
* we have to call fdt parsing code *after* cpu_init (why?)
* pass fdt pointer to all FDT support calls to avoid confusion
once we get into the kernel land
* look for PL011 compatible uart and use it
* Add some saftey checks to serial putc code to avoid null*
* fdt_node_check_compatible returns 0 on success not 1
* fdt_get_device_reg needs to add the SOC base to the result
* fdt_get_device_reg might need to add the second range cell
instead of reg?

arm/fdt: Initial reorg of fdt support code

* Makes FDT support code useable by everyone
without all of the externs
* Further movement to be non-u-boot centic
may still happen.

platform/u-boot: Work towards using arm mailbox driver

* Reference bcm2708 framebuffer when it makes sense
* Add bcm2708 define to Raspberry Pi board_config.h

U-Boot: always initialize args.arguments_count

U-Boot: delay checking /chosen:bootargs after remapping FDT

This avoids having to copy the strings.
For now we disregard argv[] as it is not remapped before
being used in add_stage2_driver_settings() and is not used
by the linux entry point.

This makes the overo loader panic at the same place as
the beagle xm one now, even though it fails to display
anything with the default RAM size since we allocate
the framebuffer beyond 128MB...

ARM: Check for RAM size in FDT

We skip the check when we already have ranges inserted,
like from the raspberry Pi start code, and we fall back to
32MB at SDRAM_BASE is not found.

U-Boot: move gUImage and gFDT back to BSS section

No need for this trick anymore.

U-Boot: introduce a start_gen() catch-all entry

So we can pass it all the optional stuff instead of playing tricks
to initialize them outside of BSS.

ARM: u-boot: fixup FDT handling

If we find an FDT (either from uImage or otherwise) we make sure
we map it after mmu_init() and use kernel_args to pass it to the
kernel (so it is available at all times there).

ARM: cleanup of bootloader memory mapping

* Removes default mapping of a portion of the RAM (will be done
as needed)
* Passes on the page directory area to kernel, so on early vm init
the kernel can use the area for pagetable allocation.
* Leaves it to the platform to pass in physical memory range(s). This
will ultimately come from FDT.
* Fix long standing issue with allocation of the heap, potentially
causing other part of the bootloader to overwrite the heap.
* Implements pagetable allocator in kernel for early vm mapping.

This fixes the first PANIC seen, we now just get the same one later
on when the VM is up... more to come...

ARM: remove initrd handling from mmu code

Let the platform mmu_map_physical_memory the initrd region, and
reserve it before calling mmu_init. This removes another hardcoded
address, since e.g. U-Boot gets the address from the uImage file.

ARM: define bootloader stack in linker script

This removes the need for the whole HAIKU_BOARD_LOADER_STACK_BASE
sing and dance, since it is always included in the bootloader binary
itself.

ARM: abort() is already pulled in using kernel_util.o

It was just here to make libgcc happy.

Corrected check to ensure that command line options are indeed passed.

* Currently, no command line options are being passed via u-boot
to haiku. However, the comparison doesn't ensure that cmdline
is not an empty string - it merely ensures cmdline is not null.

Signed-off-by: Ithamar R. Adema <ithamar@upgrade-android.com>

Style fixes

U-Boot: pass around argv and /chosen/bootargs

Not really handled correctly yet, but at least they are passed.

U-Boot: pass a copy of the FDT to the kernel

U-Boot: move of_init() call before cpu_init()

So we can use the OF wrapper there as well and copy code verbatim from
the OF platform.

U-Boot: fix warnings

ARM/u-boot: Add support for FDTs passed in the uImage

Since we're using multi-part uImage format, we can add the FDT as
a seperate "blob" in the uImage, if the used U-Boot version is not
"FDT enabled".

This is used for example for our Verdex target. Currently I've got
a local hack in the platform/u-boot/Jamfile, looking into pulling
in the FDT files and a proper Jam setup to do that properly...

U-Boot: implement part of the OpenFirmware wrapper

We'll see later on if it's really useful to keep it around.

U-Boot: check for /chosen in the FDT for an initrd holding our tgz

* since the FDT linux boot method doesn't pass the uimage, we can't
use it to pass the kernel+driver tgz in a multi-file uimage.
* instead we check for the linux initrd properties in the /chosen node.

(cherry picked from my sam460ex branch)

U-Boot: initialize the debug UART using FDT hints when possible

* we first try to find 'serial', 'serial0' or 'serial1' in /aliases
* extract the required properties from the found node and use them
* fallback to the hardcoded UART from the board definition header

(cherry picked from my sam460ex branch)

U-Boot: dump the passed FDT

* add some helpers for Flattened Device Trees, for now a dump call
* dump the passed FDT on startup for now

Conflicts:
src/system/boot/platform/u-boot/Jamfile

(cherry picked from my sam460ex branch)

U-Boot: check for /chosen in the FDT for an initrd holding our tgz

* since the FDT linux boot method doesn't pass the uimage, we can't
use it to pass the kernel+driver tgz in a multi-file uimage.
* instead we check for the linux initrd properties in the /chosen node.

U-Boot: initialize the debug UART using FDT hints when possible

* we first try to find 'serial', 'serial0' or 'serial1' in /aliases
* extract the required properties from the found node and use them
* fallback to the hardcoded UART from the board definition header

U-Boot: dump the passed FDT

* add some helpers for Flattened Device Trees, for now a dump call
* dump the passed FDT on startup for now

Fixes for other platforms.

Support static_cast on FixedWidthPointer.

Added an ELF64 version of preloaded_image.

* There is now 2 structures, preloaded_elf32_image and preloaded_elf64_image,
which both inherit from preloaded_image.
* For now I've just hardcoded in use of preloaded_elf32_image, but the
bootloader ELF code will shortly be converted to use templates which use
the appropriate structure. The kernel will be changed later when I add
ELF64 support to it.
* All kernel_args data is now compatible between 32-bit and 64-bit kernels.

U-Boot: move gFDT declaration to shell.S

* this avoids it falling into the BSS section which we clear quite late,
and allows setting it from asm code if needed.

U-Boot: save passed FDT and call common code

* should work better this way :D

Cleanup U-Boot global data struct

* there are only a few members we can really rely on, the rest is compile-time dependant.
* don't use ARM-specific stuff.

Drop ARM-specific register pointer

* the global data is already stored in a variable from shell.S anyway when available

Add empty C linux-style entry points

* On PPC, there are two different kernel entry signatures for Linux

Rename u-boot start2.cpp to start.cpp

* rename the file for consistency with other platforms.
* there used to be a start.S, long since renamed to shell.S anyway.