History log of /haiku/src/servers/app/drawing/BitmapDrawingEngine.cpp
Revision Date Author Comments
# 779ab335 09-Dec-2020 X512 <danger_mail@list.ru>

use .IsSet() instead if .Get() != NULL

Change-Id: Ia2b7a719fd398e78cc3b11d4f7b02cb81179f65f
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3488
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>


# 60d30785 27-Aug-2020 X512 <danger_mail@list.ru>

app_server memory management fixes: use BReference

Use BReference for more automated reference counting in app_server,
fixing some use-after-free and other problems.

Extracted from https://review.haiku-os.org/c/haiku/+/2695

Change-Id: I141bb248229405896b29feff3338447f7257b0b4
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3175
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>


# f6099728 23-Jan-2015 Rene Gollent <rene@gollent.com>

Fix #11775.

BitmapDrawingEngine:
- Check if fBitmap is NULL before releasing its reference. Since this is
the case when a BitmapDrawingEngine is instantiated, this would lead to
an app_server crash upon any attempt to make use of one.


# 0e652ab2 23-Jan-2015 Adrien Destugues <pulkomandy@gmail.com>

Forgot to reset fBitmap to NULL.

Thanks to Rene for reviewing.


# 8bcd6904 23-Jan-2015 Adrien Destugues <pulkomandy@gmail.com>

Call ReleaseReference when a BReference is not needed

Reduces complexity and is actualñly more readable.


# 6f3acb91 23-Jan-2015 Adrien Destugues <pulkomandy@gmail.com>

app_server: fix misuse of BReferenceable.

Fixes #9989.


# d02b8b81 08-Feb-2014 Stephan Aßmus <superstippi@gmx.de>

app_server: Cleanup of some file locations


# f6099728e419f4782cee75cc216178aa52be9492 23-Jan-2015 Rene Gollent <rene@gollent.com>

Fix #11775.

BitmapDrawingEngine:
- Check if fBitmap is NULL before releasing its reference. Since this is
the case when a BitmapDrawingEngine is instantiated, this would lead to
an app_server crash upon any attempt to make use of one.


# 0e652ab2dc2bdb9bb84094ef8cd7d0fc05037a64 23-Jan-2015 Adrien Destugues <pulkomandy@gmail.com>

Forgot to reset fBitmap to NULL.

Thanks to Rene for reviewing.


# 8bcd69044c366974d40f1cd22577679cd7b991db 23-Jan-2015 Adrien Destugues <pulkomandy@gmail.com>

Call ReleaseReference when a BReference is not needed

Reduces complexity and is actualñly more readable.


# 6f3acb91631d60911121f71ebd92b15d5f08b63b 23-Jan-2015 Adrien Destugues <pulkomandy@gmail.com>

app_server: fix misuse of BReferenceable.

Fixes #9989.


# d02b8b81e884bd0090ef9bd2d7a62af673eca354 08-Feb-2014 Stephan Aßmus <superstippi@gmx.de>

app_server: Cleanup of some file locations