History log of /haiku/src/servers/app/decorator/TabDecorator.cpp
Revision Date Author Comments
# 9d80098e 12-Jul-2022 Augustin Cavalier <waddlesplash@gmail.com>

app_server: Add casts to appease GCC2.


# 112fc353 12-Jul-2022 Augustin Cavalier <waddlesplash@gmail.com>

app_server: Basic scaling for window borders.

This code is quite convoluted and very much in need of refactoring,
but this solution works well enough for the time being. It does not
look quite right at higher resolutions (borders come out darker than
they do at the default resolution), but at least the borders are now
the correct size instead of a constant one.

The resize nub drawing code also hasn't yet been updated, so while
it draws the gradient over the full resize area and responds to clicks,
the "checkerboard" pattern is drawn at a fixed small size still.

Nonetheless, this is a significant improvement.


# 773d5303 19-Jul-2018 Tri-Edge AI <triedgeai@gmail.com>

app_server: Implement B_OUTLINE_RESIZE

- Allows applications to be resized without the window contents resizing with the window frame.
- Due to the nature of out-of-tree decorators using private APIs, this will require all pre-existing decorators to be rebuilt
- Newer decorators won't work on older versions of Haiku...
- Also has some formatting with license headers.
- Fixes #2724

Change-Id: Id0b45e7bbc0b636e6dffbd396eb584bf348b5296
Reviewed-on: https://review.haiku-os.org/c/haiku/+/344
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
Reviewed-by: Jacob Secunda <secundaja@gmail.com>


# 83bd4fda 11-May-2020 X512 <danger_mail@list.ru>

app_server: fix stack overflow crash if too many windows are tiled

Fixes #15796.

Change-Id: I24c29215116e6bad37f0a56e141d6fc26bbe4fb2
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2680
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>


# 7362b02b 08-May-2020 Adrien Destugues <pulkomandy@pulkomandy.tk>

TabDecorator: fix invalidation when removing a tab.

Fixes #12085.

Change-Id: I346e39ba4dc6befe97f33f8ff409a6ac84ae8585
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2609
Reviewed-by: waddlesplash <waddlesplash@gmail.com>


# 22e3e14a 29-Dec-2016 Murai Takashi <tmurai01@gmail.com>

TabDecorator.cpp: fix dereference of null pointer

Signed-off-by: Adrien Destugues <pulkomandy@pulkomandy.tk>

fixes #13137


# 7f9368ca 09-Dec-2015 looncraz <looncraz@looncraz.net>

Set*UIColor, etc.

The inseparable changes necessary to support live color updating across the
system in a sane, safe, and performant manner.

BView gains:

HasSystemColors()
HasDefaultColors()
AdoptSystemColors()
AdoptParentColors()
AdoptViewColor(BView*)
SetViewUIColor(color_which, float tint)
SetHighUIColor(...
SetLowUIColor(...
ViewUIColor(float* tint)
HighUIColor(...
LowUIColor(...
DelayedInvalidate()

BWindow gains a simple helper method:
IsOffscreenWindow()

BMessage gains:

AddColor()
FindColor()
GetColor()
HasColor() * allegedly this API is deprecated, but I implemented it anyway
ReplaceColor()
SetColor()

Previous private ColorTools methods are made public and moved into GraphicsDefs:

mix_color, blend_color, disable_color

These are fully compatible with BeOS dan0 R5.1 methods and are just code cleanup
of BeOS example code under the OpenTracker license.

In addition, four new colors are created:
B_LINK_TEXT_COLOR
B_LINK_HOVER_COLOR
B_LINK_ACTIVE_COLOR
B_LINK_VISITED_COLOR

These changes are documented in their proper user documentation files.

In addition, due to a history rewrite, B_FOLLOW_LEFT_TOP has been defined and
used in lieu of B_FOLLOW_TOP | B_FOLLOW_LEFT and is included in this commit.

On the app_server side, the following has changed:

Add DelayedMessage - a system by which messages can be sent at a scheduled time,
and can also be merged according to set rules. A single thread is used to service the
message queue and multiple recipients can be set for each message.
Desktop gains the ability to add message ports to a DelayedMessage so that
said messages can target either all applications or all windows, as needed.

Desktop maintains a BMessage which is used to queue up all pending color changes
and the delayed messaging system is used to enact these changes after a short
period of time has passed. This prevents abuse and allows the system to merge
repeated set_ui_color events into one event for client applications, improving
performance drastically.

In addition, B_COLORS_UPDATED is sent to the BApplication, which forwards the message
to each BWindow. This is done to improve performance over having the app_server
independently informing each window.

Decorator changes are live now, which required some reworking.

Signed-off-by: Augustin Cavalier <waddlesplash@gmail.com>


# b0a56fc5 29-Jan-2015 John Scipione <jscipione@gmail.com>

_DistributeTabSize cleanup

* use ceilf() over ceil() and floorf() over floor()
* rename prevTab to previousTab
* check that tab pointer is valid in each loop
* use tabCount variable in each loop to check the end condition


# 4ac21cd3 29-Jan-2015 Sambuddha Basu <sambuddhabasu1@gmail.com>

Issue 11111 - Division by zero in TabDecorator

Signed-off-by: John Scipione <jscipione@gmail.com>


# 0bc1fc98 16-Jan-2015 Puck Meerburg <puck@puckipedia.nl>

TabDecorator: Invalidate all tabs when updating a title

Signed-off-by: Adrien Destugues <pulkomandy@gmail.com>

Fixes #8569

I'm not sure if this works properly if you reorder tabs (see #9175). But
the fix for that is reordering the tab list to match the visible order,
which doesn't affect this part of the code.


# d2919781 26-Feb-2014 Stephan Aßmus <superstippi@gmx.de>

TabDecorator: Move tracing output into tracing statement...


# cfe0652a 14-Aug-2013 John Scipione <jscipione@gmail.com>

Move Tab code into Decorator and refactor


# e37b01b0 09-Aug-2013 John Scipione <jscipione@gmail.com>

Invalidate bitmaps when you change font size


# 5a32087b 08-Aug-2013 John Scipione <jscipione@gmail.com>

Redo close and zoom buttons

... to draw into a cached bitmap and border for BeDecorator.

Make the box positioning closer to BeOS too.

Also rearrange methods in DefaultDecorator and TabDecorator a bit.


# 63720e0f 05-Aug-2013 John Scipione <jscipione@gmail.com>

Convert BeDecorator to derive from TabDecorator

Also, make the close and zoom buttons update when clicked.


# 106fe8b3 30-Jul-2013 John Scipione <jscipione@gmail.com>

Create a TabDecorator class

Which contains methods common to Default Decorator and BeDecorator, aka
"tabbed" decorators.

Derive DefaultDecorator from a new TabDecorator base class.


# b0a56fc5db6c5597e1f7ed7cae1fa2386d6f43c0 29-Jan-2015 John Scipione <jscipione@gmail.com>

_DistributeTabSize cleanup

* use ceilf() over ceil() and floorf() over floor()
* rename prevTab to previousTab
* check that tab pointer is valid in each loop
* use tabCount variable in each loop to check the end condition


# 4ac21cd37da3c8ff3ca049312213c090efc154cb 29-Jan-2015 Sambuddha Basu <sambuddhabasu1@gmail.com>

Issue 11111 - Division by zero in TabDecorator

Signed-off-by: John Scipione <jscipione@gmail.com>


# 0bc1fc98a5f3cd1dd149cdb9ad30b826a4b54cbf 16-Jan-2015 Puck Meerburg <puck@puckipedia.nl>

TabDecorator: Invalidate all tabs when updating a title

Signed-off-by: Adrien Destugues <pulkomandy@gmail.com>

Fixes #8569

I'm not sure if this works properly if you reorder tabs (see #9175). But
the fix for that is reordering the tab list to match the visible order,
which doesn't affect this part of the code.


# d2919781c3c7d64afefe0032fb355dfca9ea6177 26-Feb-2014 Stephan Aßmus <superstippi@gmx.de>

TabDecorator: Move tracing output into tracing statement...


# cfe0652a5efb3675bfab24b58c45b450ebca7cac 14-Aug-2013 John Scipione <jscipione@gmail.com>

Move Tab code into Decorator and refactor


# e37b01b01dab5d57b782cf5cecbd31970416bfff 09-Aug-2013 John Scipione <jscipione@gmail.com>

Invalidate bitmaps when you change font size


# 5a32087b8eee6cf157f98e7f07fcb2e18ad9dd81 08-Aug-2013 John Scipione <jscipione@gmail.com>

Redo close and zoom buttons

... to draw into a cached bitmap and border for BeDecorator.

Make the box positioning closer to BeOS too.

Also rearrange methods in DefaultDecorator and TabDecorator a bit.


# 63720e0fd05765df6ecbc52db8387aa03a3e956a 05-Aug-2013 John Scipione <jscipione@gmail.com>

Convert BeDecorator to derive from TabDecorator

Also, make the close and zoom buttons update when clicked.


# 106fe8b325a387294deb0a0949201bef0d00a8f6 30-Jul-2013 John Scipione <jscipione@gmail.com>

Create a TabDecorator class

Which contains methods common to Default Decorator and BeDecorator, aka
"tabbed" decorators.

Derive DefaultDecorator from a new TabDecorator base class.