History log of /haiku/src/servers/app/decorator/DefaultDecorator.cpp
Revision Date Author Comments
# 287712a6 26-Aug-2022 Augustin Cavalier <waddlesplash@gmail.com>

app_server: Adjust borders of the resize knob depending on the handle size.

Appearance remains the same at the standard decorator sizes (12pt fonts),
but this looks better on larger font sizes. Unfortunately it doesn't
scale quite correctly; the scrollbars in Tracker do not align with this
quite correctly. Probably the -0/-1 need to be adjusted based on the
window border sizes, but we don't have those metrics readily available
in this function. Yet another reason all these classes need a major
refactor...


# 9d80098e 12-Jul-2022 Augustin Cavalier <waddlesplash@gmail.com>

app_server: Add casts to appease GCC2.


# 112fc353 12-Jul-2022 Augustin Cavalier <waddlesplash@gmail.com>

app_server: Basic scaling for window borders.

This code is quite convoluted and very much in need of refactoring,
but this solution works well enough for the time being. It does not
look quite right at higher resolutions (borders come out darker than
they do at the default resolution), but at least the borders are now
the correct size instead of a constant one.

The resize nub drawing code also hasn't yet been updated, so while
it draws the gradient over the full resize area and responds to clicks,
the "checkerboard" pattern is drawn at a fixed small size still.

Nonetheless, this is a significant improvement.


# 773d5303 19-Jul-2018 Tri-Edge AI <triedgeai@gmail.com>

app_server: Implement B_OUTLINE_RESIZE

- Allows applications to be resized without the window contents resizing with the window frame.
- Due to the nature of out-of-tree decorators using private APIs, this will require all pre-existing decorators to be rebuilt
- Newer decorators won't work on older versions of Haiku...
- Also has some formatting with license headers.
- Fixes #2724

Change-Id: Id0b45e7bbc0b636e6dffbd396eb584bf348b5296
Reviewed-on: https://review.haiku-os.org/c/haiku/+/344
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
Reviewed-by: Jacob Secunda <secundaja@gmail.com>


# df4074fb 24-Nov-2018 Augustin Cavalier <waddlesplash@gmail.com>

Remove a lot of unused constants.

Spotted by Clang. No functional change intended.


# 7f9368ca 09-Dec-2015 looncraz <looncraz@looncraz.net>

Set*UIColor, etc.

The inseparable changes necessary to support live color updating across the
system in a sane, safe, and performant manner.

BView gains:

HasSystemColors()
HasDefaultColors()
AdoptSystemColors()
AdoptParentColors()
AdoptViewColor(BView*)
SetViewUIColor(color_which, float tint)
SetHighUIColor(...
SetLowUIColor(...
ViewUIColor(float* tint)
HighUIColor(...
LowUIColor(...
DelayedInvalidate()

BWindow gains a simple helper method:
IsOffscreenWindow()

BMessage gains:

AddColor()
FindColor()
GetColor()
HasColor() * allegedly this API is deprecated, but I implemented it anyway
ReplaceColor()
SetColor()

Previous private ColorTools methods are made public and moved into GraphicsDefs:

mix_color, blend_color, disable_color

These are fully compatible with BeOS dan0 R5.1 methods and are just code cleanup
of BeOS example code under the OpenTracker license.

In addition, four new colors are created:
B_LINK_TEXT_COLOR
B_LINK_HOVER_COLOR
B_LINK_ACTIVE_COLOR
B_LINK_VISITED_COLOR

These changes are documented in their proper user documentation files.

In addition, due to a history rewrite, B_FOLLOW_LEFT_TOP has been defined and
used in lieu of B_FOLLOW_TOP | B_FOLLOW_LEFT and is included in this commit.

On the app_server side, the following has changed:

Add DelayedMessage - a system by which messages can be sent at a scheduled time,
and can also be merged according to set rules. A single thread is used to service the
message queue and multiple recipients can be set for each message.
Desktop gains the ability to add message ports to a DelayedMessage so that
said messages can target either all applications or all windows, as needed.

Desktop maintains a BMessage which is used to queue up all pending color changes
and the delayed messaging system is used to enact these changes after a short
period of time has passed. This prevents abuse and allows the system to merge
repeated set_ui_color events into one event for client applications, improving
performance drastically.

In addition, B_COLORS_UPDATED is sent to the BApplication, which forwards the message
to each BWindow. This is done to improve performance over having the app_server
independently informing each window.

Decorator changes are live now, which required some reworking.

Signed-off-by: Augustin Cavalier <waddlesplash@gmail.com>


# cfe0652a 14-Aug-2013 John Scipione <jscipione@gmail.com>

Move Tab code into Decorator and refactor


# 5a32087b 08-Aug-2013 John Scipione <jscipione@gmail.com>

Redo close and zoom buttons

... to draw into a cached bitmap and border for BeDecorator.

Make the box positioning closer to BeOS too.

Also rearrange methods in DefaultDecorator and TabDecorator a bit.


# 63720e0f 05-Aug-2013 John Scipione <jscipione@gmail.com>

Convert BeDecorator to derive from TabDecorator

Also, make the close and zoom buttons update when clicked.


# 106fe8b3 30-Jul-2013 John Scipione <jscipione@gmail.com>

Create a TabDecorator class

Which contains methods common to Default Decorator and BeDecorator, aka
"tabbed" decorators.

Derive DefaultDecorator from a new TabDecorator base class.


# 87c51182 30-Jul-2013 John Scipione <jscipione@gmail.com>

Decorators: Update copyright headers


# 719b56b0 30-Jul-2013 John Scipione <jscipione@gmail.com>

DefaultDecorator: updateRect not update


# 45b17fde 19-Jul-2013 John Scipione <jscipione@gmail.com>

Some style fixes


# 98b326dd 28-Jan-2013 Adrien Destugues <pulkomandy@gmail.com>

Revert Ctrl+Alt resizing/moving changes.
This removes the solution with no convincing replacement,
and breaks most basic window management tasks such as raising a window when clicking it.

Please come back when you get the issues fixed and a real alternative to the "ugly" border highlighting.

This reverts hrev45197-45202.


# 3071859c 16-Jan-2013 John Scipione <jscipione@gmail.com>

Update ctrl+alt window management functionality.

* Use double-headed resize arrows instead of single headed.
* Remove border highlighting, it is replaced by mouse cursor.
* Don't enter drag state if window is not movable.
* Make Ctrl+LMB resize window border like RMB.
* Define other 3 corners in default decorator and resize by them
as well
* Update mouse cursor to show arrows when over borders and control
is held.
* Set the move cursor on ctrl+alt if the window is movable.
* Set cursor to not allowed on ctrl+alt if window is not movable.
* Set the cursor to appropriate resize arrow on ctrl+alt+RMB.
* Set the cursor to not allowed on ctrl+alt+RMB if not resizable.
* Make window go to back when you right-click or ctrl+click
on the tab. It doesn't lose focus though unlike BeOS R5.


# 70a5df38 09-Jun-2012 Ryan Leavengood <leavengood@gmail.com>

Use the correct color for the tab border for inactive windows.

Before this the active window border color was used, resulting in ugly inactive
window tabs if the active and inactive border colors were quite different.

This was not noticed before because the defaults are two very similar grays.


# a18c2a6d 28-Oct-2011 John Scipione <jscipione@gmail.com>

Adjust the border color using tints so that it is just so, not too 3d. Get rid of all the extra contstants and just tint off of the base color.


# 30d17caa 28-Oct-2011 John Scipione <jscipione@gmail.com>

Added support for colored window tabs in the default decorator.


# c732cb56 15-Aug-2011 Clemens Zeidler <clemens.zeidler@googlemail.com>

Reset the tab region when switching to a tab less look. At least partially fixes #7919.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42636 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 1c141573 02-Aug-2011 Clemens Zeidler <clemens.zeidler@googlemail.com>

Move flags and look into the tab too. The flags are needed to determine e.g. whether or not the zoom button should be drawn.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42552 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 1c44bb21 02-Aug-2011 Clemens Zeidler <clemens.zeidler@googlemail.com>

Check if the dirty region is valid. Part of #7896.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42547 a95241bf-73f2-0310-859d-f6bbb57e9c96


# e089170a 31-Jul-2011 Clemens Zeidler <clemens.zeidler@googlemail.com>

Fix the check for the max tab offset when there is only one tab.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42528 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 86b01082 25-Jul-2011 Clemens Zeidler <clemens.zeidler@googlemail.com>

* Draw the complete decorator off screen and copy it to the front when finished. Stippi please take a look. This fixes some flickering when drawing shifted tabs in stack mode. In stack mode the different tabs sometime repaint each other, thus the decorator has to been drawn double buffered to avoid artefacts.
* Add an option to draw the button directly, i.e. when they are clicked.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42493 a95241bf-73f2-0310-859d-f6bbb57e9c96


# f4f30311 24-Jul-2011 Clemens Zeidler <clemens.zeidler@googlemail.com>

Cleanup app server directory a bit by creating a font and a decorator sub folder.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42483 a95241bf-73f2-0310-859d-f6bbb57e9c96


# cfe0652a5efb3675bfab24b58c45b450ebca7cac 14-Aug-2013 John Scipione <jscipione@gmail.com>

Move Tab code into Decorator and refactor


# 5a32087b8eee6cf157f98e7f07fcb2e18ad9dd81 08-Aug-2013 John Scipione <jscipione@gmail.com>

Redo close and zoom buttons

... to draw into a cached bitmap and border for BeDecorator.

Make the box positioning closer to BeOS too.

Also rearrange methods in DefaultDecorator and TabDecorator a bit.


# 63720e0fd05765df6ecbc52db8387aa03a3e956a 05-Aug-2013 John Scipione <jscipione@gmail.com>

Convert BeDecorator to derive from TabDecorator

Also, make the close and zoom buttons update when clicked.


# 106fe8b325a387294deb0a0949201bef0d00a8f6 30-Jul-2013 John Scipione <jscipione@gmail.com>

Create a TabDecorator class

Which contains methods common to Default Decorator and BeDecorator, aka
"tabbed" decorators.

Derive DefaultDecorator from a new TabDecorator base class.


# 87c51182756eeecc680ab404a79e7b474bfabc5c 30-Jul-2013 John Scipione <jscipione@gmail.com>

Decorators: Update copyright headers


# 719b56b055646060101592adc99558cf2f91cba8 30-Jul-2013 John Scipione <jscipione@gmail.com>

DefaultDecorator: updateRect not update


# 45b17fde13fc5286bad7c3508221827045f44740 19-Jul-2013 John Scipione <jscipione@gmail.com>

Some style fixes


# 98b326dd2e1b54a35ee493d6bcfacf652b860a5b 28-Jan-2013 Adrien Destugues <pulkomandy@gmail.com>

Revert Ctrl+Alt resizing/moving changes.
This removes the solution with no convincing replacement,
and breaks most basic window management tasks such as raising a window when clicking it.

Please come back when you get the issues fixed and a real alternative to the "ugly" border highlighting.

This reverts hrev45197-45202.


# 3071859cc6842d96fa086771c9463085ea0f2246 16-Jan-2013 John Scipione <jscipione@gmail.com>

Update ctrl+alt window management functionality.

* Use double-headed resize arrows instead of single headed.
* Remove border highlighting, it is replaced by mouse cursor.
* Don't enter drag state if window is not movable.
* Make Ctrl+LMB resize window border like RMB.
* Define other 3 corners in default decorator and resize by them
as well
* Update mouse cursor to show arrows when over borders and control
is held.
* Set the move cursor on ctrl+alt if the window is movable.
* Set cursor to not allowed on ctrl+alt if window is not movable.
* Set the cursor to appropriate resize arrow on ctrl+alt+RMB.
* Set the cursor to not allowed on ctrl+alt+RMB if not resizable.
* Make window go to back when you right-click or ctrl+click
on the tab. It doesn't lose focus though unlike BeOS R5.


# 70a5df3878c7778c8342a268f62176f15245ab35 09-Jun-2012 Ryan Leavengood <leavengood@gmail.com>

Use the correct color for the tab border for inactive windows.

Before this the active window border color was used, resulting in ugly inactive
window tabs if the active and inactive border colors were quite different.

This was not noticed before because the defaults are two very similar grays.


# a18c2a6d9e3f313248d3a5acc609de27ea3f9602 28-Oct-2011 John Scipione <jscipione@gmail.com>

Adjust the border color using tints so that it is just so, not too 3d. Get rid of all the extra contstants and just tint off of the base color.


# 30d17caa9d4370c1425b7ad42c1a1cd771e89b13 28-Oct-2011 John Scipione <jscipione@gmail.com>

Added support for colored window tabs in the default decorator.


# c732cb560dc554a3089aaecbd114ea632596c3db 15-Aug-2011 Clemens Zeidler <clemens.zeidler@googlemail.com>

Reset the tab region when switching to a tab less look. At least partially fixes #7919.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42636 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 1c1415732dcf43dec54a93d20ad15c701dc6996e 02-Aug-2011 Clemens Zeidler <clemens.zeidler@googlemail.com>

Move flags and look into the tab too. The flags are needed to determine e.g. whether or not the zoom button should be drawn.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42552 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 1c44bb215761366278902e794ff1c9af64012ead 02-Aug-2011 Clemens Zeidler <clemens.zeidler@googlemail.com>

Check if the dirty region is valid. Part of #7896.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42547 a95241bf-73f2-0310-859d-f6bbb57e9c96


# e089170a153f92a46538cf1a01278b651c3259ec 31-Jul-2011 Clemens Zeidler <clemens.zeidler@googlemail.com>

Fix the check for the max tab offset when there is only one tab.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42528 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 86b010824cfcf9923573ca68850fd26a71eeb0bc 25-Jul-2011 Clemens Zeidler <clemens.zeidler@googlemail.com>

* Draw the complete decorator off screen and copy it to the front when finished. Stippi please take a look. This fixes some flickering when drawing shifted tabs in stack mode. In stack mode the different tabs sometime repaint each other, thus the decorator has to been drawn double buffered to avoid artefacts.
* Add an option to draw the button directly, i.e. when they are clicked.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42493 a95241bf-73f2-0310-859d-f6bbb57e9c96


# f4f30311aab9b2768d3ef7e590f85598298edfe0 24-Jul-2011 Clemens Zeidler <clemens.zeidler@googlemail.com>

Cleanup app server directory a bit by creating a font and a decorator sub folder.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42483 a95241bf-73f2-0310-859d-f6bbb57e9c96