Time preferences: fix button jumping position

Fixes #16102.

Change-Id: I8d89173009b21e1c31652bb2f011ceb46195c232
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2795
Reviewed-by: waddlesplash <waddlesplash@gmail.com>

Time preferences: remove \r

We are not Windows, we don't need these.

NetworkTimeView: Add missing default in MessageReceived switch.

Fixes #12652.

Improve/fix tab view layout as discussed

See http://www.freelists.org/post/haiku-development/Unifying-visuals-of-BTabView-usage

Besides the tab bar going the full width of the window, also some
layouting tweaks to several apps and prefs.

Still missing: the first (and last) tabs in the tab bar should be inset by
B_USE_WINDOW_SPACING so the controls in the tab view line up nicely.
I think I remember stippi wanting to look into it... :)

Time prefs: Use button label symbols & relayout

Add becomes +, Remove becomes −, the current button labels "Add" and "Remove"
are used as tool tips. Relayout the controls so that they fit nicely with the
buttons:

The add button is placed left of the server text control showing that it
adds new server names while the remove button is placed next to the list
view showing that it removes server names from the list.

The reset button is placed next to the "Synchronize" button at the bottom of
the tab group and is renamed "Reset to default server list".

This makes the window a bit taller.

Time prefs: Set text colors in constructor

Time prefs: Set pointer NULL, delete in destructor

... avoiding potential memory leak.

Time prefs: Enable add button if server name valid

* Add button is disabled initially (as the server name is blank)
* Use B_FAILURE_COLOR when server name is invalid instead of hardcoding red
* Some code refactoring
* Some style fixes

Time prefs: Disable remove button if list empty

Time: Remove superfluous MakeEmpty()

Thanks AnEvilYak

Time: Fix memory leak.

BListView::RemoveItem() doesn't delete the item, it just removes it
from the list. We have to delete the item to free the memory it
consumes ourselves.

Time: Style fixes to NetworkTimeView

Time Preferences crashes with empty selection

Application "Time" crashes when you push "Remove" button without any
selection on list of network time servers.

Fixes #10716

Please use git format-patch to create your patches in the future so that
the author information is preserved.

Signed-off-by: John Scipione <jscipione@gmail.com>

Added more things to x86_64 image.

Some preference apps, mount_server and AboutSystem. Removed the check
for x86_64 in the boot script, the normal path through the script will
work now. Also removed a temporary hack to workaround AboutSystem not
being there in build_haiku_image.

Close alerts with ESCAPE key.

Added SetFlags(B_CLOSE_ON_ESCAPE) or SetShortcut(index, B_ESCAPE) to BAlerts
depending if the result gets used later in the code, or if it's a one-button
BAlert.

More catalog-related cleanup.

* rename B_TRANSLATE_CONTEXT to B_TRANSLATION_CONTEXT and
B_TRANSLATE_WITH_CONTEXT to B_TRANSLATE_CONTEXT, squashing a TODO
* adjust all uses of both macros in Haiku's source tree
* use correct header guard for collecting/Catalog.h

The renamed macros require adjustments to all external applications
using catalogs.

Time preference: Fix a memory leak

Accidentally introduced with an earlier commit.

Time preferences: use std::nothrow variant of new operator

Also make sure to avoid an eventual negative array size. CID 10934.

Fix #7672 by applying humdinger's patch then adding more:

The server name is checked while typing and if it is not valid the text is made
red. Invalid entries cannot be added to the list.

Also made the server add message be the invoking message so that the enter key
works to add a server.

After adding a valid server the text is cleared.

Valid servers names are alpha-numeric with periods, dashes and underscores.
Could need some things added but that should cover 99% of the cases.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42097 a95241bf-73f2-0310-859d-f6bbb57e9c96

Apply another patch from Hamish from ticket #2412 which adds more localization
and removes unneeded whitespace. Thanks!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41955 a95241bf-73f2-0310-859d-f6bbb57e9c96

Apply patches from Humdinger and mt (with some overlap) which adds localization
to the Network time tab and makes the layout use more standard spacing.

Also changed the name of the Synchronize button after a sync to Synchronize again.

Fixes #7642.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41949 a95241bf-73f2-0310-859d-f6bbb57e9c96

Apply Hamish Morrison's patch from #2412, with a few small style changes and
merging my fixes to ntp.cpp from the NetworkTime source.

This makes Time use the layout system as well as support updating time through
the network.

I tried very hard to catch and fix any new style violations, though in general
Hamish did quite well.

After some testing this could be put in Alpha3, but I won't mark it as such
yet.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41930 a95241bf-73f2-0310-859d-f6bbb57e9c96

Time prefs: Use button label symbols & relayout

Add becomes +, Remove becomes −, the current button labels "Add" and "Remove"
are used as tool tips. Relayout the controls so that they fit nicely with the
buttons:

The add button is placed left of the server text control showing that it
adds new server names while the remove button is placed next to the list
view showing that it removes server names from the list.

The reset button is placed next to the "Synchronize" button at the bottom of
the tab group and is renamed "Reset to default server list".

This makes the window a bit taller.

Time prefs: Set text colors in constructor

Time prefs: Set pointer NULL, delete in destructor

... avoiding potential memory leak.

Time prefs: Enable add button if server name valid

* Add button is disabled initially (as the server name is blank)
* Use B_FAILURE_COLOR when server name is invalid instead of hardcoding red
* Some code refactoring
* Some style fixes

Time prefs: Disable remove button if list empty

Time: Remove superfluous MakeEmpty()

Thanks AnEvilYak

Time: Fix memory leak.

BListView::RemoveItem() doesn't delete the item, it just removes it
from the list. We have to delete the item to free the memory it
consumes ourselves.

Time: Style fixes to NetworkTimeView

Time Preferences crashes with empty selection

Application "Time" crashes when you push "Remove" button without any
selection on list of network time servers.

Fixes #10716

Please use git format-patch to create your patches in the future so that
the author information is preserved.

Signed-off-by: John Scipione <jscipione@gmail.com>

Added more things to x86_64 image.

Some preference apps, mount_server and AboutSystem. Removed the check
for x86_64 in the boot script, the normal path through the script will
work now. Also removed a temporary hack to workaround AboutSystem not
being there in build_haiku_image.

Close alerts with ESCAPE key.

Added SetFlags(B_CLOSE_ON_ESCAPE) or SetShortcut(index, B_ESCAPE) to BAlerts
depending if the result gets used later in the code, or if it's a one-button
BAlert.

More catalog-related cleanup.

* rename B_TRANSLATE_CONTEXT to B_TRANSLATION_CONTEXT and
B_TRANSLATE_WITH_CONTEXT to B_TRANSLATE_CONTEXT, squashing a TODO
* adjust all uses of both macros in Haiku's source tree
* use correct header guard for collecting/Catalog.h

The renamed macros require adjustments to all external applications
using catalogs.

Time preference: Fix a memory leak

Accidentally introduced with an earlier commit.

Time preferences: use std::nothrow variant of new operator

Also make sure to avoid an eventual negative array size. CID 10934.

Fix #7672 by applying humdinger's patch then adding more:

The server name is checked while typing and if it is not valid the text is made
red. Invalid entries cannot be added to the list.

Also made the server add message be the invoking message so that the enter key
works to add a server.

After adding a valid server the text is cleared.

Valid servers names are alpha-numeric with periods, dashes and underscores.
Could need some things added but that should cover 99% of the cases.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42097 a95241bf-73f2-0310-859d-f6bbb57e9c96

Apply another patch from Hamish from ticket #2412 which adds more localization
and removes unneeded whitespace. Thanks!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41955 a95241bf-73f2-0310-859d-f6bbb57e9c96

Apply patches from Humdinger and mt (with some overlap) which adds localization
to the Network time tab and makes the layout use more standard spacing.

Also changed the name of the Synchronize button after a sync to Synchronize again.

Fixes #7642.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41949 a95241bf-73f2-0310-859d-f6bbb57e9c96

Apply Hamish Morrison's patch from #2412, with a few small style changes and
merging my fixes to ntp.cpp from the NetworkTime source.

This makes Time use the layout system as well as support updating time through
the network.

I tried very hard to catch and fix any new style violations, though in general
Hamish did quite well.

After some testing this could be put in Alpha3, but I won't mark it as such
yet.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41930 a95241bf-73f2-0310-859d-f6bbb57e9c96