| #
6eff9ae6 |
|
05-Oct-2022 |
Oscar Lesta <oscar.lesta@gmail.com> |
Sounds preflet: don't reuse variable names.
This fixes "issue 2" from #17150, that only manifested on x86-64.
Also: moved the "menu" variable declaration closer to its usege.
Change-Id: If44f84a8d5ee2bd662c312aec26359c857db5a93
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5720
Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
|
| #
e4d44d82 |
|
03-Sep-2022 |
Oscar Lesta <oscar.lesta@gmail.com> |
Sounds preflet: small UX improvements.
* Disable BMenuField unless a sound event is selected.
* Changes in the MenuItem enable/disable the play button as necessary.
(previously only changes in the EventList did that).
* Enable the play button when BFilePanel is closed (after selecting valid file).
Fixes the (still reproducible) UI/UX portion of #17150.
Change-Id: I5b5d00cc7fce00a0d0f908bbaff883169f38f855
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5613
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
|
| #
d0ac6099 |
|
07-Nov-2015 |
Humdinger <humdingerb@gmail.com> |
Use B_USE_WINDOW_SPACING
Use B_USE_WINDOW_SPACING as inset from contents to window border.
Some whitespace cleanup.
|
| #
8d46a99f |
|
14-Sep-2015 |
Axel Dörfler <axeld@pinc-software.de> |
Sounds: Center initial window.
* Now uses BWindow::MoveOnScreen().
|
| #
aaa7d926 |
|
21-Apr-2015 |
Janus <janus2@ymail.com> |
Preferences: improve layout.
* Sounds use LayoutBuilder vs. GroupLayoutBuilder.
* Time standard spacing.
* VirtualMemory standard spacing.
|
| #
57810fe9 |
|
29-Oct-2014 |
Adrien Destugues <pulkomandy@gmail.com> |
Sounds: zoom to fit instead of going fullscreen.
Fixes #5588.
|
| #
3a8e734b |
|
29-Oct-2014 |
Adrien Destugues <pulkomandy@gmail.com> |
Sounds: make private methods private.
|
| #
c54aa3df |
|
29-Oct-2014 |
Adrien Destugues <pulkomandy@gmail.com> |
Sounds: rework layout of window
* Remove useless BBox
* Use unicode symbols for play/stop buttons instead of a label
* Since the buttons are smaller, put them on the same line as the file
selector.
|
| #
38fa81bf |
|
03-Oct-2013 |
Ingo Weinhold <ingo_weinhold@gmx.de> |
Remove B_COMMON*_DIRECTORY and kCommon*Directory constants
* This does intentionally break source compatibility, so that a review
of concerned code is forced.
* Binary compatibility should be maintained in most cases. The values
of the constants for the writable directories are now used for the
writable system directories. The values for the non-writable
directories are mapped to "/boot/system/data/empty/...", an empty or
non-existent directory, so that they will simply be skipped in search
paths. Only code that explicitly expects to find something in a
B_COMMON_* directory, will fail.
|
| #
d7250540 |
|
12-Dec-2012 |
Humdinger <humdingerb@gmail.com> |
Using a variable instead of translating a string twice.
Thanks John for the guidance.
|
| #
f7c33e7f |
|
12-Dec-2012 |
Humdinger <humdingerb@gmail.com> |
Fixes case style of a label, "Sound file:"
|
| #
aed35104 |
|
05-Aug-2012 |
Humdinger <humdingerb@gmail.com> |
Close alerts with ESCAPE key.
Added SetFlags(B_CLOSE_ON_ESCAPE) or SetShortcut(index, B_ESCAPE) to BAlerts
depending if the result gets used later in the code, or if it's a one-button
BAlert.
|
| #
546208a5 |
|
16-Apr-2012 |
Oliver Tappe <zooey@hirschkaefer.de> |
More catalog-related cleanup.
* rename B_TRANSLATE_CONTEXT to B_TRANSLATION_CONTEXT and
B_TRANSLATE_WITH_CONTEXT to B_TRANSLATE_CONTEXT, squashing a TODO
* adjust all uses of both macros in Haiku's source tree
* use correct header guard for collecting/Catalog.h
The renamed macros require adjustments to all external applications
using catalogs.
|
| #
63208ae8 |
|
04-Jun-2011 |
Joachim Seemer <humdingerb@googlemail.com> |
Made the first column a bit wider,because it always truncated the Vision notification... Also changed the bit weird spacing to be a uniform DefaultItemSpacing.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41910 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
| #
61372793 |
|
17-Aug-2010 |
Oliver Tappe <zooey@hirschkaefer.de> |
CID-639: Protect against FindItem() potentially returning NULL
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38187 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
| #
4eb0cbb0 |
|
07-May-2010 |
Matt Madia <mattmadia@gmail.com> |
Updated TR_CONTEXT to be B_TRANSLATE_CONTEXT, relating to #5408.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36733 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
| #
dd4b6c23 |
|
06-May-2010 |
Matt Madia <mattmadia@gmail.com> |
Updated to use B_TRANSLATE* macros. relates to #5408.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36695 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
| #
404b95c4 |
|
06-May-2010 |
Stephan Aßmus <superstippi@gmx.de> |
Patch by mt:
* Convert Sounds to use layout API
* Localization
Thanks a lot! Closes ticket #5111. I've had to apply the patch manually because
someone committed a coding style cleanup without looking up pending patches
(and the patch also contained mostly the same cleanup).
This is the second time this happened, would be nice to avoid this in the
future.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36642 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
| #
e7f640f2 |
|
24-Feb-2010 |
Alexandre Deckner <alex@zappotek.com> |
* more cleanup in Sounds preflet, replaced occurences of the deprecated cast_as macro, added missing checks.
* took the opportunity to do the same for all occurences as reported by OpenGrok
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35600 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
| #
bf7db4bb |
|
24-Feb-2010 |
Alexandre Deckner <alex@zappotek.com> |
* style cleanup, no functional change
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35596 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
| #
550d47d9 |
|
10-Jan-2010 |
Jérôme Duval <korli@users.berlios.de> |
* cleanup
* save and restore window frame. Fixed bug #4307.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34998 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
| #
9b79c5cc |
|
09-Jan-2010 |
Jérôme Duval <korli@users.berlios.de> |
cleanup & typo
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34982 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
| #
9c1a9b92 |
|
20-Dec-2009 |
Adrien Destugues <pulkomandy@pulkomandy.ath.cx> |
* Patch by Humdinger to convert a lot of things to sentance case.
* Cleanup and update of all the touched catkeys files
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34731 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
| #
b96533c2 |
|
30-Jul-2009 |
Jonas Sundström <jonas@kirilla.com> |
Set event list to single-select.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@31977 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
| #
d27b2466 |
|
15-Nov-2008 |
Rene Gollent <anevilyak@gmail.com> |
Fix a few minor problems that resulted in the sound column not being drawn until clicked. Also changed CLV to use B_PLAIN_BORDER. This fixes the redraw issues in ticket #2980.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28658 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
| #
072403a5 |
|
28-Oct-2008 |
Karsten Heimrich <host.haiku@gmx.de> |
* fix the build
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28360 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
| #
5d8c4177 |
|
28-Oct-2008 |
Jérôme Duval <korli@users.berlios.de> |
Use a ColumnListView
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28359 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
| #
31442c74 |
|
08-May-2008 |
Jérôme Duval <korli@users.berlios.de> |
Patch from Kaoutsis: use find_directory() instead of a fixed path
added some checks, keep the style clean
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@25366 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
| #
e6b421a9 |
|
29-Apr-2008 |
Jérôme Duval <korli@users.berlios.de> |
fix misuse of ... with B_UTF8_ELLIPSIS
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@25261 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
| #
269fdeef |
|
13-Jan-2008 |
Jérôme Duval <korli@users.berlios.de> |
style cleanup
whitespace => tab
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@23505 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
| #
c71ff07b |
|
13-Jan-2008 |
Jérôme Duval <korli@users.berlios.de> |
style cleanup
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@23502 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
| #
c18df4b6 |
|
18-Aug-2007 |
Ryan Leavengood <leavengood@gmail.com> |
Two fixes:
- One from Justin O'Dell which properly enables and disables the play and stop
buttons.
- One from me which doesn't crash Sounds if you try to open a file which has no
MIME type set. It previously assumed the super type would always exist.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@22010 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
| #
8184808c |
|
21-May-2007 |
Stefano Ceccherini <stefano.ceccherini@gmail.com> |
'Sounds' is now font sensitive. Patch by Lucasz Zemczak.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@21185 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
| #
a10cf76e |
|
24-Jun-2005 |
Axel Dörfler <axeld@pinc-software.de> |
Renamed src/prefs to "preferences", as the directory is usually called in BeOS.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@13263 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
| #
8d46a99fe9f9b82168eda3b44b4c595317e4c933 |
|
14-Sep-2015 |
Axel Dörfler <axeld@pinc-software.de> |
Sounds: Center initial window.
* Now uses BWindow::MoveOnScreen().
|
| #
aaa7d92685de060c2e8143e06408f1a3c716a0b0 |
|
21-Apr-2015 |
Janus <janus2@ymail.com> |
Preferences: improve layout.
* Sounds use LayoutBuilder vs. GroupLayoutBuilder.
* Time standard spacing.
* VirtualMemory standard spacing.
|
| #
57810fe9e0e25aa2fd6d035a9f6e3046ab688976 |
|
29-Oct-2014 |
Adrien Destugues <pulkomandy@gmail.com> |
Sounds: zoom to fit instead of going fullscreen.
Fixes #5588.
|
| #
3a8e734bddb377b005c801ea65ede6d95c41727d |
|
29-Oct-2014 |
Adrien Destugues <pulkomandy@gmail.com> |
Sounds: make private methods private.
|
| #
c54aa3df3f69a256c78315b0cf92bbbde70c3fd1 |
|
29-Oct-2014 |
Adrien Destugues <pulkomandy@gmail.com> |
Sounds: rework layout of window
* Remove useless BBox
* Use unicode symbols for play/stop buttons instead of a label
* Since the buttons are smaller, put them on the same line as the file
selector.
|
| #
38fa81bf8f0ccc37a615a9f5bd333f9b781322b3 |
|
03-Oct-2013 |
Ingo Weinhold <ingo_weinhold@gmx.de> |
Remove B_COMMON*_DIRECTORY and kCommon*Directory constants
* This does intentionally break source compatibility, so that a review
of concerned code is forced.
* Binary compatibility should be maintained in most cases. The values
of the constants for the writable directories are now used for the
writable system directories. The values for the non-writable
directories are mapped to "/boot/system/data/empty/...", an empty or
non-existent directory, so that they will simply be skipped in search
paths. Only code that explicitly expects to find something in a
B_COMMON_* directory, will fail.
|
| #
d7250540e0615eb680ca6064a22a5d5446a79a35 |
|
12-Dec-2012 |
Humdinger <humdingerb@gmail.com> |
Using a variable instead of translating a string twice.
Thanks John for the guidance.
|
| #
f7c33e7ff9af71bdeefe9506bfbff7431e1df1ee |
|
12-Dec-2012 |
Humdinger <humdingerb@gmail.com> |
Fixes case style of a label, "Sound file:"
|
| #
aed35104852941f0f6f3d1dcc5338b5f337d0a3c |
|
05-Aug-2012 |
Humdinger <humdingerb@gmail.com> |
Close alerts with ESCAPE key.
Added SetFlags(B_CLOSE_ON_ESCAPE) or SetShortcut(index, B_ESCAPE) to BAlerts
depending if the result gets used later in the code, or if it's a one-button
BAlert.
|
| #
546208a53940a26c6379c48a7854ade1a8250fc5 |
|
16-Apr-2012 |
Oliver Tappe <zooey@hirschkaefer.de> |
More catalog-related cleanup.
* rename B_TRANSLATE_CONTEXT to B_TRANSLATION_CONTEXT and
B_TRANSLATE_WITH_CONTEXT to B_TRANSLATE_CONTEXT, squashing a TODO
* adjust all uses of both macros in Haiku's source tree
* use correct header guard for collecting/Catalog.h
The renamed macros require adjustments to all external applications
using catalogs.
|
| #
63208ae886ea51ca41706f39aaf4987e8d077818 |
|
04-Jun-2011 |
Joachim Seemer <humdingerb@googlemail.com> |
Made the first column a bit wider,because it always truncated the Vision notification... Also changed the bit weird spacing to be a uniform DefaultItemSpacing.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41910 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
| #
6137279338a8241cddcb982ba364f3ca9f7cc4d5 |
|
17-Aug-2010 |
Oliver Tappe <zooey@hirschkaefer.de> |
CID-639: Protect against FindItem() potentially returning NULL
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38187 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
| #
4eb0cbb044cf538f18c0d252934a5bcaa33bfd34 |
|
07-May-2010 |
Matt Madia <mattmadia@gmail.com> |
Updated TR_CONTEXT to be B_TRANSLATE_CONTEXT, relating to #5408.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36733 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
| #
dd4b6c23f62e6a83480d11da50c25a74897d0660 |
|
06-May-2010 |
Matt Madia <mattmadia@gmail.com> |
Updated to use B_TRANSLATE* macros. relates to #5408.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36695 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
| #
404b95c4108323b61aa497ddaa148c5585151880 |
|
06-May-2010 |
Stephan Aßmus <superstippi@gmx.de> |
Patch by mt:
* Convert Sounds to use layout API
* Localization
Thanks a lot! Closes ticket #5111. I've had to apply the patch manually because
someone committed a coding style cleanup without looking up pending patches
(and the patch also contained mostly the same cleanup).
This is the second time this happened, would be nice to avoid this in the
future.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36642 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
| #
e7f640f25f2251d40c0a2c95f93e0bdfccff70e4 |
|
24-Feb-2010 |
Alexandre Deckner <alex@zappotek.com> |
* more cleanup in Sounds preflet, replaced occurences of the deprecated cast_as macro, added missing checks.
* took the opportunity to do the same for all occurences as reported by OpenGrok
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35600 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
| #
bf7db4bb7e806df6ee6874b94892c06178c0bce3 |
|
24-Feb-2010 |
Alexandre Deckner <alex@zappotek.com> |
* style cleanup, no functional change
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35596 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
| #
550d47d91221cf373f43ca7b7f91d735b9422e6f |
|
10-Jan-2010 |
Jérôme Duval <korli@users.berlios.de> |
* cleanup
* save and restore window frame. Fixed bug #4307.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34998 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
| #
9b79c5cc28a04d04cff8f72aed5ed86b476cc3e2 |
|
09-Jan-2010 |
Jérôme Duval <korli@users.berlios.de> |
cleanup & typo
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34982 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
| #
9c1a9b926aa0b1890a011a44398379d1c47f09c1 |
|
20-Dec-2009 |
Adrien Destugues <pulkomandy@pulkomandy.ath.cx> |
* Patch by Humdinger to convert a lot of things to sentance case.
* Cleanup and update of all the touched catkeys files
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34731 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
| #
b96533c25673d0227804a141c7081103c19f029a |
|
30-Jul-2009 |
Jonas Sundström <jonas@kirilla.com> |
Set event list to single-select.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@31977 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
| #
d27b24661d3f88f9d044a4013bc5eea8c768df8a |
|
15-Nov-2008 |
Rene Gollent <anevilyak@gmail.com> |
Fix a few minor problems that resulted in the sound column not being drawn until clicked. Also changed CLV to use B_PLAIN_BORDER. This fixes the redraw issues in ticket #2980.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28658 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
| #
072403a553ed80d7a8e7ed598ee35701f932c3d0 |
|
28-Oct-2008 |
Karsten Heimrich <host.haiku@gmx.de> |
* fix the build
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28360 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
| #
5d8c417782df713383331410da1d51840a55c790 |
|
28-Oct-2008 |
Jérôme Duval <korli@users.berlios.de> |
Use a ColumnListView
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28359 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
| #
31442c74a4ebfaf25805cdae1a9aa1d66e341f82 |
|
08-May-2008 |
Jérôme Duval <korli@users.berlios.de> |
Patch from Kaoutsis: use find_directory() instead of a fixed path
added some checks, keep the style clean
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@25366 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
| #
e6b421a98eee762db7b1c0237e608356a2a26383 |
|
29-Apr-2008 |
Jérôme Duval <korli@users.berlios.de> |
fix misuse of ... with B_UTF8_ELLIPSIS
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@25261 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
| #
269fdeefff71dbb13136f7404d612ed2e4284131 |
|
13-Jan-2008 |
Jérôme Duval <korli@users.berlios.de> |
style cleanup
whitespace => tab
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@23505 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
| #
c71ff07bd9540240ee059b3946ab995dbaf0e12b |
|
13-Jan-2008 |
Jérôme Duval <korli@users.berlios.de> |
style cleanup
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@23502 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
| #
c18df4b6011904daabe57ae239351ad11aa00355 |
|
18-Aug-2007 |
Ryan Leavengood <leavengood@gmail.com> |
Two fixes:
- One from Justin O'Dell which properly enables and disables the play and stop
buttons.
- One from me which doesn't crash Sounds if you try to open a file which has no
MIME type set. It previously assumed the super type would always exist.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@22010 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
| #
8184808c5fcbcac3a9fb0f58c880c48295c52248 |
|
21-May-2007 |
Stefano Ceccherini <stefano.ceccherini@gmail.com> |
'Sounds' is now font sensitive. Patch by Lucasz Zemczak.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@21185 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
| #
a10cf76ef5b9e8c726ebc47183abd6943023cf8f |
|
24-Jun-2005 |
Axel Dörfler <axeld@pinc-software.de> |
Renamed src/prefs to "preferences", as the directory is usually called in BeOS.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@13263 a95241bf-73f2-0310-859d-f6bbb57e9c96
|