screen: use B_COUNT_OF(), no functional changes

Change-Id: I827da35d9c04ed3d4884d477a1904f1ff4a4aad1
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7588
Haiku-Format: Haiku-format Bot <no-reply+haikuformatbot@haiku-os.org>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>

Screen preferences: some ui fixes

- When there is no refresh rate info available, disable the menu rather
than showing "nan Hz"
- Rework the screen info tooltip generation, to avoid a confusing %s
that was mistakenly moved to the end of the string in the French
translation.

Change-Id: I4c29863a30c8c761021be57f8a2e2010709b16d5
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7364
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>

Use UTF8 multiplication sign "×" instead of "x"

It was suggested for translations in Pootle, and I agree it looks
subtly nicer: a bit smaller and vertically centered.

Also made all strings that include the "x" translatable, in case
there are different local usages.

For icon sizes in Tracker, move menu creation into a loop with an
kIconSizes array holding the pixel dimensions.

Change-Id: I805279d7186d90a13a40b4d4495670cdfac18913
Reviewed-on: https://review.haiku-os.org/c/haiku/+/6765
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk>

Screen preferences: remove leftover debug printf

Screen preferences: use a matrix menu for the resolution list

When there are a lot of display resolutions available, the menu can
become very high. Switch to a "matrix" menu with 3 columns in this case
to keep it a reasonable size.

Change-Id: I826be06a91bd1bcae600cc333e34d4a9dd7b3df5
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5320
Reviewed-by: nephele nephele <nep-git@packageloss.eu>
Reviewed-by: John Scipione <jscipione@gmail.com>
Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>

preferences/screen: Call _UpdateActiveMode after brightness is reset

* Make sure brightness is reset to properly disable the Revert button.

Fixes #16354

Change-Id: I4551e809db316db05f3fd9db361b8703d149a88b
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2989
Reviewed-by: waddlesplash <waddlesplash@gmail.com>

Screen prefs: Layout tweaks based on feedback

- Put workspaces settings in their own box below the screen box.
- Put brightness slider inside the screen box (currently it works per
screen, not per workspace).
- Move screen name to the title of the screen box.

Remove Set background... button, but keep its label for MonitorView
tool tip to let you know that clicking on it opens Backgrounds. There
wasn't enough room for this button with the brightness slider.

When brightness slider is hidden the window is shorter (unless you
have a lot of options on the right.)

Change-Id: I8b39d9e074e7e6abca2c37545f21c456289de381
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1984
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>

Screen prefs: Center Workspaces Columns and Rows

... limiting spinner textbox width instead of growing arbitrarily.

Change-Id: I8eaff4e8c43116a7fff51f21e4713b9b71efefb9
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1982
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>

Screen prefs: localize "Brightness" slider

Add a colon, so it fits better to the other slider labels.
Fixes #15346

PVS V595: Pointer was utilized before it was verified against nullptr.

Change-Id: Iba8b7e6160dc237f45080fa7c101fa72e4d8c753
Reviewed-on: https://review.haiku-os.org/c/1643
Reviewed-by: waddlesplash <waddlesplash@gmail.com>

Support for configuring screen backlight

Accelerant interface:
Introduce new hooks B_SET_BRIGHTNESS and B_GET_BRIGHTNESS. Brightness is
a float in the 0..1 range.

App_server:
Forward brightness things between BScreen and the accelerant.

intel_extreme:
Implement the hooks. Note that this only works for laptop panels, but
the driver will pretend to support it in other cases as well.

Screen preferences:
If the accelerant supports the B_GET_BRIGHTNESS hook, allow to set
brightness with a slider. Otherwise, the slidere is hidden and these
changes aren't visible.

Fix glitch in Screen prefs when changing background color.

When both Backgrounds and Screen are open, if the workspace color is changed
in Backgrounds the monitor preview in Screen will now refresh to the new color.

Also added a BAlert in BackgroundsView.cpp when failing to change the
background image.

Signed-off-by: Adrien Destugues <pulkomandy@pulkomandy.tk>

Fixes #13286.

Use B_USE_WINDOW_SPACING

Use B_USE_WINDOW_SPACING as inset from contents to window border.
Some whitespace cleanup.

Screen: improved window position, fixed empty line.

* The monitor size now scales with the font size.
* It now uses BWindow::MoveOnScreen() to find a good position on screen.
* The monitor info is now properly hidden when there is no info (this
removes a blank line at the top of the left box).

Screen: Rework AlertView to just use BAlert.

Fixes #12330.

Split BSpinner into BAbstractSpinner and...

2 concrete classes which are currently implemented:
* BSpinner (works on int32s)
* BDecimalSpinner (works on doubles)

In addition BAbstractSpinner now inherits from BControl instead of
BView/BInvoker. This allowed for code simplification at the cost of needing to
cast for the decimal version because SetValue(int32 value) comes from BControl.

Also, add a spinner_button_style enum with 3 options:
* SPINNER_BUTTON_HORIZONTAL_ARROWS
* SPINNER_BUTTON_VERTICAL_ARROWS
* SPINNER_BUTTON_PLUS_MINUS

which sets the spinner arrows to either use horizontal arrows (left/right)
vertical arrows, (up/down), or +/- symbols (the default).

If the spinner button is using horizontal arrows you can decrement and increment
the spinner value by pushing control+left/right, otherwise you can increment and
decrement by pushing up or down. The reason for needing control is so that you
can move the cursor in the textbox otherwise.

Switch the 3 apps that are currently using BSpinners to use the integer variety
in Deskbar preferences, WebPostive preferences, and Screen preferences.

Update Screen prefs to use BSpinner class

Screen: disable Apply button when no changes would be made.

* Previously this would work only in "current workspace" mode.
* Also avoid calling count_workspaces in a loop since its result is not
cached and it needs to ask app_server each time.
* Fixes #4231.

Signed-off-by: Adrien Destugues <pulkomandy@gmail.com>

Screen prefs: force weight of the two boxes

Depending on the locale and string length the layout could leave only a
small part of the window for the rightmost part, which is the important
thing. Force the weight of each side so we have a more balanced window.

Screen prefs: move driver info to main window

* Fixes relevant part of #5125
* The remaining information (serial number, frequency ranges) is
"advanced" and can be hidden in the tooltip. However, the video driver
used may be important important information, if you want to know if you
are using VESA, or if you have multiple video cards (Optimus for
example).

include strings.h where appriopriate...

instead or additionally to string.h, in preparation for functions move.
* moves str[n]casecmp() functions and others to strings.h.
* strings.h doesn't include string.h anymore.
* this solves #10949

Use UTF-8 minus sign instead of dash

Screen prefs: Use menu field layout methods

... to layout the menu field label and menu in the grid. This makes
the label and grid layout correctly, the AddMenuField() method should
be deprecated or fixed as it lays out the menu field differently.

Also replace numeric spacing units with font relative spacing units.

Revert to manually offsetting the BBox in BScreen.

Take this opportunity to reapply this hack in a much nicer way.

Before the hack included the default margins, now it doesn't.

Should be back to normal, sorry for the noise.

Screen: Undo hack to line up the top borders of the BBox's

Also, use font relative spacing units

Update screen prefs layout. Fixes #8817

* Center monitor info and Workspaces label.
* Use font-relative spacing.
* Update the header including copyright year, sort contributors by name and add
myself as well.

Style fixes only.

When the workspace changes use the passed in workspace screen mode

...instead of the current workspace screen mode that we are switching from.
Fixes #9415
Also don't ignore the returned the status code when updating the screen mode.

Added more things to x86_64 image.

Some preference apps, mount_server and AboutSystem. Removed the check
for x86_64 in the boot script, the normal path through the script will
work now. Also removed a temporary hack to workaround AboutSystem not
being there in build_haiku_image.

Close alerts with ESCAPE key.

Added SetFlags(B_CLOSE_ON_ESCAPE) or SetShortcut(index, B_ESCAPE) to BAlerts
depending if the result gets used later in the code, or if it's a one-button
BAlert.

More catalog-related cleanup.

* rename B_TRANSLATE_CONTEXT to B_TRANSLATION_CONTEXT and
B_TRANSLATE_WITH_CONTEXT to B_TRANSLATE_CONTEXT, squashing a TODO
* adjust all uses of both macros in Haiku's source tree
* use correct header guard for collecting/Catalog.h

The renamed macros require adjustments to all external applications
using catalogs.

Fix incorrect error check.

The case where GetRefreshLimits() failed wasn't being detected and
handled correctly.

Fix crashing corner case in screen prefs.

If the refresh limits only allowed a single refresh, the menu item constructed
had no BMessage. This caused _UpdateRefreshControls() to crash when attempting
to match the current refresh rate to the item. For simplicity, give it a message
containing the fixed refresh rate just as in all other cases. Should finally
fix #8431.

Screen: fixed a warning and gcc2 build.

Fix build.

Fix several issues in Screen preflet.

- Always initialize other menu item data member.
- Always use refresh_rate_to_string() to generate item labels.
- When searching for the item matching the selected refresh rate,
look for it by the actual refresh rate stored in the item's message
rather than by string comparisons of the label.
- Don't assume the Other menu item exists, since it doesn't in cases
where the refresh rate constraints only allow a single rate.
- Update copyright year.

Fixes #8431.

Make the Screen preference app windows non-resizable and make the top line of the screen BBox flush with the top line of the control BBox. Fixes #7526

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@43176 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Fixed missing initialization of fIsVesa, which should fix #7588.
+alpha


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41890 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Really, there is absolutely no need to pass the default argument to an
optional parameter...


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41349 a95241bf-73f2-0310-859d-f6bbb57e9c96

Use resource definition files instead of DoCatalogs rule. Rename B_TRANSLATE_APP_NAME and related macros to the more generic B_TRANSLATE_SYSTEM_NAME, to also fits add-ons, folders, etc, and make 'System name' its standard context. Change CodyCam and PoorMan's app signatures to match the overall x-vnd.Haiku-App pattern. Some clean-up. Make SlideShowSaver build again.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41103 a95241bf-73f2-0310-859d-f6bbb57e9c96

App name localization.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40980 a95241bf-73f2-0310-859d-f6bbb57e9c96

Localization-related fixes:
- unify the character case of the same looking strings;
- removed excessive translation for strings unvisible for end users;
- beginning spaces are handled outside of B_TRANSLATE;
- meaningful captions for warning Alerts.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40724 a95241bf-73f2-0310-859d-f6bbb57e9c96

Various build fixes.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40033 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by Mike Roll as part of GCI: localize Screen.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40027 a95241bf-73f2-0310-859d-f6bbb57e9c96

Update some apps/add-ons/preflets for impending changes to the layout API, specifically the layout builders. Also do a bit of style and layout cleanup in some places. This is part of #6407. Everything I've updated should look and function the same as it did before.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38064 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Patch by Humdinger to convert a lot of things to sentance case.
* Cleanup and update of all the touched catkeys files


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34731 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Also show the tool tip in case there is no monitor info, but still info about
the device.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34660 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Added info about the graphics device as suggested in #5112. However, it's
currently only shown in the monitor tool tip, that is now feels a bit crowded,
so a better solution would be nice. I'm hesitant to give it a more prominent
position, though, unless one has proof-read what the accelerants actually
return here.
* Added missing space between the serial number of the monitor and the date it
has been produced.
* Renamed fTempScreenMode to fUndoScreenMode, as it's only used to deliver that
functionality.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34659 a95241bf-73f2-0310-859d-f6bbb57e9c96

Updating some Preferences MIME signatures.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32509 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Even though it might be a bit too crowded, the monitor preview now also
shows the DPI of the chosen resolution. Better ideas welcome.
* Cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32302 a95241bf-73f2-0310-859d-f6bbb57e9c96

* If the user selected color space is not available for the selected resolution,
_CheckColorMenu() now selects the closest item available - if you switch back
the resolution to one that supports the original color space, it will be
restored. This fixes bug #2995.
* I also reverted r24674 as I remembered why I did that in the first place
(advertizing 24 bit modes as 32 bit), and it was a pretty stupid idea to
solve it like this, I must admit.
* Instead, the color space menu now only shows spaces that are actually
supported by the card at all. One could think about hiding 24 bit in case
both 24 bit, and 32 bit are available, but I didn't do that yet.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32179 a95241bf-73f2-0310-859d-f6bbb57e9c96

* The colors menu had "label from marked" activated, but then replaced its
label, causing bug #4193.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32176 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Now also puts the monitor's serial number and production date into the
tool tip (if available).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32144 a95241bf-73f2-0310-859d-f6bbb57e9c96

- Fix small typo.

Is it intentional that Horizontal Frequency is reported as being KHz while
Vertical Frequency is reported as being Hz?



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32104 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Added a tool tip for the monitor's capabilities.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32082 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Made the refresh slider/menu take the monitor's capabilities into account.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32048 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Made MonitorView better utilize the space it has.
* Less flickering.
* Reduced spacing in the left box.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32034 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Added a max resolution to MonitorView that can be chosen to define when it
should fill its space completely (which is now the maximal resolution that
can be chosen).
* Improved monitor info in case there is no name.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32033 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Now shows some info about the monitor if detected.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32030 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Now uses the layout engine instead of the home brewn thing.
* As a side effect, the window is now resizable, and also stores its window
size, not just its position.
* Replaced the old workspace count setter menu with column/row text controls.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@31972 a95241bf-73f2-0310-859d-f6bbb57e9c96

Implement the missing pieces to handle per workspace display mode support.
Adjust Workspace view to correctly scale each workspace based on the
resolution of that workspace. This exposes one or two anomalies in other
places in the app_server code though which I wasn't able to track down.
This fixes ticket #693.




git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28785 a95241bf-73f2-0310-859d-f6bbb57e9c96

some gcc4 warning fixes

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28207 a95241bf-73f2-0310-859d-f6bbb57e9c96

Applied patch by Jan Klötzke with some changes by myself:
* The vesa driver/accelerant supports mode switching now. No special handling
is needed anymore.
* Always write the vesa settings file to directly start with the right
resolution regardless of the used graphics driver. Should save an additional
mode switch while booting.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@25795 a95241bf-73f2-0310-859d-f6bbb57e9c96

fix misuse of ... with B_UTF8_ELLIPSIS


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@25261 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Now presents 24 bit modes as 32 bit modes to the user to avoid confusion.
* screen_mode will not make a difference between 32 and 24 bit anymore in the
equally operator.
* Some cards only support 24 bit instead of 32, for example Qemu VESA mode.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@24674 a95241bf-73f2-0310-859d-f6bbb57e9c96

* as discussed on the dev list, fixed revert and apply behaviour (tested
under vesa and supported mode). Changed message of the vesa warning
alert. TODO: additional warning text (see discussion)
* apply now stays deactivated if you only change the workspace count as
it is applied instantly already.
* disabled current workspace menu item for now since it is not
implemented. see ticket #696


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@24280 a95241bf-73f2-0310-859d-f6bbb57e9c96

Made the menu fields variable width again; it looked a bit ugly before to me.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@22734 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed bug #1016 ('Apply' button overlaying Video Format Popup menu).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20122 a95241bf-73f2-0310-859d-f6bbb57e9c96

Renamed SET_INITIAL_MODE_MSG to BUTTON_UNDO_MSG.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20101 a95241bf-73f2-0310-859d-f6bbb57e9c96

Made the Screen preflet's behavior consistent with the other preflets.
* Moved Apply button into controls box (resolution, etc.), so its meaning is more obvious.
* Revert now resets the whole screen settings for all workspaces to the configuration at the start of the preflet.
* In confirmation window, renamed Revert to Undo because that's what it actually does (it has nothing to do with the Revert in the main dialog).
* Disabled Defaults button (for now) since it doesn't use the screen's preferred settings and added a few TODOs.
* This should fix bug #321.
Note: Unfortunately, it won't work correctly on R5 because BScreen can only access the active workspace, it seems (locally, I used activate_workspace() for testing the preflet). Also, Haiku doesn't yet support setting screen preferences for each workspace individually, so I couldn't test it.
I hope my code isn't too terrible. :)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20096 a95241bf-73f2-0310-859d-f6bbb57e9c96

Now we also update the original preferences when multi-screen settings change.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20042 a95241bf-73f2-0310-859d-f6bbb57e9c96

Actually, the check isn't necessary because I'm not copying R5 behavior, anymore...I'm getting tired. :) Maybe I can checkin the Tracker fix, quickly.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20033 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed stupid logic mistake. Thanks for noticing, Axel!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20032 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Fixed a little bug that caused unnecessary mode changes when pressing Revert.
* Fixed compilation under R5.
* Made Revert more user-friendly by also allowing to revert settings to the previously active state after having pressed Apply. This only works if you didn't make new changes in the meantime. In that case, only the new changes will be reverted.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20031 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added special VESA mode support to the Screen preferences: the "Refresh Rate:" menu field
will be hidden, and on resolution change, you get a message that tells you that the change
will take effect with the next reboot.
The "vesa" mode file will be written on exit if any changes were made.
This closes bug #547.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19917 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed a small bug I found in the Screen preferences:

Now if the Backgrounds preferences app is already running clicking the
"Set Background..." button will activate it. Previously this was ignored
because the app was launched without checking the return code from be_roster.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19301 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Made the refresh selection window font sensitive.
* Nicer separation from RefreshSlider.
* Got rid of the RefreshView class (a BStringView does its job now).
* Cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17147 a95241bf-73f2-0310-859d-f6bbb57e9c96

* No longer ignores the screen refresh limits from the driver.
* Now builds under R5, but looks ugly (for testing only).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16877 a95241bf-73f2-0310-859d-f6bbb57e9c96

Filled the hole between 60 and 75 Hz for the refresh rates.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16875 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Reverting the screen mode now reverts to the one applied last, not the
one that was active when the application was launched (which was lost
on workspace change, anyway).
* Fixed on-screen centering of the AlertWindow.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16866 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Changed the signature of "Backgrounds" to follow how those signatures
are supposed to look like.
* Fixed Screen to have the correct signature for Backgrounds (had the
one from Be before).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16865 a95241bf-73f2-0310-859d-f6bbb57e9c96

* made the font of the "Set Background..." button
a little smaller, to lessen the importance of this
button.
* changed the "standard" frequencies. I hope this
doesn't have any negative impact on anything.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16434 a95241bf-73f2-0310-859d-f6bbb57e9c96

The "Screen" preferences application is no longer compatible to BeOS
(it could be built with minimal effort, but it looks awful since
BMenuFields are not resized correctly on R5).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16429 a95241bf-73f2-0310-859d-f6bbb57e9c96

* enjoy a fully font sensitive Screen preflet
* the Radeon specific controls are now layouted below
the other menu fields, it is easily changed back
to the side by side layout by changing the default
value of "sideBySide" for ScreenWindow::LayoutMenuFields()
* I added a "Set Background..." button, because I didn't
like the hidden functionality of the monitor view too
much. That is still there though.
* TODO: fix the awareness of changes to the workspace
count and include those in "reverting" and "defaults"


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16427 a95241bf-73f2-0310-859d-f6bbb57e9c96

The multi-monitor settings now also look okay. Still needs some work, though, and
a new layout as well.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@15710 a95241bf-73f2-0310-859d-f6bbb57e9c96

The aspect ratio of the monitor is now independent of the size of the MonitorView's bounds.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@15704 a95241bf-73f2-0310-859d-f6bbb57e9c96

First baby steps into a font sensitive interface. At least it now looks good when
runnning under Haiku :)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@15703 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed PostMessage usage

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@15663 a95241bf-73f2-0310-859d-f6bbb57e9c96

No longer ignores a failing SetMode() but will show an error request.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@14936 a95241bf-73f2-0310-859d-f6bbb57e9c96

Renamed src/prefs to "preferences", as the directory is usually called in BeOS.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@13263 a95241bf-73f2-0310-859d-f6bbb57e9c96

Screen: improved window position, fixed empty line.

* The monitor size now scales with the font size.
* It now uses BWindow::MoveOnScreen() to find a good position on screen.
* The monitor info is now properly hidden when there is no info (this
removes a blank line at the top of the left box).

Screen: Rework AlertView to just use BAlert.

Fixes #12330.

Split BSpinner into BAbstractSpinner and...

2 concrete classes which are currently implemented:
* BSpinner (works on int32s)
* BDecimalSpinner (works on doubles)

In addition BAbstractSpinner now inherits from BControl instead of
BView/BInvoker. This allowed for code simplification at the cost of needing to
cast for the decimal version because SetValue(int32 value) comes from BControl.

Also, add a spinner_button_style enum with 3 options:
* SPINNER_BUTTON_HORIZONTAL_ARROWS
* SPINNER_BUTTON_VERTICAL_ARROWS
* SPINNER_BUTTON_PLUS_MINUS

which sets the spinner arrows to either use horizontal arrows (left/right)
vertical arrows, (up/down), or +/- symbols (the default).

If the spinner button is using horizontal arrows you can decrement and increment
the spinner value by pushing control+left/right, otherwise you can increment and
decrement by pushing up or down. The reason for needing control is so that you
can move the cursor in the textbox otherwise.

Switch the 3 apps that are currently using BSpinners to use the integer variety
in Deskbar preferences, WebPostive preferences, and Screen preferences.

Update Screen prefs to use BSpinner class

Screen: disable Apply button when no changes would be made.

* Previously this would work only in "current workspace" mode.
* Also avoid calling count_workspaces in a loop since its result is not
cached and it needs to ask app_server each time.
* Fixes #4231.

Signed-off-by: Adrien Destugues <pulkomandy@gmail.com>

Screen prefs: force weight of the two boxes

Depending on the locale and string length the layout could leave only a
small part of the window for the rightmost part, which is the important
thing. Force the weight of each side so we have a more balanced window.

Screen prefs: move driver info to main window

* Fixes relevant part of #5125
* The remaining information (serial number, frequency ranges) is
"advanced" and can be hidden in the tooltip. However, the video driver
used may be important important information, if you want to know if you
are using VESA, or if you have multiple video cards (Optimus for
example).

include strings.h where appriopriate...

instead or additionally to string.h, in preparation for functions move.
* moves str[n]casecmp() functions and others to strings.h.
* strings.h doesn't include string.h anymore.
* this solves #10949

Use UTF-8 minus sign instead of dash

Screen prefs: Use menu field layout methods

... to layout the menu field label and menu in the grid. This makes
the label and grid layout correctly, the AddMenuField() method should
be deprecated or fixed as it lays out the menu field differently.

Also replace numeric spacing units with font relative spacing units.

Revert to manually offsetting the BBox in BScreen.

Take this opportunity to reapply this hack in a much nicer way.

Before the hack included the default margins, now it doesn't.

Should be back to normal, sorry for the noise.

Screen: Undo hack to line up the top borders of the BBox's

Also, use font relative spacing units

Update screen prefs layout. Fixes #8817

* Center monitor info and Workspaces label.
* Use font-relative spacing.
* Update the header including copyright year, sort contributors by name and add
myself as well.

Style fixes only.

When the workspace changes use the passed in workspace screen mode

...instead of the current workspace screen mode that we are switching from.
Fixes #9415
Also don't ignore the returned the status code when updating the screen mode.

Added more things to x86_64 image.

Some preference apps, mount_server and AboutSystem. Removed the check
for x86_64 in the boot script, the normal path through the script will
work now. Also removed a temporary hack to workaround AboutSystem not
being there in build_haiku_image.

Close alerts with ESCAPE key.

Added SetFlags(B_CLOSE_ON_ESCAPE) or SetShortcut(index, B_ESCAPE) to BAlerts
depending if the result gets used later in the code, or if it's a one-button
BAlert.

More catalog-related cleanup.

* rename B_TRANSLATE_CONTEXT to B_TRANSLATION_CONTEXT and
B_TRANSLATE_WITH_CONTEXT to B_TRANSLATE_CONTEXT, squashing a TODO
* adjust all uses of both macros in Haiku's source tree
* use correct header guard for collecting/Catalog.h

The renamed macros require adjustments to all external applications
using catalogs.

Fix incorrect error check.

The case where GetRefreshLimits() failed wasn't being detected and
handled correctly.

Fix crashing corner case in screen prefs.

If the refresh limits only allowed a single refresh, the menu item constructed
had no BMessage. This caused _UpdateRefreshControls() to crash when attempting
to match the current refresh rate to the item. For simplicity, give it a message
containing the fixed refresh rate just as in all other cases. Should finally
fix #8431.

Screen: fixed a warning and gcc2 build.

Fix build.

Fix several issues in Screen preflet.

- Always initialize other menu item data member.
- Always use refresh_rate_to_string() to generate item labels.
- When searching for the item matching the selected refresh rate,
look for it by the actual refresh rate stored in the item's message
rather than by string comparisons of the label.
- Don't assume the Other menu item exists, since it doesn't in cases
where the refresh rate constraints only allow a single rate.
- Update copyright year.

Fixes #8431.

Make the Screen preference app windows non-resizable and make the top line of the screen BBox flush with the top line of the control BBox. Fixes #7526

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@43176 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Fixed missing initialization of fIsVesa, which should fix #7588.
+alpha


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41890 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Really, there is absolutely no need to pass the default argument to an
optional parameter...


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41349 a95241bf-73f2-0310-859d-f6bbb57e9c96

Use resource definition files instead of DoCatalogs rule. Rename B_TRANSLATE_APP_NAME and related macros to the more generic B_TRANSLATE_SYSTEM_NAME, to also fits add-ons, folders, etc, and make 'System name' its standard context. Change CodyCam and PoorMan's app signatures to match the overall x-vnd.Haiku-App pattern. Some clean-up. Make SlideShowSaver build again.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41103 a95241bf-73f2-0310-859d-f6bbb57e9c96

App name localization.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40980 a95241bf-73f2-0310-859d-f6bbb57e9c96

Localization-related fixes:
- unify the character case of the same looking strings;
- removed excessive translation for strings unvisible for end users;
- beginning spaces are handled outside of B_TRANSLATE;
- meaningful captions for warning Alerts.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40724 a95241bf-73f2-0310-859d-f6bbb57e9c96

Various build fixes.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40033 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by Mike Roll as part of GCI: localize Screen.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40027 a95241bf-73f2-0310-859d-f6bbb57e9c96

Update some apps/add-ons/preflets for impending changes to the layout API, specifically the layout builders. Also do a bit of style and layout cleanup in some places. This is part of #6407. Everything I've updated should look and function the same as it did before.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38064 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Patch by Humdinger to convert a lot of things to sentance case.
* Cleanup and update of all the touched catkeys files


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34731 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Also show the tool tip in case there is no monitor info, but still info about
the device.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34660 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Added info about the graphics device as suggested in #5112. However, it's
currently only shown in the monitor tool tip, that is now feels a bit crowded,
so a better solution would be nice. I'm hesitant to give it a more prominent
position, though, unless one has proof-read what the accelerants actually
return here.
* Added missing space between the serial number of the monitor and the date it
has been produced.
* Renamed fTempScreenMode to fUndoScreenMode, as it's only used to deliver that
functionality.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34659 a95241bf-73f2-0310-859d-f6bbb57e9c96

Updating some Preferences MIME signatures.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32509 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Even though it might be a bit too crowded, the monitor preview now also
shows the DPI of the chosen resolution. Better ideas welcome.
* Cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32302 a95241bf-73f2-0310-859d-f6bbb57e9c96

* If the user selected color space is not available for the selected resolution,
_CheckColorMenu() now selects the closest item available - if you switch back
the resolution to one that supports the original color space, it will be
restored. This fixes bug #2995.
* I also reverted r24674 as I remembered why I did that in the first place
(advertizing 24 bit modes as 32 bit), and it was a pretty stupid idea to
solve it like this, I must admit.
* Instead, the color space menu now only shows spaces that are actually
supported by the card at all. One could think about hiding 24 bit in case
both 24 bit, and 32 bit are available, but I didn't do that yet.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32179 a95241bf-73f2-0310-859d-f6bbb57e9c96

* The colors menu had "label from marked" activated, but then replaced its
label, causing bug #4193.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32176 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Now also puts the monitor's serial number and production date into the
tool tip (if available).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32144 a95241bf-73f2-0310-859d-f6bbb57e9c96

- Fix small typo.

Is it intentional that Horizontal Frequency is reported as being KHz while
Vertical Frequency is reported as being Hz?



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32104 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Added a tool tip for the monitor's capabilities.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32082 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Made the refresh slider/menu take the monitor's capabilities into account.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32048 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Made MonitorView better utilize the space it has.
* Less flickering.
* Reduced spacing in the left box.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32034 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Added a max resolution to MonitorView that can be chosen to define when it
should fill its space completely (which is now the maximal resolution that
can be chosen).
* Improved monitor info in case there is no name.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32033 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Now shows some info about the monitor if detected.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32030 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Now uses the layout engine instead of the home brewn thing.
* As a side effect, the window is now resizable, and also stores its window
size, not just its position.
* Replaced the old workspace count setter menu with column/row text controls.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@31972 a95241bf-73f2-0310-859d-f6bbb57e9c96

Implement the missing pieces to handle per workspace display mode support.
Adjust Workspace view to correctly scale each workspace based on the
resolution of that workspace. This exposes one or two anomalies in other
places in the app_server code though which I wasn't able to track down.
This fixes ticket #693.




git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28785 a95241bf-73f2-0310-859d-f6bbb57e9c96

some gcc4 warning fixes

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28207 a95241bf-73f2-0310-859d-f6bbb57e9c96

Applied patch by Jan Klötzke with some changes by myself:
* The vesa driver/accelerant supports mode switching now. No special handling
is needed anymore.
* Always write the vesa settings file to directly start with the right
resolution regardless of the used graphics driver. Should save an additional
mode switch while booting.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@25795 a95241bf-73f2-0310-859d-f6bbb57e9c96

fix misuse of ... with B_UTF8_ELLIPSIS


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@25261 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Now presents 24 bit modes as 32 bit modes to the user to avoid confusion.
* screen_mode will not make a difference between 32 and 24 bit anymore in the
equally operator.
* Some cards only support 24 bit instead of 32, for example Qemu VESA mode.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@24674 a95241bf-73f2-0310-859d-f6bbb57e9c96

* as discussed on the dev list, fixed revert and apply behaviour (tested
under vesa and supported mode). Changed message of the vesa warning
alert. TODO: additional warning text (see discussion)
* apply now stays deactivated if you only change the workspace count as
it is applied instantly already.
* disabled current workspace menu item for now since it is not
implemented. see ticket #696


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@24280 a95241bf-73f2-0310-859d-f6bbb57e9c96

Made the menu fields variable width again; it looked a bit ugly before to me.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@22734 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed bug #1016 ('Apply' button overlaying Video Format Popup menu).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20122 a95241bf-73f2-0310-859d-f6bbb57e9c96

Renamed SET_INITIAL_MODE_MSG to BUTTON_UNDO_MSG.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20101 a95241bf-73f2-0310-859d-f6bbb57e9c96

Made the Screen preflet's behavior consistent with the other preflets.
* Moved Apply button into controls box (resolution, etc.), so its meaning is more obvious.
* Revert now resets the whole screen settings for all workspaces to the configuration at the start of the preflet.
* In confirmation window, renamed Revert to Undo because that's what it actually does (it has nothing to do with the Revert in the main dialog).
* Disabled Defaults button (for now) since it doesn't use the screen's preferred settings and added a few TODOs.
* This should fix bug #321.
Note: Unfortunately, it won't work correctly on R5 because BScreen can only access the active workspace, it seems (locally, I used activate_workspace() for testing the preflet). Also, Haiku doesn't yet support setting screen preferences for each workspace individually, so I couldn't test it.
I hope my code isn't too terrible. :)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20096 a95241bf-73f2-0310-859d-f6bbb57e9c96

Now we also update the original preferences when multi-screen settings change.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20042 a95241bf-73f2-0310-859d-f6bbb57e9c96

Actually, the check isn't necessary because I'm not copying R5 behavior, anymore...I'm getting tired. :) Maybe I can checkin the Tracker fix, quickly.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20033 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed stupid logic mistake. Thanks for noticing, Axel!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20032 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Fixed a little bug that caused unnecessary mode changes when pressing Revert.
* Fixed compilation under R5.
* Made Revert more user-friendly by also allowing to revert settings to the previously active state after having pressed Apply. This only works if you didn't make new changes in the meantime. In that case, only the new changes will be reverted.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20031 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added special VESA mode support to the Screen preferences: the "Refresh Rate:" menu field
will be hidden, and on resolution change, you get a message that tells you that the change
will take effect with the next reboot.
The "vesa" mode file will be written on exit if any changes were made.
This closes bug #547.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19917 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed a small bug I found in the Screen preferences:

Now if the Backgrounds preferences app is already running clicking the
"Set Background..." button will activate it. Previously this was ignored
because the app was launched without checking the return code from be_roster.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19301 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Made the refresh selection window font sensitive.
* Nicer separation from RefreshSlider.
* Got rid of the RefreshView class (a BStringView does its job now).
* Cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17147 a95241bf-73f2-0310-859d-f6bbb57e9c96

* No longer ignores the screen refresh limits from the driver.
* Now builds under R5, but looks ugly (for testing only).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16877 a95241bf-73f2-0310-859d-f6bbb57e9c96

Filled the hole between 60 and 75 Hz for the refresh rates.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16875 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Reverting the screen mode now reverts to the one applied last, not the
one that was active when the application was launched (which was lost
on workspace change, anyway).
* Fixed on-screen centering of the AlertWindow.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16866 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Changed the signature of "Backgrounds" to follow how those signatures
are supposed to look like.
* Fixed Screen to have the correct signature for Backgrounds (had the
one from Be before).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16865 a95241bf-73f2-0310-859d-f6bbb57e9c96

* made the font of the "Set Background..." button
a little smaller, to lessen the importance of this
button.
* changed the "standard" frequencies. I hope this
doesn't have any negative impact on anything.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16434 a95241bf-73f2-0310-859d-f6bbb57e9c96

The "Screen" preferences application is no longer compatible to BeOS
(it could be built with minimal effort, but it looks awful since
BMenuFields are not resized correctly on R5).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16429 a95241bf-73f2-0310-859d-f6bbb57e9c96

* enjoy a fully font sensitive Screen preflet
* the Radeon specific controls are now layouted below
the other menu fields, it is easily changed back
to the side by side layout by changing the default
value of "sideBySide" for ScreenWindow::LayoutMenuFields()
* I added a "Set Background..." button, because I didn't
like the hidden functionality of the monitor view too
much. That is still there though.
* TODO: fix the awareness of changes to the workspace
count and include those in "reverting" and "defaults"


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16427 a95241bf-73f2-0310-859d-f6bbb57e9c96

The multi-monitor settings now also look okay. Still needs some work, though, and
a new layout as well.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@15710 a95241bf-73f2-0310-859d-f6bbb57e9c96

The aspect ratio of the monitor is now independent of the size of the MonitorView's bounds.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@15704 a95241bf-73f2-0310-859d-f6bbb57e9c96

First baby steps into a font sensitive interface. At least it now looks good when
runnning under Haiku :)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@15703 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed PostMessage usage

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@15663 a95241bf-73f2-0310-859d-f6bbb57e9c96

No longer ignores a failing SetMode() but will show an error request.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@14936 a95241bf-73f2-0310-859d-f6bbb57e9c96

Renamed src/prefs to "preferences", as the directory is usually called in BeOS.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@13263 a95241bf-73f2-0310-859d-f6bbb57e9c96