History log of /haiku/src/preferences/input/MouseView.cpp
Revision Date Author Comments
# 02dabf4b 29-Mar-2021 Saloni <saloniggoyal@gmail.com>

input preferences: Updates code according to Haiku guidelines

These are the changes using tool clang-format with argument --style=haiku and the changes that were not according to guidelines have been removed.

Change-Id: I2d34370e1e0a112da895001bd220bb82b7086e90
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3827
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>


# 9aea709d 03-Sep-2020 Adrien Destugues <pulkomandy@pulkomandy.tk>

Input prefs: handle errors

Various error handling cases were missing, which would lead to corrupt
settings and crashes. Add the missing error checks and make sure we
always revert to sane settings in case of problems.

Change-Id: Ib72621d6e4974345f5f6ee88e01a918cbf09d7ea
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3069
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>


# 02ad22d6 04-Aug-2020 Preetpal Kaur <preetpalok123@gmail.com>

Input: declare BString to get the Mouse Name

Change-Id: I3476f58839202a6fd8c93e325a15045963a9b7b2
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3125
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>


# 213e62a7 28-Jun-2020 X512 <danger_mail@list.ru>

Input: fix MouseView drawing

BeginPicture/EndPicture do not save state so origin should be restored
after recording picture. BView::Draw use PushState internally so origin
is added and cause problem.

hrev54347 fixed behavior when recording picture so state change is
affected. It revealed #16317 bug.

Fixes #16317.

Change-Id: Iee69631ce83fea5ea73c99b492b8cf67d1b148c7
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2960
Reviewed-by: waddlesplash <waddlesplash@gmail.com>


# abbd654b 24-Apr-2020 Preetpal Kaur <preetpalok123@gmail.com>

Added 6th button in Mouse GUI

- Correct button size of 4 and 5 buttons in Mouse GUI.
- Button number are in squence now, added the default values.

Change-Id: I915077d11f9212c47c782fd9296b9f5b8909ed09
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2509
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>


# 3268566c 03-May-2020 Adrien Destugues <pulkomandy@pulkomandy.tk>

Input: fix infinite loop

Right shift on a signed value can extend the sign bit, which would make
this function do an infinite loop if passed a negative value. Use an
unsigned instead to get the behavior we want.

Fixes #15957, but this means we're using undefined data from the
settings file. I assumed it would have the unused button values set to 0
but this isn't apparently the case. Preetpal is already working on that
as we noticed the problem when testing her patch for adding a 6th
button.

Change-Id: I62fdc778ff3b9da92f3aa5570163dc60baf8cf2c
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2560
Reviewed-by: waddlesplash <waddlesplash@gmail.com>


# 5bbf7f1b 05-Feb-2020 Adrien Destugues <pulkomandy@pulkomandy.tk>

Actually handle more than 3 mouse buttons

The code in input_server was pretty much all set for this, but there was
no way to configure the extra buttons. Add them to the mouse view in
Input preferences (up to 5 buttons are handled now)

Define a new B_MOUSE_BUTTON(n) macro to generate the bitmask for a given
button (numbered from 1).

Change-Id: I9091082277937d89b08464ff474e7bbb5db82401
Reviewed-on: https://review.haiku-os.org/c/haiku/+/180
Reviewed-by: waddlesplash <waddlesplash@gmail.com>


# 8272123e 17-Jul-2019 Preetpal Kaur <preetpalok123@gmail.com>

Connected Devices: Mouse, Touchpad and Keyboard

-Resolve some issues.
-Added the connected devices code in the main window.
-Replace BUTTON_DEFAULTS and BUTTON_REVERT with kMsgDefaults and kMsgRevert.

Change-Id: I3b0c86fc581056859239df0fbf2c085b8d168136
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1619
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>


# 5e9685ca 01-May-2019 Preetpal Kaur <preetpalok123@gmail.com>

Completed Mouse and Touchppad preferences

Complete working and view of pointing devices(mouse and touchpad).

Resolve some issues.
Added the Jamfile

Change-Id: I4db021cb8c63971e5af60bd254c8b3b588d023e9
Reviewed-on: https://review.haiku-os.org/c/1426
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>