FileTypes: Renamed some IconView members to avoid confusion

* fIcon -> fIconBitmap
* fIcanData -> fIcon
* Minor style fixes.

Change-Id: I16a99b41698824dacfe694d87826c137fa76dcbe
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7546
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>

FileTypes: Refactor icon handling to use BControlLook::ComposeIconSize().

Fixes #17907.

* fixed all warnings in FileTypes preflet and enabled -Werror

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38199 a95241bf-73f2-0310-859d-f6bbb57e9c96

* style adjustments - no functional change

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38197 a95241bf-73f2-0310-859d-f6bbb57e9c96

CID 1318: IconView::Invoke() should match BControl::Invoke() signature.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37965 a95241bf-73f2-0310-859d-f6bbb57e9c96

Puh... basically this is the patch by "yourpalal" from ticket #5690, which
converts the FileTypes preflet to use layout management. However, I had to
revert r36252, apply the patch and then manually add r36252 back on top.
I have fixed issues both in the layout management patch (broken layout
in the ApplicationTypesWindow) as well as the translation (untranslated labels
in alerts) and other problems with composed strings (one problem remains, but
already had a TODO). However, the hard work was taken care of by yourpalal!
Thanks a bunch!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36405 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Fixed a memory leak when creating the drag bitmap.
* Added an optional modification message that is triggered whenever the
view adopts a new icon.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28178 a95241bf-73f2-0310-859d-f6bbb57e9c96

* TypeIconView now inherits from IconView and only adds the icon source label
to it - it also inherits all the features like drag&drop, of course.
* IconView now inherits from BControl instead of BView, might need some more
work to properly handle the invocation message stuff, though.
* The "Remove Icon" menu item was always enabled, no matter if there was an
icon or not; also it was not properly detected wether or not a MIME type
had an icon when building the menu.
* Dragging in MIME type mode now works as well.
* Added some getter methods to the IconView to retrieve the data it has.
* Some other cleanup, like adding missing consts.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19299 a95241bf-73f2-0310-859d-f6bbb57e9c96

IconView can now also be set to a MIME type instead of a file or a buffer.
Untested actually, but FileTypesWindow's TypeIconView will be merged to this
one soon.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19298 a95241bf-73f2-0310-859d-f6bbb57e9c96

When dragging an icon into an icon view that gets its icon from its MIME type,
the vector icon is now retrieved as well.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19296 a95241bf-73f2-0310-859d-f6bbb57e9c96

* The IconView is now keyboard navigable, and can be invoked (via the enter key),
or the current icon be deleted (using the delete key).
* Drag&drop between IconViews should now also work as expected for all icon
types (only the large icon was taken into consideration before).
* Improved error handling in the Icon::CopyTo() methods


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19293 a95241bf-73f2-0310-859d-f6bbb57e9c96

Moved icon_for_type() to IconView.cpp.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19283 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Extended the IconView quite a bit to support what we need:
- supports drag&drop from icons (only tested for non-vector icons yet)
- allows to remove/edit/add icons (there is still need for support in Icon-O-Matic
for this to work completely)
- has a mode where it stores the changed icon data in an object rather than
directly to disk; this object can maintain all BeOS icon types
- reacts to live updates from file icons
- supports different view sizes (for later or uses in other apps)
* works again on BeOS (it crashed before because of a BeOS "feature").
* in the Application window, the "supported types" listview will now be enlarged
with the window instead of the long version description.
* To compensate for that, the latter now shows a scroll bar.
* Application delivered supported type icons are now shown as well, and can
be edited - they're not yet saved, though.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19279 a95241bf-73f2-0310-859d-f6bbb57e9c96

Beginnings of the application type window - doesn't do anything yet, but at
least it looks more or less okay (long description border isn't right yet)
and is font sensitive.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16632 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Added an icon view to the file type window.
* Renamed the IconView class in the FileTypesWindow to TypeIconView.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16618 a95241bf-73f2-0310-859d-f6bbb57e9c96

* fixed all warnings in FileTypes preflet and enabled -Werror

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38199 a95241bf-73f2-0310-859d-f6bbb57e9c96

* style adjustments - no functional change

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38197 a95241bf-73f2-0310-859d-f6bbb57e9c96

CID 1318: IconView::Invoke() should match BControl::Invoke() signature.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37965 a95241bf-73f2-0310-859d-f6bbb57e9c96

Puh... basically this is the patch by "yourpalal" from ticket #5690, which
converts the FileTypes preflet to use layout management. However, I had to
revert r36252, apply the patch and then manually add r36252 back on top.
I have fixed issues both in the layout management patch (broken layout
in the ApplicationTypesWindow) as well as the translation (untranslated labels
in alerts) and other problems with composed strings (one problem remains, but
already had a TODO). However, the hard work was taken care of by yourpalal!
Thanks a bunch!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36405 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Fixed a memory leak when creating the drag bitmap.
* Added an optional modification message that is triggered whenever the
view adopts a new icon.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28178 a95241bf-73f2-0310-859d-f6bbb57e9c96

* TypeIconView now inherits from IconView and only adds the icon source label
to it - it also inherits all the features like drag&drop, of course.
* IconView now inherits from BControl instead of BView, might need some more
work to properly handle the invocation message stuff, though.
* The "Remove Icon" menu item was always enabled, no matter if there was an
icon or not; also it was not properly detected wether or not a MIME type
had an icon when building the menu.
* Dragging in MIME type mode now works as well.
* Added some getter methods to the IconView to retrieve the data it has.
* Some other cleanup, like adding missing consts.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19299 a95241bf-73f2-0310-859d-f6bbb57e9c96

IconView can now also be set to a MIME type instead of a file or a buffer.
Untested actually, but FileTypesWindow's TypeIconView will be merged to this
one soon.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19298 a95241bf-73f2-0310-859d-f6bbb57e9c96

When dragging an icon into an icon view that gets its icon from its MIME type,
the vector icon is now retrieved as well.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19296 a95241bf-73f2-0310-859d-f6bbb57e9c96

* The IconView is now keyboard navigable, and can be invoked (via the enter key),
or the current icon be deleted (using the delete key).
* Drag&drop between IconViews should now also work as expected for all icon
types (only the large icon was taken into consideration before).
* Improved error handling in the Icon::CopyTo() methods


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19293 a95241bf-73f2-0310-859d-f6bbb57e9c96

Moved icon_for_type() to IconView.cpp.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19283 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Extended the IconView quite a bit to support what we need:
- supports drag&drop from icons (only tested for non-vector icons yet)
- allows to remove/edit/add icons (there is still need for support in Icon-O-Matic
for this to work completely)
- has a mode where it stores the changed icon data in an object rather than
directly to disk; this object can maintain all BeOS icon types
- reacts to live updates from file icons
- supports different view sizes (for later or uses in other apps)
* works again on BeOS (it crashed before because of a BeOS "feature").
* in the Application window, the "supported types" listview will now be enlarged
with the window instead of the long version description.
* To compensate for that, the latter now shows a scroll bar.
* Application delivered supported type icons are now shown as well, and can
be edited - they're not yet saved, though.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19279 a95241bf-73f2-0310-859d-f6bbb57e9c96

Beginnings of the application type window - doesn't do anything yet, but at
least it looks more or less okay (long description border isn't right yet)
and is font sensitive.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16632 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Added an icon view to the file type window.
* Renamed the IconView class in the FileTypesWindow to TypeIconView.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16618 a95241bf-73f2-0310-859d-f6bbb57e9c96