Appearance: Store decorator filename to disk untranslated

Save ShortcutName() (i.e. filename) instead of the potentially
translated decorator Name(). If the decorator has no ref but
fInitStatus is B_OK and fPath == "Default" return Default
decorator in ShortcutName(). The Default decorator unlike other
decorators has no file on disk associated with it.

We don't need to look for ShortcutName() when iterating through
decorators anymore because we look for "Default" then file names
before we try to find by name.

Fixes #16412

Change-Id: I3109681d11931e7f55b7afaf3a65af2fb9ed5e10
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4320
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>

Appearance Prefs: Remember saved Decorator and ControlLook setting

... and make the Defaults and Revert buttons revert back to the
default/saved decorator and control look.

Add private _SetControlLook() method to set the control look which is
the equivalent of _SetDecor() but for control looks.

The person who implemented the ControlLook menu field made it so that
it would truncate the trailing "ControlLook" from the control look name,
do the same for Decorators so that BeDecorator is listed as simply "Be"
in the menu field. This is an alteration to the menu item label only and
does not affect the name of the decorator or control look.

Add private _DecorLabel() and _ControlLookLabel() methods to build
the truncated Decorator and ControlLook menu item labels respectively.

Set the current and saved decorator and control look in the constructor
and get rid of some private setter methods _AdoptToCurrentDecor() and
_AdoptInterfaceToCurrentDecor() that are no longer needed. These actions
are now done exclusively in the constructor and _SetDecor() respectively.

Remove unused knob style message constants (for now...)

Update copyright year to 2020

Change-Id: I0444a6198116d7699a84487cf97e9d826b14d1cb
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2315
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>

Appearance Prefs: style fixes to LookAndFeelSettings only

msg => message
pointer style
80 char limit fixes
Rename variable newControlLook => controlLook
Add #pragma descriptor comments.
Replace for (; condition;) loop with a while loop
Initialize count outside a different for loop
Change iterator variable i type from int => int32 (not purely style.)
2 lines of whitespace before ending header guard
Alphabetize (my) author name below Ryan Leavengood in header top comment

No functional change intended in this commit except for int => int32.

Change-Id: Ic78e3b0c85207ba07a3a71696d741344e148ac9d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2317
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>

Appearance: Add a ControlLook MenuField

Change-Id: If815fa6a864d2a916eb1ae878400d342f666e3d2
Reviewed-on: https://review.haiku-os.org/c/1434
Reviewed-by: waddlesplash <waddlesplash@gmail.com>

src/preferences Code formatting

* No functional change

code formatting changes only

Change-Id: Id861adea9266a9ccbf9925d36e4a2bad85b640b7
Reviewed-on: https://review.haiku-os.org/c/895
Reviewed-by: waddlesplash <waddlesplash@gmail.com>

Revert "Appearance Prefs: Add scroll bar knob setting"

This reverts commit 0988f80fed032d45efed92734f9487daa55d4e09.

Change-Id: I60ec2b05a7c66e3c3c8f18dc821d6213934b0cfb

Appearance Prefs: Add scroll bar knob setting

Check values before setting them in SetFromScrollBarInfo

Pin arrow and knob settings to the top so they are aligned
Adjust vertical spacing on single/double to match knob style height

Only draw arrows on single/double FakeScrollBar

Change-Id: I6be89f86181a87808ba5201caf88a33c4414d4c8

preferences: Convert to using Set*UIColor.

Signed-off-by: Augustin Cavalier <waddlesplash@gmail.com>
Patches 0023-0037 from looncraz, unmodified.

Improve/fix tab view layout as discussed

See http://www.freelists.org/post/haiku-development/Unifying-visuals-of-BTabView-usage

Besides the tab bar going the full width of the window, also some
layouting tweaks to several apps and prefs.

Still missing: the first (and last) tabs in the tab bar should be inset by
B_USE_WINDOW_SPACING so the controls in the tab view line up nicely.
I think I remember stippi wanting to look into it... :)

Fix translation for "Scroll bar:" on Look and Feel panel.

Signed-off-by: Matt Madia <mattmadia@gmail.com>

Aesthetical changes. No functional change.

Manually applied humdinger's Decorator_aesthetics.diff patch from #7874.

Compilation fixes for x86_64.

Remove the scroll bar knobs and corresponding setting

Variable name cleanup

Change SCROLL_KNOB_* constants to B_SCROLL_KNOB_*

Scroll bars is 2 words

Line the boxes up, at least for the default font size

Allow the user to select the scrollbar setting graphically.

This uses custom controls to allow the user to choose between
single and double arrows and none, dots, or line knob styles
in a graphical fashion copied from BeOS Scrollbar preflet.

Rename DecorSettingsView to LookAndFeelSettingsView.

Fix translation for "Scroll bar:" on Look and Feel panel.

Signed-off-by: Matt Madia <mattmadia@gmail.com>

Aesthetical changes. No functional change.

Manually applied humdinger's Decorator_aesthetics.diff patch from #7874.

Compilation fixes for x86_64.

Remove the scroll bar knobs and corresponding setting

Variable name cleanup

Change SCROLL_KNOB_* constants to B_SCROLL_KNOB_*

Scroll bars is 2 words

Line the boxes up, at least for the default font size

Allow the user to select the scrollbar setting graphically.

This uses custom controls to allow the user to choose between
single and double arrows and none, dots, or line knob styles
in a graphical fashion copied from BeOS Scrollbar preflet.

Rename DecorSettingsView to LookAndFeelSettingsView.