History log of /haiku/src/kits/network/libnetapi/NetAddress.cpp
Revision Date Author Comments
# f16cf073 18-Aug-2012 Alex Smith <alex@alex-smith.me.uk>

CID 714526: Operands don't affect result.

Incorrect check of in_addr_t (uint32_t) against (unsigned long)-1
would never be true.


# c91bc0e1 29-Sep-2009 Michael Lotz <mmlr@mlotz.ch>

Style cleanups, spacing, pointer style.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33352 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 49714746 29-Sep-2009 Michael Lotz <mmlr@mlotz.ch>

Space indent -> tab indent.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33351 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 49a22456 13-Jul-2008 Oliver Tappe <zooey@hirschkaefer.de>

Overhauled BNetEndpoint implementation (and BNetAddress, too):
* added NetEndpointTest that exposed a couple of bugs
* fixed several bugs in the implementation of BNetEndpoint, some of which kept
NetPenguin from working
* fixed a couple of constness issues in BNetEndpoint and BNetAddress


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26405 a95241bf-73f2-0310-859d-f6bbb57e9c96


# aebcc506 10-Jul-2008 Oliver Tappe <zooey@hirschkaefer.de>

Corrected by previous assumption, since gethostbyname() has nothing to do with
struct sockaddr_in - the real culprits were BNetAddress::GetAddr(sockaddr_in&)
and BNetAddress::SetTo(const sockaddr_in&):
* moved check_r5_compatibility() into r5_compatibility.h to make that function
available to BNetAddress, too
* adjusted sockaddr_in-handling methods of BNetAddress to deal with R5-addresses
if in compatibility mode
* removed is_r5_sockaddr() again, since it is no longer needed

With this less hacky solution, Beam, NetPositive, NetworkTime and Vision still work. So, there's hope that the R5 compatibility layer is now complete.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26377 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 1aa3d2e3 05-Jul-2008 Oliver Tappe <zooey@hirschkaefer.de>

Resolved a couple of problems in BNetAddress implementation:
* fixed several byte order inconsistencies, it does not make sense to always
convert the byte order input/output values - no we convert where it can
be expected and leave it where it is confusing
* fixed size inconsistencies with respect to family and port, both of which
were sometimes handled as int8, as int16 and as int32 in different places
(now they are always int16)
These fixes make Beam connect to the correct address and port, but it still doesn't work, as it seems to be using UDP instead of TCP (doh!). Will look into that tomorrow.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26269 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 241b0480 28-Aug-2006 Axel Dörfler <axeld@pinc-software.de>

* Fixed build of libnetapi.so - it probably won't work for now, though, have a look
at the comment in r5_compatibility.h.
* Intentionally broke source compatibility and removed all that outdated Nettle stuff.
* Also, I took the liberty of making m_init private and rename it to fInit - again, this
will only affect source compatibility.
* Rewrote NetEndpoint.h
* Fixed quite a few small bugs around the code that I touched, for example in NetAddress,
SetTo() never set fInit, and therefore could be wrong.
* Some cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18680 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 6fdccb80 28-Aug-2006 Axel Dörfler <axeld@pinc-software.de>

Moved libnetapi.so sources into the src/kit/net/ directory - they don't yet build, though.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18678 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 67b376e9 26-Nov-2005 Waldemar Kornewald <wkornew@nowhere.fake>

Moved our networking libraries to src/kits/network/compat. We want to have our own, clean libnetwork.so.

TODO: move all public networking headers to some other place (compat or headers/legacy?) and replace the current headers with clean versions from FreeBSD and BIND 9.3.1
TODO: remove R5 target support


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@15169 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 4907c35b 15-Oct-2004 Philippe Houdoin <philippe.houdoin@gmail.com>

Fixed a warning.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@9366 a95241bf-73f2-0310-859d-f6bbb57e9c96


# f1d8cfb4 03-Oct-2004 Philippe Houdoin <philippe.houdoin@gmail.com>

TODO comment commit ;-)


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@9168 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 665b241c 16-Dec-2002 Philippe Houdoin <philippe.houdoin@gmail.com>

Checked-in updated implementation of these classes written by
Scott Mansfield.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@2263 a95241bf-73f2-0310-859d-f6bbb57e9c96


# ae0638a6 31-Oct-2002 Philippe Houdoin <philippe.houdoin@gmail.com>

On behalf of Scott Mansfield, here come 3/4 of libnetapi.so rewritten,
and now building for your pleasure ;-)


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1813 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 2f22e3ab 25-Oct-2002 beveloper <beveloper@nowhere.fake>

small change


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1659 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 61d3dba8 16-Oct-2002 Philippe Houdoin <philippe.houdoin@gmail.com>

Re-written by Scott Mansfield <thephantom@mac.com


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1549 a95241bf-73f2-0310-859d-f6bbb57e9c96


# f3dfda17 27-Aug-2002 Philippe Houdoin <philippe.houdoin@gmail.com>

Moving net kit libnet.so and libnetapi.so source code to /current.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@895 a95241bf-73f2-0310-859d-f6bbb57e9c96


# f16cf073d5b83dfcfe7f47b31943eab3db4284f1 18-Aug-2012 Alex Smith <alex@alex-smith.me.uk>

CID 714526: Operands don't affect result.

Incorrect check of in_addr_t (uint32_t) against (unsigned long)-1
would never be true.


# c91bc0e18914bf6bf0f908096bc250de98bb23e2 29-Sep-2009 Michael Lotz <mmlr@mlotz.ch>

Style cleanups, spacing, pointer style.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33352 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 49714746f214d8ed73a89bee5f150c337d6b2a66 29-Sep-2009 Michael Lotz <mmlr@mlotz.ch>

Space indent -> tab indent.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33351 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 49a22456ddda2a7cfc5c19d9ccc131125b8b690c 13-Jul-2008 Oliver Tappe <zooey@hirschkaefer.de>

Overhauled BNetEndpoint implementation (and BNetAddress, too):
* added NetEndpointTest that exposed a couple of bugs
* fixed several bugs in the implementation of BNetEndpoint, some of which kept
NetPenguin from working
* fixed a couple of constness issues in BNetEndpoint and BNetAddress


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26405 a95241bf-73f2-0310-859d-f6bbb57e9c96


# aebcc506e2a5664687853ac73d914d7360f776bb 10-Jul-2008 Oliver Tappe <zooey@hirschkaefer.de>

Corrected by previous assumption, since gethostbyname() has nothing to do with
struct sockaddr_in - the real culprits were BNetAddress::GetAddr(sockaddr_in&)
and BNetAddress::SetTo(const sockaddr_in&):
* moved check_r5_compatibility() into r5_compatibility.h to make that function
available to BNetAddress, too
* adjusted sockaddr_in-handling methods of BNetAddress to deal with R5-addresses
if in compatibility mode
* removed is_r5_sockaddr() again, since it is no longer needed

With this less hacky solution, Beam, NetPositive, NetworkTime and Vision still work. So, there's hope that the R5 compatibility layer is now complete.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26377 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 1aa3d2e3f31ffbb5014679275778a7682222eda7 05-Jul-2008 Oliver Tappe <zooey@hirschkaefer.de>

Resolved a couple of problems in BNetAddress implementation:
* fixed several byte order inconsistencies, it does not make sense to always
convert the byte order input/output values - no we convert where it can
be expected and leave it where it is confusing
* fixed size inconsistencies with respect to family and port, both of which
were sometimes handled as int8, as int16 and as int32 in different places
(now they are always int16)
These fixes make Beam connect to the correct address and port, but it still doesn't work, as it seems to be using UDP instead of TCP (doh!). Will look into that tomorrow.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26269 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 241b048033e34efa942d1f43f8d199d086b07743 28-Aug-2006 Axel Dörfler <axeld@pinc-software.de>

* Fixed build of libnetapi.so - it probably won't work for now, though, have a look
at the comment in r5_compatibility.h.
* Intentionally broke source compatibility and removed all that outdated Nettle stuff.
* Also, I took the liberty of making m_init private and rename it to fInit - again, this
will only affect source compatibility.
* Rewrote NetEndpoint.h
* Fixed quite a few small bugs around the code that I touched, for example in NetAddress,
SetTo() never set fInit, and therefore could be wrong.
* Some cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18680 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 6fdccb80f57f9386b43253be9278c40fd7d5cc26 28-Aug-2006 Axel Dörfler <axeld@pinc-software.de>

Moved libnetapi.so sources into the src/kit/net/ directory - they don't yet build, though.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18678 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 67b376e9539ff0b7cc4914c79c0976ffb96e6790 26-Nov-2005 Waldemar Kornewald <wkornew@nowhere.fake>

Moved our networking libraries to src/kits/network/compat. We want to have our own, clean libnetwork.so.

TODO: move all public networking headers to some other place (compat or headers/legacy?) and replace the current headers with clean versions from FreeBSD and BIND 9.3.1
TODO: remove R5 target support


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@15169 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 4907c35be773575eb5ca6dd86c7d805230943d73 15-Oct-2004 Philippe Houdoin <philippe.houdoin@gmail.com>

Fixed a warning.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@9366 a95241bf-73f2-0310-859d-f6bbb57e9c96


# f1d8cfb43260c6eca2f2767acdcfb0dc1c8ea45d 03-Oct-2004 Philippe Houdoin <philippe.houdoin@gmail.com>

TODO comment commit ;-)


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@9168 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 665b241c1af743367c0684f1c8ee5bcdc36bd27e 16-Dec-2002 Philippe Houdoin <philippe.houdoin@gmail.com>

Checked-in updated implementation of these classes written by
Scott Mansfield.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@2263 a95241bf-73f2-0310-859d-f6bbb57e9c96


# ae0638a6be77feda92cf91e3ad82d0b8b652611b 31-Oct-2002 Philippe Houdoin <philippe.houdoin@gmail.com>

On behalf of Scott Mansfield, here come 3/4 of libnetapi.so rewritten,
and now building for your pleasure ;-)


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1813 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 2f22e3ab04ac6cfa6faebbed1c0139509cc89f9f 25-Oct-2002 beveloper <beveloper@nowhere.fake>

small change


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1659 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 61d3dba838f146f64fb612d89d68d9eec6541fd5 16-Oct-2002 Philippe Houdoin <philippe.houdoin@gmail.com>

Re-written by Scott Mansfield <thephantom@mac.com


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1549 a95241bf-73f2-0310-859d-f6bbb57e9c96


# f3dfda177957165c55cbe4d0b4386bc114f48e1c 27-Aug-2002 Philippe Houdoin <philippe.houdoin@gmail.com>

Moving net kit libnet.so and libnetapi.so source code to /current.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@895 a95241bf-73f2-0310-859d-f6bbb57e9c96