DefaultMediaTheme: fix build with tracing enabled.

DefaultMediaTheme: implement BTextParameter handling for BParameterWeb

These changes add text parameters support to DefaultMediaTheme
for the BParameterWeb class.

Change-Id: I6ec04109af73011f84bb7c1fd5210c5c8842c2cb
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3828
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>

DefaultMediaTheme: fix Slider scale

Values are using a scale of 1000, but limits are set 0..100. Very
visible in media preferencies when using balance controls for stereo
connections in the mixer: the control is shown full right at first and
the moment you touch it and the gain is updated, you only get sound from
the left channel.

Probably the root cause of #15836 and #16070.

Change-Id: I31d3b6b11a57ca99a1cc8373d9fb003f21b192b3
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3445
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>

DefaultMediaTheme: move controls to a namespace

They have generic names and are likely to conflict with other things. In
particular, there is another BPrivate::TitleView in BColumnListView,
which results in weird behavior (and me wasting days debugging things
and scratching my head) when one links libmedia before libcolumnlistview
and the wrong one ends up being called.

DefaultMediaTheme: Properly set control targets.

In removing the "GroupView" class and replacing it with a real BGroupView,
I missed that it its AttachedToWindow() implementation iterated over all
child controls and set their targets to themselves. It seems this is how
the Media Kit gets change messages from them, and so the lack of this
broke changing parameter values. Whoops.

But it seems that changing menu option values has been broken for a long time
(perhaps forever?), as in order for a BOptionPopUp to send messages to anything,
its AttachedToWindow() must be called (as this sets the BMenuItem's targets
to itself, so it can forward the messages.) So now that is fixed too.

Media Kit: Remove DynamicScrollView from DefaultMediaTheme.

As of the last commit, a BScrollView in layouted mode now behaves
this way by default.

Change-Id: I07bd17d6d20e494c0e2f08172c0d54b10fa5d26d
Reviewed-on: https://review.haiku-os.org/c/893
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>

Media Kit: Rewrite DefaultMediaTheme to use layouts.

The old fixed-rect method was very error-prone in corner-cases,
resulting in half-visible (cut off) parameters, incorrectly
sized controls, etc. on various devices, which often made it
impossible to use.

While there are still a few rough edges (scrollbar behavior could
be further improved, though it's already much better than it was before),
this method is much better than the previous one.

Fixes #11592 and related tickets.

Change-Id: I65175f760bda98e42d1fc68ba8e526470bf17c25
Reviewed-on: https://review.haiku-os.org/c/889
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>

media: Remove debug.h, finalize MediaDebug.h

* Funny rust from 0 AD.

DefaultMediaTheme: use DetachedFromWindow() for unwatching media events.

DefaultMediaTheme: improve watching for parameter value changes.

* Addresses TODO of sub-classing controls, registering with the
media roster for parameter changes.
* Also adds support for discrete parameter controls, which didn't
have this functionality.
* With this change, the controls no longer need to be focused or
modified for the parameter changes to register.

media_kit: Follow up fix to use only portable codes

* My previous commit fixed x86_64 but broke all other archs.

media_kit: Fix debug printf werrors

* When debugging was enabled in the media_kit those were
causing the build to fail complaining about werrors.

BControllable: Fix real_time and perf_time mismatch

* It caused parameters to change with delay, because the
event has been enqueued in the event queue with real time.
* Please don't rely on system_time.
* Fixes #5106.

preferences: Convert to using Set*UIColor.

Signed-off-by: Augustin Cavalier <waddlesplash@gmail.com>
Patches 0023-0037 from looncraz, unmodified.

Patch by Humdinger:
Switched strings to sentence case in servers and kits. This is the
case-servers+kits.diff applied from #5169. Couldn't spot any possibly
problematic changes.
Thanks a lot!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35044 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed building with tracing on.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@31274 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Changed ContinuousMessageFilter to register for parameter value changes,
and change its slider value when such a message arrives.
* Currently, this will only work if such a view already received a message;
added a TODO about how it should be done, but since those would require
some more changes, I don't want to do that as long as Sean Healy is working
on that file.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30083 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed various problems that caused the scrollbars and the group view to be
layouted incorrectly:
* Only remove the insets if there are any when no tabview is needed.
* Use Bounds() when creating the scrollbars, not Frame() (this probably
worked correctly only when the DynamicScrollView was the only child in a
window...)
* Simplify layouting the scrollbars and target view, always do so, since it
isn't clear if the host window uses the old style view follow modes, the
target view had no follow mode anyways, so we need to layout it for sure.
* Correct the "edged in" effect of the TitleView drawing.

This fixes the bad drawing artifacts in the Media preflet when scrollbars
are needed to embed a larger parameter web view.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28394 a95241bf-73f2-0310-859d-f6bbb57e9c96

- MakeViewFor didn't return a view with a good default size when no hintRect was provided (as
in Cortex). This happened only when needing a tabbed view. It will now return a view with the
most fitting size. This fixes #597



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@25923 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Implemented ERROR as fprintf(stderr, ...) with tracing turned off as well.
* Fixed all but one compiler warnings in libmedia.so.
* Truncated lines to 80 char width where I looked at code.
* Turned printf()s into TRACE/ERROR calls in MediaExtractor.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@24478 a95241bf-73f2-0310-859d-f6bbb57e9c96

First part of a patch sent by Clemens zeidler:
* The BMediaTheme now uses B_WIDTH_FROM_LABEL for tabs in tabviews,
this makes tabs as wide as they need to be.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@23868 a95241bf-73f2-0310-859d-f6bbb57e9c96

patch by aldeck:
* fixes the content inside the tabview in the Media preflet spanning over
the wrong area (wrong insets)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@23338 a95241bf-73f2-0310-859d-f6bbb57e9c96

Some cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@22568 a95241bf-73f2-0310-859d-f6bbb57e9c96

fixed two warnings


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18871 a95241bf-73f2-0310-859d-f6bbb57e9c96

made error messages a little more informative


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@8572 a95241bf-73f2-0310-859d-f6bbb57e9c96

The group views must not B_FOLLOW_ALL unless they are the top-level group
views - that makes all sliders accessible again.
Thanks to Marcus for reporting that bug.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6703 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed the test for the knob position with B_DOCUMENT_WINDOW_LOOK.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6670 a95241bf-73f2-0310-859d-f6bbb57e9c96

The target view of the scroll view must be moved to the origin (doesn't
matter in this context, though).


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6629 a95241bf-73f2-0310-859d-f6bbb57e9c96

We now dynamically add scroll bars to the parameter web view!

Some BeOS classes really are very stupid or just inferior:
- added DynamicScrollView class that adds and removes scroll bars as needed
and automatically takes care of the correct scroller range and proportions.
- added TabView class that is smart enough to resize its container view
and the tab views as well.

Both classes could be used in other environments, too. DynamicScrollView
would be a nice addition to BScrollView R2 - might be put into a shared
source directory for now (or into libbe's BPrivate namespace?).
The TabView additions could almost be moved to BTabView without breaking
compatibility, just the resizing mode of the tab views have to be respected.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6612 a95241bf-73f2-0310-859d-f6bbb57e9c96

small tweak to allow control of continuous parameter range 0.0 to 1.0


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4564 a95241bf-73f2-0310-859d-f6bbb57e9c96

removed/fixed warnings


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4418 a95241bf-73f2-0310-859d-f6bbb57e9c96

The groups are now put into special GroupViews which not only set the target
of its members correctly, but will also add scroll bars as needed.
Implemented basic message filters for discrete/continuous parameter views.
The views are now set to the correct parameter value and vice versa.
BContinuousParameter::{Get|Set}Response() is not yet supported, though.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@3874 a95241bf-73f2-0310-859d-f6bbb57e9c96

The creation of the parameter views now happens before the sub-groups are
added to the group. That way, a title view can be identified and always
placed at the top of the view.
Fixed minor related bugs.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@3804 a95241bf-73f2-0310-859d-f6bbb57e9c96

Now sets the height of the parameter web correctly (wasn't visible with the
Media preferences application alone).
Replaced the BBox with a simple BView for the container of a BParameterGroup.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@3801 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added support for the B_HIDDEN_PARAMETER flag.
Added heuristica to only show those BNullParameters which the original media
kit shows.
Removed flickering in the SeparatorView drawing code.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@3800 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added workaround for a misbehaving BOptionPopUp class (doesn't resize itself
properly - it obviously needs the correct size at creation time...).


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@3799 a95241bf-73f2-0310-859d-f6bbb57e9c96

Big visual update: it's now almost the same as the original MediaTheme.
Some special parameter types are still missing, actually changing anything
is missing, some needed work-arounds for broken Be code, etc.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@3798 a95241bf-73f2-0310-859d-f6bbb57e9c96

Implemented a very simple default media theme. You can't do anything yet,
but you should already see most of the options.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@3783 a95241bf-73f2-0310-859d-f6bbb57e9c96

clean up of debugging functions
FATAL is now replaced by ERROR and active at DEBUG=1 or above
TRACE is active at 2 or above
PRINT(level, ...) can be used for DEBUG= level or abode
INFO is removed


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@3578 a95241bf-73f2-0310-859d-f6bbb57e9c96

Add a first non-functional version of the default media theme.
Implemented all needed functionality in BMediaTheme to use this default
theme - it's currently disabled, though (or should be).


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@3491 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by Humdinger:
Switched strings to sentence case in servers and kits. This is the
case-servers+kits.diff applied from #5169. Couldn't spot any possibly
problematic changes.
Thanks a lot!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35044 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed building with tracing on.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@31274 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Changed ContinuousMessageFilter to register for parameter value changes,
and change its slider value when such a message arrives.
* Currently, this will only work if such a view already received a message;
added a TODO about how it should be done, but since those would require
some more changes, I don't want to do that as long as Sean Healy is working
on that file.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30083 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed various problems that caused the scrollbars and the group view to be
layouted incorrectly:
* Only remove the insets if there are any when no tabview is needed.
* Use Bounds() when creating the scrollbars, not Frame() (this probably
worked correctly only when the DynamicScrollView was the only child in a
window...)
* Simplify layouting the scrollbars and target view, always do so, since it
isn't clear if the host window uses the old style view follow modes, the
target view had no follow mode anyways, so we need to layout it for sure.
* Correct the "edged in" effect of the TitleView drawing.

This fixes the bad drawing artifacts in the Media preflet when scrollbars
are needed to embed a larger parameter web view.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28394 a95241bf-73f2-0310-859d-f6bbb57e9c96

- MakeViewFor didn't return a view with a good default size when no hintRect was provided (as
in Cortex). This happened only when needing a tabbed view. It will now return a view with the
most fitting size. This fixes #597



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@25923 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Implemented ERROR as fprintf(stderr, ...) with tracing turned off as well.
* Fixed all but one compiler warnings in libmedia.so.
* Truncated lines to 80 char width where I looked at code.
* Turned printf()s into TRACE/ERROR calls in MediaExtractor.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@24478 a95241bf-73f2-0310-859d-f6bbb57e9c96

First part of a patch sent by Clemens zeidler:
* The BMediaTheme now uses B_WIDTH_FROM_LABEL for tabs in tabviews,
this makes tabs as wide as they need to be.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@23868 a95241bf-73f2-0310-859d-f6bbb57e9c96

patch by aldeck:
* fixes the content inside the tabview in the Media preflet spanning over
the wrong area (wrong insets)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@23338 a95241bf-73f2-0310-859d-f6bbb57e9c96

Some cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@22568 a95241bf-73f2-0310-859d-f6bbb57e9c96

fixed two warnings


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18871 a95241bf-73f2-0310-859d-f6bbb57e9c96

made error messages a little more informative


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@8572 a95241bf-73f2-0310-859d-f6bbb57e9c96

The group views must not B_FOLLOW_ALL unless they are the top-level group
views - that makes all sliders accessible again.
Thanks to Marcus for reporting that bug.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6703 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed the test for the knob position with B_DOCUMENT_WINDOW_LOOK.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6670 a95241bf-73f2-0310-859d-f6bbb57e9c96

The target view of the scroll view must be moved to the origin (doesn't
matter in this context, though).


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6629 a95241bf-73f2-0310-859d-f6bbb57e9c96

We now dynamically add scroll bars to the parameter web view!

Some BeOS classes really are very stupid or just inferior:
- added DynamicScrollView class that adds and removes scroll bars as needed
and automatically takes care of the correct scroller range and proportions.
- added TabView class that is smart enough to resize its container view
and the tab views as well.

Both classes could be used in other environments, too. DynamicScrollView
would be a nice addition to BScrollView R2 - might be put into a shared
source directory for now (or into libbe's BPrivate namespace?).
The TabView additions could almost be moved to BTabView without breaking
compatibility, just the resizing mode of the tab views have to be respected.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6612 a95241bf-73f2-0310-859d-f6bbb57e9c96

small tweak to allow control of continuous parameter range 0.0 to 1.0


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4564 a95241bf-73f2-0310-859d-f6bbb57e9c96

removed/fixed warnings


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4418 a95241bf-73f2-0310-859d-f6bbb57e9c96

The groups are now put into special GroupViews which not only set the target
of its members correctly, but will also add scroll bars as needed.
Implemented basic message filters for discrete/continuous parameter views.
The views are now set to the correct parameter value and vice versa.
BContinuousParameter::{Get|Set}Response() is not yet supported, though.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@3874 a95241bf-73f2-0310-859d-f6bbb57e9c96

The creation of the parameter views now happens before the sub-groups are
added to the group. That way, a title view can be identified and always
placed at the top of the view.
Fixed minor related bugs.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@3804 a95241bf-73f2-0310-859d-f6bbb57e9c96

Now sets the height of the parameter web correctly (wasn't visible with the
Media preferences application alone).
Replaced the BBox with a simple BView for the container of a BParameterGroup.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@3801 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added support for the B_HIDDEN_PARAMETER flag.
Added heuristica to only show those BNullParameters which the original media
kit shows.
Removed flickering in the SeparatorView drawing code.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@3800 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added workaround for a misbehaving BOptionPopUp class (doesn't resize itself
properly - it obviously needs the correct size at creation time...).


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@3799 a95241bf-73f2-0310-859d-f6bbb57e9c96

Big visual update: it's now almost the same as the original MediaTheme.
Some special parameter types are still missing, actually changing anything
is missing, some needed work-arounds for broken Be code, etc.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@3798 a95241bf-73f2-0310-859d-f6bbb57e9c96

Implemented a very simple default media theme. You can't do anything yet,
but you should already see most of the options.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@3783 a95241bf-73f2-0310-859d-f6bbb57e9c96

clean up of debugging functions
FATAL is now replaced by ERROR and active at DEBUG=1 or above
TRACE is active at 2 or above
PRINT(level, ...) can be used for DEBUG= level or abode
INFO is removed


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@3578 a95241bf-73f2-0310-859d-f6bbb57e9c96

Add a first non-functional version of the default media theme.
Implemented all needed functionality in BMediaTheme to use this default
theme - it's currently disabled, though (or should be).


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@3491 a95241bf-73f2-0310-859d-f6bbb57e9c96