Document new rgb_color apis, apply their usage.

Change-Id: I48f1bedd3abfb3b445c1c7090ce43504bcff4537
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7485
Reviewed-by: waddlesplash <waddlesplash@gmail.com>

Interface Kit: Remove more non-BControlLook code.

BStatusBar: Restore the old blue-ish color from before the Set*Color changes.

kits/interface: Convert to using Set*UIColor.

Signed-off-by: Augustin Cavalier <waddlesplash@gmail.com>
Patches 0003-0017 from looncraz, unmodified.

Fix MinSize and PreferredSize.

Use be_control_look != NULL everywhere in the Interface Kit.

Should not be a functional change. It is not in the Haiku Coding Guidelines but
I feel like 'if (object != NULL)' is generally preferred to 'if (object)', plus
in this case of be_control_look that is the more common style.

Some cleanup in interface kit. From unused code warnings (before I updated buildtools).

De-virtualize BView::InvalidateLayout() and introduce LayoutInvalidated() hook, like BLayout.

Small coding style fixes.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36216 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed regression reported by Axel. If the BStatusBar is not running in layout
mode, revert to the old behavior to include the room for the labels, even if
there aren't any.
Also in layouted mode, trigger a layout invalidation when switching from running
without labels to using labels and vice versa.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35610 a95241bf-73f2-0310-859d-f6bbb57e9c96

If we already figured out the correct low colow to use in AttachedToWindow(),
we might as well use it. Couldn't see any regressions so far.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35457 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Make a BStatusBar comfortable to use without any text labels.
* In SetBarHeight(), use InvalidateLayout() when used with layout management.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35418 a95241bf-73f2-0310-859d-f6bbb57e9c96

Finished unifying the Interface Kit headers:
* Fixed copyrights (puncuation and capitalization, removed authors from
headers)
* Updated indentation style
* Unified pointer/reference style
* Re-ordered some methods for better grouping where it could be done
(abd adopted source accordingly)
* Small coding style fixes here and there

No functional change intended.

+alphabranch


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32745 a95241bf-73f2-0310-859d-f6bbb57e9c96

Implemented a new look for the Haiku interface controls. It was
overheard that they looked too ninety-ish.
TODO: The code behind this is work in progress. The basic idea
is to extract all drawing code into a new class BControlLook,
of which there is a global instance be_control_look, instantiated
in InterfaceDefs.cpp. At the moment, all the old drawing code is
still there, and the usage of be_control_look is inside if-bodies
checking the instance against NULL. In another words, by not
instanitating be_control_look, you can revert back to the old look.
BControlLook's job is to provide reusable methods for drawing
certain types of frames, backgrounds and labels, so that application
developers can make controls that re-use the same drawing code
as built-in controls and adopt to changes made there. I have added
the notion of "borders". Each of the frame drawing methods can be
made to draw certain borders only, which is supposed to help when
controls shall visually attach. This feature is not fully explored
at all ATM.
TODO: Update BColumnListView header view and BStringItem text
spacing. Update other apps where it makes sense to use BControlLook.
For the moment, only Tracker and LaunchBox are updated. More...
NOTE: The new look is not very radically different, so that existing
apps do not immediately look too ugly or out of place.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96

bonefish + zooey:
* Fixed a general problem with respect to overriding of the reserved
virtual function slots: instead of statically invoking the method
that corresponds to the reserved slot on the class that contains the
slot, we now invoke the virtual Perform() method. Perform() then dispatches
the method invocation to the "proper" class, i.e. the highest class in the
hierarchy that actually implements the requested method.
This fixes a crash in apps that use liblayout's MSlider class and
should fix one or other spurious bug with old apps or libraries, too.
* added new header folder 'binary_compatibility' that contains files that
define the method codes and data structures required by Perform()
* looked for and implemented all used reserved virtual slot functions to
invoke Perform() where necessary or to pass on the method call statically
(for slots that were already maintained by Be)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28124 a95241bf-73f2-0310-859d-f6bbb57e9c96

mmlr + stippi:
Fixed more controls to handle a B_TRANSPARENT_COLOR as view coloe of the
parent view. Some controls would not initialize their LowColor() at all
if they were the only control in a window.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26515 a95241bf-73f2-0310-859d-f6bbb57e9c96

Calling BStatusBar::Update() with NULL as either string argument should
keep the current string. (Untested)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26379 a95241bf-73f2-0310-859d-f6bbb57e9c96

Rewrote parts related to drawing the labels. The order of drawing happens as
this (seems to be what R5 BStatusBar does):
* combine the "trailing text" with the "trailing label" and truncate the
resulting string on the left side according to the width of the entire
control
* combine the "label" with the "text" and truncate that on the right side
according to the space left by the right hand text.

-> No more overlaps (theoretically, in practise there are still overlaps
because our BFont::TruncateString() does not respect the width in some
situations.)

* Changed _SetTextData() accordingly, it is not used anymore for the
label and trailing label, and could therefor be simplified a little.
* fixed _BarFrame() to not return fractional coords, which could sometimes
leave a dirty line of pixels.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@25244 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fix SpaceMonitor crash. Verified that R5 and/or Zeta in fact do *not*
Invalidate() on SetMaxValue(). This should probably be revisited in
the future whenever we break binary compat. TODO note added to that
effect.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@24468 a95241bf-73f2-0310-859d-f6bbb57e9c96

* some simplifications in the code, I'm not sure if it supported NULL texts as
the BeBook mentions it does
* make sure the view is invalidated on resize
* needs more fixes (for example GetPreferredSize() does not take everything
into account)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@22370 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by Łukasz 'Sil2100' Zemczak: Made BStatusBar layout friendly.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@21936 a95241bf-73f2-0310-859d-f6bbb57e9c96

* patch by aldeck, fixes ticket #1143


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20618 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Rewrote StatusBar.h. This fixes bug #419 due to a missing "virtual" declaration.
* More or less rewrote BStatusBar, too:
- Draw() now only redraws something when it's part of the updateRect.
- no more flickering (uses B_TRANSPARENT_COLOR now), this fixes bug #530.
- added Dano/Zeta-style SetTo() method.
- big cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17857 a95241bf-73f2-0310-859d-f6bbb57e9c96

fixed strange usage of rgb_color


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17549 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed warning.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17171 a95241bf-73f2-0310-859d-f6bbb57e9c96

Looks like bug 419 wasn't fixed by previous commit. Let's see if this does.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17050 a95241bf-73f2-0310-859d-f6bbb57e9c96

Corrected previous commit. Thanks to Axel for noticing

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17017 a95241bf-73f2-0310-859d-f6bbb57e9c96

Should fix bug 326

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17015 a95241bf-73f2-0310-859d-f6bbb57e9c96

All controls/views now accept NULL arguments for "width" and "height" in GetPreferredSize().


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@15091 a95241bf-73f2-0310-859d-f6bbb57e9c96

"trailing text" -> "trailing_text". Same for label.
I even take responsibility for this bug, as I told Marc to change it eons ago.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@13309 a95241bf-73f2-0310-859d-f6bbb57e9c96

Initialize fLabel and fTrailingLabel in the constructor. Thanks to Marc Flerackers for reporting.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@12577 a95241bf-73f2-0310-859d-f6bbb57e9c96

Style changes, moved some functionalities to private methods


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10515 a95241bf-73f2-0310-859d-f6bbb57e9c96

Investigated and resolved a TODO item concerning bar color in Archive()


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@7591 a95241bf-73f2-0310-859d-f6bbb57e9c96

Plugged some holes in the last checkin


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@3665 a95241bf-73f2-0310-859d-f6bbb57e9c96

Conform more tightly with the BeBook, and fix a few crashing bugs in the process


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@3472 a95241bf-73f2-0310-859d-f6bbb57e9c96

Minor header-related changes


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@3246 a95241bf-73f2-0310-859d-f6bbb57e9c96

Compatibility changes


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1935 a95241bf-73f2-0310-859d-f6bbb57e9c96

Label and text support, minor drawing changes


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1558 a95241bf-73f2-0310-859d-f6bbb57e9c96

Archive was overwritten with an older version


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1011 a95241bf-73f2-0310-859d-f6bbb57e9c96

Some small fixes


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1009 a95241bf-73f2-0310-859d-f6bbb57e9c96

It is accomplished ...


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fix MinSize and PreferredSize.

Use be_control_look != NULL everywhere in the Interface Kit.

Should not be a functional change. It is not in the Haiku Coding Guidelines but
I feel like 'if (object != NULL)' is generally preferred to 'if (object)', plus
in this case of be_control_look that is the more common style.

Some cleanup in interface kit. From unused code warnings (before I updated buildtools).

De-virtualize BView::InvalidateLayout() and introduce LayoutInvalidated() hook, like BLayout.

Small coding style fixes.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36216 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed regression reported by Axel. If the BStatusBar is not running in layout
mode, revert to the old behavior to include the room for the labels, even if
there aren't any.
Also in layouted mode, trigger a layout invalidation when switching from running
without labels to using labels and vice versa.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35610 a95241bf-73f2-0310-859d-f6bbb57e9c96

If we already figured out the correct low colow to use in AttachedToWindow(),
we might as well use it. Couldn't see any regressions so far.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35457 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Make a BStatusBar comfortable to use without any text labels.
* In SetBarHeight(), use InvalidateLayout() when used with layout management.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35418 a95241bf-73f2-0310-859d-f6bbb57e9c96

Finished unifying the Interface Kit headers:
* Fixed copyrights (puncuation and capitalization, removed authors from
headers)
* Updated indentation style
* Unified pointer/reference style
* Re-ordered some methods for better grouping where it could be done
(abd adopted source accordingly)
* Small coding style fixes here and there

No functional change intended.

+alphabranch


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32745 a95241bf-73f2-0310-859d-f6bbb57e9c96

Implemented a new look for the Haiku interface controls. It was
overheard that they looked too ninety-ish.
TODO: The code behind this is work in progress. The basic idea
is to extract all drawing code into a new class BControlLook,
of which there is a global instance be_control_look, instantiated
in InterfaceDefs.cpp. At the moment, all the old drawing code is
still there, and the usage of be_control_look is inside if-bodies
checking the instance against NULL. In another words, by not
instanitating be_control_look, you can revert back to the old look.
BControlLook's job is to provide reusable methods for drawing
certain types of frames, backgrounds and labels, so that application
developers can make controls that re-use the same drawing code
as built-in controls and adopt to changes made there. I have added
the notion of "borders". Each of the frame drawing methods can be
made to draw certain borders only, which is supposed to help when
controls shall visually attach. This feature is not fully explored
at all ATM.
TODO: Update BColumnListView header view and BStringItem text
spacing. Update other apps where it makes sense to use BControlLook.
For the moment, only Tracker and LaunchBox are updated. More...
NOTE: The new look is not very radically different, so that existing
apps do not immediately look too ugly or out of place.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29221 a95241bf-73f2-0310-859d-f6bbb57e9c96

bonefish + zooey:
* Fixed a general problem with respect to overriding of the reserved
virtual function slots: instead of statically invoking the method
that corresponds to the reserved slot on the class that contains the
slot, we now invoke the virtual Perform() method. Perform() then dispatches
the method invocation to the "proper" class, i.e. the highest class in the
hierarchy that actually implements the requested method.
This fixes a crash in apps that use liblayout's MSlider class and
should fix one or other spurious bug with old apps or libraries, too.
* added new header folder 'binary_compatibility' that contains files that
define the method codes and data structures required by Perform()
* looked for and implemented all used reserved virtual slot functions to
invoke Perform() where necessary or to pass on the method call statically
(for slots that were already maintained by Be)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28124 a95241bf-73f2-0310-859d-f6bbb57e9c96

mmlr + stippi:
Fixed more controls to handle a B_TRANSPARENT_COLOR as view coloe of the
parent view. Some controls would not initialize their LowColor() at all
if they were the only control in a window.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26515 a95241bf-73f2-0310-859d-f6bbb57e9c96

Calling BStatusBar::Update() with NULL as either string argument should
keep the current string. (Untested)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26379 a95241bf-73f2-0310-859d-f6bbb57e9c96

Rewrote parts related to drawing the labels. The order of drawing happens as
this (seems to be what R5 BStatusBar does):
* combine the "trailing text" with the "trailing label" and truncate the
resulting string on the left side according to the width of the entire
control
* combine the "label" with the "text" and truncate that on the right side
according to the space left by the right hand text.

-> No more overlaps (theoretically, in practise there are still overlaps
because our BFont::TruncateString() does not respect the width in some
situations.)

* Changed _SetTextData() accordingly, it is not used anymore for the
label and trailing label, and could therefor be simplified a little.
* fixed _BarFrame() to not return fractional coords, which could sometimes
leave a dirty line of pixels.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@25244 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fix SpaceMonitor crash. Verified that R5 and/or Zeta in fact do *not*
Invalidate() on SetMaxValue(). This should probably be revisited in
the future whenever we break binary compat. TODO note added to that
effect.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@24468 a95241bf-73f2-0310-859d-f6bbb57e9c96

* some simplifications in the code, I'm not sure if it supported NULL texts as
the BeBook mentions it does
* make sure the view is invalidated on resize
* needs more fixes (for example GetPreferredSize() does not take everything
into account)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@22370 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by Łukasz 'Sil2100' Zemczak: Made BStatusBar layout friendly.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@21936 a95241bf-73f2-0310-859d-f6bbb57e9c96

* patch by aldeck, fixes ticket #1143


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20618 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Rewrote StatusBar.h. This fixes bug #419 due to a missing "virtual" declaration.
* More or less rewrote BStatusBar, too:
- Draw() now only redraws something when it's part of the updateRect.
- no more flickering (uses B_TRANSPARENT_COLOR now), this fixes bug #530.
- added Dano/Zeta-style SetTo() method.
- big cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17857 a95241bf-73f2-0310-859d-f6bbb57e9c96

fixed strange usage of rgb_color


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17549 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed warning.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17171 a95241bf-73f2-0310-859d-f6bbb57e9c96

Looks like bug 419 wasn't fixed by previous commit. Let's see if this does.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17050 a95241bf-73f2-0310-859d-f6bbb57e9c96

Corrected previous commit. Thanks to Axel for noticing

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17017 a95241bf-73f2-0310-859d-f6bbb57e9c96

Should fix bug 326

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17015 a95241bf-73f2-0310-859d-f6bbb57e9c96

All controls/views now accept NULL arguments for "width" and "height" in GetPreferredSize().


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@15091 a95241bf-73f2-0310-859d-f6bbb57e9c96

"trailing text" -> "trailing_text". Same for label.
I even take responsibility for this bug, as I told Marc to change it eons ago.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@13309 a95241bf-73f2-0310-859d-f6bbb57e9c96

Initialize fLabel and fTrailingLabel in the constructor. Thanks to Marc Flerackers for reporting.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@12577 a95241bf-73f2-0310-859d-f6bbb57e9c96

Style changes, moved some functionalities to private methods


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10515 a95241bf-73f2-0310-859d-f6bbb57e9c96

Investigated and resolved a TODO item concerning bar color in Archive()


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@7591 a95241bf-73f2-0310-859d-f6bbb57e9c96

Plugged some holes in the last checkin


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@3665 a95241bf-73f2-0310-859d-f6bbb57e9c96

Conform more tightly with the BeBook, and fix a few crashing bugs in the process


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@3472 a95241bf-73f2-0310-859d-f6bbb57e9c96

Minor header-related changes


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@3246 a95241bf-73f2-0310-859d-f6bbb57e9c96

Compatibility changes


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1935 a95241bf-73f2-0310-859d-f6bbb57e9c96

Label and text support, minor drawing changes


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1558 a95241bf-73f2-0310-859d-f6bbb57e9c96

Archive was overwritten with an older version


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1011 a95241bf-73f2-0310-859d-f6bbb57e9c96

Some small fixes


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@1009 a95241bf-73f2-0310-859d-f6bbb57e9c96

It is accomplished ...


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10 a95241bf-73f2-0310-859d-f6bbb57e9c96