fs_darwin fix warning: '&&' within '||'

place parentheses around the '&&' expression to silence this warning

Change-Id: Ie6152d2371ed65f57e6e75c9541263a5e1511513
Reviewed-on: https://review.haiku-os.org/c/1532
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>

libroot_build: fs_darwin: fdopendir(): close FD on success

fdopendir() is supposed to consume the specified FD on success.

Convert fs_host files from c back to cpp and style changes.

* fs_darwin.c => fs_darwin.cpp
* fs_freebsd.c => fs_freebsd.cpp
* use bool instead of int again in fs_darwin.cpp (C => C++)
* declare loop varibles inline again in fs_freebsd.cpp (C => C++)
* 2 newlines between top header gaurd and first #include
* 2 newlines after last #include
* freebsd/endian.h and freebsd/regex.h convert \r\n to just \n
* remove some leading tabs in fs_freebsd.cpp
* add newlines after single line if statement in fs_freebsd.cpp
* 80-char limit fixes in fs_freebsd.cpp

Cleanup darwin build system some more.

* Convert fs_darwin.cpp and fs_freebsd.cpp to C.
* Convert extern C calls to __BEGIN_DECLS and __END_DECLS macros
* Link rm_attrs with dynamic libroot

Split fs_darwin.h defines into various platform dependent headers.

This completes the final 1/3 of #8857. Changes again by nielx with
style fixes by me.

The one part that I couldn't figure out, and maybe Ingo can chime
in here. If headers/build/host/darwin/sys/stat.h is surrounded in

extern "C" {

}

guards then I get a link error complaining that the functions defined
here are duplicate symbols, once in fs.o and once in function_remapper.o.
For example:

ld: duplicate symbol _futimens in generated/objects/darwin/x86_64/release/build/libroot/libroot_build_function_remapper.a(function_remapper.o) and generated/objects/darwin/x86_64/release/build/libroot/libroot_build.a(fs.o) for architecture x86_64

I'm not sure why that is.

Add fopendir() to fs_darwin.cpp and fix symlinkat().

This completes 2/3 of #8857 and is courtesy of nielx.

Make private helper function static in fs_darwin.cpp in order to not pollute
the public namespace.

Use a stack variable of MAXPATHLEN size to hold the full path to avoid having to manually malloc and free the variable.

Style fixes suggested by Axeld.
Added Ingo to the copyright
Updated copyright year to 2012 for my contribution.

Fix flag checking in fs_darwin.cpp
Somehow this commit got left out in my earlier push.

Fix build on Mac OS X 10.6 gcc2 and gcc4 and 10.7 gcc4 by adding some Mac OS X specific files that implement missing *at() functions.
Mac OS X 10.7 generates a gcc2 cross-compiler that fails when assigning NULL to a static method pointer so is still broken.
Added a weak attribute in driver_settings.cpp.
Move futimesat() from fs.cpp to fs_darwin.cpp since it is implimented on FreeBSD.
Implemented eaccess(), for the AT_EACCESS flag of faccessat()
Fix configure script to correctly detect case-sensitive file system

Move the invalid fd check to after checking if fd == AT_FDCWD in the fchownat() function

Implement the rest of chmod AT_SYMLINK_NOFOLLOW flag, fix the flag error detection code, a few comment changes.

Implement the AT_SYMLINK_NOFOLLOW flag to fchmodat() by calling open at fchmod emulating lchmod()

Fix build error and implement AT_SYMLINK_NO_FOLLOW in fstatat() by calling lstat()

Check for valid flags in faccessat() and fchmodat() and implement AT_SYMLINK_NOFOLLOW in fatchownat() using lchown().

Use S_ISDIR instead of S_IFDIR to check if the fd points to a directory and take AT_SYMLINK_NO_FOLLOW out of faccessat because IEEE Std 1003.1-2008 doesn't call for it even though Linux implements it.

Error if file descriptor is negative after checking for AT_FDCWD

Refactor so that all methods call a common get_path method to grab the full path from the fd and relative path string

insert a / between the directory path and relative path. in faccessat() use dirpath at the end, not path.

Reverse logic when checking if dirst points to a directory.

Check if flags bitmap != 0, not that it does == 0

Error if unsupported flag is passed to fstatat()

Cleanup the flags and make them the same as FreeBSD

Explicitly check path against NULL instead of relying on boolality. Yes, I just made that word up.

Rename to and from to old and new in order to be consistant with Linux.

Fix memory leak for the full path including fd directory.

Implement linkat()

Implement renameat()

Remove extraneous line where I called just unlinkat()

Implement unlinkat()

Implement symlinkat()

Implement readlinkat()

Implemented eaccess(), the AT_EACCESS flag of faccessat(), fchmodat(), fchownat(), fstatat(), mkdirat(), mkfifoat(), mknodat(), and futimesat().

Check to see that fd points to a directory before resolving the full path.

Implement a basic faccessat method. There are still a few missing pieces to it.

Don't return 0 for the unimplemented *at() functions, set errno to ENOSYS (not implemented) and return -1 instead.

Move futimesat() from fs.cpp to fs_darwin.cpp since it is implimented on FreeBSD. It is stubbed out for now.

Fix build by adding some Mac OS X specific files that implement fs function missing on that OS. The functions are stubbed out currently and have not been implemented. However, it does build now. I also added a weak attribute in driver_settings.cpp that I have no idea what does but was necessary to fix the build.

libroot_build: fs_darwin: fdopendir(): close FD on success

fdopendir() is supposed to consume the specified FD on success.

Convert fs_host files from c back to cpp and style changes.

* fs_darwin.c => fs_darwin.cpp
* fs_freebsd.c => fs_freebsd.cpp
* use bool instead of int again in fs_darwin.cpp (C => C++)
* declare loop varibles inline again in fs_freebsd.cpp (C => C++)
* 2 newlines between top header gaurd and first #include
* 2 newlines after last #include
* freebsd/endian.h and freebsd/regex.h convert \r\n to just \n
* remove some leading tabs in fs_freebsd.cpp
* add newlines after single line if statement in fs_freebsd.cpp
* 80-char limit fixes in fs_freebsd.cpp

Cleanup darwin build system some more.

* Convert fs_darwin.cpp and fs_freebsd.cpp to C.
* Convert extern C calls to __BEGIN_DECLS and __END_DECLS macros
* Link rm_attrs with dynamic libroot

Split fs_darwin.h defines into various platform dependent headers.

This completes the final 1/3 of #8857. Changes again by nielx with
style fixes by me.

The one part that I couldn't figure out, and maybe Ingo can chime
in here. If headers/build/host/darwin/sys/stat.h is surrounded in

extern "C" {

}

guards then I get a link error complaining that the functions defined
here are duplicate symbols, once in fs.o and once in function_remapper.o.
For example:

ld: duplicate symbol _futimens in generated/objects/darwin/x86_64/release/build/libroot/libroot_build_function_remapper.a(function_remapper.o) and generated/objects/darwin/x86_64/release/build/libroot/libroot_build.a(fs.o) for architecture x86_64

I'm not sure why that is.

Add fopendir() to fs_darwin.cpp and fix symlinkat().

This completes 2/3 of #8857 and is courtesy of nielx.

Make private helper function static in fs_darwin.cpp in order to not pollute
the public namespace.

Use a stack variable of MAXPATHLEN size to hold the full path to avoid having to manually malloc and free the variable.

Style fixes suggested by Axeld.
Added Ingo to the copyright
Updated copyright year to 2012 for my contribution.

Fix flag checking in fs_darwin.cpp
Somehow this commit got left out in my earlier push.

Fix build on Mac OS X 10.6 gcc2 and gcc4 and 10.7 gcc4 by adding some Mac OS X specific files that implement missing *at() functions.
Mac OS X 10.7 generates a gcc2 cross-compiler that fails when assigning NULL to a static method pointer so is still broken.
Added a weak attribute in driver_settings.cpp.
Move futimesat() from fs.cpp to fs_darwin.cpp since it is implimented on FreeBSD.
Implemented eaccess(), for the AT_EACCESS flag of faccessat()
Fix configure script to correctly detect case-sensitive file system

Move the invalid fd check to after checking if fd == AT_FDCWD in the fchownat() function

Implement the rest of chmod AT_SYMLINK_NOFOLLOW flag, fix the flag error detection code, a few comment changes.

Implement the AT_SYMLINK_NOFOLLOW flag to fchmodat() by calling open at fchmod emulating lchmod()

Fix build error and implement AT_SYMLINK_NO_FOLLOW in fstatat() by calling lstat()

Check for valid flags in faccessat() and fchmodat() and implement AT_SYMLINK_NOFOLLOW in fatchownat() using lchown().

Use S_ISDIR instead of S_IFDIR to check if the fd points to a directory and take AT_SYMLINK_NO_FOLLOW out of faccessat because IEEE Std 1003.1-2008 doesn't call for it even though Linux implements it.

Error if file descriptor is negative after checking for AT_FDCWD

Refactor so that all methods call a common get_path method to grab the full path from the fd and relative path string

insert a / between the directory path and relative path. in faccessat() use dirpath at the end, not path.

Reverse logic when checking if dirst points to a directory.

Check if flags bitmap != 0, not that it does == 0

Error if unsupported flag is passed to fstatat()

Cleanup the flags and make them the same as FreeBSD

Explicitly check path against NULL instead of relying on boolality. Yes, I just made that word up.

Rename to and from to old and new in order to be consistant with Linux.

Fix memory leak for the full path including fd directory.

Implement linkat()

Implement renameat()

Remove extraneous line where I called just unlinkat()

Implement unlinkat()

Implement symlinkat()

Implement readlinkat()

Implemented eaccess(), the AT_EACCESS flag of faccessat(), fchmodat(), fchownat(), fstatat(), mkdirat(), mkfifoat(), mknodat(), and futimesat().

Check to see that fd points to a directory before resolving the full path.

Implement a basic faccessat method. There are still a few missing pieces to it.

Don't return 0 for the unimplemented *at() functions, set errno to ENOSYS (not implemented) and return -1 instead.

Move futimesat() from fs.cpp to fs_darwin.cpp since it is implimented on FreeBSD. It is stubbed out for now.

Fix build by adding some Mac OS X specific files that implement fs function missing on that OS. The functions are stubbed out currently and have not been implemented. However, it does build now. I also added a weak attribute in driver_settings.cpp that I have no idea what does but was necessary to fix the build.