webpositive: Fix for HaikuWebKit 1.8.1

Change-Id: I00b2b01bf84e0d22ec759511b2f9435403207c95
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4150
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>

webpositive: force download window on screen.

* When Download window is initially shown, it is correctly
fully onscreen; however, adding a download resizes the
window such that it becomes partially offscreen. Now,
when the frame is resized, reposition the window onscreen
again.

Fixes #12704

Web+: changed string in Downloads window

While "Hide" may be technically more correct, "Close" is more
widely used in Haiku and accurately describes what the user
sees.

WebPositive: Ensure the downloads window is onscreen.

Fixes #12704.

Activate download window when starting a download.

Fixes #9575.

WebPositive: Removed wrong license text from all files ...

... which were technically never distributed by Apple nor
are derived from code distributed by Apple. Only BrowserApp
and BrowserWindow were originally derived from code that used
to be part of WebKit and was distributed by Apple.

Close alerts with ESCAPE key.

Added SetFlags(B_CLOSE_ON_ESCAPE) or SetShortcut(index, B_ESCAPE) to BAlerts
depending if the result gets used later in the code, or if it's a one-button
BAlert.

Add localization support to WebPositive, patch by Humdinger

* Includes style fixes
* Functional fixes by myself, patch wouldn't build

Layout fixes that hadn't yet been committed.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@548 94f232f2-1747-11df-bad5-a5bfde151594

Changed download short cut from J to D, as all the rest of the shortcuts make
more sense and don't necessarily follow Firefox conventions.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@523 94f232f2-1747-11df-bad5-a5bfde151594

* When downloads are still in progress, warn the user when the app quits and
allow to continue downloading.
* If the Downloads window is the only window, minimize on close instead of
hiding without any way to get the window back.
* Added menu item "New browser window" to Downloads window.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@512 94f232f2-1747-11df-bad5-a5bfde151594

Use Cmd-J for hiding the downloads window. (Ticket #37)

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@507 94f232f2-1747-11df-bad5-a5bfde151594

* Changed the implementation of context menus in DownloadProgressViews. The views
were intercepting mouse messages even if the window was not showing. Now
secondary clicks are intercepted in DownloadWindow and the target view is found,
which makes this much cheaper.
* Offset context menus by 2 pixels, so the mouse does not start directly over
an item.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@488 94f232f2-1747-11df-bad5-a5bfde151594

Replace the remaining places where the string was redefined.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@395 94f232f2-1747-11df-bad5-a5bfde151594

Use the new SettingsKeys.h also in the DownloadsWindow.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@394 94f232f2-1747-11df-bad5-a5bfde151594

Move variable declaration into proper scope and where it's first needed.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@357 94f232f2-1747-11df-bad5-a5bfde151594

* Scroll the downloads which just started into view.
* Delete the progress view when init fails.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@356 94f232f2-1747-11df-bad5-a5bfde151594

Manually removing downloads needs to trigger checking the button enabled status
in the download window.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@354 94f232f2-1747-11df-bad5-a5bfde151594

Implemented displaying the download speed and estimated finish time. Looks and
behaves the same as in Tracker's status window.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@352 94f232f2-1747-11df-bad5-a5bfde151594

Moved DownloadProgressView and related private classes out into their own source
file.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@350 94f232f2-1747-11df-bad5-a5bfde151594

Following another suggestion by Axel: Check if a download file is being moved
into the trash. If it's still in progress, cancel it. Dim the icon in any case.
Undim the icon if a download is moved back out of the trash (restarting still
has to happen manually).

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@348 94f232f2-1747-11df-bad5-a5bfde151594

Removing finished or missing downloads may have to disable the respective
other button.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@347 94f232f2-1747-11df-bad5-a5bfde151594

* An unfinished download is no longer considered finished, just because it isn't
currently in progress anymore.
* Added feature to remove "missing" downloads, i.e. those for which no
corresponding file exists.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@346 94f232f2-1747-11df-bad5-a5bfde151594

Just follow a moved download file, as Axel suggested.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@345 94f232f2-1747-11df-bad5-a5bfde151594

Added node monitoring to downloads window.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@344 94f232f2-1747-11df-bad5-a5bfde151594

Adjust the steps of the downloads window scrollbar.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@343 94f232f2-1747-11df-bad5-a5bfde151594

* Finished testing of downloads interaction with listener and removed debug
output.
* Optimized download restoration at program start and moved it into download
window thread in order not to block app startup.
* Downloads which have been removed meanwhile, are displayed with dimmed icon,
and the option to Restart it is given.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@342 94f232f2-1747-11df-bad5-a5bfde151594

Work in progress on better download management...
* Allow to specify the downloads folder in the General settings page.
* Added necessary wiring.
* The listener notification was not synchronous anymore because of mixed
up default function params in BWebPage.
* Added temporary debug output to WebDownloadPrivate.cpp... the restarting
downloads code path needs testing yet.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@341 94f232f2-1747-11df-bad5-a5bfde151594

Converted to Haiku coding style.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@337 94f232f2-1747-11df-bad5-a5bfde151594

* Made BWebPage download related methods and listener member static.
* Introduced BWebPage::RequestDownload() public API (expected to run
synchronous).
* Added necessary wiring for "Download this link" in context menus.
* Restarting downloads works in principle, although with some quirks.
(Sometimes it appears the "Desktop" is being downloaded...)

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@310 94f232f2-1747-11df-bad5-a5bfde151594

The BWebDownload was using BWebPage for stuff, but the BWebPage can be long
gone when a BWebDownload wanted to use it. Now the class is more self-sufficient.
One example of the problem was clicking a link that opens a blank page, then
closing that page while the download was still loading. 1) The download finished
notification never arrived and 2) clicking to cancel the download would crash
after the download finished, since really it had already selfdestructed...

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@240 94f232f2-1747-11df-bad5-a5bfde151594

Manually update to the r238 state, so that we can rebase next commits on top of it

Original commit message of r238:

Split up WebPositive from HaikuLauncher. HaikuLauncher is back to it's simple
self. WebPositive uses a new WebPositive folder in config/settings. Otherwise,
everything should be as before. LauncherWindow and LauncherApp have been renamed
and cleaned up for the Haiku coding style.

* Refactored WebDownload into BWebDownload and BPrivate::WebDownloadPrivate.
* Fixed a bug where the "Remove Finished" button in the downloads window would
be wrongly disabled whenever a new download started.
* Implemented cancelling downloads.
* Prepared restarting downloads as far as the GUI goes. Need to research this
first how a download can be triggered independently from anything else in
WebCore...


git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@196 94f232f2-1747-11df-bad5-a5bfde151594

* Began renaming some public API with the B* prefix and using the Haiku coding
style. (WebPage -> BWebPage). Documented what needs to go where in WebPage.h.
* Moved misplaced functionality from WebFrame to BWebPage (navigation).
* EditorClientHaiku takes a BWebPage pointer now, which brings a slight cleanup.
* Exposed WebFrame::isEditable() to EditorClientHaiku, so isEditable() can be
implemented.
* Added some asserts in FrameLoaderClientHaiku according to the Gtk port and
placed some debug output.


git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@150 94f232f2-1747-11df-bad5-a5bfde151594

Renamed WebProcess to WebPage.


git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@146 94f232f2-1747-11df-bad5-a5bfde151594

* Use hiding instead of minimizing for the Download window.
* Auto-show and auto-move-to-current-workspace when a download starts.


git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@61 94f232f2-1747-11df-bad5-a5bfde151594

* Now stores the URL of downloads in the DownloadProgressView and in the settings,
so that we can eventually restart downloads.
* Checks if a downloaded file already has a previous download and replaces it.
(Actually, this should take the path into account, not only URL.)
* Stores the URL as "META:url" attribute, as the good old NetPositive did.


git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@60 94f232f2-1747-11df-bad5-a5bfde151594

* DownloadWindow is now very usable.
* Fixed the scroll view look and behavior.
* Downloads are persistent.


git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@59 94f232f2-1747-11df-bad5-a5bfde151594

More work on the download window GUI. The scroll view is broken, downloads are
not persistent.
Resolved TODO in WebProcess about race condition when dispatching download
notifications. Just block until there is a reply. WebDownload pointers are
just used for extracting information at init time, and then later only as
cookie to match view and download. Although as soon as we want to cancel downloads,
refcounting may become necessary again.


git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@57 94f232f2-1747-11df-bad5-a5bfde151594

Make the Download Window accessible from every window. Bring it to the workspace
that the window is on that send the request to show it. Remember the size and
if it was showing across sessions.


git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@56 94f232f2-1747-11df-bad5-a5bfde151594

First basic GUI download progress display...


git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@54 94f232f2-1747-11df-bad5-a5bfde151594

Future public API for interfacing with WebKit on Haiku. (What will eventually
become BWebView.) Compared to the original port, the threading has been
completely redesigned such that all interaction with WebKit happens in the
application thread, as required by the PThread threading backend. This is
counteracted by using an offscreen BBitmap/view as the top-level GraphicsContext
for each Page, such that drawing is performed in various app_server threads
asynchronously. WebViewWindow provides as a target for messages from within
WebKit (mostly FrameLoaderClientHaiku events), which are forwarded via virtual
hook methods (implemented in LauncherWindow.cpp of the HaikuLauncher).


git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@6 94f232f2-1747-11df-bad5-a5bfde151594

Activate download window when starting a download.

Fixes #9575.

WebPositive: Removed wrong license text from all files ...

... which were technically never distributed by Apple nor
are derived from code distributed by Apple. Only BrowserApp
and BrowserWindow were originally derived from code that used
to be part of WebKit and was distributed by Apple.

Close alerts with ESCAPE key.

Added SetFlags(B_CLOSE_ON_ESCAPE) or SetShortcut(index, B_ESCAPE) to BAlerts
depending if the result gets used later in the code, or if it's a one-button
BAlert.

Add localization support to WebPositive, patch by Humdinger

* Includes style fixes
* Functional fixes by myself, patch wouldn't build

Layout fixes that hadn't yet been committed.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@548 94f232f2-1747-11df-bad5-a5bfde151594

Changed download short cut from J to D, as all the rest of the shortcuts make
more sense and don't necessarily follow Firefox conventions.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@523 94f232f2-1747-11df-bad5-a5bfde151594

* When downloads are still in progress, warn the user when the app quits and
allow to continue downloading.
* If the Downloads window is the only window, minimize on close instead of
hiding without any way to get the window back.
* Added menu item "New browser window" to Downloads window.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@512 94f232f2-1747-11df-bad5-a5bfde151594

Use Cmd-J for hiding the downloads window. (Ticket #37)

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@507 94f232f2-1747-11df-bad5-a5bfde151594

* Changed the implementation of context menus in DownloadProgressViews. The views
were intercepting mouse messages even if the window was not showing. Now
secondary clicks are intercepted in DownloadWindow and the target view is found,
which makes this much cheaper.
* Offset context menus by 2 pixels, so the mouse does not start directly over
an item.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@488 94f232f2-1747-11df-bad5-a5bfde151594

Replace the remaining places where the string was redefined.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@395 94f232f2-1747-11df-bad5-a5bfde151594

Use the new SettingsKeys.h also in the DownloadsWindow.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@394 94f232f2-1747-11df-bad5-a5bfde151594

Move variable declaration into proper scope and where it's first needed.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@357 94f232f2-1747-11df-bad5-a5bfde151594

* Scroll the downloads which just started into view.
* Delete the progress view when init fails.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@356 94f232f2-1747-11df-bad5-a5bfde151594

Manually removing downloads needs to trigger checking the button enabled status
in the download window.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@354 94f232f2-1747-11df-bad5-a5bfde151594

Implemented displaying the download speed and estimated finish time. Looks and
behaves the same as in Tracker's status window.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@352 94f232f2-1747-11df-bad5-a5bfde151594

Moved DownloadProgressView and related private classes out into their own source
file.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@350 94f232f2-1747-11df-bad5-a5bfde151594

Following another suggestion by Axel: Check if a download file is being moved
into the trash. If it's still in progress, cancel it. Dim the icon in any case.
Undim the icon if a download is moved back out of the trash (restarting still
has to happen manually).

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@348 94f232f2-1747-11df-bad5-a5bfde151594

Removing finished or missing downloads may have to disable the respective
other button.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@347 94f232f2-1747-11df-bad5-a5bfde151594

* An unfinished download is no longer considered finished, just because it isn't
currently in progress anymore.
* Added feature to remove "missing" downloads, i.e. those for which no
corresponding file exists.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@346 94f232f2-1747-11df-bad5-a5bfde151594

Just follow a moved download file, as Axel suggested.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@345 94f232f2-1747-11df-bad5-a5bfde151594

Added node monitoring to downloads window.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@344 94f232f2-1747-11df-bad5-a5bfde151594

Adjust the steps of the downloads window scrollbar.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@343 94f232f2-1747-11df-bad5-a5bfde151594

* Finished testing of downloads interaction with listener and removed debug
output.
* Optimized download restoration at program start and moved it into download
window thread in order not to block app startup.
* Downloads which have been removed meanwhile, are displayed with dimmed icon,
and the option to Restart it is given.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@342 94f232f2-1747-11df-bad5-a5bfde151594

Work in progress on better download management...
* Allow to specify the downloads folder in the General settings page.
* Added necessary wiring.
* The listener notification was not synchronous anymore because of mixed
up default function params in BWebPage.
* Added temporary debug output to WebDownloadPrivate.cpp... the restarting
downloads code path needs testing yet.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@341 94f232f2-1747-11df-bad5-a5bfde151594

Converted to Haiku coding style.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@337 94f232f2-1747-11df-bad5-a5bfde151594

* Made BWebPage download related methods and listener member static.
* Introduced BWebPage::RequestDownload() public API (expected to run
synchronous).
* Added necessary wiring for "Download this link" in context menus.
* Restarting downloads works in principle, although with some quirks.
(Sometimes it appears the "Desktop" is being downloaded...)

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@310 94f232f2-1747-11df-bad5-a5bfde151594

The BWebDownload was using BWebPage for stuff, but the BWebPage can be long
gone when a BWebDownload wanted to use it. Now the class is more self-sufficient.
One example of the problem was clicking a link that opens a blank page, then
closing that page while the download was still loading. 1) The download finished
notification never arrived and 2) clicking to cancel the download would crash
after the download finished, since really it had already selfdestructed...

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@240 94f232f2-1747-11df-bad5-a5bfde151594

Manually update to the r238 state, so that we can rebase next commits on top of it

Original commit message of r238:

Split up WebPositive from HaikuLauncher. HaikuLauncher is back to it's simple
self. WebPositive uses a new WebPositive folder in config/settings. Otherwise,
everything should be as before. LauncherWindow and LauncherApp have been renamed
and cleaned up for the Haiku coding style.

* Refactored WebDownload into BWebDownload and BPrivate::WebDownloadPrivate.
* Fixed a bug where the "Remove Finished" button in the downloads window would
be wrongly disabled whenever a new download started.
* Implemented cancelling downloads.
* Prepared restarting downloads as far as the GUI goes. Need to research this
first how a download can be triggered independently from anything else in
WebCore...


git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@196 94f232f2-1747-11df-bad5-a5bfde151594

* Began renaming some public API with the B* prefix and using the Haiku coding
style. (WebPage -> BWebPage). Documented what needs to go where in WebPage.h.
* Moved misplaced functionality from WebFrame to BWebPage (navigation).
* EditorClientHaiku takes a BWebPage pointer now, which brings a slight cleanup.
* Exposed WebFrame::isEditable() to EditorClientHaiku, so isEditable() can be
implemented.
* Added some asserts in FrameLoaderClientHaiku according to the Gtk port and
placed some debug output.


git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@150 94f232f2-1747-11df-bad5-a5bfde151594

Renamed WebProcess to WebPage.


git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@146 94f232f2-1747-11df-bad5-a5bfde151594

* Use hiding instead of minimizing for the Download window.
* Auto-show and auto-move-to-current-workspace when a download starts.


git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@61 94f232f2-1747-11df-bad5-a5bfde151594

* Now stores the URL of downloads in the DownloadProgressView and in the settings,
so that we can eventually restart downloads.
* Checks if a downloaded file already has a previous download and replaces it.
(Actually, this should take the path into account, not only URL.)
* Stores the URL as "META:url" attribute, as the good old NetPositive did.


git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@60 94f232f2-1747-11df-bad5-a5bfde151594

* DownloadWindow is now very usable.
* Fixed the scroll view look and behavior.
* Downloads are persistent.


git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@59 94f232f2-1747-11df-bad5-a5bfde151594

More work on the download window GUI. The scroll view is broken, downloads are
not persistent.
Resolved TODO in WebProcess about race condition when dispatching download
notifications. Just block until there is a reply. WebDownload pointers are
just used for extracting information at init time, and then later only as
cookie to match view and download. Although as soon as we want to cancel downloads,
refcounting may become necessary again.


git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@57 94f232f2-1747-11df-bad5-a5bfde151594

Make the Download Window accessible from every window. Bring it to the workspace
that the window is on that send the request to show it. Remember the size and
if it was showing across sessions.


git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@56 94f232f2-1747-11df-bad5-a5bfde151594

First basic GUI download progress display...


git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@54 94f232f2-1747-11df-bad5-a5bfde151594

Future public API for interfacing with WebKit on Haiku. (What will eventually
become BWebView.) Compared to the original port, the threading has been
completely redesigned such that all interaction with WebKit happens in the
application thread, as required by the PThread threading backend. This is
counteracted by using an offscreen BBitmap/view as the top-level GraphicsContext
for each Page, such that drawing is performed in various app_server threads
asynchronously. WebViewWindow provides as a target for messages from within
WebKit (mostly FrameLoaderClientHaiku events), which are forwarded via virtual
hook methods (implemented in LauncherWindow.cpp of the HaikuLauncher).


git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@6 94f232f2-1747-11df-bad5-a5bfde151594