TextSearch: improve edge-case in opening of "Set target" BFilePanel.

Do not fail silently if the saved fFilePanelPath doesn't exists, or
otherwise can't be used.

Default to B_USER_DIRECTORY, and print the issue to stdout at least.

Change-Id: If08720fa0d6d91bb7bd4b5a922be7136012aae95
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7536
Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>

TextSearch: do not trigger new grep searches unnecessarily.

Opening and closing a file from the results window with Pe, for
example, was triggering unnecessary new grep searches, when only
the attributes or other metadata on the file got changed (and
not its content).

That new search was also changing the focus from the results view
to the search field (making one lose the position on that list,
specially annoying with large number of results).

Avoid that by not monitoring/reacting to B_ATTR_CHANGED, and not
reacting to B_STAT_CHANGED if the only flag is B_STAT_CHANGE_TIME.

Change-Id: I56d34c93da94acf36890abe458da45d26a334593
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5763
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>

TextSearch: add option to set target to parent directory

Two usage scenarios:

* Wrong directory selected when invoking as Tracker add-on.
I often find myself having TextSearch invoked on selected child,
when I wanted it to open in parent context.
* Result was not found in target directory, so maybe the search
should be broader.

Change-Id: I2621f3cec7459572ddae438de4ba42ce74432e28
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3044
Reviewed-by: humdinger <humdingerb@gmail.com>

TextSearch: change Select all shortcut

Anecdotal: whenever I hit Cmd+A with text field focused I want to
quickly select search phrase, not the results. In fact I never found
myself in a situation where the latter is the desired outcome.
Change-Id: Ib5edcee8e7366485181cb2030ecfa989619cd600
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3043
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>

TextSearch: translate system name of the app

Change-Id: I2d120b8b92af8cecc8c55ed9ff8ed829f30456c2
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2686
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>

TextSearch: don't hard-code Pe editor

When double-clicking a result in TextSearch, it opens the file with
the preferred application for that file type. In case you search
through e.g. a HTML file, that would be most probably WebPositive,
which is not what you want normally.

TextSearch has the setting "Open files in Pe" which forces all files
to be opened in the Pe editor.

With this change, it will force the files to be opened in the
preferred app for text/x-source-code.

Change-Id: I0920a5f2497c01b16be0ac7563fbab942b67ef24
Reviewed-on: https://review.haiku-os.org/769
Reviewed-by: waddlesplash <waddlesplash@gmail.com>

TextSearch: fix bug with filenames containing ' or " or \

* Style policy
* Add more error checking
* Increase default directories stack depth

TextSearch: fix build

TextSearch: avoid calling ChangesIterator's method when null

Fixes #9874

TextSearch: several small improvements

* Wakeup periodically search thread, cancelling should be
more responsive now...
* Show Lines setting is now saved too
* Fix a bug, current file is display again while searching.
* Always pass line number, if any, to invoked app.
Works with StyledEdit as with Pe.

Partially fix #13289.
Another change will add "open with" context menu and remove "Open with Pe".

TextSearch: way speeder by using xargs + grep

* Previously, each file was starting a shell to run grep
command on it. Very suboptimal performance, big overhead.
* Now a thread write each file path to xargs input,
while another start xargs, let it distribute files on
grep processes (one per cpu) and collect results asap.
* This bring results way faster than previously.
* Rename Escape Text setting into Regular Expression, as
name was more after shell workaround than after function.
* While it doesn't use a native text searching, by
reusing both grep and xargs power, it answer the main
issue with #9529.

Use B_USE_WINDOW_SPACING

Use B_USE_WINDOW_SPACING as inset from contents to window border.
Some whitespace cleanup.

Revert "TextSearch: use BString-based searching instead of Grep-based."

This reverts commit 1e9f5f5be4c8419c2085f51c78c9ac02ef13377b.
As per discussion on the ML.

TextSearch: use BString-based searching instead of Grep-based.

Huge performance improvement. Fixes #9529.

TextSearch: use the layout API.

TextSearch: normalize copyright headers.

TextSearch: remove legacy Translation.h.

TextSearch: trim trailing whitespace.

TextSearch: don't save the 'show contents' option.

Also get rid of the redundant menu option.

Coding style fixes

Truncate names of files/folders that are being grep'ed

Show search term in window tab

Don't create filename entries without actual matches.

Added an early return in GrepWindow::_OnReportResult(BMessage* message)
in case the report message does not contain matches.

Signed-off-by: Stephan Aßmus <superstippi@gmx.de>

Close alerts with ESCAPE key.

Added SetFlags(B_CLOSE_ON_ESCAPE) or SetShortcut(index, B_ESCAPE) to BAlerts
depending if the result gets used later in the code, or if it's a one-button
BAlert.

More catalog-related cleanup.

* rename B_TRANSLATE_CONTEXT to B_TRANSLATION_CONTEXT and
B_TRANSLATE_WITH_CONTEXT to B_TRANSLATE_CONTEXT, squashing a TODO
* adjust all uses of both macros in Haiku's source tree
* use correct header guard for collecting/Catalog.h

The renamed macros require adjustments to all external applications
using catalogs.

Removing most About windows and menu items as discussed here
http://www.freelists.org/post/haiku-commits/r40968-in-haikutrunksrcapps-activitymonitor-bootmanager-charactermap-codycam-deskbar,3
Leaving them for now in replicants, and in Terminal, according to (my interpretation of) the instructions here
http://dev.haiku-os.org/browser/haiku/trunk/src/apps/terminal/README.GPL_to_OBOS#L70
Some sporadic cleanup.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41108 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Improved ambiguous commands in Icon-O-Matic. A direction like left/right
when rotating indices doesn't always make sense. Think of an "8" shape.
Reordered these items to give the correct shortcut order Alt+R - Shift+Alt+R.
* More localizing of strings in ActivityMonitor and Expander.
* TextSearch had problems with the search button being to small if one of the
translated strings for Search/Cancel get's bigger than the other. Now resizes
after toggling.
* FileTypes missed a file for the catalog in the Jamfile.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40441 a95241bf-73f2-0310-859d-f6bbb57e9c96

Reverted part of r37829, because using B_COPY to copy selected entries in the hitslist makes it impossible to copy the search string in the text box. Oops.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37850 a95241bf-73f2-0310-859d-f6bbb57e9c96

Changed some menu strings and the shortcut to copy the selected text to the clipboard from B to C. Fixes #6404 and #6406.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37829 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Update all applications in tree to use the new localizing system
* Remove the old one from the locale librairy, with some cleanup
Known regressions :
* readonlybootprompt will no longer update the locale settings : the
method used messed with internal undocumented things
* external localized apps (webpositive for example) will not run
anymore.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37336 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Add DoCatalogs call for dstcheck
* Patch by Jorma Karvonnen with some tweaks from me : localize TextSearch


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37302 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by Humdinger:
Updated Haiku apps to use sentence-case. What a huge undertaking...
The files where I had to apply the patch manually (for mysterious
reasons) have also gotten a whitespace cleanup. I've proof-read
everything so hopefully there should be no problems.

This should be the final part of #5169.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35049 a95241bf-73f2-0310-859d-f6bbb57e9c96

Spotted a few left-over occurences of the previous names: TrackerGrep and Tracker Grep. Simplified the About window: Version is no longer essential. Its simply part of Haiku now. The name is more self-explanatory now, so there is no need to explain the purpose of the application in the About window. Removed the mention of myself as the maintainer, as its maintained collectively by Haiku now. Moved myself into the list of contributors, after Oliver Tappe, which I think is chronologically correct. If the primary copyright holder was Haiku and not Matthijs Hollemans, it would have been appropriate to use Haikus BAboutWindow, but alas.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29932 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed the layout/width of the search string text view.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28028 a95241bf-73f2-0310-859d-f6bbb57e9c96

* fix some mem leaks



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27858 a95241bf-73f2-0310-859d-f6bbb57e9c96

* whitespace cleanup



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27857 a95241bf-73f2-0310-859d-f6bbb57e9c96

* GrepWindow::_AreAllFoldersOpenInTracker() could still leak entry_refs,
even in not unlikely situations.
* GrepWindow::_SelectFilesInTracker() was still leaking entry_refs in the
success code path.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27577 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed CID 1294 and 1295: delete the entry_ref on the terminating conditions.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27433 a95241bf-73f2-0310-859d-f6bbb57e9c96

Node monitoring changes:
* In the ChangesIterator, just remove removed files from the HashMap, regardless
if they could be considered "temporary" or not.
* If a file is removed, we can directly remove it from the results list. This
makes removing files from the result list more robust and quicker if this
was the only thing that happened with regards to node monitoring (the grep
process does not need to be run again).
* Refactored removing result items from the list on result notifications.
* Beginnings of supporting moving files within the watched folder hierarchy.
If they were just moved, the new location should update in the list.
(not well tested)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27377 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Added more tracing facilities (Function enter/exit printer)
* Decreased the node monitor activity timeout to 150 ms
* _StartNodeMonitoring() simply starts watching the root folder with the
B_WATCH_RECURSIVELY flag set. (Requires forthcomming changes to
BPathMonitor, but it was broken anyways.)
* _StopNodeMonitoring() returns early if node monitoring is inactive.
* When node monitoring is started after a search finished, it is done
asynchronous, since messing with the other controls results in modification
messages that otherwise stop node monitoring again. Now the message is
inserted last and works reliably.
* When receiving B_PATH_MONITOR messages, they are supposed to simply contain
a "path" field with the full path to the node that changed. That's not
currently the case with BPathMonitor, but I will commit that stuff next.
(Was broken before anyways.)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26935 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Turn the debug output for node monitoring optional tracing.
* Output something if the node monitor message does not contain the expected
fields (Haiku node monitoring is soo much easier...)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26869 a95241bf-73f2-0310-859d-f6bbb57e9c96

Stop node monitoring when the model changes.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26846 a95241bf-73f2-0310-859d-f6bbb57e9c96

Finished implementing and enabled node monitoring on the folders and files
of the current search. If new files match the pattern, the appear in the
results, or are removed if they don't match anymore. The results also
adapt to changes in the files.
Basically, I added another iterator that is also used to track changes when
node monitor events arrive. Only those changed files are grepped again after
a timeout of .5 seconds when no new node monitor events pour in.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26809 a95241bf-73f2-0310-859d-f6bbb57e9c96

Intermediate commit, because I want to rename FolderIterator but it has changes.
* Beginnings of node monitoring support. Currently disabled, but detects
new, changed and removed files. Folders untested yet. There may also be
a problem with the toplevel folders when a pose selection message is used.
That's untested too as of yet.
* Removed some superfluous whitespace.
* Small refactoring in FolderIterator to access some stuff from the outside
as well.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26795 a95241bf-73f2-0310-859d-f6bbb57e9c96

Refactoring
* FileIterator is now a mostly abstract interface
* FolderIterator is the currently only implementation (there could be
MessageIterator for an even better separation, which would read the top
level search folders from the BMessage with the selected poses, but it
would mostly use the same code for traversing the subfolders anyways so I
left that for the time being.)
* The Grepper and FolderIterator now copy the current settings from the Model
at instantiation. Since they run in a separate thread and the Model may
actually be changed from the Window thread, I think this is just a cleaner
and more safe solution.
* Cleanup here and there.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26786 a95241bf-73f2-0310-859d-f6bbb57e9c96

Refactored a new class FileIterator from Grepper that will make adding
node monitoring easier. Also, FileIterator will be split to make the code
cleaner with regards to folder or selection mode.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26752 a95241bf-73f2-0310-859d-f6bbb57e9c96

Moved TextSearch to apps folder, since it's actually a regular app.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26738 a95241bf-73f2-0310-859d-f6bbb57e9c96

Revert "TextSearch: use BString-based searching instead of Grep-based."

This reverts commit 1e9f5f5be4c8419c2085f51c78c9ac02ef13377b.
As per discussion on the ML.

TextSearch: use BString-based searching instead of Grep-based.

Huge performance improvement. Fixes #9529.

TextSearch: use the layout API.

TextSearch: normalize copyright headers.

TextSearch: remove legacy Translation.h.

TextSearch: trim trailing whitespace.

TextSearch: don't save the 'show contents' option.

Also get rid of the redundant menu option.

Coding style fixes

Truncate names of files/folders that are being grep'ed

Show search term in window tab

Don't create filename entries without actual matches.

Added an early return in GrepWindow::_OnReportResult(BMessage* message)
in case the report message does not contain matches.

Signed-off-by: Stephan Aßmus <superstippi@gmx.de>

Close alerts with ESCAPE key.

Added SetFlags(B_CLOSE_ON_ESCAPE) or SetShortcut(index, B_ESCAPE) to BAlerts
depending if the result gets used later in the code, or if it's a one-button
BAlert.

More catalog-related cleanup.

* rename B_TRANSLATE_CONTEXT to B_TRANSLATION_CONTEXT and
B_TRANSLATE_WITH_CONTEXT to B_TRANSLATE_CONTEXT, squashing a TODO
* adjust all uses of both macros in Haiku's source tree
* use correct header guard for collecting/Catalog.h

The renamed macros require adjustments to all external applications
using catalogs.

Removing most About windows and menu items as discussed here
http://www.freelists.org/post/haiku-commits/r40968-in-haikutrunksrcapps-activitymonitor-bootmanager-charactermap-codycam-deskbar,3
Leaving them for now in replicants, and in Terminal, according to (my interpretation of) the instructions here
http://dev.haiku-os.org/browser/haiku/trunk/src/apps/terminal/README.GPL_to_OBOS#L70
Some sporadic cleanup.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41108 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Improved ambiguous commands in Icon-O-Matic. A direction like left/right
when rotating indices doesn't always make sense. Think of an "8" shape.
Reordered these items to give the correct shortcut order Alt+R - Shift+Alt+R.
* More localizing of strings in ActivityMonitor and Expander.
* TextSearch had problems with the search button being to small if one of the
translated strings for Search/Cancel get's bigger than the other. Now resizes
after toggling.
* FileTypes missed a file for the catalog in the Jamfile.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40441 a95241bf-73f2-0310-859d-f6bbb57e9c96

Reverted part of r37829, because using B_COPY to copy selected entries in the hitslist makes it impossible to copy the search string in the text box. Oops.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37850 a95241bf-73f2-0310-859d-f6bbb57e9c96

Changed some menu strings and the shortcut to copy the selected text to the clipboard from B to C. Fixes #6404 and #6406.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37829 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Update all applications in tree to use the new localizing system
* Remove the old one from the locale librairy, with some cleanup
Known regressions :
* readonlybootprompt will no longer update the locale settings : the
method used messed with internal undocumented things
* external localized apps (webpositive for example) will not run
anymore.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37336 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Add DoCatalogs call for dstcheck
* Patch by Jorma Karvonnen with some tweaks from me : localize TextSearch


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37302 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by Humdinger:
Updated Haiku apps to use sentence-case. What a huge undertaking...
The files where I had to apply the patch manually (for mysterious
reasons) have also gotten a whitespace cleanup. I've proof-read
everything so hopefully there should be no problems.

This should be the final part of #5169.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35049 a95241bf-73f2-0310-859d-f6bbb57e9c96

Spotted a few left-over occurences of the previous names: TrackerGrep and Tracker Grep. Simplified the About window: Version is no longer essential. Its simply part of Haiku now. The name is more self-explanatory now, so there is no need to explain the purpose of the application in the About window. Removed the mention of myself as the maintainer, as its maintained collectively by Haiku now. Moved myself into the list of contributors, after Oliver Tappe, which I think is chronologically correct. If the primary copyright holder was Haiku and not Matthijs Hollemans, it would have been appropriate to use Haikus BAboutWindow, but alas.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29932 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed the layout/width of the search string text view.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28028 a95241bf-73f2-0310-859d-f6bbb57e9c96

* fix some mem leaks



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27858 a95241bf-73f2-0310-859d-f6bbb57e9c96

* whitespace cleanup



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27857 a95241bf-73f2-0310-859d-f6bbb57e9c96

* GrepWindow::_AreAllFoldersOpenInTracker() could still leak entry_refs,
even in not unlikely situations.
* GrepWindow::_SelectFilesInTracker() was still leaking entry_refs in the
success code path.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27577 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed CID 1294 and 1295: delete the entry_ref on the terminating conditions.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27433 a95241bf-73f2-0310-859d-f6bbb57e9c96

Node monitoring changes:
* In the ChangesIterator, just remove removed files from the HashMap, regardless
if they could be considered "temporary" or not.
* If a file is removed, we can directly remove it from the results list. This
makes removing files from the result list more robust and quicker if this
was the only thing that happened with regards to node monitoring (the grep
process does not need to be run again).
* Refactored removing result items from the list on result notifications.
* Beginnings of supporting moving files within the watched folder hierarchy.
If they were just moved, the new location should update in the list.
(not well tested)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27377 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Added more tracing facilities (Function enter/exit printer)
* Decreased the node monitor activity timeout to 150 ms
* _StartNodeMonitoring() simply starts watching the root folder with the
B_WATCH_RECURSIVELY flag set. (Requires forthcomming changes to
BPathMonitor, but it was broken anyways.)
* _StopNodeMonitoring() returns early if node monitoring is inactive.
* When node monitoring is started after a search finished, it is done
asynchronous, since messing with the other controls results in modification
messages that otherwise stop node monitoring again. Now the message is
inserted last and works reliably.
* When receiving B_PATH_MONITOR messages, they are supposed to simply contain
a "path" field with the full path to the node that changed. That's not
currently the case with BPathMonitor, but I will commit that stuff next.
(Was broken before anyways.)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26935 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Turn the debug output for node monitoring optional tracing.
* Output something if the node monitor message does not contain the expected
fields (Haiku node monitoring is soo much easier...)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26869 a95241bf-73f2-0310-859d-f6bbb57e9c96

Stop node monitoring when the model changes.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26846 a95241bf-73f2-0310-859d-f6bbb57e9c96

Finished implementing and enabled node monitoring on the folders and files
of the current search. If new files match the pattern, the appear in the
results, or are removed if they don't match anymore. The results also
adapt to changes in the files.
Basically, I added another iterator that is also used to track changes when
node monitor events arrive. Only those changed files are grepped again after
a timeout of .5 seconds when no new node monitor events pour in.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26809 a95241bf-73f2-0310-859d-f6bbb57e9c96

Intermediate commit, because I want to rename FolderIterator but it has changes.
* Beginnings of node monitoring support. Currently disabled, but detects
new, changed and removed files. Folders untested yet. There may also be
a problem with the toplevel folders when a pose selection message is used.
That's untested too as of yet.
* Removed some superfluous whitespace.
* Small refactoring in FolderIterator to access some stuff from the outside
as well.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26795 a95241bf-73f2-0310-859d-f6bbb57e9c96

Refactoring
* FileIterator is now a mostly abstract interface
* FolderIterator is the currently only implementation (there could be
MessageIterator for an even better separation, which would read the top
level search folders from the BMessage with the selected poses, but it
would mostly use the same code for traversing the subfolders anyways so I
left that for the time being.)
* The Grepper and FolderIterator now copy the current settings from the Model
at instantiation. Since they run in a separate thread and the Model may
actually be changed from the Window thread, I think this is just a cleaner
and more safe solution.
* Cleanup here and there.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26786 a95241bf-73f2-0310-859d-f6bbb57e9c96

Refactored a new class FileIterator from Grepper that will make adding
node monitoring easier. Also, FileIterator will be split to make the code
cleaner with regards to folder or selection mode.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26752 a95241bf-73f2-0310-859d-f6bbb57e9c96

Moved TextSearch to apps folder, since it's actually a regular app.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26738 a95241bf-73f2-0310-859d-f6bbb57e9c96