ShowImage: Apply i18n to number values

Also use multiplication sign for a nicer look

Change-Id: I526204832d4826f44a326f44037173418d8e2885
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7556
Haiku-Format: Haiku-format Bot <no-reply+haikuformatbot@haiku-os.org>
Reviewed-by: Niels Sascha Reedijk <niels.reedijk@gmail.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>

ShowImage: fix off-by-1 image placement

The image was placed 1 pixel to the right, resulting in a grey
vertical line appearing to the left of the image.

Fixes #18679

Change-Id: I02b1cb6bc898c48ff73ae114b2cda368ea636de7
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7118
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>

ShowImage: fix saving

As investigated and suggested by jackburton in ticket #14693:
outTranslator wasn't initialized correctly (due to type mismatch
on 64 bit platform).

Also set the image's file name as default in the save dialog.

Fixes #14693

Change-Id: I741e3616b935315a707ea3949a330d41d577fd91
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7102
Reviewed-by: waddlesplash <waddlesplash@gmail.com>

Add "Reset rating" menu item to MediaPlayer and ShowImage

Doesn't remove the rating BFS attribute from the file, just sets it to "0".

ShowImage: Move "Ratings" menu into a new "Attributes" menu, similar to
MediaPlayer.

Change-Id: I831166d88be9d18f1d302a423aa43929b7a1b255
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7092
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk>

ShowImage: Re-arrange menu items

* Moved "Use as background..." from "Image" to "File" menu.
"Image" holds items that affect the display of actual image
(rotate/flip). "Use as background..." doesn't.
* Move "Close" down above "Quit".

Change-Id: I23ddcc2cf03937322649ab289ef405f84c878dfb
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7090
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk>

ShowImage: Add "Open with..." menu

Populate a new sub-menu with all applications that support the current
image's MIME type. Launch the chosen app with the image entry_ref as
B_REFS_RECEIVED message.

The sub-menu listing supporting apps is separated into apps supporting
the supertype ("image/" and full support (e.g. "image/png").

Add the new "Open with..." menu to the "File" menu and the context menu
of the image.

Most of the code was grabbed from the FileType prefs PreferredAppMenu,
therefore its copyright was copied and extended.

Change-Id: I0190cf4b78c59e429f4e67654665598340653c5d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7072
Reviewed-by: Axel Dörfler <axeld@pinc-software.de>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>

ShowImage: Use layouts for the main view area.

The main window itself is still not using them,
due to incompatibilities with the toolbar animation.

Fixes #18547.

ShowImage: fix scrollbar size

Change-Id: I5c50bd9a842ce79d78b6e9c2227dc37e3c52c6e6
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3755
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>

ShowImage: Reset slide show delay if a user interferes

This change resets the delay when the user moves to next/previous image or
page within an image (e.g. TIFF) or deletes an image while a slide show is
running.

Fixes #16321
Change-Id: If0b8f4caef9c6aa4c0ad5bbb01d65bf43c1f831f
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2967
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>

ShowImage: Wrap to first image when going next on last image

I find this handy and in addition it makes the slide show cyclic again,
fixing #10386.

Going the other way might also be useful, but that requires some additions to
the Navigator code first.

ShowImage: Adds an option to launch tracker file info for currently viewed file.

Fixes #12241

Signed-off-by: Adrien Destugues <pulkomandy@pulkomandy.tk>

apps: Convert to using Set*UIColor.

Signed-off-by: Augustin Cavalier <waddlesplash@gmail.com>
Patches 0045-0075, 0077-0087 from looncraz, unmodified.

BToolBar: Add a "text" parameter.

For defining the text that appears alongside the icon.

This function really has too many parameters; we probably should break
it out into a BAction class...

ShowImage: reformat lines over 80 chars.

* Last commit of the day, I need a vacation!

ShowImage: improve attributes performance.

* Writes the attributes only if they are different or missing.
* Thanks Humdinger for point out.

ShowImage: fixes variables declaration.

* Thanks Axel.

ShowImage: Fixes wrong indentation.

ShowImage: Set width and height attributes of the showed image.

* Fixes #8745.

ShowImage: Remember save location

* Fixes #6766.

ShowImage: Multipage images displayed in sequence.

* The correct page is displayed.
* Next/Previous/First/Last page are enabled and disable
as Next/Previous File.
* Add in the status bar current page/ total page.
* Fixes #11959.

Showimage: Add zoom level to StatusBar.

* Improve StatusBar graphics (Same style as StyledEdit).
* Resize the StatusBar to best fit.
* Fixes #7394.

Showimage: Wait for loader threads on exit.

* Uses find_thread to wait for loader threads.
(better solutions are welcome)
* As suggested by Axel the cache isn't static anymore.
* Fixes 8902.

ShowImage: Added toolbar buttons for browsing multipage documents

Fix 11898. [ShowImage] Move toolbar buttons near the screen border in fullscreen mode

Signed-off-by: John Scipione <jscipione@gmail.com>

ShowImage: Correct frame size in fullscreen.

Signed-off-by: Augustin Cavalier <waddlesplash@gmail.com>
Fixes #7590. Thanks!

BToolbar: rename to BToolBar.

"BToolBar" matches the current convention ("BStatusBar", "BMenuBar", etc.)
I've no idea what I was thinking when I renamed this before...

Also adjust all users of BToolBar (Tracker and ShowImage).

More uses of BMessageFormat

ZipOMatic, DiskUsage, MediaConverter, MediaPlayer, ShowImage,
WebPositive, Screen preferences, Tracker, string_for_size.

Thanks to KapiX for reporting those!

ToolBarView: rename to BToolbar and move to libshared.

Also adjust ShowImage for this, it's the only thing that's using ToolBarView
right now.

Signed-off-by: Jessica Hamilton <jessica.l.hamilton@gmail.com>

Make sure there's a space in front of B_UTF8_ELLIPSIS.

As PulkoMandy said in hrev47388: C++11 safe and reads better.

Style fixesStyle fixes.

ShowImage: add feature to force original size.

* This is enabled by shift+click on the Original Size toolbar button.
* The button stays pressed as long as the feature is enabled. Clicking
it again disables it.
* When this is enabled, all images will be shown at original size,
instead of being scaled up or down to fit the window.
* This is not persistent, and only affects the current session/window.

Added menu item "Move to Trash"

Changed shortcut of "Show tool bar" to ALT+B.
Assigned shortcut ALT+T zu "Move to Trash", having the same as
e.g. Tracker and MediaPlayer playlist.
DELETE still works as alternative shortcut (if there's an active
selection, it will get unselected instead, as before).

Remove unused ShowImage Undo code.

Fix7734. Avoid race conditions in ToolBar animation

Signed-off-by: Axel Dörfler <axeld@pinc-software.de>

Use stop alert icon if can't find translator

Compilation fixes for x86_64.

Added quite a few missing components to image:

alert arp bc CortexAddOnHost

CDPlayer CharacterMap DeskCalc
Devices DiskUsage Expander LaunchBox MediaConverter NetworkStatus
PoorMan Pulse Screenshot ShowImage SoundRecorder TV Workspaces

DataTranslations Media Printers ScreenSaver

BSnow Cortex FontDemo OverlayImage Pairs

cddb_daemon midi_server power_daemon print_server print_addon_server

Canon LIPS3 Compatible Canon LIPS4 Compatible Gutenprint
PCL5 Compatible PCL6 Compatible PDF Writer PS Compatible

libgame.so libmedia.so

Signed-off-by: Alex Smith <alex@alex-smith.me.uk>

Fixed wrong parameters order

Close alerts with ESCAPE key.

Added SetFlags(B_CLOSE_ON_ESCAPE) or SetShortcut(index, B_ESCAPE) to BAlerts
depending if the result gets used later in the code, or if it's a one-button
BAlert.

Fix off-by-one error which caused scrolling artifacts.

Based on printf debugging the correct left value is actually -1, not 0, but
instead of hard-coding numbers it makes more sense to use the existing value.
I'm not sure if a -1 left value makes much sense, but overall this seems to
work and does not have the scrolling artifacts.

But overall I think ShowImage needs more layout management. Doing all this
moving and resizing manually is error prone.

Fixes #8648.

Reverting hrev44253. Didn't fix the issue, see #8648.

Coding style changes, no functional change.
Hope all's OK, Filter.h is still mostly untouched as it's quite messy with
many exessive commenting.

Fixed redrawing bug when coming out of fullscreen mode.

After coming back from fullscreen mode, horizontally scrolling a zoomed
image would draw vertical lines from the right border. Seems like an
off-by-one issue. This fixes it in my tests... hope it's properly done.

More catalog-related cleanup.

* rename B_TRANSLATE_CONTEXT to B_TRANSLATION_CONTEXT and
B_TRANSLATE_WITH_CONTEXT to B_TRANSLATE_CONTEXT, squashing a TODO
* adjust all uses of both macros in Haiku's source tree
* use correct header guard for collecting/Catalog.h

The renamed macros require adjustments to all external applications
using catalogs.

When the toolbar is hidden by animation it is moved, and so we need to move it
back when showing it again but not using animation.

Fixes #7734.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42306 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Followed Ingo's suggestion, and added a BWindow::Layout() method.
* Changed ShowImage to use that function.
+alpha in case Ingo gives his okay :-)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41782 a95241bf-73f2-0310-859d-f6bbb57e9c96

* We obviously need to relayout manually, as it looks like the view is not
layouted correctly after the resize. This fixes bug #7577. Ingo, is this
the desired behaviour of the layout engine, and if so, what's the rationale
behind it?
* Removed extraneous FitToBounds() call in ShowImageView::SetHideIdlingCursor();
it doesn't belong there.
+alpha


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41772 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Removed leftover debug output.
+alpha


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41610 a95241bf-73f2-0310-859d-f6bbb57e9c96

* The window uses layout management in principle. This was necessary
to get the main menu bar to report the correct minimum size. My
previous commit with regards to setting the correct minimum window
size introduced a regression that the window could not shrink below
it's initial size because of some backwards compatibility behavior
of BMenuBar (IIRC).
* Inserted a content view to hold the tool bar and the show image
views. This one does not use layout management, so that everything
pretty much works as before.
* Showing/Hiding the tool bar is now animated.
* When the tool bar is enabled in principle, it will automatically
show in full screen mode when the user moves the mouse. When the
mouse is not above the tool bar, it is hidden after a delay.
* Added a right-aligned "Leave full screen" icon to the tool bar.
* Improved the workings of the slide show icon. As before, it automatically
triggers full screen mode. It is now pressed when the slide show is
running. Clicking it again just stops the slide show without affecting
the full screen mode (i.e. also not when the user left full screen mode
meanwhile).

There are some problems with images not being automatically sized to
the full screen size as would be expected. This needs to be fixed, yet.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41202 a95241bf-73f2-0310-859d-f6bbb57e9c96

Compute window size limits at least with the minimum menu bar
and tool bar width taken into account.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41199 a95241bf-73f2-0310-859d-f6bbb57e9c96

Removing most About windows and menu items as discussed here
http://www.freelists.org/post/haiku-commits/r40968-in-haikutrunksrcapps-activitymonitor-bootmanager-charactermap-codycam-deskbar,3
Leaving them for now in replicants, and in Terminal, according to (my interpretation of) the instructions here
http://dev.haiku-os.org/browser/haiku/trunk/src/apps/terminal/README.GPL_to_OBOS#L70
Some sporadic cleanup.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41108 a95241bf-73f2-0310-859d-f6bbb57e9c96

Use resource definition files instead of DoCatalogs rule. Rename B_TRANSLATE_APP_NAME and related macros to the more generic B_TRANSLATE_SYSTEM_NAME, to also fits add-ons, folders, etc, and make 'System name' its standard context. Change CodyCam and PoorMan's app signatures to match the overall x-vnd.Haiku-App pattern. Some clean-up. Make SlideShowSaver build again.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41103 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Double click now toggles full screen, as in the MediaPlayer.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41069 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Changed the previous/next icons to the ones intended by zuMi.
* Removed the full-screen icon, since the zoom icon of the window
already does the job.
* Added an icon for the slide show, but it additionally goes into
full-screen mode.
* Added appropriate work arounds for bugs in the Interface Kit
concerning the hiding of tool-tips, and a bug in the app_server
concerning the invalidation of unhidden views...


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41065 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Display a tool bar by default (setting can be toggled in the
View menu)
* The previous/next, selection mode, zoom actions and full screen
mode are accessible via tool bar.
* The tool bar can currently not be shown in full screen mode.
Eventually, I want it to work like in MediaPlayer when it is
generally enabled.
* Fixed capitalization "Selection Mode" into "Selection mode"
(needs catalogs update for all languages).
* When leaving selection mode, clear the selection. Especially
with the new tool bar icon, it looked really weird and irritating
when the selection persisted.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41055 a95241bf-73f2-0310-859d-f6bbb57e9c96

Further localization. Making use of B_TRANSLATE_APP_NAME, AboutWindow. Cleanups. Please review/test changes in Terminal.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40973 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed a bug noticed by Axel (thanks!): Don't store the fullscreen window
frame when quitting ShowImage in fullscreen mode, but the old window frame
instead which would be restored when leaving fullscreen more.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40561 a95241bf-73f2-0310-859d-f6bbb57e9c96

Two unrelated features mangled into one commit:
* Added a Rating menu to the ShowImage window, to easily
give the current image a rating (uses same attribute as other
types of media, i.e. MediaPlayer).
* ShowImage no longer tries to adapt the window size of newly
opened windows to the image that is loaded into them. I've found
that the most annoying ShowImage misbehavior. I don't know why
this was thought to be a good idea, maybe it was useful in
BeOS presentations when you select 20 images in a folder and
make them pop up all at once. I however use ShowImage mainly
to view at fotos, all of which are larger than my screen, so
ShowImage would basically _aÃlways_cover up everything, even
though there is the fullscreen mode for that. Now, ShowImage
remembers the last used window position, new windows will open
at an offset. In another words, you can now have a Tracker
folder of images open, view one, close the window, view another,
ShowImage will open at the previous location, all very convenient
and expected.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40556 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Removed the slide show code from ShowImageView, and reimplemented them in
ShowImageWindow using a BMessageRunner.
* Note, this is completely untested, as it turns out my Haiku installation on
this box is too old to run it. It compiles, at least, and shouldn't break
anything else.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40178 a95241bf-73f2-0310-859d-f6bbb57e9c96

CID 5273: Don't hide the message parameter with a local variable. Not critical
but good coding practice.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40009 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Always make sure the reference to the bitmap is actually released. This
should fix bug #6824.
* Don't queue more pictures if we can only use a single CPU, and the queue is
already busy.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39486 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Removed the "shrink to window" option. Instead, there is now a "Fit to window"
menu item that just does that. Additionally, the image is always fit to the
window size when first shown, or if the full screen mode switches.
That also fixes #6765, and #6810.
* The ImageCache now also passes a referenced BitmapOwner object, and bitmaps
are now actually freed when it's allowed to.
* Pressing the zoom button will cause ShowImage to enter full screen again. For
some reason this has been removed as part of r19540.
* The progress window is now visible again, although not that often, as you will
only see it for images that were not in the queue already. The window is now
known to the ShowImageWindow instead of the ShowImageView.
* Moved most constants out of ShowImageConstants.h to where they belong.
* Dropping an image now opens it in another window.
* Removed EntryMenuItem as it's no longer used anywhere.
* Minor other cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39431 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Implemented preloading of the images around he current one; always two in the
direction of the current navigation, and one in the opposite direction.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39377 a95241bf-73f2-0310-859d-f6bbb57e9c96

* The ImageFileNavigator is now only for navigation, it doesn't load any images
anymore.
* Moved the new ImageCache into its own source file.
* The cache is now used within ShowImage. There is no read-ahead caching being
done yet, though, but you can quickly return to previous images, and you can
also skip images faster than before.
* Improved separation between the ShowImageStatusView and the rest;
ShowImageWindow no longer has a getter for the image view.
* The status view is now using the private BDirMenu which implements enhancement
ticket #6778.
* Made a few more methods private/protected in ShowImageWindow.
* Fixed bug #6797.
* The bitmap is currently only owned by the ImageCache, but we need to have a
separate referenceable object owning it. Added a TODO comment for this.
* The ProgressWindow is currently not being used anymore, added a TODO comment
for this as well.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39364 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Work in progress on implementing asynchronous image retrieval with a
read-ahead cache. Not yet done or used.
* Added deleting images via delete key again. The only difference to before is
that it will open the previous image if the last image in a folder was
removed, and only close ShowImage if there is no image left.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39322 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Moved the Tracker navigation logic into its own class, TrackerNavigation.
* Added a new class FolderNavigation that implements the same for folders
without a Tracker window.
* ImageFileNavigator is now using either one depending on whether it got a
valid tracker messenger.
* Removed some unused/unneeded methods.
* Made entry_ref a reference at some more methods, as it's not really optional.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39292 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Renamed _LoadSettings() to _ApplySettings().


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39287 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Removed the home-brewn recent menu, and just uses the one libtracker.so
provides instead.
* This also fixes bug #6774.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39285 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Quit() in the constructor does not work as one might expect.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39284 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Reverted Rene's fix for the broken build - it's no longer necessary. Thank
you for cleaning up behind me!
* Fixed bug #6771 by adding the shift key to the page shortcuts.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39282 a95241bf-73f2-0310-859d-f6bbb57e9c96

Build fixes mostly due to usage of a translation macro that isn't (currently) available in the source tree.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39267 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Removed resizing ability.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39262 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Completed stippi's work on the ImageFileNavigator.
* ShowImageWindow is now using such a navigator.
* Removed navigation support from ShowImageView.
* Prepared everything to support asynchronous image loading (which is not yet
implemented, though).
* Note, this commit brings some regressions I intend to fix in the next few
days, namely deleting files won't work anymore, and dropping images onto
ShowImage. There might be more I don't know about, though :-)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39259 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Added a selection mode that can currently only be enabled via the menu
(should be part of an optional tool bar in the future). Now the primary, and
the tertiary mouse button pan the image. You still get the selection when
using alt or ctrl and the primary mouse button, even outside of the selection
mode. In selection mode, the primary button changes the selection.
* Renamed {Shrink|Stretch}ToBounds() to comply to our coding style, thanks Ingo.
* Minor cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39132 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Fixed another pet peeve of mine: you can now always zoom, no matter if you
have enabled the shrink/stretch option.
* Renamed "zoom to window" to "stretch to window".
* Readded the shrink/stretch options to the full screen context menu only.
* Renamed GetShrinkToBounds() to ShrinkToBounds() as it's a simple getter.
* Changed how and when the shrink/stretch options come into play. Shrinking is
now only set once, when the image is first shown.
* Added snapping in ZoomIn(), and ZoomOut(): they will now always choose 1.0,
and the "fit to window" zoom level when they are close.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39129 a95241bf-73f2-0310-859d-f6bbb57e9c96

* The shrink/zoom to window options aren't available anymore from the context
menu. I plan to allow zooming always, so they won't be needed that often
anymore.
* Removed all selection copy/move/cut code. This just doesn't belong into an
image viewer.
* Selections are now changed using the tertiary mouse button, or when you press
the command or control modifiers. Instead, the image will now be moved around
with the left button.
* If you drop an image file to ShowImage, it will now open it instead of pasting
it as selection.
* Reworked the scrolling/selection code to never poll, and never use GetMouse().
Instead properly use the asynchronous API (ie. B_NO_POINTER_HISTORY).
* I plan to remove the scaling code as well: the results aren't as good as they
could be (bilinear scaling isn't the solution for everything), and the
interface is pretty awkward, anyway. IMO, this kind of functionality should
be left to apps that are actually thought for image editing. Another solution
would be a Tracker add-on that resizes (multiple) images.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39105 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Removed the delayed scaler code - it's no longer needed (and was trying rather
stupid things like creating a 50000x40000 pixel bitmap if you zoomed in).
* Removed dithering in CMAP8 mode. Please use 32 bit mode instead :-)
* Cleaned up ShowImageWindow.h.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39098 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Removed the ability to invert an image. If you really need that feature,
you'll now have to open an image editing application instead.
* Removed the black border around the image.
* Removed the B_PANEL_BACKGROUND_COLOR background in non-full screen mode - it's
now always black.
* Made zoom level changes exponential.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39095 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Implemented zooming to the current mouse position. Thanks to stippi for the
invalidate trick to prevent the app_server to scroll.
* Minor cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39079 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fix #5810 by disabling the Go to page sub-menu under Browse when there is only
one page.

Also a small refactor of a variable name in that area.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36798 a95241bf-73f2-0310-859d-f6bbb57e9c96

Updated TR_CONTEXT to be B_TRANSLATE_CONTEXT, relating to #5408.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36733 a95241bf-73f2-0310-859d-f6bbb57e9c96

Updated to use B_TRANSLATE* macros. relates to #5408.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36673 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by mt. Localization and conversion to use the layout API with coding style
fixes along the way. Thanks a lot! Fixes #5563.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35929 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by Humdinger:
Updated Haiku apps to use sentence-case. What a huge undertaking...
The files where I had to apply the patch manually (for mysterious
reasons) have also gotten a whitespace cleanup. I've proof-read
everything so hopefully there should be no problems.

This should be the final part of #5169.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35049 a95241bf-73f2-0310-859d-f6bbb57e9c96

ShowImage :
* Changing pictures using the arrow keys while being in a picture folder in tracker would quit the
fullscreen mode (if you happen to be in that mode) because it tries to resize the window to fit
the new picture.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34194 a95241bf-73f2-0310-859d-f6bbb57e9c96

ShowImage: Using the up and down arrow to change images from a tracker folder,
and loading an image bigger than the current window size didn't get the window enlarged.

exceptions: the window doesn't get resized by this mean if you check the Shrink to window or Zoom to window settings.

Fixes ticket #4273.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32502 a95241bf-73f2-0310-859d-f6bbb57e9c96

- Added back code for scrolling with the cursor keys, this time only when Shift
is pressed.

- Took Humdinger's excellent advice from #4190 to open the Backgrounds
preferences from ShowImage instead of setting the background manually. This
required some tweaks to the Backgrounds preferences to accept RefsReceived in
the application and forward that to the view. In addition the placement is
set to scaled since otherwise it will keep the old placement. How this is
done is sort of hacky, but I'm going to call it an "internal protocol." This
also allowed me to remove the BackgroundImage code from ShowImage which was
just copied from Tracker (yuck.)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32424 a95241bf-73f2-0310-859d-f6bbb57e9c96

Implemented pretty much all of #4190. The Enter key was actually already set as
a shortcut for fullscreen, but I guess the view was processing it first. So I
just removed B_ENTER as an option for next image. Also Shift plus primary mouse
was already working for moving the image.

Also I know it was discussed at length but I still wonder if all these options
for next and previous image are overkill. Now there is no way to scroll with
the keyboard. And there isn't an easy way to go to the next image with the
mouse (menus are a pain.) So I still think some more UI tweaking is needed to
avoid constant shifting between mouse and keyboard.

Finally I also added Command-1 as a shortcut for Original Size, but it does not
work. Anyone know why?


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32343 a95241bf-73f2-0310-859d-f6bbb57e9c96

Started cleaning up these monsters:

- Add underscore to private methods.
- Use class member initializer syntax.
- Make sure all class members are initialized, use same order as headers.
- Header reordering.
- A few other small things.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32342 a95241bf-73f2-0310-859d-f6bbb57e9c96

* fix mem leak



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27856 a95241bf-73f2-0310-859d-f6bbb57e9c96

* some more cleanup
* pass the target directly to AddItemMenu
* use default paramter to enable the menu item
* fixed messenger leaks for file panel and resizer window messenger
* show the job config panel when the 'Print' menu item is invoked + shortcut



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27204 a95241bf-73f2-0310-859d-f6bbb57e9c96

* cleanup, no functional change



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27201 a95241bf-73f2-0310-859d-f6bbb57e9c96

small cleanup at the code I looked at

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@22979 a95241bf-73f2-0310-859d-f6bbb57e9c96

We now disable the "Resize..." menu item when a slideshow is started. Not a
huge deal but it doesn't make much sense to resize images during a slideshow.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20020 a95241bf-73f2-0310-859d-f6bbb57e9c96

The size of the selection rectangle is now shown in the status bar. Useful for
cropping an image to a certain size or taking similar sized croppings from
various images (as I need to do.)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20012 a95241bf-73f2-0310-859d-f6bbb57e9c96

General changes:
- Fixed some formatting in the recently added resizing code.
- Changed the operation name for rotating counterclockwise to use that name
instead of anticlockwise. This makes the code consistent with the GUI.
- Reformatted the constants header to use an enum. Also removed the empty
constants cpp file.
- The QuitRequested handler in the app did not ask the windows to close, which
could cause modified images to be closed without prompting the user. Now it
does, which makes ShowImage more user friendly.

Changes to the image view:
- Added a member for keeping track of the type of image. This is mostly used in
properly updating the window's status bar when the image is changed (flipped,
rotated, etc.) This removes some hacky code I added before :)
- Removed the status parameter in the Notify method since it was only used for
the above image type status updating.
- Removed a redundant if in the mouse up handler.
- The key down handlers for moving to the next and previous image did not
properly prompt the user if the image had changed. I fixed this by sending a
message to the window where the prompting code resides. When adding this I
also created a few helper methods for sending messages to the window, which
removed some (small) repeated code through-out the class.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19994 a95241bf-73f2-0310-859d-f6bbb57e9c96

Removed "Stippled Zooming" item and made dithering automatic in 8-bit screen mode
"Keep Proportions" in resizing window became "Keep Original Proportions", which was suggested by korli and is the best suggestion IMO
Bilinear scaling is on by default
I like ShowImage's menus now. :^)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19877 a95241bf-73f2-0310-859d-f6bbb57e9c96

Usability fixes:
Moved Dither Image to the View menu (where it really belongs)
Made some menu item labels less technical
A couple of capitalization fixes
Fixed layout problems in the Resize window


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19852 a95241bf-73f2-0310-859d-f6bbb57e9c96

Variable width2 used at wrong place.
Image size too small by one when passed to ResizerWindow.
Use fractional arithmetic for aspect ratio calculations to avoid rounding errors.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19542 a95241bf-73f2-0310-859d-f6bbb57e9c96

Integrated "resize" feature from Zetas version of ShowImage, however used our bilinear scaler instead of Zetas implementation and made ResizerWindow font sensitive and removed the radio buttons with predefined sizes. Kudos to Bernd Korz for providing the ShowImage Zeta source code under MIT license.
Moved menu item "As Desktop Background" into "Image" menu from "View" menu.
Removed unused metod ShowImageWindow::Zoom(...).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19540 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added some needed stdio.h includes. I don't know what magic was used to compile
these for other people, but they wouldn't compile for me when building the
app_server test environment.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19479 a95241bf-73f2-0310-859d-f6bbb57e9c96

Several ShowImage changes:

- Changed the hotkey for the zoom to be = instead of + so that no shifting is necessary.
- Fixed the bitmap alignment code to solve some problems when zooming.
- Removed all references to alignment in the view since the image was already always centered. This greatly simplified the bitmap alignment.
- Removed the redundant fScaleX and fScaleY members of the view since they were always the same as fZoom.
- Removed all code related to having a border in the view.
- Fixed a bug where the type of file would disappear in the status area when zooming (this fix is a little hackish.)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19253 a95241bf-73f2-0310-859d-f6bbb57e9c96

Now makes sure the window is frontmost when entering full screen mode.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17819 a95241bf-73f2-0310-859d-f6bbb57e9c96

1. Added myself to About box.
2. Fixed bug 537.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17234 a95241bf-73f2-0310-859d-f6bbb57e9c96

More changes to ShowImage:

1. The newly renamed "Flip Sideways" and "Flip Upside Down" have been renamed again to "Flip Left To Right" and "Flip Top To Bottom". This was after some feedback indicating a preference for the new names.

2. When dragging a selection the standard outlined rectangle is used for the dragging image instead of the alpha-blended bitmap of the selected part of the image if the selection rectangle is larger than 400x400 (taking into account scaling of the image.) This mimics the original ShowImage with the exception of the minimum size. The choice of 400x400 was fairly arbitrary. I may see about turning that value into some kind of hidden option.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17229 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixes to ShowImage:

1. Renamed the Image menu items "Mirror Vertical" and "Mirror Horizontal" to "Flip Sideways" and "Flip Upside Down", respectively. This also involved changing the code to match the new names, for consistency.
2. Fixed a bug where zooming in and out would result in the image moving off center. This was due to the bitmap width and height not being recalculated after applying the zoom factor and therefore throwing off the calculations to find the rect for the center.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17182 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed the resizing bug I accidently introduced with r16260.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16278 a95241bf-73f2-0310-859d-f6bbb57e9c96

Followed Jeromes suggestion and moved the desktop directory lookup to the
BackgroundImage::SetDesktopImage() method - if you need more control, you
can still easily make _SetImage() public.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16274 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Added a "Set as desktop background" option with an easy to use engine based
on the OpenTracker's BackgroundImage implementation.
* It's currently placed in the "View" menu, even though it doesn't fit that
good, I think it should definitely be part of the right click menu.
* Some more cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16273 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed various issues:
* ArgvReceived() did not work with relative paths.
* Simplified quitting (no more CanQuit() and overriding BWindow::Quit()).
* Updated signature.
* Cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16260 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixes that make Haiku build with gcc 4. Mainly out of the following
categories:
* Missing includes (like <stdlib.h> and <string.h>).
* Linking against $(TARGET_LIBSTDC++) instead of libstdc++.r4.so.
* Local variables shadowing parameters.
* Default parameters in function definitions (as opposed to function
declarations).
* All C++ stuff (nothrow, map, set, vector, min, max,...) must be imported
explicitly from the std:: namespace now.
* "new (sometype)[...]" must read "new sometype[...]", even if sometype is
something like "const char *".
* __FUNCTION__ is no longer a string literal (but a string expression), i.e.
'printf(__FUNCTION__ ": ...\n")' is invalid code.
* A type cast results in a non-lvalue. E.g. "(char *)buffer += bytes"
is an invalid expression.
* "friend class SomeClass" only works when SomeClass is known before.
Otherwise the an inner class with that name is considered as friend.
gcc 4 is much pickier about scopes.
* gcc 4 is generally stricter with respect to type conversions in C.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@14878 a95241bf-73f2-0310-859d-f6bbb57e9c96

fixed alignment and image layout, esc exits fullscreen mode, black background for fullscreen, zooming window toggles fullscreen, can still browse even if current image has been deleted, space toggles slideshow, swapped next/previous menu items (more logical)

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@13101 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed printing related bug. Image was offset by the left, top corner of the printable rectangle.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10606 a95241bf-73f2-0310-859d-f6bbb57e9c96

cosmetical improvements to status view, it also shows the image size now


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@9113 a95241bf-73f2-0310-859d-f6bbb57e9c96

Rotate what? Added degree symbol.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6638 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed calculation of the menu bar height and the position of the views below.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6543 a95241bf-73f2-0310-859d-f6bbb57e9c96

Use Tracker Scripting to find next/previous image.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6203 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed file saving code so that it is only in one place, (instead of two) and fixed File-->Save As so that it now writes out the type attribute


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6127 a95241bf-73f2-0310-859d-f6bbb57e9c96

Shrunk initial window rectangle so that the scrolling operation performed in fImageView->FlushToLeftTop() will execute properly for certain small images.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5853 a95241bf-73f2-0310-859d-f6bbb57e9c96

Adjusted menu bar, scrollbars and view frame so that there are no longer double borders


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5747 a95241bf-73f2-0310-859d-f6bbb57e9c96

Disable the Invert menu item for B_CMAP8 bitmaps because they are currently unsupported by the invert algorithm.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5721 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added initial implementation of Undo for OBOS ShowImage! Now, users can Undo/Redo merge/paste operations. Still need to enhance Undo further so that other operations can be undone, also need to account for image rotations and similar operations.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5693 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed default window location so that it now appears in the top left corner, like Be's ShowImage. Also, window is now properly aligned to the top left corner when it is zoomed.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5678 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed bug where the close confirmation would still appear after a changed document was closed


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5640 a95241bf-73f2-0310-859d-f6bbb57e9c96

Changed Full Screen menu item shortcut to Alt-F and added BWindow shortcut for Full Screen using Alt-Enter so that Windows users can use the familar Alt-Enter and Be users will be able to use the familar Alt-F (MoviePlayer, ImageViewer).


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5498 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added checking for modified document and prompt the user if they try to close a document without saving.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5492 a95241bf-73f2-0310-859d-f6bbb57e9c96

- Implemented Floyd Steinberg dithering algorithm.
- Remembers "orientation" state (rotated, mirrored or inverted) in file attribute of image.
- Update recent documents menu every time the menu is opened.
- Bug fix and optimization in Filter.cpp.
- Moved image manipulation code from ShowImageView.cpp to Filter.cpp. So it can take advantage of multiple CPUs.
- Experimental: Write/remove thumbnail to/from file icons.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5480 a95241bf-73f2-0310-859d-f6bbb57e9c96

Show small icons in recent document menu.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5444 a95241bf-73f2-0310-859d-f6bbb57e9c96

- Made some settings persistent: Slide Show Delay, Scale Bilinear, Shrink/Zoom to Window, Show Caption in Full Screen Mode and PrintOptions.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5441 a95241bf-73f2-0310-859d-f6bbb57e9c96

Including Clipboard.h could help.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5419 a95241bf-73f2-0310-859d-f6bbb57e9c96

- Made some settings persistent: Slide Show Delay, Scale Bilinear, Shrink/Zoom to Window, Show Caption in Full Screen Mode and PrintOptions persistent.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5415 a95241bf-73f2-0310-859d-f6bbb57e9c96

Implemented Cut and Paste. Still need to implement Undo and check for a dirty document when the window or app is closed.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5414 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added code to enable / disable the Edit->Paste menu item when the contents of the clipboard change


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5413 a95241bf-73f2-0310-859d-f6bbb57e9c96

- Rewrote bilinear scaling algorithm. The version that uses fixed point calculations is at least two times faster than the version that uses floating point calculations!
- Fixed off by one bugs.
- Replace "Fit to Window" with "Shrink to Window" and "Zoom to Window".


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5409 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added code to merge selection with background image; removed Select None item, replaced it with Clear as Select None was behaving like Be ShowImage's Clear anyway; properly enabled/disabled Edit menu items when selection is made or cleared. Still no undo yet, but I'm planning to do that after Paste is implemented.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5403 a95241bf-73f2-0310-859d-f6bbb57e9c96

Changed text for "Rotate Clockwise" and "Rotate Anticlockwise" to "Rotate +90" and "Rotate -90"


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5387 a95241bf-73f2-0310-859d-f6bbb57e9c96

Changed page browsing keyboard shortcuts to make it possible to browse through files and pages without moving any hands.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5383 a95241bf-73f2-0310-859d-f6bbb57e9c96

- scale bilinear (experimental: scaled image is too small by one pixel)
- bug fixes


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5347 a95241bf-73f2-0310-859d-f6bbb57e9c96

- Scrolling with mouse wheel
- Moving image with third mouse button pressed
- Added pop up menu with contents of View menu of menu bar
- Center image in full screen mode
- Added Select None menu item
- To avoid flickering, disabled caption during moving image with mouse- Added key bindings:
- Cursor keys: moves image
- Enter or space bar: next file
- Backspace: previous file
- Escape: Stops slide show
- SHIFT + first mouse button: simulate third mouse button
- CONTROL + first mouse button: simulates second mouse button


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5322 a95241bf-73f2-0310-859d-f6bbb57e9c96

- added printing support
- added zoom in and out
- next/previous file sorts directory entries by itself; does not rely on file system
- added shortcuts to the first 10 menu items of Go To sub menu


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5299 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added Go To Page submenu so the user can directly go to the page that they want. Also fixed a typo.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5290 a95241bf-73f2-0310-859d-f6bbb57e9c96

- renamed and restructured menu bar
- show dialog box when image can not be opened
- added optional caption in full screen mode
- moved/removed code from ShowImageApp to ShowImageView


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5289 a95241bf-73f2-0310-859d-f6bbb57e9c96

- added recent documents sub menu
- added resize window to image size when file is opened
- added drag and drop selection
- added copy selection to clipboard


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5288 a95241bf-73f2-0310-859d-f6bbb57e9c96

- added full screen mode
- added dia show
- added rotate image clockwise, anti-clockwise, mirror image vertical or -horiztonal and invert image
- added myself to about dialog and copyright holders


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5270 a95241bf-73f2-0310-859d-f6bbb57e9c96

- added option resize image to window size
- added show next/previous file using Command + Cursor Up/Down key
- rewrote selection code
- added marching ants
- renamed member variables to start with capital letter after field prefix


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5255 a95241bf-73f2-0310-859d-f6bbb57e9c96

removed (page x of y) from status text, (page info should come from the identify string of translators that support multiple pages) added a border around the image (like Be's ShowImage has), added disabling of Page menu for single page images


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4218 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added multi-page support (as in OBOS TIFFTranslator). Made many changes to the way the app, window and view objects interface with each other. Still could use some polish.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4216 a95241bf-73f2-0310-859d-f6bbb57e9c96

Change to have a more consistent coding style, eliminated unused / unessecary code, added MIT license notice, prevented image window from closing when a save panel is open, prevented the user from opening multiple save panels for a single image window, etc.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4214 a95241bf-73f2-0310-859d-f6bbb57e9c96

Simplified / cleaned up code, fixed close window behavior, changed status view text to show identify string


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4212 a95241bf-73f2-0310-859d-f6bbb57e9c96

Changed Save AS sub menu to only show the available destination types for bitmap images, implemented Save As feature


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4181 a95241bf-73f2-0310-859d-f6bbb57e9c96

Initial Checkin. Coded by Fernando Francisco de Oliveira.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@388 a95241bf-73f2-0310-859d-f6bbb57e9c96

BToolBar: Add a "text" parameter.

For defining the text that appears alongside the icon.

This function really has too many parameters; we probably should break
it out into a BAction class...

ShowImage: reformat lines over 80 chars.

* Last commit of the day, I need a vacation!

ShowImage: improve attributes performance.

* Writes the attributes only if they are different or missing.
* Thanks Humdinger for point out.

ShowImage: fixes variables declaration.

* Thanks Axel.

ShowImage: Fixes wrong indentation.

ShowImage: Set width and height attributes of the showed image.

* Fixes #8745.

ShowImage: Remember save location

* Fixes #6766.

ShowImage: Multipage images displayed in sequence.

* The correct page is displayed.
* Next/Previous/First/Last page are enabled and disable
as Next/Previous File.
* Add in the status bar current page/ total page.
* Fixes #11959.

Showimage: Add zoom level to StatusBar.

* Improve StatusBar graphics (Same style as StyledEdit).
* Resize the StatusBar to best fit.
* Fixes #7394.

Showimage: Wait for loader threads on exit.

* Uses find_thread to wait for loader threads.
(better solutions are welcome)
* As suggested by Axel the cache isn't static anymore.
* Fixes 8902.

ShowImage: Added toolbar buttons for browsing multipage documents

Fix 11898. [ShowImage] Move toolbar buttons near the screen border in fullscreen mode

Signed-off-by: John Scipione <jscipione@gmail.com>

ShowImage: Correct frame size in fullscreen.

Signed-off-by: Augustin Cavalier <waddlesplash@gmail.com>
Fixes #7590. Thanks!

BToolbar: rename to BToolBar.

"BToolBar" matches the current convention ("BStatusBar", "BMenuBar", etc.)
I've no idea what I was thinking when I renamed this before...

Also adjust all users of BToolBar (Tracker and ShowImage).

More uses of BMessageFormat

ZipOMatic, DiskUsage, MediaConverter, MediaPlayer, ShowImage,
WebPositive, Screen preferences, Tracker, string_for_size.

Thanks to KapiX for reporting those!

ToolBarView: rename to BToolbar and move to libshared.

Also adjust ShowImage for this, it's the only thing that's using ToolBarView
right now.

Signed-off-by: Jessica Hamilton <jessica.l.hamilton@gmail.com>

Make sure there's a space in front of B_UTF8_ELLIPSIS.

As PulkoMandy said in hrev47388: C++11 safe and reads better.

Style fixesStyle fixes.

ShowImage: add feature to force original size.

* This is enabled by shift+click on the Original Size toolbar button.
* The button stays pressed as long as the feature is enabled. Clicking
it again disables it.
* When this is enabled, all images will be shown at original size,
instead of being scaled up or down to fit the window.
* This is not persistent, and only affects the current session/window.

Added menu item "Move to Trash"

Changed shortcut of "Show tool bar" to ALT+B.
Assigned shortcut ALT+T zu "Move to Trash", having the same as
e.g. Tracker and MediaPlayer playlist.
DELETE still works as alternative shortcut (if there's an active
selection, it will get unselected instead, as before).

Remove unused ShowImage Undo code.

Fix7734. Avoid race conditions in ToolBar animation

Signed-off-by: Axel Dörfler <axeld@pinc-software.de>

Use stop alert icon if can't find translator

Compilation fixes for x86_64.

Added quite a few missing components to image:

alert arp bc CortexAddOnHost

CDPlayer CharacterMap DeskCalc
Devices DiskUsage Expander LaunchBox MediaConverter NetworkStatus
PoorMan Pulse Screenshot ShowImage SoundRecorder TV Workspaces

DataTranslations Media Printers ScreenSaver

BSnow Cortex FontDemo OverlayImage Pairs

cddb_daemon midi_server power_daemon print_server print_addon_server

Canon LIPS3 Compatible Canon LIPS4 Compatible Gutenprint
PCL5 Compatible PCL6 Compatible PDF Writer PS Compatible

libgame.so libmedia.so

Signed-off-by: Alex Smith <alex@alex-smith.me.uk>

Fixed wrong parameters order

Close alerts with ESCAPE key.

Added SetFlags(B_CLOSE_ON_ESCAPE) or SetShortcut(index, B_ESCAPE) to BAlerts
depending if the result gets used later in the code, or if it's a one-button
BAlert.

Fix off-by-one error which caused scrolling artifacts.

Based on printf debugging the correct left value is actually -1, not 0, but
instead of hard-coding numbers it makes more sense to use the existing value.
I'm not sure if a -1 left value makes much sense, but overall this seems to
work and does not have the scrolling artifacts.

But overall I think ShowImage needs more layout management. Doing all this
moving and resizing manually is error prone.

Fixes #8648.

Reverting hrev44253. Didn't fix the issue, see #8648.

Coding style changes, no functional change.
Hope all's OK, Filter.h is still mostly untouched as it's quite messy with
many exessive commenting.

Fixed redrawing bug when coming out of fullscreen mode.

After coming back from fullscreen mode, horizontally scrolling a zoomed
image would draw vertical lines from the right border. Seems like an
off-by-one issue. This fixes it in my tests... hope it's properly done.

More catalog-related cleanup.

* rename B_TRANSLATE_CONTEXT to B_TRANSLATION_CONTEXT and
B_TRANSLATE_WITH_CONTEXT to B_TRANSLATE_CONTEXT, squashing a TODO
* adjust all uses of both macros in Haiku's source tree
* use correct header guard for collecting/Catalog.h

The renamed macros require adjustments to all external applications
using catalogs.

When the toolbar is hidden by animation it is moved, and so we need to move it
back when showing it again but not using animation.

Fixes #7734.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42306 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Followed Ingo's suggestion, and added a BWindow::Layout() method.
* Changed ShowImage to use that function.
+alpha in case Ingo gives his okay :-)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41782 a95241bf-73f2-0310-859d-f6bbb57e9c96

* We obviously need to relayout manually, as it looks like the view is not
layouted correctly after the resize. This fixes bug #7577. Ingo, is this
the desired behaviour of the layout engine, and if so, what's the rationale
behind it?
* Removed extraneous FitToBounds() call in ShowImageView::SetHideIdlingCursor();
it doesn't belong there.
+alpha


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41772 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Removed leftover debug output.
+alpha


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41610 a95241bf-73f2-0310-859d-f6bbb57e9c96

* The window uses layout management in principle. This was necessary
to get the main menu bar to report the correct minimum size. My
previous commit with regards to setting the correct minimum window
size introduced a regression that the window could not shrink below
it's initial size because of some backwards compatibility behavior
of BMenuBar (IIRC).
* Inserted a content view to hold the tool bar and the show image
views. This one does not use layout management, so that everything
pretty much works as before.
* Showing/Hiding the tool bar is now animated.
* When the tool bar is enabled in principle, it will automatically
show in full screen mode when the user moves the mouse. When the
mouse is not above the tool bar, it is hidden after a delay.
* Added a right-aligned "Leave full screen" icon to the tool bar.
* Improved the workings of the slide show icon. As before, it automatically
triggers full screen mode. It is now pressed when the slide show is
running. Clicking it again just stops the slide show without affecting
the full screen mode (i.e. also not when the user left full screen mode
meanwhile).

There are some problems with images not being automatically sized to
the full screen size as would be expected. This needs to be fixed, yet.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41202 a95241bf-73f2-0310-859d-f6bbb57e9c96

Compute window size limits at least with the minimum menu bar
and tool bar width taken into account.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41199 a95241bf-73f2-0310-859d-f6bbb57e9c96

Removing most About windows and menu items as discussed here
http://www.freelists.org/post/haiku-commits/r40968-in-haikutrunksrcapps-activitymonitor-bootmanager-charactermap-codycam-deskbar,3
Leaving them for now in replicants, and in Terminal, according to (my interpretation of) the instructions here
http://dev.haiku-os.org/browser/haiku/trunk/src/apps/terminal/README.GPL_to_OBOS#L70
Some sporadic cleanup.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41108 a95241bf-73f2-0310-859d-f6bbb57e9c96

Use resource definition files instead of DoCatalogs rule. Rename B_TRANSLATE_APP_NAME and related macros to the more generic B_TRANSLATE_SYSTEM_NAME, to also fits add-ons, folders, etc, and make 'System name' its standard context. Change CodyCam and PoorMan's app signatures to match the overall x-vnd.Haiku-App pattern. Some clean-up. Make SlideShowSaver build again.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41103 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Double click now toggles full screen, as in the MediaPlayer.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41069 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Changed the previous/next icons to the ones intended by zuMi.
* Removed the full-screen icon, since the zoom icon of the window
already does the job.
* Added an icon for the slide show, but it additionally goes into
full-screen mode.
* Added appropriate work arounds for bugs in the Interface Kit
concerning the hiding of tool-tips, and a bug in the app_server
concerning the invalidation of unhidden views...


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41065 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Display a tool bar by default (setting can be toggled in the
View menu)
* The previous/next, selection mode, zoom actions and full screen
mode are accessible via tool bar.
* The tool bar can currently not be shown in full screen mode.
Eventually, I want it to work like in MediaPlayer when it is
generally enabled.
* Fixed capitalization "Selection Mode" into "Selection mode"
(needs catalogs update for all languages).
* When leaving selection mode, clear the selection. Especially
with the new tool bar icon, it looked really weird and irritating
when the selection persisted.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41055 a95241bf-73f2-0310-859d-f6bbb57e9c96

Further localization. Making use of B_TRANSLATE_APP_NAME, AboutWindow. Cleanups. Please review/test changes in Terminal.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40973 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed a bug noticed by Axel (thanks!): Don't store the fullscreen window
frame when quitting ShowImage in fullscreen mode, but the old window frame
instead which would be restored when leaving fullscreen more.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40561 a95241bf-73f2-0310-859d-f6bbb57e9c96

Two unrelated features mangled into one commit:
* Added a Rating menu to the ShowImage window, to easily
give the current image a rating (uses same attribute as other
types of media, i.e. MediaPlayer).
* ShowImage no longer tries to adapt the window size of newly
opened windows to the image that is loaded into them. I've found
that the most annoying ShowImage misbehavior. I don't know why
this was thought to be a good idea, maybe it was useful in
BeOS presentations when you select 20 images in a folder and
make them pop up all at once. I however use ShowImage mainly
to view at fotos, all of which are larger than my screen, so
ShowImage would basically _aÃlways_cover up everything, even
though there is the fullscreen mode for that. Now, ShowImage
remembers the last used window position, new windows will open
at an offset. In another words, you can now have a Tracker
folder of images open, view one, close the window, view another,
ShowImage will open at the previous location, all very convenient
and expected.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40556 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Removed the slide show code from ShowImageView, and reimplemented them in
ShowImageWindow using a BMessageRunner.
* Note, this is completely untested, as it turns out my Haiku installation on
this box is too old to run it. It compiles, at least, and shouldn't break
anything else.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40178 a95241bf-73f2-0310-859d-f6bbb57e9c96

CID 5273: Don't hide the message parameter with a local variable. Not critical
but good coding practice.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40009 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Always make sure the reference to the bitmap is actually released. This
should fix bug #6824.
* Don't queue more pictures if we can only use a single CPU, and the queue is
already busy.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39486 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Removed the "shrink to window" option. Instead, there is now a "Fit to window"
menu item that just does that. Additionally, the image is always fit to the
window size when first shown, or if the full screen mode switches.
That also fixes #6765, and #6810.
* The ImageCache now also passes a referenced BitmapOwner object, and bitmaps
are now actually freed when it's allowed to.
* Pressing the zoom button will cause ShowImage to enter full screen again. For
some reason this has been removed as part of r19540.
* The progress window is now visible again, although not that often, as you will
only see it for images that were not in the queue already. The window is now
known to the ShowImageWindow instead of the ShowImageView.
* Moved most constants out of ShowImageConstants.h to where they belong.
* Dropping an image now opens it in another window.
* Removed EntryMenuItem as it's no longer used anywhere.
* Minor other cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39431 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Implemented preloading of the images around he current one; always two in the
direction of the current navigation, and one in the opposite direction.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39377 a95241bf-73f2-0310-859d-f6bbb57e9c96

* The ImageFileNavigator is now only for navigation, it doesn't load any images
anymore.
* Moved the new ImageCache into its own source file.
* The cache is now used within ShowImage. There is no read-ahead caching being
done yet, though, but you can quickly return to previous images, and you can
also skip images faster than before.
* Improved separation between the ShowImageStatusView and the rest;
ShowImageWindow no longer has a getter for the image view.
* The status view is now using the private BDirMenu which implements enhancement
ticket #6778.
* Made a few more methods private/protected in ShowImageWindow.
* Fixed bug #6797.
* The bitmap is currently only owned by the ImageCache, but we need to have a
separate referenceable object owning it. Added a TODO comment for this.
* The ProgressWindow is currently not being used anymore, added a TODO comment
for this as well.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39364 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Work in progress on implementing asynchronous image retrieval with a
read-ahead cache. Not yet done or used.
* Added deleting images via delete key again. The only difference to before is
that it will open the previous image if the last image in a folder was
removed, and only close ShowImage if there is no image left.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39322 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Moved the Tracker navigation logic into its own class, TrackerNavigation.
* Added a new class FolderNavigation that implements the same for folders
without a Tracker window.
* ImageFileNavigator is now using either one depending on whether it got a
valid tracker messenger.
* Removed some unused/unneeded methods.
* Made entry_ref a reference at some more methods, as it's not really optional.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39292 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Renamed _LoadSettings() to _ApplySettings().


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39287 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Removed the home-brewn recent menu, and just uses the one libtracker.so
provides instead.
* This also fixes bug #6774.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39285 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Quit() in the constructor does not work as one might expect.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39284 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Reverted Rene's fix for the broken build - it's no longer necessary. Thank
you for cleaning up behind me!
* Fixed bug #6771 by adding the shift key to the page shortcuts.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39282 a95241bf-73f2-0310-859d-f6bbb57e9c96

Build fixes mostly due to usage of a translation macro that isn't (currently) available in the source tree.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39267 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Removed resizing ability.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39262 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Completed stippi's work on the ImageFileNavigator.
* ShowImageWindow is now using such a navigator.
* Removed navigation support from ShowImageView.
* Prepared everything to support asynchronous image loading (which is not yet
implemented, though).
* Note, this commit brings some regressions I intend to fix in the next few
days, namely deleting files won't work anymore, and dropping images onto
ShowImage. There might be more I don't know about, though :-)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39259 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Added a selection mode that can currently only be enabled via the menu
(should be part of an optional tool bar in the future). Now the primary, and
the tertiary mouse button pan the image. You still get the selection when
using alt or ctrl and the primary mouse button, even outside of the selection
mode. In selection mode, the primary button changes the selection.
* Renamed {Shrink|Stretch}ToBounds() to comply to our coding style, thanks Ingo.
* Minor cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39132 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Fixed another pet peeve of mine: you can now always zoom, no matter if you
have enabled the shrink/stretch option.
* Renamed "zoom to window" to "stretch to window".
* Readded the shrink/stretch options to the full screen context menu only.
* Renamed GetShrinkToBounds() to ShrinkToBounds() as it's a simple getter.
* Changed how and when the shrink/stretch options come into play. Shrinking is
now only set once, when the image is first shown.
* Added snapping in ZoomIn(), and ZoomOut(): they will now always choose 1.0,
and the "fit to window" zoom level when they are close.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39129 a95241bf-73f2-0310-859d-f6bbb57e9c96

* The shrink/zoom to window options aren't available anymore from the context
menu. I plan to allow zooming always, so they won't be needed that often
anymore.
* Removed all selection copy/move/cut code. This just doesn't belong into an
image viewer.
* Selections are now changed using the tertiary mouse button, or when you press
the command or control modifiers. Instead, the image will now be moved around
with the left button.
* If you drop an image file to ShowImage, it will now open it instead of pasting
it as selection.
* Reworked the scrolling/selection code to never poll, and never use GetMouse().
Instead properly use the asynchronous API (ie. B_NO_POINTER_HISTORY).
* I plan to remove the scaling code as well: the results aren't as good as they
could be (bilinear scaling isn't the solution for everything), and the
interface is pretty awkward, anyway. IMO, this kind of functionality should
be left to apps that are actually thought for image editing. Another solution
would be a Tracker add-on that resizes (multiple) images.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39105 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Removed the delayed scaler code - it's no longer needed (and was trying rather
stupid things like creating a 50000x40000 pixel bitmap if you zoomed in).
* Removed dithering in CMAP8 mode. Please use 32 bit mode instead :-)
* Cleaned up ShowImageWindow.h.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39098 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Removed the ability to invert an image. If you really need that feature,
you'll now have to open an image editing application instead.
* Removed the black border around the image.
* Removed the B_PANEL_BACKGROUND_COLOR background in non-full screen mode - it's
now always black.
* Made zoom level changes exponential.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39095 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Implemented zooming to the current mouse position. Thanks to stippi for the
invalidate trick to prevent the app_server to scroll.
* Minor cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39079 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fix #5810 by disabling the Go to page sub-menu under Browse when there is only
one page.

Also a small refactor of a variable name in that area.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36798 a95241bf-73f2-0310-859d-f6bbb57e9c96

Updated TR_CONTEXT to be B_TRANSLATE_CONTEXT, relating to #5408.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36733 a95241bf-73f2-0310-859d-f6bbb57e9c96

Updated to use B_TRANSLATE* macros. relates to #5408.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36673 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by mt. Localization and conversion to use the layout API with coding style
fixes along the way. Thanks a lot! Fixes #5563.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35929 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by Humdinger:
Updated Haiku apps to use sentence-case. What a huge undertaking...
The files where I had to apply the patch manually (for mysterious
reasons) have also gotten a whitespace cleanup. I've proof-read
everything so hopefully there should be no problems.

This should be the final part of #5169.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35049 a95241bf-73f2-0310-859d-f6bbb57e9c96

ShowImage :
* Changing pictures using the arrow keys while being in a picture folder in tracker would quit the
fullscreen mode (if you happen to be in that mode) because it tries to resize the window to fit
the new picture.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34194 a95241bf-73f2-0310-859d-f6bbb57e9c96

ShowImage: Using the up and down arrow to change images from a tracker folder,
and loading an image bigger than the current window size didn't get the window enlarged.

exceptions: the window doesn't get resized by this mean if you check the Shrink to window or Zoom to window settings.

Fixes ticket #4273.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32502 a95241bf-73f2-0310-859d-f6bbb57e9c96

- Added back code for scrolling with the cursor keys, this time only when Shift
is pressed.

- Took Humdinger's excellent advice from #4190 to open the Backgrounds
preferences from ShowImage instead of setting the background manually. This
required some tweaks to the Backgrounds preferences to accept RefsReceived in
the application and forward that to the view. In addition the placement is
set to scaled since otherwise it will keep the old placement. How this is
done is sort of hacky, but I'm going to call it an "internal protocol." This
also allowed me to remove the BackgroundImage code from ShowImage which was
just copied from Tracker (yuck.)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32424 a95241bf-73f2-0310-859d-f6bbb57e9c96

Implemented pretty much all of #4190. The Enter key was actually already set as
a shortcut for fullscreen, but I guess the view was processing it first. So I
just removed B_ENTER as an option for next image. Also Shift plus primary mouse
was already working for moving the image.

Also I know it was discussed at length but I still wonder if all these options
for next and previous image are overkill. Now there is no way to scroll with
the keyboard. And there isn't an easy way to go to the next image with the
mouse (menus are a pain.) So I still think some more UI tweaking is needed to
avoid constant shifting between mouse and keyboard.

Finally I also added Command-1 as a shortcut for Original Size, but it does not
work. Anyone know why?


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32343 a95241bf-73f2-0310-859d-f6bbb57e9c96

Started cleaning up these monsters:

- Add underscore to private methods.
- Use class member initializer syntax.
- Make sure all class members are initialized, use same order as headers.
- Header reordering.
- A few other small things.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32342 a95241bf-73f2-0310-859d-f6bbb57e9c96

* fix mem leak



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27856 a95241bf-73f2-0310-859d-f6bbb57e9c96

* some more cleanup
* pass the target directly to AddItemMenu
* use default paramter to enable the menu item
* fixed messenger leaks for file panel and resizer window messenger
* show the job config panel when the 'Print' menu item is invoked + shortcut



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27204 a95241bf-73f2-0310-859d-f6bbb57e9c96

* cleanup, no functional change



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27201 a95241bf-73f2-0310-859d-f6bbb57e9c96

small cleanup at the code I looked at

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@22979 a95241bf-73f2-0310-859d-f6bbb57e9c96

We now disable the "Resize..." menu item when a slideshow is started. Not a
huge deal but it doesn't make much sense to resize images during a slideshow.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20020 a95241bf-73f2-0310-859d-f6bbb57e9c96

The size of the selection rectangle is now shown in the status bar. Useful for
cropping an image to a certain size or taking similar sized croppings from
various images (as I need to do.)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20012 a95241bf-73f2-0310-859d-f6bbb57e9c96

General changes:
- Fixed some formatting in the recently added resizing code.
- Changed the operation name for rotating counterclockwise to use that name
instead of anticlockwise. This makes the code consistent with the GUI.
- Reformatted the constants header to use an enum. Also removed the empty
constants cpp file.
- The QuitRequested handler in the app did not ask the windows to close, which
could cause modified images to be closed without prompting the user. Now it
does, which makes ShowImage more user friendly.

Changes to the image view:
- Added a member for keeping track of the type of image. This is mostly used in
properly updating the window's status bar when the image is changed (flipped,
rotated, etc.) This removes some hacky code I added before :)
- Removed the status parameter in the Notify method since it was only used for
the above image type status updating.
- Removed a redundant if in the mouse up handler.
- The key down handlers for moving to the next and previous image did not
properly prompt the user if the image had changed. I fixed this by sending a
message to the window where the prompting code resides. When adding this I
also created a few helper methods for sending messages to the window, which
removed some (small) repeated code through-out the class.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19994 a95241bf-73f2-0310-859d-f6bbb57e9c96

Removed "Stippled Zooming" item and made dithering automatic in 8-bit screen mode
"Keep Proportions" in resizing window became "Keep Original Proportions", which was suggested by korli and is the best suggestion IMO
Bilinear scaling is on by default
I like ShowImage's menus now. :^)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19877 a95241bf-73f2-0310-859d-f6bbb57e9c96

Usability fixes:
Moved Dither Image to the View menu (where it really belongs)
Made some menu item labels less technical
A couple of capitalization fixes
Fixed layout problems in the Resize window


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19852 a95241bf-73f2-0310-859d-f6bbb57e9c96

Variable width2 used at wrong place.
Image size too small by one when passed to ResizerWindow.
Use fractional arithmetic for aspect ratio calculations to avoid rounding errors.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19542 a95241bf-73f2-0310-859d-f6bbb57e9c96

Integrated "resize" feature from Zetas version of ShowImage, however used our bilinear scaler instead of Zetas implementation and made ResizerWindow font sensitive and removed the radio buttons with predefined sizes. Kudos to Bernd Korz for providing the ShowImage Zeta source code under MIT license.
Moved menu item "As Desktop Background" into "Image" menu from "View" menu.
Removed unused metod ShowImageWindow::Zoom(...).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19540 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added some needed stdio.h includes. I don't know what magic was used to compile
these for other people, but they wouldn't compile for me when building the
app_server test environment.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19479 a95241bf-73f2-0310-859d-f6bbb57e9c96

Several ShowImage changes:

- Changed the hotkey for the zoom to be = instead of + so that no shifting is necessary.
- Fixed the bitmap alignment code to solve some problems when zooming.
- Removed all references to alignment in the view since the image was already always centered. This greatly simplified the bitmap alignment.
- Removed the redundant fScaleX and fScaleY members of the view since they were always the same as fZoom.
- Removed all code related to having a border in the view.
- Fixed a bug where the type of file would disappear in the status area when zooming (this fix is a little hackish.)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19253 a95241bf-73f2-0310-859d-f6bbb57e9c96

Now makes sure the window is frontmost when entering full screen mode.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17819 a95241bf-73f2-0310-859d-f6bbb57e9c96

1. Added myself to About box.
2. Fixed bug 537.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17234 a95241bf-73f2-0310-859d-f6bbb57e9c96

More changes to ShowImage:

1. The newly renamed "Flip Sideways" and "Flip Upside Down" have been renamed again to "Flip Left To Right" and "Flip Top To Bottom". This was after some feedback indicating a preference for the new names.

2. When dragging a selection the standard outlined rectangle is used for the dragging image instead of the alpha-blended bitmap of the selected part of the image if the selection rectangle is larger than 400x400 (taking into account scaling of the image.) This mimics the original ShowImage with the exception of the minimum size. The choice of 400x400 was fairly arbitrary. I may see about turning that value into some kind of hidden option.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17229 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixes to ShowImage:

1. Renamed the Image menu items "Mirror Vertical" and "Mirror Horizontal" to "Flip Sideways" and "Flip Upside Down", respectively. This also involved changing the code to match the new names, for consistency.
2. Fixed a bug where zooming in and out would result in the image moving off center. This was due to the bitmap width and height not being recalculated after applying the zoom factor and therefore throwing off the calculations to find the rect for the center.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17182 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed the resizing bug I accidently introduced with r16260.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16278 a95241bf-73f2-0310-859d-f6bbb57e9c96

Followed Jeromes suggestion and moved the desktop directory lookup to the
BackgroundImage::SetDesktopImage() method - if you need more control, you
can still easily make _SetImage() public.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16274 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Added a "Set as desktop background" option with an easy to use engine based
on the OpenTracker's BackgroundImage implementation.
* It's currently placed in the "View" menu, even though it doesn't fit that
good, I think it should definitely be part of the right click menu.
* Some more cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16273 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed various issues:
* ArgvReceived() did not work with relative paths.
* Simplified quitting (no more CanQuit() and overriding BWindow::Quit()).
* Updated signature.
* Cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16260 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixes that make Haiku build with gcc 4. Mainly out of the following
categories:
* Missing includes (like <stdlib.h> and <string.h>).
* Linking against $(TARGET_LIBSTDC++) instead of libstdc++.r4.so.
* Local variables shadowing parameters.
* Default parameters in function definitions (as opposed to function
declarations).
* All C++ stuff (nothrow, map, set, vector, min, max,...) must be imported
explicitly from the std:: namespace now.
* "new (sometype)[...]" must read "new sometype[...]", even if sometype is
something like "const char *".
* __FUNCTION__ is no longer a string literal (but a string expression), i.e.
'printf(__FUNCTION__ ": ...\n")' is invalid code.
* A type cast results in a non-lvalue. E.g. "(char *)buffer += bytes"
is an invalid expression.
* "friend class SomeClass" only works when SomeClass is known before.
Otherwise the an inner class with that name is considered as friend.
gcc 4 is much pickier about scopes.
* gcc 4 is generally stricter with respect to type conversions in C.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@14878 a95241bf-73f2-0310-859d-f6bbb57e9c96

fixed alignment and image layout, esc exits fullscreen mode, black background for fullscreen, zooming window toggles fullscreen, can still browse even if current image has been deleted, space toggles slideshow, swapped next/previous menu items (more logical)

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@13101 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed printing related bug. Image was offset by the left, top corner of the printable rectangle.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10606 a95241bf-73f2-0310-859d-f6bbb57e9c96

cosmetical improvements to status view, it also shows the image size now


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@9113 a95241bf-73f2-0310-859d-f6bbb57e9c96

Rotate what? Added degree symbol.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6638 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed calculation of the menu bar height and the position of the views below.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6543 a95241bf-73f2-0310-859d-f6bbb57e9c96

Use Tracker Scripting to find next/previous image.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6203 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed file saving code so that it is only in one place, (instead of two) and fixed File-->Save As so that it now writes out the type attribute


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6127 a95241bf-73f2-0310-859d-f6bbb57e9c96

Shrunk initial window rectangle so that the scrolling operation performed in fImageView->FlushToLeftTop() will execute properly for certain small images.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5853 a95241bf-73f2-0310-859d-f6bbb57e9c96

Adjusted menu bar, scrollbars and view frame so that there are no longer double borders


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5747 a95241bf-73f2-0310-859d-f6bbb57e9c96

Disable the Invert menu item for B_CMAP8 bitmaps because they are currently unsupported by the invert algorithm.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5721 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added initial implementation of Undo for OBOS ShowImage! Now, users can Undo/Redo merge/paste operations. Still need to enhance Undo further so that other operations can be undone, also need to account for image rotations and similar operations.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5693 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed default window location so that it now appears in the top left corner, like Be's ShowImage. Also, window is now properly aligned to the top left corner when it is zoomed.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5678 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed bug where the close confirmation would still appear after a changed document was closed


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5640 a95241bf-73f2-0310-859d-f6bbb57e9c96

Changed Full Screen menu item shortcut to Alt-F and added BWindow shortcut for Full Screen using Alt-Enter so that Windows users can use the familar Alt-Enter and Be users will be able to use the familar Alt-F (MoviePlayer, ImageViewer).


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5498 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added checking for modified document and prompt the user if they try to close a document without saving.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5492 a95241bf-73f2-0310-859d-f6bbb57e9c96

- Implemented Floyd Steinberg dithering algorithm.
- Remembers "orientation" state (rotated, mirrored or inverted) in file attribute of image.
- Update recent documents menu every time the menu is opened.
- Bug fix and optimization in Filter.cpp.
- Moved image manipulation code from ShowImageView.cpp to Filter.cpp. So it can take advantage of multiple CPUs.
- Experimental: Write/remove thumbnail to/from file icons.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5480 a95241bf-73f2-0310-859d-f6bbb57e9c96

Show small icons in recent document menu.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5444 a95241bf-73f2-0310-859d-f6bbb57e9c96

- Made some settings persistent: Slide Show Delay, Scale Bilinear, Shrink/Zoom to Window, Show Caption in Full Screen Mode and PrintOptions.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5441 a95241bf-73f2-0310-859d-f6bbb57e9c96

Including Clipboard.h could help.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5419 a95241bf-73f2-0310-859d-f6bbb57e9c96

- Made some settings persistent: Slide Show Delay, Scale Bilinear, Shrink/Zoom to Window, Show Caption in Full Screen Mode and PrintOptions persistent.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5415 a95241bf-73f2-0310-859d-f6bbb57e9c96

Implemented Cut and Paste. Still need to implement Undo and check for a dirty document when the window or app is closed.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5414 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added code to enable / disable the Edit->Paste menu item when the contents of the clipboard change


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5413 a95241bf-73f2-0310-859d-f6bbb57e9c96

- Rewrote bilinear scaling algorithm. The version that uses fixed point calculations is at least two times faster than the version that uses floating point calculations!
- Fixed off by one bugs.
- Replace "Fit to Window" with "Shrink to Window" and "Zoom to Window".


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5409 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added code to merge selection with background image; removed Select None item, replaced it with Clear as Select None was behaving like Be ShowImage's Clear anyway; properly enabled/disabled Edit menu items when selection is made or cleared. Still no undo yet, but I'm planning to do that after Paste is implemented.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5403 a95241bf-73f2-0310-859d-f6bbb57e9c96

Changed text for "Rotate Clockwise" and "Rotate Anticlockwise" to "Rotate +90" and "Rotate -90"


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5387 a95241bf-73f2-0310-859d-f6bbb57e9c96

Changed page browsing keyboard shortcuts to make it possible to browse through files and pages without moving any hands.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5383 a95241bf-73f2-0310-859d-f6bbb57e9c96

- scale bilinear (experimental: scaled image is too small by one pixel)
- bug fixes


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5347 a95241bf-73f2-0310-859d-f6bbb57e9c96

- Scrolling with mouse wheel
- Moving image with third mouse button pressed
- Added pop up menu with contents of View menu of menu bar
- Center image in full screen mode
- Added Select None menu item
- To avoid flickering, disabled caption during moving image with mouse- Added key bindings:
- Cursor keys: moves image
- Enter or space bar: next file
- Backspace: previous file
- Escape: Stops slide show
- SHIFT + first mouse button: simulate third mouse button
- CONTROL + first mouse button: simulates second mouse button


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5322 a95241bf-73f2-0310-859d-f6bbb57e9c96

- added printing support
- added zoom in and out
- next/previous file sorts directory entries by itself; does not rely on file system
- added shortcuts to the first 10 menu items of Go To sub menu


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5299 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added Go To Page submenu so the user can directly go to the page that they want. Also fixed a typo.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5290 a95241bf-73f2-0310-859d-f6bbb57e9c96

- renamed and restructured menu bar
- show dialog box when image can not be opened
- added optional caption in full screen mode
- moved/removed code from ShowImageApp to ShowImageView


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5289 a95241bf-73f2-0310-859d-f6bbb57e9c96

- added recent documents sub menu
- added resize window to image size when file is opened
- added drag and drop selection
- added copy selection to clipboard


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5288 a95241bf-73f2-0310-859d-f6bbb57e9c96

- added full screen mode
- added dia show
- added rotate image clockwise, anti-clockwise, mirror image vertical or -horiztonal and invert image
- added myself to about dialog and copyright holders


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5270 a95241bf-73f2-0310-859d-f6bbb57e9c96

- added option resize image to window size
- added show next/previous file using Command + Cursor Up/Down key
- rewrote selection code
- added marching ants
- renamed member variables to start with capital letter after field prefix


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5255 a95241bf-73f2-0310-859d-f6bbb57e9c96

removed (page x of y) from status text, (page info should come from the identify string of translators that support multiple pages) added a border around the image (like Be's ShowImage has), added disabling of Page menu for single page images


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4218 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added multi-page support (as in OBOS TIFFTranslator). Made many changes to the way the app, window and view objects interface with each other. Still could use some polish.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4216 a95241bf-73f2-0310-859d-f6bbb57e9c96

Change to have a more consistent coding style, eliminated unused / unessecary code, added MIT license notice, prevented image window from closing when a save panel is open, prevented the user from opening multiple save panels for a single image window, etc.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4214 a95241bf-73f2-0310-859d-f6bbb57e9c96

Simplified / cleaned up code, fixed close window behavior, changed status view text to show identify string


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4212 a95241bf-73f2-0310-859d-f6bbb57e9c96

Changed Save AS sub menu to only show the available destination types for bitmap images, implemented Save As feature


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4181 a95241bf-73f2-0310-859d-f6bbb57e9c96

Initial Checkin. Coded by Fernando Francisco de Oliveira.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@388 a95241bf-73f2-0310-859d-f6bbb57e9c96