ShowImage: Use layouts for the main view area.

The main window itself is still not using them,
due to incompatibilities with the toolbar animation.

Fixes #18547.

ShowImage: avoid trigger screen saver in full screen

ShowImage hides the mouse pointer when in full screen. This change
additionally avoids triggering the screen saver in that case, using
the same method as MediaPlayer, i.e. setting the current mouse
coordinates.

Change-Id: I151be209f02a2b8d3033766f2b7469655a5c8b61
Reviewed-on: https://review.haiku-os.org/c/haiku/+/6639
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>

ShowImage: Use BControlLook::ComposeIconSize.

Also use BBitmap::ImportBits instead of a manual copy, while at it.

Showimage: Add zoom level to StatusBar.

* Improve StatusBar graphics (Same style as StyledEdit).
* Resize the StatusBar to best fit.
* Fixes #7394.

Make gcc4 happy.

ShowImage: add feature to force original size.

* This is enabled by shift+click on the Original Size toolbar button.
* The button stays pressed as long as the feature is enabled. Clicking
it again disables it.
* When this is enabled, all images will be shown at original size,
instead of being scaled up or down to fit the window.
* This is not persistent, and only affects the current session/window.

Revert attempt to fix stretch-to-window.

Turns out the option shouldn't do what I need. Let's add another option.

ShowImage: fix scale-to-fit behavior

* Fix the condition so that big images are fitted to the window on first
time only if the option is set.
* Small images are never stretched to the window size, as this isn't
very useful.

The interaction of this global setting with the zoom buttons is a bit
confusing. Should they be merged?

ShowImage: Scroll horizontally with control

...instead of command.

See http://www.freelists.org/post/haiku-commits/haiku-hrev46304-srckitsinterface,18

ShowImage: Style fixes related to scrolling

Remove unused ShowImage Undo code.

Change the cursor hiding so it isn't done constantly when enabled.

Fix #8781. Display rotated images with alpha channel properly

Signed-off-by: Axel Dörfler <axeld@pinc-software.de>

Fix #7736. Avoid memory corruption

Signed-off-by: Axel Dörfler <axeld@pinc-software.de>

Close alerts with ESCAPE key.

Added SetFlags(B_CLOSE_ON_ESCAPE) or SetShortcut(index, B_ESCAPE) to BAlerts
depending if the result gets used later in the code, or if it's a one-button
BAlert.

Coding style changes, no functional change.
Hope all's OK, Filter.h is still mostly untouched as it's quite messy with
many exessive commenting.

Fixed issue when auto-showing toolbar in fullscreen mode.

If you've zoomed in fullscreen mode and moved the mouse to the top of the
screen, the toolbar didn't appear. You had to scroll up to the top of zoomed
image first. Using the screen coords instead of the view coords fixes this.

More catalog-related cleanup.

* rename B_TRANSLATE_CONTEXT to B_TRANSLATION_CONTEXT and
B_TRANSLATE_WITH_CONTEXT to B_TRANSLATE_CONTEXT, squashing a TODO
* adjust all uses of both macros in Haiku's source tree
* use correct header guard for collecting/Catalog.h

The renamed macros require adjustments to all external applications
using catalogs.

Make the zoom "sticky" at 1.0 for about half a second when zooming with the mousewheel.

It might be a bit annoying, not sure yet.

Implements #7253.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42311 a95241bf-73f2-0310-859d-f6bbb57e9c96

Changing the order of function calls in SelectAll() causes the selection rect
size to show up correctly in the status bar.

Fixes #7710.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42310 a95241bf-73f2-0310-859d-f6bbb57e9c96

In fullscreen mode, hide and show the toolbar based on the mouse's position,
not just any mouse movement. When the mouse reaches the top 15 pixels, show the
toolbar, otherwise hide it.

Implements #7735.

On a related note, the animation for toolbar showing and hiding which Stephan
implemented is really nice. We need more animation in Haiku!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42307 a95241bf-73f2-0310-859d-f6bbb57e9c96

Delete the cursors in the view destructor. Thanks Axel!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42237 a95241bf-73f2-0310-859d-f6bbb57e9c96

Account for quickly repeated double clicks when toggling fullscreen mode. If
done fast enough the click count can reach 7 pretty easily.

Fixes #7591.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42233 a95241bf-73f2-0310-859d-f6bbb57e9c96

Use grabbing cursor when moving image with the mouse.

Fixes #7592.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42232 a95241bf-73f2-0310-859d-f6bbb57e9c96

Make the delete key clear the selection in selection mode, trash the file otherwise.

Fixes #6772.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42231 a95241bf-73f2-0310-859d-f6bbb57e9c96

* We obviously need to relayout manually, as it looks like the view is not
layouted correctly after the resize. This fixes bug #7577. Ingo, is this
the desired behaviour of the layout engine, and if so, what's the rationale
behind it?
* Removed extraneous FitToBounds() call in ShowImageView::SetHideIdlingCursor();
it doesn't belong there.
+alpha


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41772 a95241bf-73f2-0310-859d-f6bbb57e9c96

* The window uses layout management in principle. This was necessary
to get the main menu bar to report the correct minimum size. My
previous commit with regards to setting the correct minimum window
size introduced a regression that the window could not shrink below
it's initial size because of some backwards compatibility behavior
of BMenuBar (IIRC).
* Inserted a content view to hold the tool bar and the show image
views. This one does not use layout management, so that everything
pretty much works as before.
* Showing/Hiding the tool bar is now animated.
* When the tool bar is enabled in principle, it will automatically
show in full screen mode when the user moves the mouse. When the
mouse is not above the tool bar, it is hidden after a delay.
* Added a right-aligned "Leave full screen" icon to the tool bar.
* Improved the workings of the slide show icon. As before, it automatically
triggers full screen mode. It is now pressed when the slide show is
running. Clicking it again just stops the slide show without affecting
the full screen mode (i.e. also not when the user left full screen mode
meanwhile).

There are some problems with images not being automatically sized to
the full screen size as would be expected. This needs to be fixed, yet.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41202 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Double click now toggles full screen, as in the MediaPlayer.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41069 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Fit image to the view bounds again after a rotation (it's quite annoying when
you suddenly only see part of the image). This could be improved by only doing
so if the image was fit before, too.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40808 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Made the minimum zoom depend on the actual zoom factor, too. This fixes the
wrong resizing as observed by humdinger.
* I did not remove the limit altogether, because it's a bit odd to be able to
zoom out until you only see a pixel from the original image... Maybe someone
has a better idea on how to go about this.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40582 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed a typo.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40554 a95241bf-73f2-0310-859d-f6bbb57e9c96

Remove hack introduced in r36806 to offset the context menu due to our
previously bad menu handling.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40179 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Removed the slide show code from ShowImageView, and reimplemented them in
ShowImageWindow using a BMessageRunner.
* Note, this is completely untested, as it turns out my Haiku installation on
this box is too old to run it. It compiles, at least, and shouldn't break
anything else.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40178 a95241bf-73f2-0310-859d-f6bbb57e9c96

CID 6925: Use snprintf. Also sizeof(size) is kind of funny.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40008 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Also call FitToBounds() when you disable stretching, and the image is
currently zoomed in. This closes #6857.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39631 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Fixed #3042 as suggested by Stippi (looks like I'm quickly following Ingo's
great example at getting senile - at least he told me about this solution
before; the same trick is already used in SetZoom()).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39527 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Removed the "shrink to window" option. Instead, there is now a "Fit to window"
menu item that just does that. Additionally, the image is always fit to the
window size when first shown, or if the full screen mode switches.
That also fixes #6765, and #6810.
* The ImageCache now also passes a referenced BitmapOwner object, and bitmaps
are now actually freed when it's allowed to.
* Pressing the zoom button will cause ShowImage to enter full screen again. For
some reason this has been removed as part of r19540.
* The progress window is now visible again, although not that often, as you will
only see it for images that were not in the queue already. The window is now
known to the ShowImageWindow instead of the ShowImageView.
* Moved most constants out of ShowImageConstants.h to where they belong.
* Dropping an image now opens it in another window.
* Removed EntryMenuItem as it's no longer used anywhere.
* Minor other cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39431 a95241bf-73f2-0310-859d-f6bbb57e9c96

* The ImageFileNavigator is now only for navigation, it doesn't load any images
anymore.
* Moved the new ImageCache into its own source file.
* The cache is now used within ShowImage. There is no read-ahead caching being
done yet, though, but you can quickly return to previous images, and you can
also skip images faster than before.
* Improved separation between the ShowImageStatusView and the rest;
ShowImageWindow no longer has a getter for the image view.
* The status view is now using the private BDirMenu which implements enhancement
ticket #6778.
* Made a few more methods private/protected in ShowImageWindow.
* Fixed bug #6797.
* The bitmap is currently only owned by the ImageCache, but we need to have a
separate referenceable object owning it. Added a TODO comment for this.
* The ProgressWindow is currently not being used anymore, added a TODO comment
for this as well.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39364 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Work in progress on implementing asynchronous image retrieval with a
read-ahead cache. Not yet done or used.
* Added deleting images via delete key again. The only difference to before is
that it will open the previous image if the last image in a folder was
removed, and only close ShowImage if there is no image left.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39322 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Moved the Tracker navigation logic into its own class, TrackerNavigation.
* Added a new class FolderNavigation that implements the same for folders
without a Tracker window.
* ImageFileNavigator is now using either one depending on whether it got a
valid tracker messenger.
* Removed some unused/unneeded methods.
* Made entry_ref a reference at some more methods, as it's not really optional.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39292 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Completed stippi's work on the ImageFileNavigator.
* ShowImageWindow is now using such a navigator.
* Removed navigation support from ShowImageView.
* Prepared everything to support asynchronous image loading (which is not yet
implemented, though).
* Note, this commit brings some regressions I intend to fix in the next few
days, namely deleting files won't work anymore, and dropping images onto
ShowImage. There might be more I don't know about, though :-)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39259 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Added a selection mode that can currently only be enabled via the menu
(should be part of an optional tool bar in the future). Now the primary, and
the tertiary mouse button pan the image. You still get the selection when
using alt or ctrl and the primary mouse button, even outside of the selection
mode. In selection mode, the primary button changes the selection.
* Renamed {Shrink|Stretch}ToBounds() to comply to our coding style, thanks Ingo.
* Minor cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39132 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Fixed another pet peeve of mine: you can now always zoom, no matter if you
have enabled the shrink/stretch option.
* Renamed "zoom to window" to "stretch to window".
* Readded the shrink/stretch options to the full screen context menu only.
* Renamed GetShrinkToBounds() to ShrinkToBounds() as it's a simple getter.
* Changed how and when the shrink/stretch options come into play. Shrinking is
now only set once, when the image is first shown.
* Added snapping in ZoomIn(), and ZoomOut(): they will now always choose 1.0,
and the "fit to window" zoom level when they are close.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39129 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Fixed typo.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39117 a95241bf-73f2-0310-859d-f6bbb57e9c96

* The shrink/zoom to window options aren't available anymore from the context
menu. I plan to allow zooming always, so they won't be needed that often
anymore.
* Removed all selection copy/move/cut code. This just doesn't belong into an
image viewer.
* Selections are now changed using the tertiary mouse button, or when you press
the command or control modifiers. Instead, the image will now be moved around
with the left button.
* If you drop an image file to ShowImage, it will now open it instead of pasting
it as selection.
* Reworked the scrolling/selection code to never poll, and never use GetMouse().
Instead properly use the asynchronous API (ie. B_NO_POINTER_HISTORY).
* I plan to remove the scaling code as well: the results aren't as good as they
could be (bilinear scaling isn't the solution for everything), and the
interface is pretty awkward, anyway. IMO, this kind of functionality should
be left to apps that are actually thought for image editing. Another solution
would be a Tracker add-on that resizes (multiple) images.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39105 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Removed the delayed scaler code - it's no longer needed (and was trying rather
stupid things like creating a 50000x40000 pixel bitmap if you zoomed in).
* Removed dithering in CMAP8 mode. Please use 32 bit mode instead :-)
* Cleaned up ShowImageWindow.h.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39098 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Removed the ability to invert an image. If you really need that feature,
you'll now have to open an image editing application instead.
* Removed the black border around the image.
* Removed the B_PANEL_BACKGROUND_COLOR background in non-full screen mode - it's
now always black.
* Made zoom level changes exponential.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39095 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Implemented zooming to the current mouse position. Thanks to stippi for the
invalidate trick to prevent the app_server to scroll.
* Minor cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39079 a95241bf-73f2-0310-859d-f6bbb57e9c96

Removed one liner function that was only called from one place.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37166 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Moved selection box handling into a separate class SelectionBox. Mouse hooks
of that class are not yet used. Invalidation of the view could also work
via listener mechanism.
* Made image <-> view conversion and constraint methods public.
* Sorted .cpp files in Jamfile alphabetically.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37164 a95241bf-73f2-0310-859d-f6bbb57e9c96

Previously misunderstood what fMovesBitmap means, renamed _MoveBitmap() also
so these two match up again and refer scrolling.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37160 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Coding style cleanup
* Some cleanup in member sorting
* Some renaming of members for improved clarity
* Removed _HasSelection() and use fHasSelection directly


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37159 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Fixed storage of image data in the system clipboard. According to the
comments in the code, different programs do it differently. However, I
believe we should follow the BeBook documentation. This is the method which
WonderBrush uses as well, and that one had been tested with other apps like
Refraction. Potentially, copy&paste could work across GoBe Productive now
also, but I didn't test.
* Handle the case where the selection bitmap that gets restored from the
clipboard has a bounds rectangle with an offset. Use this offset as an
alternative to the "be:location" hack.
* Fix the drag bitmap to be semi-transparent on Haiku. B_OP_SELECT does not
affect the alpha channel on Haiku like it apparently did on BeOS, though
I am not inclined to change that behavior.
* Fixed some coding style violations, but tried to mix as little cleanup as
possible.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37118 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Do not use the Scaler anymore for asynchronous bilinear filtering, but pass
B_FILTER_BITMAP_BILINEAR to DrawBitmap(). There is virtually no delay at all.
* Some cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37080 a95241bf-73f2-0310-859d-f6bbb57e9c96

Use a 2 pixel offset instead of 5 for the ShowImage context menu.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36806 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fix #5808. I'm not completely happy with this solution, but it fixes the
problem without a bunch of refactoring. I intend to do more refactoring of
ShowImage after developing an automated test suite.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36800 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fix #5809 by making the context menu sticky and also offsetting the open point
by 5 pixels. Add a check so that multiple context menus aren't opened.

Also don't draw a 0 x 0 selection rect.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36799 a95241bf-73f2-0310-859d-f6bbb57e9c96

Updated TR_CONTEXT to be B_TRANSLATE_CONTEXT, relating to #5408.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36733 a95241bf-73f2-0310-859d-f6bbb57e9c96

Updated to use B_TRANSLATE* macros. relates to #5408.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36673 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by Jorma Karvonen, modified by myself to remove translations of BView
names and localization unfriendly string composition. Closes ticket #5563,
thanks!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36647 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Fix can't cut and drag a piece of picture from ShowImage to Desktop, ticket #4874.
* Set the current image mime as first in the translators list, thus on drag&drop with
left mouse button the same image type is created as the currently loaded in ShowImage.

Still this does more hide than fix the real problem, beeing ICO translator the first in
the generated translator list due to the high capabilitys values and a limited set of
output sizes it can handle. I attached a further fix to the ticket, still i would like
to get some other opinions on it before commiting.


By default the transla


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35139 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by Humdinger:
Updated Haiku apps to use sentence-case. What a huge undertaking...
The files where I had to apply the patch manually (for mysterious
reasons) have also gotten a whitespace cleanup. I've proof-read
everything so hopefully there should be no problems.

This should be the final part of #5169.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35049 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Applied patch by Idefix that fixes bug #4730 by removing the iterate over
directory functionality without Tracker.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34103 a95241bf-73f2-0310-859d-f6bbb57e9c96

* The new Command-[Shift-]'R' shortcut for rotation is annoyingly unhandy; added
'[' and ']' to rotate without having the Command key held.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33846 a95241bf-73f2-0310-859d-f6bbb57e9c96

- Added back code for scrolling with the cursor keys, this time only when Shift
is pressed.

- Took Humdinger's excellent advice from #4190 to open the Backgrounds
preferences from ShowImage instead of setting the background manually. This
required some tweaks to the Backgrounds preferences to accept RefsReceived in
the application and forward that to the view. In addition the placement is
set to scaled since otherwise it will keep the old placement. How this is
done is sort of hacky, but I'm going to call it an "internal protocol." This
also allowed me to remove the BackgroundImage code from ShowImage which was
just copied from Tracker (yuck.)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32424 a95241bf-73f2-0310-859d-f6bbb57e9c96

Implemented pretty much all of #4190. The Enter key was actually already set as
a shortcut for fullscreen, but I guess the view was processing it first. So I
just removed B_ENTER as an option for next image. Also Shift plus primary mouse
was already working for moving the image.

Also I know it was discussed at length but I still wonder if all these options
for next and previous image are overkill. Now there is no way to scroll with
the keyboard. And there isn't an easy way to go to the next image with the
mouse (menus are a pain.) So I still think some more UI tweaking is needed to
avoid constant shifting between mouse and keyboard.

Finally I also added Command-1 as a shortcut for Original Size, but it does not
work. Anyone know why?


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32343 a95241bf-73f2-0310-859d-f6bbb57e9c96

Started cleaning up these monsters:

- Add underscore to private methods.
- Use class member initializer syntax.
- Make sure all class members are initialized, use same order as headers.
- Header reordering.
- A few other small things.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32342 a95241bf-73f2-0310-859d-f6bbb57e9c96

fix a style violation


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28507 a95241bf-73f2-0310-859d-f6bbb57e9c96

* traverse the entry so that symlinks to files can be opened as well



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27957 a95241bf-73f2-0310-859d-f6bbb57e9c96

* cleanup



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27956 a95241bf-73f2-0310-859d-f6bbb57e9c96

patch by Andrea Anzani:
* fix a rounding problem when layouting the image
Thanks!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@23427 a95241bf-73f2-0310-859d-f6bbb57e9c96

Remove debugging printf.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@21393 a95241bf-73f2-0310-859d-f6bbb57e9c96

The zoom level needed to be reset to 1.0 after loading an image, otherwise it
would keep the zoom level of the previous image in some cases.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@21392 a95241bf-73f2-0310-859d-f6bbb57e9c96

Changed the progress monitor protocol to path a basic message that will be sent back
instead of having a fixed message code.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20746 a95241bf-73f2-0310-859d-f6bbb57e9c96

Implemented a progress window: it will be shown after one second in case the translator
supports it - currently, only the RAW image translator does this (as it needs about 10
seconds to open a 6 mio. pixel RAW image on a 2.6 GHz P4).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20650 a95241bf-73f2-0310-859d-f6bbb57e9c96

The size of the selection rectangle is now shown in the status bar. Useful for
cropping an image to a certain size or taking similar sized croppings from
various images (as I need to do.)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20012 a95241bf-73f2-0310-859d-f6bbb57e9c96

General changes:
- Fixed some formatting in the recently added resizing code.
- Changed the operation name for rotating counterclockwise to use that name
instead of anticlockwise. This makes the code consistent with the GUI.
- Reformatted the constants header to use an enum. Also removed the empty
constants cpp file.
- The QuitRequested handler in the app did not ask the windows to close, which
could cause modified images to be closed without prompting the user. Now it
does, which makes ShowImage more user friendly.

Changes to the image view:
- Added a member for keeping track of the type of image. This is mostly used in
properly updating the window's status bar when the image is changed (flipped,
rotated, etc.) This removes some hacky code I added before :)
- Removed the status parameter in the Notify method since it was only used for
the above image type status updating.
- Removed a redundant if in the mouse up handler.
- The key down handlers for moving to the next and previous image did not
properly prompt the user if the image had changed. I fixed this by sending a
message to the window where the prompting code resides. When adding this I
also created a few helper methods for sending messages to the window, which
removed some (small) repeated code through-out the class.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19994 a95241bf-73f2-0310-859d-f6bbb57e9c96

Removed "Stippled Zooming" item and made dithering automatic in 8-bit screen mode
"Keep Proportions" in resizing window became "Keep Original Proportions", which was suggested by korli and is the best suggestion IMO
Bilinear scaling is on by default
I like ShowImage's menus now. :^)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19877 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed selection handling bug if zoom level is not 1.0. Zoom factor has to be calculated in Setup() otherwise the selection rectangle uses the wrong zoom level.
Bug was introduced in revision 19253.
@Ryan: Can you please verify that this fix does not introduce another bug?


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19648 a95241bf-73f2-0310-859d-f6bbb57e9c96

Changed the delay on hiding the cursor in fullscreen to 2 seconds (much
better...not sure what I was thinking with 5 seconds before.) I also fixed a
few other issues related to this.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19578 a95241bf-73f2-0310-859d-f6bbb57e9c96

Implemented Stephan's previous TODO (in an svn commit message) to hide the
cursor after a delay when in fullscreen mode. I set the delay to 5 seconds. In
addition I make sure the ShowImage window is the active window before trying to
hide the cursor, because otherwise there is a lot of cursor flickering if you
change workspaces.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19569 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added support to ShowImage for sending an image to the Trash by scripting
Tracker. For now it only works when the delete key is pressed. I suppose a menu
item might be useful, but I can do that later if people really want it :)

When the image is trashed the next image in the directory is opened. If the
trashed image is the last in the directory the window is closed.

The code seems pretty solid as I even tested it with Tracker not running. It
also works fine in R5 (in fact that is where I tested it.)

As shown I would prefer to use the Tracker headers rather than redefining the
constant used for the trashing message. I'm already using Tracker's app MIME
type from the private headers.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19564 a95241bf-73f2-0310-859d-f6bbb57e9c96

Integrated "resize" feature from Zetas version of ShowImage, however used our bilinear scaler instead of Zetas implementation and made ResizerWindow font sensitive and removed the radio buttons with predefined sizes. Kudos to Bernd Korz for providing the ShowImage Zeta source code under MIT license.
Moved menu item "As Desktop Background" into "Image" menu from "View" menu.
Removed unused metod ShowImageWindow::Zoom(...).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19540 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added some needed stdio.h includes. I don't know what magic was used to compile
these for other people, but they wouldn't compile for me when building the
app_server test environment.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19479 a95241bf-73f2-0310-859d-f6bbb57e9c96

Several ShowImage changes:

- Changed the hotkey for the zoom to be = instead of + so that no shifting is necessary.
- Fixed the bitmap alignment code to solve some problems when zooming.
- Removed all references to alignment in the view since the image was already always centered. This greatly simplified the bitmap alignment.
- Removed the redundant fScaleX and fScaleY members of the view since they were always the same as fZoom.
- Removed all code related to having a border in the view.
- Fixed a bug where the type of file would disappear in the status area when zooming (this fix is a little hackish.)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19253 a95241bf-73f2-0310-859d-f6bbb57e9c96

More changes to ShowImage:

1. The newly renamed "Flip Sideways" and "Flip Upside Down" have been renamed again to "Flip Left To Right" and "Flip Top To Bottom". This was after some feedback indicating a preference for the new names.

2. When dragging a selection the standard outlined rectangle is used for the dragging image instead of the alpha-blended bitmap of the selected part of the image if the selection rectangle is larger than 400x400 (taking into account scaling of the image.) This mimics the original ShowImage with the exception of the minimum size. The choice of 400x400 was fairly arbitrary. I may see about turning that value into some kind of hidden option.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17229 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixes to ShowImage:

1. Renamed the Image menu items "Mirror Vertical" and "Mirror Horizontal" to "Flip Sideways" and "Flip Upside Down", respectively. This also involved changing the code to match the new names, for consistency.
2. Fixed a bug where zooming in and out would result in the image moving off center. This was due to the bitmap width and height not being recalculated after applying the zoom factor and therefore throwing off the calculations to find the rect for the center.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17182 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Mabye I should do better testing of what I "fix"; absolute paths didn't work
anymore from the command line all of a sudden...
* Made the caption background slightly less translucent to allow the text to
be read even with very checkered images.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16280 a95241bf-73f2-0310-859d-f6bbb57e9c96

Made the caption in full screen mode a bit easier to look at (boring yes, but some
people out there just aren't colour blind :-)).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16279 a95241bf-73f2-0310-859d-f6bbb57e9c96

* No longer hides the mouse cursor when the pop up menu is shown.
* Removed the superfluous "Cancel" item from the pop up menu.
* Cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16277 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed various issues:
* ArgvReceived() did not work with relative paths.
* Simplified quitting (no more CanQuit() and overriding BWindow::Quit()).
* Updated signature.
* Cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16260 a95241bf-73f2-0310-859d-f6bbb57e9c96

* quick fix for when fBitmap has been recomposed
partly, fDisplayBitmap is not correctly re-established...


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@15887 a95241bf-73f2-0310-859d-f6bbb57e9c96

* quick hack to hide the cursor in fullscreen
(TODO: do this after a time out)
* quick hack to display bitmaps containing an
alpha channel with a checker background
(TODO: rework filters to be alpha channel
aware and compose the checker background
independently of the filter)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@15886 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixes that make Haiku build with gcc 4. Mainly out of the following
categories:
* Missing includes (like <stdlib.h> and <string.h>).
* Linking against $(TARGET_LIBSTDC++) instead of libstdc++.r4.so.
* Local variables shadowing parameters.
* Default parameters in function definitions (as opposed to function
declarations).
* All C++ stuff (nothrow, map, set, vector, min, max,...) must be imported
explicitly from the std:: namespace now.
* "new (sometype)[...]" must read "new sometype[...]", even if sometype is
something like "const char *".
* __FUNCTION__ is no longer a string literal (but a string expression), i.e.
'printf(__FUNCTION__ ": ...\n")' is invalid code.
* A type cast results in a non-lvalue. E.g. "(char *)buffer += bytes"
is an invalid expression.
* "friend class SomeClass" only works when SomeClass is known before.
Otherwise the an inner class with that name is considered as friend.
gcc 4 is much pickier about scopes.
* gcc 4 is generally stricter with respect to type conversions in C.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@14878 a95241bf-73f2-0310-859d-f6bbb57e9c96

fixed alignment and image layout, esc exits fullscreen mode, black background for fullscreen, zooming window toggles fullscreen, can still browse even if current image has been deleted, space toggles slideshow, swapped next/previous menu items (more logical)

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@13101 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed page changing, simplified entry_ref usage in SetImage()


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@11366 a95241bf-73f2-0310-859d-f6bbb57e9c96

cosmetical improvements to status view, it also shows the image size now


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@9113 a95241bf-73f2-0310-859d-f6bbb57e9c96

Re-Added directory based Next/Previous file functionality. Now, if tracker scripting is unavailable, user will still be able to use Next/Previous file commands and the slideshow feature


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@8067 a95241bf-73f2-0310-859d-f6bbb57e9c96

Implemented rewind functionality so that slide show no longer stops when it reaches the last file in the directory


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@7453 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed to check if refs are directories and to error properly if they are


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6949 a95241bf-73f2-0310-859d-f6bbb57e9c96

Use Tracker Scripting to find next/previous image.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6203 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed file saving code so that it is only in one place, (instead of two) and fixed File-->Save As so that it now writes out the type attribute


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6127 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added feature where a file dropped from the Tracker becomes the current selection


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6121 a95241bf-73f2-0310-859d-f6bbb57e9c96

Bug fixed: ignore user zoom setting in automatic zoom modes.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6000 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed bug in FindNextImage where -1 is returned instead of false


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5895 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed bug which occured when the Next or Previous image command was used with an image that failed to translate. Changed Next/Previous image behavior to skip past images that fail to translate.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5894 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed access to invalid bitmap bug.
Refactored code a little bit.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5746 a95241bf-73f2-0310-859d-f6bbb57e9c96

Removed some debug print statements, set the maximum allowed Zoom to 1600%


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5744 a95241bf-73f2-0310-859d-f6bbb57e9c96

Disable the Invert menu item for B_CMAP8 bitmaps because they are currently unsupported by the invert algorithm.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5721 a95241bf-73f2-0310-859d-f6bbb57e9c96

Cleared the Undo buffer when actions that are reversable are performed. Disabled Invert command for B_CMAP8 bitmaps, as they are not properly inverted


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5720 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed Edit-->Clear to leave behind a white box if the selection box is not moved after it is made, added Undo capability for Cut and Clear actions


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5719 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added initial implementation of Undo for OBOS ShowImage! Now, users can Undo/Redo merge/paste operations. Still need to enhance Undo further so that other operations can be undone, also need to account for image rotations and similar operations.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5693 a95241bf-73f2-0310-859d-f6bbb57e9c96

Changed Paste/DragDrop code so that a clip does not have to be pasted entirely within the bounds of the background bitmap


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5654 a95241bf-73f2-0310-859d-f6bbb57e9c96

Implemented drag/drop from one ShowImage window to another


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5653 a95241bf-73f2-0310-859d-f6bbb57e9c96

Removed unneeded calls to Invalidate(), changed minimum size for selection rectangle so that users can click in an empty section of the window to unselect the selection


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5641 a95241bf-73f2-0310-859d-f6bbb57e9c96

Removed Keydown handler code that invoked the creation/removal of the thumbnail icons


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5495 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added checking for modified document and prompt the user if they try to close a document without saving.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5492 a95241bf-73f2-0310-859d-f6bbb57e9c96

- Fixed bug in conversion from image coordinates to view coordinates are vice versa.
- Change the size of the image being dragged to size of the selection in the view coordinate system.
- Experimental: delay start of filtering thread(s) for some tenth of a second. This allows faster update during resizing.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5491 a95241bf-73f2-0310-859d-f6bbb57e9c96

Changed Cut behavior to match Be's version so that if the user Cuts a selection before moving it, the selection is cut, and a white rectangle is left in its place. If the selection is dragged before the Cut command is used, a white rectangle is not drawn.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5489 a95241bf-73f2-0310-859d-f6bbb57e9c96

- Implemented Floyd Steinberg dithering algorithm.
- Remembers "orientation" state (rotated, mirrored or inverted) in file attribute of image.
- Update recent documents menu every time the menu is opened.
- Bug fix and optimization in Filter.cpp.
- Moved image manipulation code from ShowImageView.cpp to Filter.cpp. So it can take advantage of multiple CPUs.
- Experimental: Write/remove thumbnail to/from file icons.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5480 a95241bf-73f2-0310-859d-f6bbb57e9c96

- Made some settings persistent: Slide Show Delay, Scale Bilinear, Shrink/Zoom to Window, Show Caption in Full Screen Mode and PrintOptions.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5441 a95241bf-73f2-0310-859d-f6bbb57e9c96

Rollback to original/way better constrated captions colors.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5437 a95241bf-73f2-0310-859d-f6bbb57e9c96

Ooops, forget to match caption rect size and position there too...


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5420 a95241bf-73f2-0310-859d-f6bbb57e9c96

Including Clipboard.h could help.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5419 a95241bf-73f2-0310-859d-f6bbb57e9c96

- Made some settings persistent: Slide Show Delay, Scale Bilinear, Shrink/Zoom to Window, Show Caption in Full Screen Mode and PrintOptions persistent.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5415 a95241bf-73f2-0310-859d-f6bbb57e9c96

Implemented Cut and Paste. Still need to implement Undo and check for a dirty document when the window or app is closed.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5414 a95241bf-73f2-0310-859d-f6bbb57e9c96

- Rewrote bilinear scaling algorithm. The version that uses fixed point calculations is at least two times faster than the version that uses floating point calculations!
- Fixed off by one bugs.
- Replace "Fit to Window" with "Shrink to Window" and "Zoom to Window".


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5409 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added code to merge selection with background image; removed Select None item, replaced it with Clear as Select None was behaving like Be ShowImage's Clear anyway; properly enabled/disabled Edit menu items when selection is made or cleared. Still no undo yet, but I'm planning to do that after Paste is implemented.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5403 a95241bf-73f2-0310-859d-f6bbb57e9c96

Changed fpBitmap to the more Be-ish notation of fBitmap, added code to allow the user to drag the bitmap selection around like in Be's ShowImage. However, no changes can be made yet to the underlying image. Need to resolve resize flickering of selected image and allow the user to modify the underlying image.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5392 a95241bf-73f2-0310-859d-f6bbb57e9c96

Drag selection code can now move the selection inside the view, fixed selection drag code so that unwanted MouseUps don't affect the selection box movement. Though, drag selection code is not done yet, it is not yet copying the bitmap from where the selection was dragged from, it is just moving the selection rectangle. Dragging a selection to outside of the window still works the same.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5391 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed caption hiding method so that whenever any kind of scrolling is done, the caption is hidden in full screen mode. Previously, the caption would only hide during click-and-drag scrolling and using other scrolling would cause the caption to be painted in various places on top of the image.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5384 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added comments to MouseWheelChanged function which explains how B_MOUSE_WHEEL_CHANGED behaves.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5376 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed issue where view scrolls to the left when mouse wheel is used, changed to scroll faster if the wheel is scrolled multiple clicks per B_MOUSE_WHEEL_CHANGED message, increased the scroll speed


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5375 a95241bf-73f2-0310-859d-f6bbb57e9c96

Bug fixed: virtual function must not be called in destructor.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5352 a95241bf-73f2-0310-859d-f6bbb57e9c96

Bug fixes.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5350 a95241bf-73f2-0310-859d-f6bbb57e9c96

- scale bilinear (experimental: scaled image is too small by one pixel)
- bug fixes


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5347 a95241bf-73f2-0310-859d-f6bbb57e9c96

- Scrolling with mouse wheel
- Moving image with third mouse button pressed
- Added pop up menu with contents of View menu of menu bar
- Center image in full screen mode
- Added Select None menu item
- To avoid flickering, disabled caption during moving image with mouse- Added key bindings:
- Cursor keys: moves image
- Enter or space bar: next file
- Backspace: previous file
- Escape: Stops slide show
- SHIFT + first mouse button: simulate third mouse button
- CONTROL + first mouse button: simulates second mouse button


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5322 a95241bf-73f2-0310-859d-f6bbb57e9c96

- added printing support
- added zoom in and out
- next/previous file sorts directory entries by itself; does not rely on file system
- added shortcuts to the first 10 menu items of Go To sub menu


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5299 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added Go To Page submenu so the user can directly go to the page that they want. Also fixed a typo.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5290 a95241bf-73f2-0310-859d-f6bbb57e9c96

- renamed and restructured menu bar
- show dialog box when image can not be opened
- added optional caption in full screen mode
- moved/removed code from ShowImageApp to ShowImageView


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5289 a95241bf-73f2-0310-859d-f6bbb57e9c96

- added recent documents sub menu
- added resize window to image size when file is opened
- added drag and drop selection
- added copy selection to clipboard


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5288 a95241bf-73f2-0310-859d-f6bbb57e9c96

- added full screen mode
- added dia show
- added rotate image clockwise, anti-clockwise, mirror image vertical or -horiztonal and invert image
- added myself to about dialog and copyright holders


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5270 a95241bf-73f2-0310-859d-f6bbb57e9c96

- added option resize image to window size
- added show next/previous file using Command + Cursor Up/Down key
- rewrote selection code
- added marching ants
- renamed member variables to start with capital letter after field prefix


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5255 a95241bf-73f2-0310-859d-f6bbb57e9c96

Changed selection box to use a checkered pattern, closer to what Be's ShowImage uses. Stopped using inversion to clear old selections, drawing the bitmap over them instead. Fixed the rect used in setting the view bitmap.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5090 a95241bf-73f2-0310-859d-f6bbb57e9c96

Implemented preliminary selection box skeleton code. Need to add marching ants and connect selection box status to Edit menu.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5083 a95241bf-73f2-0310-859d-f6bbb57e9c96

removed (page x of y) from status text, (page info should come from the identify string of translators that support multiple pages) added a border around the image (like Be's ShowImage has), added disabling of Page menu for single page images


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4218 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added multi-page support (as in OBOS TIFFTranslator). Made many changes to the way the app, window and view objects interface with each other. Still could use some polish.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4216 a95241bf-73f2-0310-859d-f6bbb57e9c96

Change to have a more consistent coding style, eliminated unused / unessecary code, added MIT license notice, prevented image window from closing when a save panel is open, prevented the user from opening multiple save panels for a single image window, etc.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4214 a95241bf-73f2-0310-859d-f6bbb57e9c96

Removed selection box code


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4210 a95241bf-73f2-0310-859d-f6bbb57e9c96

Changed Save AS sub menu to only show the available destination types for bitmap images, implemented Save As feature


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4181 a95241bf-73f2-0310-859d-f6bbb57e9c96

Initial Checkin. Coded by Fernando Francisco de Oliveira.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@388 a95241bf-73f2-0310-859d-f6bbb57e9c96

Showimage: Add zoom level to StatusBar.

* Improve StatusBar graphics (Same style as StyledEdit).
* Resize the StatusBar to best fit.
* Fixes #7394.

Make gcc4 happy.

ShowImage: add feature to force original size.

* This is enabled by shift+click on the Original Size toolbar button.
* The button stays pressed as long as the feature is enabled. Clicking
it again disables it.
* When this is enabled, all images will be shown at original size,
instead of being scaled up or down to fit the window.
* This is not persistent, and only affects the current session/window.

Revert attempt to fix stretch-to-window.

Turns out the option shouldn't do what I need. Let's add another option.

ShowImage: fix scale-to-fit behavior

* Fix the condition so that big images are fitted to the window on first
time only if the option is set.
* Small images are never stretched to the window size, as this isn't
very useful.

The interaction of this global setting with the zoom buttons is a bit
confusing. Should they be merged?

ShowImage: Scroll horizontally with control

...instead of command.

See http://www.freelists.org/post/haiku-commits/haiku-hrev46304-srckitsinterface,18

ShowImage: Style fixes related to scrolling

Remove unused ShowImage Undo code.

Change the cursor hiding so it isn't done constantly when enabled.

Fix #8781. Display rotated images with alpha channel properly

Signed-off-by: Axel Dörfler <axeld@pinc-software.de>

Fix #7736. Avoid memory corruption

Signed-off-by: Axel Dörfler <axeld@pinc-software.de>

Close alerts with ESCAPE key.

Added SetFlags(B_CLOSE_ON_ESCAPE) or SetShortcut(index, B_ESCAPE) to BAlerts
depending if the result gets used later in the code, or if it's a one-button
BAlert.

Coding style changes, no functional change.
Hope all's OK, Filter.h is still mostly untouched as it's quite messy with
many exessive commenting.

Fixed issue when auto-showing toolbar in fullscreen mode.

If you've zoomed in fullscreen mode and moved the mouse to the top of the
screen, the toolbar didn't appear. You had to scroll up to the top of zoomed
image first. Using the screen coords instead of the view coords fixes this.

More catalog-related cleanup.

* rename B_TRANSLATE_CONTEXT to B_TRANSLATION_CONTEXT and
B_TRANSLATE_WITH_CONTEXT to B_TRANSLATE_CONTEXT, squashing a TODO
* adjust all uses of both macros in Haiku's source tree
* use correct header guard for collecting/Catalog.h

The renamed macros require adjustments to all external applications
using catalogs.

Make the zoom "sticky" at 1.0 for about half a second when zooming with the mousewheel.

It might be a bit annoying, not sure yet.

Implements #7253.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42311 a95241bf-73f2-0310-859d-f6bbb57e9c96

Changing the order of function calls in SelectAll() causes the selection rect
size to show up correctly in the status bar.

Fixes #7710.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42310 a95241bf-73f2-0310-859d-f6bbb57e9c96

In fullscreen mode, hide and show the toolbar based on the mouse's position,
not just any mouse movement. When the mouse reaches the top 15 pixels, show the
toolbar, otherwise hide it.

Implements #7735.

On a related note, the animation for toolbar showing and hiding which Stephan
implemented is really nice. We need more animation in Haiku!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42307 a95241bf-73f2-0310-859d-f6bbb57e9c96

Delete the cursors in the view destructor. Thanks Axel!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42237 a95241bf-73f2-0310-859d-f6bbb57e9c96

Account for quickly repeated double clicks when toggling fullscreen mode. If
done fast enough the click count can reach 7 pretty easily.

Fixes #7591.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42233 a95241bf-73f2-0310-859d-f6bbb57e9c96

Use grabbing cursor when moving image with the mouse.

Fixes #7592.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42232 a95241bf-73f2-0310-859d-f6bbb57e9c96

Make the delete key clear the selection in selection mode, trash the file otherwise.

Fixes #6772.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42231 a95241bf-73f2-0310-859d-f6bbb57e9c96

* We obviously need to relayout manually, as it looks like the view is not
layouted correctly after the resize. This fixes bug #7577. Ingo, is this
the desired behaviour of the layout engine, and if so, what's the rationale
behind it?
* Removed extraneous FitToBounds() call in ShowImageView::SetHideIdlingCursor();
it doesn't belong there.
+alpha


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41772 a95241bf-73f2-0310-859d-f6bbb57e9c96

* The window uses layout management in principle. This was necessary
to get the main menu bar to report the correct minimum size. My
previous commit with regards to setting the correct minimum window
size introduced a regression that the window could not shrink below
it's initial size because of some backwards compatibility behavior
of BMenuBar (IIRC).
* Inserted a content view to hold the tool bar and the show image
views. This one does not use layout management, so that everything
pretty much works as before.
* Showing/Hiding the tool bar is now animated.
* When the tool bar is enabled in principle, it will automatically
show in full screen mode when the user moves the mouse. When the
mouse is not above the tool bar, it is hidden after a delay.
* Added a right-aligned "Leave full screen" icon to the tool bar.
* Improved the workings of the slide show icon. As before, it automatically
triggers full screen mode. It is now pressed when the slide show is
running. Clicking it again just stops the slide show without affecting
the full screen mode (i.e. also not when the user left full screen mode
meanwhile).

There are some problems with images not being automatically sized to
the full screen size as would be expected. This needs to be fixed, yet.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41202 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Double click now toggles full screen, as in the MediaPlayer.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41069 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Fit image to the view bounds again after a rotation (it's quite annoying when
you suddenly only see part of the image). This could be improved by only doing
so if the image was fit before, too.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40808 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Made the minimum zoom depend on the actual zoom factor, too. This fixes the
wrong resizing as observed by humdinger.
* I did not remove the limit altogether, because it's a bit odd to be able to
zoom out until you only see a pixel from the original image... Maybe someone
has a better idea on how to go about this.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40582 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed a typo.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40554 a95241bf-73f2-0310-859d-f6bbb57e9c96

Remove hack introduced in r36806 to offset the context menu due to our
previously bad menu handling.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40179 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Removed the slide show code from ShowImageView, and reimplemented them in
ShowImageWindow using a BMessageRunner.
* Note, this is completely untested, as it turns out my Haiku installation on
this box is too old to run it. It compiles, at least, and shouldn't break
anything else.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40178 a95241bf-73f2-0310-859d-f6bbb57e9c96

CID 6925: Use snprintf. Also sizeof(size) is kind of funny.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40008 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Also call FitToBounds() when you disable stretching, and the image is
currently zoomed in. This closes #6857.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39631 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Fixed #3042 as suggested by Stippi (looks like I'm quickly following Ingo's
great example at getting senile - at least he told me about this solution
before; the same trick is already used in SetZoom()).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39527 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Removed the "shrink to window" option. Instead, there is now a "Fit to window"
menu item that just does that. Additionally, the image is always fit to the
window size when first shown, or if the full screen mode switches.
That also fixes #6765, and #6810.
* The ImageCache now also passes a referenced BitmapOwner object, and bitmaps
are now actually freed when it's allowed to.
* Pressing the zoom button will cause ShowImage to enter full screen again. For
some reason this has been removed as part of r19540.
* The progress window is now visible again, although not that often, as you will
only see it for images that were not in the queue already. The window is now
known to the ShowImageWindow instead of the ShowImageView.
* Moved most constants out of ShowImageConstants.h to where they belong.
* Dropping an image now opens it in another window.
* Removed EntryMenuItem as it's no longer used anywhere.
* Minor other cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39431 a95241bf-73f2-0310-859d-f6bbb57e9c96

* The ImageFileNavigator is now only for navigation, it doesn't load any images
anymore.
* Moved the new ImageCache into its own source file.
* The cache is now used within ShowImage. There is no read-ahead caching being
done yet, though, but you can quickly return to previous images, and you can
also skip images faster than before.
* Improved separation between the ShowImageStatusView and the rest;
ShowImageWindow no longer has a getter for the image view.
* The status view is now using the private BDirMenu which implements enhancement
ticket #6778.
* Made a few more methods private/protected in ShowImageWindow.
* Fixed bug #6797.
* The bitmap is currently only owned by the ImageCache, but we need to have a
separate referenceable object owning it. Added a TODO comment for this.
* The ProgressWindow is currently not being used anymore, added a TODO comment
for this as well.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39364 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Work in progress on implementing asynchronous image retrieval with a
read-ahead cache. Not yet done or used.
* Added deleting images via delete key again. The only difference to before is
that it will open the previous image if the last image in a folder was
removed, and only close ShowImage if there is no image left.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39322 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Moved the Tracker navigation logic into its own class, TrackerNavigation.
* Added a new class FolderNavigation that implements the same for folders
without a Tracker window.
* ImageFileNavigator is now using either one depending on whether it got a
valid tracker messenger.
* Removed some unused/unneeded methods.
* Made entry_ref a reference at some more methods, as it's not really optional.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39292 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Completed stippi's work on the ImageFileNavigator.
* ShowImageWindow is now using such a navigator.
* Removed navigation support from ShowImageView.
* Prepared everything to support asynchronous image loading (which is not yet
implemented, though).
* Note, this commit brings some regressions I intend to fix in the next few
days, namely deleting files won't work anymore, and dropping images onto
ShowImage. There might be more I don't know about, though :-)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39259 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Added a selection mode that can currently only be enabled via the menu
(should be part of an optional tool bar in the future). Now the primary, and
the tertiary mouse button pan the image. You still get the selection when
using alt or ctrl and the primary mouse button, even outside of the selection
mode. In selection mode, the primary button changes the selection.
* Renamed {Shrink|Stretch}ToBounds() to comply to our coding style, thanks Ingo.
* Minor cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39132 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Fixed another pet peeve of mine: you can now always zoom, no matter if you
have enabled the shrink/stretch option.
* Renamed "zoom to window" to "stretch to window".
* Readded the shrink/stretch options to the full screen context menu only.
* Renamed GetShrinkToBounds() to ShrinkToBounds() as it's a simple getter.
* Changed how and when the shrink/stretch options come into play. Shrinking is
now only set once, when the image is first shown.
* Added snapping in ZoomIn(), and ZoomOut(): they will now always choose 1.0,
and the "fit to window" zoom level when they are close.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39129 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Fixed typo.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39117 a95241bf-73f2-0310-859d-f6bbb57e9c96

* The shrink/zoom to window options aren't available anymore from the context
menu. I plan to allow zooming always, so they won't be needed that often
anymore.
* Removed all selection copy/move/cut code. This just doesn't belong into an
image viewer.
* Selections are now changed using the tertiary mouse button, or when you press
the command or control modifiers. Instead, the image will now be moved around
with the left button.
* If you drop an image file to ShowImage, it will now open it instead of pasting
it as selection.
* Reworked the scrolling/selection code to never poll, and never use GetMouse().
Instead properly use the asynchronous API (ie. B_NO_POINTER_HISTORY).
* I plan to remove the scaling code as well: the results aren't as good as they
could be (bilinear scaling isn't the solution for everything), and the
interface is pretty awkward, anyway. IMO, this kind of functionality should
be left to apps that are actually thought for image editing. Another solution
would be a Tracker add-on that resizes (multiple) images.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39105 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Removed the delayed scaler code - it's no longer needed (and was trying rather
stupid things like creating a 50000x40000 pixel bitmap if you zoomed in).
* Removed dithering in CMAP8 mode. Please use 32 bit mode instead :-)
* Cleaned up ShowImageWindow.h.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39098 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Removed the ability to invert an image. If you really need that feature,
you'll now have to open an image editing application instead.
* Removed the black border around the image.
* Removed the B_PANEL_BACKGROUND_COLOR background in non-full screen mode - it's
now always black.
* Made zoom level changes exponential.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39095 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Implemented zooming to the current mouse position. Thanks to stippi for the
invalidate trick to prevent the app_server to scroll.
* Minor cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39079 a95241bf-73f2-0310-859d-f6bbb57e9c96

Removed one liner function that was only called from one place.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37166 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Moved selection box handling into a separate class SelectionBox. Mouse hooks
of that class are not yet used. Invalidation of the view could also work
via listener mechanism.
* Made image <-> view conversion and constraint methods public.
* Sorted .cpp files in Jamfile alphabetically.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37164 a95241bf-73f2-0310-859d-f6bbb57e9c96

Previously misunderstood what fMovesBitmap means, renamed _MoveBitmap() also
so these two match up again and refer scrolling.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37160 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Coding style cleanup
* Some cleanup in member sorting
* Some renaming of members for improved clarity
* Removed _HasSelection() and use fHasSelection directly


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37159 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Fixed storage of image data in the system clipboard. According to the
comments in the code, different programs do it differently. However, I
believe we should follow the BeBook documentation. This is the method which
WonderBrush uses as well, and that one had been tested with other apps like
Refraction. Potentially, copy&paste could work across GoBe Productive now
also, but I didn't test.
* Handle the case where the selection bitmap that gets restored from the
clipboard has a bounds rectangle with an offset. Use this offset as an
alternative to the "be:location" hack.
* Fix the drag bitmap to be semi-transparent on Haiku. B_OP_SELECT does not
affect the alpha channel on Haiku like it apparently did on BeOS, though
I am not inclined to change that behavior.
* Fixed some coding style violations, but tried to mix as little cleanup as
possible.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37118 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Do not use the Scaler anymore for asynchronous bilinear filtering, but pass
B_FILTER_BITMAP_BILINEAR to DrawBitmap(). There is virtually no delay at all.
* Some cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37080 a95241bf-73f2-0310-859d-f6bbb57e9c96

Use a 2 pixel offset instead of 5 for the ShowImage context menu.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36806 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fix #5808. I'm not completely happy with this solution, but it fixes the
problem without a bunch of refactoring. I intend to do more refactoring of
ShowImage after developing an automated test suite.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36800 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fix #5809 by making the context menu sticky and also offsetting the open point
by 5 pixels. Add a check so that multiple context menus aren't opened.

Also don't draw a 0 x 0 selection rect.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36799 a95241bf-73f2-0310-859d-f6bbb57e9c96

Updated TR_CONTEXT to be B_TRANSLATE_CONTEXT, relating to #5408.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36733 a95241bf-73f2-0310-859d-f6bbb57e9c96

Updated to use B_TRANSLATE* macros. relates to #5408.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36673 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by Jorma Karvonen, modified by myself to remove translations of BView
names and localization unfriendly string composition. Closes ticket #5563,
thanks!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36647 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Fix can't cut and drag a piece of picture from ShowImage to Desktop, ticket #4874.
* Set the current image mime as first in the translators list, thus on drag&drop with
left mouse button the same image type is created as the currently loaded in ShowImage.

Still this does more hide than fix the real problem, beeing ICO translator the first in
the generated translator list due to the high capabilitys values and a limited set of
output sizes it can handle. I attached a further fix to the ticket, still i would like
to get some other opinions on it before commiting.


By default the transla


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35139 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by Humdinger:
Updated Haiku apps to use sentence-case. What a huge undertaking...
The files where I had to apply the patch manually (for mysterious
reasons) have also gotten a whitespace cleanup. I've proof-read
everything so hopefully there should be no problems.

This should be the final part of #5169.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35049 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Applied patch by Idefix that fixes bug #4730 by removing the iterate over
directory functionality without Tracker.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34103 a95241bf-73f2-0310-859d-f6bbb57e9c96

* The new Command-[Shift-]'R' shortcut for rotation is annoyingly unhandy; added
'[' and ']' to rotate without having the Command key held.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33846 a95241bf-73f2-0310-859d-f6bbb57e9c96

- Added back code for scrolling with the cursor keys, this time only when Shift
is pressed.

- Took Humdinger's excellent advice from #4190 to open the Backgrounds
preferences from ShowImage instead of setting the background manually. This
required some tweaks to the Backgrounds preferences to accept RefsReceived in
the application and forward that to the view. In addition the placement is
set to scaled since otherwise it will keep the old placement. How this is
done is sort of hacky, but I'm going to call it an "internal protocol." This
also allowed me to remove the BackgroundImage code from ShowImage which was
just copied from Tracker (yuck.)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32424 a95241bf-73f2-0310-859d-f6bbb57e9c96

Implemented pretty much all of #4190. The Enter key was actually already set as
a shortcut for fullscreen, but I guess the view was processing it first. So I
just removed B_ENTER as an option for next image. Also Shift plus primary mouse
was already working for moving the image.

Also I know it was discussed at length but I still wonder if all these options
for next and previous image are overkill. Now there is no way to scroll with
the keyboard. And there isn't an easy way to go to the next image with the
mouse (menus are a pain.) So I still think some more UI tweaking is needed to
avoid constant shifting between mouse and keyboard.

Finally I also added Command-1 as a shortcut for Original Size, but it does not
work. Anyone know why?


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32343 a95241bf-73f2-0310-859d-f6bbb57e9c96

Started cleaning up these monsters:

- Add underscore to private methods.
- Use class member initializer syntax.
- Make sure all class members are initialized, use same order as headers.
- Header reordering.
- A few other small things.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32342 a95241bf-73f2-0310-859d-f6bbb57e9c96

fix a style violation


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28507 a95241bf-73f2-0310-859d-f6bbb57e9c96

* traverse the entry so that symlinks to files can be opened as well



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27957 a95241bf-73f2-0310-859d-f6bbb57e9c96

* cleanup



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27956 a95241bf-73f2-0310-859d-f6bbb57e9c96

patch by Andrea Anzani:
* fix a rounding problem when layouting the image
Thanks!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@23427 a95241bf-73f2-0310-859d-f6bbb57e9c96

Remove debugging printf.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@21393 a95241bf-73f2-0310-859d-f6bbb57e9c96

The zoom level needed to be reset to 1.0 after loading an image, otherwise it
would keep the zoom level of the previous image in some cases.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@21392 a95241bf-73f2-0310-859d-f6bbb57e9c96

Changed the progress monitor protocol to path a basic message that will be sent back
instead of having a fixed message code.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20746 a95241bf-73f2-0310-859d-f6bbb57e9c96

Implemented a progress window: it will be shown after one second in case the translator
supports it - currently, only the RAW image translator does this (as it needs about 10
seconds to open a 6 mio. pixel RAW image on a 2.6 GHz P4).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20650 a95241bf-73f2-0310-859d-f6bbb57e9c96

The size of the selection rectangle is now shown in the status bar. Useful for
cropping an image to a certain size or taking similar sized croppings from
various images (as I need to do.)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20012 a95241bf-73f2-0310-859d-f6bbb57e9c96

General changes:
- Fixed some formatting in the recently added resizing code.
- Changed the operation name for rotating counterclockwise to use that name
instead of anticlockwise. This makes the code consistent with the GUI.
- Reformatted the constants header to use an enum. Also removed the empty
constants cpp file.
- The QuitRequested handler in the app did not ask the windows to close, which
could cause modified images to be closed without prompting the user. Now it
does, which makes ShowImage more user friendly.

Changes to the image view:
- Added a member for keeping track of the type of image. This is mostly used in
properly updating the window's status bar when the image is changed (flipped,
rotated, etc.) This removes some hacky code I added before :)
- Removed the status parameter in the Notify method since it was only used for
the above image type status updating.
- Removed a redundant if in the mouse up handler.
- The key down handlers for moving to the next and previous image did not
properly prompt the user if the image had changed. I fixed this by sending a
message to the window where the prompting code resides. When adding this I
also created a few helper methods for sending messages to the window, which
removed some (small) repeated code through-out the class.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19994 a95241bf-73f2-0310-859d-f6bbb57e9c96

Removed "Stippled Zooming" item and made dithering automatic in 8-bit screen mode
"Keep Proportions" in resizing window became "Keep Original Proportions", which was suggested by korli and is the best suggestion IMO
Bilinear scaling is on by default
I like ShowImage's menus now. :^)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19877 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed selection handling bug if zoom level is not 1.0. Zoom factor has to be calculated in Setup() otherwise the selection rectangle uses the wrong zoom level.
Bug was introduced in revision 19253.
@Ryan: Can you please verify that this fix does not introduce another bug?


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19648 a95241bf-73f2-0310-859d-f6bbb57e9c96

Changed the delay on hiding the cursor in fullscreen to 2 seconds (much
better...not sure what I was thinking with 5 seconds before.) I also fixed a
few other issues related to this.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19578 a95241bf-73f2-0310-859d-f6bbb57e9c96

Implemented Stephan's previous TODO (in an svn commit message) to hide the
cursor after a delay when in fullscreen mode. I set the delay to 5 seconds. In
addition I make sure the ShowImage window is the active window before trying to
hide the cursor, because otherwise there is a lot of cursor flickering if you
change workspaces.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19569 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added support to ShowImage for sending an image to the Trash by scripting
Tracker. For now it only works when the delete key is pressed. I suppose a menu
item might be useful, but I can do that later if people really want it :)

When the image is trashed the next image in the directory is opened. If the
trashed image is the last in the directory the window is closed.

The code seems pretty solid as I even tested it with Tracker not running. It
also works fine in R5 (in fact that is where I tested it.)

As shown I would prefer to use the Tracker headers rather than redefining the
constant used for the trashing message. I'm already using Tracker's app MIME
type from the private headers.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19564 a95241bf-73f2-0310-859d-f6bbb57e9c96

Integrated "resize" feature from Zetas version of ShowImage, however used our bilinear scaler instead of Zetas implementation and made ResizerWindow font sensitive and removed the radio buttons with predefined sizes. Kudos to Bernd Korz for providing the ShowImage Zeta source code under MIT license.
Moved menu item "As Desktop Background" into "Image" menu from "View" menu.
Removed unused metod ShowImageWindow::Zoom(...).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19540 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added some needed stdio.h includes. I don't know what magic was used to compile
these for other people, but they wouldn't compile for me when building the
app_server test environment.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19479 a95241bf-73f2-0310-859d-f6bbb57e9c96

Several ShowImage changes:

- Changed the hotkey for the zoom to be = instead of + so that no shifting is necessary.
- Fixed the bitmap alignment code to solve some problems when zooming.
- Removed all references to alignment in the view since the image was already always centered. This greatly simplified the bitmap alignment.
- Removed the redundant fScaleX and fScaleY members of the view since they were always the same as fZoom.
- Removed all code related to having a border in the view.
- Fixed a bug where the type of file would disappear in the status area when zooming (this fix is a little hackish.)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19253 a95241bf-73f2-0310-859d-f6bbb57e9c96

More changes to ShowImage:

1. The newly renamed "Flip Sideways" and "Flip Upside Down" have been renamed again to "Flip Left To Right" and "Flip Top To Bottom". This was after some feedback indicating a preference for the new names.

2. When dragging a selection the standard outlined rectangle is used for the dragging image instead of the alpha-blended bitmap of the selected part of the image if the selection rectangle is larger than 400x400 (taking into account scaling of the image.) This mimics the original ShowImage with the exception of the minimum size. The choice of 400x400 was fairly arbitrary. I may see about turning that value into some kind of hidden option.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17229 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixes to ShowImage:

1. Renamed the Image menu items "Mirror Vertical" and "Mirror Horizontal" to "Flip Sideways" and "Flip Upside Down", respectively. This also involved changing the code to match the new names, for consistency.
2. Fixed a bug where zooming in and out would result in the image moving off center. This was due to the bitmap width and height not being recalculated after applying the zoom factor and therefore throwing off the calculations to find the rect for the center.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17182 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Mabye I should do better testing of what I "fix"; absolute paths didn't work
anymore from the command line all of a sudden...
* Made the caption background slightly less translucent to allow the text to
be read even with very checkered images.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16280 a95241bf-73f2-0310-859d-f6bbb57e9c96

Made the caption in full screen mode a bit easier to look at (boring yes, but some
people out there just aren't colour blind :-)).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16279 a95241bf-73f2-0310-859d-f6bbb57e9c96

* No longer hides the mouse cursor when the pop up menu is shown.
* Removed the superfluous "Cancel" item from the pop up menu.
* Cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16277 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed various issues:
* ArgvReceived() did not work with relative paths.
* Simplified quitting (no more CanQuit() and overriding BWindow::Quit()).
* Updated signature.
* Cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16260 a95241bf-73f2-0310-859d-f6bbb57e9c96

* quick fix for when fBitmap has been recomposed
partly, fDisplayBitmap is not correctly re-established...


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@15887 a95241bf-73f2-0310-859d-f6bbb57e9c96

* quick hack to hide the cursor in fullscreen
(TODO: do this after a time out)
* quick hack to display bitmaps containing an
alpha channel with a checker background
(TODO: rework filters to be alpha channel
aware and compose the checker background
independently of the filter)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@15886 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixes that make Haiku build with gcc 4. Mainly out of the following
categories:
* Missing includes (like <stdlib.h> and <string.h>).
* Linking against $(TARGET_LIBSTDC++) instead of libstdc++.r4.so.
* Local variables shadowing parameters.
* Default parameters in function definitions (as opposed to function
declarations).
* All C++ stuff (nothrow, map, set, vector, min, max,...) must be imported
explicitly from the std:: namespace now.
* "new (sometype)[...]" must read "new sometype[...]", even if sometype is
something like "const char *".
* __FUNCTION__ is no longer a string literal (but a string expression), i.e.
'printf(__FUNCTION__ ": ...\n")' is invalid code.
* A type cast results in a non-lvalue. E.g. "(char *)buffer += bytes"
is an invalid expression.
* "friend class SomeClass" only works when SomeClass is known before.
Otherwise the an inner class with that name is considered as friend.
gcc 4 is much pickier about scopes.
* gcc 4 is generally stricter with respect to type conversions in C.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@14878 a95241bf-73f2-0310-859d-f6bbb57e9c96

fixed alignment and image layout, esc exits fullscreen mode, black background for fullscreen, zooming window toggles fullscreen, can still browse even if current image has been deleted, space toggles slideshow, swapped next/previous menu items (more logical)

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@13101 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed page changing, simplified entry_ref usage in SetImage()


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@11366 a95241bf-73f2-0310-859d-f6bbb57e9c96

cosmetical improvements to status view, it also shows the image size now


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@9113 a95241bf-73f2-0310-859d-f6bbb57e9c96

Re-Added directory based Next/Previous file functionality. Now, if tracker scripting is unavailable, user will still be able to use Next/Previous file commands and the slideshow feature


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@8067 a95241bf-73f2-0310-859d-f6bbb57e9c96

Implemented rewind functionality so that slide show no longer stops when it reaches the last file in the directory


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@7453 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed to check if refs are directories and to error properly if they are


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6949 a95241bf-73f2-0310-859d-f6bbb57e9c96

Use Tracker Scripting to find next/previous image.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6203 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed file saving code so that it is only in one place, (instead of two) and fixed File-->Save As so that it now writes out the type attribute


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6127 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added feature where a file dropped from the Tracker becomes the current selection


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6121 a95241bf-73f2-0310-859d-f6bbb57e9c96

Bug fixed: ignore user zoom setting in automatic zoom modes.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@6000 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed bug in FindNextImage where -1 is returned instead of false


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5895 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed bug which occured when the Next or Previous image command was used with an image that failed to translate. Changed Next/Previous image behavior to skip past images that fail to translate.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5894 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed access to invalid bitmap bug.
Refactored code a little bit.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5746 a95241bf-73f2-0310-859d-f6bbb57e9c96

Removed some debug print statements, set the maximum allowed Zoom to 1600%


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5744 a95241bf-73f2-0310-859d-f6bbb57e9c96

Disable the Invert menu item for B_CMAP8 bitmaps because they are currently unsupported by the invert algorithm.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5721 a95241bf-73f2-0310-859d-f6bbb57e9c96

Cleared the Undo buffer when actions that are reversable are performed. Disabled Invert command for B_CMAP8 bitmaps, as they are not properly inverted


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5720 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed Edit-->Clear to leave behind a white box if the selection box is not moved after it is made, added Undo capability for Cut and Clear actions


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5719 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added initial implementation of Undo for OBOS ShowImage! Now, users can Undo/Redo merge/paste operations. Still need to enhance Undo further so that other operations can be undone, also need to account for image rotations and similar operations.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5693 a95241bf-73f2-0310-859d-f6bbb57e9c96

Changed Paste/DragDrop code so that a clip does not have to be pasted entirely within the bounds of the background bitmap


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5654 a95241bf-73f2-0310-859d-f6bbb57e9c96

Implemented drag/drop from one ShowImage window to another


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5653 a95241bf-73f2-0310-859d-f6bbb57e9c96

Removed unneeded calls to Invalidate(), changed minimum size for selection rectangle so that users can click in an empty section of the window to unselect the selection


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5641 a95241bf-73f2-0310-859d-f6bbb57e9c96

Removed Keydown handler code that invoked the creation/removal of the thumbnail icons


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5495 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added checking for modified document and prompt the user if they try to close a document without saving.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5492 a95241bf-73f2-0310-859d-f6bbb57e9c96

- Fixed bug in conversion from image coordinates to view coordinates are vice versa.
- Change the size of the image being dragged to size of the selection in the view coordinate system.
- Experimental: delay start of filtering thread(s) for some tenth of a second. This allows faster update during resizing.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5491 a95241bf-73f2-0310-859d-f6bbb57e9c96

Changed Cut behavior to match Be's version so that if the user Cuts a selection before moving it, the selection is cut, and a white rectangle is left in its place. If the selection is dragged before the Cut command is used, a white rectangle is not drawn.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5489 a95241bf-73f2-0310-859d-f6bbb57e9c96

- Implemented Floyd Steinberg dithering algorithm.
- Remembers "orientation" state (rotated, mirrored or inverted) in file attribute of image.
- Update recent documents menu every time the menu is opened.
- Bug fix and optimization in Filter.cpp.
- Moved image manipulation code from ShowImageView.cpp to Filter.cpp. So it can take advantage of multiple CPUs.
- Experimental: Write/remove thumbnail to/from file icons.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5480 a95241bf-73f2-0310-859d-f6bbb57e9c96

- Made some settings persistent: Slide Show Delay, Scale Bilinear, Shrink/Zoom to Window, Show Caption in Full Screen Mode and PrintOptions.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5441 a95241bf-73f2-0310-859d-f6bbb57e9c96

Rollback to original/way better constrated captions colors.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5437 a95241bf-73f2-0310-859d-f6bbb57e9c96

Ooops, forget to match caption rect size and position there too...


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5420 a95241bf-73f2-0310-859d-f6bbb57e9c96

Including Clipboard.h could help.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5419 a95241bf-73f2-0310-859d-f6bbb57e9c96

- Made some settings persistent: Slide Show Delay, Scale Bilinear, Shrink/Zoom to Window, Show Caption in Full Screen Mode and PrintOptions persistent.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5415 a95241bf-73f2-0310-859d-f6bbb57e9c96

Implemented Cut and Paste. Still need to implement Undo and check for a dirty document when the window or app is closed.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5414 a95241bf-73f2-0310-859d-f6bbb57e9c96

- Rewrote bilinear scaling algorithm. The version that uses fixed point calculations is at least two times faster than the version that uses floating point calculations!
- Fixed off by one bugs.
- Replace "Fit to Window" with "Shrink to Window" and "Zoom to Window".


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5409 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added code to merge selection with background image; removed Select None item, replaced it with Clear as Select None was behaving like Be ShowImage's Clear anyway; properly enabled/disabled Edit menu items when selection is made or cleared. Still no undo yet, but I'm planning to do that after Paste is implemented.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5403 a95241bf-73f2-0310-859d-f6bbb57e9c96

Changed fpBitmap to the more Be-ish notation of fBitmap, added code to allow the user to drag the bitmap selection around like in Be's ShowImage. However, no changes can be made yet to the underlying image. Need to resolve resize flickering of selected image and allow the user to modify the underlying image.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5392 a95241bf-73f2-0310-859d-f6bbb57e9c96

Drag selection code can now move the selection inside the view, fixed selection drag code so that unwanted MouseUps don't affect the selection box movement. Though, drag selection code is not done yet, it is not yet copying the bitmap from where the selection was dragged from, it is just moving the selection rectangle. Dragging a selection to outside of the window still works the same.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5391 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed caption hiding method so that whenever any kind of scrolling is done, the caption is hidden in full screen mode. Previously, the caption would only hide during click-and-drag scrolling and using other scrolling would cause the caption to be painted in various places on top of the image.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5384 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added comments to MouseWheelChanged function which explains how B_MOUSE_WHEEL_CHANGED behaves.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5376 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed issue where view scrolls to the left when mouse wheel is used, changed to scroll faster if the wheel is scrolled multiple clicks per B_MOUSE_WHEEL_CHANGED message, increased the scroll speed


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5375 a95241bf-73f2-0310-859d-f6bbb57e9c96

Bug fixed: virtual function must not be called in destructor.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5352 a95241bf-73f2-0310-859d-f6bbb57e9c96

Bug fixes.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5350 a95241bf-73f2-0310-859d-f6bbb57e9c96

- scale bilinear (experimental: scaled image is too small by one pixel)
- bug fixes


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5347 a95241bf-73f2-0310-859d-f6bbb57e9c96

- Scrolling with mouse wheel
- Moving image with third mouse button pressed
- Added pop up menu with contents of View menu of menu bar
- Center image in full screen mode
- Added Select None menu item
- To avoid flickering, disabled caption during moving image with mouse- Added key bindings:
- Cursor keys: moves image
- Enter or space bar: next file
- Backspace: previous file
- Escape: Stops slide show
- SHIFT + first mouse button: simulate third mouse button
- CONTROL + first mouse button: simulates second mouse button


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5322 a95241bf-73f2-0310-859d-f6bbb57e9c96

- added printing support
- added zoom in and out
- next/previous file sorts directory entries by itself; does not rely on file system
- added shortcuts to the first 10 menu items of Go To sub menu


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5299 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added Go To Page submenu so the user can directly go to the page that they want. Also fixed a typo.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5290 a95241bf-73f2-0310-859d-f6bbb57e9c96

- renamed and restructured menu bar
- show dialog box when image can not be opened
- added optional caption in full screen mode
- moved/removed code from ShowImageApp to ShowImageView


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5289 a95241bf-73f2-0310-859d-f6bbb57e9c96

- added recent documents sub menu
- added resize window to image size when file is opened
- added drag and drop selection
- added copy selection to clipboard


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5288 a95241bf-73f2-0310-859d-f6bbb57e9c96

- added full screen mode
- added dia show
- added rotate image clockwise, anti-clockwise, mirror image vertical or -horiztonal and invert image
- added myself to about dialog and copyright holders


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5270 a95241bf-73f2-0310-859d-f6bbb57e9c96

- added option resize image to window size
- added show next/previous file using Command + Cursor Up/Down key
- rewrote selection code
- added marching ants
- renamed member variables to start with capital letter after field prefix


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5255 a95241bf-73f2-0310-859d-f6bbb57e9c96

Changed selection box to use a checkered pattern, closer to what Be's ShowImage uses. Stopped using inversion to clear old selections, drawing the bitmap over them instead. Fixed the rect used in setting the view bitmap.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5090 a95241bf-73f2-0310-859d-f6bbb57e9c96

Implemented preliminary selection box skeleton code. Need to add marching ants and connect selection box status to Edit menu.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@5083 a95241bf-73f2-0310-859d-f6bbb57e9c96

removed (page x of y) from status text, (page info should come from the identify string of translators that support multiple pages) added a border around the image (like Be's ShowImage has), added disabling of Page menu for single page images


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4218 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added multi-page support (as in OBOS TIFFTranslator). Made many changes to the way the app, window and view objects interface with each other. Still could use some polish.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4216 a95241bf-73f2-0310-859d-f6bbb57e9c96

Change to have a more consistent coding style, eliminated unused / unessecary code, added MIT license notice, prevented image window from closing when a save panel is open, prevented the user from opening multiple save panels for a single image window, etc.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4214 a95241bf-73f2-0310-859d-f6bbb57e9c96

Removed selection box code


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4210 a95241bf-73f2-0310-859d-f6bbb57e9c96

Changed Save AS sub menu to only show the available destination types for bitmap images, implemented Save As feature


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@4181 a95241bf-73f2-0310-859d-f6bbb57e9c96

Initial Checkin. Coded by Fernando Francisco de Oliveira.


git-svn-id: file:///srv/svn/repos/haiku/trunk/current@388 a95241bf-73f2-0310-859d-f6bbb57e9c96