Screenshot: fixed alpha channel handling.

* Screenshot always used B_RGBA32 color space, but did not care about the
alpha channel at all. Now it only uses that space when "includeBorder"
is used.
* Utility::_MakeTabSpaceTransparent() now also makes sure that the rest
of the bitmap has the correct alpha channel set. This fixes bug #10491.
* Minor cleanup.

Strings owned by local stack objects can't be returned.

The BString is destroyed when the function returns and takes the
storage pointed to by BString::String() with it, so returning such a
pointer is bogus. Instead the return type is now a BString which takes
over ownership of the string.

Screenshot application enhancements:
- Remove the options panel, and the "-o, --options" switch, put all options
inside the main panel as discussed in ticket #3831.
- Add a "Copy to clipboard" button, as discussed in ticket #3831.
- Add a "-c, --clipboard" switch to quickly copy a screenshot to the clipboard
without launching the GUI.
- All settings apply directly to the current schreenshot as well as new
Screenshots, as discussed in ticket #4100.
- Separate executables for the CLI (Screenshot) and GUI (ScreenshotApp).
When "Screenshot" is launched it runs in the background, and launches the
GUI (if not run with the -s or -c switch) before quiting itself. When a new
screenshot is requested through the ScreenshotApp GUI interface,
ScreenshotApp launches Screenshot before quiting itself, after which
Screenshot re-launches ScreenshotApp. This fixes ticket #4100.
Note that because of this change the deskbar entry will show "ScreenshotApp"
and not "Screenshot" as might be expected. I am not sure if this is a
problem.
- Fixed the code that determines the active window because it was just finding
the top most window. This change fixes tickets #3112, #4878, and #4423.
- Hide the cursor by calling BApplication::HideCursor().
This fixes ticket #2988 (but *not* #2997).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37017 a95241bf-73f2-0310-859d-f6bbb57e9c96

Screenshot: fixed alpha channel handling.

* Screenshot always used B_RGBA32 color space, but did not care about the
alpha channel at all. Now it only uses that space when "includeBorder"
is used.
* Utility::_MakeTabSpaceTransparent() now also makes sure that the rest
of the bitmap has the correct alpha channel set. This fixes bug #10491.
* Minor cleanup.

Strings owned by local stack objects can't be returned.

The BString is destroyed when the function returns and takes the
storage pointed to by BString::String() with it, so returning such a
pointer is bogus. Instead the return type is now a BString which takes
over ownership of the string.

Screenshot application enhancements:
- Remove the options panel, and the "-o, --options" switch, put all options
inside the main panel as discussed in ticket #3831.
- Add a "Copy to clipboard" button, as discussed in ticket #3831.
- Add a "-c, --clipboard" switch to quickly copy a screenshot to the clipboard
without launching the GUI.
- All settings apply directly to the current schreenshot as well as new
Screenshots, as discussed in ticket #4100.
- Separate executables for the CLI (Screenshot) and GUI (ScreenshotApp).
When "Screenshot" is launched it runs in the background, and launches the
GUI (if not run with the -s or -c switch) before quiting itself. When a new
screenshot is requested through the ScreenshotApp GUI interface,
ScreenshotApp launches Screenshot before quiting itself, after which
Screenshot re-launches ScreenshotApp. This fixes ticket #4100.
Note that because of this change the deskbar entry will show "ScreenshotApp"
and not "Screenshot" as might be expected. I am not sure if this is a
problem.
- Fixed the code that determines the active window because it was just finding
the top most window. This change fixes tickets #3112, #4878, and #4423.
- Hide the cursor by calling BApplication::HideCursor().
This fixes ticket #2988 (but *not* #2997).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37017 a95241bf-73f2-0310-859d-f6bbb57e9c96