processcontroller: Fix -Wformat-security

Change-Id: I50aaf5e92aefaaea4e616e535c22196cfb69a879
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3327
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>

ProcessController: Fix memory leak.

ProcessController: Relicense as MIT.

We received permission from the original author and all relevant contributors
(see the mailing list) to do this. (As best as can be established, BeUnited
did not modify the source code after importing besides adding their copyright.)

Revert "ProcessController: solve BMessage kind of memory leak."

This reverts the ProcessController portion of commit edcc37c64af67db04d4bacc7cd3d7b93423e95a9.

Barrett refused to relicense his contribution to ProcessController.

ProcessController and VolumeControl: solve BMessage kind of memory leak.

Signed-off-by: Adrien Destugues <pulkomandy@gmail.com>

64-bit fixes for ProcessController.

Close alerts with ESCAPE key.

Added SetFlags(B_CLOSE_ON_ESCAPE) or SetShortcut(index, B_ESCAPE) to BAlerts
depending if the result gets used later in the code, or if it's a one-button
BAlert.

More catalog-related cleanup.

* rename B_TRANSLATE_CONTEXT to B_TRANSLATION_CONTEXT and
B_TRANSLATE_WITH_CONTEXT to B_TRANSLATE_CONTEXT, squashing a TODO
* adjust all uses of both macros in Haiku's source tree
* use correct header guard for collecting/Catalog.h

The renamed macros require adjustments to all external applications
using catalogs.

Filtered flat import of Oliver's svn package management branch

Bring the changes that aren't package management related and the ones
that are but don't take effect as long as they are ignored by the build
system into the master.

Summary of changes:
* Introduce private header <directories.h> with constants for a good
deal of paths that should usually be retrieved via find_directory().
* Replace hard-coded paths by using find_directory() or the
<directories.h> constants (e.g. in drivers and the kernel).
* Add find_directory() constants needed for package management.
* Add __HAIKU_ABI_NAME and B_HAIKU_ABI_NAME macros.
* src/apps/deskbar: BeMenu.* -> DeskbarMenu.*,
DeskBarUtils.* -> DeskbarUtils.*
* Change deskbar menu settings directory from ~/config/be to
~/config/settings/deskbar.
* Other smaller cleanups, changes, and fixes.

Flat commit of all changes from package-management branch in svn

Partially applying localization patch prepared by Jorma Karvonen.
Fixes #7350. Thanks.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40909 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed exessive internationalization: the names of the:
- thread;
- preferences file;
- preferences file parameters;
should not be translated. Pointed by Diver. Thanx!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40270 a95241bf-73f2-0310-859d-f6bbb57e9c96

Corrected copy-and-paste error. Fixes #7029.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39941 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by Mike Roll: i18n ProcessController


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39938 a95241bf-73f2-0310-859d-f6bbb57e9c96

Changed wording of installation alert again.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39727 a95241bf-73f2-0310-859d-f6bbb57e9c96

Changed wording of installation alert.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39725 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Removed the version check, and the Deskbar restart code.
* This closes ticket #2314.
* Minor cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33862 a95241bf-73f2-0310-859d-f6bbb57e9c96

Some application MIME signature fixing.

We really should come up with a way to avoid the duplication between the rdef
and source code...


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32505 a95241bf-73f2-0310-859d-f6bbb57e9c96

Spell fix, thanks Stefano for correcting me.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@31567 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Last check in had an error when you tried to install ProcessController twice.
* Had to change some names so that I didn't use the name tmp or temp :)

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@31566 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixes #2314.
* Check if ProcessController are already installed in deskbar, If so don't try to install again.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@31526 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Changed directory structure as suggested on the mailing list.
* Made the TimeZoneView less error prone, and also actually use Haiku code (the
previous check didn't work since it used #if, not #ifdef).
* Also took the liberty to rename our boot loader to haiku_loader, since I had
to update the nasm binary anyway. Updated the assembly sources to nasm 2.0.
* I haven't found where the synth location in the MIDI code is specified,
though.
* Also, NetBootArchive, and FloppyBootImage haven't been updated yet. Will do
so next.
* Some optional packages still put their license to beos/etc/licenses. I didn't
update them yet, as we'll probably do so anyway at some point. Also, I think
we might want to introduce a common/data/licenses instead for those.
* If you encounter any problems, please tell!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29876 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by Vasilis Kaoutsis:
* Style cleanup.
* Renamed class GebsPreferences to Preferences.
* Made NoiseBarMenuItem::fBusyWaiting/fLost private and added getters
and setters.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@23498 a95241bf-73f2-0310-859d-f6bbb57e9c96

More (minor) GCC 4 fixes.....



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18153 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Moved "install to Deskbar" alert into the application.
* If you install ProcessController to the Deskbar after startup, its window
is not opened anymore.
* When you install ProcessController, the Deskbar is only restarted if needed;
this can probably be removed completely under Haiku.
* Renamed some menu items.
* Removed "Use Pulse's settings" menu item.
* Fixed remaining issues from bug #633 as far as ProcessController was concerned.
* Removed unused source files.
* Big cleanup, even though there could be done much much more.
* Compacted the source files a bit, merged PCView.cpp and PCView2.cpp to
ProcessController.cpp to match the name of the class.
* Renamed PCUtils.{cpp|h} to Utilities.{cpp|h}


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17647 a95241bf-73f2-0310-859d-f6bbb57e9c96

Some changes to make it better fit into a Haiku distribution:
* Fixed Terminal signature to Haiku's Terminal.
* Removed documentation menu item.
* Minor cleanups.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17589 a95241bf-73f2-0310-859d-f6bbb57e9c96

Imported ProcessController from BeUnited's CVS into our repository.
Doesn't compile yet.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17568 a95241bf-73f2-0310-859d-f6bbb57e9c96

ProcessController and VolumeControl: solve BMessage kind of memory leak.

Signed-off-by: Adrien Destugues <pulkomandy@gmail.com>

64-bit fixes for ProcessController.

Close alerts with ESCAPE key.

Added SetFlags(B_CLOSE_ON_ESCAPE) or SetShortcut(index, B_ESCAPE) to BAlerts
depending if the result gets used later in the code, or if it's a one-button
BAlert.

More catalog-related cleanup.

* rename B_TRANSLATE_CONTEXT to B_TRANSLATION_CONTEXT and
B_TRANSLATE_WITH_CONTEXT to B_TRANSLATE_CONTEXT, squashing a TODO
* adjust all uses of both macros in Haiku's source tree
* use correct header guard for collecting/Catalog.h

The renamed macros require adjustments to all external applications
using catalogs.

Filtered flat import of Oliver's svn package management branch

Bring the changes that aren't package management related and the ones
that are but don't take effect as long as they are ignored by the build
system into the master.

Summary of changes:
* Introduce private header <directories.h> with constants for a good
deal of paths that should usually be retrieved via find_directory().
* Replace hard-coded paths by using find_directory() or the
<directories.h> constants (e.g. in drivers and the kernel).
* Add find_directory() constants needed for package management.
* Add __HAIKU_ABI_NAME and B_HAIKU_ABI_NAME macros.
* src/apps/deskbar: BeMenu.* -> DeskbarMenu.*,
DeskBarUtils.* -> DeskbarUtils.*
* Change deskbar menu settings directory from ~/config/be to
~/config/settings/deskbar.
* Other smaller cleanups, changes, and fixes.

Flat commit of all changes from package-management branch in svn

Partially applying localization patch prepared by Jorma Karvonen.
Fixes #7350. Thanks.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40909 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed exessive internationalization: the names of the:
- thread;
- preferences file;
- preferences file parameters;
should not be translated. Pointed by Diver. Thanx!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40270 a95241bf-73f2-0310-859d-f6bbb57e9c96

Corrected copy-and-paste error. Fixes #7029.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39941 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by Mike Roll: i18n ProcessController


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39938 a95241bf-73f2-0310-859d-f6bbb57e9c96

Changed wording of installation alert again.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39727 a95241bf-73f2-0310-859d-f6bbb57e9c96

Changed wording of installation alert.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39725 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Removed the version check, and the Deskbar restart code.
* This closes ticket #2314.
* Minor cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33862 a95241bf-73f2-0310-859d-f6bbb57e9c96

Some application MIME signature fixing.

We really should come up with a way to avoid the duplication between the rdef
and source code...


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32505 a95241bf-73f2-0310-859d-f6bbb57e9c96

Spell fix, thanks Stefano for correcting me.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@31567 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Last check in had an error when you tried to install ProcessController twice.
* Had to change some names so that I didn't use the name tmp or temp :)

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@31566 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixes #2314.
* Check if ProcessController are already installed in deskbar, If so don't try to install again.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@31526 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Changed directory structure as suggested on the mailing list.
* Made the TimeZoneView less error prone, and also actually use Haiku code (the
previous check didn't work since it used #if, not #ifdef).
* Also took the liberty to rename our boot loader to haiku_loader, since I had
to update the nasm binary anyway. Updated the assembly sources to nasm 2.0.
* I haven't found where the synth location in the MIDI code is specified,
though.
* Also, NetBootArchive, and FloppyBootImage haven't been updated yet. Will do
so next.
* Some optional packages still put their license to beos/etc/licenses. I didn't
update them yet, as we'll probably do so anyway at some point. Also, I think
we might want to introduce a common/data/licenses instead for those.
* If you encounter any problems, please tell!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29876 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by Vasilis Kaoutsis:
* Style cleanup.
* Renamed class GebsPreferences to Preferences.
* Made NoiseBarMenuItem::fBusyWaiting/fLost private and added getters
and setters.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@23498 a95241bf-73f2-0310-859d-f6bbb57e9c96

More (minor) GCC 4 fixes.....



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18153 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Moved "install to Deskbar" alert into the application.
* If you install ProcessController to the Deskbar after startup, its window
is not opened anymore.
* When you install ProcessController, the Deskbar is only restarted if needed;
this can probably be removed completely under Haiku.
* Renamed some menu items.
* Removed "Use Pulse's settings" menu item.
* Fixed remaining issues from bug #633 as far as ProcessController was concerned.
* Removed unused source files.
* Big cleanup, even though there could be done much much more.
* Compacted the source files a bit, merged PCView.cpp and PCView2.cpp to
ProcessController.cpp to match the name of the class.
* Renamed PCUtils.{cpp|h} to Utilities.{cpp|h}


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17647 a95241bf-73f2-0310-859d-f6bbb57e9c96

Some changes to make it better fit into a Haiku distribution:
* Fixed Terminal signature to Haiku's Terminal.
* Removed documentation menu item.
* Minor cleanups.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17589 a95241bf-73f2-0310-859d-f6bbb57e9c96

Imported ProcessController from BeUnited's CVS into our repository.
Doesn't compile yet.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17568 a95241bf-73f2-0310-859d-f6bbb57e9c96