processcontroller: Fix memory leak

When getting icon is failed, get_team_name_and_icon()
does not return false, so bitmap allocated to
infoPack.team_icon can be leaked.

* Delete bitmap in get_team_name_and_icon(), not in caller.
* Return false when getiing icon is failed.

Change-Id: Ib65065b59b70cd839e6deda4e1142bd104072d84
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3744
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>

ProcessController: Relicense as MIT.

We received permission from the original author and all relevant contributors
(see the mailing list) to do this. (As best as can be established, BeUnited
did not modify the source code after importing besides adding their copyright.)

kernel, libroot: Introduce new API for obtaining system info

ProcessController: Fix memory calculations.

On systems with > 4GB of memory, the calculations would overflow,
leading to the memory bars being drawn incorrectly.

Fix end of range check to not read beyond the allocation.

The counter j is equal to fTeamCount if no matching team was found in
the team array. Therefore using it as an index into the team array was
invalid.

Partially applying localization patch prepared by Jorma Karvonen.
Fixes #7350. Thanks.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40909 a95241bf-73f2-0310-859d-f6bbb57e9c96

Use string_for_size() to format and localize sizes in a consistent way.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40780 a95241bf-73f2-0310-859d-f6bbb57e9c96

- Localization of the global popup menu name is removed as invidible to the end-user;
- In consistency with other applications, following units were replaced: MB -> MiB, KB -> KiB;
Pointed out by Jean-Loic Charroud. Thanks.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40777 a95241bf-73f2-0310-859d-f6bbb57e9c96

Localized some still missed strings pointed out by Diver. Thanks!
Use more safe snprintf calls instead of sprintf ones.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40746 a95241bf-73f2-0310-859d-f6bbb57e9c96

Modify ProcessController's System Resources and Caches item: it
now shows cache and total committed mem respectively.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@24801 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by Vasilis Kaoutsis:
* Style cleanup.
* Renamed class GebsPreferences to Preferences.
* Made NoiseBarMenuItem::fBusyWaiting/fLost private and added getters
and setters.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@23498 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Moved "install to Deskbar" alert into the application.
* If you install ProcessController to the Deskbar after startup, its window
is not opened anymore.
* When you install ProcessController, the Deskbar is only restarted if needed;
this can probably be removed completely under Haiku.
* Renamed some menu items.
* Removed "Use Pulse's settings" menu item.
* Fixed remaining issues from bug #633 as far as ProcessController was concerned.
* Removed unused source files.
* Big cleanup, even though there could be done much much more.
* Compacted the source files a bit, merged PCView.cpp and PCView2.cpp to
ProcessController.cpp to match the name of the class.
* Renamed PCUtils.{cpp|h} to Utilities.{cpp|h}


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17647 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Made memory menu font sensitive (fixes part of bug #633).
* Some cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17638 a95241bf-73f2-0310-859d-f6bbb57e9c96

Imported ProcessController from BeUnited's CVS into our repository.
Doesn't compile yet.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17568 a95241bf-73f2-0310-859d-f6bbb57e9c96

kernel, libroot: Introduce new API for obtaining system info

ProcessController: Fix memory calculations.

On systems with > 4GB of memory, the calculations would overflow,
leading to the memory bars being drawn incorrectly.

Fix end of range check to not read beyond the allocation.

The counter j is equal to fTeamCount if no matching team was found in
the team array. Therefore using it as an index into the team array was
invalid.

Partially applying localization patch prepared by Jorma Karvonen.
Fixes #7350. Thanks.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40909 a95241bf-73f2-0310-859d-f6bbb57e9c96

Use string_for_size() to format and localize sizes in a consistent way.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40780 a95241bf-73f2-0310-859d-f6bbb57e9c96

- Localization of the global popup menu name is removed as invidible to the end-user;
- In consistency with other applications, following units were replaced: MB -> MiB, KB -> KiB;
Pointed out by Jean-Loic Charroud. Thanks.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40777 a95241bf-73f2-0310-859d-f6bbb57e9c96

Localized some still missed strings pointed out by Diver. Thanks!
Use more safe snprintf calls instead of sprintf ones.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40746 a95241bf-73f2-0310-859d-f6bbb57e9c96

Modify ProcessController's System Resources and Caches item: it
now shows cache and total committed mem respectively.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@24801 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by Vasilis Kaoutsis:
* Style cleanup.
* Renamed class GebsPreferences to Preferences.
* Made NoiseBarMenuItem::fBusyWaiting/fLost private and added getters
and setters.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@23498 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Moved "install to Deskbar" alert into the application.
* If you install ProcessController to the Deskbar after startup, its window
is not opened anymore.
* When you install ProcessController, the Deskbar is only restarted if needed;
this can probably be removed completely under Haiku.
* Renamed some menu items.
* Removed "Use Pulse's settings" menu item.
* Fixed remaining issues from bug #633 as far as ProcessController was concerned.
* Removed unused source files.
* Big cleanup, even though there could be done much much more.
* Compacted the source files a bit, merged PCView.cpp and PCView2.cpp to
ProcessController.cpp to match the name of the class.
* Renamed PCUtils.{cpp|h} to Utilities.{cpp|h}


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17647 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Made memory menu font sensitive (fixes part of bug #633).
* Some cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17638 a95241bf-73f2-0310-859d-f6bbb57e9c96

Imported ProcessController from BeUnited's CVS into our repository.
Doesn't compile yet.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17568 a95241bf-73f2-0310-859d-f6bbb57e9c96