History log of /haiku/src/apps/people/PersonWindow.cpp
Revision Date Author Comments
# 964b6e80 30-Oct-2023 Humdinger <humdinger@mailbox.org>

People: Accept initial values

Besides the entry_ref to an existing Person file as argv, also
accept a BMessage containing values for attributes and set those
in the new window.

The specifier name in the BMessage needs to be the same as the
attribute name used by the People app, e.g. "META:email".

Needed to let the Mail app create a new Person file with the email
address already filled in.

Fixes #14766

Change-Id: I637200b08d5c1b7cf52d7cf3f56dab93ce1a6ec5
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7085
Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>


# 5c040b73 23-Oct-2023 Augustin Cavalier <waddlesplash@gmail.com>

People: Fix buffer overflow in string handling.

Also move some variable declarations closer to their usages.

Fixes #18618.


# b5a859ad 24-Jul-2021 Adrien Destugues <adrien.destugues@opensource.viveris.fr>

People: make default size larger

We have increased the number of default attributes, so the initial size
wasn't enough.

On small resolution displays, adjust the size to not end up with part
of the window outside the screen.

Fixes #15371

Change-Id: Ie59cb3a3f6609eff7d933d0bf0e11f66637d6d10
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2222
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>


# f290b766 20-Apr-2017 Augustin Cavalier <waddlesplash@gmail.com>

People: Enclose PeopleView in a BScrollView.

People uses a customizeable set of attributes, and on my install
that has a lot of old BeOS applications, the window is too tall
for the screen. So now it will be possible to scroll it.

Depends on the prior change to BScrollView to auto-update
scrollbar limits when the window size changes, as otherwise
you will not be able to scroll properly.

As you can see by the date, I've had this patch sitting around
for almost 2 years now, waiting for BScrollView layouted behavior
to be fixed...

Change-Id: Iee7a691771d3b17efb2f6aba8c5011986ad0e36b
Reviewed-on: https://review.haiku-os.org/c/894
Reviewed-by: waddlesplash <waddlesplash@gmail.com>


# d63ed584 15-Jan-2017 Adrien Destugues <pulkomandy@pulkomandy.tk>

People: revert window spacing changes

Revert changes from d0ac609964842f8cdb6d54b3c539c6c15293e172

The People window include a dark grey stripe, which must be next to the
window border with no spacing. The spacing was properly done inside the
main view.

Thanks to Diver for noticing the issue.


# 3c5208e4 07-Nov-2015 Humdinger <humdingerb@gmail.com>

Improve/fix layout

Some tweaks to the layout of apps/prefs in the course of using
B_USE_WINDOW_SPACING.


# d0ac6099 07-Nov-2015 Humdinger <humdingerb@gmail.com>

Use B_USE_WINDOW_SPACING

Use B_USE_WINDOW_SPACING as inset from contents to window border.
Some whitespace cleanup.


# 991dadd6 16-Jun-2014 Humdinger <humdingerb@gmail.com>

Make sure there's a space in front of B_UTF8_ELLIPSIS.

As PulkoMandy said in hrev47388: C++11 safe and reads better.


# 776c58b2 30-Dec-2012 Humdinger <humdingerb@gmail.com>

Unifying the quit/save alerts.

Wherever I found an alert prompting to save changes, I used the
button labeling 'Cancel', 'Don't save', 'Save' with the first button
left aligned, 2nd and 3rd right aligned.

I added the shortcuts 'd' for 'Don't save, and 's' for 'Save' where
not already set.

The topic was discussed at
http://permalink.gmane.org/gmane.os.haiku.devel/23244
The discussion died down, I hope I made changes everyone can live with.


# aed35104 05-Aug-2012 Humdinger <humdingerb@gmail.com>

Close alerts with ESCAPE key.

Added SetFlags(B_CLOSE_ON_ESCAPE) or SetShortcut(index, B_ESCAPE) to BAlerts
depending if the result gets used later in the code, or if it's a one-button
BAlert.


# 546208a5 16-Apr-2012 Oliver Tappe <zooey@hirschkaefer.de>

More catalog-related cleanup.

* rename B_TRANSLATE_CONTEXT to B_TRANSLATION_CONTEXT and
B_TRANSLATE_WITH_CONTEXT to B_TRANSLATE_CONTEXT, squashing a TODO
* adjust all uses of both macros in Haiku's source tree
* use correct header guard for collecting/Catalog.h

The renamed macros require adjustments to all external applications
using catalogs.


# 805cd0be 08-Apr-2011 Jonas Sundström <jonas@kirilla.com>

Make cut/copy/paste/undo work.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41205 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 589d9759 25-Feb-2011 Philippe Houdoin <philippe.houdoin@gmail.com>

Since _SetToRet() check previous value of fRef, an sane initial value must be
set at construction.
Closes #7264.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40683 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 433dc783 24-Feb-2011 Philippe Houdoin <philippe.houdoin@gmail.com>

As spotted by Stephan, pulled out items enabling/disabling of the if block,
as menu items must be updated even when the focus is not a text view!
Thanks.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40670 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 2f768089 24-Feb-2011 Philippe Houdoin <philippe.houdoin@gmail.com>

Soon the current focused could be something else than a BTextView...


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40662 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 84627497 23-Feb-2011 Philippe Houdoin <philippe.houdoin@gmail.com>

Add a new feature to People app: a picture can now be stored in Person file,
besides attributes.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40647 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 6df07298 12-Feb-2011 Stephan Aßmus <superstippi@gmx.de>

Added "Configure attributes" item to Edit menu (?). This feature invokes
FileTypes with the Person MIME type selected.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40473 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 968ec77e 12-Feb-2011 Stephan Aßmus <superstippi@gmx.de>

Renamed PeopleWindow/View to PersonWindow/View, since they only show one person at a time.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40462 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 991dadd6324f7b7a68e94743a39ebae789823228 16-Jun-2014 Humdinger <humdingerb@gmail.com>

Make sure there's a space in front of B_UTF8_ELLIPSIS.

As PulkoMandy said in hrev47388: C++11 safe and reads better.


# 776c58b2b56d8bcf33638a2ecb6c697f95a1cbf3 30-Dec-2012 Humdinger <humdingerb@gmail.com>

Unifying the quit/save alerts.

Wherever I found an alert prompting to save changes, I used the
button labeling 'Cancel', 'Don't save', 'Save' with the first button
left aligned, 2nd and 3rd right aligned.

I added the shortcuts 'd' for 'Don't save, and 's' for 'Save' where
not already set.

The topic was discussed at
http://permalink.gmane.org/gmane.os.haiku.devel/23244
The discussion died down, I hope I made changes everyone can live with.


# aed35104852941f0f6f3d1dcc5338b5f337d0a3c 05-Aug-2012 Humdinger <humdingerb@gmail.com>

Close alerts with ESCAPE key.

Added SetFlags(B_CLOSE_ON_ESCAPE) or SetShortcut(index, B_ESCAPE) to BAlerts
depending if the result gets used later in the code, or if it's a one-button
BAlert.


# 546208a53940a26c6379c48a7854ade1a8250fc5 16-Apr-2012 Oliver Tappe <zooey@hirschkaefer.de>

More catalog-related cleanup.

* rename B_TRANSLATE_CONTEXT to B_TRANSLATION_CONTEXT and
B_TRANSLATE_WITH_CONTEXT to B_TRANSLATE_CONTEXT, squashing a TODO
* adjust all uses of both macros in Haiku's source tree
* use correct header guard for collecting/Catalog.h

The renamed macros require adjustments to all external applications
using catalogs.


# 805cd0be8c456c8c19aea06a1b12bcd93eada2f2 08-Apr-2011 Jonas Sundström <jonas@kirilla.com>

Make cut/copy/paste/undo work.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41205 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 589d9759a45fe78d4aec4f997c72985ef8d8393d 25-Feb-2011 Philippe Houdoin <philippe.houdoin@gmail.com>

Since _SetToRet() check previous value of fRef, an sane initial value must be
set at construction.
Closes #7264.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40683 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 433dc7837964c038bcf344794c12de279bdd5263 24-Feb-2011 Philippe Houdoin <philippe.houdoin@gmail.com>

As spotted by Stephan, pulled out items enabling/disabling of the if block,
as menu items must be updated even when the focus is not a text view!
Thanks.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40670 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 2f76808976e7fde2567f6524c45e04fa6a70a805 24-Feb-2011 Philippe Houdoin <philippe.houdoin@gmail.com>

Soon the current focused could be something else than a BTextView...


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40662 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 84627497fb50f0217c24d3c8af4b68f5566b4e6d 23-Feb-2011 Philippe Houdoin <philippe.houdoin@gmail.com>

Add a new feature to People app: a picture can now be stored in Person file,
besides attributes.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40647 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 6df0729855318b8c5b87d10feb32781c5562227e 12-Feb-2011 Stephan Aßmus <superstippi@gmx.de>

Added "Configure attributes" item to Edit menu (?). This feature invokes
FileTypes with the Person MIME type selected.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40473 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 968ec77e1f783265bc393eae565c5166c5a13bd8 12-Feb-2011 Stephan Aßmus <superstippi@gmx.de>

Renamed PeopleWindow/View to PersonWindow/View, since they only show one person at a time.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40462 a95241bf-73f2-0310-859d-f6bbb57e9c96