packageinstaller: Fix -Wformat-security

Change-Id: I9792b89ed0b59d509f20c43170f806a6168cbf81
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3347
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>

Small spelling fixes. Reported by mazbrili through Pootle. Thanks!

apps: Convert to using Set*UIColor.

Signed-off-by: Augustin Cavalier <waddlesplash@gmail.com>
Patches 0045-0075, 0077-0087 from looncraz, unmodified.

PackageInstaller: use string_for_size instead of a custom function.

Fix various typos and inconsistencies in strings

DiskProbe, DriveSetup, Icon-O-Matic, Installer, Login,
PackageInstaller, Screenshot, Translation Inspector, BootManager,
CharacterMap, CodyCam, BPrintJob

DiskUsage: removed useless translation, used only for layouting purposes

Thanks to KapiX for spotting these problems.

PackageInstaller: Unbreak selecting custom install folders.

BFilePanel always sends B_CANCEL when it hides (as documented in the BeBook),
not just when the user cancels the file panel. Track what message we expect
and only react to B_CANCEL when it means the user really canceled selecting
the target folder.

PackageInstaller: Increase install type description height

* In case the scroll bar needs to appear, it had not enough room.

PackageInstaller: Implement John's suggestions
* Rename "Install" button to "Begin" so it matches most packages instructions
at least for the English locale.
* Restore right-alignment of the menu field labels.
* Also move the "Begin" button onto its own line to allow more of the target
folder to be readable on the menu field.

packageinstaller: style fixes

PackageInstaller: More robust way to select destination...
... after file panel is cancelled.

PackageInstaller: Handle aborting the file panel

* Select the first item and reset the path.

PackageInstaller: Improved main window layout

* Moved "Install to:" besides the "Install" button again.
* Don't right-align menu field labels.
* Give the install type description some default text when no description is
given. Give it a smaller font, align with the type menu.

PackageInstaller: Install apps to non-packaged "apps" folder.

Previously, the target folder was always unset, which meant one needed
to select a target folder manually. When running from a read-only media,
this would still be a problem (a TODO), so that instead of failing to install
the package, the user is simply prompted for a path.
The change means that together with rewriting old paths to packaged
locations to the non-packaged equivalents, just double clicking a PKG and
hitting "Install" will now work. Tested with Moho installer and
Gobe Productive.

PackageInstaller: Converted to use layout API

* Also auto-hide vertical scroll-bars when not needed.
* Nicer margins everywhere
* TODO: Install type description could collapse when empty or display
a default message.
* More refactoring and cleanup

PackageView: Small coding-style cleanup

PackageView: Refactored a lot of repetitive code...

... to create menu items.

PackageInstaller: Make window title properly localizeable

PackageInstaller: Another round of cleanup.

Close alerts with ESCAPE key.

Added SetFlags(B_CLOSE_ON_ESCAPE) or SetShortcut(index, B_ESCAPE) to BAlerts
depending if the result gets used later in the code, or if it's a one-button
BAlert.

More catalog-related cleanup.

* rename B_TRANSLATE_CONTEXT to B_TRANSLATION_CONTEXT and
B_TRANSLATE_WITH_CONTEXT to B_TRANSLATE_CONTEXT, squashing a TODO
* adjust all uses of both macros in Haiku's source tree
* use correct header guard for collecting/Catalog.h

The renamed macros require adjustments to all external applications
using catalogs.

Added missing localization macros.+alpha

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41941 a95241bf-73f2-0310-859d-f6bbb57e9c96

prof was dereferenced before checking for NULL. CID 1065


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38113 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch a confusing bug which showed "Replace all" as a choice after choosing to skip files which already exist


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37982 a95241bf-73f2-0310-859d-f6bbb57e9c96

Updated TR_CONTEXT to be B_TRANSLATE_CONTEXT, relating to #5408.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36733 a95241bf-73f2-0310-859d-f6bbb57e9c96

Updated to use B_TRANSLATE* macros. relates to #5408.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36676 a95241bf-73f2-0310-859d-f6bbb57e9c96

Remembered the rule wrong about how many blank lines between copyright and
headers.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36619 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by Jorma Karvonen: Localization of the PackageInstaller. Thanks a lot!
Contains small coding style corrections by myself. Closes ticket #5907.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36618 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by sil2100:
* Avoid showing read-only volumes as possible installation targets.
* Mark the menu item for the first suitable volume that was found.
* Removed no more needed debug output.

Fixes #5231. Thanks a lot!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36596 a95241bf-73f2-0310-859d-f6bbb57e9c96

Applied patch by sil2100 that enables handling of script files (bug #3762)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36020 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by Humdinger:
Updated Haiku apps to use sentence-case. What a huge undertaking...
The files where I had to apply the patch manually (for mysterious
reasons) have also gotten a whitespace cleanup. I've proof-read
everything so hopefully there should be no problems.

This should be the final part of #5169.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35049 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Applied patch by sil2100 that basically adds a "Yes to all" button, see
ticket #4059. I fixed a few style violations, though. Thanks!
* Automatic whitespace cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32161 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Applied patch by sil2001 that fixes bug #3666 (handling of existing symlinks).
* Refactored PkgItem classes, and pulled out a PackageItem base class. Renamed
other classes to Package*.
* The ItemExists() method should really get a "Apply this choice to all files"
kind of option...
* Style cleanups.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30125 a95241bf-73f2-0310-859d-f6bbb57e9c96

Changed the error message for unreadable packages to be a passive one, as suggested by Stephan.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29162 a95241bf-73f2-0310-859d-f6bbb57e9c96

* exits on invalid packages
* added messages on errors


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29159 a95241bf-73f2-0310-859d-f6bbb57e9c96

Applied patch by Duane R. Bailey:
* Replaced occurances of "..." by B_UTF8_ELLIPSIS in the apps folder.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@24851 a95241bf-73f2-0310-859d-f6bbb57e9c96

style cleanup


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@23501 a95241bf-73f2-0310-859d-f6bbb57e9c96

Adding Łukasz Zemczak's package installer to our tree. This was his Google
Summer of Code project. Thanks for your work Łukasz and I hope we can see
more work from you.

Still to do:
- Create an icon.
- Add pkg files to the MIME database with PackageInstaller as the default
handler. The rdef here has the MIME type name for the pkg format should
anyone else choose to add it :)
- Support for running scripts included with packages.
- Testing various different packages.
- Fixing problems in the Haiku GUI layout system which affect the code used
for various parts of the installer GUI (please bear with the commented out
code for now.)
- Adding this to the image.

Tomorrow I will add Łukasz's InstalledPackages utility which can be used to
view installed packages and uninstall them.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@22525 a95241bf-73f2-0310-859d-f6bbb57e9c96

PackageInstaller: use string_for_size instead of a custom function.

Fix various typos and inconsistencies in strings

DiskProbe, DriveSetup, Icon-O-Matic, Installer, Login,
PackageInstaller, Screenshot, Translation Inspector, BootManager,
CharacterMap, CodyCam, BPrintJob

DiskUsage: removed useless translation, used only for layouting purposes

Thanks to KapiX for spotting these problems.

PackageInstaller: Unbreak selecting custom install folders.

BFilePanel always sends B_CANCEL when it hides (as documented in the BeBook),
not just when the user cancels the file panel. Track what message we expect
and only react to B_CANCEL when it means the user really canceled selecting
the target folder.

PackageInstaller: Increase install type description height

* In case the scroll bar needs to appear, it had not enough room.

PackageInstaller: Implement John's suggestions
* Rename "Install" button to "Begin" so it matches most packages instructions
at least for the English locale.
* Restore right-alignment of the menu field labels.
* Also move the "Begin" button onto its own line to allow more of the target
folder to be readable on the menu field.

packageinstaller: style fixes

PackageInstaller: More robust way to select destination...
... after file panel is cancelled.

PackageInstaller: Handle aborting the file panel

* Select the first item and reset the path.

PackageInstaller: Improved main window layout

* Moved "Install to:" besides the "Install" button again.
* Don't right-align menu field labels.
* Give the install type description some default text when no description is
given. Give it a smaller font, align with the type menu.

PackageInstaller: Install apps to non-packaged "apps" folder.

Previously, the target folder was always unset, which meant one needed
to select a target folder manually. When running from a read-only media,
this would still be a problem (a TODO), so that instead of failing to install
the package, the user is simply prompted for a path.
The change means that together with rewriting old paths to packaged
locations to the non-packaged equivalents, just double clicking a PKG and
hitting "Install" will now work. Tested with Moho installer and
Gobe Productive.

PackageInstaller: Converted to use layout API

* Also auto-hide vertical scroll-bars when not needed.
* Nicer margins everywhere
* TODO: Install type description could collapse when empty or display
a default message.
* More refactoring and cleanup

PackageView: Small coding-style cleanup

PackageView: Refactored a lot of repetitive code...

... to create menu items.

PackageInstaller: Make window title properly localizeable

PackageInstaller: Another round of cleanup.

Close alerts with ESCAPE key.

Added SetFlags(B_CLOSE_ON_ESCAPE) or SetShortcut(index, B_ESCAPE) to BAlerts
depending if the result gets used later in the code, or if it's a one-button
BAlert.

More catalog-related cleanup.

* rename B_TRANSLATE_CONTEXT to B_TRANSLATION_CONTEXT and
B_TRANSLATE_WITH_CONTEXT to B_TRANSLATE_CONTEXT, squashing a TODO
* adjust all uses of both macros in Haiku's source tree
* use correct header guard for collecting/Catalog.h

The renamed macros require adjustments to all external applications
using catalogs.

Added missing localization macros.+alpha

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41941 a95241bf-73f2-0310-859d-f6bbb57e9c96

prof was dereferenced before checking for NULL. CID 1065


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38113 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch a confusing bug which showed "Replace all" as a choice after choosing to skip files which already exist


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37982 a95241bf-73f2-0310-859d-f6bbb57e9c96

Updated TR_CONTEXT to be B_TRANSLATE_CONTEXT, relating to #5408.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36733 a95241bf-73f2-0310-859d-f6bbb57e9c96

Updated to use B_TRANSLATE* macros. relates to #5408.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36676 a95241bf-73f2-0310-859d-f6bbb57e9c96

Remembered the rule wrong about how many blank lines between copyright and
headers.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36619 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by Jorma Karvonen: Localization of the PackageInstaller. Thanks a lot!
Contains small coding style corrections by myself. Closes ticket #5907.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36618 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by sil2100:
* Avoid showing read-only volumes as possible installation targets.
* Mark the menu item for the first suitable volume that was found.
* Removed no more needed debug output.

Fixes #5231. Thanks a lot!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36596 a95241bf-73f2-0310-859d-f6bbb57e9c96

Applied patch by sil2100 that enables handling of script files (bug #3762)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36020 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by Humdinger:
Updated Haiku apps to use sentence-case. What a huge undertaking...
The files where I had to apply the patch manually (for mysterious
reasons) have also gotten a whitespace cleanup. I've proof-read
everything so hopefully there should be no problems.

This should be the final part of #5169.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35049 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Applied patch by sil2100 that basically adds a "Yes to all" button, see
ticket #4059. I fixed a few style violations, though. Thanks!
* Automatic whitespace cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32161 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Applied patch by sil2001 that fixes bug #3666 (handling of existing symlinks).
* Refactored PkgItem classes, and pulled out a PackageItem base class. Renamed
other classes to Package*.
* The ItemExists() method should really get a "Apply this choice to all files"
kind of option...
* Style cleanups.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30125 a95241bf-73f2-0310-859d-f6bbb57e9c96

Changed the error message for unreadable packages to be a passive one, as suggested by Stephan.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29162 a95241bf-73f2-0310-859d-f6bbb57e9c96

* exits on invalid packages
* added messages on errors


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29159 a95241bf-73f2-0310-859d-f6bbb57e9c96

Applied patch by Duane R. Bailey:
* Replaced occurances of "..." by B_UTF8_ELLIPSIS in the apps folder.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@24851 a95241bf-73f2-0310-859d-f6bbb57e9c96

style cleanup


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@23501 a95241bf-73f2-0310-859d-f6bbb57e9c96

Adding Łukasz Zemczak's package installer to our tree. This was his Google
Summer of Code project. Thanks for your work Łukasz and I hope we can see
more work from you.

Still to do:
- Create an icon.
- Add pkg files to the MIME database with PackageInstaller as the default
handler. The rdef here has the MIME type name for the pkg format should
anyone else choose to add it :)
- Support for running scripts included with packages.
- Testing various different packages.
- Fixing problems in the Haiku GUI layout system which affect the code used
for various parts of the installer GUI (please bear with the commented out
code for now.)
- Adding this to the image.

Tomorrow I will add Łukasz's InstalledPackages utility which can be used to
view installed packages and uninstall them.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@22525 a95241bf-73f2-0310-859d-f6bbb57e9c96