Revert "LegacyPackageInstaller: Override fPathType when the path begins with /boot/."

This reverts commit 8cf0752f1bde487b7b78c6f375d22181023e32c2.
This reverts commit af3057423c2951d7a1652cf7383b2fafe12872b6.

This change fixed one package, and broke everything else. Please find a
proper fix and actually test it before committing.

Fixes #12909

LegacyPackageInstaller: Correct previous commit.

The test in the previous commit had a totally flawed invocation of strcmp().
I probably shouldn't attempt to write C code without consulting the manual.

Even if it had worked, it would have worked on too many cases, including
some volume paths. So I reordered the if statement and added it in there.

LegacyPackageInstaller: Override fPathType when the path begins with /boot/.

Fixes installation of the RefLine pkg. I don't know why, but it seems to
specify the path as a P_INSTALL_PATH.

PackageInstaller: Fix the build.

Previously, <stdlib.h> wasn't included (which is where environ is),
but Axel changed some Be API headers and now it is indirectly included,
which broke the build.

Fixes #12263.

PackageInstaller: when zlib fails, print the error message.

PackageInstaller: rewrite /boot/beos/system to /boot/system

Fixes #10603.

PackageInstaller: Added -v/--verbose option

It enables just a few printf()s in PackageItem.cpp.
I went with a quick solution using a global variable
instead of using/writing some nice logging framework which
could even generate install logs... but it helps in tracking
down some package problems without first having to uncomment
some printf()s...

PackageInstaller: Fix Paladin installation

... and perhaps more packages build for pre-PM Haiku.
* Restore the original path rewriting of "/boot/system"
alongside rewriting "/boot/beos/system".
* Rewrite "/boot/apps" in install scripts. This one fits
the existing TODO that the rewriting should not use
hard-coded replacement paths.
* Fixes ticket #10875

PackageInstaller: Fix rewriting paths to system

In BeOS, there was no /boot/system, there as /boot/beos/system. If memory
serves. Fixes install location of GoBe Translators.

PackageInstaller: Fixed more problems with working directories

I've encountered three different ways of specifying the working directory
for install scripts: Relative to target folder, relative to install folder
and absolute. At least those three now work...

PackageInstaller: Disable debug output of scripts

Install scripts can define a NULL path...

... don't try to call InitPath() then.
Also replace more hard-coded paths. Added TODO about refactoring this
code and not using hard-coded paths myself, which is no better than these
scripts.

PackageInstaller: Run install scripts in the correct directory

* From debugging with the Gobe and Moho installer, scripts define which
folder to run them from. The PackageInstaller is supposed to run the script
in that working directory. The parser seems to have the correct folder in
"installPath" when adding the script as PackageItem, but that code is rather
horrible. I've changed it so PackageScript items also set the path, use
InitPath() to obtain the final working directory and set it before running
the script.
* Both Moho and Gobe create the Deskbar link from that script, the folder
is rewritten in the script via ReplaceAll().
* Correctly running the script makes a bug visible: Dynamically added files
in the install location by these scripts are not removed when uninstalling
the package. When re-installing a package, it is first uninstalled and this
currently gives an error for both Moho and Gobe, since they create some
links in these scripts which never worked before. To install again, the
install folder needs to be deleted manually.
* Some cleanup along the way... sorry.

PackageItem: Fixed rewriting item paths

* The version of BString::Replace() that was used takes the offset at which
replacing should start, not the number of replacements. So did this ever
work? Use ReplaceFirst() instead.
* Address the performance issues which Pawel commented on, plus some more.
* I've left some debug output in the code (commented out), since I want to
work on this some more. For example, I noticed that GoBe Productive puts
files into /boot/beos/...

PackageInstaller: Dynamically replace /boot/system with the system non-packaged dir, same with ~/config

PackageItem::ParseAttribute(), use delete[] for deleing *attrData.

Signed-off-by: Oliver Tappe <zooey@hirschkaefer.de>

More catalog-related cleanup.

* rename B_TRANSLATE_CONTEXT to B_TRANSLATION_CONTEXT and
B_TRANSLATE_WITH_CONTEXT to B_TRANSLATE_CONTEXT, squashing a TODO
* adjust all uses of both macros in Haiku's source tree
* use correct header guard for collecting/Catalog.h

The renamed macros require adjustments to all external applications
using catalogs.

fixed warnings with debug enabled


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38287 a95241bf-73f2-0310-859d-f6bbb57e9c96

CID 1460,1461,1462: delete[] must be used to delete arrays.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38052 a95241bf-73f2-0310-859d-f6bbb57e9c96

Updated TR_CONTEXT to be B_TRANSLATE_CONTEXT, relating to #5408.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36733 a95241bf-73f2-0310-859d-f6bbb57e9c96

Remembered the rule wrong about how many blank lines between copyright and
headers.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36619 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by Jorma Karvonen: Localization of the PackageInstaller. Thanks a lot!
Contains small coding style corrections by myself. Closes ticket #5907.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36618 a95241bf-73f2-0310-859d-f6bbb57e9c96

Applied patch by sil2100 that enables handling of script files (bug #3762)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36020 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Applied patch by sil2100 that basically adds a "Yes to all" button, see
ticket #4059. I fixed a few style violations, though. Thanks!
* Automatic whitespace cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32161 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Applied patch by sil2001 that fixes bug #3666 (handling of existing symlinks).
* Refactored PkgItem classes, and pulled out a PackageItem base class. Renamed
other classes to Package*.
* The ItemExists() method should really get a "Apply this choice to all files"
kind of option...
* Style cleanups.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30125 a95241bf-73f2-0310-859d-f6bbb57e9c96

* fixed symlink creation and symlink attributes
* more debug output


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29562 a95241bf-73f2-0310-859d-f6bbb57e9c96

* added debug output
* don't create the directory with the link name, only the parent


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29549 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Break parsing loop if PkgA is encountered. This helps with QEmu pkg.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29216 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed every (hopefully) CID cases of delete where delete[] should have been used. CID 122, 123, 124, 125, 126, 127, 128, 129, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 142, 143, 144, 147, 148, 149, 150

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27703 a95241bf-73f2-0310-859d-f6bbb57e9c96

Adding Łukasz Zemczak's package installer to our tree. This was his Google
Summer of Code project. Thanks for your work Łukasz and I hope we can see
more work from you.

Still to do:
- Create an icon.
- Add pkg files to the MIME database with PackageInstaller as the default
handler. The rdef here has the MIME type name for the pkg format should
anyone else choose to add it :)
- Support for running scripts included with packages.
- Testing various different packages.
- Fixing problems in the Haiku GUI layout system which affect the code used
for various parts of the installer GUI (please bear with the commented out
code for now.)
- Adding this to the image.

Tomorrow I will add Łukasz's InstalledPackages utility which can be used to
view installed packages and uninstall them.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@22525 a95241bf-73f2-0310-859d-f6bbb57e9c96

PackageInstaller: Fix the build.

Previously, <stdlib.h> wasn't included (which is where environ is),
but Axel changed some Be API headers and now it is indirectly included,
which broke the build.

Fixes #12263.

PackageInstaller: when zlib fails, print the error message.

PackageInstaller: rewrite /boot/beos/system to /boot/system

Fixes #10603.

PackageInstaller: Added -v/--verbose option

It enables just a few printf()s in PackageItem.cpp.
I went with a quick solution using a global variable
instead of using/writing some nice logging framework which
could even generate install logs... but it helps in tracking
down some package problems without first having to uncomment
some printf()s...

PackageInstaller: Fix Paladin installation

... and perhaps more packages build for pre-PM Haiku.
* Restore the original path rewriting of "/boot/system"
alongside rewriting "/boot/beos/system".
* Rewrite "/boot/apps" in install scripts. This one fits
the existing TODO that the rewriting should not use
hard-coded replacement paths.
* Fixes ticket #10875

PackageInstaller: Fix rewriting paths to system

In BeOS, there was no /boot/system, there as /boot/beos/system. If memory
serves. Fixes install location of GoBe Translators.

PackageInstaller: Fixed more problems with working directories

I've encountered three different ways of specifying the working directory
for install scripts: Relative to target folder, relative to install folder
and absolute. At least those three now work...

PackageInstaller: Disable debug output of scripts

Install scripts can define a NULL path...

... don't try to call InitPath() then.
Also replace more hard-coded paths. Added TODO about refactoring this
code and not using hard-coded paths myself, which is no better than these
scripts.

PackageInstaller: Run install scripts in the correct directory

* From debugging with the Gobe and Moho installer, scripts define which
folder to run them from. The PackageInstaller is supposed to run the script
in that working directory. The parser seems to have the correct folder in
"installPath" when adding the script as PackageItem, but that code is rather
horrible. I've changed it so PackageScript items also set the path, use
InitPath() to obtain the final working directory and set it before running
the script.
* Both Moho and Gobe create the Deskbar link from that script, the folder
is rewritten in the script via ReplaceAll().
* Correctly running the script makes a bug visible: Dynamically added files
in the install location by these scripts are not removed when uninstalling
the package. When re-installing a package, it is first uninstalled and this
currently gives an error for both Moho and Gobe, since they create some
links in these scripts which never worked before. To install again, the
install folder needs to be deleted manually.
* Some cleanup along the way... sorry.

PackageItem: Fixed rewriting item paths

* The version of BString::Replace() that was used takes the offset at which
replacing should start, not the number of replacements. So did this ever
work? Use ReplaceFirst() instead.
* Address the performance issues which Pawel commented on, plus some more.
* I've left some debug output in the code (commented out), since I want to
work on this some more. For example, I noticed that GoBe Productive puts
files into /boot/beos/...

PackageInstaller: Dynamically replace /boot/system with the system non-packaged dir, same with ~/config

PackageItem::ParseAttribute(), use delete[] for deleing *attrData.

Signed-off-by: Oliver Tappe <zooey@hirschkaefer.de>

More catalog-related cleanup.

* rename B_TRANSLATE_CONTEXT to B_TRANSLATION_CONTEXT and
B_TRANSLATE_WITH_CONTEXT to B_TRANSLATE_CONTEXT, squashing a TODO
* adjust all uses of both macros in Haiku's source tree
* use correct header guard for collecting/Catalog.h

The renamed macros require adjustments to all external applications
using catalogs.

fixed warnings with debug enabled


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38287 a95241bf-73f2-0310-859d-f6bbb57e9c96

CID 1460,1461,1462: delete[] must be used to delete arrays.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38052 a95241bf-73f2-0310-859d-f6bbb57e9c96

Updated TR_CONTEXT to be B_TRANSLATE_CONTEXT, relating to #5408.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36733 a95241bf-73f2-0310-859d-f6bbb57e9c96

Remembered the rule wrong about how many blank lines between copyright and
headers.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36619 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by Jorma Karvonen: Localization of the PackageInstaller. Thanks a lot!
Contains small coding style corrections by myself. Closes ticket #5907.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36618 a95241bf-73f2-0310-859d-f6bbb57e9c96

Applied patch by sil2100 that enables handling of script files (bug #3762)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36020 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Applied patch by sil2100 that basically adds a "Yes to all" button, see
ticket #4059. I fixed a few style violations, though. Thanks!
* Automatic whitespace cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32161 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Applied patch by sil2001 that fixes bug #3666 (handling of existing symlinks).
* Refactored PkgItem classes, and pulled out a PackageItem base class. Renamed
other classes to Package*.
* The ItemExists() method should really get a "Apply this choice to all files"
kind of option...
* Style cleanups.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30125 a95241bf-73f2-0310-859d-f6bbb57e9c96

* fixed symlink creation and symlink attributes
* more debug output


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29562 a95241bf-73f2-0310-859d-f6bbb57e9c96

* added debug output
* don't create the directory with the link name, only the parent


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29549 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Break parsing loop if PkgA is encountered. This helps with QEmu pkg.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29216 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed every (hopefully) CID cases of delete where delete[] should have been used. CID 122, 123, 124, 125, 126, 127, 128, 129, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 142, 143, 144, 147, 148, 149, 150

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27703 a95241bf-73f2-0310-859d-f6bbb57e9c96

Adding Łukasz Zemczak's package installer to our tree. This was his Google
Summer of Code project. Thanks for your work Łukasz and I hope we can see
more work from you.

Still to do:
- Create an icon.
- Add pkg files to the MIME database with PackageInstaller as the default
handler. The rdef here has the MIME type name for the pkg format should
anyone else choose to add it :)
- Support for running scripts included with packages.
- Testing various different packages.
- Fixing problems in the Haiku GUI layout system which affect the code used
for various parts of the installer GUI (please bear with the commented out
code for now.)
- Adding this to the image.

Tomorrow I will add Łukasz's InstalledPackages utility which can be used to
view installed packages and uninstall them.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@22525 a95241bf-73f2-0310-859d-f6bbb57e9c96