mail: partial style cleanup

No functional changes

Change-Id: I8f2b18da4955ee48cba87359050fbe3fc8cdb9ea
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3830
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>

src/apps: style fixes

* add break statement to the last clause of switch/cases
* fix some other minor issues

Change-Id: I9ac3dac0cda0b14043b975938caea88b79bb749f
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1299
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>

src/apps Code formatting

* No functional changes

code formatting changes only

Change-Id: I046ae21d9b288126022fe0bc2ddf827843765e70
Reviewed-on: https://review.haiku-os.org/c/896
Reviewed-by: Stephan Aßmus <superstippi@gmx.de>

Mail: sizing/placing cleanup.

* Don't set a default fixed font size - just use the default fixed font.
* The preferences and signature window no longer have a default size,
and position, either. Instead, they are placed over the active window.
* Fixed spacing in the preferences window.
* Converted the signature window to use the layout API.
* Minor cleanup.

Mail: work in progress to use the layout API.

Mail: Use BToolBar and vector icons.

Fixes #9519. Partially using the patch there, but most of this
is my own work.

Create MAIL:flags index in Mail. This should fix #8506.

More catalog-related cleanup.

* rename B_TRANSLATE_CONTEXT to B_TRANSLATION_CONTEXT and
B_TRANSLATE_WITH_CONTEXT to B_TRANSLATE_CONTEXT, squashing a TODO
* adjust all uses of both macros in Haiku's source tree
* use correct header guard for collecting/Catalog.h

The renamed macros require adjustments to all external applications
using catalogs.

Placement of user splell_check directories fixed

* User collected dictionaries and indexes are moved under
~/config/data/spell_check/ folder. Fixes #7887.
* This fix was made during completing GCI 2011 task.

Signed-off-by: Siarzhuk Zharski <zharik@gmx.li>

Fixed typo in the comment of the default mail charset string.

Spotted by RQ and mentioned on #8147. Thanks!

Textencoding Kit localization support added.

* Textencoding Kit now uses localized names of available encodings;
* Default encoding for composing new messages in Mail application is now
configurable through localization feature. Fixes #8147.
* This contribution was made as part of GCI 2011 task.

Signed-off-by: Siarzhuk Zharski <zharik@gmx.li>

Fixed a minor typo in the help text.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42481 a95241bf-73f2-0310-859d-f6bbb57e9c96

Unburying the bug of ticket #6721.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41163 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fix for #7372. Don't use an uninitialized buffer. Some BString replacement of C strings. Replace Mail's ReadAttrString() function with the BNode method. Define a B_MAIL_ATTR_BCC.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41159 a95241bf-73f2-0310-859d-f6bbb57e9c96

Workaround for ticket #6721 by using %b (line break) instead of \n for newline. (I looked into the string escaping issue in the locale kit and it appears to work as expected, so I don't know.) Simplification of some code. Addition of a default reply preamble. The name variable now results in just the name. Removal of commented out First/Last name variables, as the order of these is culture-dependent. Insert at point of selection.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41158 a95241bf-73f2-0310-859d-f6bbb57e9c96

Follow-up on r41108. Removal of About-windows and menu items.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41115 a95241bf-73f2-0310-859d-f6bbb57e9c96

Use resource definition files instead of DoCatalogs rule. Rename B_TRANSLATE_APP_NAME and related macros to the more generic B_TRANSLATE_SYSTEM_NAME, to also fits add-ons, folders, etc, and make 'System name' its standard context. Change CodyCam and PoorMan's app signatures to match the overall x-vnd.Haiku-App pattern. Some clean-up. Make SlideShowSaver build again.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41103 a95241bf-73f2-0310-859d-f6bbb57e9c96

Making use of B_TRANSLATE_APP_NAME, BAboutMenuItem, BAboutWindow. Clean-up. Removal of some ellipsis. ('About Haiku' in Deskbar.)

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40968 a95241bf-73f2-0310-859d-f6bbb57e9c96

- Partial downloaded messages are now opened by Mail and not by the mail daemon. Mail request the body fetch and get notified when the daemon is done. During this time the Mail window title is showing "Downloading: subject". This fixes #7256.
- Some cleanup in Mail.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40789 a95241bf-73f2-0310-859d-f6bbb57e9c96

Switch to the new MailProtocol and account API. Lot of other smaller adaption to the new mail server.

Remove button in the pref app removes the complete account because we don't have separate chains any more. The pref app stays a mess, needs some layout love! (I did it even look worse...)

The new account/mail settings classes know if they have been changed but the current pref panel does not use this feature very well. It always mark the settings as modified when the settings view is displayed or more precise when the settings view is detached from the pref window, this could be optimized. The according mail protocol is completely restarted when their settings changed.

Some system filters are now directly integrated in the mail protocols. Hopefully make things easier to understand.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40398 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by diver: Localize the default Mail window title. Closes ticket #6447.
Thanks.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38631 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Update all applications in tree to use the new localizing system
* Remove the old one from the locale librairy, with some cleanup
Known regressions :
* readonlybootprompt will no longer update the locale settings : the
method used messed with internal undocumented things
* external localized apps (webpositive for example) will not run
anymore.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37336 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fix localization of mail so that the title is put in big font no matter the language.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37308 a95241bf-73f2-0310-859d-f6bbb57e9c96

Updated TR_CONTEXT to be B_TRANSLATE_CONTEXT, relating to #5408.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36733 a95241bf-73f2-0310-859d-f6bbb57e9c96

Updated to use B_TRANSLATE* macros. relates to #5408.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36668 a95241bf-73f2-0310-859d-f6bbb57e9c96

Sentence-cased GUI strings, adapted from patch by Humdinger in #5169.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34973 a95241bf-73f2-0310-859d-f6bbb57e9c96

Localization to replace the hardcoded English/Japanese. I will follow up with a Japanese translation based on the previous code. Some of the old solution lingers in parts of the code. A small amount of clean-up and removal BeOS-specifics.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34956 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Enlarged the cascading offset a bit, so that you can still read the title.
* Cascading should really be solved in a shared source, so that all apps behave
in the same way (I don't consider Mail's cascading to be how it should be
either, btw).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34269 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Made the cascading work a bit nicer and more consistent.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34268 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Moved spell check files to /system/data/spell_check.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33988 a95241bf-73f2-0310-859d-f6bbb57e9c96

* When using localtime_r(), you might have to call tzset() yourself (the exact
behaviour is not specified in POSIX). This fixes Mail sometimes not having
the correct timezone.
* Since it's not specified, we might want to do that always on libroot init?
We could introduce a syscall that keeps the already parsed data, if there
isn't already to make this cheap.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33608 a95241bf-73f2-0310-859d-f6bbb57e9c96

Hopefully this are all remaining read erros.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30651 a95241bf-73f2-0310-859d-f6bbb57e9c96

Add another option to the mail app. When you switch "Automaticly mark mail as readed" off a new Read / Unread button appears and a mail is only marked as readed when you push this button. On default the old behaviour is used.

This is once again a opera feature I like very much and I haven't found in any other email client yet.
E.g. you can start a query on unreaded mails and take a short look at the mails without the mails are disappearing from the query. If you read the mail you press "Readed" and the mail is gone from the query. This is e.g an advantage if you have less time, take a look at a mail and found that the mail is very long but potentially intressting. In this case you just press next or close the window and the mail is still in the unreaded query, ready to be readed at another time. The unreaded flag becomes something like a automatic important flag. You don't have to mark / unmark the mails as important and still don't forget to process any mail. I think this is a different way how most people read mails so I hope you like the patch.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30437 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Changed the window cascading to be more useful with more windows.
* Minor cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26113 a95241bf-73f2-0310-859d-f6bbb57e9c96

The "Show Header" option is no longer persistent, and will only affect the
currently shown mail when checked.
It just didn't make any sense the way it was before, and was inconsistent, too,
as it only affected mails opened after the current one.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26112 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added an Accounts menu item which opens the E-mail preferences.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@24021 a95241bf-73f2-0310-859d-f6bbb57e9c96

* fixed Mail startup, it would not open a window because of an uninitialized
variable (#1459)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@22200 a95241bf-73f2-0310-859d-f6bbb57e9c96

first part of a big cleanup of the Mail code
* separated window, app and context menu code
* got rid of all the global variables (which were accessed completely without
locking, and the code with regards to the preference window sill needs
fixing)
* extracted some defines and helper functions to MailSupport.cpp, though I later
saw Utilities.cpp...
* got rid of the FONT_SIZE define which was used in some (but not all) controls
to override the system font size
* worked in Header.cpp to get the controls layout font sensitive with correct
alignment too, some problems remain when resizing the window


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@22122 a95241bf-73f2-0310-859d-f6bbb57e9c96

Mail: work in progress to use the layout API.

Mail: Use BToolBar and vector icons.

Fixes #9519. Partially using the patch there, but most of this
is my own work.

Create MAIL:flags index in Mail. This should fix #8506.

More catalog-related cleanup.

* rename B_TRANSLATE_CONTEXT to B_TRANSLATION_CONTEXT and
B_TRANSLATE_WITH_CONTEXT to B_TRANSLATE_CONTEXT, squashing a TODO
* adjust all uses of both macros in Haiku's source tree
* use correct header guard for collecting/Catalog.h

The renamed macros require adjustments to all external applications
using catalogs.

Placement of user splell_check directories fixed

* User collected dictionaries and indexes are moved under
~/config/data/spell_check/ folder. Fixes #7887.
* This fix was made during completing GCI 2011 task.

Signed-off-by: Siarzhuk Zharski <zharik@gmx.li>

Fixed typo in the comment of the default mail charset string.

Spotted by RQ and mentioned on #8147. Thanks!

Textencoding Kit localization support added.

* Textencoding Kit now uses localized names of available encodings;
* Default encoding for composing new messages in Mail application is now
configurable through localization feature. Fixes #8147.
* This contribution was made as part of GCI 2011 task.

Signed-off-by: Siarzhuk Zharski <zharik@gmx.li>

Fixed a minor typo in the help text.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42481 a95241bf-73f2-0310-859d-f6bbb57e9c96

Unburying the bug of ticket #6721.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41163 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fix for #7372. Don't use an uninitialized buffer. Some BString replacement of C strings. Replace Mail's ReadAttrString() function with the BNode method. Define a B_MAIL_ATTR_BCC.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41159 a95241bf-73f2-0310-859d-f6bbb57e9c96

Workaround for ticket #6721 by using %b (line break) instead of \n for newline. (I looked into the string escaping issue in the locale kit and it appears to work as expected, so I don't know.) Simplification of some code. Addition of a default reply preamble. The name variable now results in just the name. Removal of commented out First/Last name variables, as the order of these is culture-dependent. Insert at point of selection.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41158 a95241bf-73f2-0310-859d-f6bbb57e9c96

Follow-up on r41108. Removal of About-windows and menu items.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41115 a95241bf-73f2-0310-859d-f6bbb57e9c96

Use resource definition files instead of DoCatalogs rule. Rename B_TRANSLATE_APP_NAME and related macros to the more generic B_TRANSLATE_SYSTEM_NAME, to also fits add-ons, folders, etc, and make 'System name' its standard context. Change CodyCam and PoorMan's app signatures to match the overall x-vnd.Haiku-App pattern. Some clean-up. Make SlideShowSaver build again.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41103 a95241bf-73f2-0310-859d-f6bbb57e9c96

Making use of B_TRANSLATE_APP_NAME, BAboutMenuItem, BAboutWindow. Clean-up. Removal of some ellipsis. ('About Haiku' in Deskbar.)

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40968 a95241bf-73f2-0310-859d-f6bbb57e9c96

- Partial downloaded messages are now opened by Mail and not by the mail daemon. Mail request the body fetch and get notified when the daemon is done. During this time the Mail window title is showing "Downloading: subject". This fixes #7256.
- Some cleanup in Mail.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40789 a95241bf-73f2-0310-859d-f6bbb57e9c96

Switch to the new MailProtocol and account API. Lot of other smaller adaption to the new mail server.

Remove button in the pref app removes the complete account because we don't have separate chains any more. The pref app stays a mess, needs some layout love! (I did it even look worse...)

The new account/mail settings classes know if they have been changed but the current pref panel does not use this feature very well. It always mark the settings as modified when the settings view is displayed or more precise when the settings view is detached from the pref window, this could be optimized. The according mail protocol is completely restarted when their settings changed.

Some system filters are now directly integrated in the mail protocols. Hopefully make things easier to understand.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40398 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by diver: Localize the default Mail window title. Closes ticket #6447.
Thanks.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38631 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Update all applications in tree to use the new localizing system
* Remove the old one from the locale librairy, with some cleanup
Known regressions :
* readonlybootprompt will no longer update the locale settings : the
method used messed with internal undocumented things
* external localized apps (webpositive for example) will not run
anymore.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37336 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fix localization of mail so that the title is put in big font no matter the language.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37308 a95241bf-73f2-0310-859d-f6bbb57e9c96

Updated TR_CONTEXT to be B_TRANSLATE_CONTEXT, relating to #5408.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36733 a95241bf-73f2-0310-859d-f6bbb57e9c96

Updated to use B_TRANSLATE* macros. relates to #5408.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36668 a95241bf-73f2-0310-859d-f6bbb57e9c96

Sentence-cased GUI strings, adapted from patch by Humdinger in #5169.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34973 a95241bf-73f2-0310-859d-f6bbb57e9c96

Localization to replace the hardcoded English/Japanese. I will follow up with a Japanese translation based on the previous code. Some of the old solution lingers in parts of the code. A small amount of clean-up and removal BeOS-specifics.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34956 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Enlarged the cascading offset a bit, so that you can still read the title.
* Cascading should really be solved in a shared source, so that all apps behave
in the same way (I don't consider Mail's cascading to be how it should be
either, btw).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34269 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Made the cascading work a bit nicer and more consistent.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34268 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Moved spell check files to /system/data/spell_check.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33988 a95241bf-73f2-0310-859d-f6bbb57e9c96

* When using localtime_r(), you might have to call tzset() yourself (the exact
behaviour is not specified in POSIX). This fixes Mail sometimes not having
the correct timezone.
* Since it's not specified, we might want to do that always on libroot init?
We could introduce a syscall that keeps the already parsed data, if there
isn't already to make this cheap.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33608 a95241bf-73f2-0310-859d-f6bbb57e9c96

Hopefully this are all remaining read erros.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30651 a95241bf-73f2-0310-859d-f6bbb57e9c96

Add another option to the mail app. When you switch "Automaticly mark mail as readed" off a new Read / Unread button appears and a mail is only marked as readed when you push this button. On default the old behaviour is used.

This is once again a opera feature I like very much and I haven't found in any other email client yet.
E.g. you can start a query on unreaded mails and take a short look at the mails without the mails are disappearing from the query. If you read the mail you press "Readed" and the mail is gone from the query. This is e.g an advantage if you have less time, take a look at a mail and found that the mail is very long but potentially intressting. In this case you just press next or close the window and the mail is still in the unreaded query, ready to be readed at another time. The unreaded flag becomes something like a automatic important flag. You don't have to mark / unmark the mails as important and still don't forget to process any mail. I think this is a different way how most people read mails so I hope you like the patch.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30437 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Changed the window cascading to be more useful with more windows.
* Minor cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26113 a95241bf-73f2-0310-859d-f6bbb57e9c96

The "Show Header" option is no longer persistent, and will only affect the
currently shown mail when checked.
It just didn't make any sense the way it was before, and was inconsistent, too,
as it only affected mails opened after the current one.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26112 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added an Accounts menu item which opens the E-mail preferences.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@24021 a95241bf-73f2-0310-859d-f6bbb57e9c96

* fixed Mail startup, it would not open a window because of an uninitialized
variable (#1459)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@22200 a95241bf-73f2-0310-859d-f6bbb57e9c96

first part of a big cleanup of the Mail code
* separated window, app and context menu code
* got rid of all the global variables (which were accessed completely without
locking, and the code with regards to the preference window sill needs
fixing)
* extracted some defines and helper functions to MailSupport.cpp, though I later
saw Utilities.cpp...
* got rid of the FONT_SIZE define which was used in some (but not all) controls
to override the system font size
* worked in Header.cpp to get the controls layout font sensitive with correct
alignment too, some problems remain when resizing the window


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@22122 a95241bf-73f2-0310-859d-f6bbb57e9c96