Mail: Accept dropped files on window

Currently only files dropped on the mail contents view are added as
attachments. Since dropped text files get inserted into the contents,
it only worked for non-text files.

With this change, the header area and the empty space of the tool bar
react to file drops as well.

* Accept dropped files on the whole window area
* Forward dropped files on the address text controls to the
main window (if they aren't people files)

Change-Id: Ia92f1e34aaf98a3089b318947668f3df41af00ce
Reviewed-on: https://review.haiku-os.org/c/haiku/+/6697
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>

Mail: fix layout when resending

When resending a mail, don't put the To-field in the second column
after the From-field as it's done for incoming mail. To- and From-field
are the same layout as for creating a new mail.

Use the member fResending instead of the parameter "resending" the
THeaderView was called with.

Initialize fCcControl in ctor.

Mail: save vertical space in the header when reading mail

The layout is unchanged for writing an email.

Changes when reading an email:

* decrease vertical spacing between rows
* move "To" to the right of "From" in the first row
* move "CC" to the right of "Date" in the second row
* move "Subject" down to the last, 3rd row

"CC" still only shows when it contains data.

This is a comparison of the old (left) and new (right) layout:
https://linx.li/new-mail.png

TODO:
It would be nice if the "To" and "CC" were right-aligned.

Change-Id: I89c758bc16af03838e6e3206b2983f451f6044b2
Reviewed-on: https://review.haiku-os.org/753
Reviewed-by: Axel Dörfler <axeld@pinc-software.de>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>

Mail: corrected spacing after window spacing change.

* The button panel shouldn't be indented at all.
* The header panel was intented twice, once by the surrounding layout,
once by its own.

Mail: Implement select all hook for subject

This allows the Cmd+A key shortcut to select all text on
the subject control. You could already Select All from the
View menu but this is more convinient.

Fixes #12361

Mail: temporary workaround for the label placing issue.

* Does not work for all font sizes.

Mail: change look of disabled text controls.

* Added HeaderTextControl that draws the text in black, and uses the
panel background without a frame when it's disabled. Only the label
is still drawn as disabled.
* Changed AddressTextControl to behave in the same way.
* The date view is now a HeaderTextControl, too.
* Unfortunately, the label is not vertically aligned with the contents.

BEmailMessage: added missing const, Date() returns time_t.

* Added missing const to some getter methods.
* Date() now tries to parse the date of the mail, and return it as
a time_t; you can still retrieve the actual string via
HeaderField("Date") if you have to.
* Mail now shows the time in the local time zone, and with the
current locale.

Mail: fAccount text control is no longer used.

Mail: work in progress to use the layout API.

Make sure Mail leaves enough space for all strings

* The code was assuming "Attachments" would be the longer word used, but
this doesn't always work outside of english. Actually search for the
longest string in the translations.
* Fixes #5285.
* It would be even better to convert the whole window to use layouts,
but this makes it useable until that's done.

Signed-off-by: Adrien Destugues <pulkomandy@gmail.com>

include strings.h where appriopriate...

instead or additionally to string.h, in preparation for functions move.
* moves str[n]casecmp() functions and others to strings.h.
* strings.h doesn't include string.h anymore.
* this solves #10949

Mail: Tweak the height of the menu fields

Since hrev45725 we no longer resize fixed sized menu fields to their preferred
height in the constructor so as to be backwards compatible with the behavior on
BeOS R5. As a consequence though, the menu fields in Mail are now a bit too
tall so this commit tweaks the menu fields to be just a bit shorter matching
the height of the text controls.

Mail: some 64 bit fixes

Add Cc: text field to mails shown when it's not empty.

Patch by Sean Healy 'jalopeura'. Fixes #2446.

More catalog-related cleanup.

* rename B_TRANSLATE_CONTEXT to B_TRANSLATION_CONTEXT and
B_TRANSLATE_WITH_CONTEXT to B_TRANSLATE_CONTEXT, squashing a TODO
* adjust all uses of both macros in Haiku's source tree
* use correct header guard for collecting/Catalog.h

The renamed macros require adjustments to all external applications
using catalogs.

Cosmetic fixes in localized strings. Pointed out by Sergei Reznikov (Diver). Thanks!



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41269 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by Sean "jalopeura" Healy: save and restore account and encoding of draft mails.
This fix #4789. Thanks.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41266 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fix for #7372. Don't use an uninitialized buffer. Some BString replacement of C strings. Replace Mail's ReadAttrString() function with the BNode method. Define a B_MAIL_ATTR_BCC.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41159 a95241bf-73f2-0310-859d-f6bbb57e9c96

- Partial downloaded messages are now opened by Mail and not by the mail daemon. Mail request the body fetch and get notified when the daemon is done. During this time the Mail window title is showing "Downloading: subject". This fixes #7256.
- Some cleanup in Mail.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40789 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fix account name in mail.
Work in progress: fetch next partial downloaded message.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40504 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Applied patch by Diver that lets Mail properly render vector icons for the
attachments, and adds a few missing translated strings. Thanks!
* Some cleanups by myself.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40495 a95241bf-73f2-0310-859d-f6bbb57e9c96

Switch to the new MailProtocol and account API. Lot of other smaller adaption to the new mail server.

Remove button in the pref app removes the complete account because we don't have separate chains any more. The pref app stays a mess, needs some layout love! (I did it even look worse...)

The new account/mail settings classes know if they have been changed but the current pref panel does not use this feature very well. It always mark the settings as modified when the settings view is displayed or more precise when the settings view is detached from the pref window, this could be optimized. The according mail protocol is completely restarted when their settings changed.

Some system filters are now directly integrated in the mail protocols. Hopefully make things easier to understand.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40398 a95241bf-73f2-0310-859d-f6bbb57e9c96

Updated TR_CONTEXT to be B_TRANSLATE_CONTEXT, relating to #5408.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36733 a95241bf-73f2-0310-859d-f6bbb57e9c96

Updated to use B_TRANSLATE* macros. relates to #5408.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36668 a95241bf-73f2-0310-859d-f6bbb57e9c96

Humble beginnings of a code style correction.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34976 a95241bf-73f2-0310-859d-f6bbb57e9c96

Removal of non-Haiku ifdefs. Rephrasing 'BeOS attributes' as 'file attributes'.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34974 a95241bf-73f2-0310-859d-f6bbb57e9c96

Sentence-cased GUI strings, adapted from patch by Humdinger in #5169.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34973 a95241bf-73f2-0310-859d-f6bbb57e9c96

Localization to replace the hardcoded English/Japanese. I will follow up with a Japanese translation based on the previous code. Some of the old solution lingers in parts of the code. A small amount of clean-up and removal BeOS-specifics.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34956 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixing random GCC4 warnings. Mostly missing consts, some parentheses, some braces... Should all be harmless and not change anything.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@31600 a95241bf-73f2-0310-859d-f6bbb57e9c96

- Removed debug output.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29286 a95241bf-73f2-0310-859d-f6bbb57e9c96

- Fix displaying of the From: popup menu when composing a new message.

This actually show a bug in BPopUpMenu. It seesm to think that its size
includes the arrow at its right size and so it draws the menu item
string over it. Stippi?



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29285 a95241bf-73f2-0310-859d-f6bbb57e9c96

* place the Encoding before the To. this fixes bug #1206


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29182 a95241bf-73f2-0310-859d-f6bbb57e9c96

This fixes all the issues mentioned in #1207
* improved alignment of controls
* removed last separator from icon bar
* moved separator in sending mode so grouping of trash icon is like in
reading mode
* adjust window size constraints according to icon bar width
* fixed follow modes of menufields when resizing window (even on BeOS,
though a custom menu field is needed to take care of invalidation)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@22128 a95241bf-73f2-0310-859d-f6bbb57e9c96

first part of a big cleanup of the Mail code
* separated window, app and context menu code
* got rid of all the global variables (which were accessed completely without
locking, and the code with regards to the preference window sill needs
fixing)
* extracted some defines and helper functions to MailSupport.cpp, though I later
saw Utilities.cpp...
* got rid of the FONT_SIZE define which was used in some (but not all) controls
to override the system font size
* worked in Header.cpp to get the controls layout font sensitive with correct
alignment too, some problems remain when resizing the window


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@22122 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Renamed BeMail to Mail.
* The settings are still saved in "config/settings/BeMail Settings", though.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20389 a95241bf-73f2-0310-859d-f6bbb57e9c96

Mail: temporary workaround for the label placing issue.

* Does not work for all font sizes.

Mail: change look of disabled text controls.

* Added HeaderTextControl that draws the text in black, and uses the
panel background without a frame when it's disabled. Only the label
is still drawn as disabled.
* Changed AddressTextControl to behave in the same way.
* The date view is now a HeaderTextControl, too.
* Unfortunately, the label is not vertically aligned with the contents.

BEmailMessage: added missing const, Date() returns time_t.

* Added missing const to some getter methods.
* Date() now tries to parse the date of the mail, and return it as
a time_t; you can still retrieve the actual string via
HeaderField("Date") if you have to.
* Mail now shows the time in the local time zone, and with the
current locale.

Mail: fAccount text control is no longer used.

Mail: work in progress to use the layout API.

Make sure Mail leaves enough space for all strings

* The code was assuming "Attachments" would be the longer word used, but
this doesn't always work outside of english. Actually search for the
longest string in the translations.
* Fixes #5285.
* It would be even better to convert the whole window to use layouts,
but this makes it useable until that's done.

Signed-off-by: Adrien Destugues <pulkomandy@gmail.com>

include strings.h where appriopriate...

instead or additionally to string.h, in preparation for functions move.
* moves str[n]casecmp() functions and others to strings.h.
* strings.h doesn't include string.h anymore.
* this solves #10949

Mail: Tweak the height of the menu fields

Since hrev45725 we no longer resize fixed sized menu fields to their preferred
height in the constructor so as to be backwards compatible with the behavior on
BeOS R5. As a consequence though, the menu fields in Mail are now a bit too
tall so this commit tweaks the menu fields to be just a bit shorter matching
the height of the text controls.

Mail: some 64 bit fixes

Add Cc: text field to mails shown when it's not empty.

Patch by Sean Healy 'jalopeura'. Fixes #2446.

More catalog-related cleanup.

* rename B_TRANSLATE_CONTEXT to B_TRANSLATION_CONTEXT and
B_TRANSLATE_WITH_CONTEXT to B_TRANSLATE_CONTEXT, squashing a TODO
* adjust all uses of both macros in Haiku's source tree
* use correct header guard for collecting/Catalog.h

The renamed macros require adjustments to all external applications
using catalogs.

Cosmetic fixes in localized strings. Pointed out by Sergei Reznikov (Diver). Thanks!



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41269 a95241bf-73f2-0310-859d-f6bbb57e9c96

Patch by Sean "jalopeura" Healy: save and restore account and encoding of draft mails.
This fix #4789. Thanks.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41266 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fix for #7372. Don't use an uninitialized buffer. Some BString replacement of C strings. Replace Mail's ReadAttrString() function with the BNode method. Define a B_MAIL_ATTR_BCC.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41159 a95241bf-73f2-0310-859d-f6bbb57e9c96

- Partial downloaded messages are now opened by Mail and not by the mail daemon. Mail request the body fetch and get notified when the daemon is done. During this time the Mail window title is showing "Downloading: subject". This fixes #7256.
- Some cleanup in Mail.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40789 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fix account name in mail.
Work in progress: fetch next partial downloaded message.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40504 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Applied patch by Diver that lets Mail properly render vector icons for the
attachments, and adds a few missing translated strings. Thanks!
* Some cleanups by myself.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40495 a95241bf-73f2-0310-859d-f6bbb57e9c96

Switch to the new MailProtocol and account API. Lot of other smaller adaption to the new mail server.

Remove button in the pref app removes the complete account because we don't have separate chains any more. The pref app stays a mess, needs some layout love! (I did it even look worse...)

The new account/mail settings classes know if they have been changed but the current pref panel does not use this feature very well. It always mark the settings as modified when the settings view is displayed or more precise when the settings view is detached from the pref window, this could be optimized. The according mail protocol is completely restarted when their settings changed.

Some system filters are now directly integrated in the mail protocols. Hopefully make things easier to understand.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40398 a95241bf-73f2-0310-859d-f6bbb57e9c96

Updated TR_CONTEXT to be B_TRANSLATE_CONTEXT, relating to #5408.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36733 a95241bf-73f2-0310-859d-f6bbb57e9c96

Updated to use B_TRANSLATE* macros. relates to #5408.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36668 a95241bf-73f2-0310-859d-f6bbb57e9c96

Humble beginnings of a code style correction.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34976 a95241bf-73f2-0310-859d-f6bbb57e9c96

Removal of non-Haiku ifdefs. Rephrasing 'BeOS attributes' as 'file attributes'.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34974 a95241bf-73f2-0310-859d-f6bbb57e9c96

Sentence-cased GUI strings, adapted from patch by Humdinger in #5169.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34973 a95241bf-73f2-0310-859d-f6bbb57e9c96

Localization to replace the hardcoded English/Japanese. I will follow up with a Japanese translation based on the previous code. Some of the old solution lingers in parts of the code. A small amount of clean-up and removal BeOS-specifics.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34956 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixing random GCC4 warnings. Mostly missing consts, some parentheses, some braces... Should all be harmless and not change anything.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@31600 a95241bf-73f2-0310-859d-f6bbb57e9c96

- Removed debug output.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29286 a95241bf-73f2-0310-859d-f6bbb57e9c96

- Fix displaying of the From: popup menu when composing a new message.

This actually show a bug in BPopUpMenu. It seesm to think that its size
includes the arrow at its right size and so it draws the menu item
string over it. Stippi?



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29285 a95241bf-73f2-0310-859d-f6bbb57e9c96

* place the Encoding before the To. this fixes bug #1206


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29182 a95241bf-73f2-0310-859d-f6bbb57e9c96

This fixes all the issues mentioned in #1207
* improved alignment of controls
* removed last separator from icon bar
* moved separator in sending mode so grouping of trash icon is like in
reading mode
* adjust window size constraints according to icon bar width
* fixed follow modes of menufields when resizing window (even on BeOS,
though a custom menu field is needed to take care of invalidation)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@22128 a95241bf-73f2-0310-859d-f6bbb57e9c96

first part of a big cleanup of the Mail code
* separated window, app and context menu code
* got rid of all the global variables (which were accessed completely without
locking, and the code with regards to the preference window sill needs
fixing)
* extracted some defines and helper functions to MailSupport.cpp, though I later
saw Utilities.cpp...
* got rid of the FONT_SIZE define which was used in some (but not all) controls
to override the system font size
* worked in Header.cpp to get the controls layout font sensitive with correct
alignment too, some problems remain when resizing the window


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@22122 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Renamed BeMail to Mail.
* The settings are still saved in "config/settings/BeMail Settings", though.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20389 a95241bf-73f2-0310-859d-f6bbb57e9c96