Mail: Slightly improved attachment handling, layout, strings

* In case the dropped file is a symlink, attach the actual file instead.
* Don't add a file, if it's already in the list of attachments.
* Add file size in brackets after the filename in the list of attacments.
* Add some spacing before the "Attachments" label.
* Consistently use "attachment" instead of the mixed in "enclosure".
"Attachment" also seems a more common term for this.

Change-Id: Id36d900216ce25c96ac1815889b8c7b6ec0e5f2c
Reviewed-on: https://review.haiku-os.org/c/haiku/+/6699
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>

Mail: respect system text & Link color

Change-Id: I0e37f640decb69a43ee12389af36c70c3821d548
Reviewed-on: https://review.haiku-os.org/c/haiku/+/6062
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Axel Dörfler <axeld@pinc-software.de>

Mass updating of OpenBeOS text to Haiku

No functional code altered.

https://dev.haiku-os.org/ticket/17197

Change-Id: I75cc74f6be0ad968fd77c31fbe5b0f650a6fe9e0
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4364
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>

mail: partial style cleanup

No functional changes

Change-Id: I8f2b18da4955ee48cba87359050fbe3fc8cdb9ea
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3830
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>

Mail: Fix build following realloc() fix.

Mail: fix memory leak on realloc

Fixes #9873

Change-Id: I274fc61359c34ada1088994f65f3d3c762297176
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2069
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>

Mail: change keyboard shortcuts / labels

1) People normally don't change their email account and Mail settings
often after the initial setup and short tweaking period. Using
keyboard shortcuts on those menu items is wasteful. Let's remove
them.

2) OTOH, I need to in/decrease the quoting level rather often (Mail
could probably be more intelligent here, too...).
Also, the current shortcuts for this ALT+' and ALT+SHIFT+' are awkward
and in some keymaps (German, for example) unreachable.
With the change in 1), ALT +/- becomes available, which is easily
reched with many keymaps AFAIK, and the numpad.

3) Rename the menu items "Quote" and "Remove quote" to
"Increase quote level" and "Decrease quote level", which is much
more correct. Also ties n nicely with the +/- shortcuts.

4) Rename the BMessage constants for consistency.

Change-Id: I2da21ed3aa465c30d09b2520288b64dea70feeec
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1868
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>

Change a number of sprintf to snprintf.

Fixes a number of -Werrors about format overflow from GCC 8.

mail: Fix potential memory leak

Fix memory leak when realloc() failed.
Pointed out by Clang Static Analyzer.

Change-Id: I13f758c4d89275651e22785652d0880a6d5b1a8e
Reviewed-on: https://review.haiku-os.org/c/1064
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>

Mail: fixing unicode for szlig;

The unicode for szlig ("ß") when filtering HTML tags was wrong, showing
"ö" instead. Discovered by miqlas, pin-pointed by PulkoMandy.

Mail: Fix infinite loop in FindURL.

Fixes #14746.

Signed-off-by: Augustin Cavalier <waddlesplash@gmail.com>
One minor change from owenca's original patch: we can't return
immediately if urlString is NULL, as the caller probably wants
the urlLength.

Mail: Detect URLs by parsing ahead instead of checking every character.

This is a *massive* performance improvement; some longer emails that
took 45+ seconds to load before now take < 1 second, at the cost
of a completely rewritten URL detector. This means some URLs that
were detected before (e.g. anything starting with "www", emails
without "mailto:", etc.) are now not detected, though support
for detecting them could be reinstated in the future.

Fixes #4816.

apps: Convert to using Set*UIColor.

Signed-off-by: Augustin Cavalier <waddlesplash@gmail.com>
Patches 0045-0075, 0077-0087 from looncraz, unmodified.

BScrollView::SetBorders() added to disable borders.

* You can specify which borders will be drawn using the
BControlLook::B_TOP_BORDER, ... constants.
* Adapted Mail to no longer need the SetInsets() hack.

Mail: work in progress to use the layout API.

include strings.h where appriopriate...

instead or additionally to string.h, in preparation for functions move.
* moves str[n]casecmp() functions and others to strings.h.
* strings.h doesn't include string.h anymore.
* this solves #10949

Mail: Make quote and unquote work better

Always quote and unquote starting from the beginning of the line
instead of the current cursor position.

Remove /boot/common for good

* Remove support for the "common" installation location from packagefs,
package kit, package daemon, package managers.
* Rename the B_COMMON_*_DIRECTORY constants referring to writable
directories to B_SYSTEM_*_DIRECTORY.
* Remove/adjust the use of various B_COMMON_*_DIRECTORY constants.
I'm sure some occurrence still remain. They can be adjusted when the
remaining B_COMMON_*_DIRECTORY constants are removed.

Mail: some 64 bit fixes

Mail: remove un-intended debugging code committed

Mail: coding styles fixes. should have no functional changes

Close alerts with ESCAPE key.

Added SetFlags(B_CLOSE_ON_ESCAPE) or SetShortcut(index, B_ESCAPE) to BAlerts
depending if the result gets used later in the code, or if it's a one-button
BAlert.

More catalog-related cleanup.

* rename B_TRANSLATE_CONTEXT to B_TRANSLATION_CONTEXT and
B_TRANSLATE_WITH_CONTEXT to B_TRANSLATE_CONTEXT, squashing a TODO
* adjust all uses of both macros in Haiku's source tree
* use correct header guard for collecting/Catalog.h

The renamed macros require adjustments to all external applications
using catalogs.

Some fixes for GCC 4.6 warning: variable set but not used

Improve the auto-signature insertion algorithm

* Append the signature only after the e-mail Reader thread will finish
it's work. This prevent from inserting the signature in wrong place;
* Added extra lines between original e-mail quote and the signature for
more comfortable editing of replies.
* This fix was made during GCI2011;
* This fixes #4590.

Signed-off-by: Siarzhuk Zharski <zharik@gmx.li>

Preserve/Restore e-mail reading position

* Introduce the "MAIL:read_pos" attribute of e-mail file node to
store the latest scroll position of the mail text view;
* Fixes #4302 (Mail should store and restore scroll offset);
* This feature was implemented during completing GCI2011 task.

Signed-off-by: Siarzhuk Zharski <zharik@gmx.li>

Mail: various checks of malloc returns + memory leak fix

CID 891.

Correct update of TextView text run on font change.

* Fixes #4698 - font preference changes were not applied
on the next message;
* The source of problem is resetting of the text run array after
applying new font with SetFontAndColor function. Proposed solution
updates the text run array items fonts directly without resetting
it them and without loosing any styling and color quiting
information;
* This is result of completing GCI 2011 task.

Signed-off-by: Siarzhuk Zharski <zharik@gmx.li>

Make the enclosure string in the mail body translatable.

- Partial downloaded messages are now opened by Mail and not by the mail daemon. Mail request the body fetch and get notified when the daemon is done. During this time the Mail window title is showing "Downloading: subject". This fixes #7256.
- Some cleanup in Mail.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40789 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Applied patch by Diver that lets Mail properly render vector icons for the
attachments, and adds a few missing translated strings. Thanks!
* Some cleanups by myself.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40495 a95241bf-73f2-0310-859d-f6bbb57e9c96

* applied patch by kaliber that fixes more than 100 warnings - thanks a lot!
Closes #6349

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37670 a95241bf-73f2-0310-859d-f6bbb57e9c96

Updated TR_CONTEXT to be B_TRANSLATE_CONTEXT, relating to #5408.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36733 a95241bf-73f2-0310-859d-f6bbb57e9c96

Updated to use B_TRANSLATE* macros. relates to #5408.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36668 a95241bf-73f2-0310-859d-f6bbb57e9c96

Sentence-cased GUI strings, adapted from patch by Humdinger in #5169.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34973 a95241bf-73f2-0310-859d-f6bbb57e9c96

Localization to replace the hardcoded English/Japanese. I will follow up with a Japanese translation based on the previous code. Some of the old solution lingers in parts of the code. A small amount of clean-up and removal BeOS-specifics.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34956 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixing random GCC4 warnings. Mostly missing consts, some parentheses, some braces... Should all be harmless and not change anything.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@31600 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed leaks. CID 893 and 894. There are still some leaks in this file, but the code is too complex and I won't touch it. I'd feel better if someone who knows it better would have a look

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27739 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Slightly improved invalid suffix removal from URLs.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@25872 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Added a quote_context structure that FillInQuoteTextRuns() can now optionally
use to keep track of the current context. This should not only make it faster,
but may also fix the occasionally seen bug of the previous solution.
* Added a simple diff mode coloring as well - only enabled when quote coloring
is enabled.
* Minor cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@25364 a95241bf-73f2-0310-859d-f6bbb57e9c96

first part of a big cleanup of the Mail code
* separated window, app and context menu code
* got rid of all the global variables (which were accessed completely without
locking, and the code with regards to the preference window sill needs
fixing)
* extracted some defines and helper functions to MailSupport.cpp, though I later
saw Utilities.cpp...
* got rid of the FONT_SIZE define which was used in some (but not all) controls
to override the system font size
* worked in Header.cpp to get the controls layout font sensitive with correct
alignment too, some problems remain when resizing the window


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@22122 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Renamed BeMail to Mail.
* The settings are still saved in "config/settings/BeMail Settings", though.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20389 a95241bf-73f2-0310-859d-f6bbb57e9c96

BScrollView::SetBorders() added to disable borders.

* You can specify which borders will be drawn using the
BControlLook::B_TOP_BORDER, ... constants.
* Adapted Mail to no longer need the SetInsets() hack.

Mail: work in progress to use the layout API.

include strings.h where appriopriate...

instead or additionally to string.h, in preparation for functions move.
* moves str[n]casecmp() functions and others to strings.h.
* strings.h doesn't include string.h anymore.
* this solves #10949

Mail: Make quote and unquote work better

Always quote and unquote starting from the beginning of the line
instead of the current cursor position.

Remove /boot/common for good

* Remove support for the "common" installation location from packagefs,
package kit, package daemon, package managers.
* Rename the B_COMMON_*_DIRECTORY constants referring to writable
directories to B_SYSTEM_*_DIRECTORY.
* Remove/adjust the use of various B_COMMON_*_DIRECTORY constants.
I'm sure some occurrence still remain. They can be adjusted when the
remaining B_COMMON_*_DIRECTORY constants are removed.

Mail: some 64 bit fixes

Mail: remove un-intended debugging code committed

Mail: coding styles fixes. should have no functional changes

Close alerts with ESCAPE key.

Added SetFlags(B_CLOSE_ON_ESCAPE) or SetShortcut(index, B_ESCAPE) to BAlerts
depending if the result gets used later in the code, or if it's a one-button
BAlert.

More catalog-related cleanup.

* rename B_TRANSLATE_CONTEXT to B_TRANSLATION_CONTEXT and
B_TRANSLATE_WITH_CONTEXT to B_TRANSLATE_CONTEXT, squashing a TODO
* adjust all uses of both macros in Haiku's source tree
* use correct header guard for collecting/Catalog.h

The renamed macros require adjustments to all external applications
using catalogs.

Some fixes for GCC 4.6 warning: variable set but not used

Improve the auto-signature insertion algorithm

* Append the signature only after the e-mail Reader thread will finish
it's work. This prevent from inserting the signature in wrong place;
* Added extra lines between original e-mail quote and the signature for
more comfortable editing of replies.
* This fix was made during GCI2011;
* This fixes #4590.

Signed-off-by: Siarzhuk Zharski <zharik@gmx.li>

Preserve/Restore e-mail reading position

* Introduce the "MAIL:read_pos" attribute of e-mail file node to
store the latest scroll position of the mail text view;
* Fixes #4302 (Mail should store and restore scroll offset);
* This feature was implemented during completing GCI2011 task.

Signed-off-by: Siarzhuk Zharski <zharik@gmx.li>

Mail: various checks of malloc returns + memory leak fix

CID 891.

Correct update of TextView text run on font change.

* Fixes #4698 - font preference changes were not applied
on the next message;
* The source of problem is resetting of the text run array after
applying new font with SetFontAndColor function. Proposed solution
updates the text run array items fonts directly without resetting
it them and without loosing any styling and color quiting
information;
* This is result of completing GCI 2011 task.

Signed-off-by: Siarzhuk Zharski <zharik@gmx.li>

Make the enclosure string in the mail body translatable.

- Partial downloaded messages are now opened by Mail and not by the mail daemon. Mail request the body fetch and get notified when the daemon is done. During this time the Mail window title is showing "Downloading: subject". This fixes #7256.
- Some cleanup in Mail.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40789 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Applied patch by Diver that lets Mail properly render vector icons for the
attachments, and adds a few missing translated strings. Thanks!
* Some cleanups by myself.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40495 a95241bf-73f2-0310-859d-f6bbb57e9c96

* applied patch by kaliber that fixes more than 100 warnings - thanks a lot!
Closes #6349

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37670 a95241bf-73f2-0310-859d-f6bbb57e9c96

Updated TR_CONTEXT to be B_TRANSLATE_CONTEXT, relating to #5408.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36733 a95241bf-73f2-0310-859d-f6bbb57e9c96

Updated to use B_TRANSLATE* macros. relates to #5408.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36668 a95241bf-73f2-0310-859d-f6bbb57e9c96

Sentence-cased GUI strings, adapted from patch by Humdinger in #5169.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34973 a95241bf-73f2-0310-859d-f6bbb57e9c96

Localization to replace the hardcoded English/Japanese. I will follow up with a Japanese translation based on the previous code. Some of the old solution lingers in parts of the code. A small amount of clean-up and removal BeOS-specifics.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34956 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixing random GCC4 warnings. Mostly missing consts, some parentheses, some braces... Should all be harmless and not change anything.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@31600 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed leaks. CID 893 and 894. There are still some leaks in this file, but the code is too complex and I won't touch it. I'd feel better if someone who knows it better would have a look

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27739 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Slightly improved invalid suffix removal from URLs.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@25872 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Added a quote_context structure that FillInQuoteTextRuns() can now optionally
use to keep track of the current context. This should not only make it faster,
but may also fix the occasionally seen bug of the previous solution.
* Added a simple diff mode coloring as well - only enabled when quote coloring
is enabled.
* Minor cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@25364 a95241bf-73f2-0310-859d-f6bbb57e9c96

first part of a big cleanup of the Mail code
* separated window, app and context menu code
* got rid of all the global variables (which were accessed completely without
locking, and the code with regards to the preference window sill needs
fixing)
* extracted some defines and helper functions to MailSupport.cpp, though I later
saw Utilities.cpp...
* got rid of the FONT_SIZE define which was used in some (but not all) controls
to override the system font size
* worked in Header.cpp to get the controls layout font sensitive with correct
alignment too, some problems remain when resizing the window


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@22122 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Renamed BeMail to Mail.
* The settings are still saved in "config/settings/BeMail Settings", though.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20389 a95241bf-73f2-0310-859d-f6bbb57e9c96