Installer: Fixed installer

- InstallerWindow.cpp announces a message with a boolean that defines whether the install has been completed. That boolean will define InstallerApp.cpp's behavior.
- Changed the method that was used (unsuccessfully) to open FirstBootPrompt within the Installer itself, upon quitting.

Change-Id: Ibbba2f0ee3b79e091032294afcb3ed404e898f5c
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3218
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>

Installer: Rework status message view sizing logic.

* Make the status message view have a minimum height of the logo
view's height.
* Properly add the views to the BGroupView layout.
* Instead of trying to set the explicit minimum size from the status
view information, just invalidate the GroupLayout. This seems to fix
a number of bugs relating to text overflowing the view, while it doesn't
fix others (e.g. orphan words on their own lines are still not drawn
in some cases, which appears to be a BTextView bug.)
* Use BString::SetToFormat instead of snprintf in some places.

As far as I can make out, fixes #13608.

Installer: WorkerThread: Remove InstallerWindow dependency

* Move message constants to InstallerDefs.h.
* Determine the source and target partition ID already in
InstallerWindow and pass those to WorkerThread instead of fiddling
with menu items in _PerformInstall(). And instead of the window object
pass a messenger to the constructor.

Installer: Move path string constants to new InstallerDefs.h/cpp

* Applied patch by idefix that fixes IDE. Nah, that fixes launching BootManager
when mimset didn't run yet. This obviously cleans up after a change that I
did, thanks a lot!
* This closes bug #7595.
* Also took the opportunity to clean up a bit more in this regard, and fixed a
few coding style violations.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41837 a95241bf-73f2-0310-859d-f6bbb57e9c96

InstallSourceArchive now copies source archives to _sources_/, which in turn
is ignored by Installer. Automatic whitespace cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36517 a95241bf-73f2-0310-859d-f6bbb57e9c96

Moved the "Write boot sector" and "Set up boot menu" functionality into a new
Tools menu. Fixes #5820.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36484 a95241bf-73f2-0310-859d-f6bbb57e9c96

In the spirit of giving exposure to as many Haiku features as possible,
integrate the Boot Manager into Installer. There was a patch for this in ticket
#4425, but I have implemented this myself, since the patch didn't implement
the interaction with running and quitting DriveSetup and Bootman correctly.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36482 a95241bf-73f2-0310-859d-f6bbb57e9c96

Simplified use of CenterOnScreen().

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33406 a95241bf-73f2-0310-859d-f6bbb57e9c96

Changed the somewhat bold BLocker usage to a more straight forward semaphore
based mechanism to pause and eventually cancel the WorkerThread. This also works
now when the CopyEngine is still collecting file informartion (ticket #4153).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@31912 a95241bf-73f2-0310-859d-f6bbb57e9c96

If no suitable partitions have been found, encourage the user to use the
Setup Partitions button...


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30612 a95241bf-73f2-0310-859d-f6bbb57e9c96

First round of cleanup:
* Renamed CopyEngine to WorkerThread, since it's used for other things than
just copying.
* Removed the code borrowed from Tracker.
* Removed the InstallerCopyLoopControl, since the CopyEngine handles
notifications and cancelling by itself now.
* Renamed a few message constants.
* Since we only support BFS partitions as install targets, I removed the
FS type from the target menu item label. However, I am going to solve this
differently. I guess all partitions should be seen in the target list, just
disabled if they are not a valid target, and with a reason given too.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30600 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Prevent to copy the "var" and "_packages_" folders from the source volume
root folder as before switching the CopyEngine.
* Add a button "Write Boot Sector" that makes the selected target volume
bootable without performing an installation. Adjusted the status message
after installation to be more descriptive.
* Small improvements in the CopyEngine, collecting the source size should be
even a bit faster now since we can use the file size from the already
performed stat().


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30395 a95241bf-73f2-0310-859d-f6bbb57e9c96

Sorry, this is a bit of a mess yet and needs more refactoring...
* I've implemented my own copy engine which runs a separate writer thread.
Especially when installing from one hard drive to another, it should speed
things up. When installing from CD, the entire harddisk write time should
at least disappear in the CD read time. When installing from/to the same
drive, the new routine is as fast as the Tracker code that was used before.
* When stopping/canceling the copy process, the copy engine will now actually
block, instead of happily going on while the alert is showing. I've
still implemented that to not leave incomplete files around, like before.
* There is now a progress bar, based on data bytes in files to copy. Reason
being that it's quite fast to collect this info versus also scanning all
attributes.
* The copy engine itself was used in another project before and was tested
with SHA256 hashes of the original files and the copied files, so I think
it can be trusted.
* There is now a lot of code that can be removed or should be cleaned up.
What was the "CopyEngine" should become the "WorkerThread" or something.
* I still had a mental TODO about skipping the swap file (there is none on
CDs, but when copying a harddisk installation there may be one), I just
remembered this when typing this commit message... will fix that next.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30394 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Tweaked text here and there (also thanks to Alexandre for proof-reading!)
* Renamed _UpdateMenus() to _UpdateControls().


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30380 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Prevent the user from chosing the same disk for source and destination.
* Keep the info text and the Begin button in consistent state at all times
according to the selection of the disks.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30379 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Adopted naming scheme for private methods
* Sorted methods to reflect order in .cpp


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30376 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Converted to use layout-management.
* New logo specific to R1 Alpha/1.
* "Setup Partitions" is now always visible, since it will most likely be
required to prepare a partition for installation anyways.
* The optional packages are still in the GUI, but are collapsed by default as
before. As there are currently no optional packages, a message will be
displayed if no optional packages are found on the source partition.
* The default label for the "Onto" popup is now "Please choose target" instead
of the first partition found, even though it is not actually selected yet.
* The EULA window is still shown, but it's not based on a BAlert anymore.
* Only make main window non-minimizable if the Deskbar is not running
(untested).
* Style cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30368 a95241bf-73f2-0310-859d-f6bbb57e9c96

In some ways, this is unrelated, but I had to combine this anyhow:
* Extend the PaneSwitch BControl from Tracker, so it can draw on/off labels.
This has the added benefit that you can click the label to expand/collapse,
like for example in the Get Info window (Permissions).
* I also added font-sensitivity features to PaneSwitch, and it can be used
in layouted windows (untested).
* This made the "DrawButton" in the Installer superfluous.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30348 a95241bf-73f2-0310-859d-f6bbb57e9c96

* don't copy /var (bug #3584)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29707 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Patch from Christian Fasshauer: provides a cancel button
* fixed a few things: one couldn't restart the install process when cancelled, use B_QUIT_REQUESTED instead of QuitRequested().


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@25466 a95241bf-73f2-0310-859d-f6bbb57e9c96

code style update
now mount the target partition before copying


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@21113 a95241bf-73f2-0310-859d-f6bbb57e9c96

minor cleanup


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16340 a95241bf-73f2-0310-859d-f6bbb57e9c96

if a already selected item is selected, don't do anything
Installer isn't beos compatible is this directory, will add a test directory for it
fixed link libs and debug message


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16196 a95241bf-73f2-0310-859d-f6bbb57e9c96

some changes : alert if free space isn't enough, set status when mouse is over packages (doesn't work for some reason ...)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16192 a95241bf-73f2-0310-859d-f6bbb57e9c96

* added checks for installing on source volume, or boot volume
* added alert for file error: lots of errors happening when updating a volume:
* it seems BEntry::IsDirectory() returns false whereas it should return true for some directories
this is to be checked with a test app
* boot volume is now marked automatically as the source volume (a rule is yet to be found for the target volume)



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16066 a95241bf-73f2-0310-859d-f6bbb57e9c96

reworked a bit to install packages


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16048 a95241bf-73f2-0310-859d-f6bbb57e9c96

CopyEngine is a BLooper: let it delete itself ...
copy everything in source directory instead of just 'beos'


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16040 a95241bf-73f2-0310-859d-f6bbb57e9c96

actually uses the copyengine looper to handle the copy process


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16011 a95241bf-73f2-0310-859d-f6bbb57e9c96

now populates menus
improved size to string formating for GB and TB


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@14531 a95241bf-73f2-0310-859d-f6bbb57e9c96

added a haiku logo from stippi, thanks!
enlarged the window
improves widget placement


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@14419 a95241bf-73f2-0310-859d-f6bbb57e9c96

fix packages view, added a copy engine class


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@14283 a95241bf-73f2-0310-859d-f6bbb57e9c96

more copy loop control methods
added a size view


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@14268 a95241bf-73f2-0310-859d-f6bbb57e9c96

displays package list


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@14234 a95241bf-73f2-0310-859d-f6bbb57e9c96

added some views for packages


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@14230 a95241bf-73f2-0310-859d-f6bbb57e9c96

added an EULA, etc ...


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@14220 a95241bf-73f2-0310-859d-f6bbb57e9c96

fix my name encoding
added a few comonents


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@14217 a95241bf-73f2-0310-859d-f6bbb57e9c96

added a skeleton for Installer


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@14212 a95241bf-73f2-0310-859d-f6bbb57e9c96

Installer: WorkerThread: Remove InstallerWindow dependency

* Move message constants to InstallerDefs.h.
* Determine the source and target partition ID already in
InstallerWindow and pass those to WorkerThread instead of fiddling
with menu items in _PerformInstall(). And instead of the window object
pass a messenger to the constructor.

Installer: Move path string constants to new InstallerDefs.h/cpp

* Applied patch by idefix that fixes IDE. Nah, that fixes launching BootManager
when mimset didn't run yet. This obviously cleans up after a change that I
did, thanks a lot!
* This closes bug #7595.
* Also took the opportunity to clean up a bit more in this regard, and fixed a
few coding style violations.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41837 a95241bf-73f2-0310-859d-f6bbb57e9c96

InstallSourceArchive now copies source archives to _sources_/, which in turn
is ignored by Installer. Automatic whitespace cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36517 a95241bf-73f2-0310-859d-f6bbb57e9c96

Moved the "Write boot sector" and "Set up boot menu" functionality into a new
Tools menu. Fixes #5820.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36484 a95241bf-73f2-0310-859d-f6bbb57e9c96

In the spirit of giving exposure to as many Haiku features as possible,
integrate the Boot Manager into Installer. There was a patch for this in ticket
#4425, but I have implemented this myself, since the patch didn't implement
the interaction with running and quitting DriveSetup and Bootman correctly.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36482 a95241bf-73f2-0310-859d-f6bbb57e9c96

Simplified use of CenterOnScreen().

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33406 a95241bf-73f2-0310-859d-f6bbb57e9c96

Changed the somewhat bold BLocker usage to a more straight forward semaphore
based mechanism to pause and eventually cancel the WorkerThread. This also works
now when the CopyEngine is still collecting file informartion (ticket #4153).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@31912 a95241bf-73f2-0310-859d-f6bbb57e9c96

If no suitable partitions have been found, encourage the user to use the
Setup Partitions button...


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30612 a95241bf-73f2-0310-859d-f6bbb57e9c96

First round of cleanup:
* Renamed CopyEngine to WorkerThread, since it's used for other things than
just copying.
* Removed the code borrowed from Tracker.
* Removed the InstallerCopyLoopControl, since the CopyEngine handles
notifications and cancelling by itself now.
* Renamed a few message constants.
* Since we only support BFS partitions as install targets, I removed the
FS type from the target menu item label. However, I am going to solve this
differently. I guess all partitions should be seen in the target list, just
disabled if they are not a valid target, and with a reason given too.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30600 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Prevent to copy the "var" and "_packages_" folders from the source volume
root folder as before switching the CopyEngine.
* Add a button "Write Boot Sector" that makes the selected target volume
bootable without performing an installation. Adjusted the status message
after installation to be more descriptive.
* Small improvements in the CopyEngine, collecting the source size should be
even a bit faster now since we can use the file size from the already
performed stat().


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30395 a95241bf-73f2-0310-859d-f6bbb57e9c96

Sorry, this is a bit of a mess yet and needs more refactoring...
* I've implemented my own copy engine which runs a separate writer thread.
Especially when installing from one hard drive to another, it should speed
things up. When installing from CD, the entire harddisk write time should
at least disappear in the CD read time. When installing from/to the same
drive, the new routine is as fast as the Tracker code that was used before.
* When stopping/canceling the copy process, the copy engine will now actually
block, instead of happily going on while the alert is showing. I've
still implemented that to not leave incomplete files around, like before.
* There is now a progress bar, based on data bytes in files to copy. Reason
being that it's quite fast to collect this info versus also scanning all
attributes.
* The copy engine itself was used in another project before and was tested
with SHA256 hashes of the original files and the copied files, so I think
it can be trusted.
* There is now a lot of code that can be removed or should be cleaned up.
What was the "CopyEngine" should become the "WorkerThread" or something.
* I still had a mental TODO about skipping the swap file (there is none on
CDs, but when copying a harddisk installation there may be one), I just
remembered this when typing this commit message... will fix that next.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30394 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Tweaked text here and there (also thanks to Alexandre for proof-reading!)
* Renamed _UpdateMenus() to _UpdateControls().


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30380 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Prevent the user from chosing the same disk for source and destination.
* Keep the info text and the Begin button in consistent state at all times
according to the selection of the disks.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30379 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Adopted naming scheme for private methods
* Sorted methods to reflect order in .cpp


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30376 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Converted to use layout-management.
* New logo specific to R1 Alpha/1.
* "Setup Partitions" is now always visible, since it will most likely be
required to prepare a partition for installation anyways.
* The optional packages are still in the GUI, but are collapsed by default as
before. As there are currently no optional packages, a message will be
displayed if no optional packages are found on the source partition.
* The default label for the "Onto" popup is now "Please choose target" instead
of the first partition found, even though it is not actually selected yet.
* The EULA window is still shown, but it's not based on a BAlert anymore.
* Only make main window non-minimizable if the Deskbar is not running
(untested).
* Style cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30368 a95241bf-73f2-0310-859d-f6bbb57e9c96

In some ways, this is unrelated, but I had to combine this anyhow:
* Extend the PaneSwitch BControl from Tracker, so it can draw on/off labels.
This has the added benefit that you can click the label to expand/collapse,
like for example in the Get Info window (Permissions).
* I also added font-sensitivity features to PaneSwitch, and it can be used
in layouted windows (untested).
* This made the "DrawButton" in the Installer superfluous.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@30348 a95241bf-73f2-0310-859d-f6bbb57e9c96

* don't copy /var (bug #3584)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29707 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Patch from Christian Fasshauer: provides a cancel button
* fixed a few things: one couldn't restart the install process when cancelled, use B_QUIT_REQUESTED instead of QuitRequested().


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@25466 a95241bf-73f2-0310-859d-f6bbb57e9c96

code style update
now mount the target partition before copying


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@21113 a95241bf-73f2-0310-859d-f6bbb57e9c96

minor cleanup


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16340 a95241bf-73f2-0310-859d-f6bbb57e9c96

if a already selected item is selected, don't do anything
Installer isn't beos compatible is this directory, will add a test directory for it
fixed link libs and debug message


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16196 a95241bf-73f2-0310-859d-f6bbb57e9c96

some changes : alert if free space isn't enough, set status when mouse is over packages (doesn't work for some reason ...)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16192 a95241bf-73f2-0310-859d-f6bbb57e9c96

* added checks for installing on source volume, or boot volume
* added alert for file error: lots of errors happening when updating a volume:
* it seems BEntry::IsDirectory() returns false whereas it should return true for some directories
this is to be checked with a test app
* boot volume is now marked automatically as the source volume (a rule is yet to be found for the target volume)



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16066 a95241bf-73f2-0310-859d-f6bbb57e9c96

reworked a bit to install packages


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16048 a95241bf-73f2-0310-859d-f6bbb57e9c96

CopyEngine is a BLooper: let it delete itself ...
copy everything in source directory instead of just 'beos'


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16040 a95241bf-73f2-0310-859d-f6bbb57e9c96

actually uses the copyengine looper to handle the copy process


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16011 a95241bf-73f2-0310-859d-f6bbb57e9c96

now populates menus
improved size to string formating for GB and TB


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@14531 a95241bf-73f2-0310-859d-f6bbb57e9c96

added a haiku logo from stippi, thanks!
enlarged the window
improves widget placement


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@14419 a95241bf-73f2-0310-859d-f6bbb57e9c96

fix packages view, added a copy engine class


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@14283 a95241bf-73f2-0310-859d-f6bbb57e9c96

more copy loop control methods
added a size view


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@14268 a95241bf-73f2-0310-859d-f6bbb57e9c96

displays package list


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@14234 a95241bf-73f2-0310-859d-f6bbb57e9c96

added some views for packages


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@14230 a95241bf-73f2-0310-859d-f6bbb57e9c96

added an EULA, etc ...


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@14220 a95241bf-73f2-0310-859d-f6bbb57e9c96

fix my name encoding
added a few comonents


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@14217 a95241bf-73f2-0310-859d-f6bbb57e9c96

added a skeleton for Installer


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@14212 a95241bf-73f2-0310-859d-f6bbb57e9c96