History log of /haiku/src/apps/debugger/user_interface/gui/teams_window/TeamsListView.cpp
Revision Date Author Comments
# af791479 30-Aug-2022 Augustin Cavalier <waddlesplash@gmail.com>

Debugger: Initial fixes to TeamsListView for HiDPI.

* Use BControlLook::ComposeIconSize.
* Use LabelSpacing for row heights.


# 70823669 13-Jan-2018 Rene Gollent <rene@gollent.com>

Debugger: Fix crash in teams window.

- Some of the recent changes for memory management exposed a race
condition, where the teams window would potentially try to access
already freed objects on quit. Ensure we acquire references to the target
host so this doesn't happen.


# 365840af 30-Nov-2016 Rene Gollent <rene@gollent.com>

Debugger: Adjust TeamsWindow for connection selection.

TeamsWindow:
- Add Listener interface for selected target host interface changes.
- Add menu field to display/choose between active host connections.
- Add button to create a new connection (not yet functional).

TeamsListView:
- Implement TeamsWindow Listener interface to decide when to update
the displayed team list.
- Remove unused current team ID.


# a1afac4d 20-Apr-2016 Rene Gollent <rene@gollent.com>

Debugger: Rework to fully use TargetHostInterface.

Application objects:
- Rework and simplify to take into account that they will no longer be
directly managing the team debugger list. Requests to start a new debugger
are still funnelled through here however, and as such, said requests must
now provide the appropriate target host to start with. Adjust StartTeamWindow
and TeamsWindow accordingly.
- On global init, always create an instance of the local interface.

TargetHostInterface:
- Convert to BLooper and implement TeamDebugger's Listener interface.
TargetHostInterfaces now directly manage their TeamDebugger instances,
and consequently take over the equivalent duties that the main application
previously had.
- Adjust signatures of Attach/CreateTeam to add const. Adjust
LocalTargetHostInterface accordingly.
- Add accessor to determine if a given interface is local or not. Will be
needed for the TeamDebugger's file manager eventually so it knows if it
needs to request remote files if no matching local file is found.
- Add accessor to start a TeamDebugger instance, and corresponding options
structure.

TargetHostInterfaceRoster:
- Minor adjustments to host interface initialization to take into account
needing to start the looper.
- Add accessor for number of running team debuggers, for the main app to
use when deciding to quit.

TeamDebugger:
- Add accessor for SettingsManager. Needed for the case of a restart request,
as the host interfaces do not have direct access to it.

TeamsWindow:
- For now, always grab the local host interface when initializing the window.
Once the remote interface is implemented, this will need to be adjusted, but
the appropriate UI for creating/selecting it is needed first anyways.

With these changes, the main application is fully host-agnostic, and all
management of actual debuggers is delegated to their parent host interfaces.
There still needs to be a listener interface for the host interface and/or
roster though, so that the application can be made aware of when debuggers
quit, as this drives whether it's time to terminate the app or not.


# 8c7bdb72 04-Apr-2016 Rene Gollent <rene@gollent.com>

Debugger: Refactor TeamsWindow to use TargetHostInterface.

TeamsWindow:
- On startup, instantiate a LocalTargetHostInterface, and pass it
to the TeamsListView.

TeamsListView:
- Refactor building and updating the teams list to work via TargetHost
and its respective listener interface rather than the previous combination
of be_roster and manual polling.
- Style fixes.


# 8d1603cd 10-May-2015 Janus <janus2@ymail.com>

Debugger: BColumnListView supports big fonts.

* Fix #9240.


# cde8a1ab 09-Jan-2015 Janus <janus2@ymail.com>

Fix #11727 - Teams listview is navigable

Signed-off-by: Rene Gollent <rene@gollent.com>


# 12abf3b2 02-May-2013 Rene Gollent <anevilyak@gmail.com>

Various cleanups to Teams window.

- Convert to using layout APIs.
- Add buttons to attach to an existing team or create a new one (not
implemented yet).
- Various minor style cleanups.


# 7a931c68 16-Sep-2011 Philippe Houdoin <philippe.houdoin@gmail.com>

Do an explicit row's update when it's needed.
This should close #7988 this time, hopefully.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42756 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 909c5269 15-Sep-2011 Philippe Houdoin <philippe.houdoin@gmail.com>

Pass up-to-date team_info to TeamRow, so we can detect when a team app image has changed after
an exec() syscall, and update team's fields, icon included.
This fix #7988.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42755 a95241bf-73f2-0310-859d-f6bbb57e9c96


# dd537d13 21-Aug-2011 Philippe Houdoin <philippe.houdoin@gmail.com>

Followed Ingo's suggestion: use private get_app_ref(). This reduce code duplication.
Thanks.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42659 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 727c05a5 21-Aug-2011 Philippe Houdoin <philippe.houdoin@gmail.com>

Now always retrieve the team icon from the first B_APP_IMAGE image entry_ref.
Using team_info.args as before was not safe: when truncated, the
entry_ref could be an intermediate folder, which display a folder
icon as team's icon!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42653 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 7015777f 17-Nov-2010 Philippe Houdoin <philippe.houdoin@gmail.com>

Switch the list to a BColumnListView-based one.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39476 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 6fd9d3d9 02-Nov-2010 Philippe Houdoin <philippe.houdoin@gmail.com>

Fix style.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39269 a95241bf-73f2-0310-859d-f6bbb57e9c96


# aede5439 02-Nov-2010 Philippe Houdoin <philippe.houdoin@gmail.com>

Checks AddItem() success, as hinted by Stippi 5 (!) weeks ago.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39268 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 7fa49587 28-Sep-2010 Philippe Houdoin <philippe.houdoin@gmail.com>

Fix a bug in _UpdateList(), where the newest teams were not append at all due to
an out-of-range index passed to AddItem().


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38832 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 30c47afa 22-Sep-2010 Philippe Houdoin <philippe.houdoin@gmail.com>

Fix memory leak + style cleanup. Thanks Axel!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38787 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 190108e9 22-Sep-2010 Philippe Houdoin <philippe.houdoin@gmail.com>

Add missing allocation checks where needed.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38785 a95241bf-73f2-0310-859d-f6bbb57e9c96


# db2c7eeb 22-Sep-2010 Philippe Houdoin <philippe.houdoin@gmail.com>

Style cleanup, no functional changes.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38782 a95241bf-73f2-0310-859d-f6bbb57e9c96


# ccb01bef 21-Sep-2010 Philippe Houdoin <philippe.houdoin@gmail.com>

Finally integrates running_teams_window stuff to the Debugger app:
* Rework Debugger class a bit to ease integration
* Expand TeamDebugger::Listener interface to notify start event too.
* Former RunningTeamsWindow, now name TeamsWindow, is shown at start
if no team/program to launch is specified.
* Double-clicking a team item in this list starts a new Team debugger, or
reactivate the existing one if any

This window settings is not yet integrated with the SettingsManager.
Will comes next.
I plan to add some UI controls to this Teams window to allow user to setup
a program arguments and environment variables and then launch & debug it.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38758 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 8d1603cd54e2953c9f5c7c572f896f4277875700 10-May-2015 Janus <janus2@ymail.com>

Debugger: BColumnListView supports big fonts.

* Fix #9240.


# cde8a1ab6902932a18e83eab3972671d75ec83d1 09-Jan-2015 Janus <janus2@ymail.com>

Fix #11727 - Teams listview is navigable

Signed-off-by: Rene Gollent <rene@gollent.com>


# 12abf3b28011c9034fefeb9efec04cc4a7c224ed 02-May-2013 Rene Gollent <anevilyak@gmail.com>

Various cleanups to Teams window.

- Convert to using layout APIs.
- Add buttons to attach to an existing team or create a new one (not
implemented yet).
- Various minor style cleanups.


# 7a931c68e85dbdfbc546f5edc838a1f3246cf6f6 16-Sep-2011 Philippe Houdoin <philippe.houdoin@gmail.com>

Do an explicit row's update when it's needed.
This should close #7988 this time, hopefully.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42756 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 909c526903ac020634f6efde096698989acf2198 15-Sep-2011 Philippe Houdoin <philippe.houdoin@gmail.com>

Pass up-to-date team_info to TeamRow, so we can detect when a team app image has changed after
an exec() syscall, and update team's fields, icon included.
This fix #7988.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42755 a95241bf-73f2-0310-859d-f6bbb57e9c96


# dd537d13a84fad412fb5fa68d5744199232423d4 21-Aug-2011 Philippe Houdoin <philippe.houdoin@gmail.com>

Followed Ingo's suggestion: use private get_app_ref(). This reduce code duplication.
Thanks.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42659 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 727c05a5df9b4c29497768f64c2afaf1f54128a5 21-Aug-2011 Philippe Houdoin <philippe.houdoin@gmail.com>

Now always retrieve the team icon from the first B_APP_IMAGE image entry_ref.
Using team_info.args as before was not safe: when truncated, the
entry_ref could be an intermediate folder, which display a folder
icon as team's icon!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42653 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 7015777f33adebf9b333ba90a2559ec2ffc4dbc6 17-Nov-2010 Philippe Houdoin <philippe.houdoin@gmail.com>

Switch the list to a BColumnListView-based one.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39476 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 6fd9d3d9301eb96832ffe05db42fba2aef3bfdae 02-Nov-2010 Philippe Houdoin <philippe.houdoin@gmail.com>

Fix style.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39269 a95241bf-73f2-0310-859d-f6bbb57e9c96


# aede5439948bf7f19b4ac2dd2f7913a4595a6b7e 02-Nov-2010 Philippe Houdoin <philippe.houdoin@gmail.com>

Checks AddItem() success, as hinted by Stippi 5 (!) weeks ago.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39268 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 7fa49587bc9339d0fc355e2239e2840fa60fdc5f 28-Sep-2010 Philippe Houdoin <philippe.houdoin@gmail.com>

Fix a bug in _UpdateList(), where the newest teams were not append at all due to
an out-of-range index passed to AddItem().


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38832 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 30c47afa79f617945e74394c463e2eb5cc021950 22-Sep-2010 Philippe Houdoin <philippe.houdoin@gmail.com>

Fix memory leak + style cleanup. Thanks Axel!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38787 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 190108e9c901482dabfc9c88fb2f9e23cdb405e3 22-Sep-2010 Philippe Houdoin <philippe.houdoin@gmail.com>

Add missing allocation checks where needed.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38785 a95241bf-73f2-0310-859d-f6bbb57e9c96


# db2c7eeb49cf219569e7ff442187bab11805c82d 22-Sep-2010 Philippe Houdoin <philippe.houdoin@gmail.com>

Style cleanup, no functional changes.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38782 a95241bf-73f2-0310-859d-f6bbb57e9c96


# ccb01bef441eb4f8a951633d646dd545fe5f800c 21-Sep-2010 Philippe Houdoin <philippe.houdoin@gmail.com>

Finally integrates running_teams_window stuff to the Debugger app:
* Rework Debugger class a bit to ease integration
* Expand TeamDebugger::Listener interface to notify start event too.
* Former RunningTeamsWindow, now name TeamsWindow, is shown at start
if no team/program to launch is specified.
* Double-clicking a team item in this list starts a new Team debugger, or
reactivate the existing one if any

This window settings is not yet integrated with the SettingsManager.
Will comes next.
I plan to add some UI controls to this Teams window to allow user to setup
a program arguments and environment variables and then launch & debug it.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38758 a95241bf-73f2-0310-859d-f6bbb57e9c96