Fix various instances of -Wset-but-unused.

Largely no functional change; most of these are just
removing the unused variables.

apps: Convert to using Set*UIColor.

Signed-off-by: Augustin Cavalier <waddlesplash@gmail.com>
Patches 0045-0075, 0077-0087 from looncraz, unmodified.

Debugger: Fix edit mode redraw issue.

MemoryView:
- During edit mode, if navigating with the left or right arrow
only resulted adjusting the focus nybble and not transitioning
to another block, redraw wouldn't be triggered, leading to it appearing
as if the keypress had no effect.

Debugger: Fix uninitialized variable.

MemoryView:
- fTrackingMouse wasn't being initialized in the constructor, which would
lead to the memory view sometimes thinking it was in mouse tracking mode
immediately when opened.

Debugger: Add edit mode support to MemoryView.

MemoryView:
- Add hooks and supporting status tracking members to enable edit mode.
When editing is requested, we allocate a duplicate copy of the current
block's data to perform edits in. Currently, editing is only supported from
within the hex view, and when edit mode is enabled, the view is locked to
8-bit hex mode in order to avoid any possible confusion with regards to
source vs target endian orientation.
- Extend Draw() to determine whether to write data from the edit data store
or the actual memory block. Also implement highlighting the current edit
position caret when in edit mode, as well as highlighting bytes that have
been changed compared to the block's original data.

Debugger: Fix MemoryView layout issues.

MemoryView:
- Implement {Min,Max,Preferred}Size() hooks. The default BView
versions were causing the inspector to sometimes not be properly
resizable after previous settings were restored.

Debugger: Fix #11430.

InspectorWindow:
- Inherit from Team::Listener and implement hook for thread state
change events.
- On thread state change, if the new state is stopped, and we have
an active block, release it, and ask to re-inspect.
- Factor out helper function for updating the active block.
- Always ensure the MemoryView is updated when we change blocks.

MemoryView:
- Clean up acquisition of target memory block.

This ensures that the block data is kept up to date when stepping
through code with an inspector window open.

Fix debugger only displaying 16 bits of 64-bit integers in the memory inspector

Signed-off-by: Oliver Tappe <zooey@hirschkaefer.de>

Debugger: Fix #10781.

- Don't attempt to calculate a selection region if we don't currently have a
valid target block. Should fix remaining part of #10781.

Debugger: Fix crash in Inspector.

- If a selection was active, and the hex mode was switched to not
display, a divide by zero crash would occur. Spotted by Olivier Coursiere.

Debugger: MemoryView - Tweak target address drawing.

- Since we actually draw a selection now, change the target address
highlight to clearly distinguish it. Rather than inverting it, it's
now drawn with a normal background and red text in the hex display.
The text mode subcomponent still shows it as an invert though, since
the latter doesn't currently indicate the selection.

Debugger: Fix calculation in MemoryView.

- The offset calculation for mapping the current point wasn't taking
into account the number of bytes per hex block, causing it to be
proportionally further off if one switched to 16/32/64-bit hex mode.

Gets mouse selection working properly in said modes.

Fix gcc2 build.

Fix previous format problem more correctly.

Thanks Ingo, Oliver and Ithamar for the hint.

Debugger: Fix data copy issue.
- B_PRIx8 unfortunately doesn't necessarily strictly stay within the bounds
of an 8-bit hex constant, so force the size passed to snprintf to make it
that way.

Build fix.

Debugger: Add selection support to MemoryView.

- The Inspector's memory view now supports selecting chunks of the hex display in
the manner one would in a TextView. The selection can also be copied to the clipboard,
or if it matches the size of a target address, can be used as input for an address to
inspect directly.

Still needs some fine tuning, but basically works.

Debugger: MemoryView - Tweak target address drawing.

- Since we actually draw a selection now, change the target address
highlight to clearly distinguish it. Rather than inverting it, it's
now drawn with a normal background and red text in the hex display.
The text mode subcomponent still shows it as an invert though, since
the latter doesn't currently indicate the selection.

Debugger: Fix calculation in MemoryView.

- The offset calculation for mapping the current point wasn't taking
into account the number of bytes per hex block, causing it to be
proportionally further off if one switched to 16/32/64-bit hex mode.

Gets mouse selection working properly in said modes.

Fix gcc2 build.

Fix previous format problem more correctly.

Thanks Ingo, Oliver and Ithamar for the hint.

Debugger: Fix data copy issue.
- B_PRIx8 unfortunately doesn't necessarily strictly stay within the bounds
of an 8-bit hex constant, so force the size passed to snprintf to make it
that way.

Build fix.

Debugger: Add selection support to MemoryView.

- The Inspector's memory view now supports selecting chunks of the hex display in
the manner one would in a TextView. The selection can also be copied to the clipboard,
or if it matches the size of a target address, can be used as input for an address to
inspect directly.

Still needs some fine tuning, but basically works.

Add listener interface to MemoryView.

- When the target address of the memory view changes, an attached
listener is now notified. This lets the inspector window's text input
keep in sync with the current address when keyboard navigating the
memory view.

Take target address size into account in MemoryView, fixes #9307.

Debugger (and some friends): 64 bit fixes

Make the memory view properly handle the target address size.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42255 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Cleanups.
* Add support for keyboard navigation to the memory view.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42246 a95241bf-73f2-0310-859d-f6bbb57e9c96

Add support for byte swapping to the memory inspector.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42238 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Add previous/next block navigation buttons.
* Fix a calculation error with respect to the last line of the block.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42216 a95241bf-73f2-0310-859d-f6bbb57e9c96

Align the text section's highlight correctly.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42214 a95241bf-73f2-0310-859d-f6bbb57e9c96

Implement scrolling to the target address.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42213 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Re-enable 64-bit representation.
* Clean up various drawing issues in the memory view's rendering code that were
causing scrolling artifacts.
* Fix stupid mistake whereby the data being visualized was in fact from the
Debugger's address space, and not the target team's. This would likely also
have caused some crashes.
* Highlight the data pointed to by the current target address.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42212 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Refactored MemoryView to be more flexible ; it can now show a configurable
choice of hexadecimal and/or character displays of the memory data, with
different digit grouping sizes. Still needs some work but is basically
functional.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42204 a95241bf-73f2-0310-859d-f6bbb57e9c96

* fix build of Debugger with gcc2

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42197 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fix off by one error that resulted in the first line of data being
rendered offscreen.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42171 a95241bf-73f2-0310-859d-f6bbb57e9c96

More cleanups. Scrolling draws correctly now.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42170 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fix buffer size.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42169 a95241bf-73f2-0310-859d-f6bbb57e9c96

Slight cleanup.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42168 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Move expression evaluation to the inspector window.
* Actually start rendering the memory data. Still has some drawing glitches
when scrolling though, will look into those tomorrow. Also doesn't yet
highlight the location which the target address actually points to within
the block.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42167 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Introduce TeamMemoryBlock[Manager]. These provide an interface to raw memory
page data of the target team.
* Jobs: Add RetrieveMemoryBlockJob which performs a background read of the
target team's memory. Used by InspectRequested() to perform the actual work.
* TeamDebugger: Added InspectRequested() hooks to allow clients to ask for
a memory read to be performed.
* Introduce InspectorWindow and MemoryView to form the basis of a memory inspector.
As yet these are more or less stubs and not yet hooked in.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42080 a95241bf-73f2-0310-859d-f6bbb57e9c96

Debugger: Fix edit mode redraw issue.

MemoryView:
- During edit mode, if navigating with the left or right arrow
only resulted adjusting the focus nybble and not transitioning
to another block, redraw wouldn't be triggered, leading to it appearing
as if the keypress had no effect.

Debugger: Fix uninitialized variable.

MemoryView:
- fTrackingMouse wasn't being initialized in the constructor, which would
lead to the memory view sometimes thinking it was in mouse tracking mode
immediately when opened.

Debugger: Add edit mode support to MemoryView.

MemoryView:
- Add hooks and supporting status tracking members to enable edit mode.
When editing is requested, we allocate a duplicate copy of the current
block's data to perform edits in. Currently, editing is only supported from
within the hex view, and when edit mode is enabled, the view is locked to
8-bit hex mode in order to avoid any possible confusion with regards to
source vs target endian orientation.
- Extend Draw() to determine whether to write data from the edit data store
or the actual memory block. Also implement highlighting the current edit
position caret when in edit mode, as well as highlighting bytes that have
been changed compared to the block's original data.

Debugger: Fix MemoryView layout issues.

MemoryView:
- Implement {Min,Max,Preferred}Size() hooks. The default BView
versions were causing the inspector to sometimes not be properly
resizable after previous settings were restored.

Debugger: Fix #11430.

InspectorWindow:
- Inherit from Team::Listener and implement hook for thread state
change events.
- On thread state change, if the new state is stopped, and we have
an active block, release it, and ask to re-inspect.
- Factor out helper function for updating the active block.
- Always ensure the MemoryView is updated when we change blocks.

MemoryView:
- Clean up acquisition of target memory block.

This ensures that the block data is kept up to date when stepping
through code with an inspector window open.

Fix debugger only displaying 16 bits of 64-bit integers in the memory inspector

Signed-off-by: Oliver Tappe <zooey@hirschkaefer.de>

Debugger: Fix #10781.

- Don't attempt to calculate a selection region if we don't currently have a
valid target block. Should fix remaining part of #10781.

Debugger: Fix crash in Inspector.

- If a selection was active, and the hex mode was switched to not
display, a divide by zero crash would occur. Spotted by Olivier Coursiere.

Debugger: MemoryView - Tweak target address drawing.

- Since we actually draw a selection now, change the target address
highlight to clearly distinguish it. Rather than inverting it, it's
now drawn with a normal background and red text in the hex display.
The text mode subcomponent still shows it as an invert though, since
the latter doesn't currently indicate the selection.

Debugger: Fix calculation in MemoryView.

- The offset calculation for mapping the current point wasn't taking
into account the number of bytes per hex block, causing it to be
proportionally further off if one switched to 16/32/64-bit hex mode.

Gets mouse selection working properly in said modes.

Fix gcc2 build.

Fix previous format problem more correctly.

Thanks Ingo, Oliver and Ithamar for the hint.

Debugger: Fix data copy issue.
- B_PRIx8 unfortunately doesn't necessarily strictly stay within the bounds
of an 8-bit hex constant, so force the size passed to snprintf to make it
that way.

Build fix.

Debugger: Add selection support to MemoryView.

- The Inspector's memory view now supports selecting chunks of the hex display in
the manner one would in a TextView. The selection can also be copied to the clipboard,
or if it matches the size of a target address, can be used as input for an address to
inspect directly.

Still needs some fine tuning, but basically works.

Debugger: MemoryView - Tweak target address drawing.

- Since we actually draw a selection now, change the target address
highlight to clearly distinguish it. Rather than inverting it, it's
now drawn with a normal background and red text in the hex display.
The text mode subcomponent still shows it as an invert though, since
the latter doesn't currently indicate the selection.

Debugger: Fix calculation in MemoryView.

- The offset calculation for mapping the current point wasn't taking
into account the number of bytes per hex block, causing it to be
proportionally further off if one switched to 16/32/64-bit hex mode.

Gets mouse selection working properly in said modes.

Fix gcc2 build.

Fix previous format problem more correctly.

Thanks Ingo, Oliver and Ithamar for the hint.

Debugger: Fix data copy issue.
- B_PRIx8 unfortunately doesn't necessarily strictly stay within the bounds
of an 8-bit hex constant, so force the size passed to snprintf to make it
that way.

Build fix.

Debugger: Add selection support to MemoryView.

- The Inspector's memory view now supports selecting chunks of the hex display in
the manner one would in a TextView. The selection can also be copied to the clipboard,
or if it matches the size of a target address, can be used as input for an address to
inspect directly.

Still needs some fine tuning, but basically works.

Add listener interface to MemoryView.

- When the target address of the memory view changes, an attached
listener is now notified. This lets the inspector window's text input
keep in sync with the current address when keyboard navigating the
memory view.

Take target address size into account in MemoryView, fixes #9307.

Debugger (and some friends): 64 bit fixes

Make the memory view properly handle the target address size.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42255 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Cleanups.
* Add support for keyboard navigation to the memory view.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42246 a95241bf-73f2-0310-859d-f6bbb57e9c96

Add support for byte swapping to the memory inspector.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42238 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Add previous/next block navigation buttons.
* Fix a calculation error with respect to the last line of the block.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42216 a95241bf-73f2-0310-859d-f6bbb57e9c96

Align the text section's highlight correctly.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42214 a95241bf-73f2-0310-859d-f6bbb57e9c96

Implement scrolling to the target address.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42213 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Re-enable 64-bit representation.
* Clean up various drawing issues in the memory view's rendering code that were
causing scrolling artifacts.
* Fix stupid mistake whereby the data being visualized was in fact from the
Debugger's address space, and not the target team's. This would likely also
have caused some crashes.
* Highlight the data pointed to by the current target address.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42212 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Refactored MemoryView to be more flexible ; it can now show a configurable
choice of hexadecimal and/or character displays of the memory data, with
different digit grouping sizes. Still needs some work but is basically
functional.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42204 a95241bf-73f2-0310-859d-f6bbb57e9c96

* fix build of Debugger with gcc2

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42197 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fix off by one error that resulted in the first line of data being
rendered offscreen.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42171 a95241bf-73f2-0310-859d-f6bbb57e9c96

More cleanups. Scrolling draws correctly now.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42170 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fix buffer size.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42169 a95241bf-73f2-0310-859d-f6bbb57e9c96

Slight cleanup.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42168 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Move expression evaluation to the inspector window.
* Actually start rendering the memory data. Still has some drawing glitches
when scrolling though, will look into those tomorrow. Also doesn't yet
highlight the location which the target address actually points to within
the block.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42167 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Introduce TeamMemoryBlock[Manager]. These provide an interface to raw memory
page data of the target team.
* Jobs: Add RetrieveMemoryBlockJob which performs a background read of the
target team's memory. Used by InspectRequested() to perform the actual work.
* TeamDebugger: Added InspectRequested() hooks to allow clients to ask for
a memory read to be performed.
* Introduce InspectorWindow and MemoryView to form the basis of a memory inspector.
As yet these are more or less stubs and not yet hooked in.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42080 a95241bf-73f2-0310-859d-f6bbb57e9c96