BootManager: fix usage of BPartition::ContentName()

This one got changed in hrev56463. Fixes #17969.

Credit for the proper fix: Jérôme Duval.

Change-Id: Ia7ab07573538031f4794efce9e0feba37b7b9bda
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5714
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>

BootManager: Lock installation to "Intel" partition types only.

It seems no other OS calls these "Intel" partition types, but instead
MBR partition types. Perhaps we should change this, too?

At any rate, this solves #13260 by blocking installation on GPT
drives altogether.

BootManager: Take explicit instead of implicit reference.

Passing a type& to a va-args turns it into a pointer as per
the Itanium ABI; but we shouldn't rely on such trickery.
Explicitly capture a reference to it instead.

BootManager Disallow install to read-only drive (Bug #14596 & Bug #7200)

* Test for read-only devices during drive scan
if read-only detected, flag it in ui and disallow installation

Change-Id: Idd9e8e94d4a4840df97939154e1bbec70d0c0ece
Reviewed-on: https://review.haiku-os.org/c/1026
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
Reviewed-by: Axel Dörfler <axeld@pinc-software.de>

BootManager: different error when no MBR is found

We were using the same "no space available" message used when the first
partition starts too early. Be more specific here to make it clearer
what the problem is.

Fixes #7087.

x86_64: Add BootManager, writembr

* Fix build of BootManager on x86_64 (signed vs unsigned error)
* Throw in writembr as it seems to build (untested)

More catalog-related cleanup.

* rename B_TRANSLATE_CONTEXT to B_TRANSLATION_CONTEXT and
B_TRANSLATE_WITH_CONTEXT to B_TRANSLATE_CONTEXT, squashing a TODO
* adjust all uses of both macros in Haiku's source tree
* use correct header guard for collecting/Catalog.h

The renamed macros require adjustments to all external applications
using catalogs.

* Removed no longer used TestBootDrive.* files.
* Added a comment to LegacyBootMenu.cpp on how to conveniently test the boot
manager, and its menu.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40151 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Changed bootman.S to use the BIOS provided drive to stage load itself, as well
as when the boot menu entry has a 0 BIOS drive. This allows the boot loader to
be installed on any drive.
* Implemented BootDrive class, and changed LegacyBootMenu the way it should
work now. Installing the boot menu should now work again, and the first time
while installing Haiku.
* Removed MakeArray.cpp - we already have such a tool in our repository.
* Build BootLoader.h automatically during the build process - the only
disadvantage is that you can only build it on x86 now (but other systems
don't use this boot loader, anyway).
* In general, the BootManager is prepared to handle different kinds of boot
menus; one only needs to write a class BootMenu implementation for this to
work - and have the possibility to choose between different menus, if there
are more than one per platform/partitioning system.
* Renamed quite a few methods.
* Automatic whitespace cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40149 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Work in progress of being able to choose the drive to install the menu to.
Note, the BootManager might not work right now, anymore.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40130 a95241bf-73f2-0310-859d-f6bbb57e9c96

BootManager: different error when no MBR is found

We were using the same "no space available" message used when the first
partition starts too early. Be more specific here to make it clearer
what the problem is.

Fixes #7087.

x86_64: Add BootManager, writembr

* Fix build of BootManager on x86_64 (signed vs unsigned error)
* Throw in writembr as it seems to build (untested)

More catalog-related cleanup.

* rename B_TRANSLATE_CONTEXT to B_TRANSLATION_CONTEXT and
B_TRANSLATE_WITH_CONTEXT to B_TRANSLATE_CONTEXT, squashing a TODO
* adjust all uses of both macros in Haiku's source tree
* use correct header guard for collecting/Catalog.h

The renamed macros require adjustments to all external applications
using catalogs.

* Removed no longer used TestBootDrive.* files.
* Added a comment to LegacyBootMenu.cpp on how to conveniently test the boot
manager, and its menu.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40151 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Changed bootman.S to use the BIOS provided drive to stage load itself, as well
as when the boot menu entry has a 0 BIOS drive. This allows the boot loader to
be installed on any drive.
* Implemented BootDrive class, and changed LegacyBootMenu the way it should
work now. Installing the boot menu should now work again, and the first time
while installing Haiku.
* Removed MakeArray.cpp - we already have such a tool in our repository.
* Build BootLoader.h automatically during the build process - the only
disadvantage is that you can only build it on x86 now (but other systems
don't use this boot loader, anyway).
* In general, the BootManager is prepared to handle different kinds of boot
menus; one only needs to write a class BootMenu implementation for this to
work - and have the possibility to choose between different menus, if there
are more than one per platform/partitioning system.
* Renamed quite a few methods.
* Automatic whitespace cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40149 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Work in progress of being able to choose the drive to install the menu to.
Note, the BootManager might not work right now, anymore.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40130 a95241bf-73f2-0310-859d-f6bbb57e9c96