translators/gif: Fix mismatching malloc/delete

fHeadMemblock is allocated by malloc() in MemblockAllocate(),
but freed by delete.
Pointed out by LGTM.

Change-Id: I5019c2c3e4d240051e6f8a1ac70a9738f6f97131
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1878
Reviewed-by: Axel Dörfler <axeld@pinc-software.de>

GIF Translator: tiny style fix

GIFTranslator: Return false if read fails

GIFTranslator: Whitespace style fixes

Also remove break in last case.

GIFTranslator: try hard to not throw an exception

... by calling new(std::nothrow)

Also try really hard not to leak any memory in the process.

Lots of error checking added to check if reads and writes fail
returning B_IO_ERROR and if initialization fails returning B_NO_MEMORY

GIFTranslator: Reorder includes

Thanks Jérôme

GIFTranslator: error if out of bounds

Error out if we're trying to access an out-of-bounds array index
(which should never happen, but let's check just in case.)

GIFTranslator: rename cs and size to codeSize

GIFTranslator: Read the left and top image coordinates

GIFTranslator: Replace magic constants

Introduce GIFPrivate.h to define these magic constants

Also, make sure that we don't go over LZ_MAX_CODE bits

GIFTranslator: check if NULL before accessing member

GIFTranslator: use ENTRY_COUNT define instead of 4096

GIFTranslator: Use array notation instead of pointer

GIFTranslator: Log info messages with LOG_INFO not LOG_ERR

GIFTranslator: Style change, uchar => unsigned char

GIFTranslator: don't call an implicit constructor for Memblock

GIFTranslator: Style fixes

Fix #9487: GIFLoad array subscript below array bounds

Recently enabled variable range propagation enables GCC to among others analyze
whether array subscript is in a valid range. While being quite useful this
particular feature also happens to produce false positives. This is merely
a workaround to make compiler happy.

The actual reason why compiler is reporting false positive is that array is
indexed with a signed integer and it is not clear for compiler what value it may
have due to it being a member of the class and and external procedure being
invoked between its initialization and usage.

Applied following patches proposed by Jorma Karvonen:
#7135 #7140 #7141 #7145 #7186 #7188 #7191
#7136 #7187 #7184 #7185 #7192 #7138 #7139

with some changes and exclusions:
- all attempts to localize "fprintf(stderr,..." and "printf(..."
replaced by _untranslated_ "syslog(LOG_ERR ...";
- following *Translator.rdef files, that were not added in mentioned patches
were additionally created:
SGI, TIFF, RAW, RTF, PPM, WebP, EXR, STXT, WonderBrush, GIF, TGA;
- some small fixes for consistent catalogs building.

Thank you, Jorma! Please check. ;-)



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40357 a95241bf-73f2-0310-859d-f6bbb57e9c96

use defines for some gif flags, for clearer code. Reordered initializers to avoid warnings.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27633 a95241bf-73f2-0310-859d-f6bbb57e9c96

Other small style changes

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27519 a95241bf-73f2-0310-859d-f6bbb57e9c96

set fScanLine to NULL after freeing it.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27518 a95241bf-73f2-0310-859d-f6bbb57e9c96

more style changes

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27517 a95241bf-73f2-0310-859d-f6bbb57e9c96

Style changes. No functional change

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27516 a95241bf-73f2-0310-859d-f6bbb57e9c96

removed the redundant "translator" from the folder names, fixed some warnings in the JPEG2000Translator

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@14449 a95241bf-73f2-0310-859d-f6bbb57e9c96

GIF Translator: tiny style fix

GIFTranslator: Return false if read fails

GIFTranslator: Whitespace style fixes

Also remove break in last case.

GIFTranslator: try hard to not throw an exception

... by calling new(std::nothrow)

Also try really hard not to leak any memory in the process.

Lots of error checking added to check if reads and writes fail
returning B_IO_ERROR and if initialization fails returning B_NO_MEMORY

GIFTranslator: Reorder includes

Thanks Jérôme

GIFTranslator: error if out of bounds

Error out if we're trying to access an out-of-bounds array index
(which should never happen, but let's check just in case.)

GIFTranslator: rename cs and size to codeSize

GIFTranslator: Read the left and top image coordinates

GIFTranslator: Replace magic constants

Introduce GIFPrivate.h to define these magic constants

Also, make sure that we don't go over LZ_MAX_CODE bits

GIFTranslator: check if NULL before accessing member

GIFTranslator: use ENTRY_COUNT define instead of 4096

GIFTranslator: Use array notation instead of pointer

GIFTranslator: Log info messages with LOG_INFO not LOG_ERR

GIFTranslator: Style change, uchar => unsigned char

GIFTranslator: don't call an implicit constructor for Memblock

GIFTranslator: Style fixes

Fix #9487: GIFLoad array subscript below array bounds

Recently enabled variable range propagation enables GCC to among others analyze
whether array subscript is in a valid range. While being quite useful this
particular feature also happens to produce false positives. This is merely
a workaround to make compiler happy.

The actual reason why compiler is reporting false positive is that array is
indexed with a signed integer and it is not clear for compiler what value it may
have due to it being a member of the class and and external procedure being
invoked between its initialization and usage.

Applied following patches proposed by Jorma Karvonen:
#7135 #7140 #7141 #7145 #7186 #7188 #7191
#7136 #7187 #7184 #7185 #7192 #7138 #7139

with some changes and exclusions:
- all attempts to localize "fprintf(stderr,..." and "printf(..."
replaced by _untranslated_ "syslog(LOG_ERR ...";
- following *Translator.rdef files, that were not added in mentioned patches
were additionally created:
SGI, TIFF, RAW, RTF, PPM, WebP, EXR, STXT, WonderBrush, GIF, TGA;
- some small fixes for consistent catalogs building.

Thank you, Jorma! Please check. ;-)



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40357 a95241bf-73f2-0310-859d-f6bbb57e9c96

use defines for some gif flags, for clearer code. Reordered initializers to avoid warnings.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27633 a95241bf-73f2-0310-859d-f6bbb57e9c96

Other small style changes

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27519 a95241bf-73f2-0310-859d-f6bbb57e9c96

set fScanLine to NULL after freeing it.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27518 a95241bf-73f2-0310-859d-f6bbb57e9c96

more style changes

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27517 a95241bf-73f2-0310-859d-f6bbb57e9c96

Style changes. No functional change

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27516 a95241bf-73f2-0310-859d-f6bbb57e9c96

removed the redundant "translator" from the folder names, fixed some warnings in the JPEG2000Translator

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@14449 a95241bf-73f2-0310-859d-f6bbb57e9c96