History log of /haiku/src/add-ons/screen_savers/message/Message.cpp
Revision Date Author Comments
# eeff891b 24-Apr-2020 X512 <danger_mail@list.ru>

Message screensaver: style fixes

Change-Id: Ifd910a517411e888eaee0efda2fa18838a1023d7
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2513
Reviewed-by: waddlesplash <waddlesplash@gmail.com>


# 3ed66caf 22-Mar-2020 X512 <danger_mail@list.ru>

Message screensaver: fix array delete[] problem on clang, style fixes

Change-Id: Ic0182e81e9267c69b92ed60a85026eb45cda3a2d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2407
Reviewed-by: waddlesplash <waddlesplash@gmail.com>


# 8ff74b67 28-Oct-2018 Murai Takashi <tmurai01@gmail.com>

screen_savers/message: Use delete[] instead of delete

Use delete[] instead of delete, since memory is allocated by new[]
at line 139.

Pointed out by clang.

Change-Id: I70396283b8d2c01d52886f7543804998d891ea44
Reviewed-on: https://review.haiku-os.org/646
Reviewed-by: waddlesplash <waddlesplash@gmail.com>


# e9208b68 13-Apr-2016 John Scipione <jscipione@gmail.com>

ScreenSaver: Rename BuildScreenSaverDefaultSettingsView

...to just DefaultSettingsView

It is just as obvious what it does in context, but shorter.

Rename the function it contains from
BuildDefaultScreenSaverSettingsView to
BuildDefaultSettingsView


# 8e887ea2 23-Jan-2014 Jérôme Duval <jerome.duval@gmail.com>

Message: use BString.Split().

Could help with #10209.


# a1e717b8 20-Dec-2013 John Scipione <jscipione@gmail.com>

Fix crash in Message Screensaver

In the Draw() method check to make sure that the view is valid, is
connected to the window, that the window is locked, that the screen
is valid and that the BBitmap buffer is valid. This (hopefully) fixes the
last of the bugs experienced due to #4260.

It is not sufficient to just check that the view is valid to prevent the crash,
you must also check that it is connected to a window via Window() and
that the window is locked.


# 68aca9a4 17-Jul-2013 Philippe Saint-Pierre <stpere@gmail.com>

Message screensaver: memory leak fix - CID 601698


# fa30ef56 17-Jul-2013 Philippe Saint-Pierre <stpere@gmail.com>

Message screensaver: close pipe with pclose - CID 990944


# 2e1347b2 29-Apr-2013 Murai Takashi <tmurai01@gmail.com>

Fix more GCC4 narrowing conversion warnings

Signed-off-by: Jérôme Duval <jerome.duval@gmail.com>


# 546208a5 16-Apr-2012 Oliver Tappe <zooey@hirschkaefer.de>

More catalog-related cleanup.

* rename B_TRANSLATE_CONTEXT to B_TRANSLATION_CONTEXT and
B_TRANSLATE_WITH_CONTEXT to B_TRANSLATE_CONTEXT, squashing a TODO
* adjust all uses of both macros in Haiku's source tree
* use correct header guard for collecting/Catalog.h

The renamed macros require adjustments to all external applications
using catalogs.


# 044f12ae 06-Mar-2011 Joachim Seemer <humdingerb@googlemail.com>

Localization of screensavers. Fixes #7326.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40848 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 5e819d74 07-Aug-2010 Jérôme Duval <korli@users.berlios.de>

CID 1464: Delete an array with delete[]


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37963 a95241bf-73f2-0310-859d-f6bbb57e9c96


# edbcbaa6 01-Oct-2009 Ryan Leavengood <leavengood@gmail.com>

Updated the screensavers Haiku, Icons and Message to use the new default
settings view function.
Also some clean-up.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33405 a95241bf-73f2-0310-859d-f6bbb57e9c96


# bdffbce7 09-Dec-2008 Rene Gollent <anevilyak@gmail.com>

Adjust ScreenSaverRunner to make the screen saver draw once before sleeping. This fixes the perceived black screen problem with the Message screensaver. Also cleaned up Message slightly to retrieve its string from fortune more cleanly, and readded it to the build since it will no longer deadlock the screensaver module for 30 seconds at a time.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28793 a95241bf-73f2-0310-859d-f6bbb57e9c96


# ade73e8c 10-Nov-2008 Ryan Leavengood <leavengood@gmail.com>

Make the BObjectList member for font families a non-pointer.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28596 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 8a33d611 09-Nov-2008 Ryan Leavengood <leavengood@gmail.com>

Use BObjectList instead of BList.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28586 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 96493dca 07-Jun-2007 Ryan Leavengood <leavengood@gmail.com>

Better name: result becomes lines.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@21348 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 26c1085f 07-Jun-2007 Ryan Leavengood <leavengood@gmail.com>

Inspired by Daniel Sandler's Mac OS X recreation of Message, I've added a
little rounded box on the bottom with the full message in it.

Given that currently this version only uses fortune to get it's message this
allows maximum enjoyment of the little anecdotes and jokes provided by fortune.
Though after testing this 60+ times today I'm starting to get sick of fortunes.

I've implemented everything myself here, including breaking the string up on
newlines and drawing each line of text with the right vertical spacing. I
suppose some clever use of BTextView would have been better. But this works
fine and wasn't that much code.

I'm not sure if this was the most productive use of the last 5 hours, but I
learned quite a bit.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@21347 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 406228de 29-May-2007 Stephan Aßmus <superstippi@gmx.de>

* don't turn off anti-aliasing
* use B_OP_OVER in order to do anti-aliasing with the real background



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@21275 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 41ecd349 01-Feb-2007 Ryan Leavengood <leavengood@gmail.com>

Another recreation of a favorite BeOS screensaver of mine: Message, originally
by Jon Watte.

This was a tough but interesting problem. My version still isn't quite as nice
as his. I think the color generation could be improved, and I KNOW the x and y
placement of the text could be improved.

I also think it would be nice to display the full message at the bottom of the
screen (similar to ShowImage showing the file type and name in full screen
mode.)

But this is a good base to work from.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20035 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 8e887ea2444c49fea9576a21dff916444c265512 23-Jan-2014 Jérôme Duval <jerome.duval@gmail.com>

Message: use BString.Split().

Could help with #10209.


# a1e717b8f72104ba9768ba1ea6e8d1b610b7818e 20-Dec-2013 John Scipione <jscipione@gmail.com>

Fix crash in Message Screensaver

In the Draw() method check to make sure that the view is valid, is
connected to the window, that the window is locked, that the screen
is valid and that the BBitmap buffer is valid. This (hopefully) fixes the
last of the bugs experienced due to #4260.

It is not sufficient to just check that the view is valid to prevent the crash,
you must also check that it is connected to a window via Window() and
that the window is locked.


# 68aca9a47756561c97fcb5676eb13db40568f4b2 17-Jul-2013 Philippe Saint-Pierre <stpere@gmail.com>

Message screensaver: memory leak fix - CID 601698


# fa30ef56404468f18e01995f499b9466e6ab22f4 17-Jul-2013 Philippe Saint-Pierre <stpere@gmail.com>

Message screensaver: close pipe with pclose - CID 990944


# 2e1347b2bfc34f47f20174ae1112d7b4f774ae48 29-Apr-2013 Murai Takashi <tmurai01@gmail.com>

Fix more GCC4 narrowing conversion warnings

Signed-off-by: Jérôme Duval <jerome.duval@gmail.com>


# 546208a53940a26c6379c48a7854ade1a8250fc5 16-Apr-2012 Oliver Tappe <zooey@hirschkaefer.de>

More catalog-related cleanup.

* rename B_TRANSLATE_CONTEXT to B_TRANSLATION_CONTEXT and
B_TRANSLATE_WITH_CONTEXT to B_TRANSLATE_CONTEXT, squashing a TODO
* adjust all uses of both macros in Haiku's source tree
* use correct header guard for collecting/Catalog.h

The renamed macros require adjustments to all external applications
using catalogs.


# 044f12ae62ec55b96597670cce5635f79dcc4526 06-Mar-2011 Joachim Seemer <humdingerb@googlemail.com>

Localization of screensavers. Fixes #7326.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40848 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 5e819d74ddf01e4c61a98efecb424d0eefc6229a 07-Aug-2010 Jérôme Duval <korli@users.berlios.de>

CID 1464: Delete an array with delete[]


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37963 a95241bf-73f2-0310-859d-f6bbb57e9c96


# edbcbaa6317a2fa5905f71b6b9f40dab7e9c5dda 01-Oct-2009 Ryan Leavengood <leavengood@gmail.com>

Updated the screensavers Haiku, Icons and Message to use the new default
settings view function.
Also some clean-up.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33405 a95241bf-73f2-0310-859d-f6bbb57e9c96


# bdffbce7af2ff1016e0af243970646c7c4e0d729 09-Dec-2008 Rene Gollent <anevilyak@gmail.com>

Adjust ScreenSaverRunner to make the screen saver draw once before sleeping. This fixes the perceived black screen problem with the Message screensaver. Also cleaned up Message slightly to retrieve its string from fortune more cleanly, and readded it to the build since it will no longer deadlock the screensaver module for 30 seconds at a time.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28793 a95241bf-73f2-0310-859d-f6bbb57e9c96


# ade73e8c851b39f043d5211a44d9f3c6d849a242 10-Nov-2008 Ryan Leavengood <leavengood@gmail.com>

Make the BObjectList member for font families a non-pointer.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28596 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 8a33d6112340340ea2eb5bf5069d3f437a203b26 09-Nov-2008 Ryan Leavengood <leavengood@gmail.com>

Use BObjectList instead of BList.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28586 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 96493dcae9e7b3cc99977b052d95f70e192dd567 07-Jun-2007 Ryan Leavengood <leavengood@gmail.com>

Better name: result becomes lines.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@21348 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 26c1085f1b7300676f83e29f6a13da6036af1f17 07-Jun-2007 Ryan Leavengood <leavengood@gmail.com>

Inspired by Daniel Sandler's Mac OS X recreation of Message, I've added a
little rounded box on the bottom with the full message in it.

Given that currently this version only uses fortune to get it's message this
allows maximum enjoyment of the little anecdotes and jokes provided by fortune.
Though after testing this 60+ times today I'm starting to get sick of fortunes.

I've implemented everything myself here, including breaking the string up on
newlines and drawing each line of text with the right vertical spacing. I
suppose some clever use of BTextView would have been better. But this works
fine and wasn't that much code.

I'm not sure if this was the most productive use of the last 5 hours, but I
learned quite a bit.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@21347 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 406228de63a6d48ced9fea0d72e1267ce5f89294 29-May-2007 Stephan Aßmus <superstippi@gmx.de>

* don't turn off anti-aliasing
* use B_OP_OVER in order to do anti-aliasing with the real background



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@21275 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 41ecd34905d82698d3386ac3938184696447aff6 01-Feb-2007 Ryan Leavengood <leavengood@gmail.com>

Another recreation of a favorite BeOS screensaver of mine: Message, originally
by Jon Watte.

This was a tough but interesting problem. My version still isn't quite as nice
as his. I think the color generation could be improved, and I KNOW the x and y
placement of the text could be improved.

I also think it would be nice to display the full message at the bottom of the
screen (similar to ShowImage showing the file type and name in full screen
mode.)

But this is a good base to work from.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20035 a95241bf-73f2-0310-859d-f6bbb57e9c96