icons screen saver: fix memory leak

Fix fBackBitmap and items of fVectorIcons were not released.

Change-Id: I8bf974a9f11852c4b1092490e699b46bd79997eb
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3879
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>

ScreenSaver: Rename BuildScreenSaverDefaultSettingsView

...to just DefaultSettingsView

It is just as obvious what it does in context, but shorter.

Rename the function it contains from
BuildDefaultScreenSaverSettingsView to
BuildDefaultSettingsView

icons screensaver: double free when in RandomSaver

RandomSaver apparently calls StopSaver two times, and Icons was having a
double free in that case.

Fixes #10957.

IconSaver: bump max icon count to 384

300 wasn’t enough

IconSaver: fix potential memory leak

delete icon doesn’t do anything, delete[] data does.

IconSaver: remove extra space

Icons Screensaver: Get icons from MIME db again

The previous method only queried application icons, not document icons.

Unfortunately, the app icons in the MIME DB are broken/not present.
IconsSaver only displays document icons for the time being.

Because of better error checking the garbled icons are filtered out though
at least.

Next step is to fix the application icons in the MIME DB.

Some other changes:
* Don't draw if the BBitmap was not filled out correctly
* Add Vincent Duvert to authors list, he's already in copyright
* Convert fVectorIcons from a BList to a BObjectList
* Put vector_icon struct in it’s own header (needed for above)
* Remove type param from vector_icon struct
* Bump max icon count to 300, hopefully this should be enough, 128
is too few for app and document icons in default install.

Icons Screensaver: Grab vector icons via query, fixes #10166

Iterate through each BFS volume and find vector icon data in apps
using a BFS query. Cap off at 128 total icons, we could get more if
desired. Default install comes with ~100 at present.

Make sure we have at least 20 icons (15 display at a time) before we
start drawing icons.

Rename VectorIcon to vector_icon and treat it like the POD struct that it is.
Also add a type_code parame to vector_icon that should be set to
B_VECTOR_ICON.

Some style fixes also included, e.g. turned defines into static const int32’s.

Icons Screensaver: Style fixes only

Icons Screensaver: Update copyright header and version

Add myself to authors, assign copyright to Haiku, Inc.

Bump version to 1.0.1-final, update short and long description

More catalog-related cleanup.

* rename B_TRANSLATE_CONTEXT to B_TRANSLATION_CONTEXT and
B_TRANSLATE_WITH_CONTEXT to B_TRANSLATE_CONTEXT, squashing a TODO
* adjust all uses of both macros in Haiku's source tree
* use correct header guard for collecting/Catalog.h

The renamed macros require adjustments to all external applications
using catalogs.

Localization of screensavers. Fixes #7326.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40848 a95241bf-73f2-0310-859d-f6bbb57e9c96

Updated the screensavers Haiku, Icons and Message to use the new default
settings view function.
Also some clean-up.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33405 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added a very nice Icons screensaver, by Vincent Duvert.
Thanks.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33268 a95241bf-73f2-0310-859d-f6bbb57e9c96

icons screensaver: double free when in RandomSaver

RandomSaver apparently calls StopSaver two times, and Icons was having a
double free in that case.

Fixes #10957.

IconSaver: bump max icon count to 384

300 wasn’t enough

IconSaver: fix potential memory leak

delete icon doesn’t do anything, delete[] data does.

IconSaver: remove extra space

Icons Screensaver: Get icons from MIME db again

The previous method only queried application icons, not document icons.

Unfortunately, the app icons in the MIME DB are broken/not present.
IconsSaver only displays document icons for the time being.

Because of better error checking the garbled icons are filtered out though
at least.

Next step is to fix the application icons in the MIME DB.

Some other changes:
* Don't draw if the BBitmap was not filled out correctly
* Add Vincent Duvert to authors list, he's already in copyright
* Convert fVectorIcons from a BList to a BObjectList
* Put vector_icon struct in it’s own header (needed for above)
* Remove type param from vector_icon struct
* Bump max icon count to 300, hopefully this should be enough, 128
is too few for app and document icons in default install.

Icons Screensaver: Grab vector icons via query, fixes #10166

Iterate through each BFS volume and find vector icon data in apps
using a BFS query. Cap off at 128 total icons, we could get more if
desired. Default install comes with ~100 at present.

Make sure we have at least 20 icons (15 display at a time) before we
start drawing icons.

Rename VectorIcon to vector_icon and treat it like the POD struct that it is.
Also add a type_code parame to vector_icon that should be set to
B_VECTOR_ICON.

Some style fixes also included, e.g. turned defines into static const int32’s.

Icons Screensaver: Style fixes only

Icons Screensaver: Update copyright header and version

Add myself to authors, assign copyright to Haiku, Inc.

Bump version to 1.0.1-final, update short and long description

More catalog-related cleanup.

* rename B_TRANSLATE_CONTEXT to B_TRANSLATION_CONTEXT and
B_TRANSLATE_WITH_CONTEXT to B_TRANSLATE_CONTEXT, squashing a TODO
* adjust all uses of both macros in Haiku's source tree
* use correct header guard for collecting/Catalog.h

The renamed macros require adjustments to all external applications
using catalogs.

Localization of screensavers. Fixes #7326.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40848 a95241bf-73f2-0310-859d-f6bbb57e9c96

Updated the screensavers Haiku, Icons and Message to use the new default
settings view function.
Also some clean-up.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33405 a95241bf-73f2-0310-859d-f6bbb57e9c96

Added a very nice Icons screensaver, by Vincent Duvert.
Thanks.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33268 a95241bf-73f2-0310-859d-f6bbb57e9c96