nfs4: fix gcc2 build

gcc2 preprocessor reads `__func__,` as one token, yielding
dprintf("nfs4: %s()" "whatever" "\n", );
and a parse error for the expansion of ERROR with only one parameter.
Separating the comma gives the result we want.

Change-Id: I5d20e2c06a796b7092b9f23162fa7bfb269318be
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3899
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>

nfs4: Improve tracing when DEBUG. Always show NFS errors

Change-Id: Idd6904258c479dc3d188bf245b1bae0d3849820b
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3397
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>

nfs4: Fix gIdMapper resource leak

Mounting another nfs4 volume loses reference to the previous idmapper
service. Thanks Stephan for pointing this out.

nfs4: Fix CID 1108337: Use AutoDeleter to fix leak

nfs4: Fix mismatching allocation and deallocation

Fixes CID #1108170.

Signed-off-by: Pawel Dziepak <pdziepak@quarnos.org>

nfs4: Ignore superfluous slashes and get proper NFS4 share name

nfs4: Fix CID #991617: Set cookie file system at its creation

nfs4: fix few issues related with file caches
* update metadata cache when writing to cache
* do not limit size of a io request
* minor checks in Inode::Write

nfs4: support hard links properly

The main purpose of this patch is to prevent VFS from removing a vnode to early
what might have happened if the NFS client knew it had more than one name but
then one of them was deleted. Moreover, all discovered and still valid names
are stored what may be useful in proper file handle recovery when they are
volatile.

This patch fixes both #9558 and #9561.

nfs4: update vnode objects and cached data when rename overrides a file
* this patch also fixes unnecessary cache invalidation when a file is renamed
without changing its parent directory

nfs4: Allow customization of DirectoryCache expiration time

nfs4: Fix CID 991506: memory leak in case of error

nfs4: Use B_PRI* instead of standard PRI*

nfs4: Fix compiler warning about optionsEnd being not initialized

nfs4: Fix wrong cast in nfs4_rename

nfs4: Make TRACE format strings 32/64 bit independent

nfs4: Support callbacks over IPv6

nfs4: Try connecting to all getaddrinfo() results before giving up

nfs4: Fix few Inode::fOpenState related race conditions

nfs4: Make request time limit adjustable

nfs4: Multiple style fixes

nfs4: Do not create new Inode object when deleting a vnode

nfs4: Fix problems with reading directory entries
* Inode::ReadDir missed an entry when given buffer was too small
* Each OpenDirCookie now has its own copy of directory snapshot what
would prevent Inode::ReadDir from accessing freed memory when removing
files and reading directory entries simultaneously
* Several minor issues fixed

nfs4: Release vnodes when no longer used

nfs4: Introduce VnodeToInode mapping

VnodeToInode is another abstraction layer between VFS vnodes and NFS nodes.
It simplifies dealing with race conditions as well as faking some guarantees
VFS expects but NFS does not provide.

nfs4: Fix race condition between inode creation and removal

If the underlying file system reuses inode numbers it is possible that
an entry of inode with reused id in InodeIdMap will be removed.
This patch should also improve behavior when one of many hard links
is removed.

nfs4: Add basic tracing of nfs4 module calls

nfs4: Add numerous assertion checks

nfs4: Do not ignore idmapper initialization errors

nfs4, dns_resolver: fix numerous style violations

nfs4: Update FileInfo at rename

nfs4: Fix node removal

nfs4: Make the client more configurable

nfs4: Let GenerateClientID take advantage of PeerAddress methods

nfs4: Add basic support for extended attributes

nfs4: Make idmapper initialization lazy

nfs4: Add attribute directory related hooks

nfs4: Fix dir cookie rewinding

nfs4: Add asynchronous work queue

nfs4: Support delegations of created files

nfs4: Do not sync too often if delegation is held

nfs4: Move cache management inside Inode class

nfs4: Use one open state per inode

nfs4: Add basic RPC level support for callbacks

nfs4: Do not open too much files on server

nfs4: Revalidate cache before locks

nfs4: Use existing write cookie, do not send COMMIT if not necessary

nfs4: Use unstable writes and commit before close

nfs4: Change write policy from write through to write back

nfs4: Basic data cache implementation

nfs4: Make networking code IP version agnostic

nfs4: Use IPPROTO_* instead of enum Transport

nfs4: Rename Filehandle to FileHandle and Filesystem to FileSystem

Move parsing getattrinfo() result out of dns_resolver module

nfs4: Add id mapper

nfs4: Do not get_vnode() if Inode::Create() failed

nfs4: Add full support for lease migration

nfs4: Do not release locks if cookie is NULL

nfs4: Add remove_vnode() hook

nfs4: Add stub fsync() hook

nfs4: Add support for file locking

nfs4: Add set_flags() hook

nfs4: Remove unused entries from inode number to filehandle map

nfs4: Add write_stat() hook

nfs4: Add create_dir() hook

nfs4: Add support for O_APPEND mode

nfs4: Fix cookie and vnode creation in create() hook

nfs4: Add write() hook

nfs4: Add create() hook

nfs4: Add create_symlink() hook

nfs4: Add link() hook

nfs4: unlink() and remove_dir() should check node type

nfs4: Add unlink() and remove_dir() hooks

nfs4: Add rename() hook

nfs4: close*() should wake all blocked operations

nfs4: Add support for server migration

nfs4: Parse command line args

Thist commit also makes inet_addr() accessible for the kernel and kernel modules.

nfs4: Allow opening symbolic links

nfs4: Add read_fs_info hook

nfs4: Add read_symlink() hook

nfs4: Add per server NFS4 objects

RPC::Server is now able to store RPC programs data.
NFS4Server objects are currently used mainly for managing client id.

nfs4: Fix timeout handling code

nfs4: Allow open() on directories

nfs4: Add access() hook

nfs4: k- variants of socket functions are not really needed

nfs4: Add close() and free_cookie() hooks

nfs4: Add read() hook

nfs4: Add open() hook

nfs4: Add get_vnode_name hook

nfs4: Inodes should know their name and parent's filehandle

nfs4: Add rewind_dir() hook

nfs4: Add lookup() and get_vnode() hooks

get_vnode() needs a way to retrieve filehandle knowing only inode number.
Since NFS4 sever does not provide such services client manages its own mapping
between ino_t and filehandles.

nfs4: The unary & operator is not really needed

nfs4: Add read_dir() hook

nfs4: Add open_dir, close_dir and free_dir_cookie hooks

nfs4: Add unmount() and put_vnode() procedures

nfs4: Add basic nfs4_read_stat() procedure

Not all data are retrieved and there is a room for improvement in handling
situations when server does not provide necessary information.

nfs4: Implement nfs4_mount() procedure

nfs4: Make mount() send null nfs4 call

nfs4: Add network code

Connection class supports sending and receiving RPC data using either
TCP or UDP as a transport protocol.

nfs4: Initial commit

Empty file system with only mounting supported.

nfs4: Fix gIdMapper resource leak

Mounting another nfs4 volume loses reference to the previous idmapper
service. Thanks Stephan for pointing this out.

nfs4: Fix CID 1108337: Use AutoDeleter to fix leak

nfs4: Fix mismatching allocation and deallocation

Fixes CID #1108170.

Signed-off-by: Pawel Dziepak <pdziepak@quarnos.org>

nfs4: Ignore superfluous slashes and get proper NFS4 share name

nfs4: Fix CID #991617: Set cookie file system at its creation

nfs4: fix few issues related with file caches
* update metadata cache when writing to cache
* do not limit size of a io request
* minor checks in Inode::Write

nfs4: support hard links properly

The main purpose of this patch is to prevent VFS from removing a vnode to early
what might have happened if the NFS client knew it had more than one name but
then one of them was deleted. Moreover, all discovered and still valid names
are stored what may be useful in proper file handle recovery when they are
volatile.

This patch fixes both #9558 and #9561.

nfs4: update vnode objects and cached data when rename overrides a file
* this patch also fixes unnecessary cache invalidation when a file is renamed
without changing its parent directory

nfs4: Allow customization of DirectoryCache expiration time

nfs4: Fix CID 991506: memory leak in case of error

nfs4: Use B_PRI* instead of standard PRI*

nfs4: Fix compiler warning about optionsEnd being not initialized

nfs4: Fix wrong cast in nfs4_rename

nfs4: Make TRACE format strings 32/64 bit independent

nfs4: Support callbacks over IPv6

nfs4: Try connecting to all getaddrinfo() results before giving up

nfs4: Fix few Inode::fOpenState related race conditions

nfs4: Make request time limit adjustable

nfs4: Multiple style fixes

nfs4: Do not create new Inode object when deleting a vnode

nfs4: Fix problems with reading directory entries
* Inode::ReadDir missed an entry when given buffer was too small
* Each OpenDirCookie now has its own copy of directory snapshot what
would prevent Inode::ReadDir from accessing freed memory when removing
files and reading directory entries simultaneously
* Several minor issues fixed

nfs4: Release vnodes when no longer used

nfs4: Introduce VnodeToInode mapping

VnodeToInode is another abstraction layer between VFS vnodes and NFS nodes.
It simplifies dealing with race conditions as well as faking some guarantees
VFS expects but NFS does not provide.

nfs4: Fix race condition between inode creation and removal

If the underlying file system reuses inode numbers it is possible that
an entry of inode with reused id in InodeIdMap will be removed.
This patch should also improve behavior when one of many hard links
is removed.

nfs4: Add basic tracing of nfs4 module calls

nfs4: Add numerous assertion checks

nfs4: Do not ignore idmapper initialization errors

nfs4, dns_resolver: fix numerous style violations

nfs4: Update FileInfo at rename

nfs4: Fix node removal

nfs4: Make the client more configurable

nfs4: Let GenerateClientID take advantage of PeerAddress methods

nfs4: Add basic support for extended attributes

nfs4: Make idmapper initialization lazy

nfs4: Add attribute directory related hooks

nfs4: Fix dir cookie rewinding

nfs4: Add asynchronous work queue

nfs4: Support delegations of created files

nfs4: Do not sync too often if delegation is held

nfs4: Move cache management inside Inode class

nfs4: Use one open state per inode

nfs4: Add basic RPC level support for callbacks

nfs4: Do not open too much files on server

nfs4: Revalidate cache before locks

nfs4: Use existing write cookie, do not send COMMIT if not necessary

nfs4: Use unstable writes and commit before close

nfs4: Change write policy from write through to write back

nfs4: Basic data cache implementation

nfs4: Make networking code IP version agnostic

nfs4: Use IPPROTO_* instead of enum Transport

nfs4: Rename Filehandle to FileHandle and Filesystem to FileSystem

Move parsing getattrinfo() result out of dns_resolver module

nfs4: Add id mapper

nfs4: Do not get_vnode() if Inode::Create() failed

nfs4: Add full support for lease migration

nfs4: Do not release locks if cookie is NULL

nfs4: Add remove_vnode() hook

nfs4: Add stub fsync() hook

nfs4: Add support for file locking

nfs4: Add set_flags() hook

nfs4: Remove unused entries from inode number to filehandle map

nfs4: Add write_stat() hook

nfs4: Add create_dir() hook

nfs4: Add support for O_APPEND mode

nfs4: Fix cookie and vnode creation in create() hook

nfs4: Add write() hook

nfs4: Add create() hook

nfs4: Add create_symlink() hook

nfs4: Add link() hook

nfs4: unlink() and remove_dir() should check node type

nfs4: Add unlink() and remove_dir() hooks

nfs4: Add rename() hook

nfs4: close*() should wake all blocked operations

nfs4: Add support for server migration

nfs4: Parse command line args

Thist commit also makes inet_addr() accessible for the kernel and kernel modules.

nfs4: Allow opening symbolic links

nfs4: Add read_fs_info hook

nfs4: Add read_symlink() hook

nfs4: Add per server NFS4 objects

RPC::Server is now able to store RPC programs data.
NFS4Server objects are currently used mainly for managing client id.

nfs4: Fix timeout handling code

nfs4: Allow open() on directories

nfs4: Add access() hook

nfs4: k- variants of socket functions are not really needed

nfs4: Add close() and free_cookie() hooks

nfs4: Add read() hook

nfs4: Add open() hook

nfs4: Add get_vnode_name hook

nfs4: Inodes should know their name and parent's filehandle

nfs4: Add rewind_dir() hook

nfs4: Add lookup() and get_vnode() hooks

get_vnode() needs a way to retrieve filehandle knowing only inode number.
Since NFS4 sever does not provide such services client manages its own mapping
between ino_t and filehandles.

nfs4: The unary & operator is not really needed

nfs4: Add read_dir() hook

nfs4: Add open_dir, close_dir and free_dir_cookie hooks

nfs4: Add unmount() and put_vnode() procedures

nfs4: Add basic nfs4_read_stat() procedure

Not all data are retrieved and there is a room for improvement in handling
situations when server does not provide necessary information.

nfs4: Implement nfs4_mount() procedure

nfs4: Make mount() send null nfs4 call

nfs4: Add network code

Connection class supports sending and receiving RPC data using either
TCP or UDP as a transport protocol.

nfs4: Initial commit

Empty file system with only mounting supported.