Netfs: Fix wformat-security

Change-Id: Id24585b12a264deb7dc87deb87a523e507773096
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4483
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Franck LeCodeur <cassisian@gmail.com>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>

file_systems/netfs/server: Fix attempting to delete released memory

Remove 'delete securityContext;' at line 967, since 'securityContext'
will be deleted by ObjectDeleter.

Pointed by clang static analyzer.

Change-Id: Iffcd6e2b293d5614fa15ee108562ff1f5f23ddc9
Reviewed-on: https://review.haiku-os.org/c/1011
Reviewed-by: waddlesplash <waddlesplash@gmail.com>

netfs: Fix and enable on 64-bit.

NetFSServer: Forward errors and fix use-after-free.

At least right now, the constructor of ServerInfoSender can only fail
because of OOM.

Signed-off-by: Augustin Cavalier <waddlesplash@gmail.com>
Fixes #11716. One minor tweak by me from the original patch
(change "!sender" to "sender == NULL").

Move NetFS to a package

This is based on Jalopeura's patch to #10191, however, there are some
changes.
From the patch:
* Make userlandfs use separate "interface definition" files for each
filesystem, so the netfs package can provide a configuration file
* Add a short document on how to use NetFS
* Various fixes to netfs to make it build again (volatile atomics)
* The netfs_mount script for easier use of NetFS

Additional fixes:
* Move netfs_mount and the interface description file to data/ in the
source tree
* Use strlcat instead of strcat to avoid a buffer overflow
* Some parts were already applied in previous commits

Fix #8420: NetFS does not compile with DEBUG

Debug macros like PRINT, ERROR, etc. are defined differently in NetFS
and UserlandFS. In NetFS they use single parentheses while in UserlandFS
double parentheses are required. Somehow this got mixed up in NetFS and
there were both styles of calling these macros what caused the incorrect
one to produce compilation errors.

Signed-off-by: Ingo Weinhold <ingo_weinhold@gmx.de>

Replace uses of obsolescent BReference[able] API.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39870 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed various errors/warnings reported by cppcheck:
* memory leaks
* resource leaks
* added const's to getters
* removed a few reundant conditions


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35433 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Renamed NetFSServer to netfs_server and added .rdef for running it in the
background.
* Renamed NetFSServerPrefs to netfs_server_prefs.
* Fixed copyright years in authentication_server.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35169 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed misleading warning. I don't know how a BMessage based settings file
at ~/config/settings/netfs/NetFSServer would come into being, but NetFSServer
will fall back to ~/config/settings/kernel/drivers/netfs-server, which works
if that file is there (see src/add-ons/kernel/file_systems/netfs/netfs-server
for an example settings file).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35086 a95241bf-73f2-0310-859d-f6bbb57e9c96

Copied Ingo's netfs from the dark pit in which it was forgotten to something
more visible and ported it to the current UserlandFS server (and GCC4). It still
uses the R5 file system API, which the UserlandFS conveniently still provides
support for. It compiles and links, but is otherwise still untested. The changes
I am alsmost confident that I didn't change any semantics. That is unless
HashMap, HashString and DoublyLinkedList work differently enough to make any of
the netfs code break.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35081 a95241bf-73f2-0310-859d-f6bbb57e9c96

NetFSServer: Forward errors and fix use-after-free.

At least right now, the constructor of ServerInfoSender can only fail
because of OOM.

Signed-off-by: Augustin Cavalier <waddlesplash@gmail.com>
Fixes #11716. One minor tweak by me from the original patch
(change "!sender" to "sender == NULL").

Move NetFS to a package

This is based on Jalopeura's patch to #10191, however, there are some
changes.
From the patch:
* Make userlandfs use separate "interface definition" files for each
filesystem, so the netfs package can provide a configuration file
* Add a short document on how to use NetFS
* Various fixes to netfs to make it build again (volatile atomics)
* The netfs_mount script for easier use of NetFS

Additional fixes:
* Move netfs_mount and the interface description file to data/ in the
source tree
* Use strlcat instead of strcat to avoid a buffer overflow
* Some parts were already applied in previous commits

Fix #8420: NetFS does not compile with DEBUG

Debug macros like PRINT, ERROR, etc. are defined differently in NetFS
and UserlandFS. In NetFS they use single parentheses while in UserlandFS
double parentheses are required. Somehow this got mixed up in NetFS and
there were both styles of calling these macros what caused the incorrect
one to produce compilation errors.

Signed-off-by: Ingo Weinhold <ingo_weinhold@gmx.de>

Replace uses of obsolescent BReference[able] API.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39870 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed various errors/warnings reported by cppcheck:
* memory leaks
* resource leaks
* added const's to getters
* removed a few reundant conditions


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35433 a95241bf-73f2-0310-859d-f6bbb57e9c96

* Renamed NetFSServer to netfs_server and added .rdef for running it in the
background.
* Renamed NetFSServerPrefs to netfs_server_prefs.
* Fixed copyright years in authentication_server.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35169 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed misleading warning. I don't know how a BMessage based settings file
at ~/config/settings/netfs/NetFSServer would come into being, but NetFSServer
will fall back to ~/config/settings/kernel/drivers/netfs-server, which works
if that file is there (see src/add-ons/kernel/file_systems/netfs/netfs-server
for an example settings file).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35086 a95241bf-73f2-0310-859d-f6bbb57e9c96

Copied Ingo's netfs from the dark pit in which it was forgotten to something
more visible and ported it to the current UserlandFS server (and GCC4). It still
uses the R5 file system API, which the UserlandFS conveniently still provides
support for. It compiles and links, but is otherwise still untested. The changes
I am alsmost confident that I didn't change any semantics. That is unless
HashMap, HashString and DoublyLinkedList work differently enough to make any of
the netfs code break.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35081 a95241bf-73f2-0310-859d-f6bbb57e9c96