netfs: Restore status_t result, fix build

result is being used on VisitReadQueryRequest().

It was not being used on ProcessQueryEvent() though
so leave that off still.

Change-Id: I8fbfbb3edef6ff962237f696fe315b66900b4376

netfs: Removed 'result' variable

Return B_NO_MEMORY on error creating volumeIDs object
in VisitReadQueryRequest() and return nothing on error
in ProcessQueryEvent() because the method's return
value is void.

Change-Id: I23c6f12258a702b6ffff667639e01fdbac928d6d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/6371
Reviewed-by: waddlesplash <waddlesplash@gmail.com>

Adjust all struct dirent creations (again), this time to use offsetof().

The dirent struct is not packed, so offsetof(dirent, d_name) != sizeof(dirent).
Thus in order not to waste the alignment bytes (which are significant,
on x86_64 at least, sizeof(dirent)==32, but offsetof(...)=26.)

This is also the most portable way to handle things, and should
work just fine in cross-platform code that has a non-zero-sized d_name.

file_systems/netfs: Fix -Wformat=

Change-Id: I291900a38cedf6b0bf6b61e55256ba60bff7935d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3349
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>

Remove 'always true' if statements (PVS 547)

Change-Id: I8d50e0ca48b48e4ce5091efee65949c6d65099a3
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2057
Reviewed-by: Axel Dörfler <axeld@pinc-software.de>

netfs: Fix and enable on 64-bit.

Fix GCC 4.9 maybe-uninitialized warning.

Signed-off-by: Augustin Cavalier <waddlesplash@gmail.com>

netfs: Fix build for gcc4.

Fix #8420: NetFS does not compile with DEBUG

Debug macros like PRINT, ERROR, etc. are defined differently in NetFS
and UserlandFS. In NetFS they use single parentheses while in UserlandFS
double parentheses are required. Somehow this got mixed up in NetFS and
there were both styles of calling these macros what caused the incorrect
one to produce compilation errors.

Signed-off-by: Ingo Weinhold <ingo_weinhold@gmx.de>

Adjust ReleaseReference() to also return the previous ref count as
AcquireReference() now does, and adjust all callers that relied on the previous
return type.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42091 a95241bf-73f2-0310-859d-f6bbb57e9c96

Replace uses of obsolescent BReference[able] API.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39870 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed various errors/warnings reported by cppcheck:
* memory leaks
* resource leaks
* added const's to getters
* removed a few reundant conditions


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35433 a95241bf-73f2-0310-859d-f6bbb57e9c96

Copied Ingo's netfs from the dark pit in which it was forgotten to something
more visible and ported it to the current UserlandFS server (and GCC4). It still
uses the R5 file system API, which the UserlandFS conveniently still provides
support for. It compiles and links, but is otherwise still untested. The changes
I am alsmost confident that I didn't change any semantics. That is unless
HashMap, HashString and DoublyLinkedList work differently enough to make any of
the netfs code break.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35081 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fix GCC 4.9 maybe-uninitialized warning.

Signed-off-by: Augustin Cavalier <waddlesplash@gmail.com>

netfs: Fix build for gcc4.

Fix #8420: NetFS does not compile with DEBUG

Debug macros like PRINT, ERROR, etc. are defined differently in NetFS
and UserlandFS. In NetFS they use single parentheses while in UserlandFS
double parentheses are required. Somehow this got mixed up in NetFS and
there were both styles of calling these macros what caused the incorrect
one to produce compilation errors.

Signed-off-by: Ingo Weinhold <ingo_weinhold@gmx.de>

Adjust ReleaseReference() to also return the previous ref count as
AcquireReference() now does, and adjust all callers that relied on the previous
return type.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42091 a95241bf-73f2-0310-859d-f6bbb57e9c96

Replace uses of obsolescent BReference[able] API.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@39870 a95241bf-73f2-0310-859d-f6bbb57e9c96

Fixed various errors/warnings reported by cppcheck:
* memory leaks
* resource leaks
* added const's to getters
* removed a few reundant conditions


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35433 a95241bf-73f2-0310-859d-f6bbb57e9c96

Copied Ingo's netfs from the dark pit in which it was forgotten to something
more visible and ported it to the current UserlandFS server (and GCC4). It still
uses the R5 file system API, which the UserlandFS conveniently still provides
support for. It compiles and links, but is otherwise still untested. The changes
I am alsmost confident that I didn't change any semantics. That is unless
HashMap, HashString and DoublyLinkedList work differently enough to make any of
the netfs code break.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35081 a95241bf-73f2-0310-859d-f6bbb57e9c96