#
eee4243d |
|
20-Oct-2011 |
Alex Wilson <yourpalal2@gmail.com> |
De-virtualize BView::InvalidateLayout() and introduce LayoutInvalidated() hook, like BLayout.
|
#
f71910c0 |
|
27-Jan-2011 |
Ryan Leavengood <leavengood@gmail.com> |
Apply the patch from Pete Goodeve from #7165 and therefore fix that ticket. Instead of forcing a click to open rect this just restarts menu tracking if the mouse was clicked. It seems to work great and is cleaner than my solution which is removed in this commit as well. This still fixes the problem of accidentially selecting menu items but also maintains the API. Good job Pete! git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40306 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
77b7e18a |
|
07-Jan-2011 |
Ryan Leavengood <leavengood@gmail.com> |
Revert my hack from r40132 and just go ahead and fix our pop-up menu behavior by forcing openAnyway and creating a clickToOpen rect if there is not one. Should fix #7022 and maybe others. Partially based on the patch from #7022 and Travis Reed's patch from the mailing list discussion in December. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40142 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
cd9af8e7 |
|
01-May-2010 |
Rene Gollent <anevilyak@gmail.com> |
Reverted r35463 and applied a patch by Stefano to handle the Terminal context menu issue a different way. Should fix #5835. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36575 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
633645bc |
|
18-Nov-2008 |
Rene Gollent <anevilyak@gmail.com> |
Fix a potential race condition in BPopUpMenu: if Go() is called on an async popup menu that hasn't yet been completely dismissed, it's possible to hit a debugger call because the menu's view tries to add itself to the menu window before the previous menu instance has removed it. This was quite easy to hit with things like BColumnListView's column title context menu, since there is no notification for when the menu was dismissed without invoking an item, and thus double right clicking quickly enough would hit the debugger. Go() now checks if the menu's tracking thread is still up, and if it is, waits for it to go away before trying to start another instance. Fixes ticket #3146. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28693 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
39fbf550 |
|
15-Oct-2008 |
Oliver Tappe <zooey@hirschkaefer.de> |
bonefish + zooey: * Fixed a general problem with respect to overriding of the reserved virtual function slots: instead of statically invoking the method that corresponds to the reserved slot on the class that contains the slot, we now invoke the virtual Perform() method. Perform() then dispatches the method invocation to the "proper" class, i.e. the highest class in the hierarchy that actually implements the requested method. This fixes a crash in apps that use liblayout's MSlider class and should fix one or other spurious bug with old apps or libraries, too. * added new header folder 'binary_compatibility' that contains files that define the method codes and data structures required by Perform() * looked for and implemented all used reserved virtual slot functions to invoke Perform() where necessary or to pass on the method call statically (for slots that were already maintained by Be) git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28124 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
99939029 |
|
13-Jul-2008 |
Karsten Heimrich <host.haiku@gmx.de> |
* only delete the popupmenu if we running the async version of BPopUpMenu This fixes part 3 of task #1987, TaskManager was using the syncronous version of of BPopUpMenu wrapped in it's own class to run asyncronous. It did set SetAsyncAutoDestruct to true and afterwards calling delete an the already deleted menu. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26406 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
e5e708ca |
|
08-Apr-2008 |
Stefano Ceccherini <stefano.ceccherini@gmail.com> |
Removed the snooze() call before tracking the popup menu. This should avoid the problem noticed by Andrea Anzani (can you check, please ?) where the tracker menu would close when moving the mouse too fast. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@24863 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
fbe2f227 |
|
12-Jun-2007 |
Stefano Ceccherini <stefano.ceccherini@gmail.com> |
Some work on menu layouts: - Menus are generally a bit wider (BeIDE ones didn't look nice) - The modifiers bitmap are drawn more centered vertically - Splitted BMenu::ComputeLayout() into three methods - Various minor changes. The menuitems still don't look nice with bigger font sizes, but we'll try to fix this... git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@21394 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
cd1cef8a |
|
12-Dec-2006 |
Stefano Ceccherini <stefano.ceccherini@gmail.com> |
moved synchronous waiting to _WaitMenu(). Renamed private methods to our style guidelines. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19475 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
fc82227a |
|
20-Nov-2006 |
Stefano Ceccherini <stefano.ceccherini@gmail.com> |
I thought I had found the cause of a bug. Not the case. But still, this looks better. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19332 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
3ec18e87 |
|
17-Sep-2006 |
Marcus Overhagen <marcusoverhagen@gmail.com> |
various GCC 4 build fixes git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18875 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
277a78ab |
|
13-Sep-2006 |
Stefano Ceccherini <stefano.ceccherini@gmail.com> |
some cleanups git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18834 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
946d88f9 |
|
12-Sep-2006 |
Axel Dörfler <axeld@pinc-software.de> |
We're now using the same priorities for windows as BeOS does - this should improve the responsiveness of the GUI, and should also fix bug #742. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18821 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
68c442e5 |
|
01-Jun-2006 |
Stefano Ceccherini <stefano.ceccherini@gmail.com> |
small cleanup, removed now unneeded hack git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17695 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
6d27f962 |
|
25-May-2006 |
Axel Dörfler <axeld@pinc-software.de> |
* Allowed Go() to also work if it was not called from within a window - this prevented ProcessController from showing its menus. * Minor cleanup. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17587 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
415c63be |
|
15-Apr-2006 |
Stefano Ceccherini <stefano.ceccherini@gmail.com> |
PopUpMenus didn't respect the openanyway setting (sticky mode), they always set it. And even in that case, they weren't working correctly. This should fix bugs 463 and 476. This might not work if click to open isn't selected in the menu prefs, though. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17136 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
36aa2198 |
|
14-Apr-2006 |
Stefano Ceccherini <stefano.ceccherini@gmail.com> |
Some more changes, fixed bug 487, added a small hysteresis so menus could be more nice to navigate, some corrections in popupmenu git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17134 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
cb8bdc4e |
|
05-Apr-2006 |
Stefano Ceccherini <stefano.ceccherini@gmail.com> |
Window's destructor should acquire the menu sem, not delete it. Could help fixing bug 422 git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17016 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
9deb82df |
|
02-Apr-2006 |
Stefano Ceccherini <stefano.ceccherini@gmail.com> |
If the popup was asynchronous, the window menu semaphore was never resetted git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16962 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
797d1a66 |
|
10-Jan-2006 |
Stefano Ceccherini <stefano.ceccherini@gmail.com> |
menufields should default to B_ITEMS_IN_COLUMN. This fixes the workspaces menu (in Screen) opened at the wrong position. As a consequence of this, I had to change the drawing code a bit git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@15892 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
27ec1ee4 |
|
13-Jan-2005 |
Stefano Ceccherini <stefano.ceccherini@gmail.com> |
Added a clarifying comment. git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10707 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
14260ebb |
|
27-Dec-2004 |
Stefano Ceccherini <stefano.ceccherini@gmail.com> |
Small style changes git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10537 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
26b54010 |
|
14-Jul-2004 |
Stefano Ceccherini <stefano.ceccherini@gmail.com> |
Added implementation of _set_menu_sem_() to Window.cpp (should it go to a different place ?), thus fixing the build (at least here, I hope I didn't forget anything else). Thanks to Bill Hayden for reporting and sorry again for the trouble. Changed a comment in PopUpMenu.cpp git-svn-id: file:///srv/svn/repos/haiku/trunk/current@8394 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
4b44b026 |
|
13-Jul-2004 |
Stefano Ceccherini <stefano.ceccherini@gmail.com> |
Finished (or, at least fixed) BPopUpMenu, to make it do something useful (it works actually, even if not all options are tested). Fixed build of Dragger, Shelf and ZombieReplicantView git-svn-id: file:///srv/svn/repos/haiku/trunk/current@8387 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
2847a12d |
|
28-Jun-2004 |
Axel Dörfler <axeld@pinc-software.de> |
Fixed compilation and applied our style guide. git-svn-id: file:///srv/svn/repos/haiku/trunk/current@8220 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
af53a136 |
|
27-Jun-2004 |
Axel Dörfler <axeld@pinc-software.de> |
Added Marc Fleracker's BPopUpMenu implementation - it does not yet compile, though. Thanks to Jack Burton for making this available. git-svn-id: file:///srv/svn/repos/haiku/trunk/current@8219 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
eee4243d35225a35d0964ebebe94490eaca14261 |
|
20-Oct-2011 |
Alex Wilson <yourpalal2@gmail.com> |
De-virtualize BView::InvalidateLayout() and introduce LayoutInvalidated() hook, like BLayout.
|
#
f71910c068ed509205ba27d988ef695b8956ea37 |
|
27-Jan-2011 |
Ryan Leavengood <leavengood@gmail.com> |
Apply the patch from Pete Goodeve from #7165 and therefore fix that ticket. Instead of forcing a click to open rect this just restarts menu tracking if the mouse was clicked. It seems to work great and is cleaner than my solution which is removed in this commit as well. This still fixes the problem of accidentially selecting menu items but also maintains the API. Good job Pete! git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40306 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
77b7e18ab7f97a10c0d55d69a48efa1b97cca8ce |
|
07-Jan-2011 |
Ryan Leavengood <leavengood@gmail.com> |
Revert my hack from r40132 and just go ahead and fix our pop-up menu behavior by forcing openAnyway and creating a clickToOpen rect if there is not one. Should fix #7022 and maybe others. Partially based on the patch from #7022 and Travis Reed's patch from the mailing list discussion in December. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40142 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
cd9af8e701322c691fd340cb7970586e4d632642 |
|
01-May-2010 |
Rene Gollent <anevilyak@gmail.com> |
Reverted r35463 and applied a patch by Stefano to handle the Terminal context menu issue a different way. Should fix #5835. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36575 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
633645bca91b3a70bd8829ad00bf5b80f6721cf3 |
|
18-Nov-2008 |
Rene Gollent <anevilyak@gmail.com> |
Fix a potential race condition in BPopUpMenu: if Go() is called on an async popup menu that hasn't yet been completely dismissed, it's possible to hit a debugger call because the menu's view tries to add itself to the menu window before the previous menu instance has removed it. This was quite easy to hit with things like BColumnListView's column title context menu, since there is no notification for when the menu was dismissed without invoking an item, and thus double right clicking quickly enough would hit the debugger. Go() now checks if the menu's tracking thread is still up, and if it is, waits for it to go away before trying to start another instance. Fixes ticket #3146. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28693 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
39fbf5509b8740d9883b61649027478dc8a3ead8 |
|
15-Oct-2008 |
Oliver Tappe <zooey@hirschkaefer.de> |
bonefish + zooey: * Fixed a general problem with respect to overriding of the reserved virtual function slots: instead of statically invoking the method that corresponds to the reserved slot on the class that contains the slot, we now invoke the virtual Perform() method. Perform() then dispatches the method invocation to the "proper" class, i.e. the highest class in the hierarchy that actually implements the requested method. This fixes a crash in apps that use liblayout's MSlider class and should fix one or other spurious bug with old apps or libraries, too. * added new header folder 'binary_compatibility' that contains files that define the method codes and data structures required by Perform() * looked for and implemented all used reserved virtual slot functions to invoke Perform() where necessary or to pass on the method call statically (for slots that were already maintained by Be) git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28124 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
99939029b3a3afc028abaf61db68e476c2dfda93 |
|
13-Jul-2008 |
Karsten Heimrich <host.haiku@gmx.de> |
* only delete the popupmenu if we running the async version of BPopUpMenu This fixes part 3 of task #1987, TaskManager was using the syncronous version of of BPopUpMenu wrapped in it's own class to run asyncronous. It did set SetAsyncAutoDestruct to true and afterwards calling delete an the already deleted menu. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26406 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
e5e708ca39fa9ecfa8f804962c6d2cb7faa1ee41 |
|
08-Apr-2008 |
Stefano Ceccherini <stefano.ceccherini@gmail.com> |
Removed the snooze() call before tracking the popup menu. This should avoid the problem noticed by Andrea Anzani (can you check, please ?) where the tracker menu would close when moving the mouse too fast. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@24863 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
fbe2f227cab65d4a1d972fd0bc2ed08681985bc2 |
|
12-Jun-2007 |
Stefano Ceccherini <stefano.ceccherini@gmail.com> |
Some work on menu layouts: - Menus are generally a bit wider (BeIDE ones didn't look nice) - The modifiers bitmap are drawn more centered vertically - Splitted BMenu::ComputeLayout() into three methods - Various minor changes. The menuitems still don't look nice with bigger font sizes, but we'll try to fix this... git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@21394 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
cd1cef8aab2ca7917824516c52e43f6e82ec65c5 |
|
12-Dec-2006 |
Stefano Ceccherini <stefano.ceccherini@gmail.com> |
moved synchronous waiting to _WaitMenu(). Renamed private methods to our style guidelines. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19475 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
fc82227a6e9da9f3895311e73324afe8824c36ad |
|
20-Nov-2006 |
Stefano Ceccherini <stefano.ceccherini@gmail.com> |
I thought I had found the cause of a bug. Not the case. But still, this looks better. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@19332 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
3ec18e87d6cfa48715a6ed10bcd03858d832093b |
|
17-Sep-2006 |
Marcus Overhagen <marcusoverhagen@gmail.com> |
various GCC 4 build fixes git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18875 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
277a78abf5521d3f47546053327d36429e903554 |
|
13-Sep-2006 |
Stefano Ceccherini <stefano.ceccherini@gmail.com> |
some cleanups git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18834 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
946d88f90b9c740ffbfd3ceb123e376a7d0cfa95 |
|
12-Sep-2006 |
Axel Dörfler <axeld@pinc-software.de> |
We're now using the same priorities for windows as BeOS does - this should improve the responsiveness of the GUI, and should also fix bug #742. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18821 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
68c442e5c2b7d9cd402e34acb93bb81db8e39b1b |
|
01-Jun-2006 |
Stefano Ceccherini <stefano.ceccherini@gmail.com> |
small cleanup, removed now unneeded hack git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17695 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
6d27f962bd94237f5b126b066ba779506e58497e |
|
25-May-2006 |
Axel Dörfler <axeld@pinc-software.de> |
* Allowed Go() to also work if it was not called from within a window - this prevented ProcessController from showing its menus. * Minor cleanup. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17587 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
415c63bee290da0d064c5102d5e32b7f4ffe3aef |
|
15-Apr-2006 |
Stefano Ceccherini <stefano.ceccherini@gmail.com> |
PopUpMenus didn't respect the openanyway setting (sticky mode), they always set it. And even in that case, they weren't working correctly. This should fix bugs 463 and 476. This might not work if click to open isn't selected in the menu prefs, though. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17136 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
36aa2198b715fd6f8440f73355c22cc951c4f22d |
|
14-Apr-2006 |
Stefano Ceccherini <stefano.ceccherini@gmail.com> |
Some more changes, fixed bug 487, added a small hysteresis so menus could be more nice to navigate, some corrections in popupmenu git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17134 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
cb8bdc4edae377c5900904a38f62c0ec08d5c5a5 |
|
05-Apr-2006 |
Stefano Ceccherini <stefano.ceccherini@gmail.com> |
Window's destructor should acquire the menu sem, not delete it. Could help fixing bug 422 git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17016 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
9deb82dfc08fe1b6aa9ffad94393e8e190ee6c48 |
|
02-Apr-2006 |
Stefano Ceccherini <stefano.ceccherini@gmail.com> |
If the popup was asynchronous, the window menu semaphore was never resetted git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16962 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
797d1a66fa05bd68a2bb475b4786af13038e9b16 |
|
10-Jan-2006 |
Stefano Ceccherini <stefano.ceccherini@gmail.com> |
menufields should default to B_ITEMS_IN_COLUMN. This fixes the workspaces menu (in Screen) opened at the wrong position. As a consequence of this, I had to change the drawing code a bit git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@15892 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
27ec1ee4feda70bfe4b402337e8f6446c3d65342 |
|
13-Jan-2005 |
Stefano Ceccherini <stefano.ceccherini@gmail.com> |
Added a clarifying comment. git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10707 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
14260ebb3b3fef272f447af220a740bc57d573e9 |
|
27-Dec-2004 |
Stefano Ceccherini <stefano.ceccherini@gmail.com> |
Small style changes git-svn-id: file:///srv/svn/repos/haiku/trunk/current@10537 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
26b5401027b198700ec4cdc99a619d5368609a88 |
|
14-Jul-2004 |
Stefano Ceccherini <stefano.ceccherini@gmail.com> |
Added implementation of _set_menu_sem_() to Window.cpp (should it go to a different place ?), thus fixing the build (at least here, I hope I didn't forget anything else). Thanks to Bill Hayden for reporting and sorry again for the trouble. Changed a comment in PopUpMenu.cpp git-svn-id: file:///srv/svn/repos/haiku/trunk/current@8394 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
4b44b0265a0abe50aaa53c4ba06f28569f58d486 |
|
13-Jul-2004 |
Stefano Ceccherini <stefano.ceccherini@gmail.com> |
Finished (or, at least fixed) BPopUpMenu, to make it do something useful (it works actually, even if not all options are tested). Fixed build of Dragger, Shelf and ZombieReplicantView git-svn-id: file:///srv/svn/repos/haiku/trunk/current@8387 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
2847a12df445b31a37c4c3511fa0df08e9b78f8b |
|
28-Jun-2004 |
Axel Dörfler <axeld@pinc-software.de> |
Fixed compilation and applied our style guide. git-svn-id: file:///srv/svn/repos/haiku/trunk/current@8220 a95241bf-73f2-0310-859d-f6bbb57e9c96
|
#
af53a136d12a06c6cac3226ade0ee34f6eea9c0d |
|
27-Jun-2004 |
Axel Dörfler <axeld@pinc-software.de> |
Added Marc Fleracker's BPopUpMenu implementation - it does not yet compile, though. Thanks to Jack Burton for making this available. git-svn-id: file:///srv/svn/repos/haiku/trunk/current@8219 a95241bf-73f2-0310-859d-f6bbb57e9c96
|