History log of /haiku-fatelf/src/apps/webpositive/URLInputGroup.cpp
Revision Date Author Comments
# 2218c029 11-Jul-2012 Alexandre Deckner <alexandre.deckner@uzzl.com>

Add localization support to WebPositive, patch by Humdinger

* Includes style fixes
* Functional fixes by myself, patch wouldn't build


# 26bc1632 09-Dec-2010 anevilyak <anevilyak@94f232f2-1747-11df-bad5-a5bfde151594>

Layout fixes that hadn't yet been committed.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@548 94f232f2-1747-11df-bad5-a5bfde151594


# 90a69c8e 18-May-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

The mechanism with which the TextViewCompleter detected changes (attaching a
BMessageFilter to the BTextView to pre-process key down events) missed changes
to the BTextView via other means, for example by pasting, or simply when
SetText() is invoked on the BTextView. -> Introduced an alternative method
of making the TextViewCompleter aware of changes, by invoking new method
TextModified(). To bypass the old method, one has to call
SetModificationsReported(true). URLInput::URLTextView now uses the new method
in InsertText() and DeleteText(), which catches any and all changes to the
text. Since the BAutoCompleter framework also controls the editor view contents,
it needs to protect against re-entering some methods when the editor view
reports the changes (fIgnoreEditViewStateChanges). Since we want the
BAutoCompleter to always be aware of the current editor view contents, but not
necessarily also running the choice mechanism (i.e. when you enter
"www.google.com", you don't want the auto-completion kick back in when it is
programmatically changed to "http://www.google.com" later on), the
EditViewStateChange() method gets a boolean now "updateChoices". All
programmatic changes to the URL will then not trigger displaying the choice
pop-up, but the BAutoCompleter is always aware of the current editor view
contents.

All this fixes numerous issues and inconsistencies with entering text in the
URL text view.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@500 94f232f2-1747-11df-bad5-a5bfde151594


# 095c4241 04-May-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

Moved BitmapButton into it's own file.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@483 94f232f2-1747-11df-bad5-a5bfde151594


# 27dab3e5 03-May-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

Make sure never to draw the favicon too big, in case we only got a big one from
the page, and use the proper drawing mode and filtering.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@479 94f232f2-1747-11df-bad5-a5bfde151594


# 5913d4a9 30-Apr-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

* Invalidate layout only when necessary.
* Icon view needs to update completely on resize.
-> Fixes graphics glitch when switching between icon and no icon.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@467 94f232f2-1747-11df-bad5-a5bfde151594


# 65cc5e49 30-Apr-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

The favicon is now also displayed in the URL input view. Mostly because one is
used to it, but also when only one page is open and tabs are not displayed as
per the user settings, the favicon would then not be visible.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@465 94f232f2-1747-11df-bad5-a5bfde151594


# f7530134 22-Apr-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

Don't set the text if it's the same, allows to keep selection.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@454 94f232f2-1747-11df-bad5-a5bfde151594


# 9d150599 20-Apr-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

Make the base URL show in bold font in the URL input field, and the rest of the
text in dark gray.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@445 94f232f2-1747-11df-bad5-a5bfde151594


# ae82400b 20-Apr-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

The return key is never supposed to reach the BTextView implementation, even if
we don't have to invoke in the URLTextView.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@440 94f232f2-1747-11df-bad5-a5bfde151594


# a72e997a 15-Apr-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

Improved the design of the Go button graphics.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@417 94f232f2-1747-11df-bad5-a5bfde151594


# a26e66b5 12-Apr-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

One more round of simplification and fixing.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@407 94f232f2-1747-11df-bad5-a5bfde151594


# f9977c07 12-Apr-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

strlcpy() takes buffer size, not char count, and will copy buffer size - 1 chars
at max and terminate the buffer.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@406 94f232f2-1747-11df-bad5-a5bfde151594


# 560610f7 11-Apr-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

Don't overwrite memory when pressing return in the URL text input.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@405 94f232f2-1747-11df-bad5-a5bfde151594


# ad7c99c0 08-Apr-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

* Integrated the Go button into the URL text field.
* Added a context menu to the URL input for integration with the system
clipboard when you want to use the mouse only.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@403 94f232f2-1747-11df-bad5-a5bfde151594


# 312655fb 07-Apr-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

* Renamed TextControlCompleter to TextViewCompleter, since it actually only
works with the BTextView.
* Factored out the URL text handling into a new class URLInputGroup, which is
used instead of a plain BTextControl, but currently works much the same way.
It's a BGroupView though and allows easy addition of other controls and items
into the URL text field.
* Moved baseURL() method into it's own file, since it's used from multiple
places now.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@402 94f232f2-1747-11df-bad5-a5bfde151594


# 2218c029a5ab7260d03036b43c68475e0b35b449 11-Jul-2012 Alexandre Deckner <alexandre.deckner@uzzl.com>

Add localization support to WebPositive, patch by Humdinger

* Includes style fixes
* Functional fixes by myself, patch wouldn't build


# 26bc1632000d90f95e6aaef5f468c735c5370ed6 09-Dec-2010 anevilyak <anevilyak@94f232f2-1747-11df-bad5-a5bfde151594>

Layout fixes that hadn't yet been committed.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@548 94f232f2-1747-11df-bad5-a5bfde151594


# 90a69c8e1d42bbe82b16a9caadad3fefca92f655 18-May-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

The mechanism with which the TextViewCompleter detected changes (attaching a
BMessageFilter to the BTextView to pre-process key down events) missed changes
to the BTextView via other means, for example by pasting, or simply when
SetText() is invoked on the BTextView. -> Introduced an alternative method
of making the TextViewCompleter aware of changes, by invoking new method
TextModified(). To bypass the old method, one has to call
SetModificationsReported(true). URLInput::URLTextView now uses the new method
in InsertText() and DeleteText(), which catches any and all changes to the
text. Since the BAutoCompleter framework also controls the editor view contents,
it needs to protect against re-entering some methods when the editor view
reports the changes (fIgnoreEditViewStateChanges). Since we want the
BAutoCompleter to always be aware of the current editor view contents, but not
necessarily also running the choice mechanism (i.e. when you enter
"www.google.com", you don't want the auto-completion kick back in when it is
programmatically changed to "http://www.google.com" later on), the
EditViewStateChange() method gets a boolean now "updateChoices". All
programmatic changes to the URL will then not trigger displaying the choice
pop-up, but the BAutoCompleter is always aware of the current editor view
contents.

All this fixes numerous issues and inconsistencies with entering text in the
URL text view.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@500 94f232f2-1747-11df-bad5-a5bfde151594


# 095c4241efc817337f8662d832a6634f74146db3 04-May-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

Moved BitmapButton into it's own file.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@483 94f232f2-1747-11df-bad5-a5bfde151594


# 27dab3e5fe5e7f8115d8db88f82508168faf27e9 03-May-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

Make sure never to draw the favicon too big, in case we only got a big one from
the page, and use the proper drawing mode and filtering.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@479 94f232f2-1747-11df-bad5-a5bfde151594


# 5913d4a98b5c55e91bb9327e89d748747e439ffd 30-Apr-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

* Invalidate layout only when necessary.
* Icon view needs to update completely on resize.
-> Fixes graphics glitch when switching between icon and no icon.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@467 94f232f2-1747-11df-bad5-a5bfde151594


# 65cc5e49ee22e22dae9204db37a33ab636f39bf3 30-Apr-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

The favicon is now also displayed in the URL input view. Mostly because one is
used to it, but also when only one page is open and tabs are not displayed as
per the user settings, the favicon would then not be visible.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@465 94f232f2-1747-11df-bad5-a5bfde151594


# f7530134b1b87dc483f6d62309433ce4e22188fe 22-Apr-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

Don't set the text if it's the same, allows to keep selection.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@454 94f232f2-1747-11df-bad5-a5bfde151594


# 9d150599741158a2e9efd09305020a73b5d0bd8f 20-Apr-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

Make the base URL show in bold font in the URL input field, and the rest of the
text in dark gray.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@445 94f232f2-1747-11df-bad5-a5bfde151594


# ae82400bb4ff73fbc67c1d618ebf7fb53d1d83e3 20-Apr-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

The return key is never supposed to reach the BTextView implementation, even if
we don't have to invoke in the URLTextView.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@440 94f232f2-1747-11df-bad5-a5bfde151594


# a72e997ab0ab32f1afa97cd4378c4e8dc6b9f094 15-Apr-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

Improved the design of the Go button graphics.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@417 94f232f2-1747-11df-bad5-a5bfde151594


# a26e66b548662dc307869b11f411b6ce019ab3ae 12-Apr-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

One more round of simplification and fixing.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@407 94f232f2-1747-11df-bad5-a5bfde151594


# f9977c07c19bfe294637ac51b3c64aa237b9a300 12-Apr-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

strlcpy() takes buffer size, not char count, and will copy buffer size - 1 chars
at max and terminate the buffer.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@406 94f232f2-1747-11df-bad5-a5bfde151594


# 560610f70eb60020d17ec3c2889357b18aa4e322 11-Apr-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

Don't overwrite memory when pressing return in the URL text input.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@405 94f232f2-1747-11df-bad5-a5bfde151594


# ad7c99c0ca4493fe060f90ec7ee8aae72913e640 08-Apr-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

* Integrated the Go button into the URL text field.
* Added a context menu to the URL input for integration with the system
clipboard when you want to use the mouse only.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@403 94f232f2-1747-11df-bad5-a5bfde151594


# 312655fb6f521a6a769e3d7dd4cb908708848f29 07-Apr-2010 stippi <stippi@94f232f2-1747-11df-bad5-a5bfde151594>

* Renamed TextControlCompleter to TextViewCompleter, since it actually only
works with the BTextView.
* Factored out the URL text handling into a new class URLInputGroup, which is
used instead of a plain BTextControl, but currently works much the same way.
It's a BGroupView though and allows easy addition of other controls and items
into the URL text field.
* Moved baseURL() method into it's own file, since it's used from multiple
places now.

git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@402 94f232f2-1747-11df-bad5-a5bfde151594