#
9f1a0fb4 |
|
08-Sep-2018 |
Pascal Perez <pascallouis@google.com> |
[fidl] Doc comments de-sugared in Doc attribute (vs doc) Changing capitalization of Doc comment attribute for consistency with other attributes such as [Layout = ...], [Discoverable], etc. Test: make tools && ./build-x64/host_tests/fidl-compiler-test Change-Id: I0f85d7d888cc94e36da2c1faea42d140e1ea2040
|
#
4ef2fb8c |
|
04-Sep-2018 |
Pascal Perez <pascallouis@google.com> |
[fidl] Prevent duplicate attributes. Attributes can annote various elements such as method, interfaces, types, libraries. The intent is for attributes to be a key/value pair. Until this change however, we allowed attributes' keys to be duplicated, potentially leading to unknown behavior in downstream libraries (e.g. code generators). This change enforces this requirement, and unit tests it. We're adding an ASSERT_STR_STR to the unittesting library to check for string containement, so as to make the tests easier to read. Test: make tools HOST_USE_ASAN=true && ./build-x64/host_tests/fidl-compiler-test, and full builds Change-Id: Icc92cacc68761bd5d17d77e441300aa860e9f877 Change-Id: I5e3ec76ce2041cbc4389252b935fd5f081a23399
|