#
e2f36496 |
|
27-Feb-2024 |
Gordon Bergling <gbe@FreeBSD.org> |
bxe(4): Fix two typos in a kernel messages - s/successfull/successful/ MFC after: 3 days
|
#
2a371643 |
|
21-Jul-2023 |
Justin Hibbits <jhibbits@FreeBSD.org> |
IfAPI: Retire if_etherbpfmtap() and if_bpfmtap() Summary: These came in the original DrvAPI commits in 2014, and are obsoleted by bpf_mtap_if() and ether_bpf_mtap_if(). The `_if` suffix, rather than prefix, conveys that it's operating on the bpf of the interface, instead than the interface itself. Reviewed by: glebius Sponsored by: Juniper Networks, Inc. Differential Revision: https://reviews.freebsd.org/D41146
|
#
685dc743 |
|
16-Aug-2023 |
Warner Losh <imp@FreeBSD.org> |
sys: Remove $FreeBSD$: one-line .c pattern Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/
|
#
ed2e5050 |
|
04-Jul-2019 |
Ed Maste <emaste@FreeBSD.org> |
bxe: prefer C99 bool to boolean_t Differential Revision: https://reviews.freebsd.org/D20853
|
#
8bd9afe9 |
|
11-Apr-2023 |
Zhenlei Huang <zlei@FreeBSD.org> |
bxe(4): Use CTLFLAG_RDTUN flag definition sysctl variables rx_budget and max_aggregation_size are read-only loader tunable. Mark them with CTLFLAG_RD flag. No functional change intended. Reviewed by: hselasky, erj MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D39466
|
#
ec22a3a2 |
|
19-Aug-2022 |
Justin Hibbits <jhibbits@FreeBSD.org> |
DrvAPI: Trivial mechanical conversions for various drivers Mechanically convert the following drivers, with trivial changes: * ipw(4) * igc(4) * enetc(4) * malo(4) * nfe(4) * bxe(4) * awg(4) * otus(4) * rtwn(4) * bnxt(4) * ath(4) Sponsored by: Juniper Networks, Inc.
|
#
e902e626 |
|
01-Nov-2022 |
Gordon Bergling <gbe@FreeBSD.org> |
bxe(4): Fix a typo in a source code comment - s/interrutps/interrupts/ MFC after: 3 days
|
#
6e9e7b05 |
|
04-Sep-2022 |
Gordon Bergling <gbe@FreeBSD.org> |
bxe(4): Grammar fix for a source code comment - s/that that/that the/ MFC after: 3 days
|
#
b15b1fc1 |
|
06-May-2022 |
John Baldwin <jhb@FreeBSD.org> |
bxe: Remove unused devclass argument to DRIVER_MODULE.
|
#
583df2db |
|
06-Apr-2022 |
John Baldwin <jhb@FreeBSD.org> |
bxe: Quiet set but not used warnings. Comment out other references to more_tx since the only use is commented out. Remove unused is_parity variable.
|
#
e443f210 |
|
02-Apr-2022 |
Gordon Bergling <gbe@FreeBSD.org> |
bxe(4): Fix a typo in an error message - s/intergers/integers/ MFC after: 3 days
|
#
8117f96f |
|
09-Dec-2021 |
Mateusz Guzik <mjg@FreeBSD.org> |
bxe: plug some of set-but-not-used vars Sponsored by: Rubicon Communications, LLC ("Netgate")
|
#
8a6f38c8 |
|
22-Nov-2021 |
Gleb Smirnoff <glebius@FreeBSD.org> |
ifnet: garbage collect drbr_*_drv(). They were left in 62d76917b8678 but after years proved not to be useful.
|
#
4081c895 |
|
02-Sep-2021 |
Alexander Motin <mav@FreeBSD.org> |
bxe(4): Mark sysctls and callout MP-safe. MFC after: 1 month
|
#
646f3a36 |
|
14-Aug-2021 |
Gordon Bergling <gbe@FreeBSD.org> |
Fix a typo that was introduced while fixing a typo - s/enrtry/entry/ MFC after: 5 days
|
#
86b74b73 |
|
14-Aug-2021 |
Gordon Bergling <gbe@FreeBSD.org> |
Fix a common typo in a comment - s/enrty/entry/ MFC after: 5 days
|
#
8b8af168 |
|
08-Nov-2020 |
Warner Losh <imp@FreeBSD.org> |
Remove newline from bxe description, it's not done elsewhere.
|
#
aeb665b5 |
|
30-Mar-2020 |
Ed Maste <emaste@FreeBSD.org> |
remove extraneous double ;s in sys/
|
#
eab6ecc0 |
|
01-Mar-2020 |
Warner Losh <imp@FreeBSD.org> |
Finish removing support from old versions Eliminate code for old versions, inline pci_find_cap instead of relying on compat ifdef. This commit should have been combined with r358488 before pushing it in.
|
#
e602f0c8 |
|
01-Mar-2020 |
Warner Losh <imp@FreeBSD.org> |
Remove FreeBSD 7-10 support from bxe driver. Use new PCIER and PCIEM names in the driver rather than relying on old, compat shims.
|
#
7029da5c |
|
26-Feb-2020 |
Pawel Biernacki <kaktus@FreeBSD.org> |
Mark more nodes as CTLFLAG_MPSAFE or CTLFLAG_NEEDGIANT (17 of many) r357614 added CTLFLAG_NEEDGIANT to make it easier to find nodes that are still not MPSAFE (or already are but aren’t properly marked). Use it in preparation for a general review of all nodes. This is non-functional change that adds annotations to SYSCTL_NODE and SYSCTL_PROC nodes using one of the soon-to-be-required flags. Mark all obvious cases as MPSAFE. All entries that haven't been marked as MPSAFE before are by default marked as NEEDGIANT Approved by: kib (mentor, blanket) Commented by: kib, gallatin, melifaro Differential Revision: https://reviews.freebsd.org/D23718
|
#
6c3e93cb |
|
11-Feb-2020 |
Gleb Smirnoff <glebius@FreeBSD.org> |
Use NET_TASK_INIT() and NET_GROUPTASK_INIT() for drivers that process incoming packets in taskqueue context. Reviewed by: hselasky Differential Revision: https://reviews.freebsd.org/D23518
|
#
349ecfc3 |
|
21-Oct-2019 |
Gleb Smirnoff <glebius@FreeBSD.org> |
Convert to if_foreach_llmaddr() KPI.
|
#
7790c8c1 |
|
17-Oct-2019 |
Conrad Meyer <cem@FreeBSD.org> |
Split out a more generic debugnet(4) from netdump(4) Debugnet is a simplistic and specialized panic- or debug-time reliable datagram transport. It can drive a single connection at a time and is currently unidirectional (debug/panic machine transmit to remote server only). It is mostly a verbatim code lift from netdump(4). Netdump(4) remains the only consumer (until the rest of this patch series lands). The INET-specific logic has been extracted somewhat more thoroughly than previously in netdump(4), into debugnet_inet.c. UDP-layer logic and up, as much as possible as is protocol-independent, remains in debugnet.c. The separation is not perfect and future improvement is welcome. Supporting INET6 is a long-term goal. Much of the diff is "gratuitous" renaming from 'netdump_' or 'nd_' to 'debugnet_' or 'dn_' -- sorry. I thought keeping the netdump name on the generic module would be more confusing than the refactoring. The only functional change here is the mbuf allocation / tracking. Instead of initiating solely on netdump-configured interface(s) at dumpon(8) configuration time, we watch for any debugnet-enabled NIC for link activation and query it for mbuf parameters at that time. If they exceed the existing high-water mark allocation, we re-allocate and track the new high-water mark. Otherwise, we leave the pre-panic mbuf allocation alone. In a future patch in this series, this will allow initiating netdump from panic ddb(4) without pre-panic configuration. No other functional change intended. Reviewed by: markj (earlier version) Some discussion with: emaste, jhb Objection from: marius Differential Revision: https://reviews.freebsd.org/D21421
|
#
36baf17e |
|
15-Oct-2018 |
David C Somayajulu <davidcs@FreeBSD.org> |
Add support for Error Recovery Submitted by:Vaishali.Kulkarni@cavium.com Approved by:re(kib) MFC after:5 days
|
#
9d50798c |
|
17-Sep-2018 |
David C Somayajulu <davidcs@FreeBSD.org> |
Fixed isses: State check before enqueuing transmit task in bxe_link_attn() routine. State check before invoking bxe_nic_unload in bxe_shutdown(). Submitted by:Vaishali.Kulkarni@cavium.com Approved by:re(gjb)
|
#
38b42191 |
|
17-Jul-2018 |
David C Somayajulu <davidcs@FreeBSD.org> |
Fixes for the following issues: 1. Fix taskqueues drain/free to fix panic seen when interface is being bought down and in parallel asynchronous link events happening. 2. Fix bxe_ifmedia_status() Submitted by:Vaishali.Kulkarni@cavium.com and Anand.Khoje@cavium.com MFC after:5 days
|
#
48f00baf |
|
11-Jun-2018 |
Dimitry Andric <dim@FreeBSD.org> |
Fix build of bxe with base gcc on i386 Casting from rman_res_t to a pointer results in "cast to pointer from integer of different size" warnings with base gcc on i386, so print these without casting. The kva field of struct bxe_bar is of type vm_offset_t, which can be 32 or 64 bit, so cast it to uintmax_t before printing. Reviewed by: markj MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D15733
|
#
d7c5a620 |
|
18-May-2018 |
Matt Macy <mmacy@FreeBSD.org> |
ifnet: Replace if_addr_lock rwlock with epoch + mutex Run on LLNW canaries and tested by pho@ gallatin: Using a 14-core, 28-HTT single socket E5-2697 v3 with a 40GbE MLX5 based ConnectX 4-LX NIC, I see an almost 12% improvement in received packet rate, and a larger improvement in bytes delivered all the way to userspace. When the host receiving 64 streams of netperf -H $DUT -t UDP_STREAM -- -m 1, I see, using nstat -I mce0 1 before the patch: InMpps OMpps InGbs OGbs err TCP Est %CPU syscalls csw irq GBfree 4.98 0.00 4.42 0.00 4235592 33 83.80 4720653 2149771 1235 247.32 4.73 0.00 4.20 0.00 4025260 33 82.99 4724900 2139833 1204 247.32 4.72 0.00 4.20 0.00 4035252 33 82.14 4719162 2132023 1264 247.32 4.71 0.00 4.21 0.00 4073206 33 83.68 4744973 2123317 1347 247.32 4.72 0.00 4.21 0.00 4061118 33 80.82 4713615 2188091 1490 247.32 4.72 0.00 4.21 0.00 4051675 33 85.29 4727399 2109011 1205 247.32 4.73 0.00 4.21 0.00 4039056 33 84.65 4724735 2102603 1053 247.32 After the patch InMpps OMpps InGbs OGbs err TCP Est %CPU syscalls csw irq GBfree 5.43 0.00 4.20 0.00 3313143 33 84.96 5434214 1900162 2656 245.51 5.43 0.00 4.20 0.00 3308527 33 85.24 5439695 1809382 2521 245.51 5.42 0.00 4.19 0.00 3316778 33 87.54 5416028 1805835 2256 245.51 5.42 0.00 4.19 0.00 3317673 33 90.44 5426044 1763056 2332 245.51 5.42 0.00 4.19 0.00 3314839 33 88.11 5435732 1792218 2499 245.52 5.44 0.00 4.19 0.00 3293228 33 91.84 5426301 1668597 2121 245.52 Similarly, netperf reports 230Mb/s before the patch, and 270Mb/s after the patch Reviewed by: gallatin Sponsored by: Limelight Networks Differential Revision: https://reviews.freebsd.org/D15366
|
#
b4fa90d6 |
|
09-May-2018 |
Mark Johnston <markj@FreeBSD.org> |
Fix bxe(4) netdump rx polling. Reviewed by: cem, rstone X-MFC with: r333287 Sponsored by: Dell EMC Isilon
|
#
6eadb68b |
|
05-May-2018 |
Mark Johnston <markj@FreeBSD.org> |
Add netdump support to bxe(4). Tested with a NetXtreme II BCM57810 adapter. Reviewed by: davidcs MFC after: 1 month Sponsored by: Dell EMC Isilon Differential Revision: https://reviews.freebsd.org/D15257
|
#
cbbd5be0 |
|
25-Apr-2018 |
David C Somayajulu <davidcs@FreeBSD.org> |
Fix Issue with adding MUltiCast Addresses. When multicast addresses are added/deleted, the delete the multicast addresses previously programmed in HW and reprogram the new set of multicast addresses. Submitted by:Vaishali.Kulkarni@cavium.com MFC after:5 days
|
#
c93a3334 |
|
10-Jan-2018 |
Pedro F. Giffuni <pfg@FreeBSD.org> |
dev/bxe: make use of mallocarray(9). Use mallocarray in a couple of cases where a calloc-like operation is taking place.
|
#
7282444b |
|
20-Nov-2017 |
Pedro F. Giffuni <pfg@FreeBSD.org> |
sys/dev: further adoption of SPDX licensing ID tags. Mainly focus on files that use BSD 3-Clause license. The Software Package Data Exchange (SPDX) group provides a specification to make it easier for automated tools to detect and summarize well known opensource licenses. We are gradually adopting the specification, noting that the tags are considered only advisory and do not, in any way, superceed or replace the license texts. Special thanks to Wind River for providing access to "The Duke of Highlander" tool: an older (2014) run over FreeBSD tree was useful as a starting point.
|
#
27a8713f |
|
19-Jul-2017 |
Andrey V. Elsukov <ae@FreeBSD.org> |
Add HPE FlexFabric 10Gb 4-port 536FLR-T device id to the bxe(4) driver. Tested by: David Miguel Almas <dmalmas gmail com> MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D11478
|
#
7a1297c8 |
|
27-Feb-2017 |
David C Somayajulu <davidcs@FreeBSD.org> |
1. state checks in bxe_tx_mq_start_locked() and bxe_tx_mq_start() to sync threads during interface down or detach. 2. add sysctl to set pause frame parameters 3. increase max segs for TSO packets to BXE_TSO_MAX_SEGMENTS (32) 4. add debug messages for PHY 5. HW LRO support restricted to FreeBSD versions 8.x and above. Submitted by:Vaishali.Kulkarni@cavium.com MFC after:5 days
|
#
f33f887e |
|
15-Feb-2017 |
Roger Pau Monné <royger@FreeBSD.org> |
bxe: enable usage with NetXtreme II BCM57840 2x20GbE chip Current bxe probe function won't attach to devices with the NetXtreme II BCM57840 2x20GbE chip, enable it by adding it's chip ID to the list of supported chips. Tested on: HP ProLiant WS460c Gen9 Reviewed by: gnn MFC after: 1 week Sponsored by: Citrix Systems R&D Differential Revision: https://reviews.freebsd.org/D9609
|
#
4f3a4c01 |
|
05-Nov-2016 |
Sean Bruno <sbruno@FreeBSD.org> |
r266979 missed a call to enable capabilities of the hw leading to an inability to enable features of the device. PR: 213845 Submitted by: pherman@frenchfries.net MFC after: 1 week
|
#
16486169 |
|
24-Oct-2016 |
Bryan Drewery <bdrewery@FreeBSD.org> |
Use proper if_getdrvflags() API. This is a NOP. Sponsored by: Dell EMC Isilon
|
#
c7873d96 |
|
18-Oct-2016 |
David C Somayajulu <davidcs@FreeBSD.org> |
1. Use taskqueue_create() instead of taskqueue_create_fast() for both fastpath and slowpath taskqueues. 2. Service all transmits in taskqueue threads. 3. additional stats counters for keeping track of - bd availability - tx buf ring not emptied in the fp task queue. These are drained via timeout taskqueue. - tx attempts during link down. MFC after: 5 days
|
#
106961b6 |
|
30-Sep-2016 |
David C Somayajulu <davidcs@FreeBSD.org> |
Revert commit r306284 - Fixes for issues under high workloads Will fix and recommit patch
|
#
678b8d82 |
|
23-Sep-2016 |
David C Somayajulu <davidcs@FreeBSD.org> |
Fixes for issues under high workloads MFC after:5 days
|
#
f0be707d |
|
09-Aug-2016 |
Pedro F. Giffuni <pfg@FreeBSD.org> |
sys/dev: replace comma with semicolon when pertinent. Uses of commas instead of a semicolons can easily go undetected. The comma can serve as a statement separator but this shouldn't be abused when statements are meant to be standalone. Detected with devel/coccinelle following a hint from DragonFlyBSD. MFC after: 1 month
|
#
f57637a4 |
|
08-Aug-2016 |
Ryan Stone <rstone@FreeBSD.org> |
Don't enqueue NULL on a drbr In one corner case in the bxe TX path, a NULL mbuf could be enqueued onto a drbr queue. This could case a KASSERT to fire with INVARIANTS enabled, or the processing of packets from the queue to be prematurely ended later on. Submitted by: Matt Joras (matt.joras AT isilon.com) Reviewed by: davidcs MFC after: 3 days Sponsored by: EMC / Isilon Storage Division Differential Revision: https://reviews.freebsd.org/D7041
|
#
dde1276e |
|
12-May-2016 |
Scott Long <scottl@FreeBSD.org> |
Don't jam the softc in the device_probe routine. The softc isn't owned by the driver here, so it shouldn't be accessed, let alone written to. Remove the nearby debug line, it's the only thing that depended on the softc, and it depended on it in a way that couldn't work in this part of the code. This fixes some reports of use-after-free and system instability with DEBUG_MEMGUARD enabled. Submitted by: Matthew Macy MFC after: 3 days
|
#
453130d9 |
|
02-May-2016 |
Pedro F. Giffuni <pfg@FreeBSD.org> |
sys/dev: minor spelling fixes. Most affect comments, very few have user-visible effects.
|
#
e5baa39a |
|
22-Apr-2016 |
David C Somayajulu <davidcs@FreeBSD.org> |
Remove Unused/Dead Code MFC after:5 days
|
#
6f39c760 |
|
19-Apr-2016 |
David C Somayajulu <davidcs@FreeBSD.org> |
1. modify fwdump (a.k.a grcdump) so that grcdump memory is allocated and freed on as needed basis. 2. grcdump can be taken at failure points by invoking bxe_grc_dump() when trigger_grcdump sysctl flag is set. When grcdump is taken grcdump_done sysctl flag is set. 3. grcdump_done can be monitored by the user to retrieve the grcdump. Submitted by:vaishali.kulkarni@qlogic.com
|
#
3e8a5445 |
|
13-Apr-2016 |
David C Somayajulu <davidcs@FreeBSD.org> |
reversed commits r297916 r297909 r297898 due to i386 build failures. MFC after:5 days
|
#
9f4d1b48 |
|
13-Apr-2016 |
David C Somayajulu <davidcs@FreeBSD.org> |
Fix compilation error on i386
|
#
9bca1d24 |
|
12-Apr-2016 |
David C Somayajulu <davidcs@FreeBSD.org> |
Fix build failure on i386. Need to typecast a bunch of variables to (uintmax_t) MFC after:5 days
|
#
6dbd80fa |
|
12-Apr-2016 |
David C Somayajulu <davidcs@FreeBSD.org> |
1. modify fwdump (a.k.a grcdump) memory is allocated and freed on as needed basis. 2. grcdump can be taken at failure points by invoking bxe_grc_dump() when trigger_grcdump sysctl flag is set. When grcdump is taken grcdump_done sysctl flag is set. 3. grcdump_done can be monitored by the user to retrieve the grcdump. Submitted by:vaishali.kulkarni@qlogic.com Approved by:davidcs@freebsd.org MFC after:5 days
|
#
6ba5a1d9 |
|
12-Apr-2016 |
David C Somayajulu <davidcs@FreeBSD.org> |
Add support for Flash Update Submitted by:nrapendra.singh@qlogic.com;vaishali.kulkarni@qlogic.com;davidcs@freebsd.org Approved by:davidcs@freebsd.org MFC after:5 days
|
#
b1d45902 |
|
12-Apr-2016 |
David C Somayajulu <davidcs@FreeBSD.org> |
1. Process tx completions in bxe_periodic_callout_func() and restart transmissions if possible. 2. For SIOCSIFFLAGS call bxe_init_locked() only if !BXE_STATE_DISABLED 3. remove code not needed in bxe_init_internal_common() Submitted by:vaishali.kulkarni@qlogic.com;venkata.bhavaraju@qlogic.com Approved by:davidcs@freebsd.org MFC after:5 days
|
#
74b8d63d |
|
10-Apr-2016 |
Pedro F. Giffuni <pfg@FreeBSD.org> |
Cleanup unnecessary semicolons from the kernel. Found with devel/coccinelle.
|
#
32020557 |
|
21-Mar-2016 |
David C Somayajulu <davidcs@FreeBSD.org> |
Modifications to achieve a common source base from FreeBSD7.x thru 10.x MFC after:5 days
|
#
da1b038a |
|
17-Mar-2016 |
Justin Hibbits <jhibbits@FreeBSD.org> |
Use uintmax_t (typedef'd to rman_res_t type) for rman ranges. On some architectures, u_long isn't large enough for resource definitions. Particularly, powerpc and arm allow 36-bit (or larger) physical addresses, but type `long' is only 32-bit. This extends rman's resources to uintmax_t. With this change, any resource can feasibly be placed anywhere in physical memory (within the constraints of the driver). Why uintmax_t and not something machine dependent, or uint64_t? Though it's possible for uintmax_t to grow, it's highly unlikely it will become 128-bit on 32-bit architectures. 64-bit architectures should have plenty of RAM to absorb the increase on resource sizes if and when this occurs, and the number of resources on memory-constrained systems should be sufficiently small as to not pose a drastic overhead. That being said, uintmax_t was chosen for source clarity. If it's specified as uint64_t, all printf()-like calls would either need casts to uintmax_t, or be littered with PRI*64 macros. Casts to uintmax_t aren't horrible, but it would also bake into the API for resource_list_print_type() either a hidden assumption that entries get cast to uintmax_t for printing, or these calls would need the PRI*64 macros. Since source code is meant to be read more often than written, I chose the clearest path of simply using uintmax_t. Tested on a PowerPC p5020-based board, which places all device resources in 0xfxxxxxxxx, and has 8GB RAM. Regression tested on qemu-system-i386 Regression tested on qemu-system-mips (malta profile) Tested PAE and devinfo on virtualbox (live CD) Special thanks to bz for his testing on ARM. Reviewed By: bz, jhb (previous) Relnotes: Yes Sponsored by: Alex Perez/Inertial Computing Differential Revision: https://reviews.freebsd.org/D4544
|
#
988f26f9 |
|
09-Mar-2016 |
David C Somayajulu <davidcs@FreeBSD.org> |
Fix code so that buf_ring allocation for Tx Queues and their mutexes is done during during bxe_attach() and freed during bxe_detach() MFC after: 5 days
|
#
cbc4d2db |
|
01-Mar-2016 |
John Baldwin <jhb@FreeBSD.org> |
Remove taskqueue_enqueue_fast(). taskqueue_enqueue() was changed to support both fast and non-fast taskqueues 10 years ago in r154167. It has been a compat shim ever since. It's time for the compat shim to go. Submitted by: Howard Su <howard0su@gmail.com> Reviewed by: sephe Differential Revision: https://reviews.freebsd.org/D5131
|
#
4ef8ebfd |
|
25-Feb-2016 |
David C Somayajulu <davidcs@FreeBSD.org> |
Upgrade the firmware carried in driver and loaded during hardware initialization (a.k.a STORM firmware) to version 7.13.1 (latest version)
|
#
bb329d4b |
|
19-Feb-2016 |
David C Somayajulu <davidcs@FreeBSD.org> |
Remove dead code. Code Cleanup. Improve clarity in debug messages MFC after:5 days
|
#
34b133bc |
|
19-Feb-2016 |
David C Somayajulu <davidcs@FreeBSD.org> |
Modified the use of bxe_grc_dump() function so that it can be invoked directly at any potential error path, where a fwdump is needed. The fwdump (a.k.a grcdump) is stored in a driver buffer. The sysctl grcdump_done indicates if a fwdump was taken and waiting to be retrieved. The sysctl trigger_grcdump can be used to manually trigger a fwdump. MFC after:5 days
|
#
29e60198 |
|
22-Dec-2015 |
David C Somayajulu <davidcs@FreeBSD.org> |
Add support for firmware dump (a.k.a grcdump) MFC after:5 days
|
#
6dbbc5f6 |
|
22-Dec-2015 |
David C Somayajulu <davidcs@FreeBSD.org> |
Check for packet_length is greater than 60 bytes as well as packet_length is greater than len_on_bd, before invoking the routine to handle jumbo over SGL (bxe_service_rxsgl()). Add counters for number of jumbo_over_SGL packets (rx_bxe_service_rxsgl) and erroneous jumbo_over_SGL packets (rx_erroneous_jumbo_sge_pkts) Fix formatting in bxe_sysctl_state() MFC after:5 days
|
#
56c55e65 |
|
12-Oct-2015 |
David C Somayajulu <davidcs@FreeBSD.org> |
Add support for reading device temperature MFC after:5 days
|
#
ab97207a |
|
28-Jul-2015 |
David C Somayajulu <davidcs@FreeBSD.org> |
- Avoid lock contention in the if_transmit callback by using trylock and enqueueing the frames when it fails. This way there is some latency removed from the transmitting path. - If IFF_DRV_OACTIVE is set (and also if IFF_DRV_RUNNING is not) just enqueue the desired frames and return successful transmit. This way we avoid to return errors on transmit side and resulting in possible out-of-order frames. Please note that IFF_DRV_OACTIVE is set everytime we get the threshold ring hit, so this can be happening quite often. Submitted by: Attilio.Rao@isilon.com MFC after:5 days
|
#
c197bf4f |
|
23-Jun-2015 |
David C Somayajulu <davidcs@FreeBSD.org> |
tx_mtx should be grabbed before calling buf_ring_dequeue_sc() Submitted by:Attilio.Rao@isilon.com MFC after:5 days
|
#
284d94cf |
|
20-Jun-2015 |
David C Somayajulu <davidcs@FreeBSD.org> |
Simplified implementation of bxe_set_mc_list() removed bxe_free_mcast_macs_list() and bxe_init_mcast_macs_list() fixed bug where copy of multicast list mta was deleted prior to passing the list to firmware MFC after:5 days
|
#
9987f305 |
|
16-Jun-2015 |
David C Somayajulu <davidcs@FreeBSD.org> |
In bxe_init_mcast_macs_list(): mc_mac->mac needs to point to the multicast mac address In bxe_set_mc_list(): added missing BXE_MCAST_UNLOCK() In __ecore_vlan_mac_h_exec_pending(): need to check for ECORE_PENDING Submitted by:gary.zambrano@qlogic.com
|
#
04e9541d |
|
12-Jun-2015 |
David C Somayajulu <davidcs@FreeBSD.org> |
PHY LOCK acquires the hardware lock via bxe_acquire_phy_lock() and releases it via bxe_release_phy_lock(). It was simply acquiring a mutex earlier which can cause the PHY to use bogus values. Fixes intermittent link failures. bxe_ioctl() completes all functions within its context as opposed to a taskqueue earlier. bxe_handle_rx_mode_tq() no longer required. bxe_set_rx_mode() handles the functionality within its context Submitted by:gary.zambrano@qlogic.com MFC after:5 days
|
#
bfdeba0c |
|
21-May-2015 |
David C Somayajulu <davidcs@FreeBSD.org> |
Add stat counters for Jumbo Frames using SGE ring. Also remove the checks for IFCAP_LRO in bxe_alloc_fp_buffers() and bxe_pf_rx_q_prep() since both TPA and Jumbo can use SGE ring. Submitted by:gary.zambrano@qlogic.com Approved by:davidcs@freebsd.org MFC after:5 days
|
#
3d60b144 |
|
21-May-2015 |
David C Somayajulu <davidcs@FreeBSD.org> |
Limit the size of the posted receive buffers in Rx Rings to MJUMPAGESIZE. Previously for jumbo MTUs, the rx ring buffers were MTU + any required pad. Now when this size greater than MJUMPAGESIZE, the packet is spanned across multiple buffers and the mbufs are stiched together. Submitted by:gary.zambrano@qlogic.com Approved by:davidcs@freebsd.org
|
#
16a38a93 |
|
02-Apr-2015 |
David C Somayajulu <davidcs@FreeBSD.org> |
When an mbuf allocation fails in the receive path, the mbuf containing the received packet is not sent to the host net work stack and is reused again on the receive ring. Remaining received packets in the ring are not processed in that invocation of bxe_rxeof() and defered to the task thread. MFC after: 5 days
|
#
c2529042 |
|
01-Dec-2014 |
Hans Petter Selasky <hselasky@FreeBSD.org> |
Start process of removing the use of the deprecated "M_FLOWID" flag from the FreeBSD network code. The flag is still kept around in the "sys/mbuf.h" header file, but does no longer have any users. Instead the "m_pkthdr.rsstype" field in the mbuf structure is now used to decide the meaning of the "m_pkthdr.flowid" field. To modify the "m_pkthdr.rsstype" field please use the existing "M_HASHTYPE_XXX" macros as defined in the "sys/mbuf.h" header file. This patch introduces new behaviour in the transmit direction. Previously network drivers checked if "M_FLOWID" was set in "m_flags" before using the "m_pkthdr.flowid" field. This check has now now been replaced by checking if "M_HASHTYPE_GET(m)" is different from "M_HASHTYPE_NONE". In the future more hashtypes will be added, for example hashtypes for hardware dedicated flows. "M_HASHTYPE_OPAQUE" indicates that the "m_pkthdr.flowid" value is valid and has no particular type. This change removes the need for an "if" statement in TCP transmit code checking for the presence of a valid flowid value. The "if" statement mentioned above is now a direct variable assignment which is then later checked by the respective network drivers like before. Additional notes: - The SCTP code changes will be committed as a separate patch. - Removal of the "M_FLOWID" flag will also be done separately. - The FreeBSD version has been bumped. MFC after: 1 month Sponsored by: Mellanox Technologies
|
#
f0188618 |
|
21-Oct-2014 |
Hans Petter Selasky <hselasky@FreeBSD.org> |
Fix multiple incorrect SYSCTL arguments in the kernel: - Wrong integer type was specified. - Wrong or missing "access" specifier. The "access" specifier sometimes included the SYSCTL type, which it should not, except for procedural SYSCTL nodes. - Logical OR where binary OR was expected. - Properly assert the "access" argument passed to all SYSCTL macros, using the CTASSERT macro. This applies to both static- and dynamically created SYSCTLs. - Properly assert the the data type for both static and dynamic SYSCTLs. In the case of static SYSCTLs we only assert that the data pointed to by the SYSCTL data pointer has the correct size, hence there is no easy way to assert types in the C language outside a C-function. - Rewrote some code which doesn't pass a constant "access" specifier when creating dynamic SYSCTL nodes, which is now a requirement. - Updated "EXAMPLES" section in SYSCTL manual page. MFC after: 3 days Sponsored by: Mellanox Technologies
|
#
df360178 |
|
18-Sep-2014 |
Gleb Smirnoff <glebius@FreeBSD.org> |
- Use if_inc_counter() to increment various counters. - Do not ever set a counter to a value. For those counters that we don't increment, but return directly from hardware create cases in if_get_counter() method. Sponsored by: Netflix Sponsored by: Nginx, Inc.
|
#
09a8241f |
|
30-Aug-2014 |
Gleb Smirnoff <glebius@FreeBSD.org> |
It is actually possible to have if_t a typedef to non-void type, and keep both converted to drvapi and non-converted drivers compilable. o Make if_t typedef to struct ifnet *. o Remove shim functions. Sponsored by: Netflix Sponsored by: Nginx, Inc.
|
#
e3a36fb0 |
|
18-Jul-2014 |
David C Somayajulu <davidcs@FreeBSD.org> |
Initiate error recovery stats fail to update after 3 retries. Change bxe_panic() ECORE_DBG_BREAK_IF() ECORE_BUG() ECORE_BUG_ON() to panic only if ECORE_STOP_ON_ERROR is defined. MFC after:5 days
|
#
af3b2549 |
|
27-Jun-2014 |
Hans Petter Selasky <hselasky@FreeBSD.org> |
Pull in r267961 and r267973 again. Fix for issues reported will follow.
|
#
37a107a4 |
|
27-Jun-2014 |
Glen Barber <gjb@FreeBSD.org> |
Revert r267961, r267973: These changes prevent sysctl(8) from returning proper output, such as: 1) no output from sysctl(8) 2) erroneously returning ENOMEM with tools like truss(1) or uname(1) truss: can not get etype: Cannot allocate memory
|
#
3da1cf1e |
|
27-Jun-2014 |
Hans Petter Selasky <hselasky@FreeBSD.org> |
Extend the meaning of the CTLFLAG_TUN flag to automatically check if there is an environment variable which shall initialize the SYSCTL during early boot. This works for all SYSCTL types both statically and dynamically created ones, except for the SYSCTL NODE type and SYSCTLs which belong to VNETs. A new flag, CTLFLAG_NOFETCH, has been added to be used in the case a tunable sysctl has a custom initialisation function allowing the sysctl to still be marked as a tunable. The kernel SYSCTL API is mostly the same, with a few exceptions for some special operations like iterating childrens of a static/extern SYSCTL node. This operation should probably be made into a factored out common macro, hence some device drivers use this. The reason for changing the SYSCTL API was the need for a SYSCTL parent OID pointer and not only the SYSCTL parent OID list pointer in order to quickly generate the sysctl path. The motivation behind this patch is to avoid parameter loading cludges inside the OFED driver subsystem. Instead of adding special code to the OFED driver subsystem to post-load tunables into dynamically created sysctls, we generalize this in the kernel. Other changes: - Corrected a possibly incorrect sysctl name from "hw.cbb.intr_mask" to "hw.pcic.intr_mask". - Removed redundant TUNABLE statements throughout the kernel. - Some minor code rewrites in connection to removing not needed TUNABLE statements. - Added a missing SYSCTL_DECL(). - Wrapped two very long lines. - Avoid malloc()/free() inside sysctl string handling, in case it is called to initialize a sysctl from a tunable, hence malloc()/free() is not ready when sysctls from the sysctl dataset are registered. - Bumped FreeBSD version to indicate SYSCTL API change. MFC after: 2 weeks Sponsored by: Mellanox Technologies
|
#
717568ad |
|
02-Jun-2014 |
Marcel Moolenaar <marcel@FreeBSD.org> |
Convert bxe(4) to use the driver API. Submitted by: Sreekanth Rupavatharam <rupavath@juniper.net> Obtained from: Juniper Networks, Inc.
|
#
ed062a30 |
|
08-May-2014 |
David C Somayajulu <davidcs@FreeBSD.org> |
Modify Copyright information and other strings to reflect Qlogic Corporation's purchase of Broadcom's NetXtreme business. Added clean option to Makefile Submitted by:David C Somayajulu (davidcs@freebsd.org) QLogic Corporation MFC after:5 days
|
#
e36ffbdd |
|
05-May-2014 |
David C Somayajulu <davidcs@FreeBSD.org> |
Modify Copyright information to reflect Qlogic Corporation's purchase of Broadcom's NetXtreme business Submitted by:David C Somayajulu (davidcs@freebsd.org) QLogic Corporation MFC after:5 days
|
#
b245f96c |
|
12-Mar-2014 |
Gleb Smirnoff <glebius@FreeBSD.org> |
Since 32-bit if_baudrate isn't enough to describe a baud rate of a 10 Gbit interface, in the r241616 a crutch was provided. It didn't work well, and finally we decided that it is time to break ABI and simply make if_baudrate a 64-bit value. Meanwhile, the entire struct if_data was reviewed. o Remove the if_baudrate_pf crutch. o Make all fields of struct if_data fixed machine independent size. The notion of data (packet counters, etc) are by no means MD. And it is a bug that on amd64 we've got a 64-bit counters, while on i386 32-bit, which at modern speeds overflow within a second. This also removes quite a lot of COMPAT_FREEBSD32 code. o Give 16 bit for the ifi_datalen field. This field was provided to make future changes to if_data less ABI breaking. Unfortunately the 8 bit size of it had effectively limited sizeof if_data to 256 bytes. o Give 32 bits to ifi_mtu and ifi_metric. o Give 64 bits to the rest of fields, since they are counters. __FreeBSD_version bumped. Discussed with: emax Sponsored by: Netflix Sponsored by: Nginx, Inc.
|
#
0096a659 |
|
11-Mar-2014 |
Eric Davis <edavis@FreeBSD.org> |
Fixed MSI interrupt allocation and handling. Fixed a DMA mapping leak that occurs when defragmenting packet chains. Approved by: davidch (mentor) MFC after: 1 week
|
#
b8c83a19 |
|
16-Jan-2014 |
Gleb Smirnoff <glebius@FreeBSD.org> |
Another round of removing historical mbuf(9) allocator flags. They are breeding! New ones arouse since last round. Sponsored by: Nginx, Inc.
|
#
0f25d857 |
|
07-Jan-2014 |
Eric Davis <edavis@FreeBSD.org> |
defragment mbuf chains longer than hw segment limit before dropping Approved by: davidch
|
#
ae02949d |
|
30-Dec-2013 |
Eric Davis <edavis@FreeBSD.org> |
For TSO, when the first mbuf contains both the packet header and data, the header is split out into its own BD for processing by the firmware. When this split occurred the data length in the BD was not being set correctly resulting in packet corruption. Approved by: davidcd (mentor)
|
#
7d1af5ca |
|
26-Dec-2013 |
Dimitry Andric <dim@FreeBSD.org> |
In sys/dev/bxe/bxe.c, remove static function bxe_has_tx_work_unload(), which has never been used. Reviewed by: edavis MFC after: 3 days
|
#
5e33beca |
|
15-Nov-2013 |
Eric Davis <edavis@FreeBSD.org> |
Fixed a tx watchdog chip reset that could occur on mostly idle links. Fixed various link related issues and 10GBaseT is now linking properly. Modified the types for the driver tunables to be consistent with the sysctl APIs. Approved by: davidch (mentor)
|
#
8467a7dc |
|
11-Oct-2013 |
Dimitry Andric <dim@FreeBSD.org> |
In sys/dev/bxe/bxe.c, print bus_addr_t values using %#jx, to fix several gcc warnings for PAE kernels. Approved by: re (glebius) Reviewed by: davidch, edavis
|
#
2bd40797 |
|
10-Oct-2013 |
Eric Davis <edavis@FreeBSD.org> |
Fixed the media type shown via ifconfig. Fixed a panic that occurs when bringing up an interface on 57710/57711 running very old bootcode versions. Fixed how bool is defined for those who have been using this code on older versions of FreeBSD. Approved by: re@ (gjb) Approved by: davidch (mentor)
|
#
4e400768 |
|
20-Sep-2013 |
David Christensen <davidch@FreeBSD.org> |
Substantial rewrite of bxe(4) to add support for the BCM57712 and BCM578XX controllers. Approved by: re MFC after: 4 weeks
|