#
e2ad879d |
|
13-Jun-2024 |
Ed Maste <emaste@FreeBSD.org> |
ifconfig: make interface address without mask an error In commit d8237b955528, as part of the deprecation of IPv4 address classes, Mike Karels introduced a warning in ifconfig for setting an address without a width or mask. The commit message says "This will hopefully be an error in the future." As the warning has been included in releases from FreeBSD 13.1 on, and sufficient time has passed, turn this into an error. Reviewed by: allanjude, olce, grembo, philip, gordon Relnotes: Yes Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D45585
|
#
8a9f0fa4 |
|
12-Jun-2024 |
Michael Gmelin <grembo@FreeBSD.org> |
ifconfig: Fix default netmask calculation Reported by: phk Reviewed by: emaste, kp MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D45570
|
#
4f8f43b0 |
|
16-Oct-2023 |
Kristof Provost <kp@FreeBSD.org> |
netlink: cope with growing requests If a request ends up growing beyong the initially allocated space the netlink functions (such as snl_add_msg_attr_u32()) will allocate a new buffer. This invalidates the header pointer we can have received from snl_create_msg_request(). Always use the hdr returned by snl_finalize_msg(). Reviewed by: melifaro MFC after: 1 week Sponsored by: Rubicon Communications, LLC ("Netgate") Differential Revision: https://reviews.freebsd.org/D42223
|
#
eba230af |
|
25-Sep-2023 |
John Baldwin <jhb@FreeBSD.org> |
Purge more stray embedded $FreeBSD$ strings These do not use __FBSDID but instead use bare char arrays. Reviewed by: imp, emaste Differential Revision: https://reviews.freebsd.org/D41957
|
#
a3930cd4 |
|
14-Jun-2023 |
Alexander V. Chernikov <melifaro@FreeBSD.org> |
ifconfig: use default (more rigid) WARNS level. It helps catch more errors at compile time. Reviewed by: kp Differential Revision: https://reviews.freebsd.org/D40536 MFC after: 2 weeks
|
#
3927d0fb |
|
14-Jun-2023 |
Alexander V. Chernikov <melifaro@FreeBSD.org> |
ifconfig: fix -Wunused warnings MFC after: 2 weeks
|
#
85e0016a |
|
13-Jun-2023 |
Alexander V. Chernikov <melifaro@FreeBSD.org> |
ifconfig: remove global 'name' variable. Consistenly use newly-added 'ctx->ifname' as the name of the current target interface. Reviewed By: kp Differential Revision: https://reviews.freebsd.org/D40438 MFC after: 2 weeks
|
#
c6f0602f |
|
13-Jun-2023 |
Alexander V. Chernikov <melifaro@FreeBSD.org> |
ifconfig: pass if_ctx instead of socket to the tunnel handlers. This is a pre-requisite for the global 'name' variable removal. Reviewed By: kp Differential Revision: https://reviews.freebsd.org/D40432 MFC after: 2 weeks
|
#
0c2beef7 |
|
01-Jun-2023 |
Alexander V. Chernikov <melifaro@FreeBSD.org> |
ifconfig: fix warnings #2 Fix all -Wparameter-unused and cast alignment Differential Revision: https://reviews.freebsd.org/D40303 MFC after: 2 weeks
|
#
6d204407 |
|
25-May-2023 |
Alexander V. Chernikov <melifaro@FreeBSD.org> |
ifconfig: fix ifconfig IFX inet[6] ADDR -alias Internally, inet and inet6 family handlers store state for address addition and deletion separately, as, for example, "ifconfig lo0 inet 127.0.0.2/32" triggers a) deletion of the first interface address and b) addition of a new one. The current logic behind handling "-alias" being the last argument is to copy the address from "addition" state to the "deletion" state. It is done by the generic ifconfig code, which explicitly typecasts opaque handler state pointers to "struct ifreq", which doesn't work in the Netlink case. Fix this by introducing family-specific "af_copyaddr" handler, which removes the peeking & typecasting logic from the generic code. Reported by: otis Tested by: otis
|
#
4bf44dd7 |
|
20-May-2023 |
Alexander V. Chernikov <melifaro@FreeBSD.org> |
ifconfig: switch IPv4/IPv6 address manipulations to Netlink. Differential Revision: https://reviews.freebsd.org/D40182
|
#
6e3a9d7f |
|
23-May-2023 |
Alexander V. Chernikov <melifaro@FreeBSD.org> |
ifconfig: introduce `ifconfig_context` to store current global state. The structure consists of all current context - arguments, open sockets, current family and so on. Pass this structure as a first argument to most of the af_ menthods. This allows to propagate and update shared data without using global variables. The diff is pretty large, but de-facto mechanical. All changes except the structure setup in ifconfig[_netlink].c are one-line mechanical changes. Reviewed by: kp Differential Revision: https://reviews.freebsd.org/D40239 MFC after: 2 weeks
|
#
44cd85d4 |
|
23-May-2023 |
Alexander V. Chernikov <melifaro@FreeBSD.org> |
ifconfig: cleanup warnings #1 Cleanup compiler warnings in preparation to set Wextra and remove WARNS?=2 Differential Revision: https://reviews.freebsd.org/D40238 MFC after: 2 weeks
|
#
26056fa8 |
|
22-May-2023 |
Alexander V. Chernikov <melifaro@FreeBSD.org> |
Revert "ifconfig: switch IPv4/IPv6 address manipulations to Netlink" Revert the change as 2 non-expected issues have been reported. This reverts commit 54418f79fd292e14abf121f87a3c790a17447971.
|
#
454d72ec |
|
22-May-2023 |
Alexander V. Chernikov <melifaro@FreeBSD.org> |
Revert "ifconfig: Fix the build" This reverts commit 5b8ce85e1a72d2c9541cb344b4e157f38f6a5d6c.
|
#
5b8ce85e |
|
22-May-2023 |
Mark Johnston <markj@FreeBSD.org> |
ifconfig: Fix the build Fix indentation in warn_nomask() while here. Fixes: 54418f79fd29 ("ifconfig: switch IPv4/IPv6 address manipulations to Netlink")
|
#
54418f79 |
|
20-May-2023 |
Alexander V. Chernikov <melifaro@FreeBSD.org> |
ifconfig: switch IPv4/IPv6 address manipulations to Netlink Subscribers: imp Differential Revision: https://reviews.freebsd.org/D40182
|
#
a72b7890 |
|
19-May-2023 |
Alexander V. Chernikov <melifaro@FreeBSD.org> |
ifconfig: simplify carp vhid setup. Currently carp implementation peeks into the opaque 'afp->af_addreq' buffer, assumes it knows the af-specific layout and assigns vhid directly. Simplify the code and remove abstraction leak by introducing per-afp callback for setting vhid. This change is a pre-requisite to set addresses via Netlink, as Netlink implementiation uses different structure layout. Reviewed by: kp Differential Revision: https://reviews.freebsd.org/D40160 MFC after: 2 weeks
|
#
4c91a5df |
|
10-May-2023 |
Alexander V. Chernikov <melifaro@FreeBSD.org> |
ifconfig: make interface and address listing use Netlink as transport Differential Revision: https://reviews.freebsd.org/D40044
|
#
d1cd0344 |
|
14-May-2023 |
Alexander V. Chernikov <melifaro@FreeBSD.org> |
ifconfig: split printing functions into smaller per-type chunks. This change is a prerequisite for netlink conversion. No functional changes intended. Reviewed by: kp Differential Revision: https://reviews.freebsd.org/D40033 MFC after: 2 weeks
|
#
d8237b95 |
|
28-Oct-2021 |
Mike Karels <karels@FreeBSD.org> |
ifconfig: warn if setting an Internet address without mask Add a postproc function for af_inet, and add interface flags as a parameter. Check there if setting an address without a mask unless the interface is loopback or point-to-point, where mask is not really meaningful; warn if so. This will hopefully be an error in the future. MFC after: 1 month Reviewd by: bz Differential Revision: https://reviews.freebsd.org/D32709
|
#
d309dcbc |
|
25-Feb-2019 |
Alan Somers <asomers@FreeBSD.org> |
ifconfig: eliminate trailing whitespace Eliminate trailing whitespace on inet, inet6, and groups lines. I think the "list txpower" command will still show some, but I'm not able to test that. PR: 153731 Reported-by: Nikolay Denev <ndenev@gmail.com> MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D19004
|
#
cd851487 |
|
25-Feb-2019 |
Alan Somers <asomers@FreeBSD.org> |
Create a project branch for fuse(4) work. The branch will be used for a new test suite, bug fixes, and various other enhancements to fuse. Sponsored by: The FreeBSD Foundation
|
#
8a16b7a1 |
|
20-Nov-2017 |
Pedro F. Giffuni <pfg@FreeBSD.org> |
General further adoption of SPDX licensing ID tags. Mainly focus on files that use BSD 3-Clause license. The Software Package Data Exchange (SPDX) group provides a specification to make it easier for automated tools to detect and summarize well known opensource licenses. We are gradually adopting the specification, noting that the tags are considered only advisory and do not, in any way, superceed or replace the license texts. Special thanks to Wind River for providing access to "The Duke of Highlander" tool: an older (2014) run over FreeBSD tree was useful as a starting point.
|
#
fbbd9655 |
|
28-Feb-2017 |
Warner Losh <imp@FreeBSD.org> |
Renumber copyright clause 4 Renumber cluase 4 to 3, per what everybody else did when BSD granted them permission to remove clause 3. My insistance on keeping the same numbering for legal reasons is too pedantic, so give up on that point. Submitted by: Jan Schaumann <jschauma@stevens.edu> Pull Request: https://github.com/freebsd/freebsd/pull/96
|
#
b91a1413 |
|
08-Oct-2016 |
Allan Jude <allanjude@FreeBSD.org> |
Fix spurious white space introduced in r301059 r301059 accidently introduced a subtle change for point to point interfaces where an extra space is inserted before the netmask. This can cause issues for scripts that parse ifconfig output. Submitted by: Kevin Bowling <kevin.bowling@kev009.com> Reviewed by: hiren MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D8199
|
#
776db16a |
|
01-Jun-2016 |
Allan Jude <allanjude@FreeBSD.org> |
Address feedback from hrs@ re: r301059 (ifconfig subnet mask) - Use NI_MAXHOST to size buffers for getnameinfo() - remove non-standard 'full' inet6 address printing - remove 'no scope' option - use strchr(3) to optimize replacing separator character in lladdrs Reviewed by: gnn, jhb Differential Revision: https://reviews.freebsd.org/D2856
|
#
7c2aa744 |
|
31-May-2016 |
Allan Jude <allanjude@FreeBSD.org> |
ifconfig(8) now supports some output formatting options specified by the -f flag or IFCONFIG_FORMAT environment variable, the user can request that inet4 subnet masks be printed in CIDR or dotted-quad notation, in addition to the traditional hex output. inet6 prefixes can be printed in CIDR as well. For more documentation see the ifconfig(8) man page. PR: 169072 Requested by: seanc, marcel, brd, many others Reviewed by: gnn, jhb (earlier version) Relnotes: yes Sponsored by: ScaleEngine Inc. Differential Revision: https://reviews.freebsd.org/D2856
|
#
c8711749 |
|
15-May-2016 |
Don Lewis <truckman@FreeBSD.org> |
Use strlcpy() instead of strncpy() when copying ifname to ensure that it is NUL terminated. Additional NUL padding is not required for short names. Use sizeof(destination) in a few places instead of IFNAMSIZ. Cast afp->af_ridreq and afp->af_addreq to make the intent of the code more obvious. Reported by: Coverity CID: 1009628, 1009630, 1009631, 1009632, 1009633, 1009635, 1009638 CID: 1009639, 1009640, 1009641, 1009642, 1009643, 1009644, 1009645 CID: 1009646, 1009647, 1010049, 1010050, 1010051, 1010052, 1010053 CID: 1010054, 1011293, 1011294, 1011295, 1011296, 1011297, 1011298 CID: 1011299, 1305821, 1351720, 1351721 MFC after: 1 week
|
#
ff129d6f |
|
18-Apr-2016 |
Marcelo Araujo <araujo@FreeBSD.org> |
User NULL instead of 0 for pointers. gethostbyname(3) will return NULL in case of an error. MFC after: 2 weeks.
|
#
4f34db2d |
|
10-May-2015 |
Enji Cooper <ngie@FreeBSD.org> |
Use MIN from sys/param.h instead of handrolling the macro Replace sys/types.h with sys/param.h per-style(9) MFC after: 3 days Sponsored by: EMC / Isilon Storage Division
|
#
56d5e096 |
|
06-Apr-2015 |
Gleb Smirnoff <glebius@FreeBSD.org> |
Stop including if_var.h from userland. Sponsored by: Nginx, Inc.
|
#
92ed4e1a |
|
16-Dec-2011 |
Gleb Smirnoff <glebius@FreeBSD.org> |
Since size of struct in_aliasreq has just been changed in r228571, and thus ifconfig(8) needs recompile, it is a good chance to make parameter checks on SIOCAIFADDR arguments more strict.
|
#
08b68b0e |
|
15-Dec-2011 |
Gleb Smirnoff <glebius@FreeBSD.org> |
A major overhaul of the CARP implementation. The ip_carp.c was started from scratch, copying needed functionality from the old implemenation on demand, with a thorough review of all code. The main change is that interface layer has been removed from the CARP. Now redundant addresses are configured exactly on the interfaces, they run on. The CARP configuration itself is, as before, configured and read via SIOCSVH/SIOCGVH ioctls. A new prefix created with SIOCAIFADDR or SIOCAIFADDR_IN6 may now be configured to a particular virtual host id, which makes the prefix redundant. ifconfig(8) semantics has been changed too: now one doesn't need to clone carpXX interface, he/she should directly configure a vhid on a Ethernet interface. To supply vhid data from the kernel to an application the getifaddrs(8) function had been changed to pass ifam_data with each address. [1] The new implementation definitely closes all PRs related to carp(4) being an interface, and may close several others. It also allows to run a single redundant IP per interface. Big thanks to Bjoern Zeeb for his help with inet6 part of patch, for idea on using ifam_data and for several rounds of reviewing! PR: kern/117000, kern/126945, kern/126714, kern/120130, kern/117448 Reviewed by: bz Submitted by: bz [1]
|
#
8d7813e7 |
|
19-Nov-2011 |
Gleb Smirnoff <glebius@FreeBSD.org> |
For unknown reason, since rev 1.1 of ifconfig.c, sin_family isn't set properly for the mask argument. Since I'd like to improve argument sanity checking in kernel side, in in_control(), fix this.
|
#
ad2571a2 |
|
18-Jul-2011 |
Bjoern A. Zeeb <bz@FreeBSD.org> |
If compiling RESCUE always ignore feature_present(3) calls so that a /rescue/ifconfig more modern than the kernel could still configure IPv4 or IPv6 addresses. Reported by: Andrzej Tobola (ato iem.pw.edu.pl) Reported by: gcooper MFC after: 1 day X-MFC: will not MFC any time soon, just reminder for r222527
|
#
5af3fa9a |
|
31-May-2011 |
Bjoern A. Zeeb <bz@FreeBSD.org> |
Conditionally compile in the af_inet and af_inet6, af_nd6 modules. If compiled in for dual-stack use, test with feature_present(3) to see if we should register the IPv4/IPv6 address family related options. In case there is no "inet" support we would love to go with the usage() and make the address family mandatory (as it is for anything but inet in theory). Unfortunately people are used to ifconfig IF up/down etc. as well, so use a fallback of "link". Adjust the man page to reflect these minor details. Improve error handling printing a warning in addition to the usage telling that we do not know the given address family in two places. Reviewed by: hrs, rwatson Sponsored by: The FreeBSD Foundation Sponsored by: iXsystems MFC after: 2 weeks
|
#
a7d5f7eb |
|
19-Oct-2010 |
Jamie Gritton <jamie@FreeBSD.org> |
A new jail(8) with a configuration file, to replace the work currently done by /etc/rc.d/jail.
|
#
fe0506d7 |
|
09-Mar-2010 |
Marcel Moolenaar <marcel@FreeBSD.org> |
Create the altix project branch. The altix project will add support for the SGI Altix 350 to FreeBSD/ia64. The hardware used for porting is a two-module system, consisting of a base compute module and a CPU expansion module. SGI's NUMAFlex architecture can be an excellent platform to test CPU affinity and NUMA-aware features in FreeBSD.
|
#
40efe37e |
|
14-Jan-2010 |
Ed Maste <emaste@FreeBSD.org> |
Reject invalid CIDR widths rather than silently stopping at the first non-digit character. Due to an issue with rc(8) in a test configuration, ifconfig was being invoked with the address used again as the width - for example, ifconfig vlan0 10.0.0.1/10.0.0.1 Prior to this change, that address/width would be interpreted as 10.0.0.1/10.
|
#
b59dcaee |
|
23-Jun-2009 |
Xin LI <delphij@FreeBSD.org> |
- Use size_t instead of int when appropriate; - Use C99 sparse initialization. With these changes ifconfig(8) is WARNS=2 clean.
|
#
7e820087 |
|
15-Apr-2009 |
Brooks Davis <brooks@FreeBSD.org> |
The structs ifaliasreq and in_aliasreq have exactly the same layout and member names, but we really do mean to use in_aliasreq here. MFC after: 1 week
|
#
d7f03759 |
|
19-Oct-2008 |
Ulf Lilleengen <lulf@FreeBSD.org> |
- Import the HEAD csup code which is the basis for the cvsmode work.
|
#
cb8c905a |
|
24-Feb-2007 |
Sam Leffler <sam@FreeBSD.org> |
use getifaddrs from libc instead of private code Reviewed by: bms MFC after: 1 month
|
#
73bbc449 |
|
16-Jun-2005 |
Hajimu UMEMOTO <ume@FreeBSD.org> |
only show a tunnel information of an adequate address family. Approved by: re (dwhite)
|
#
5faf8dcb |
|
08-Dec-2004 |
Sam Leffler <sam@FreeBSD.org> |
Overhaul to cleanup some of the tangled logic that's grown over the years. o break per-address family support out into separate files o modularize per-address family and functional operations using a registration mechanism; this permits configuration according to which files you include (but beware that order of the files is important to insure backwards compatibility) o many cleanups to eliminate incestuous behaviour, global variables, and poor coding practices (still much more to fix) The original motivation of this work was to support dynamic addition of functionality based on the interface so we can eliminate the various little control programs and so that vendors can distribute ifconfig plugins that support their in-kernel code. That work is still to be completed. o Update 802.11 support for all the new net80211 functionality; some of these operations (e.g. list *) may be better suited in a different program
|