History log of /freebsd-current/contrib/telnet/telnet/commands.c
Revision Date Author Comments
# a3c85800 27-Nov-2023 Brooks Davis <brooks@FreeBSD.org>

telnet: remove locally added __FBSDID

This partially reverts 77b7cdf1999ee965ad494fddd184b18f532ac91a.

Reviewed by: imp
Differential Revision: https://reviews.freebsd.org/D42704


# 11af9d24 18-Apr-2023 John Baldwin <jhb@FreeBSD.org>

telnet: Use C89 function definitions for two stragglers.

Reviewed by: emaste
Differential Revision: https://reviews.freebsd.org/D39528


# a7399ea2 13-Jul-2022 Cy Schubert <cy@FreeBSD.org>

telnet: Fix telnet segfault when invalid set or help help commands

Silently ignore invalid set ' ' and invalid help help commands.
This is the same fix applied by NetBSD in hg commit 1019940:4f248823eaff.

PR: 265097
Reported by: Simon Josefsson <simon@josefsson.org>
Obtained from: NetBSD hg commit 1019940:4f248823eaff
NetBSD PR/56918
MFC after: 1 week


# 224c772c 21-Jun-2021 Edward Tomasz Napierala <trasz@FreeBSD.org>

telnet(1): add quiet mode ("telnet -Q")

Reviewed By: imp, phk
Sponsored by: NetApp, Inc.
Sponsored by: Klara, Inc.
X-NetApp-PR: #54
Differential Revision: https://reviews.freebsd.org/D30819


# 83129c0b 15-Aug-2019 Ed Maste <emaste@FreeBSD.org>

telnet: remove 3rd clause from Berkeley copyrights

Per the July 22, 1999 letter (in /COPYRIGHT) from
William Hoskins
Director, Office of Technology Licensing
University of California, Berkeley

MFC after: 1 week


# deffed6e 01-Aug-2019 Ed Maste <emaste@FreeBSD.org>

telnet: use asprintf for r349890 change

Suggested by: imp
MFC after: 3 weeks
Sponsored by: The FreeBSD Foundation


# 6071f00f 10-Jul-2019 Philip Paeps <philip@FreeBSD.org>

telnet: fix minor style violation

While here also fix a very unlikely NULL pointer dereference.

Submitted by: Shawn Webb <shawn.webb@hardenedbsd.org>


# e68ce1cc 10-Jul-2019 Philip Paeps <philip@FreeBSD.org>

telnet: fix a couple of snprintf() buffer overflows

Obtained from: Juniper Networks
MFC after: 1 week


# 866616de 30-Aug-2016 Dimitry Andric <dim@FreeBSD.org>

Fix warnings in telnet about invalid constant conversions, e.g.:

contrib/telnet/telnet/commands.c:2914:13: error: implicit conversion
from 'int' to 'char' changes value from 137 to -119
[-Werror,-Wconstant-conversion]
*lsrp++ = IPOPT_SSRR;
~ ^~~~~~~~~~
/usr/include/netinet/ip.h:152:21: note: expanded from macro 'IPOPT_SSRR'
#define IPOPT_SSRR 137 /* strict source route */
^~~
contrib/telnet/telnet/commands.c:2916:13: error: implicit conversion
from 'int' to 'char' changes value from 131 to -125
[-Werror,-Wconstant-conversion]
*lsrp++ = IPOPT_LSRR;
~ ^~~~~~~~~~
/usr/include/netinet/ip.h:148:21: note: expanded from macro 'IPOPT_LSRR'
#define IPOPT_LSRR 131 /* loose source route */
^~~

Use unsigned char buffers instead.

MFC after: 1 week


# ad11def5 10-Nov-2014 Enji Cooper <ngie@FreeBSD.org>

Add baud rate support to telnet(1)

This implements part of RFC-2217

It's based off a patch originally written by Sujal Patel at Isilon, and
contributions from other Isilon employees.

PR: 173728
Phabric: D995
Reviewed by: markj, markm
MFC after: 2 weeks
Sponsored by: EMC / Isilon Storage Division


# a7d5f7eb 19-Oct-2010 Jamie Gritton <jamie@FreeBSD.org>

A new jail(8) with a configuration file, to replace the work currently done
by /etc/rc.d/jail.


# f1ce4e8a 07-May-2010 Jilles Tjoelker <jilles@FreeBSD.org>

MFC r207449: telnet: Fix infinite loop if local output generates SIGPIPE.

Instead of catching SIGPIPE and jumping out of the signal handler with
longjmp, ignore it and handle write errors to the local output by exiting
from there. I have changed the error message to mention the local output
instead of NetBSD's wrong "Connection closed by foreign host". Write errors
to the network were already handled by exiting immediately and this now
applies to EPIPE too.

The code assumed that SIGPIPE could only be generated by the network
connection; if it was generated by the local output, it would longjmp out of
the signal handler and write an error message which caused another SIGPIPE.

PR: 19773
Obtained from: NetBSD


# 524461f1 30-Apr-2010 Jilles Tjoelker <jilles@FreeBSD.org>

telnet: Fix infinite loop if local output generates SIGPIPE.

Instead of catching SIGPIPE and jumping out of the signal handler with
longjmp, ignore it and handle write errors to the local output by exiting
from there. I have changed the error message to mention the local output
instead of NetBSD's wrong "Connection closed by foreign host". Write errors
to the network were already handled by exiting immediately and this now
applies to EPIPE too.

The code assumed that SIGPIPE could only be generated by the network
connection; if it was generated by the local output, it would longjmp out of
the signal handler and write an error message which caused another SIGPIPE.

PR: 19773
Obtained from: NetBSD
MFC after: 1 week


# fe0506d7 09-Mar-2010 Marcel Moolenaar <marcel@FreeBSD.org>

Create the altix project branch. The altix project will add support
for the SGI Altix 350 to FreeBSD/ia64. The hardware used for porting
is a two-module system, consisting of a base compute module and a
CPU expansion module. SGI's NUMAFlex architecture can be an excellent
platform to test CPU affinity and NUMA-aware features in FreeBSD.


# d7f03759 19-Oct-2008 Ulf Lilleengen <lulf@FreeBSD.org>

- Import the HEAD csup code which is the basis for the cvsmode work.


# 3a44a4c3 27-Feb-2005 Anton Berezin <tobez@FreeBSD.org>

Increase usefulness of telnet(1) as a protocol tester. By prepending
"+" to the port number, disable option negotiation and allow
transferring of data with high bit set.

OKed by: markm (maintainer)
PR: 52032
Submitted by: Valentin Nechayev <netch maybe-at netch stop kiev stop ua>
MFC After: 2 weeks


# 0d4cc5f6 04-Jan-2005 Maxim Konovalov <maxim@FreeBSD.org>

o Print a correct status for unix domain sockets.
o Restore input mode when return from the command one.

PR: bin/49983
Submitted by: Volker Stolz
OK in general from: markm
MFC after: 1 month


# f95d4633 24-Oct-2003 Hajimu UMEMOTO <ume@FreeBSD.org>

Switch Advanced Sockets API for IPv6 from RFC2292 to RFC3542
(aka RFC2292bis). Though I believe this commit doesn't break
backward compatibility againt existing binaries, it breaks
backward compatibility of API.
Now, the applications which use Advanced Sockets API such as
telnet, ping6, mld6query and traceroute6 use RFC3542 API.

Obtained from: KAME


# 37b3e941 23-Oct-2003 Hajimu UMEMOTO <ume@FreeBSD.org>

EAI_ADDRFAMILY and EAI_NODATA was deprecated in RFC3493
(aka RFC2553bis). Now, getaddrinfo(3) returns EAI_NONAME
instead of EAI_NODATA. Our getaddrinfo(3) nor getnameinfo(3)
didn't use EAI_ADDRFAMILY.

Obtained from: KAME


# 074e8e8e 11-May-2003 Mark Murray <markm@FreeBSD.org>

Fix up external variables named "debug" that have a horrible habit
of conflicting with other, similarly named functions in static
libraries. This is done mostly by renaming the var if it is shared
amongst modules, or making it static otherwise.

OK'ed by: re(scottl)


# 77b7cdf1 03-May-2003 David E. O'Brien <obrien@FreeBSD.org>

Use __FBSDID vs. rcsid[]. Also protect sccs[] and copyright[] from GCC 3.3.


# 0d16d021 26-Nov-2002 Eric Melville <eric@FreeBSD.org>

Merge argument parsing changes into this copy of telnet.

Submitted by: markm
Approved by: bmah


# ba0f77df 01-Oct-2002 Dima Dorfman <dd@FreeBSD.org>

Permit the argument to the -s option to be a hostname. I see no
reason to restrict this to a numeric address.

PR: 41841
Submitted by: Dmitry Pryanishnikov <dmitry@atlantis.dp.ua>,
Maxim Maximov <mcsi@agava.com>


# 86953b02 25-Sep-2002 Mark Murray <markm@FreeBSD.org>

Catch up with "base" telnet.

s/FALL THROUGH/FALLTHROUGH/ for lint(1).
s/Usage/usage/ for consistency.


# cc7b0935 10-May-2002 Alfred Perlstein <alfred@FreeBSD.org>

unbreak build:

commands.c, sys_bsd.c: comment out/remove junk after #endif/#else
network.c, terminal.c, utlities.c: include stdlib.h for exit(3)


# de0dff90 03-Dec-2001 John Hay <jhay@FreeBSD.org>

Protect variables and function prototypes that are only used in the INET6
case with an ifdef INET6.

This make the fixit floppy compile again.

Reviewed by: markm


# 54ab3ed8 02-Dec-2001 Mark Murray <markm@FreeBSD.org>

help the alphas out with the WARNS=2 stuff.


# 3138440a 30-Nov-2001 Mark Murray <markm@FreeBSD.org>

Damn. The previous mega-commit was incomplete WRT ANSIfication. This
fixes that.


# 8fa113e5 30-Nov-2001 Mark Murray <markm@FreeBSD.org>

Very large style makeover.

1) ANSIfy.
2) Clean up ifdefs so that
a) ones that never/always apply are appropriately either
fully removed, or just the #if junk is removed.
b) change #if defined(FOO) for appropiate values of FOO.
(currently AUTHENTICATION and ENCRYPTION)
3) WARNS=2 fixing
4) GC other unused stuff

This code can now be unifdef(1)ed to make non-crypto telnet.


# 6b022d00 29-Aug-2001 Mark Murray <markm@FreeBSD.org>

Manually unifdef(1) CRAY, UNICOS, hpux and sun uselsess code.


# 21f083c0 19-Aug-2001 Mark Murray <markm@FreeBSD.org>

Code merge and diff reduce with "base" telnet. This is the "later"
telnet, so it was treated as the reference code, except where later
commits were made to "base" telnet.


# e5c23e88 23-May-2001 Matthew Dillon <dillon@FreeBSD.org>

A feature to allow one to telnet to a unix domain socket. (MFC from
non-crypto version)

Also update the crypto telnet's man page to reflect other options
ported from the non-crypto version.

Obtained from: Lyndon Nerenberg <lyndon@orthanc.ab.ca>


# f6fd83ed 26-Nov-2000 Kris Kennaway <kris@FreeBSD.org>

Correct definition of MAXHOSTNAMELEN in ifdef'ed code.

Submitted by: Edwin Groothuis <mavetju@chello.nl>
PR: bin/22787


# f743d119 19-Nov-2000 Kris Kennaway <kris@FreeBSD.org>

Fix a buffer overflow from a long local hostname.

Obtained from: OpenBSD


# c847fdb1 20-Jul-2000 Hajimu UMEMOTO <ume@FreeBSD.org>

Fix buffer size of ALIGNed buffer.

PR: bin/20053
Submitted by: Alex Kapranoff <alex@kapran.bitmcnit.bryansk.su>


# 1c609034 07-Jul-2000 Hajimu UMEMOTO <ume@FreeBSD.org>

Make telnet -s work. It is corresponding to EAI_NONAME -> EAI_NODATA
change (getaddrinfo.c rev 1.12).


# 7e154dad 06-Jul-2000 Jun-ichiro itojun Hagino <itojun@FreeBSD.org>

sync with usr.bin/telnet/commands.c 1.21 -> 1.22. pierre.dampure@alveley.org


# 46ad1c23 02-Mar-2000 Yoshinobu Inoue <shin@FreeBSD.org>

CMSG_XXX macros alignment fixes to follow RFC2292.

Approved by: jkh


# 81edae92 19-Feb-2000 Yoshinobu Inoue <shin@FreeBSD.org>

Use static buffer to save source route hostnames.

Approved by: jkh


# a82a4df8 19-Feb-2000 Yoshinobu Inoue <shin@FreeBSD.org>

Print "Trying ..." for each host. Also cleanups for error printing.

Approved by: jkh

Submitted by: Ben Smithurst <ben@scientia.demon.co.uk>


# 1d1ade86 15-Feb-2000 Yoshinobu Inoue <shin@FreeBSD.org>

Fix bugs in telnet.

Sorry there were still several bugs.
-error retry at af missmatch was incomplete.
-af matching for source addr option was wrong
-socket was not freed at retry.

Approved by: jkh


# 960e15a7 10-Feb-2000 Yoshinobu Inoue <shin@FreeBSD.org>

Add more dual stack consideration.

-Should retry as much as possible when some of source
routing intermediate hosts' address families missmatch
happened.
(such as when a host has only A record, and another host
has each of A and AAAA record.)

-Should retry as much as possible when dest addr and
source addr(specified with -s option) address family
missmatch happend

Approved by: jkh


# f306e0c8 06-Feb-2000 Yoshinobu Inoue <shin@FreeBSD.org>

Fix telnet core dump at invalid service name specified.
Added an error check to avoid it.

Approved by: jkh

Submitted by: Robert Muir <rmuir@gibralter.net>


# 0bd288cd 29-Jan-2000 Yoshinobu Inoue <shin@FreeBSD.org>

Add NI_NAMEREQD flag to getnameinfo() call. Without this flag,
getnameinfo() don't return error at name resolving failure.
But it is used at doaddrlookup(-N) case in telnet, error need to be
returned to correctly initialize hostname buffer.

Discovered at checking recent KAME repository change, noticed by itojun.


# 4dd8b5ab 27-Jan-2000 Yoshinobu Inoue <shin@FreeBSD.org>

another tcp apps IPv6 updates.(should be make world safe)
ftp, telnet, ftpd, faithd
also telnet related sync with crypto, secure, kerberosIV

Obtained from: KAME project


# c6a00c45 15-Aug-1999 Nick Sayer <nsayer@FreeBSD.org>

Fix int function without return (make consistent with neighbors)


# 42cf8219 17-Jun-1999 Ruslan Ermilov <ru@FreeBSD.org>

Merge from non-crypto version:
- "-N" option
- "-E" security fix
- "-s src_addr" option

Requested by: markm


# 04c426cc 07-Sep-1997 Mark Murray <markm@FreeBSD.org>

Bring the FreeBSD changes to the virgin sources.


# 81cb6ddc 04-Sep-1997 Mark Murray <markm@FreeBSD.org>

Initial import of BSD telnet. This will be used to build the kerberised
telnet, and after userland diffs have been merged in, will be used to
build the non-kerberised sources as well. (See unifdef(1) for details)