125485 |
05-Feb-2004 |
bde |
Fixed some bugs in checkdirty(). The check for the clean bit was combined with the the signature check in a wrong way (basically (dirty:= signature_recognised() && !clean) instead of (mightbedirty:= !signature_recognized || !clean), so file systems with unrecognized signatures were considered clean. Many of the don't-care and reserved bits were not ignored, so some file systems with valid signatures were unrecognized. One of my FAT32 file systems has a signature of f8,ff,ff,ff,ff,ff,ff,f7 when dirty, but only f8,ff,ff,0f,ff,ff,ff,07 was recognised as dirty for FAT32, so the fail-unsafeness made my file system always considered clean.
Check the i/o non-error bit in checkdirty(). Its absence would give an unrecognized signature in code that is unaware of it, but we now mask it out of the signature so we have to check it explicitly. This combines naturally with the check of the clean bit.
Reviewed by: rnordier (except for final details)
|
123917 |
28-Dec-2003 |
bde |
Oops, highly non-KNF indentation is normal for large expressions in this program. Gnu indentation is used for these. Redo the fix for the large expression at the end of the previous commit to give gnu indentation. The original version was gnuish but had 9 bogus extra characters of indentation in its continuation lines, perfect tab lossage on every line, and other bugs.
The previous commit log should have claimed to fix style bugs in the previous-1 commit (1.5), not the forced null previous commit (1.6).
|