#
267654 |
|
19-Jun-2014 |
gjb |
Copy stable/9 to releng/9.3 as part of the 9.3-RELEASE cycle.
Approved by: re (implicit) Sponsored by: The FreeBSD Foundation |
#
225736 |
|
22-Sep-2011 |
kensmith |
Copy head to stable/9 as part of 9.0-RELEASE release cycle.
Approved by: re (implicit)
|
#
174689 |
|
16-Dec-2007 |
deischen |
Remove hacks to allow libkse to export its symbols in the LIBTHREAD_1_0 version namespace which was needed before the library version was bumped.
|
#
174112 |
|
30-Nov-2007 |
deischen |
WARNS=3'ify.
|
#
173967 |
|
27-Nov-2007 |
jasone |
Add _pthread_mutex_init_calloc_cb() to libthr and libkse, so that malloc(3) (part of libc) can use pthreads mutexes without causing infinite recursion during initialization.
|
#
172491 |
|
09-Oct-2007 |
obrien |
Repo copy libpthreads to libkse. This introduces the WITHOUT_LIBKSE nob, and changes WITHOUT_LIBPTHREADS to mean with neither threading libs. Approved by: re(kensmith)
|
#
165967 |
|
12-Jan-2007 |
imp |
Remove 3rd clause, renumber, ok per email
|
#
156611 |
|
12-Mar-2006 |
deischen |
Add compatibility symbol maps. libpthread (.so.1 and .so.2) used LIBTHREAD_1_0 as its version definition, but now needs to define its symbols in the same namespace used by libc. The compatibility hooks allows you to use libraries and binaries built and linked to libpthread before libc was built with symbol versioning. The shims can be removed if libpthread is given a version bump.
Reviewed by: davidxu
|
#
156330 |
|
06-Mar-2006 |
deischen |
Only catch SIGINFO (for dumping thread states) when LIBPTHREAD_DEBUG is defined in the environment.
Requested by: jmg & a few others
|
#
156319 |
|
05-Mar-2006 |
deischen |
Add some more pthread stubs so that librt can use them. The thread jump table has been resorted, so you need to keep libc, libpthread, and libthr in sync.
Submitted by: xu
|
#
150499 |
|
23-Sep-2005 |
brian |
Modify the code path of the ifdef NOTYET part of _kse_single_thread():
o Don't reinitialise the atfork() handler list in the child. We are meant to call the child handler, and on subsequent fork()s should call all three functions as normal. o Don't reinitialise the thread specific keyed data in the child after a fork. Applications may require this for context. o Reinitialise curthread->tlflags after removing ourselves from (and reinitialising) the various internal thread lists. o Reinitialise __malloc_lock in the child after fork() (to balance our explicitly taking the lock prior to the fork()).
With these changes, it is possible to enable the NOTYET code in thr_kern.c to allow the use of non-async-safe functions after fork()ing from a threaded program.
Reviewed by: Daniel Eischen <deischen@freebsd.org> [_malloc_lock reinitialisation has since been moved to avoid polluting the !NOTYET code]
|
#
142047 |
|
18-Feb-2005 |
deischen |
Somewhere along the line, tick accumulation for SA threads was changed to use the statclock. Make sure we calculate the value of a tick correctly in userland.
Noticed by: Kazuaki Oda <kaakun at highway dot ne dot jp>
|
#
141949 |
|
15-Feb-2005 |
deischen |
Set the default guardsize and stacksize in the default thread attribute when the library is initialized.
|
#
141822 |
|
13-Feb-2005 |
deischen |
Increase the default stacksizes:
32-bit 64-bit main thread 2MB 4MB other threads 1MB 2MB
|
#
139023 |
|
18-Dec-2004 |
deischen |
Use a generic way to back threads out of wait queues when handling signals instead of having more intricate knowledge of thread state within signal handling.
Simplify signal code because of above (by David Xu).
Use macros for libpthread usage of pthread_cleanup_push() and pthread_cleanup_pop(). This removes some instances of malloc() and free() from the semaphore and pthread_once() implementations.
When single threaded and forking(), make sure that the current thread's signal mask is inherited by the forked thread.
Use private mutexes for libc and libpthread. Signals are deferred while threads hold private mutexes. This fix also breaks www/linuxpluginwrapper; a patch that fixes it is at http://people.freebsd.org/~deischen/kse/linuxpluginwrapper.diff
Fix race condition in condition variables where handling a signal (pthread_kill() or kill()) may not see a wakeup (pthread_cond_signal() or pthread_cond_broadcast()).
In collaboration with: davidxu
|
#
134115 |
|
21-Aug-2004 |
davidxu |
Pull debug symbols in for statically linked binary.
Reviewed by: desichen
|
#
133563 |
|
12-Aug-2004 |
deischen |
As long as we have a knob to force system scope threads, why not have a knob to force process scope threads. If the environment variable LIBPTHREAD_PROCESS_SCOPE is set, force all threads to be process scope threads regardless of how the application creates them. If LIBPTHREAD_SYSTEM_SCOPE is set (forcing system scope threads), it overrides LIBPTHREAD_PROCESS_SCOPE.
$ # To force system scope threads $ LIBPTHREAD_SYSTEM_SCOPE=anything threaded_app $ # To force process scope threads $ LIBPTHREAD_PROCESS_SCOPE=anything threaded_app
|
#
133269 |
|
07-Aug-2004 |
deischen |
Add a way to force 1:1 mode for libpthread. To do this, define LIBPTHREAD_SYSTEM_SCOPE in the environment.
You can still force libpthread to be built in strictly 1:1 by adding -DSYSTEM_SCOPE_ONLY to CFLAGS. This is kept for archs that don't yet support M:N mode.
Requested by: rwatson Reviewed by: davidxu
|
#
132121 |
|
13-Jul-2004 |
davidxu |
If _libkse_debug is not zero, activate thread mode.
|
#
123047 |
|
29-Nov-2003 |
davidxu |
Remove surplus mmap() call for stack guard page in init_private, it is done in init_main_thread. Also don't initialize lock and lockuser again for initial thread, it is already done by _thr_alloc().
Reviewed by: deischen Approved by: re (scottl)
|
#
122075 |
|
04-Nov-2003 |
deischen |
Add an implementation for pthread_atfork().
Aside from the POSIX requirements for pthread_atfork(), when fork()ing, take the malloc lock to keep malloc state consistent in the child.
Reviewed by: davidxu
|
#
119063 |
|
18-Aug-2003 |
davidxu |
Treat initial thread as scope system thread when KSE mode is not activated yet, so we can protect some locking code from being interrupted by signal handling. When KSE mode is turned on, reset the thread flag to scope process except we are running in 1:1 mode which we needn't turn it off. Also remove some unused member variables in structure kse.
Tested by: deischen
|
#
118747 |
|
10-Aug-2003 |
davidxu |
Initialize rtld lock just before turning on thread mode and uninitialize rtld lock after thread mode shutdown.
|
#
118510 |
|
05-Aug-2003 |
deischen |
Rethink the MD interfaces for libpthread to account for archs that can (or are required to) have per-thread registers.
Tested on i386, amd64; marcel is testing on ia64 and will have some follow-up commits.
Reviewed by: davidxu
|
#
117706 |
|
17-Jul-2003 |
davidxu |
o Eliminate upcall for PTHREAD_SYSTEM_SCOPE thread, now it is system bound thread and when it is blocked, no upcall is generated.
o Add ability to libkse to allow it run in pure 1:1 threading mode, defining SYSTEM_SCOPE_ONLY in Makefile can turn on this option.
o Eliminate code for installing dummy signal handler for sigwait call.
o Add hash table to find thread.
Reviewed by: deischen
|
#
116977 |
|
28-Jun-2003 |
davidxu |
o Use a daemon thread to monitor signal events in kernel, if pending signals were changed in kernel, it will retrieve the pending set and try to find a thread to dispatch the signal. The dispatching process can be rolled back if the signal is no longer in kernel.
o Create two functions _thr_signal_init() and _thr_signal_deinit(), all signal action settings are retrieved from kernel when threading mode is turned on, after a fork(), child process will reset them to user settings by calling _thr_signal_deinit(). when threading mode is not turned on, all signal operations are direct past to kernel.
o When a thread generated a synchoronous signals and its context returned from completed list, UTS will retrieve the signal from its mailbox and try to deliver the signal to thread.
o Context signal mask is now only used when delivering signals, thread's current signal mask is always the one in pthread structure.
o Remove have_signals field in pthread structure, replace it with psf_valid in pthread_signal_frame. when psf_valid is true, in context switch time, thread will backout itself from some mutex/condition internal queues, then begin to process signals. when a thread is not at blocked state and running, check_pending indicates there are signals for the thread, after preempted and then resumed time, UTS will try to deliver signals to the thread.
o At signal delivering time, not only pending signals in thread will be scanned, process's pending signals will be scanned too.
o Change sigwait code a bit, remove field sigwait in pthread_wait_data, replace it with oldsigmask in pthread structure, when a thread calls sigwait(), its current signal mask is backuped to oldsigmask, and waitset is copied to its signal mask and when the thread gets a signal in the waitset range, its current signal mask is restored from oldsigmask, these are done in atomic fashion.
o Two additional POSIX APIs are implemented, sigwaitinfo() and sigtimedwait().
o Signal code locking is better than previous, there is fewer race conditions.
o Temporary disable most of code in _kse_single_thread as it is not safe after fork().
|
#
115828 |
|
04-Jun-2003 |
davidxu |
Only init _thread_sigact once, needn't init it again after a fork().
Obtained from: deischen
|
#
115399 |
|
29-May-2003 |
kan |
Attempt to eliminate PLT relocations from rwlock aquire/release path, making them suitable for direct use by the dynamic loader.
Register libpthread-specific locking API with rtld on startup.
This still has some rough edges with signals which should be addresses later.
Approved by: re (scottl)
|
#
115381 |
|
29-May-2003 |
deischen |
Don't really spin on a spinlock; silently convert it to the same low-level lock used by the libpthread implementation. In the future, we'll eliminate spinlocks from libc but that will wait until after 5.1-release.
Don't call an application signal handler if the handler is the same as the library-installed handler. This seems to be possible after a fork and is the cause of konsole hangs.
Approved by: re@ (jhb)
|
#
115080 |
|
16-May-2003 |
deischen |
Add a method of yielding the current thread with the scheduler lock held (_thr_sched_switch_unlocked()) and use this to avoid dropping the scheduler lock and having the scheduler retake the same lock again.
Add a better way of detecting if a low-level lock is in use.
When switching out a thread due to blocking in the UTS, don't switch to the KSE's scheduler stack only to switch back to another thread. If possible switch to the new thread directly from the old thread and avoid the overhead of the extra context switch.
Check for pending signals on a thread when entering the scheduler and add them to the threads signal frame. This includes some other minor signal fixes.
Most of this was a joint effor between davidxu and myself.
Reviewed by: davidxu Approved by: re@ (blanket for libpthread)
|
#
114295 |
|
30-Apr-2003 |
deischen |
Move the mailbox to the beginning of the thread and align the thread so that the context (SSE FPU state) is also aligned.
|
#
114254 |
|
29-Apr-2003 |
deischen |
Create the thread signal lock as a KSE lock (as opposed to a thread lock).
Better protect access to thread state while searching for threads to handle a signal.
Better protect access to process pending signals while processing a thread in sigwait().
Submitted by: davidxu
|
#
113870 |
|
22-Apr-2003 |
deischen |
Add a couple asserts to pthread_cond_foo to ensure the (low-level) lock level is 0. Thus far, the threads implementation doesn't use mutexes or condition variables so the lock level should be 0.
Save the return value when trying to schedule a new thread and use this to return an error from pthread_create().
Change the max sleep time for an idle KSE to 1 minute from 2 minutes.
Maintain a count of the number of KSEs within a KSEG.
With these changes scope system threads seem to work, but heavy use of them crash the kernel (supposedly VM bugs).
|
#
113661 |
|
18-Apr-2003 |
deischen |
Sorry folks; I accidentally committed a patch from what I was working on a couple of days ago. This should be the most recent changes.
Noticed by: davidxu
|
#
113658 |
|
18-Apr-2003 |
deischen |
Revamp libpthread so that it has a chance of working in an SMP environment. This includes support for multiple KSEs and KSEGs.
The ability to create more than 1 KSE via pthread_setconcurrency() is in the works as well as support for PTHREAD_SCOPE_SYSTEM threads. Those should come shortly.
There are still some known issues which davidxu and I are working on, but it'll make it easier for us by committing what we have.
This library now passes all of the ACE tests that libc_r passes with the exception of one. It also seems to work OK with KDE including konqueror, kwrite, etc. I haven't been able to get mozilla to run due to lack of java plugin, so I'd be interested to see how it works with that.
Reviewed by: davidxu
|
#
111035 |
|
17-Feb-2003 |
mini |
Deliver signals posted via an upcall to the appropriate thread.
|
#
106786 |
|
11-Nov-2002 |
mini |
Schedule an idle context to block until timeouts expire without blocking further upcalls.
|
#
106191 |
|
30-Oct-2002 |
mini |
Use KSE to schedule threads.
|
#
103419 |
|
16-Sep-2002 |
mini |
Make libpthread KSE aware.
Reviewed by: deischen, julian Approved by: -arch
|
#
103388 |
|
16-Sep-2002 |
mini |
Make the changes needed for libpthread to compile in its new home. The new libpthread will provide POSIX threading support using KSE. These files were previously repo-copied from src/lib/libc_r.
Reviewed by: deischen Approved by: -arch
|
#
97204 |
|
24-May-2002 |
deischen |
Revamp suspend and resume. While I'm here add pthread_suspend_all_np() and pthread_resume_all_np(). These suspend and resume all threads except the current thread, respectively. The existing functions pthread_single_np() and pthread_multi_np(), which formerly had no effect, now exhibit the same behaviour and pthread_suspend_all_np() and pthread_resume_all_np(). These functions have been added mostly for the native java port.
Don't allow the uthread kernel pipe to use the same descriptors as stdio. Mostily submitted by Oswald Buddenhagen <ossi@kde.org>.
Correct some minor style nits.
|
#
96636 |
|
15-May-2002 |
alfred |
Undo namespace pollution by prefixing the globals pthread_guard_default and pthread_page_size.
Fix a bunch line wrapping.
Pointed out by: deischen
|
#
96501 |
|
13-May-2002 |
alfred |
Don't use PAGE_SIZE in userland, instead use getpagesize(), this is to allow running on other arches when the instructions are supported but the page size granularity is not.
Glanced at by: peter
|
#
92730 |
|
19-Mar-2002 |
deischen |
Add the ability to recognize old references to keys, and return NULL when old keys are referenced (after pthread_key_delete()) via pthread_getspecific().
|
#
90431 |
|
09-Feb-2002 |
deischen |
This has been sitting in my local tree long enough. Remove the use of an alternate signal stack for handling signals. Let the kernel send signals on the stack of the current thread and teach the threads signal handler how to deliver signals to the current thread if it needs to. Also, always store a threads context as a jmp_buf. Eventually this will change to be a ucontext_t or mcontext_t.
Other small nits. Use struct pthread * instead of pthread_t in internal library routines. The threads code wants struct pthread *, and pthread_t doesn't necessarily have to be the same.
Reviewed by: jasone
|
#
88092 |
|
18-Dec-2001 |
deischen |
Fix the retrieval of USRSTACK via sysctl so that it works for 64-bit archs. This should fix libc_r on alpha.
Submitted by: Bernd Walter <ticso@cicely9.cicely.de>
|
#
85567 |
|
26-Oct-2001 |
peter |
Make libc_r check the kern.usrstack sysctl instead of using internal kernel #defines to figure out where the stack is located. This stops libc_r from exploding when the kernel is compiled with a different KVM size. IMHO this is all kinda bogus, it would be better to just check %esp and work from that.
|
#
84768 |
|
10-Oct-2001 |
bde |
Compensate for "Compensate for header dethreading" by backing it out.
|
#
80021 |
|
20-Jul-2001 |
jasone |
Implement pthread_attr_[gs]etguardsize(). Non-default-size stacks used to be malloc()ed, but they are now allocated using mmap(), just as the default-size stacks are. A separate cache of stacks is kept for non-default-size stacks.
Collaboration with: deischen
|
#
76909 |
|
20-May-2001 |
jasone |
Instead of using a join queue for each thread, use a single pointer to keep track of a joiner. POSIX only supports a single joiner, so this simplification is acceptable.
At the same time, make sure to mark a joined thread as detached so that its resources can be freed.
Reviewed by: deischen PR: 24345
|
#
76179 |
|
01-May-2001 |
markm |
Compenate for header dethreading.
|
#
73056 |
|
25-Feb-2001 |
deischen |
Limit threads clock resolution to no less than 1000usec (1000Hz).
PR: 25300 Submitted by: Tom Pavel <pavel@alum.mit.edu> (in part)
|
#
71581 |
|
24-Jan-2001 |
deischen |
Add weak definitions for wrapped system calls. In general:
_foo - wrapped system call foo - weak definition to _foo
and for cancellation points:
_foo - wrapped system call __foo - enter cancellation point, call _foo(), leave cancellation point foo - weak definition to __foo
Change use of global _thread_run to call a function to get the currently running thread.
Make all pthread_foo functions weak definitions to _pthread_foo, where _pthread_foo is the implementation. This allows an application to provide its own pthread functions.
Provide slightly different versions of pthread_mutex_lock and pthread_mutex_init so that we can tell the difference between a libc mutex and an application mutex. Threads holding mutexes internal to libc should never be allowed to exit, call signal handlers, or cancel.
Approved by: -arch
|
#
70702 |
|
06-Jan-2001 |
obrien |
Force strong references to several pthread_* functions which are weakly referenced to by libgcc.a.
This is needed when linking statically as SVR4 (ie, ELF) behavior is to only link in a module if it satisfies an undefined strong reference from somewhere. (this surprises a lot of people) Things are different when using shared libs, the entire library and its modules and their symbols are available at run-time (when the weak reference is seen to still be unsatisfied and is satisfied on the spot), this is not the case with static libs.
Thus one can have a static binary with unresolved week references, and at run-time dereference a NULL pointer.
Submitted by: eischen
|
#
68726 |
|
14-Nov-2000 |
deischen |
When entering the scheduler from the signal handler, tell the kernel to (re)use the alternate signal stack. In this case, we don't return normally from the signal handler, so the kernel still thinks we are using the signal stack. The fixes a nasty bug where the signal handler can start fiddling with the stack of a thread while the handler is actually running on the same stack.
MFC candidate
|
#
68516 |
|
09-Nov-2000 |
deischen |
Don't needlessly poll file descriptors when there are no file descriptors needing to be polled (Doh!). Reported by Dan Nelson <dnelson@emsphone.com>.
Don't install and start the scheduling timer until the first thread is created. This prevents the overhead of having a periodic scheduling signal in a single threaded program. Reported by Dan Nelson <dnelson@emsphone.com>.
Allow builtin longjmps out of application installed signal handlers without the need perform any post-handler cleanup:
o Change signal handling to save the threads interrupted context on the stack. The threads current context is now always stored in the same place (in the pthread). If and when a signal handler returns, the interrupted context is copied back to the storage area in the pthread.
o Before calling invoking a signal handler for a thread, back the thread out of any internal waiting queues (mutex, CV, join, etc) to which it belongs.
Rework uthread_info.c a bit to make it easier to change the format of a thread dump.
Use an alternal signal stack for the thread library's signal handler. This allows us to fiddle with the main threads stack without fear of it being in use.
Reviewed by: jasone
|
#
67097 |
|
13-Oct-2000 |
deischen |
Implement zero system call thread switching. Performance of thread switches should be on par with that under scheduler activations.
o Timing is achieved through the use of a fixed interval timer (ITIMER_PROF) to count scheduling ticks instead of retrieving the time-of-day upon every thread switch and calculating elapsed real time.
o Polling for I/O readiness is performed once for each scheduling tick instead of every thread switch.
o The non-signal saving/restoring versions of setjmp/longjmp are used to save and restore thread contexts. This may allow the removal of _THREAD_SAFE macros from setjmp() and longjmp() - needs more investigation.
Change signal handling so that signals are handled in the context of the thread that is receiving the signal. When signals are dispatched to a thread, a special signal handling frame is created on top of the target threads stack. The frame contains the threads saved state information and a new context in which the thread can run. The applications signal handler is invoked through a wrapper routine that knows how to restore the threads saved state and unwind to previous frames.
Fix interruption of threads due to signals. Some states were being improperly interrupted while other states were not being interrupted. This should fix several PRs.
Signal handlers, which are invoked as a result of a process signal (not by pthread_kill()), are now called with the code (or siginfo_t if SA_SIGINFO was set in sa_flags) and sigcontext_t as received from the process signal handler.
Modify the search for a thread to which a signal is delivered. The search algorithm is now:
o First thread found in sigwait() with signal in wait mask. o First thread found sigsuspend()'d on the signal. o Current thread if signal is unmasked. o First thread found with signal unmasked.
Collapse machine dependent support into macros defined in pthread_private.h. These should probably eventually be moved into separate MD files.
Change the range of settable priorities to be compliant with POSIX (0-31). The threads library uses higher priorities internally for real-time threads (not yet implemented) and threads executing signal handlers. Real-time threads and threads running signal handlers add 64 and 32, respectively, to a threads base priority.
Some other small changes and cleanups.
PR: 17757 18559 21943 Reviewed by: jasone
|
#
62181 |
|
27-Jun-2000 |
jasone |
If multiple threads are blocked in sigwait() for the same signal that does not have a user-supplied signal handler, when a signal is delivered, one thread will receive the signal, and then the code reverts to having no signal handler for the signal. This can leave the other sigwait()ing threads stranded permanently if the signal is later ignored, or can result in process termination when the process should have delivered the signal to one of the threads in sigwait().
To fix this problem, maintain a count of sigwait()ers for each signal that has no default signal handler. Use the count to correctly install/uninstall dummy signal handlers.
Reviewed by: deischen
|
#
56277 |
|
19-Jan-2000 |
jasone |
Implement continuations to correctly handle [sig|_]longjmp() inside of a signal handler. Explicitly check for jumps to anywhere other than the current stack, since such jumps are undefined according to POSIX.
While we're at it, convert thread cancellation to use continuations, since it's cleaner than the original cancellation code.
Avoid delivering a signal to a thread twice. This was a pre-existing bug, but was likely unexposed until these other changes were made.
Defer signals generated by pthread_kill() so that they can be delivered on the appropriate stack. deischen claims that this is unnecessary, which is likely true, but without this change, pthread_kill() can cause undefined priority queue states and/or PANICs in [sig|_]longjmp(), so I'm leaving this in for now. To compile this code out and exercise the bug, define the _NO_UNDISPATCH cpp macro. Defining _PTHREADS_INVARIANTS as well will cause earlier crashes.
PR: kern/14685 Collaboration with: deischen
|
#
56236 |
|
18-Jan-2000 |
deischen |
Properly initialize the last active time of the initial thread. This fixes the case that a CPU hungry main thread is prevented from being preempted due to a negative calculation of its time slice.
Reported by: Alexander Litvin <archer@lucky.net>
|
#
55222 |
|
29-Dec-1999 |
jasone |
Don't explicitly mmap() red zones at the bottom of thread stacks (except the initial thread). Instead, just leave an unmapped gap between thread stacks and make sure that the thread stacks won't grow into these gaps, simply by limiting the size of the stacks with the 'len' argument to mmap(). This (if I understand correctly) reduces VM overhead considerably.
Reviewed by: deischen
|
#
55193 |
|
28-Dec-1999 |
deischen |
Change stack allocation algorithm to make better use of memory (it was leaving an unused block). Also protect the global stack pointer from context changes while fiddling with it.
|
#
53812 |
|
28-Nov-1999 |
alfred |
add pthread_cancel, obtained from OpenBSD.
eischen (Daniel Eischen) added wrappers to protect against cancled threads orphaning internal resources.
the cancelability code is still a bit fuzzy but works for test programs of my own, OpenBSD's and some examples from ORA's books.
add readdir_r to both libc and libc_r
add some 'const' attributes to function parameters
Reviewed by: eischen, jasone
|
#
50476 |
|
27-Aug-1999 |
peter |
$Id$ -> $FreeBSD$
|
#
49438 |
|
05-Aug-1999 |
deischen |
Fix thread initialization to allow for the case where stdio file descriptors are not opened.
PR: bin/12853 Reviewed by: jb
|
#
48784 |
|
12-Jul-1999 |
dt |
Use USRSTACK (defined in <machine/vmparam.h>) to get top of the initial stack. PTHREAD_STACK_TOP was wrong for all supported architectures.
|
#
48748 |
|
11-Jul-1999 |
jasone |
Modify previous changes to conform better to libc_r's coding style.
Always use mmap() for default-size stack allocation. Use MAP_ANON instead of MAP_STACK on the alpha architecture.
Reduce the amount of code executed while owning _gc_mutex during stack allocation.
|
#
48609 |
|
05-Jul-1999 |
jasone |
Always use growable thread stacks on the i386. The VM_STACK kernel option must be made default for the alpha before growable thread stacks are enabled for the alpha.
|
#
48569 |
|
04-Jul-1999 |
jasone |
Use growable stacks for thread stacks that are the default stack size.
Cache discarded default thread stacks for use in subsequent thread creations.
Create a red zone at the end of each stack (including the initial thread stack), with the hope of causing a segfault if a stack overflows.
To activate these modifications, add -D_PTHREAD_GSTACK to CFLAGS in src/lib/libc_r/Makefile. Since the modifications depend on the VM_STACK kernel option, I'm not sure how to safely use growable stacks by default.
Testing, as well as algorithmic and stylistic comments are welcome.
|
#
48140 |
|
23-Jun-1999 |
dt |
Fix few warnings on the alpha.
|
#
48046 |
|
20-Jun-1999 |
jb |
In the words of the author:
o The polling mechanism for I/O readiness was changed from select() to poll(). In additon, a wrapped version of poll() is now provided.
o The wrapped select routine now converts each fd_set to a poll array so that the thread scheduler doesn't have to perform a bitwise search for selected fds each time file descriptors are polled for I/O readiness.
o The thread scheduler was modified to use a new queue (_workq) for threads that need work. Threads waiting for I/O readiness and spinblocks are added to the work queue in addition to the waiting queue. This reduces the time spent forming/searching the array of file descriptors being polled.
o The waiting queue (_waitingq) is now maintained in order of thread wakeup time. This allows the thread scheduler to find the nearest wakeup time by looking at the first thread in the queue instead of searching the entire queue.
o Removed file descriptor locking for select/poll routines. An application should not rely on the threads library for providing this locking; if necessary, the application should use mutexes to protect selecting/polling of file descriptors.
o Retrieve and use the kernel clock rate/resolution at startup instead of hardcoding the clock resolution to 10 msec (tested with kernel running at 1000 HZ).
o All queues have been changed to use queue.h macros. These include the queues of all threads, dead threads, and threads waiting for file descriptor locks.
o Added reinitialization of the GC mutex and condition variable after a fork. Also prevented reallocation of the ready queue after a fork.
o Prevented the wrapped close routine from closing the thread kernel pipes.
o Initialized file descriptor table for stdio entries at thread init.
o Provided additional flags to indicate to what queues threads belong.
o Moved TAILQ initialization for statically allocated mutex and condition variables to after the spinlock.
o Added dispatching of signals to pthread_kill. Removing the dispatching of signals from thread activation broke sigsuspend when pthread_kill was used to send a signal to a thread.
o Temporarily set the state of a thread to PS_SUSPENDED when it is first created and placed in the list of threads so that it will not be accidentally scheduled before becoming a member of one of the scheduling queues.
o Change the signal handler to queue signals to the thread kernel pipe if the scheduling queues are protected. When scheduling queues are unprotected, signals are then dequeued and handled.
o Ensured that all installed signal handlers block the scheduling signal and that the scheduling signal handler blocks all other signals. This ensures that the signal handler is only interruptible for and by non-scheduling signals. An atomic lock is used to decide which instance of the signal handler will handle pending signals.
o Removed _lock_thread_list and _unlock_thread_list as they are no longer used to protect the thread list.
o Added missing RCS IDs to modified files.
o Added checks for appropriate queue membership and activity when adding, removing, and searching the scheduling queues. These checks add very little overhead and are enabled when compiled with _PTHREADS_INVARIANTS defined. Suggested and implemented by Tor Egge with some modification by me.
o Close a race condition in uthread_close. (Tor Egge)
o Protect the scheduling queues while modifying them in pthread_cond_signal and _thread_fd_unlock. (Tor Egge)
o Ensure that when a thread gets a mutex, the mutex is on that threads list of owned mutexes. (Tor Egge)
o Set the kernel-in-scheduler flag in _thread_kern_sched_state and _thread_kern_sched_state_unlock to prevent a scheduling signal from calling the scheduler again. (Tor Egge)
o Don't use TAILQ_FOREACH macro while searching the waiting queue for threads in a sigwait state, because a change of state destroys the TAILQ link. It is actually safe to do so, though, because once a sigwaiting thread is found, the loop ends and the function returns. (Tor Egge)
o When dispatching signals to threads, make the thread inherit the signal deferral flag of the currently running thread. (Tor Egge)
Submitted by: Daniel Eischen <eischen@vigrid.com> and Tor Egge <Tor.Egge@fast.no>
|
#
44963 |
|
23-Mar-1999 |
jb |
[ The author's description... ]
o Runnable threads are now maintained in priority queues. The implementation requires two things:
1.) The priority queues must be protected during insertion and removal of threads. Since the kernel scheduler must modify the priority queues, a spinlock for protection cannot be used. The functions _thread_kern_sched_defer() and _thread_kern_sched_undefer() were added to {un}defer kernel scheduler activation.
2.) A thread (active) priority change can be performed only when the thread is removed from the priority queue. The implementation uses a threads active priority when inserting it into the queue.
A by-product is that thread switches are much faster. A separate queue is used for waiting and/or blocked threads, and it is searched at most 2 times in the kernel scheduler when there are active threads. It should be possible to reduce this to once by combining polling of threads waiting on I/O with the loop that looks for timed out threads and the minimum timeout value.
o Functions to defer kernel scheduler activation were added. These are _thread_kern_sched_defer() and _thread_kern_sched_undefer() and may be called recursively. These routines do not block the scheduling signal, but latch its occurrence. The signal handler will not call the kernel scheduler when the running thread has deferred scheduling, but it will be called when running thread undefers scheduling.
o Added support for _POSIX_THREAD_PRIORITY_SCHEDULING. All the POSIX routines required by this should now be implemented. One note, SCHED_OTHER, SCHED_FIFO, and SCHED_RR are required to be defined by including pthread.h. These defines are currently in sched.h. I modified pthread.h to include sched.h but don't know if this is the proper thing to do.
o Added support for priority protection and inheritence mutexes. This allows definition of _POSIX_THREAD_PRIO_PROTECT and _POSIX_THREAD_PRIO_INHERIT.
o Added additional error checks required by POSIX for mutexes and condition variables.
o Provided a wrapper for sigpending which is marked as a hidden syscall.
o Added a non-portable function as a debugging aid to allow an application to monitor thread context switches. An application can install a routine that gets called everytime a thread (explicitly created by the application) gets context switched. The routine gets passed the pthread IDs of the threads that are being switched in and out.
Submitted by: Dan Eischen <eischen@vigrid.com>
Changes by me:
o Added a PS_SPINBLOCK state to deal with the priority inversion problem most often (I think) seen by threads calling malloc/free/realloc.
o Dispatch signals to the running thread directly rather than at a context switch to avoid the situation where the switch never occurs.
|
#
39807 |
|
30-Sep-1998 |
jb |
Move the cleanup code that frees memory allocated for a dead thread from the thread kernel into a garbage collector thread which is started when the fisrt thread is created (other than the initial thread). This removes the window of opportunity where a context switch will cause a thread that has locked the malloc spinlock, to enter the thread kernel, find there is a dead thread and try to free memory, therefore trying to lock the malloc spinlock against itself.
The garbage collector thread acts just like any other thread, so instead of having a spinlock to control accesses to the dead thread list, it uses a mutex and a condition variable so that it can happily wait to be signalled when a thread exists.
|
#
38208 |
|
09-Aug-1998 |
jb |
Add extra initialisation code that is required for processes that are started instead of init (pid = 1). This allows an embedded implementation quite like VxWorks, with (possibly) a single threaded program running instead of init. The neat thing is that the same threaded process can run in a multi-user workstation environment too.
|
#
35509 |
|
29-Apr-1998 |
jb |
Change signal model to match POSIX (i.e. one set of signal handlers for the process, not a separate set for each thread). By default, the process now only has signal handlers installed for SIGVTALRM, SIGINFO and SIGCHLD. The thread kernel signal handler is installed for other signals on demand. This means that SIG_IGN and SIG_DFL processing is now left to the kernel, not the thread kernel.
Change the signal dispatch to no longer use a signal thread, and call the signal handler using the stack of the thread that has the signal pending.
Change the atomic lock method to use test-and-set asm code with a yield if blocked. This introduces separate locks for each type of object instead of blocking signals to prevent a context switch. It was this blocking of signals that caused the performance degradation the people have noted.
This is a *big* change!
|
#
33292 |
|
12-Feb-1998 |
julian |
Fixes from Jeremy Allison and Terry Lambert for pthreads:
specifically: uthread_accept.c: Fix for inherited socket not getting correct entry in pthread flags. uthread_create.c: Fix to allow pthread_t pointer return to be null if caller doesn't care about return. uthread_fd.c: Fix for return codes to be placed into correct errno. uthread_init.c: Changes to make gcc-2.8 thread aware for exception stack frames (WARNING: This is #ifdef'ed out by default and is different from the Cygnus egcs fix). uthread_ioctl.c: Fix for blocking/non-blocking ioctl. uthread_kern.c: Signal handling fixes (only one case left to fix, that of an externally sent SIGSEGV and friends - a fairly unusual case). uthread_write.c: Fix for lock of fd - ask for write lock, not read/write. uthread_writev.c: Fix for lock of fd - ask for write lock, not read/write.
Pthreads now works well enough to run the LDAP and ACAPD(with the gcc 2.8 fix) sample implementations.
|
#
25795 |
|
13-May-1997 |
alex |
Fixed overallocation of _thread_fd_table.
PR: 3494 Submitted by: Steve Bauer <sbauer@rock.sdsmt.edu>
|
#
22315 |
|
05-Feb-1997 |
julian |
Submitted by: John Birrell uthreads update from the author.
|
#
17706 |
|
20-Aug-1996 |
julian |
Submitted by: John Birrell <cimaxp1!jb@werple.net.au>
Here are the diffs for libc_r to get it one step closer to P1003.1c These make most of the thread/mutex/condvar structures opaque to the user. There are three functions which have been renamed with _np suffixes because they are extensions to P1003.1c (I did them for JAVA, which needs to suspend/resume threads and also start threads suspended).
I've created a new header (pthread_np.h) for the non-POSIX stuff.
The egrep tags stuff in /usr/src/lib/libc_r/Makefile that I uncommented doesn't work. I think its best to delete it. I don't think libc_r needs tags anyway, 'cause most of the source is in libc which does have tags.
also:
Here's the first batch of man pages for the thread functions. The diff to /usr/src/lib/libc_r/Makefile removes some stuff that was inherited from /usr/src/lib/libc/Makefile that should only be done with libc.
also:
I should have sent this diff with the pthread(3) man page. It allows people to type
make -DWANT_LIBC_R world
to get libc_r built with the rest of the world. I put this in the pthread(3) man page. The default is still not to build libc_r.
also: The diff attached adds a pthread(3) man page to /usr/src/share/man/man3. The idea is that without libc_r installed, this man page will give people enough info to know that they have to build libc_r.
|
#
14117 |
|
17-Feb-1996 |
jdp |
Added a new module "uthread_autoinit.cc". This is a small C++ module. It uses a static constructor to call _thread_init() at program start-up time. That eliminates the need for any initialization hooks in crt0.o.
Added a symbol reference in "uthread_init.c", to ensure that the new module will always be pulled in when the archive version of the library is used.
In "Makefile.inc", defined CPLUSPLUSLIB, so that the constructor will be properly invoked in the shared library.
Suggested by: Christopher Provenzano, Peter Wemm, and others.
|
#
13546 |
|
21-Jan-1996 |
julian |
Reviewed by: julian Submitted by: john birrel
One version of the pthreads library another will follow with differnt actions under some cases.. not QUITE complete
|