History log of /freebsd-11.0-release/usr.sbin/ctld/login.c
Revision Date Author Comments
(<<< Hide modified files)
(Show modified files >>>)
# 303975 11-Aug-2016 gjb

Copy stable/11@r303970 to releng/11.0 as part of the 11.0-RELEASE
cycle.

Prune svn:mergeinfo from the new branch, and rename it to RC1.

Update __FreeBSD_version.

Use the quarterly branch for the default FreeBSD.conf pkg(8) repo and
the dvd1.iso packages population.

Approved by: re (implicit)
Sponsored by: The FreeBSD Foundation

# 303311 25-Jul-2016 np

MFC r303199:

ctld(8): Fix MaxBurstLength negotiation.

The target must reply with the selected value of MaxBurstSize instead of
just echoing back the initiator's offered value.

Reviewed by: mav@
Approved by: re@ (gjb@)
Sponsored by: Chelsio Communications
Differential Revision: https://reviews.freebsd.org/D7278


# 302408 08-Jul-2016 gjb

Copy head@r302406 to stable/11 as part of the 11.0-RELEASE cycle.
Prune svn:mergeinfo from the new branch, as nothing has been merged
here.

Additional commits post-branch will follow.

Approved by: re (implicit)
Sponsored by: The FreeBSD Foundation


# 301720 09-Jun-2016 trasz

Don't cap FirstBurstLength to maximum MaxRecvDataSegmentLength claimed
by the offload driver; there is no reason to do so, and it actually
harms performance.

MFC after: 1 month


# 301437 05-Jun-2016 trasz

Report negotiated MaxBurstLength and FirstBurstLength in "iscsictl -v"
and "ctladm islist -v" outputs.

MFC after: 1 month


# 299894 16-May-2016 truckman

pdu_delete(request) frees request, so move the call after
login_new_response(request) to avoid a use-after-free error

Reported by: Coverity
Reviewed by: 1331219, 1331220


# 295562 12-Feb-2016 mav

Don't check CmdSN for initial login request.

This fixes connection errors for some initiators not starting CmdSN
from zero.

While there, fix wrong status details reported for couple errors.

MFC after: 3 days


# 287766 13-Sep-2015 mav

Add negotiation of iSCSIProtocolLevel to 2 (RFC7144).

We may need to pass negotiated value to kernel level, but so far it is
not necessary, since it does not use any new features without request.


# 286462 08-Aug-2015 mav

Refactor early stages of security negotiation.

MFC after: 2 weeks


# 286456 08-Aug-2015 mav

Remove some code duplication.

MFC after: 1 week


# 283898 02-Jun-2015 mav

Fix bug in r278331: unlike some other options MaxRecvDataSegmentLength
is not negotiated as minimum, but only reported by sides to each other.

MFC after: 1 week


# 282086 27-Apr-2015 trasz

Make setproctitle(3) work in Capsicum capability mode. This makes
ctld(8) child processes to indicate initiator address and name in
their titles, similar to what iscsid(8) child processes do.

PR: 181352
Differential Revision: https://reviews.freebsd.org/D2363
Reviewed by: rwatson@, mjg@
MFC after: 1 month
Sponsored by: The FreeBSD Foundation


# 281532 14-Apr-2015 delphij

Eliminate unused headers.


# 279392 28-Feb-2015 trasz

Move the "offload" clause from the target section to portal-group
section; it makes more sense there.

MFC after: 1 month
Sponsored by: The FreeBSD Foundation


# 278331 06-Feb-2015 trasz

Make it possible to set (via ctl.conf(5)) and query (via ctladm islist -v)
target iSCSI offload. Add mechanism to query maximum receive data segment
size supported by chosen hardware offload module, and use it in ctld(8)
to determine the value to advertise to the other side.

MFC after: 1 month
Sponsored by: The FreeBSD Foundation


# 278322 06-Feb-2015 mav

Add support for multiple portal groups per target.

This change allows multiple "portal-group" options to be specified per
target. Each of them may include new optional auth-group name parameter
to override per-target auth parameters for specific portal group.

Kernel side support was added earlier at r278161.

MFC after: 2 weeks
Sponsored by: iXsystems, Inc.


# 275925 19-Dec-2014 mav

Slightly polish iSCSI parameters negotiation.

MFC after: 1 week


# 275864 17-Dec-2014 mav

Make sequence numbers checks more strict.

While we don't support MCS, hole in received sequence numbers may mean
only PDU loss. While we don't support lost PDU recovery, terminate the
connection to avoid stuck commands.

While there, improve handling of sequence numbers wrap after 2^32 PDUs.

MFC after: 2 weeks


# 274309 09-Nov-2014 trasz

Fix several nits in redirection handling - don't use wrong CSG,
and avoid use-after-free.

MFC after: 1 month
Sponsored by: The FreeBSD Foundation


# 274308 09-Nov-2014 trasz

Add support for sending redirections to iSCSI target.

MFC after: 1 month
Sponsored by: The FreeBSD Foundation


# 273813 29-Oct-2014 trasz

Add discovery-filter. This makes it possible to restrict which targets
are returned during discovery based on initiator portal, name, and CHAP
credentials.

Reviewed by: mav@
MFC after: 1 month
Sponsored by: The FreeBSD Foundation


# 273584 24-Oct-2014 trasz

Make the initiator-name and initiator-portal checks a little nicer.

MFC after: 1 month
Sponsored by: The FreeBSD Foundation


# 273583 24-Oct-2014 trasz

Tidy up the login code; no functional changes.

MFC after: 1 month
Sponsored by: The FreeBSD Foundation


# 273464 22-Oct-2014 trasz

Whitespace fixes.

MFC after: 1 month
Sponsored by: The FreeBSD Foundation


# 273459 22-Oct-2014 trasz

Untangle iSCSI authentication code by splitting off the CHAP
implementation.

Reviewed by: mav@
MFC after: 1 month
Sponsored by: The FreeBSD Foundation


# 271320 09-Sep-2014 trasz

Use keys_add_int() where appropriate. No functional changes.

Sponsored by: The FreeBSD Foundation


# 271319 09-Sep-2014 trasz

Fix ctld(8) to not forget to send TargetPortalGroupTag and TargetAlias
when the initiator skips security negotiation. This fixes interoperability
with Xtend SAN initiator.

PR: 193021
MFC after: 1 week
Sponsored by: The FreeBSD Foundation


# 271157 05-Sep-2014 trasz

Fix typo.

MFC after: 2 weeks
Sponsored by: The FreeBSD Foundation


# 270279 21-Aug-2014 trasz

Make the iSCSI stack use __FBSDID() properly.

MFC after: 2 weeks
Sponsored by: The FreeBSD Foundation


# 269183 28-Jul-2014 mav

Add netmasks support to initiator-portal option.

MFC after: 2 weeks


# 268302 05-Jul-2014 mav

Pass through iSCSI session ISID from LOGIN request to the CTL frontend.

ISID is an important part of initiator transport ID for iSCSI. It is not
used now, but should be to properly implement persistent reservation.


# 264532 16-Apr-2014 trasz

Use proper terminology in debug messages.

Sponsored by: The FreeBSD Foundation


# 263356 19-Mar-2014 trasz

Make the error message more clear.

Sponsored by: The FreeBSD Foundation


# 261763 11-Feb-2014 trasz

Use new auth-type "deny" instead of using "chap" with no chap entries;
it's cleaner this way, and gives better feedback to the user.

Sponsored by: The FreeBSD Foundation


# 261757 11-Feb-2014 trasz

Rename a variable, no functional changes.

Sponsored by: The FreeBSD Foundation


# 261754 11-Feb-2014 trasz

Implement initiator-name and initiator-portal restrictions.

Sponsored by: The FreeBSD Foundation


# 261752 11-Feb-2014 trasz

Empty data segment during Login Phase is rather unlikely, but it's
not, by itself, a protocol error. This fixes interoperability with
OpenBSD initiator.

Sponsored by: The FreeBSD Foundation


# 259182 10-Dec-2013 trasz

Fix handling for empty auth-groups. Without it, ctld child process
would either exit on assertion, or, if assertions are not enabled,
fail to authenticate the target.

MFC after: 2 days
Sponsored by: The FreeBSD Foundation


# 256192 09-Oct-2013 trasz

Plug memory leaks.

Coverity CID: 1087993, 1087992
Approved by: re (marius)
Sponsored by: FreeBSD Foundation


# 255570 14-Sep-2013 trasz

Bring in the new iSCSI target and initiator.

Reviewed by: ken (parts)
Approved by: re (delphij)
Sponsored by: FreeBSD Foundation